#52: Crash: #get_frame didn't change the buffer
-------------------------+--------------------------------------------------
Reporter: toots | Owner: toots
Type: Bugs | Status: assigned
Priority: 6 | Milestone:
Component: Liquidsoap | Version: 0.3.4
Resolution: | Keywords:
-------------------------+--------------------------------------------------
Comment (by toots):
I agree that we ought to look at smartcross for an issue there. Notice
that the issue happens not only when buffering. I don't know how
smart_cross works but I would expect it just relays get_frame in this
situation (though it doesn't crash without it..)
However, besides your argumentation, to which I agree, there are two
details I'd like to stress:
* The remaining val is set to 0 when track has finished, and -1 when a
track has been loaded. I would better set it to -1 when there are no
tracks ready, as your comment on smart says:
{{{
(* TODO 0 is often answered just before the beginning of a track
* I'd prefer -1 if possible. Otherwise add more info in the state.
* Or simply don't bother about that harmless transition. *)
}}}
* Although it's important to maintain strong constrains on the behaviour,
I'm not sure we need to have failures in every case. It could also be that
get_frame never fails in any case, but it logs a big warning when it is
called while is_ready is false..
However, we still need to fix the bug in smart :)
--
Ticket URL: <http://savonet.rastageeks.org/ticket/52#comment:9>
Savonet <http://savonet.rastageeks.org/>
Let's program our stream !
