Hi John,

The PR for the crossfade rewrite is pending here:
https://github.com/savonet/liquidsoap/pull/705

I'm a bit reluctant to merge it right away because it's a significant chunk
of change and I haven't played with it for a while. However, last I checked
it was looking pretty good.

Perhaps you could give it a try? Essentially, the only thing you should
have to change is that the simple `crossfade` is removed and
`smart_crossfade` is renamed `crossfade`.

Romain

Le jeu. 7 mars 2019 à 04:28, John Warburton <j...@johnwarburton.net> a
écrit :

> Good morning,
>
> While running the latest dev master, cross-fading using the "crossfade"
> operator has stopped after about six days' operation. Now, Romain, I
> remember you were re-implementing this operator, and had already changed
> something. Should I change one of my commands, also?
>
> A transition normally looks like this in the log:
>
> 2019/03/07 05:15:42 [test-18feb-shuf(dot)m3u8:4] Remaining: -0.1s, queued:
> 0.0s, adding: 147.4s (RID 1)
> 2019/03/07 05:15:42 [buffer_25567:4] End of track.
> 2019/03/07 05:15:42 [buffer_25567:4] Buffer emptied, buffering needed.
> 2019/03/07 05:15:48 [cross_10436:4] Buffering end of track...
> 2019/03/07 05:15:48 [source:4] Garbage collected empty_25566.
> 2019/03/07 05:15:48 [source:4] Garbage collected add_25557.
> 2019/03/07 05:15:48 [source:4] Garbage collected buffer_25556.
> 2019/03/07 05:15:48 [cross_10436:4] More buffering will be needed.
> 2019/03/07 05:18:22 [decoder:4] Decoding "/home/john/src/radio/mez/24
> Anywhere.QfYCLC.mka" ended: Ffmpeg_decoder.End_of_file.
> 2019/03/07 05:18:22 [fade(dot)in:4] Fading out with 0.0s remaining..
> 2019/03/07 05:18:22 [test-18feb-shuf(dot)m3u8:3] Finished with
> "/home/john/src/radio/mez/24 Anywhere.QfYCLC.mka".
> 2019/03/07 05:18:22 [amplify_10424:3] End of the current overriding.
> 2019/03/07 05:18:22 [test-18feb-shuf(dot)m3u8:4] Remaining: 0.0s, queued:
> 147.4s, taking: 147.4s
> 2019/03/07 05:18:22 [test-18feb-shuf(dot)m3u8:3] Prepared
> "/home/john/src/radio/mez/Wheels_Go_Round_DWMIL_009_trk_1700.TovbhY.mka"
> (RID 1).
> 2019/03/07 05:18:22 [source:4] Source add_25576 gets up.
> 2019/03/07 05:18:22 [add_25576:4] Content kind is {audio=2;video=0;midi=0}.
> 2019/03/07 05:18:22 [fade(dot)out:4] Activations changed:
> static=[add_25576:cross_10436, add_25568:cross_10436],
> dynamic=[cross_10436].
> 2019/03/07 05:18:22 [fade(dot)out:4] Enabling caching mode: two static
> activations.
> 2019/03/07 05:18:22 [source:4] Source buffer_25575 gets up.
> 2019/03/07 05:18:22 [buffer_25575:4] Content kind is
> {audio=2;video=0;midi=0}.
> 2019/03/07 05:18:22 [buffer_25575:4] Activations changed:
> static=[add_25576:cross_10436], dynamic=[].
> 2019/03/07 05:18:22 [add_25576:4] Activations changed:
> static=[cross_10436], dynamic=[].
> 2019/03/07 05:18:22 [add_25568:4] Activations changed: static=[],
> dynamic=[].
> 2019/03/07 05:18:22 [source:4] Source add_25568 gets down.
> 2019/03/07 05:18:22 [fade(dot)out:4] Activations changed:
> static=[add_25576:cross_10436], dynamic=[cross_10436].
> 2019/03/07 05:18:22 [fade(dot)out:4] Disabling caching mode.
> 2019/03/07 05:18:22 [buffer_25567:4] Activations changed: static=[],
> dynamic=[].
> 2019/03/07 05:18:22 [source:4] Source buffer_25567 gets down.
> 2019/03/07 05:18:22 [cue_cut_10420:3] Cueing in...
>
> After the failure, the transition is reduced to this:
>
> 2019/03/07 05:28:14 [test-18feb-shuf(dot)m3u8:4] Remaining: 0.0s, queued:
> 0.0s, adding: 61.9s (RID 6)
> 2019/03/07 05:28:16 [source:4] Garbage collected empty_25598.
> 2019/03/07 05:31:06 [decoder:4] Decoding "/home/john/src/radio/mez/1-18
> It's Your Thing.IPbAXh.mka" ended: Ffmpeg_decoder.End_of_file.
> 2019/03/07 05:31:07 [test-18feb-shuf(dot)m3u8:3] Finished with
> "/home/john/src/radio/mez/1-18 It's Your Thing.IPbAXh.mka".
> 2019/03/07 05:31:07 [amplify_10424:3] End of the current overriding.
> 2019/03/07 05:31:07 [test-18feb-shuf(dot)m3u8:4] Remaining: 0.0s, queued:
> 61.9s, taking: 61.9s
> 2019/03/07 05:31:07 [test-18feb-shuf(dot)m3u8:3] Prepared
> "/home/john/src/radio/mez/3. Buddy Baker - Sign Song.sHmcqk.mka" (RID 6).
> 2019/03/07 05:31:07 [amplify_10424:3] Overriding amplification: 0.812831.
> 2019/03/07 05:31:07 [fallback_10427:4] Fading in..
> 2019/03/07 05:31:07 [decoder:2] Cannot find decoder FLAC
> 2019/03/07 05:31:07 [fade(dot)in:4] Fading out with 0.0s remaining..
>
> Everything to do with buffers (e.g. the "End of track" note and everything
> else) stops appearing.
>
> Is it possible that I need to change the "crossfade()" statement to work
> better with the dev version? If so, I'll gladly have a go.
>
> with best wishes,
> JW
> _______________________________________________
> Savonet-users mailing list
> Savonet-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/savonet-users
>
_______________________________________________
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users

Reply via email to