2009/2/19 Joost ´t Hart <[email protected]>
>
> The duration of the correction phase depends on the number of
> corrections only (which is easily understood by the user as he has given
> them 'a go' himself) and is as far as I have noticed reasonably mild.
> Besides, it shows a progress bar.
When using the command
File -> Maintenance -> Name spelling -> Spellcheck players names
Scid's UI is frozen for a while, and I see no progress bar.
Which is normal given that function sc_name_spellcheck in file tkscid.cpp
does not call any update to a progress bar.
>
> The time taken for the investigation (only!) depends on the number of
> player names in the dBase and the size of the ssp file. Reason: The
> investigation is not stopped at 'MaxCorrections'.
For me it is : after MaxCorrections is reached, most code is not executed.
> It continues after
> that without side effects with the only goal to present the total number
> corrections to make "of which the first MaxCorrections are listed
> below."
>
> So it is either
> a) a configurable quicker scan, without knowing what is at stake beyond,
> or
> b) a full scan, taking some time
>
> The in-between solution with some (fixed) number of corrections as we
> currently have it is the worst of both worlds. The investigation takes
> the same time, but you have to do it multiple (and sometimes even many)
> times.
>
> My patch follows approach (b).
>
> There is something to say for (a) as well.
>
> [Q] Do you a (all) agree that having a configurable limitation implies
> approach (b) for "infinite" and (a) for the other options? That is, in
> the latter case the user is NOT informed on the status/progress of the
> spell checking for the current base-as-a-whole.
I don't see what prevents status update (at least a progress bar).
As I wrote, why not simply use a configurable threshold, the latest value
for MaxCorrections being "infinite" ?
[...]
[Q] Dunno if you got the chance to notice this, but the Chess Assistant
> guys follow the approach to explicitly add a player's country (FIDE
> style) to the name in a pair of ()'s. In the game list this country part
> is stripped off.
This is not in PGN standard, so should be avoided.
[...]
But as I said I am not an user of spell checking features in Scid. So
certainly others would do a better job at discussing specifications.
Pascal
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Scid-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scid-users
