Hi Pascal, I see I need just a little bit more patience :-)
The switch - if defined, of course (!) - does exactly what it says: It makes scid bail out after it has found maxCorrections. This saves time. This means that it handles issue (2) from my previous posting. So, indeed my proposal is in line with your statement below, _PLUS_ / _BUT_ I suggest NOT to use the maxCorrections option from the tcl layer at all. It is good to leave the C-code for this feature in there (we have it anyway), but I suggest not to use it, as it makes no sense (issue (1)). It seems this is the final thing we need to agree on. After this I am perfectly happy to resend a complete patch to be included in some release candidate. You can be sure that I (white-box-) tested a lot of different (dbase) use cases, but 1) developers should not be testers 2) I build and test only on Linux. I have a windoze XP PC as well, but no clue how to build for it So it is certainly better if someone else is willing to conduct some testing indeed. Cheers, Joost. On Mon, 2009-03-02 at 13:12 +0100, Pascal Georges wrote: > Thanks for your patience and your explanation. What I see : > > 1. The define is useless. I was mislead by your default > #undef BAIL_OUT_AFTER_MAXCORRECTIONS > > where > > #define BAIL_OUT_AFTER_MAXCORRECTIONS > > gives far better result, and I don't see much drawbacks using this one > (or did I miss something ?). > > So I agree with your conclusions (provided that you also think the > compiler switch should be the #define above) : could you post an > updated patch ? > Are there some users willing to test this ? My own tests are very > partial as, again, I am not a big user of name checking. > > Pascal > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ Scid-users mailing list > Scid-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/scid-users ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Scid-users mailing list Scid-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scid-users
