Hi,
I tried your patch and I am not sure if it completely achieves its goal
(again I am not an expert in spell checking ...). What I understood is that
when checking players' names, a limited list of corrections is displayed.
After applying the proposed 2000 corrections, some will be displayed again
(those that could not be commited due certainly to date inconsistencies).
But then what should the user do in order to apply all corrections, not only
the first thousands ?
The advantage of your patch is Scid's UI does no longer look frozen when it
parses the names, but pressing "make corrections" leads to the same previous
problem. Unchecking "ambiguous" helps but it remains an iterative process
where skipped names are presented again and again.
Imagine 2000 names are proposed with date incoherencies : the next names
will never be displayed to the user (I don't know if that case can really
happen). A workaround could be :
First pass : presented players from Aaron to Karpov
Second pass : start at Karpov,
etc.
So do I miss something ? Is it ok to leave things like that ?
Another point : I would not use a define like BAIL_OUT_AFTER_MAXCORRECTIONS
in your code. It makes things flexible, but 99,9% of users will not be able
to use it. So either it is useful and it should be made available to the
user, either it is useless (which I doubt), and then it should be removed.
Pascal
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Scid-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scid-users
