[PATCH 2/3] ARM: socfpga: clock-manager: fix Wmissing-prototypes
Fix the warning arch/arm/mach-socfpga/arria10-clock-manager.c:113:14: warning: no previous prototype for 'arria10_cm_get_mmc_controller_clk_hz' [-Wmissing-prototypes] 113 | unsigned int arria10_cm_get_mmc_controller_clk_hz(void) | ^~~~ Signed-off-by: Steffen Trumtrar --- arch/arm/mach-socfpga/include/mach/arria10-clock-manager.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-socfpga/include/mach/arria10-clock-manager.h b/arch/arm/mach-socfpga/include/mach/arria10-clock-manager.h index ee2b9b3c5ec1..c0a57439af0d 100644 --- a/arch/arm/mach-socfpga/include/mach/arria10-clock-manager.h +++ b/arch/arm/mach-socfpga/include/mach/arria10-clock-manager.h @@ -128,6 +128,7 @@ struct arria10_perpll_cfg { extern int arria10_cm_basic_init(struct arria10_mainpll_cfg *mainpll_cfg, struct arria10_perpll_cfg *perpll_cfg); +unsigned int arria10_cm_get_mmc_controller_clk_hz(void); extern unsigned int cm_get_mmc_controller_clk_hz(void); extern void arria10_cm_use_intosc(void); extern uint32_t cm_l4_main_clk_hz; -- 2.23.0 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH 3/3] ARM: socfpga: arria10-xload: fix Wmissing-prototypes
Fix the warning: arch/arm/mach-socfpga/arria10-xload.c:17:5: warning: no previous prototype for 'a10_update_bits' [-Wmissing-prototypes] 17 | int a10_update_bits(unsigned int reg, unsigned int mask, | ^~~ Signed-off-by: Steffen Trumtrar --- arch/arm/mach-socfpga/include/mach/arria10-xload.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-socfpga/include/mach/arria10-xload.h b/arch/arm/mach-socfpga/include/mach/arria10-xload.h index 71f839736230..7575231bbf34 100644 --- a/arch/arm/mach-socfpga/include/mach/arria10-xload.h +++ b/arch/arm/mach-socfpga/include/mach/arria10-xload.h @@ -4,6 +4,7 @@ void arria10_init_mmc(void); int arria10_prepare_mmc(int barebox_part, int rbf_part); int arria10_read_blocks(void *dst, int blocknum, size_t len); +int a10_update_bits(unsigned int reg, unsigned int mask, unsigned int val); struct partition { uint64_t first_sec; -- 2.23.0 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH 1/3] ARM: socfpga: reset-manager: fix Wmissing-prototypes
Fix the following warnings arch/arm/mach-socfpga/arria10-reset-manager.c:152:6: warning: no previous prototype for 'arria10_reset_deassert_shared_peripherals_q1' [-Wmissing-prototypes] 152 | void arria10_reset_deassert_shared_peripherals_q1(uint32_t *mask0, | ^~~~ arch/arm/mach-socfpga/arria10-reset-manager.c:226:6: warning: no previous prototype for 'arria10_reset_deassert_shared_peripherals_q2' [-Wmissing-prototypes] 226 | void arria10_reset_deassert_shared_peripherals_q2(uint32_t *mask0, | ^~~~ arch/arm/mach-socfpga/arria10-reset-manager.c:272:6: warning: no previous prototype for 'arria10_reset_deassert_shared_peripherals_q3' [-Wmissing-prototypes] 272 | void arria10_reset_deassert_shared_peripherals_q3(uint32_t *mask0, | ^~~~ arch/arm/mach-socfpga/arria10-reset-manager.c:329:6: warning: no previous prototype for 'arria10_reset_deassert_shared_peripherals_q4' [-Wmissing-prototypes] 329 | void arria10_reset_deassert_shared_peripherals_q4(uint32_t *mask0, uint32_t *mask1) | ^~~~ Signed-off-by: Steffen Trumtrar --- arch/arm/mach-socfpga/include/mach/arria10-reset-manager.h | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/mach-socfpga/include/mach/arria10-reset-manager.h b/arch/arm/mach-socfpga/include/mach/arria10-reset-manager.h index ebd20434263a..2033de77a39f 100644 --- a/arch/arm/mach-socfpga/include/mach/arria10-reset-manager.h +++ b/arch/arm/mach-socfpga/include/mach/arria10-reset-manager.h @@ -108,6 +108,10 @@ void arria10_reset_peripherals(void); void arria10_reset_deassert_dedicated_peripherals(void); void arria10_reset_deassert_shared_peripherals(void); +void arria10_reset_deassert_shared_peripherals_q1(uint32_t *mask0, uint32_t *mask1); +void arria10_reset_deassert_shared_peripherals_q2(uint32_t *mask0, uint32_t *mask1); +void arria10_reset_deassert_shared_peripherals_q3(uint32_t *mask0, uint32_t *mask1); +void arria10_reset_deassert_shared_peripherals_q4(uint32_t *mask0, uint32_t *mask1); void arria10_reset_deassert_fpga_peripherals(void); #endif -- 2.23.0 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] cp: complete command help
Signed-off-by: Robert Karszniewicz --- commands/cp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/commands/cp.c b/commands/cp.c index 54934dd..845dae6 100644 --- a/commands/cp.c +++ b/commands/cp.c @@ -100,13 +100,14 @@ BAREBOX_CMD_HELP_START(cp) BAREBOX_CMD_HELP_TEXT("Copy file from SRC to DEST.") BAREBOX_CMD_HELP_TEXT("") BAREBOX_CMD_HELP_TEXT("Options:") +BAREBOX_CMD_HELP_OPT ("-r", "recursive") BAREBOX_CMD_HELP_OPT ("-v", "verbose") BAREBOX_CMD_HELP_END BAREBOX_CMD_START(cp) .cmd= do_cp, BAREBOX_CMD_DESC("copy files") - BAREBOX_CMD_OPTS("[-v] SRC DEST") + BAREBOX_CMD_OPTS("[-rv] SRC DEST") BAREBOX_CMD_GROUP(CMD_GRP_FILE) BAREBOX_CMD_HELP(cmd_cp_help) BAREBOX_CMD_END -- 2.7.4 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH v4] readline: make ctrl-u to work like linux console
From: DU HUANPENG currtly, the ctrl-u discards the whole line, in most linux boxes, ctrl-u just erase characters before cursor to the begginning of the line. this patch make ctrl-u to do this. Signed-off-by: DU HUANPENG --- lib/readline.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/readline.c b/lib/readline.c index d026af1..3d16c18 100644 --- a/lib/readline.c +++ b/lib/readline.c @@ -290,9 +290,17 @@ int readline(const char *prompt, char *buf, int len) insert = !insert; break; case BB_KEY_ERASE_LINE: + BEGINNING_OF_LINE(); + ERASE_TO_EOL(); + break; case CTL_CH('u'): + wlen = eol_num - num; + memmove(buf, buf+num, wlen); BEGINNING_OF_LINE(); ERASE_TO_EOL(); + eol_num = wlen; + REFRESH_TO_EOL(); + BEGINNING_OF_LINE(); break; case DEL: case BB_KEY_DEL7: -- 2.7.4 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: readling, ctrl-u is not working like linux console
> > In some shells, like mksh, the default behaviour of ctrl-u is to kill the > whole line. But then it's not called unix-line-discard, and I don't think > mksh uses readline, either. The "standard" is probably just readline, though > it makes me wonder where the "unix" came from… Hi, to avoid run into this issues: > The program in a Unix-like system that allocates machine resources and talks > to the hardware is called the “kernel”. GNU is typically used with a kernel > called Linux. This combination is the GNU/Linux operating system. GNU/Linux > is used by millions, though many call it “Linux” by mistake. I think it is better to descript it what it ctrl-u does: Kill backward from the cursor to the beginning of the current line. :) Regards, duhuanpeng ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: readling, ctrl-u is not working like linux console
On 10/16/19 10:57 AM, Roland Hieber wrote: On Wed, Oct 16, 2019 at 04:57:45AM +0800, duhuanpeng wrote: Hi, I find it the barebox console's ctrl-u is not working like my linux host. for now, the barebox's ctrl-u discard the whole line. but the linux consle just remove characters before cursor. is the barebox ctrl-u follows any standard, if not, how about make it just works like linux(ah, it is gnu readline) does. FWIW, in bash on both my tty2 and urxvt, Ctrl-U clears the whole line. But I don't know if there is a standard for this shortkey. - Roland In some shells, like mksh, the default behaviour of ctrl-u is to kill the whole line. But then it's not called unix-line-discard, and I don't think mksh uses readline, either. The "standard" is probably just readline, though it makes me wonder where the "unix" came from… ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: readling, ctrl-u is not working like linux console
> > FWIW, in bash on both my tty2 and urxvt, Ctrl-U clears the whole line. did you try to move your cursor in the middle of a line. I guess my bash use this keybinds: [1] https://www.gnu.org/software/bash/manual/bash.html#Bindable-Readline-Commands 8.4.4 Killing And Yanking kill-line (C-k) Kill the text from point to the end of the line. backward-kill-line (C-x Rubout) Kill backward from the cursor to the beginning of the current line. unix-line-discard (C-u) Kill backward from the cursor to the beginning of the current line. kill-whole-line () Kill all characters on the current line, no matter where point is. By default, this is unbound. Regards, duhuanpeng ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: MFGTools from NXP
On 10/16/19 2:44 PM, Mihaita Ivascu wrote: > 2018.04.0 I've v2019.09.0 and did the same steps you described and it works for me. Can you try with a newer version? > > On Wed, Oct 16, 2019 at 2:41 PM Ahmad Fatoum wrote: >> >> On 10/16/19 2:35 PM, Mihaita Ivascu wrote: >>> No it does not. Still no devices listed. >> >> Strange. What barebox version? >> >>> >>> Thanks, >>> Mihaita >>> >>> On Wed, Oct 16, 2019 at 1:36 PM Ahmad Fatoum >>> wrote: On 10/16/19 1:28 PM, Mihaita Ivascu wrote: > On Wed, Oct 16, 2019 at 11:53 AM Ahmad Fatoum > wrote: >> >> >> On 10/16/19 11:48 AM, Mihaita Ivascu wrote: >>> On Wed, Oct 16, 2019 at 11:26 AM Ahmad Fatoum > wrote: On 10/16/19 11:21 AM, Mihaita Ivascu wrote: > Hello, > >Thanks for your answer. Yes i am able to connect via PUTTY to the > target. >Then I should use some adb commands in order to push the new > barebox/firmware ? do you know where I could find some examples? fastboot device -l works normally on Linux. You need to check what you > need to do on Windows to do the same. You should only need the Fastboot > utility for this. >>> [mi] Yes I have both fastboot and adb installed on both Windows and >>> Linux machines. In both cases it does not list any device. >>>The board is detected as fastboot android is windows device >>> manager. But the fastboot and adb does not list it. same for Linux. >>> Please see attachment >> >> Let's focus on Linux. You don't see a device there? >> What does barebox say? Does it say 'multi_bind: creating Fastboot > function'? >> What does you Linux host's dmesg say? >> > > barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ usbgadget -aA > udc0: registering UDC driver [g_multi] > multi_bind: creating Fastboot function > multi_bind: creating ACM function > g_multi usbgadget: Multifunction Composite Gadget > g_multi usbgadget: userspace failed to provide iSerialNumber > g_multi usbgadget: g_multi ready > barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ g_multi usbgadget: > high-speed > config #1: Multifunction Composite Gadget > > dmesg: > > [ 25.602275] usb 1-1.3: USB disconnect, device number 3 > [ 28.359930] usb 1-1.3: new high-speed USB device number 5 using > ehci-pci > [ 28.452971] usb 1-1.3: New USB device found, idVendor=1d6b, > idProduct=0104 > [ 28.452976] usb 1-1.3: New USB device strings: Mfr=0, Product=2, > SerialNumber=0 > [ 28.452980] usb 1-1.3: Product: Phytec phyCORE-i.MX6 Ultra Lite SOM > [ 28.457925] cdc_acm 1-1.3:1.1: ttyACM0: USB ACM device > > > So I see the device on Linux. But fastboot does not list any device on > Linux. sudo doesn't change this? > >> > > >Also I have a question: purpose of this activity is for me to be > able to flash some imx6ul boards that have no firmware: no barebox. >So I know hardware config for the port is otg mode but as I have no > barebox running them before I am wondering if I will be able to > connect via PUTTY if I do not set the ACM gadget from barebox? Check the Embest MarS board's environment in barebox master. It sets up a fastboot gadget automatically on boot from imx-usb-loader. You can adjust it to your liking. >>> >>> [mi] I was not able to find any docs about this board. I will keep >>> searching/asking in the nxp community. If you have already ahve any >>> files related to it would be helpful. Thanks >> >> It's in the barebox next branch (not master, sorry), see here: >> > https://github.com/saschahauer/barebox/blob/next/arch/arm/boards/embest-marsboard/defaultenv-mars/init/fastboot >> >> You can copy and adjust the environment setup for your board. >> Cheers Ahmad > > Thanks, > Mihaita > > On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum > > wrote: >> >> On 10/16/19 10:40 AM, Mihaita Ivascu wrote: >>> Hello again, >>> >>>I have the target in otg peripheral mode, ADB and fastboot > drivers >>> installed but fastboot does not list any device. The board is > detected >>> in device manager >> >> Try enabling the ACM gadget in barebox and connect with PuTTY and > see if >> at least that works. It worked for me on Windows with another i.MX > board >> a month ago. >> >> As for fastboot, I don't know how to configure it on Windows, but > surely >> Android Modding boards will have you covered there. >> >>>Please see attachment. Any ideas how shoul
Re: MFGTools from NXP
2018.04.0 On Wed, Oct 16, 2019 at 2:41 PM Ahmad Fatoum wrote: > > On 10/16/19 2:35 PM, Mihaita Ivascu wrote: > > No it does not. Still no devices listed. > > Strange. What barebox version? > > > > > Thanks, > > Mihaita > > > > On Wed, Oct 16, 2019 at 1:36 PM Ahmad Fatoum > > wrote: > >> > >> On 10/16/19 1:28 PM, Mihaita Ivascu wrote: > >>> On Wed, Oct 16, 2019 at 11:53 AM Ahmad Fatoum > >>> wrote: > > > On 10/16/19 11:48 AM, Mihaita Ivascu wrote: > > On Wed, Oct 16, 2019 at 11:26 AM Ahmad Fatoum > >>> wrote: > >> > >> On 10/16/19 11:21 AM, Mihaita Ivascu wrote: > >>> Hello, > >>> > >>>Thanks for your answer. Yes i am able to connect via PUTTY to the > >>> target. > >>>Then I should use some adb commands in order to push the new > >>> barebox/firmware ? do you know where I could find some examples? > >> > >> fastboot device -l works normally on Linux. You need to check what you > >>> need > >> to do on Windows to do the same. You should only need the Fastboot > >>> utility > >> for this. > >> > > [mi] Yes I have both fastboot and adb installed on both Windows and > > Linux machines. In both cases it does not list any device. > >The board is detected as fastboot android is windows device > > manager. But the fastboot and adb does not list it. same for Linux. > > Please see attachment > > Let's focus on Linux. You don't see a device there? > What does barebox say? Does it say 'multi_bind: creating Fastboot > >>> function'? > What does you Linux host's dmesg say? > > >>> > >>> barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ usbgadget -aA > >>> udc0: registering UDC driver [g_multi] > >>> multi_bind: creating Fastboot function > >>> multi_bind: creating ACM function > >>> g_multi usbgadget: Multifunction Composite Gadget > >>> g_multi usbgadget: userspace failed to provide iSerialNumber > >>> g_multi usbgadget: g_multi ready > >>> barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ g_multi usbgadget: > >>> high-speed > >>> config #1: Multifunction Composite Gadget > >>> > >>> dmesg: > >>> > >>> [ 25.602275] usb 1-1.3: USB disconnect, device number 3 > >>> [ 28.359930] usb 1-1.3: new high-speed USB device number 5 using > >>> ehci-pci > >>> [ 28.452971] usb 1-1.3: New USB device found, idVendor=1d6b, > >>> idProduct=0104 > >>> [ 28.452976] usb 1-1.3: New USB device strings: Mfr=0, Product=2, > >>> SerialNumber=0 > >>> [ 28.452980] usb 1-1.3: Product: Phytec phyCORE-i.MX6 Ultra Lite SOM > >>> [ 28.457925] cdc_acm 1-1.3:1.1: ttyACM0: USB ACM device > >>> > >>> > >>> So I see the device on Linux. But fastboot does not list any device on > >>> Linux. > >> > >> sudo doesn't change this? > >> > >>> > > > >>> > >>>Also I have a question: purpose of this activity is for me to be > >>> able to flash some imx6ul boards that have no firmware: no barebox. > >>>So I know hardware config for the port is otg mode but as I have no > >>> barebox running them before I am wondering if I will be able to > >>> connect via PUTTY if I do not set the ACM gadget from barebox? > >> > >> Check the Embest MarS board's environment in barebox master. It sets up > >> a fastboot gadget automatically on boot from imx-usb-loader. > >> You can adjust it to your liking. > > > > [mi] I was not able to find any docs about this board. I will keep > > searching/asking in the nxp community. If you have already ahve any > > files related to it would be helpful. Thanks > > It's in the barebox next branch (not master, sorry), see here: > > >>> https://github.com/saschahauer/barebox/blob/next/arch/arm/boards/embest-marsboard/defaultenv-mars/init/fastboot > > You can copy and adjust the environment setup for your board. > > >> > >> Cheers > >> Ahmad > >> > >>> > >>> Thanks, > >>> Mihaita > >>> > >>> On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum > >>> > >>> wrote: > > On 10/16/19 10:40 AM, Mihaita Ivascu wrote: > > Hello again, > > > >I have the target in otg peripheral mode, ADB and fastboot > >>> drivers > > installed but fastboot does not list any device. The board is > >>> detected > > in device manager > > Try enabling the ACM gadget in barebox and connect with PuTTY and > >>> see if > at least that works. It worked for me on Windows with another i.MX > >>> board > a month ago. > > As for fastboot, I don't know how to configure it on Windows, but > >>> surely > Android Modding boards will have you covered there. > > >Please see attachment. Any ideas how should I proceed? Thanks for > > the support. > > You can enable the ACM gadget in barebox and see if that works, I > >>> tested > it
Re: MFGTools from NXP
On 10/16/19 2:35 PM, Mihaita Ivascu wrote: > No it does not. Still no devices listed. Strange. What barebox version? > > Thanks, > Mihaita > > On Wed, Oct 16, 2019 at 1:36 PM Ahmad Fatoum wrote: >> >> On 10/16/19 1:28 PM, Mihaita Ivascu wrote: >>> On Wed, Oct 16, 2019 at 11:53 AM Ahmad Fatoum >>> wrote: On 10/16/19 11:48 AM, Mihaita Ivascu wrote: > On Wed, Oct 16, 2019 at 11:26 AM Ahmad Fatoum >>> wrote: >> >> On 10/16/19 11:21 AM, Mihaita Ivascu wrote: >>> Hello, >>> >>>Thanks for your answer. Yes i am able to connect via PUTTY to the >>> target. >>>Then I should use some adb commands in order to push the new >>> barebox/firmware ? do you know where I could find some examples? >> >> fastboot device -l works normally on Linux. You need to check what you >>> need >> to do on Windows to do the same. You should only need the Fastboot >>> utility >> for this. >> > [mi] Yes I have both fastboot and adb installed on both Windows and > Linux machines. In both cases it does not list any device. >The board is detected as fastboot android is windows device > manager. But the fastboot and adb does not list it. same for Linux. > Please see attachment Let's focus on Linux. You don't see a device there? What does barebox say? Does it say 'multi_bind: creating Fastboot >>> function'? What does you Linux host's dmesg say? >>> >>> barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ usbgadget -aA >>> udc0: registering UDC driver [g_multi] >>> multi_bind: creating Fastboot function >>> multi_bind: creating ACM function >>> g_multi usbgadget: Multifunction Composite Gadget >>> g_multi usbgadget: userspace failed to provide iSerialNumber >>> g_multi usbgadget: g_multi ready >>> barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ g_multi usbgadget: high-speed >>> config #1: Multifunction Composite Gadget >>> >>> dmesg: >>> >>> [ 25.602275] usb 1-1.3: USB disconnect, device number 3 >>> [ 28.359930] usb 1-1.3: new high-speed USB device number 5 using ehci-pci >>> [ 28.452971] usb 1-1.3: New USB device found, idVendor=1d6b, >>> idProduct=0104 >>> [ 28.452976] usb 1-1.3: New USB device strings: Mfr=0, Product=2, >>> SerialNumber=0 >>> [ 28.452980] usb 1-1.3: Product: Phytec phyCORE-i.MX6 Ultra Lite SOM >>> [ 28.457925] cdc_acm 1-1.3:1.1: ttyACM0: USB ACM device >>> >>> >>> So I see the device on Linux. But fastboot does not list any device on >>> Linux. >> >> sudo doesn't change this? >> >>> > >>> >>>Also I have a question: purpose of this activity is for me to be >>> able to flash some imx6ul boards that have no firmware: no barebox. >>>So I know hardware config for the port is otg mode but as I have no >>> barebox running them before I am wondering if I will be able to >>> connect via PUTTY if I do not set the ACM gadget from barebox? >> >> Check the Embest MarS board's environment in barebox master. It sets up >> a fastboot gadget automatically on boot from imx-usb-loader. >> You can adjust it to your liking. > > [mi] I was not able to find any docs about this board. I will keep > searching/asking in the nxp community. If you have already ahve any > files related to it would be helpful. Thanks It's in the barebox next branch (not master, sorry), see here: >>> https://github.com/saschahauer/barebox/blob/next/arch/arm/boards/embest-marsboard/defaultenv-mars/init/fastboot You can copy and adjust the environment setup for your board. >> >> Cheers >> Ahmad >> >>> >>> Thanks, >>> Mihaita >>> >>> On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum >>> wrote: On 10/16/19 10:40 AM, Mihaita Ivascu wrote: > Hello again, > >I have the target in otg peripheral mode, ADB and fastboot >>> drivers > installed but fastboot does not list any device. The board is >>> detected > in device manager Try enabling the ACM gadget in barebox and connect with PuTTY and >>> see if at least that works. It worked for me on Windows with another i.MX >>> board a month ago. As for fastboot, I don't know how to configure it on Windows, but >>> surely Android Modding boards will have you covered there. >Please see attachment. Any ideas how should I proceed? Thanks for > the support. You can enable the ACM gadget in barebox and see if that works, I >>> tested it on Windows with an i.MX board a month ago Cheers Ahmad > > Thanks, > Mihaita > > On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu > wrote: >> >> Thanks. I have installed ADB and fastboot drivers for Win from >> >>> https://www.getdroidtips.com
Re: MFGTools from NXP
No it does not. Still no devices listed. Thanks, Mihaita On Wed, Oct 16, 2019 at 1:36 PM Ahmad Fatoum wrote: > > On 10/16/19 1:28 PM, Mihaita Ivascu wrote: > > On Wed, Oct 16, 2019 at 11:53 AM Ahmad Fatoum > > wrote: > >> > >> > >> On 10/16/19 11:48 AM, Mihaita Ivascu wrote: > >>> On Wed, Oct 16, 2019 at 11:26 AM Ahmad Fatoum > > wrote: > > On 10/16/19 11:21 AM, Mihaita Ivascu wrote: > > Hello, > > > >Thanks for your answer. Yes i am able to connect via PUTTY to the > > target. > >Then I should use some adb commands in order to push the new > > barebox/firmware ? do you know where I could find some examples? > > fastboot device -l works normally on Linux. You need to check what you > > need > to do on Windows to do the same. You should only need the Fastboot > > utility > for this. > > >>> [mi] Yes I have both fastboot and adb installed on both Windows and > >>> Linux machines. In both cases it does not list any device. > >>>The board is detected as fastboot android is windows device > >>> manager. But the fastboot and adb does not list it. same for Linux. > >>> Please see attachment > >> > >> Let's focus on Linux. You don't see a device there? > >> What does barebox say? Does it say 'multi_bind: creating Fastboot > > function'? > >> What does you Linux host's dmesg say? > >> > > > > barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ usbgadget -aA > > udc0: registering UDC driver [g_multi] > > multi_bind: creating Fastboot function > > multi_bind: creating ACM function > > g_multi usbgadget: Multifunction Composite Gadget > > g_multi usbgadget: userspace failed to provide iSerialNumber > > g_multi usbgadget: g_multi ready > > barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ g_multi usbgadget: high-speed > > config #1: Multifunction Composite Gadget > > > > dmesg: > > > > [ 25.602275] usb 1-1.3: USB disconnect, device number 3 > > [ 28.359930] usb 1-1.3: new high-speed USB device number 5 using ehci-pci > > [ 28.452971] usb 1-1.3: New USB device found, idVendor=1d6b, > > idProduct=0104 > > [ 28.452976] usb 1-1.3: New USB device strings: Mfr=0, Product=2, > > SerialNumber=0 > > [ 28.452980] usb 1-1.3: Product: Phytec phyCORE-i.MX6 Ultra Lite SOM > > [ 28.457925] cdc_acm 1-1.3:1.1: ttyACM0: USB ACM device > > > > > > So I see the device on Linux. But fastboot does not list any device on > > Linux. > > sudo doesn't change this? > > > > >> > > > > >Also I have a question: purpose of this activity is for me to be > > able to flash some imx6ul boards that have no firmware: no barebox. > >So I know hardware config for the port is otg mode but as I have no > > barebox running them before I am wondering if I will be able to > > connect via PUTTY if I do not set the ACM gadget from barebox? > > Check the Embest MarS board's environment in barebox master. It sets up > a fastboot gadget automatically on boot from imx-usb-loader. > You can adjust it to your liking. > >>> > >>> [mi] I was not able to find any docs about this board. I will keep > >>> searching/asking in the nxp community. If you have already ahve any > >>> files related to it would be helpful. Thanks > >> > >> It's in the barebox next branch (not master, sorry), see here: > >> > > https://github.com/saschahauer/barebox/blob/next/arch/arm/boards/embest-marsboard/defaultenv-mars/init/fastboot > >> > >> You can copy and adjust the environment setup for your board. > >> > > Cheers > Ahmad > > > > > Thanks, > > Mihaita > > > > On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum > > wrote: > >> > >> On 10/16/19 10:40 AM, Mihaita Ivascu wrote: > >>> Hello again, > >>> > >>>I have the target in otg peripheral mode, ADB and fastboot > > drivers > >>> installed but fastboot does not list any device. The board is > > detected > >>> in device manager > >> > >> Try enabling the ACM gadget in barebox and connect with PuTTY and > > see if > >> at least that works. It worked for me on Windows with another i.MX > > board > >> a month ago. > >> > >> As for fastboot, I don't know how to configure it on Windows, but > > surely > >> Android Modding boards will have you covered there. > >> > >>>Please see attachment. Any ideas how should I proceed? Thanks for > >>> the support. > >> > >> You can enable the ACM gadget in barebox and see if that works, I > > tested > >> it on Windows with an i.MX board a month ago > >> > >> Cheers > >> Ahmad > >> > >>> > >>> Thanks, > >>> Mihaita > >>> > >>> On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu > >>> wrote: > > Thanks. I have installed ADB and fastboot drivers for Win from > > > https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ > I have installed according to the att
Re: MFGTools from NXP
On 10/16/19 1:28 PM, Mihaita Ivascu wrote: > On Wed, Oct 16, 2019 at 11:53 AM Ahmad Fatoum > wrote: >> >> >> On 10/16/19 11:48 AM, Mihaita Ivascu wrote: >>> On Wed, Oct 16, 2019 at 11:26 AM Ahmad Fatoum > wrote: On 10/16/19 11:21 AM, Mihaita Ivascu wrote: > Hello, > >Thanks for your answer. Yes i am able to connect via PUTTY to the > target. >Then I should use some adb commands in order to push the new > barebox/firmware ? do you know where I could find some examples? fastboot device -l works normally on Linux. You need to check what you > need to do on Windows to do the same. You should only need the Fastboot > utility for this. >>> [mi] Yes I have both fastboot and adb installed on both Windows and >>> Linux machines. In both cases it does not list any device. >>>The board is detected as fastboot android is windows device >>> manager. But the fastboot and adb does not list it. same for Linux. >>> Please see attachment >> >> Let's focus on Linux. You don't see a device there? >> What does barebox say? Does it say 'multi_bind: creating Fastboot > function'? >> What does you Linux host's dmesg say? >> > > barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ usbgadget -aA > udc0: registering UDC driver [g_multi] > multi_bind: creating Fastboot function > multi_bind: creating ACM function > g_multi usbgadget: Multifunction Composite Gadget > g_multi usbgadget: userspace failed to provide iSerialNumber > g_multi usbgadget: g_multi ready > barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ g_multi usbgadget: high-speed > config #1: Multifunction Composite Gadget > > dmesg: > > [ 25.602275] usb 1-1.3: USB disconnect, device number 3 > [ 28.359930] usb 1-1.3: new high-speed USB device number 5 using ehci-pci > [ 28.452971] usb 1-1.3: New USB device found, idVendor=1d6b, > idProduct=0104 > [ 28.452976] usb 1-1.3: New USB device strings: Mfr=0, Product=2, > SerialNumber=0 > [ 28.452980] usb 1-1.3: Product: Phytec phyCORE-i.MX6 Ultra Lite SOM > [ 28.457925] cdc_acm 1-1.3:1.1: ttyACM0: USB ACM device > > > So I see the device on Linux. But fastboot does not list any device on > Linux. sudo doesn't change this? > >> > > >Also I have a question: purpose of this activity is for me to be > able to flash some imx6ul boards that have no firmware: no barebox. >So I know hardware config for the port is otg mode but as I have no > barebox running them before I am wondering if I will be able to > connect via PUTTY if I do not set the ACM gadget from barebox? Check the Embest MarS board's environment in barebox master. It sets up a fastboot gadget automatically on boot from imx-usb-loader. You can adjust it to your liking. >>> >>> [mi] I was not able to find any docs about this board. I will keep >>> searching/asking in the nxp community. If you have already ahve any >>> files related to it would be helpful. Thanks >> >> It's in the barebox next branch (not master, sorry), see here: >> > https://github.com/saschahauer/barebox/blob/next/arch/arm/boards/embest-marsboard/defaultenv-mars/init/fastboot >> >> You can copy and adjust the environment setup for your board. >> Cheers Ahmad > > Thanks, > Mihaita > > On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum > wrote: >> >> On 10/16/19 10:40 AM, Mihaita Ivascu wrote: >>> Hello again, >>> >>>I have the target in otg peripheral mode, ADB and fastboot > drivers >>> installed but fastboot does not list any device. The board is > detected >>> in device manager >> >> Try enabling the ACM gadget in barebox and connect with PuTTY and > see if >> at least that works. It worked for me on Windows with another i.MX > board >> a month ago. >> >> As for fastboot, I don't know how to configure it on Windows, but > surely >> Android Modding boards will have you covered there. >> >>>Please see attachment. Any ideas how should I proceed? Thanks for >>> the support. >> >> You can enable the ACM gadget in barebox and see if that works, I > tested >> it on Windows with an i.MX board a month ago >> >> Cheers >> Ahmad >> >>> >>> Thanks, >>> Mihaita >>> >>> On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu >>> wrote: Thanks. I have installed ADB and fastboot drivers for Win from > https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ I have installed according to the attachment. But is not recognized in Windows. I did reboot the system after installation but did not add any new env variable. H:\>fastboot devices -l 'fastboot' is not recognized as an internal or external command, operable program or batch file. Thanks, Mihaita On Tue, O
Re: MFGTools from NXP
On Wed, Oct 16, 2019 at 11:53 AM Ahmad Fatoum wrote: > > > On 10/16/19 11:48 AM, Mihaita Ivascu wrote: > > On Wed, Oct 16, 2019 at 11:26 AM Ahmad Fatoum > > wrote: > >> > >> On 10/16/19 11:21 AM, Mihaita Ivascu wrote: > >>> Hello, > >>> > >>>Thanks for your answer. Yes i am able to connect via PUTTY to the > >>> target. > >>>Then I should use some adb commands in order to push the new > >>> barebox/firmware ? do you know where I could find some examples? > >> > >> fastboot device -l works normally on Linux. You need to check what you need > >> to do on Windows to do the same. You should only need the Fastboot utility > >> for this. > >> > > [mi] Yes I have both fastboot and adb installed on both Windows and > > Linux machines. In both cases it does not list any device. > >The board is detected as fastboot android is windows device > > manager. But the fastboot and adb does not list it. same for Linux. > > Please see attachment > > Let's focus on Linux. You don't see a device there? > What does barebox say? Does it say 'multi_bind: creating Fastboot function'? > What does you Linux host's dmesg say? barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ usbgadget -aA udc0: registering UDC driver [g_multi] multi_bind: creating Fastboot function multi_bind: creating ACM function g_multi usbgadget: Multifunction Composite Gadget g_multi usbgadget: userspace failed to provide iSerialNumber g_multi usbgadget: g_multi ready barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ g_multi usbgadget: high-speed config #1: Multifunction Composite Gadget dmesg: [ 25.602275] usb 1-1.3: USB disconnect, device number 3 [ 28.359930] usb 1-1.3: new high-speed USB device number 5 using ehci-pci [ 28.452971] usb 1-1.3: New USB device found, idVendor=1d6b, idProduct=0104 [ 28.452976] usb 1-1.3: New USB device strings: Mfr=0, Product=2, SerialNumber=0 [ 28.452980] usb 1-1.3: Product: Phytec phyCORE-i.MX6 Ultra Lite SOM [ 28.457925] cdc_acm 1-1.3:1.1: ttyACM0: USB ACM device So I see the device on Linux. But fastboot does not list any device on Linux. > > > > > >>> > >>>Also I have a question: purpose of this activity is for me to be > >>> able to flash some imx6ul boards that have no firmware: no barebox. > >>>So I know hardware config for the port is otg mode but as I have no > >>> barebox running them before I am wondering if I will be able to > >>> connect via PUTTY if I do not set the ACM gadget from barebox? > >> > >> Check the Embest MarS board's environment in barebox master. It sets up > >> a fastboot gadget automatically on boot from imx-usb-loader. > >> You can adjust it to your liking. > > > > [mi] I was not able to find any docs about this board. I will keep > > searching/asking in the nxp community. If you have already ahve any > > files related to it would be helpful. Thanks > > It's in the barebox next branch (not master, sorry), see here: > https://github.com/saschahauer/barebox/blob/next/arch/arm/boards/embest-marsboard/defaultenv-mars/init/fastboot > > You can copy and adjust the environment setup for your board. > > >> > >> Cheers > >> Ahmad > >> > >>> > >>> Thanks, > >>> Mihaita > >>> > >>> On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum > >>> wrote: > > On 10/16/19 10:40 AM, Mihaita Ivascu wrote: > > Hello again, > > > >I have the target in otg peripheral mode, ADB and fastboot drivers > > installed but fastboot does not list any device. The board is detected > > in device manager > > Try enabling the ACM gadget in barebox and connect with PuTTY and see if > at least that works. It worked for me on Windows with another i.MX board > a month ago. > > As for fastboot, I don't know how to configure it on Windows, but surely > Android Modding boards will have you covered there. > > >Please see attachment. Any ideas how should I proceed? Thanks for > > the support. > > You can enable the ACM gadget in barebox and see if that works, I tested > it on Windows with an i.MX board a month ago > > Cheers > Ahmad > > > > > Thanks, > > Mihaita > > > > On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu > > wrote: > >> > >> Thanks. I have installed ADB and fastboot drivers for Win from > >> https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ > >> I have installed according to the attachment. > >> But is not recognized in Windows. I did reboot the system after > >> installation but did not add any new env variable. > >> > >> H:\>fastboot devices -l > >> 'fastboot' is not recognized as an internal or external command, > >> operable program or batch file. > >> > >> Thanks, > >> Mihaita > >> > >> > >> On Tue, Oct 15, 2019 at 4:44 PM Ahmad Fatoum > >> wrote: > >>> > >>> On 10/15/19 4:41 PM, Mihaita Ivascu wrote: > barebox@Phytec phyC
[PATCH v2] libfile: copy_file: prevent spurious error message
Before this, if the function bails out somewhere at a later point, this return value will be outdated and will produce a misleading error message down the line. Signed-off-by: Robert Karszniewicz --- Changes from v1: - commit message lib/libfile.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/libfile.c b/lib/libfile.c index 3f3ec21..319e66b 100644 --- a/lib/libfile.c +++ b/lib/libfile.c @@ -349,6 +349,7 @@ int copy_file(const char *src, const char *dst, int verbose) ret = stat(dst, &dststat); if (ret && ret != -ENOENT) goto out; + ret = 0; /* Set O_TRUNC only if file exist and is a regular file */ if (!ret && S_ISREG(dststat.st_mode)) -- 2.7.4 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: MFGTools from NXP
On 10/16/19 11:48 AM, Mihaita Ivascu wrote: > On Wed, Oct 16, 2019 at 11:26 AM Ahmad Fatoum wrote: >> >> On 10/16/19 11:21 AM, Mihaita Ivascu wrote: >>> Hello, >>> >>>Thanks for your answer. Yes i am able to connect via PUTTY to the target. >>>Then I should use some adb commands in order to push the new >>> barebox/firmware ? do you know where I could find some examples? >> >> fastboot device -l works normally on Linux. You need to check what you need >> to do on Windows to do the same. You should only need the Fastboot utility >> for this. >> > [mi] Yes I have both fastboot and adb installed on both Windows and > Linux machines. In both cases it does not list any device. >The board is detected as fastboot android is windows device > manager. But the fastboot and adb does not list it. same for Linux. > Please see attachment Let's focus on Linux. You don't see a device there? What does barebox say? Does it say 'multi_bind: creating Fastboot function'? What does you Linux host's dmesg say? > >>> >>>Also I have a question: purpose of this activity is for me to be >>> able to flash some imx6ul boards that have no firmware: no barebox. >>>So I know hardware config for the port is otg mode but as I have no >>> barebox running them before I am wondering if I will be able to >>> connect via PUTTY if I do not set the ACM gadget from barebox? >> >> Check the Embest MarS board's environment in barebox master. It sets up >> a fastboot gadget automatically on boot from imx-usb-loader. >> You can adjust it to your liking. > > [mi] I was not able to find any docs about this board. I will keep > searching/asking in the nxp community. If you have already ahve any > files related to it would be helpful. Thanks It's in the barebox next branch (not master, sorry), see here: https://github.com/saschahauer/barebox/blob/next/arch/arm/boards/embest-marsboard/defaultenv-mars/init/fastboot You can copy and adjust the environment setup for your board. >> >> Cheers >> Ahmad >> >>> >>> Thanks, >>> Mihaita >>> >>> On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum >>> wrote: On 10/16/19 10:40 AM, Mihaita Ivascu wrote: > Hello again, > >I have the target in otg peripheral mode, ADB and fastboot drivers > installed but fastboot does not list any device. The board is detected > in device manager Try enabling the ACM gadget in barebox and connect with PuTTY and see if at least that works. It worked for me on Windows with another i.MX board a month ago. As for fastboot, I don't know how to configure it on Windows, but surely Android Modding boards will have you covered there. >Please see attachment. Any ideas how should I proceed? Thanks for > the support. You can enable the ACM gadget in barebox and see if that works, I tested it on Windows with an i.MX board a month ago Cheers Ahmad > > Thanks, > Mihaita > > On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu > wrote: >> >> Thanks. I have installed ADB and fastboot drivers for Win from >> https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ >> I have installed according to the attachment. >> But is not recognized in Windows. I did reboot the system after >> installation but did not add any new env variable. >> >> H:\>fastboot devices -l >> 'fastboot' is not recognized as an internal or external command, >> operable program or batch file. >> >> Thanks, >> Mihaita >> >> >> On Tue, Oct 15, 2019 at 4:44 PM Ahmad Fatoum >> wrote: >>> >>> On 10/15/19 4:41 PM, Mihaita Ivascu wrote: barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ fastboot devices -l >>> That's what you run on your host system, not on the target. >>> -- >>> Pengutronix e.K. | >>> | >>> Industrial Linux Solutions | http://www.pengutronix.de/ >>> | >>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 >>> | >>> Amtsgericht Hildesheim, HRA 2686 | Fax: >>> +49-5121-206917- | -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | >>> >> >> >> -- >> Pengutronix e.K. | | >> Industrial Linux Solutions | http://www.pengutronix.de/ | >> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | -- Pengutronix e.K. |
Re: MFGTools from NXP
On Wed, Oct 16, 2019 at 11:26 AM Ahmad Fatoum wrote: > > On 10/16/19 11:21 AM, Mihaita Ivascu wrote: > > Hello, > > > >Thanks for your answer. Yes i am able to connect via PUTTY to the target. > >Then I should use some adb commands in order to push the new > > barebox/firmware ? do you know where I could find some examples? > > fastboot device -l works normally on Linux. You need to check what you need > to do on Windows to do the same. You should only need the Fastboot utility > for this. > [mi] Yes I have both fastboot and adb installed on both Windows and Linux machines. In both cases it does not list any device. The board is detected as fastboot android is windows device manager. But the fastboot and adb does not list it. same for Linux. Please see attachment > > > >Also I have a question: purpose of this activity is for me to be > > able to flash some imx6ul boards that have no firmware: no barebox. > >So I know hardware config for the port is otg mode but as I have no > > barebox running them before I am wondering if I will be able to > > connect via PUTTY if I do not set the ACM gadget from barebox? > > Check the Embest MarS board's environment in barebox master. It sets up > a fastboot gadget automatically on boot from imx-usb-loader. > You can adjust it to your liking. [mi] I was not able to find any docs about this board. I will keep searching/asking in the nxp community. If you have already ahve any files related to it would be helpful. Thanks > > Cheers > Ahmad > > > > > Thanks, > > Mihaita > > > > On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum > > wrote: > >> > >> On 10/16/19 10:40 AM, Mihaita Ivascu wrote: > >>> Hello again, > >>> > >>>I have the target in otg peripheral mode, ADB and fastboot drivers > >>> installed but fastboot does not list any device. The board is detected > >>> in device manager > >> > >> Try enabling the ACM gadget in barebox and connect with PuTTY and see if > >> at least that works. It worked for me on Windows with another i.MX board > >> a month ago. > >> > >> As for fastboot, I don't know how to configure it on Windows, but surely > >> Android Modding boards will have you covered there. > >> > >>>Please see attachment. Any ideas how should I proceed? Thanks for > >>> the support. > >> > >> You can enable the ACM gadget in barebox and see if that works, I tested > >> it on Windows with an i.MX board a month ago > >> > >> Cheers > >> Ahmad > >> > >>> > >>> Thanks, > >>> Mihaita > >>> > >>> On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu > >>> wrote: > > Thanks. I have installed ADB and fastboot drivers for Win from > https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ > I have installed according to the attachment. > But is not recognized in Windows. I did reboot the system after > installation but did not add any new env variable. > > H:\>fastboot devices -l > 'fastboot' is not recognized as an internal or external command, > operable program or batch file. > > Thanks, > Mihaita > > > On Tue, Oct 15, 2019 at 4:44 PM Ahmad Fatoum > wrote: > > > > On 10/15/19 4:41 PM, Mihaita Ivascu wrote: > >> barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ fastboot devices -l > > That's what you run on your host system, not on the target. > > -- > > Pengutronix e.K. | > > | > > Industrial Linux Solutions | http://www.pengutronix.de/ > > | > > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > > | > > Amtsgericht Hildesheim, HRA 2686 | Fax: > > +49-5121-206917- | > >> > >> > >> -- > >> Pengutronix e.K. | | > >> Industrial Linux Solutions | http://www.pengutronix.de/ | > >> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| > >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | > > > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] ARM: stm32mp: select ARCH_HAS_RESET_CONTROLLER
Many STM32 peripherals, including I2C, SPI, USB and SDMMC use the RCC reset controller for reset. Enable ARCH_HAS_RESET_CONTROLLER, so drivers depending on RESET_CONTROLLER become available for selection. Signed-off-by: Ahmad Fatoum --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index b227bb78b64f..16bd82fe6b9f 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -217,6 +217,7 @@ config ARCH_STM32MP select HAS_DEBUG_LL select HAVE_CLK select GPIOLIB + select ARCH_HAS_RESET_CONTROLLER config ARCH_VERSATILE bool "ARM Versatile boards (ARM926EJ-S)" -- 2.23.0 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH] fixup! mci: add support for stm32mp sd/mmc controller
We need reset controller support in the driver, depend on it. --- drivers/mci/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mci/Kconfig b/drivers/mci/Kconfig index 5b560310136a..4a71a4609763 100644 --- a/drivers/mci/Kconfig +++ b/drivers/mci/Kconfig @@ -156,6 +156,7 @@ config MMC_SPI_CRC_ON config MCI_STM32_SDMMC2 bool "STMicroelectronics STM32H7 SD/MMC Host Controller support" depends on ARM_AMBA + depends on RESET_CONTROLLER help This selects support for the SD/MMC controller on STM32H7 SoCs. If you have a board based on such a SoC and with a SD/MMC slot, -- 2.23.0 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: MFGTools from NXP
On 10/16/19 11:21 AM, Mihaita Ivascu wrote: > Hello, > >Thanks for your answer. Yes i am able to connect via PUTTY to the target. >Then I should use some adb commands in order to push the new > barebox/firmware ? do you know where I could find some examples? fastboot device -l works normally on Linux. You need to check what you need to do on Windows to do the same. You should only need the Fastboot utility for this. > >Also I have a question: purpose of this activity is for me to be > able to flash some imx6ul boards that have no firmware: no barebox. >So I know hardware config for the port is otg mode but as I have no > barebox running them before I am wondering if I will be able to > connect via PUTTY if I do not set the ACM gadget from barebox? Check the Embest MarS board's environment in barebox master. It sets up a fastboot gadget automatically on boot from imx-usb-loader. You can adjust it to your liking. Cheers Ahmad > > Thanks, > Mihaita > > On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum wrote: >> >> On 10/16/19 10:40 AM, Mihaita Ivascu wrote: >>> Hello again, >>> >>>I have the target in otg peripheral mode, ADB and fastboot drivers >>> installed but fastboot does not list any device. The board is detected >>> in device manager >> >> Try enabling the ACM gadget in barebox and connect with PuTTY and see if >> at least that works. It worked for me on Windows with another i.MX board >> a month ago. >> >> As for fastboot, I don't know how to configure it on Windows, but surely >> Android Modding boards will have you covered there. >> >>>Please see attachment. Any ideas how should I proceed? Thanks for >>> the support. >> >> You can enable the ACM gadget in barebox and see if that works, I tested >> it on Windows with an i.MX board a month ago >> >> Cheers >> Ahmad >> >>> >>> Thanks, >>> Mihaita >>> >>> On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu >>> wrote: Thanks. I have installed ADB and fastboot drivers for Win from https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ I have installed according to the attachment. But is not recognized in Windows. I did reboot the system after installation but did not add any new env variable. H:\>fastboot devices -l 'fastboot' is not recognized as an internal or external command, operable program or batch file. Thanks, Mihaita On Tue, Oct 15, 2019 at 4:44 PM Ahmad Fatoum wrote: > > On 10/15/19 4:41 PM, Mihaita Ivascu wrote: >> barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ fastboot devices -l > That's what you run on your host system, not on the target. > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | >> >> >> -- >> Pengutronix e.K. | | >> Industrial Linux Solutions | http://www.pengutronix.de/ | >> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: MFGTools from NXP
Hello, Thanks for your answer. Yes i am able to connect via PUTTY to the target. Then I should use some adb commands in order to push the new barebox/firmware ? do you know where I could find some examples? Also I have a question: purpose of this activity is for me to be able to flash some imx6ul boards that have no firmware: no barebox. So I know hardware config for the port is otg mode but as I have no barebox running them before I am wondering if I will be able to connect via PUTTY if I do not set the ACM gadget from barebox? Thanks, Mihaita On Wed, Oct 16, 2019 at 10:51 AM Ahmad Fatoum wrote: > > On 10/16/19 10:40 AM, Mihaita Ivascu wrote: > > Hello again, > > > >I have the target in otg peripheral mode, ADB and fastboot drivers > > installed but fastboot does not list any device. The board is detected > > in device manager > > Try enabling the ACM gadget in barebox and connect with PuTTY and see if > at least that works. It worked for me on Windows with another i.MX board > a month ago. > > As for fastboot, I don't know how to configure it on Windows, but surely > Android Modding boards will have you covered there. > > >Please see attachment. Any ideas how should I proceed? Thanks for > > the support. > > You can enable the ACM gadget in barebox and see if that works, I tested > it on Windows with an i.MX board a month ago > > Cheers > Ahmad > > > > > Thanks, > > Mihaita > > > > On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu > > wrote: > >> > >> Thanks. I have installed ADB and fastboot drivers for Win from > >> https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ > >> I have installed according to the attachment. > >> But is not recognized in Windows. I did reboot the system after > >> installation but did not add any new env variable. > >> > >> H:\>fastboot devices -l > >> 'fastboot' is not recognized as an internal or external command, > >> operable program or batch file. > >> > >> Thanks, > >> Mihaita > >> > >> > >> On Tue, Oct 15, 2019 at 4:44 PM Ahmad Fatoum > >> wrote: > >>> > >>> On 10/15/19 4:41 PM, Mihaita Ivascu wrote: > barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ fastboot devices -l > >>> That's what you run on your host system, not on the target. > >>> -- > >>> Pengutronix e.K. | | > >>> Industrial Linux Solutions | http://www.pengutronix.de/ | > >>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| > >>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | > > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: readling, ctrl-u is not working like linux console
On Wed, Oct 16 2019 at 10:57 +0200, Roland Hieber wrote: > On Wed, Oct 16, 2019 at 04:57:45AM +0800, duhuanpeng wrote: >> Hi, >> >> I find it the barebox console's ctrl-u is not working like my >> linux host. >> for now, the barebox's ctrl-u discard the whole line. but the >> linux consle just remove characters before cursor. >> is the barebox ctrl-u follows any standard, if not, how about >> make it just works like linux(ah, it is gnu readline) does. > > FWIW, in bash on both my tty2 and urxvt, Ctrl-U clears the whole line. > But I don't know if there is a standard for this shortkey. See this section [1] in the readline documentation. Best regards Ulrich [1] https://tiswww.case.edu/php/chet/readline/readline.html#SEC17 -- Pengutronix e.K. | Ulrich Ölmann | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: readling, ctrl-u is not working like linux console
On Wed, Oct 16, 2019 at 04:57:45AM +0800, duhuanpeng wrote: > Hi, > > I find it the barebox console's ctrl-u is not working like my > linux host. > for now, the barebox's ctrl-u discard the whole line. but the > linux consle just remove characters before cursor. > is the barebox ctrl-u follows any standard, if not, how about > make it just works like linux(ah, it is gnu readline) does. FWIW, in bash on both my tty2 and urxvt, Ctrl-U clears the whole line. But I don't know if there is a standard for this shortkey. - Roland -- Roland Hieber | r.hie...@pengutronix.de | Pengutronix e.K. | https://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: MFGTools from NXP
On 10/16/19 10:40 AM, Mihaita Ivascu wrote: > Hello again, > >I have the target in otg peripheral mode, ADB and fastboot drivers > installed but fastboot does not list any device. The board is detected > in device manager Try enabling the ACM gadget in barebox and connect with PuTTY and see if at least that works. It worked for me on Windows with another i.MX board a month ago. As for fastboot, I don't know how to configure it on Windows, but surely Android Modding boards will have you covered there. >Please see attachment. Any ideas how should I proceed? Thanks for > the support. You can enable the ACM gadget in barebox and see if that works, I tested it on Windows with an i.MX board a month ago Cheers Ahmad > > Thanks, > Mihaita > > On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu > wrote: >> >> Thanks. I have installed ADB and fastboot drivers for Win from >> https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ >> I have installed according to the attachment. >> But is not recognized in Windows. I did reboot the system after >> installation but did not add any new env variable. >> >> H:\>fastboot devices -l >> 'fastboot' is not recognized as an internal or external command, >> operable program or batch file. >> >> Thanks, >> Mihaita >> >> >> On Tue, Oct 15, 2019 at 4:44 PM Ahmad Fatoum wrote: >>> >>> On 10/15/19 4:41 PM, Mihaita Ivascu wrote: barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ fastboot devices -l >>> That's what you run on your host system, not on the target. >>> -- >>> Pengutronix e.K. | | >>> Industrial Linux Solutions | http://www.pengutronix.de/ | >>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| >>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: MFGTools from NXP
Hello again, I have the target in otg peripheral mode, ADB and fastboot drivers installed but fastboot does not list any device. The board is detected in device manager Please see attachment. Any ideas how should I proceed? Thanks for the support. Thanks, Mihaita On Wed, Oct 16, 2019 at 9:32 AM Mihaita Ivascu wrote: > > Thanks. I have installed ADB and fastboot drivers for Win from > https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ > I have installed according to the attachment. > But is not recognized in Windows. I did reboot the system after > installation but did not add any new env variable. > > H:\>fastboot devices -l > 'fastboot' is not recognized as an internal or external command, > operable program or batch file. > > Thanks, > Mihaita > > > On Tue, Oct 15, 2019 at 4:44 PM Ahmad Fatoum wrote: > > > > On 10/15/19 4:41 PM, Mihaita Ivascu wrote: > > > barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ fastboot devices -l > > That's what you run on your host system, not on the target. > > -- > > Pengutronix e.K. | | > > Industrial Linux Solutions | http://www.pengutronix.de/ | > > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: [PATCH v3] readline: make ctrl-u to work like linux console
Am 16.10.19 um 09:25 schrieb sendpa...@qq.com: > From: DU HUANPENG > > currtly, the ctrl-u discards the whole line, in most linux > boxes, ctrl-u just erase characters before cursor to the > begginning of the line. this patch make ctrl-u to do this. > > Signed-off-by: DU HUANPENG > --- > lib/readline.c | 26 -- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/lib/readline.c b/lib/readline.c > index d026af1..3d5fafd 100644 > --- a/lib/readline.c > +++ b/lib/readline.c > @@ -188,9 +188,10 @@ int readline(const char *prompt, char *buf, int len) > unsigned wlen; > int ichar; > int insert = 1; > + int i; > #ifdef CONFIG_AUTO_COMPLETE > char tmp; > - int reprint, i; > + int reprint; > char *completestr; > > complete_reset(); > @@ -290,10 +291,31 @@ int readline(const char *prompt, char *buf, int len) > insert = !insert; > break; > case BB_KEY_ERASE_LINE: > - case CTL_CH('u'): > BEGINNING_OF_LINE(); > ERASE_TO_EOL(); > break; > + case CTL_CH('u'): > + if (num <= eol_num) { i doubt num can be ever bigger then eol_num. or do i missing some thing? > + for (i = num; i < eol_num; i++) > + buf[i-num] = buf[i]; > + buf[i] = '\0'; > + > + for (i = 0; i < num; i++) > + getcmd_putch(CTL_BACKSPACE); > + for (i = 0; i < eol_num; i++) > + getcmd_putch(' '); > + for (i = 0; i < eol_num; i++) > + getcmd_putch(CTL_BACKSPACE); > + > + eol_num -= num; > + num = 0; > + > + for (i = 0 ; i < eol_num; i++) > + getcmd_putch(buf[i]); > + for (i = 0; i < eol_num; i++) > + getcmd_putch(CTL_BACKSPACE); > + } > + break; > case DEL: > case BB_KEY_DEL7: > case 8: > -- Regards, Oleksij ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
Re: MFGTools from NXP
Thanks. I have installed ADB and fastboot drivers for Win from https://www.getdroidtips.com/how-to-install-adb-and-fastboot-on-windows/ I have installed according to the attachment. But is not recognized in Windows. I did reboot the system after installation but did not add any new env variable. H:\>fastboot devices -l 'fastboot' is not recognized as an internal or external command, operable program or batch file. Thanks, Mihaita On Tue, Oct 15, 2019 at 4:44 PM Ahmad Fatoum wrote: > > On 10/15/19 4:41 PM, Mihaita Ivascu wrote: > > barebox@Phytec phyCORE-i.MX6 Ultra Lite SOM:/ fastboot devices -l > That's what you run on your host system, not on the target. > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH v3] readline: make ctrl-u to work like linux console
From: DU HUANPENG currtly, the ctrl-u discards the whole line, in most linux boxes, ctrl-u just erase characters before cursor to the begginning of the line. this patch make ctrl-u to do this. Signed-off-by: DU HUANPENG --- lib/readline.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/lib/readline.c b/lib/readline.c index d026af1..3d5fafd 100644 --- a/lib/readline.c +++ b/lib/readline.c @@ -188,9 +188,10 @@ int readline(const char *prompt, char *buf, int len) unsigned wlen; int ichar; int insert = 1; + int i; #ifdef CONFIG_AUTO_COMPLETE char tmp; - int reprint, i; + int reprint; char *completestr; complete_reset(); @@ -290,10 +291,31 @@ int readline(const char *prompt, char *buf, int len) insert = !insert; break; case BB_KEY_ERASE_LINE: - case CTL_CH('u'): BEGINNING_OF_LINE(); ERASE_TO_EOL(); break; + case CTL_CH('u'): + if (num <= eol_num) { + for (i = num; i < eol_num; i++) + buf[i-num] = buf[i]; + buf[i] = '\0'; + + for (i = 0; i < num; i++) + getcmd_putch(CTL_BACKSPACE); + for (i = 0; i < eol_num; i++) + getcmd_putch(' '); + for (i = 0; i < eol_num; i++) + getcmd_putch(CTL_BACKSPACE); + + eol_num -= num; + num = 0; + + for (i = 0 ; i < eol_num; i++) + getcmd_putch(buf[i]); + for (i = 0; i < eol_num; i++) + getcmd_putch(CTL_BACKSPACE); + } + break; case DEL: case BB_KEY_DEL7: case 8: -- 2.7.4 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH 3/5] efi: use efi_guidcmp helper where appropriate
We have a helper for it. Let's use it. Signed-off-by: Ahmad Fatoum --- drivers/efi/efi-device.c | 2 +- fs/efivarfs.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/efi/efi-device.c b/drivers/efi/efi-device.c index 305d337aabf5..68d81caf010b 100644 --- a/drivers/efi/efi-device.c +++ b/drivers/efi/efi-device.c @@ -311,7 +311,7 @@ static int efi_bus_match(struct device_d *dev, struct driver_d *drv) int i; for (i = 0; i < efidev->num_guids; i++) { - if (!memcmp(&efidrv->guid, &efidev->guids[i], sizeof(efi_guid_t))) { + if (!efi_guidcmp(efidrv->guid, efidev->guids[i])) { BS->handle_protocol(efidev->handle, &efidev->guids[i], &efidev->protocol); return 0; diff --git a/fs/efivarfs.c b/fs/efivarfs.c index 1e8049362168..9eadda41215c 100644 --- a/fs/efivarfs.c +++ b/fs/efivarfs.c @@ -145,7 +145,7 @@ static int efivars_create(struct device_d *dev, const char *pathname, mode_t mod if (ret) return -ENOENT; - if (memcmp(&vendor, &EFI_BAREBOX_VENDOR_GUID, sizeof(efi_guid_t))) + if (efi_guidcmp(vendor, EFI_BAREBOX_VENDOR_GUID)) return -EPERM; inode = xzalloc(sizeof(*inode)); -- 2.20.1 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH 4/5] x86: include: add asmlinkage 'storage class'
We've a number of C functions with external linkage that are only called from assembly. -Wmissing-prototypes warns about these unless they have a prototype that goes unused. Let's standardize on using the asmlinkage 'storage class' to mark such declarations. As defines asmlinkage to naught unless does, it's sufficient to add an empty header to make this usable on x86 as well. Signed-off-by: Ahmad Fatoum --- arch/x86/include/asm/linkage.h | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 arch/x86/include/asm/linkage.h diff --git a/arch/x86/include/asm/linkage.h b/arch/x86/include/asm/linkage.h new file mode 100644 index ..a8d1bdb7de1f --- /dev/null +++ b/arch/x86/include/asm/linkage.h @@ -0,0 +1,6 @@ +#ifndef __ASM_LINKAGE_H +#define __ASM_LINKAGE_H + +/* referenced by */ + +#endif -- 2.20.1 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH 2/5] efi: retire efi_compare_guid in favor of efi_guidcmp
Both functions wrap the same memcmp except that one uses pointers to GUIDs and the other passes the GUIDs by value. The function is static inline, so it doesn't really matter which one we keep. We'll drop efi_compare_guid because it's been used once only in the code base so far. Signed-off-by: Ahmad Fatoum --- common/efi-devicepath.c | 2 +- include/efi.h | 5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/common/efi-devicepath.c b/common/efi-devicepath.c index 24722284b4a7..3db2cea061ca 100644 --- a/common/efi-devicepath.c +++ b/common/efi-devicepath.c @@ -572,7 +572,7 @@ dev_path_vendor(struct string *str, void *dev_path) } cprintf(str, "Ven%s(%pU", type, &Vendor->Guid); - if (efi_compare_guid(&Vendor->Guid, &efi_unknown_device_guid) == 0) { + if (efi_guidcmp(Vendor->Guid, efi_unknown_device_guid) == 0) { /* GUID used by EFI to enumerate an EDD 1.1 device */ unknown_dev_path = (struct unknown_device_vendor_device_path *) Vendor; diff --git a/include/efi.h b/include/efi.h index 218333f82426..166803a58f39 100644 --- a/include/efi.h +++ b/include/efi.h @@ -664,11 +664,6 @@ typedef union { efi_ipv6_address v6; } efi_ip_address; -static inline int efi_compare_guid(efi_guid_t *a, efi_guid_t *b) -{ - return memcmp(a, b, sizeof(efi_guid_t)); -} - struct efi_device_path *device_path_from_handle(efi_handle_t Handle); char *device_path_to_str(struct efi_device_path *dev_path); u8 device_path_to_type(struct efi_device_path *dev_path); -- 2.20.1 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH 5/5] efi: silence warning about un-prototyped assembly-called functions
Both _relocate and efi_main are only called from assembly, but -Wmissing-prototypes doesn't know that and warns about them. Pre-declare prototypes to silence the warnings. Signed-off-by: Ahmad Fatoum --- arch/x86/mach-efi/reloc_x86_64.c | 3 +++ common/efi/efi.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/arch/x86/mach-efi/reloc_x86_64.c b/arch/x86/mach-efi/reloc_x86_64.c index 1db72f5dbc52..e83bacb302ca 100644 --- a/arch/x86/mach-efi/reloc_x86_64.c +++ b/arch/x86/mach-efi/reloc_x86_64.c @@ -35,11 +35,14 @@ SUCH DAMAGE. */ +#include #include #include #include +asmlinkage efi_status_t _relocate (long, Elf64_Dyn *, efi_handle_t, efi_system_table_t *); + efi_status_t _relocate (long ldbase, Elf64_Dyn *dyn, efi_handle_t image, efi_system_table_t *systab) { long relsz = 0, relent = 0; diff --git a/common/efi/efi.c b/common/efi/efi.c index a7b25cbbe251..73cea3703695 100644 --- a/common/efi/efi.c +++ b/common/efi/efi.c @@ -17,6 +17,7 @@ * */ +#include #include #include #include @@ -318,6 +319,8 @@ static int efi_init(void) } device_initcall(efi_init); +asmlinkage efi_status_t efi_main(efi_handle_t, efi_system_table_t *); + /** * efi-main - Entry point for EFI images */ -- 2.20.1 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox
[PATCH 1/5] efi: Fix typo in description string
s/Conosle/Console/ Signed-off-by: Ahmad Fatoum --- common/efi-guid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/efi-guid.c b/common/efi-guid.c index 1e45ccf4d238..2bf2395e8540 100644 --- a/common/efi-guid.c +++ b/common/efi-guid.c @@ -52,7 +52,7 @@ const char *efi_guid_string(efi_guid_t *g) EFI_GUID_STRING(EFI_ISA_IO_PROTOCOL_GUID, "ISA IO Protocol", "ISA IO Protocol"); EFI_GUID_STRING(EFI_STANDARD_ERROR_DEVICE_GUID, "Standard Error Device Guid", "EFI Standard Error Device Guid"); EFI_GUID_STRING(EFI_CONSOLE_OUT_DEVICE_GUID, "Console Out Device Guid", "EFI Console Out Device Guid"); - EFI_GUID_STRING(EFI_CONSOLE_IN_DEVICE_GUID, "Console In Device Guid", "EFI Conosle In Device Guid"); + EFI_GUID_STRING(EFI_CONSOLE_IN_DEVICE_GUID, "Console In Device Guid", "EFI Console In Device Guid"); EFI_GUID_STRING(EFI_SIMPLE_TEXT_OUT_PROTOCOL_GUID, "Simple Text Out Protocol", "EFI 1.0 Simple Text Out Protocol"); EFI_GUID_STRING(EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL_GUID, "Simple Text Input Ex Protocol", "UEFI 2.1 Simple Text Input Ex Protocol"); EFI_GUID_STRING(EFI_SIMPLE_TEXT_IN_PROTOCOL_GUID, "Simple Text In Protocol", "EFI 1.0 Simple Text In Protocol"); -- 2.20.1 ___ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox