APK generated from FireFoxOS App?

2014-06-20 Thread Carlos Santana
I'm curious about this:
https://developer.mozilla.org/en-US/Marketplace/Options/Open_web_apps_for_android

Anyone knows more about how this works and compares to cordova android?

Is generating a cordova android APK?
Is using android web view or gecko web view?
Is using some some sort of shim layer call "web runtime" for FirefoxOS API
birding to Android?

Anything here to leverage(i.e. Concepts, API separation, packaging on the
the cloud, etc) for Cordova, maybe in the area of android plug-able web
views?

-- Carlos




-- 
Carlos Santana



Re: [DISCUSS] Tools release

2014-06-20 Thread Andrew Grieve
Now that the dust has settled on the android library change, I'd like to
try this again. Created bug:
https://issues.apache.org/jira/browse/CB-7002

I hope to put together RCs tomorrow morning. Likely not too many people
checking email any more since it's the weekend, but feeling like we're
overdue on this, so hopefully Monday we can all test & vote. If it doesn't
pan out, oh well, but otherwise we'll have a release! :)


On Thu, Jun 12, 2014 at 1:44 AM, Anis KADRI  wrote:

> On Wed, Jun 11, 2014 at 6:19 AM, Ian Clelland 
> wrote:
>
> > (FWIW, I don't see any reason *not* to consider it end-user software. It
> > provides the programmatic interface to all of the logic in the CLI tools.
> > If someone wanted to integrate the Cordova build process into another
> tool,
> > like an IDE or an automated build system, I would be thrilled if they
> chose
> > to use cordova-lib and called it directly from Node, rather than spawning
> > shells to invoke the CLI.)
> >
>
> +1 as well. I've played with the new flow and aside from the fact of having
> to link 3 repositories to test shit out, it works. However, I've got some
> ranting to do:
>
> Just like you said. programmatic interface to _ALL_ of the logic in the CLI
> tools even though most IDEs/tools might want to use a tiny feature of the
> CLI tools (like in Brian's case just the create-project part). There is a
> different thread on the topic and you guys seem (Google) to agree with the
> idea of a breakout but I just felt like reiterating it because I think it's
> really important for so many different reasons.
>


[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/181


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Browserify JS is in

2014-06-20 Thread Anis KADRI
Ok cool. I can look at adding a --browserify option for run and prepare. I
logged an issue for it [1]

[1] https://issues.apache.org/jira/browse/CB-7001


On Thu, Jun 19, 2014 at 5:57 PM, Andrew Grieve  wrote:

> Thanks Anis!
>
> Tougher for CLI since it's actually the prepare step that creates
> cordova_plugins.js, but longer term (medium term?) I don't see why we
> shouldn't just turn it on always anyways.
>
> So... Maybe cordova prepare --browserify?
> Build prepares first, so will also need: cordova run android --browserify
>
> I haven't looked at it yet. Google IO is next week and it's been consuming
> most of our time the last few weeks. Will definitely play with it next next
> week though!
>
>
>
> On Thu, Jun 19, 2014 at 6:28 PM, Anis KADRI  wrote:
>
>> Sorry. I forgot you asked the question. There was no issue but there is
>> one now.
>> https://issues.apache.org/jira/browse/CB-6990
>>
>> This "feature" is plugman only for now. How important is it to wire it
>> to CLI ? Have  you guys had time to test it out yet ? How would it
>> work with CLI ? Add another flag such as "cordova plugin add
>> --browserify" ?
>>
>> On Thu, Jun 19, 2014 at 9:28 AM, Andrew Grieve 
>> wrote:
>> > bump
>> >
>> >
>> > On Mon, Jun 16, 2014 at 12:51 PM, Andrew Grieve 
>> > wrote:
>> >>
>> >> Cool, yes! Thanks for the update!
>> >>
>> >> Is there a JIRA for this? Was asked in
>> >> https://issues.apache.org/jira/browse/CB-5671.
>> >>
>> >>
>> >>
>> >>
>> >> On Mon, Jun 16, 2014 at 10:21 AM, Michal Mocny 
>> >> wrote:
>> >>>
>> >>> Awesome Anis.
>> >>>
>> >>> Will gladly take a look at this later today.  Just wanted to send a
>> quick
>> >>> thanks for landing this this way, and for the useful report.
>> >>>
>> >>> -Michal
>> >>>
>> >>>
>> >>> On Fri, Jun 13, 2014 at 7:55 PM, Anis KADRI 
>> wrote:
>> >>>
>> >>> > Yo,
>> >>> >
>> >>> > Just wanted to let everyone know that I added browserify support to
>> >>> > plugman (behind a flag for now). CLI is not hooked to this yet. Here
>> >>> > is how it works:
>> >>> >
>> >>> > plugman install --browserify --plugin [PLUGIN] --platform [PLATFORM]
>> >>> > --project [PROJECT_PATH]
>> >>> >
>> >>> > will generate a browserify version of cordova.js. Plugins and
>> >>> > everything is bundled in. This version passes mobile-spec on iOS and
>> >>> > Android. I am not yet setup to test other platforms.
>> >>> >
>> >>> > plugman install --plugin [PLUGIN] --platform [PLATFORM] --project
>> >>> > [PROJECT_PATH]
>> >>> >
>> >>> > Will continue to generate cordova.js the way it used to.
>> >>> >
>> >>> > Because some of you really care about benchmarks here is some
>> >>> > comparison for dependencies-plugin install:
>> >>> >
>> >>> > No browserify:
>> >>> >
>> >>> > real 0m9.546s
>> >>> > user 0m4.673s
>> >>> > sys 0m0.692s
>> >>> >
>> >>> > Browserify:
>> >>> > real 0m9.861s
>> >>> > user 0m4.759s
>> >>> > sys 0m0.648s
>> >>> >
>> >>> > All cordova-lib tests are passing so I am assuming this has minimal
>> >>> > impact but LET ME KNOW otherwise.
>> >>> >
>> >>> > Anis
>> >>> >
>> >>
>> >>
>> >
>>
>
>


[GitHub] cordova-lib pull request: CB-6615 Fix plugin check error, when plu...

2014-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-windows pull request: CB-6977 Support chip architecture as...

2014-06-20 Thread purplecabbage
Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-windows/pull/34#issuecomment-46727252
  
@vladimir-kotikov Is this still valid? There are merge issues with 
@sgrebnov's recent pull-reqest.
if so, can you rebase into master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: network-information memory leak

2014-06-20 Thread Staci Cooper
The leak happens when you start the application on a native page and then
navigate back and forth between it and the hybrid page. It was reported by
an IBM customer and I was verifying its existence and the fix with Visual
Studio's memory profiler.

If you add the network-information plugin, when navigating back and forth
between pages, it keeps creating new instances of MainPage and they are
never garbage collected. With the commit I linked to, the pages get garbage
collected. If I add the string empty back, I see the leak again, but I
don't understand why.




On Fri, Jun 20, 2014 at 4:28 PM, Jesse  wrote:

> What is leaked?
> How are you proving that there is a leak, and it is indeed fixed?
>
> All js callable cordova commands are backed by c# subclasses of BaseCommand
> and their methods all have the same signature:
>
> public void callableMethod(string);
>
>
>
>
> @purplecabbage
> risingj.com
>
>
> On Fri, Jun 20, 2014 at 1:20 PM, Staci Cooper  wrote:
>
> > I found another memory leak in windows phone. This time it involves the
> > network information plugin.
> >
> > I found a fix:
> >
> >
> https://github.com/stacic/cordova-plugin-network-information/commit/d41118f0da0270d23cd699dc0766d377c9e8922a
> >
> > But I'm not sure I understand why it works. In addition to unsubscribing
> > from some event handlers, it involves the getConnectionInfo function in
> > NetworkStatus.js, which takes a string parameter called 'empty' that it
> > does nothing with. If I get rid of that parameter the leak disappears.
> >
> > Does anybody know why it was there in the first place? I didn't see any
> > problems after deleting it, but it seems odd.
> >
>


[GitHub] cordova-plugin-camera pull request: CB- 6958. Port camera test to ...

2014-06-20 Thread javierbb31
Github user javierbb31 commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r14040361
  
--- Diff: plugin.xml ---
@@ -202,6 +205,7 @@
 
 
 
+
--- End diff --

I already removed this dependency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [GitHub] cordova-lib pull request: CB-3571: support for element in...

2014-06-20 Thread Axel Nennker
I ran jshint manually on the changed files and amended ConfigParser.js
which jshint complained about.
Axel


2014-06-20 22:06 GMT+02:00 Axel Nennker :

> I ran npm test but get a bunch of other errors. No idea what is wrong.
> Axel
>
> > npm run jasmine && npm run jshint
>
>
> > cordova-lib@0.21.4-dev jasmine /host/Cordova/cordova-lib/cordova-lib
> > jasmine-node --color spec-plugman spec-cordova
>
> ...cp:
> copyFileSync: could not write to dest file
> (code=ENOENT):/tmp/plugman-test/android_install
>
>
> F.
>
> Failures:
>
>   1) install success should check version if plugin has engine tag
>Message:
>  Expected spy satisfies to have been called with [ '2.5.0', '>=2.3.0'
> ] but actual calls were [ null, '>=2.3.0' ], [ '0.21.4-dev', '>=0.10.0' ],
> [ '2.5.0', '>=1.0.0' ], [ '2.5.0', '>=3.0.0' ]
>Stacktrace:
>  Error: Expected spy satisfies to have been called with [ '2.5.0',
> '>=2.3.0' ] but actual calls were [ null, '>=2.3.0' ], [ '0.21.4-dev',
> '>=0.10.0' ], [ '2.5.0', '>=1.0.0' ], [ '2.5.0', '>=3.0.0' ]
> at null.
> (/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:218:35)
> at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
>
>   2) install success should check version and munge it a little if it has
> "rc" in it so it plays nice with semver (introduce a dash in it)
>Message:
>  Expected spy satisfies to have been called with [ '3.0.0-rc1',
> '>=2.3.0' ] but actual calls were [ null, '>=2.3.0' ], [ '0.21.4-dev',
> '>=0.10.0' ], [ '3.0.0-rc1', '>=1.0.0' ], [ '3.0.0-rc1', '>=3.0.0' ]
>Stacktrace:
>  Error: Expected spy satisfies to have been called with [ '3.0.0-rc1',
> '>=2.3.0' ] but actual calls were [ null, '>=2.3.0' ], [ '0.21.4-dev',
> '>=0.10.0' ], [ '3.0.0-rc1', '>=1.0.0' ], [ '3.0.0-rc1', '>=3.0.0' ]
> at null.
> (/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:232:35)
> at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
>
>   3) install success should check specific platform version over cordova
> version if specified
>Message:
>  Expected spy satisfies to have been called with [ '3.1.0', '>=3.1.0'
> ] but actual calls were [ null, '>=3.0.0' ], [ null, '>=3.1.0' ], [ null,
> '>=18' ]
>Stacktrace:
>  Error: Expected spy satisfies to have been called with [ '3.1.0',
> '>=3.1.0' ] but actual calls were [ null, '>=3.0.0' ], [ null, '>=3.1.0' ],
> [ null, '>=18' ]
> at null.
> (/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:247:29)
> at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
>
>   4) install success should check platform sdk version if specified
>Message:
>  Expected [ null, '>=3.0.0' ] to equal [ '18.0.0', '>=3.0.0' ].
>Stacktrace:
>  Error: Expected [ null, '>=3.0.0' ] to equal [ '18.0.0', '>=3.0.0' ].
> at null.
> (/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:267:43)
> at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
>
>   5) install success should check platform sdk version if specified
>Message:
>  Expected [ null, '>=3.1.0' ] to equal [ '18.0.0', '>=3.1.0' ].
>Stacktrace:
>  Error: Expected [ null, '>=3.1.0' ] to equal [ '18.0.0', '>=3.1.0' ].
> at null.
> (/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:268:43)
> at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
>
>   6) install success should check platform sdk version if specified
>Message:
>  Expected [ null, '>=18' ] to equal [ '18.0.0', '>=18' ].
>Stacktrace:
>  Error: Expected [ null, '>=18' ] to equal [ '18.0.0', '>=18' ].
> at null.
> (/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:269:43)
> at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
>
>   7) install success should check engine versions
>Message:
>  Expected [ null, '>=2.3.0' ] to equal [ '', '>=2.3.0' ].
>Stacktrace:
>  Error: Expected [ null, '>=2.3.0' ] to equal [ '', '>=2.3.0' ].
> at null.
> (/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:289:43)
> at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)
>
> Finished in 11.773 seconds
> 617 tests, 872 assertions, 7 failures, 0 skipped
>
>
> npm ERR! weird error 1
> npm ERR! not ok code 0
> npm ERR! Test failed.  See above for more details.
> npm ERR! not ok code 0
> igni

Re: network-information memory leak

2014-06-20 Thread Jesse
What is leaked?
How are you proving that there is a leak, and it is indeed fixed?

All js callable cordova commands are backed by c# subclasses of BaseCommand
and their methods all have the same signature:

public void callableMethod(string);




@purplecabbage
risingj.com


On Fri, Jun 20, 2014 at 1:20 PM, Staci Cooper  wrote:

> I found another memory leak in windows phone. This time it involves the
> network information plugin.
>
> I found a fix:
>
> https://github.com/stacic/cordova-plugin-network-information/commit/d41118f0da0270d23cd699dc0766d377c9e8922a
>
> But I'm not sure I understand why it works. In addition to unsubscribing
> from some event handlers, it involves the getConnectionInfo function in
> NetworkStatus.js, which takes a string parameter called 'empty' that it
> does nothing with. If I get rid of that parameter the leak disappears.
>
> Does anybody know why it was there in the first place? I didn't see any
> problems after deleting it, but it seems odd.
>


network-information memory leak

2014-06-20 Thread Staci Cooper
I found another memory leak in windows phone. This time it involves the
network information plugin.

I found a fix:
https://github.com/stacic/cordova-plugin-network-information/commit/d41118f0da0270d23cd699dc0766d377c9e8922a

But I'm not sure I understand why it works. In addition to unsubscribing
from some event handlers, it involves the getConnectionInfo function in
NetworkStatus.js, which takes a string parameter called 'empty' that it
does nothing with. If I get rid of that parameter the leak disappears.

Does anybody know why it was there in the first place? I didn't see any
problems after deleting it, but it seems odd.


[GitHub] cordova-plugin-battery-status pull request: Minor doc corrections

2014-06-20 Thread bryanhiggins
GitHub user bryanhiggins opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/12

Minor doc corrections



You can merge this pull request into a Git repository by running:

$ git pull 
https://github.com/blackberry-webworks/cordova-plugin-battery-status docFix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit 4e262999be9a4a5caa6a1b78e548f92311c6f4af
Author: Bryan Higgins 
Date:   2014-06-20T20:11:20Z

Minor doc corrections




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [GitHub] cordova-lib pull request: CB-3571: support for element in...

2014-06-20 Thread Axel Nennker
I ran npm test but get a bunch of other errors. No idea what is wrong.
Axel

> npm run jasmine && npm run jshint


> cordova-lib@0.21.4-dev jasmine /host/Cordova/cordova-lib/cordova-lib
> jasmine-node --color spec-plugman spec-cordova

...cp:
copyFileSync: could not write to dest file
(code=ENOENT):/tmp/plugman-test/android_install

F.

Failures:

  1) install success should check version if plugin has engine tag
   Message:
 Expected spy satisfies to have been called with [ '2.5.0', '>=2.3.0' ]
but actual calls were [ null, '>=2.3.0' ], [ '0.21.4-dev', '>=0.10.0' ], [
'2.5.0', '>=1.0.0' ], [ '2.5.0', '>=3.0.0' ]
   Stacktrace:
 Error: Expected spy satisfies to have been called with [ '2.5.0',
'>=2.3.0' ] but actual calls were [ null, '>=2.3.0' ], [ '0.21.4-dev',
'>=0.10.0' ], [ '2.5.0', '>=1.0.0' ], [ '2.5.0', '>=3.0.0' ]
at null.
(/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:218:35)
at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

  2) install success should check version and munge it a little if it has
"rc" in it so it plays nice with semver (introduce a dash in it)
   Message:
 Expected spy satisfies to have been called with [ '3.0.0-rc1',
'>=2.3.0' ] but actual calls were [ null, '>=2.3.0' ], [ '0.21.4-dev',
'>=0.10.0' ], [ '3.0.0-rc1', '>=1.0.0' ], [ '3.0.0-rc1', '>=3.0.0' ]
   Stacktrace:
 Error: Expected spy satisfies to have been called with [ '3.0.0-rc1',
'>=2.3.0' ] but actual calls were [ null, '>=2.3.0' ], [ '0.21.4-dev',
'>=0.10.0' ], [ '3.0.0-rc1', '>=1.0.0' ], [ '3.0.0-rc1', '>=3.0.0' ]
at null.
(/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:232:35)
at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

  3) install success should check specific platform version over cordova
version if specified
   Message:
 Expected spy satisfies to have been called with [ '3.1.0', '>=3.1.0' ]
but actual calls were [ null, '>=3.0.0' ], [ null, '>=3.1.0' ], [ null,
'>=18' ]
   Stacktrace:
 Error: Expected spy satisfies to have been called with [ '3.1.0',
'>=3.1.0' ] but actual calls were [ null, '>=3.0.0' ], [ null, '>=3.1.0' ],
[ null, '>=18' ]
at null.
(/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:247:29)
at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

  4) install success should check platform sdk version if specified
   Message:
 Expected [ null, '>=3.0.0' ] to equal [ '18.0.0', '>=3.0.0' ].
   Stacktrace:
 Error: Expected [ null, '>=3.0.0' ] to equal [ '18.0.0', '>=3.0.0' ].
at null.
(/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:267:43)
at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

  5) install success should check platform sdk version if specified
   Message:
 Expected [ null, '>=3.1.0' ] to equal [ '18.0.0', '>=3.1.0' ].
   Stacktrace:
 Error: Expected [ null, '>=3.1.0' ] to equal [ '18.0.0', '>=3.1.0' ].
at null.
(/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:268:43)
at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

  6) install success should check platform sdk version if specified
   Message:
 Expected [ null, '>=18' ] to equal [ '18.0.0', '>=18' ].
   Stacktrace:
 Error: Expected [ null, '>=18' ] to equal [ '18.0.0', '>=18' ].
at null.
(/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:269:43)
at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

  7) install success should check engine versions
   Message:
 Expected [ null, '>=2.3.0' ] to equal [ '', '>=2.3.0' ].
   Stacktrace:
 Error: Expected [ null, '>=2.3.0' ] to equal [ '', '>=2.3.0' ].
at null.
(/host/Cordova/cordova-lib/cordova-lib/spec-plugman/install.spec.js:289:43)
at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

Finished in 11.773 seconds
617 tests, 872 assertions, 7 failures, 0 skipped


npm ERR! weird error 1
npm ERR! not ok code 0
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0
ignisvulpis@ubuntu:/host/Cordova/cordova-lib/cordova-lib$


[GitHub] cordova-wp8 pull request: CB-6977 Support chip architecture as an ...

2014-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-wp8/pull/42


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Amazon Fire Phone

2014-06-20 Thread Shazron
Jesse, that is cool o_O
Is anyone confused (well the market will be) with FireOS and
FirefoxOS? I don't think Amazon will budge on the name...


On Fri, Jun 20, 2014 at 12:01 PM, Jesse  wrote:
> Burner phone?
> Am I the first?
>
> @purplecabbage
> risingj.com
>
>
> On Fri, Jun 20, 2014 at 11:34 AM, Anis KADRI  wrote:
>
>> $649 (or $749) gets you an unlocked Amazon Fire phone.
>>
>> On Fri, Jun 20, 2014 at 8:11 AM, Mike Billau 
>> wrote:
>> > Does anybody know if the device will be available unlocked, or will the
>> > unlocked version be delayed like what Apple sometimes does?
>> > I've also been badgering for a device, but since we have to take the
>> > corporate path it will probably be a few days (weeks?) after July 25 that
>> > we get some.
>> >
>> >
>> > On Thu, Jun 19, 2014 at 4:42 PM, Michael Brooks <
>> mich...@michaelbrooks.ca>
>> > wrote:
>> >
>> >> Heads up, I believe we (Adobe) are getting one of the devices for
>> testing.
>> >>
>> >>
>> >> On Wed, Jun 18, 2014 at 12:41 PM, Carlos Santana 
>> >> wrote:
>> >>
>> >> > Announced today:
>> >> >
>> >> > http://www.amazon.com/gp/product/B00EOE0WKQ/
>> >> >
>> >> > Runs Fire OS 3.5
>> >> >
>> >> >
>> >>
>> https://developer.amazon.com/appsandservices/solutions/devices/fire-phone
>> >> >
>> >> >
>> >> > --
>> >> > Carlos Santana
>> >> > 
>> >> >
>> >>
>>


Re: CB-6994 - Windows 8 does not save big file transferred using Blob

2014-06-20 Thread Jesse
Saw it, thanks Maxime!

@purplecabbage
risingj.com


On Fri, Jun 20, 2014 at 11:32 AM, Maxime LUCE  wrote:

> Hi everybody,
>
> I just create an issue and its associated pull request for File Plugin in
> Windows 8.
>
> When trying to save Blob using FileWriter.write method, if the blob's size
> is too high, we get a stack overflow exception during the conversion of the
> blob into an basic array.
> WinRT (WinJS) provide a method to write Blob directly to the filesystem.
> It uses Streams so it's safe for memory.
>
> In the pull request we avoid the conversion of the Blob to ArrayBuffer and
> from ArrayBuffer to plain Array and we pass the blob directly to the
> FileProxy.
> In the FileProxy we use a specific method which saves the Blob to the file
> system by using a safe Stream method.
>
> More info at :
>
> http://code.msdn.microsoft.com/windowsapps/Blob-Sample-0e35889e/sourcecode?fileId=43594&pathId=962515806
> Method : writeBlobToFile
>
> Please review this fix and merge.
>
> Thanks
>
> 
> Maxime LUCE
> Touchify - CEO
> +33 6 28 60 72 34 | +1 415 481 9965
> max...@touchify.co | http://touchify.co
>
>


Re: [GitHub] cordova-plugin-file-transfer pull request: Update index.md

2014-06-20 Thread Jesse
Yeah, I am still pulling it in ...

@purplecabbage
risingj.com


On Fri, Jun 20, 2014 at 12:11 PM, cfjedimaster  wrote:

> Github user cfjedimaster commented on the pull request:
>
>
> https://github.com/apache/cordova-plugin-file-transfer/pull/33#issuecomment-46715751
>
> But when people alert the error, they see the #s, not the nice values.
> And yes, ideally, they would write a nice function like that. No one does.
> Why not simply document it for quick look up?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


[GitHub] cordova-plugin-file-transfer pull request: Update index.md

2014-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/33


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-file-transfer pull request: Update index.md

2014-06-20 Thread cfjedimaster
Github user cfjedimaster commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/33#issuecomment-46715751
  
But when people alert the error, they see the #s, not the nice values. And 
yes, ideally, they would write a nice function like that. No one does. Why not 
simply document it for quick look up?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


CB-6994 - Windows 8 does not save big file transferred using Blob

2014-06-20 Thread Maxime LUCE
Hi everybody,

I just create an issue and its associated pull request for File Plugin in 
Windows 8.

When trying to save Blob using FileWriter.write method, if the blob's size is 
too high, we get a stack overflow exception during the conversion of the blob 
into an basic array.
WinRT (WinJS) provide a method to write Blob directly to the filesystem. It 
uses Streams so it's safe for memory.

In the pull request we avoid the conversion of the Blob to ArrayBuffer and from 
ArrayBuffer to plain Array and we pass the blob directly to the FileProxy.
In the FileProxy we use a specific method which saves the Blob to the file 
system by using a safe Stream method.

More info at :
http://code.msdn.microsoft.com/windowsapps/Blob-Sample-0e35889e/sourcecode?fileId=43594&pathId=962515806
Method : writeBlobToFile

Please review this fix and merge.

Thanks


Maxime LUCE
Touchify - CEO
+33 6 28 60 72 34 | +1 415 481 9965
max...@touchify.co | http://touchify.co



[GitHub] cordova-plugin-file-transfer pull request: Update index.md

2014-06-20 Thread purplecabbage
Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/33#issuecomment-46715601
  
Ideally no-one outside of the plugin developer uses the numeric values.

Sample code should demonstrate this:
```
function errorCodeToMessage(errCode) {
if(errCode == FileTransferError.FILE_NOT_FOUND_ERR) {
return "Error: File Not Found";
}
...
}



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Amazon Fire Phone

2014-06-20 Thread Mike Billau
Thanks Anis


On Fri, Jun 20, 2014 at 3:01 PM, Jesse  wrote:

> Burner phone?
> Am I the first?
>
> @purplecabbage
> risingj.com
>
>
> On Fri, Jun 20, 2014 at 11:34 AM, Anis KADRI  wrote:
>
> > $649 (or $749) gets you an unlocked Amazon Fire phone.
> >
> > On Fri, Jun 20, 2014 at 8:11 AM, Mike Billau 
> > wrote:
> > > Does anybody know if the device will be available unlocked, or will the
> > > unlocked version be delayed like what Apple sometimes does?
> > > I've also been badgering for a device, but since we have to take the
> > > corporate path it will probably be a few days (weeks?) after July 25
> that
> > > we get some.
> > >
> > >
> > > On Thu, Jun 19, 2014 at 4:42 PM, Michael Brooks <
> > mich...@michaelbrooks.ca>
> > > wrote:
> > >
> > >> Heads up, I believe we (Adobe) are getting one of the devices for
> > testing.
> > >>
> > >>
> > >> On Wed, Jun 18, 2014 at 12:41 PM, Carlos Santana <
> csantan...@gmail.com>
> > >> wrote:
> > >>
> > >> > Announced today:
> > >> >
> > >> > http://www.amazon.com/gp/product/B00EOE0WKQ/
> > >> >
> > >> > Runs Fire OS 3.5
> > >> >
> > >> >
> > >>
> >
> https://developer.amazon.com/appsandservices/solutions/devices/fire-phone
> > >> >
> > >> >
> > >> > --
> > >> > Carlos Santana
> > >> > 
> > >> >
> > >>
> >
>


Re: Contacts API, iOS

2014-06-20 Thread Mike Billau
Just noticed this an hour ago as well. On Android, pickContact just doesn't
do anything, but some other people are reporting that the JavaScript itself
is hosed and the app won't load any .js - Ray, you didn't observe this on
iOS, right? It seems strange to me that an old version of the contact .js
would keep _any_ .js from loading.

In the mean time I am just going to direct people to get the plugin from
the git URL.


On Fri, Jun 20, 2014 at 2:43 PM, Ray Camden  wrote:

> If I had to guess, I'd say the docs lead to from docs.cordova.io are
> going to an unreleased version. If you go to the docs via
> plugins.cordova.io, you see the right docs.
>
> I *was* able to test by explicitly getting the plugin from the Git URL and
> it works cool - can't wait for this to "officially" land.
>
> 
> From: mmo...@google.com  on behalf of Michal Mocny <
> mmo...@chromium.org>
> Sent: Friday, June 20, 2014 1:36 PM
> To: Michal Mocny
> Cc: dev
> Subject: Re: Contacts API, iOS
>
> As far as the API documentation, and why iOS has a different interface.. I
> don't know the history, but this seems mighty confusing.  I think contacts
> plugin has been in need of some love for quite a while, but its been hard
> to get anyone excited about it.
>
> -Michal
>
>
> On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny  wrote:
>
> > Alright, sorry I got confused reading the history because of some
> > fast-forward merges.
> >
> > Seems all is well in the repo -- but the last plugins release Steven held
> > back contacts due to failing tests, hence whats up on plugins.cordova.io
> > being so stale.
> >
> > -Michal
> >
> >
> > On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny 
> wrote:
> >
> >> That may not be right at all.  Something seems fishy at first glance,
> but
> >> its hard to track the history.  Ian and I are looking at it.
> >>
> >>
> >> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny 
> >> wrote:
> >>
> >>> Looks like the last release was based on dev branch (
> >>>
> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js
> ),
> >>> which was closed, but maybe wasn't merged in to master?
> >>>
> >>> -Michal
> >>>
> >>>
> >>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden 
> wrote:
> >>>
>  Ok, so doing
> 
>  cordova plugin add org.apache.cordova.contacts
> 
>  brings in org.apache.cordova.contacts/www/contacts.js that does NOT
>  match what I'm seeing in
> 
> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js
> ,
>  which was last updated *2* months ago.
> 
>  Any ideas?
> 
>  
>  From: Ray Camden 
>  Sent: Friday, June 20, 2014 1:07 PM
>  To: dev@cordova.apache.org
>  Subject: Contacts API, iOS
> 
>  (I struggled with whether or not this should go here or the Google
>  Group. Settled on here but if folks think it should be moved, just
> let me
>  know.)
> 
>  I was building a small test of the pickContact API when I noticed it
>  didn't work in iOS. I opened up a remote debug session with Safari and
>  noticed it had chooseContact.
> 
>  Thinking it was just a doc bug, I corrected it with a pull request and
>  returned to my code. But then my app crashed after selecting a
> contact.
> 
>  From what I can see, the chooseContact iOS API is:
> 
>  chooseContact : function(successCallback, options) {
> 
>  not
> 
>  chooseContact : function(successCallback, errorCallback) {
> 
>  So something is seriously weird here compared to the original docs.
>  Anyone know what is going on with the plugin?
> 
> >>>
> >>>
> >>
> >
>


Re: Amazon Fire Phone

2014-06-20 Thread Jesse
Burner phone?
Am I the first?

@purplecabbage
risingj.com


On Fri, Jun 20, 2014 at 11:34 AM, Anis KADRI  wrote:

> $649 (or $749) gets you an unlocked Amazon Fire phone.
>
> On Fri, Jun 20, 2014 at 8:11 AM, Mike Billau 
> wrote:
> > Does anybody know if the device will be available unlocked, or will the
> > unlocked version be delayed like what Apple sometimes does?
> > I've also been badgering for a device, but since we have to take the
> > corporate path it will probably be a few days (weeks?) after July 25 that
> > we get some.
> >
> >
> > On Thu, Jun 19, 2014 at 4:42 PM, Michael Brooks <
> mich...@michaelbrooks.ca>
> > wrote:
> >
> >> Heads up, I believe we (Adobe) are getting one of the devices for
> testing.
> >>
> >>
> >> On Wed, Jun 18, 2014 at 12:41 PM, Carlos Santana 
> >> wrote:
> >>
> >> > Announced today:
> >> >
> >> > http://www.amazon.com/gp/product/B00EOE0WKQ/
> >> >
> >> > Runs Fire OS 3.5
> >> >
> >> >
> >>
> https://developer.amazon.com/appsandservices/solutions/devices/fire-phone
> >> >
> >> >
> >> > --
> >> > Carlos Santana
> >> > 
> >> >
> >>
>


[GitHub] cordova-js pull request: CB-6983 misleading debug statement

2014-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/71


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: Contacts API, iOS

2014-06-20 Thread Ray Camden
If I had to guess, I'd say the docs lead to from docs.cordova.io are going to 
an unreleased version. If you go to the docs via plugins.cordova.io, you see 
the right docs. 

I *was* able to test by explicitly getting the plugin from the Git URL and it 
works cool - can't wait for this to "officially" land.


From: mmo...@google.com  on behalf of Michal Mocny 

Sent: Friday, June 20, 2014 1:36 PM
To: Michal Mocny
Cc: dev
Subject: Re: Contacts API, iOS

As far as the API documentation, and why iOS has a different interface.. I
don't know the history, but this seems mighty confusing.  I think contacts
plugin has been in need of some love for quite a while, but its been hard
to get anyone excited about it.

-Michal


On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny  wrote:

> Alright, sorry I got confused reading the history because of some
> fast-forward merges.
>
> Seems all is well in the repo -- but the last plugins release Steven held
> back contacts due to failing tests, hence whats up on plugins.cordova.io
> being so stale.
>
> -Michal
>
>
> On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny  wrote:
>
>> That may not be right at all.  Something seems fishy at first glance, but
>> its hard to track the history.  Ian and I are looking at it.
>>
>>
>> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny 
>> wrote:
>>
>>> Looks like the last release was based on dev branch (
>>> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
>>> which was closed, but maybe wasn't merged in to master?
>>>
>>> -Michal
>>>
>>>
>>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden  wrote:
>>>
 Ok, so doing

 cordova plugin add org.apache.cordova.contacts

 brings in org.apache.cordova.contacts/www/contacts.js that does NOT
 match what I'm seeing in
 https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
 which was last updated *2* months ago.

 Any ideas?

 
 From: Ray Camden 
 Sent: Friday, June 20, 2014 1:07 PM
 To: dev@cordova.apache.org
 Subject: Contacts API, iOS

 (I struggled with whether or not this should go here or the Google
 Group. Settled on here but if folks think it should be moved, just let me
 know.)

 I was building a small test of the pickContact API when I noticed it
 didn't work in iOS. I opened up a remote debug session with Safari and
 noticed it had chooseContact.

 Thinking it was just a doc bug, I corrected it with a pull request and
 returned to my code. But then my app crashed after selecting a contact.

 From what I can see, the chooseContact iOS API is:

 chooseContact : function(successCallback, options) {

 not

 chooseContact : function(successCallback, errorCallback) {

 So something is seriously weird here compared to the original docs.
 Anyone know what is going on with the plugin?

>>>
>>>
>>
>


Re: Contacts API, iOS

2014-06-20 Thread Michal Mocny
As far as the API documentation, and why iOS has a different interface.. I
don't know the history, but this seems mighty confusing.  I think contacts
plugin has been in need of some love for quite a while, but its been hard
to get anyone excited about it.

-Michal


On Fri, Jun 20, 2014 at 2:30 PM, Michal Mocny  wrote:

> Alright, sorry I got confused reading the history because of some
> fast-forward merges.
>
> Seems all is well in the repo -- but the last plugins release Steven held
> back contacts due to failing tests, hence whats up on plugins.cordova.io
> being so stale.
>
> -Michal
>
>
> On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny  wrote:
>
>> That may not be right at all.  Something seems fishy at first glance, but
>> its hard to track the history.  Ian and I are looking at it.
>>
>>
>> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny 
>> wrote:
>>
>>> Looks like the last release was based on dev branch (
>>> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
>>> which was closed, but maybe wasn't merged in to master?
>>>
>>> -Michal
>>>
>>>
>>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden  wrote:
>>>
 Ok, so doing

 cordova plugin add org.apache.cordova.contacts

 brings in org.apache.cordova.contacts/www/contacts.js that does NOT
 match what I'm seeing in
 https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
 which was last updated *2* months ago.

 Any ideas?

 
 From: Ray Camden 
 Sent: Friday, June 20, 2014 1:07 PM
 To: dev@cordova.apache.org
 Subject: Contacts API, iOS

 (I struggled with whether or not this should go here or the Google
 Group. Settled on here but if folks think it should be moved, just let me
 know.)

 I was building a small test of the pickContact API when I noticed it
 didn't work in iOS. I opened up a remote debug session with Safari and
 noticed it had chooseContact.

 Thinking it was just a doc bug, I corrected it with a pull request and
 returned to my code. But then my app crashed after selecting a contact.

 From what I can see, the chooseContact iOS API is:

 chooseContact : function(successCallback, options) {

 not

 chooseContact : function(successCallback, errorCallback) {

 So something is seriously weird here compared to the original docs.
 Anyone know what is going on with the plugin?

>>>
>>>
>>
>


Re: Amazon Fire Phone

2014-06-20 Thread Anis KADRI
$649 (or $749) gets you an unlocked Amazon Fire phone.

On Fri, Jun 20, 2014 at 8:11 AM, Mike Billau  wrote:
> Does anybody know if the device will be available unlocked, or will the
> unlocked version be delayed like what Apple sometimes does?
> I've also been badgering for a device, but since we have to take the
> corporate path it will probably be a few days (weeks?) after July 25 that
> we get some.
>
>
> On Thu, Jun 19, 2014 at 4:42 PM, Michael Brooks 
> wrote:
>
>> Heads up, I believe we (Adobe) are getting one of the devices for testing.
>>
>>
>> On Wed, Jun 18, 2014 at 12:41 PM, Carlos Santana 
>> wrote:
>>
>> > Announced today:
>> >
>> > http://www.amazon.com/gp/product/B00EOE0WKQ/
>> >
>> > Runs Fire OS 3.5
>> >
>> >
>> https://developer.amazon.com/appsandservices/solutions/devices/fire-phone
>> >
>> >
>> > --
>> > Carlos Santana
>> > 
>> >
>>


Re: Contacts API, iOS

2014-06-20 Thread Michal Mocny
Alright, sorry I got confused reading the history because of some
fast-forward merges.

Seems all is well in the repo -- but the last plugins release Steven held
back contacts due to failing tests, hence whats up on plugins.cordova.io
being so stale.

-Michal


On Fri, Jun 20, 2014 at 2:23 PM, Michal Mocny  wrote:

> That may not be right at all.  Something seems fishy at first glance, but
> its hard to track the history.  Ian and I are looking at it.
>
>
> On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny  wrote:
>
>> Looks like the last release was based on dev branch (
>> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
>> which was closed, but maybe wasn't merged in to master?
>>
>> -Michal
>>
>>
>> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden  wrote:
>>
>>> Ok, so doing
>>>
>>> cordova plugin add org.apache.cordova.contacts
>>>
>>> brings in org.apache.cordova.contacts/www/contacts.js that does NOT
>>> match what I'm seeing in
>>> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
>>> which was last updated *2* months ago.
>>>
>>> Any ideas?
>>>
>>> 
>>> From: Ray Camden 
>>> Sent: Friday, June 20, 2014 1:07 PM
>>> To: dev@cordova.apache.org
>>> Subject: Contacts API, iOS
>>>
>>> (I struggled with whether or not this should go here or the Google
>>> Group. Settled on here but if folks think it should be moved, just let me
>>> know.)
>>>
>>> I was building a small test of the pickContact API when I noticed it
>>> didn't work in iOS. I opened up a remote debug session with Safari and
>>> noticed it had chooseContact.
>>>
>>> Thinking it was just a doc bug, I corrected it with a pull request and
>>> returned to my code. But then my app crashed after selecting a contact.
>>>
>>> From what I can see, the chooseContact iOS API is:
>>>
>>> chooseContact : function(successCallback, options) {
>>>
>>> not
>>>
>>> chooseContact : function(successCallback, errorCallback) {
>>>
>>> So something is seriously weird here compared to the original docs.
>>> Anyone know what is going on with the plugin?
>>>
>>
>>
>


Re: Contacts API, iOS

2014-06-20 Thread Michal Mocny
That may not be right at all.  Something seems fishy at first glance, but
its hard to track the history.  Ian and I are looking at it.


On Fri, Jun 20, 2014 at 2:18 PM, Michal Mocny  wrote:

> Looks like the last release was based on dev branch (
> https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
> which was closed, but maybe wasn't merged in to master?
>
> -Michal
>
>
> On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden  wrote:
>
>> Ok, so doing
>>
>> cordova plugin add org.apache.cordova.contacts
>>
>> brings in org.apache.cordova.contacts/www/contacts.js that does NOT match
>> what I'm seeing in
>> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
>> which was last updated *2* months ago.
>>
>> Any ideas?
>>
>> 
>> From: Ray Camden 
>> Sent: Friday, June 20, 2014 1:07 PM
>> To: dev@cordova.apache.org
>> Subject: Contacts API, iOS
>>
>> (I struggled with whether or not this should go here or the Google Group.
>> Settled on here but if folks think it should be moved, just let me know.)
>>
>> I was building a small test of the pickContact API when I noticed it
>> didn't work in iOS. I opened up a remote debug session with Safari and
>> noticed it had chooseContact.
>>
>> Thinking it was just a doc bug, I corrected it with a pull request and
>> returned to my code. But then my app crashed after selecting a contact.
>>
>> From what I can see, the chooseContact iOS API is:
>>
>> chooseContact : function(successCallback, options) {
>>
>> not
>>
>> chooseContact : function(successCallback, errorCallback) {
>>
>> So something is seriously weird here compared to the original docs.
>> Anyone know what is going on with the plugin?
>>
>
>


[GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...

2014-06-20 Thread fberton
GitHub user fberton opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/54

CB-6994 - Windows 8 does not save big file transferred using Blob

When trying to save Blob using FileWriter.write method, if the blob's size 
is too high, we get a stack overflow exception during the conversion of the 
blob into an basic array.

In order to avoid this exception, we pass the Blob or File directly in 
FileProxy (avoid the conversion to ArrayBuffer) and we use a specific method in 
FileProxy to save the Blob directly to the filesystem by using Streams (safe).

More info at : https://issues.apache.org/jira/browse/CB-6994

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Touchit/cordova-plugin-file CB-6994

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit 823d2ff100757b21411e990633d084482bbca52e
Author: Florian BERTON 
Date:   2014-06-20T17:22:16Z

Fix function write for big files on windows 8




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Contacts API, iOS

2014-06-20 Thread Michal Mocny
Looks like the last release was based on dev branch (
https://github.com/apache/cordova-plugin-contacts/blob/55ba3f2580d2c3bbd1662f49d89043710446220a/www/contacts.js),
which was closed, but maybe wasn't merged in to master?

-Michal


On Fri, Jun 20, 2014 at 2:10 PM, Ray Camden  wrote:

> Ok, so doing
>
> cordova plugin add org.apache.cordova.contacts
>
> brings in org.apache.cordova.contacts/www/contacts.js that does NOT match
> what I'm seeing in
> https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js,
> which was last updated *2* months ago.
>
> Any ideas?
>
> 
> From: Ray Camden 
> Sent: Friday, June 20, 2014 1:07 PM
> To: dev@cordova.apache.org
> Subject: Contacts API, iOS
>
> (I struggled with whether or not this should go here or the Google Group.
> Settled on here but if folks think it should be moved, just let me know.)
>
> I was building a small test of the pickContact API when I noticed it
> didn't work in iOS. I opened up a remote debug session with Safari and
> noticed it had chooseContact.
>
> Thinking it was just a doc bug, I corrected it with a pull request and
> returned to my code. But then my app crashed after selecting a contact.
>
> From what I can see, the chooseContact iOS API is:
>
> chooseContact : function(successCallback, options) {
>
> not
>
> chooseContact : function(successCallback, errorCallback) {
>
> So something is seriously weird here compared to the original docs. Anyone
> know what is going on with the plugin?
>


[GitHub] cordova-plugin-contacts pull request: Fix docs for Android

2014-06-20 Thread mbillau
Github user mbillau closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Contacts API, iOS

2014-06-20 Thread Ray Camden
(I struggled with whether or not this should go here or the Google Group. 
Settled on here but if folks think it should be moved, just let me know.)

I was building a small test of the pickContact API when I noticed it didn't 
work in iOS. I opened up a remote debug session with Safari and noticed it had 
chooseContact.

Thinking it was just a doc bug, I corrected it with a pull request and returned 
to my code. But then my app crashed after selecting a contact.

>From what I can see, the chooseContact iOS API is:

chooseContact : function(successCallback, options) {

not

chooseContact : function(successCallback, errorCallback) {

So something is seriously weird here compared to the original docs. Anyone know 
what is going on with the plugin?


RE: Contacts API, iOS

2014-06-20 Thread Ray Camden
Ok, so doing

cordova plugin add org.apache.cordova.contacts

brings in org.apache.cordova.contacts/www/contacts.js that does NOT match what 
I'm seeing in 
https://github.com/apache/cordova-plugin-contacts/blob/master/www/contacts.js, 
which was last updated *2* months ago. 

Any ideas?


From: Ray Camden 
Sent: Friday, June 20, 2014 1:07 PM
To: dev@cordova.apache.org
Subject: Contacts API, iOS

(I struggled with whether or not this should go here or the Google Group. 
Settled on here but if folks think it should be moved, just let me know.)

I was building a small test of the pickContact API when I noticed it didn't 
work in iOS. I opened up a remote debug session with Safari and noticed it had 
chooseContact.

Thinking it was just a doc bug, I corrected it with a pull request and returned 
to my code. But then my app crashed after selecting a contact.

>From what I can see, the chooseContact iOS API is:

chooseContact : function(successCallback, options) {

not

chooseContact : function(successCallback, errorCallback) {

So something is seriously weird here compared to the original docs. Anyone know 
what is going on with the plugin?


[GitHub] cordova-plugin-contacts pull request: Update index.md

2014-06-20 Thread cfjedimaster
Github user cfjedimaster closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/31


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-contacts pull request: Update index.md

2014-06-20 Thread cfjedimaster
Github user cfjedimaster commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/31#issuecomment-46709107
  
Nope, this is bad - sorry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-contacts pull request: Update index.md

2014-06-20 Thread cfjedimaster
GitHub user cfjedimaster opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/31

Update index.md

API docs mentioned pickContact, but at least in iOS it was chooseContact.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cfjedimaster/cordova-plugin-contacts patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit e639a8556420cf8438a92676a73c8379e093a5d2
Author: Raymond Camden 
Date:   2014-06-20T17:58:37Z

Update index.md

API docs mentioned pickContact, but at least in iOS it was chooseContact.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-windows pull request: CB-6976 Add support for Windows Univ...

2014-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-camera pull request: Update index.md

2014-06-20 Thread cfjedimaster
GitHub user cfjedimaster opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/35

Update index.md

I added some information about the defaults based on what I saw here: 
https://github.com/apache/cordova-plugin-camera/blob/master/www/Camera.js

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cfjedimaster/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit c07fb713cc3e951406a0802d1a842fd9231e3adf
Author: Raymond Camden 
Date:   2014-06-20T17:34:24Z

Update index.md

I added some information about the defaults based on what I saw here: 
https://github.com/apache/cordova-plugin-camera/blob/master/www/Camera.js




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/181#discussion_r14030680
  
--- Diff: src/cli.js ---
@@ -165,6 +165,20 @@ function cli(inputArgs) {
 throw new CordovaError(msg)
 }
 
+// CB-6976 Windows Universal Apps. Allow mixing windows and 
windows8 aliases
+opts.platforms = opts.platforms.map(function(platform) {
+// allow using old windows8 alias for new unified windows 
platform
+if (platform == 'windows8' && 
require('fs').existsSync('platforms/windows')) {
+return 'windows';
+} 
+// allow using new windows alias for old windows8 platform
+if (platform == 'windows' && 
!require('fs').existsSync('platforms/windows') 
+&& require('fs').existsSync('platforms/windows8')) {
+return 'windows8';
--- End diff --

Discussion is here.
http://markmail.org/message/v5pul7xqzp5ndnto


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/181#discussion_r14030140
  
--- Diff: src/cli.js ---
@@ -165,6 +165,20 @@ function cli(inputArgs) {
 throw new CordovaError(msg)
 }
 
+// CB-6976 Windows Universal Apps. Allow mixing windows and 
windows8 aliases
+opts.platforms = opts.platforms.map(function(platform) {
+// allow using old windows8 alias for new unified windows 
platform
--- End diff --

That is fine, and already discussed and decided. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread kamrik
Github user kamrik commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/181#discussion_r14029634
  
--- Diff: src/cli.js ---
@@ -165,6 +165,20 @@ function cli(inputArgs) {
 throw new CordovaError(msg)
 }
 
+// CB-6976 Windows Universal Apps. Allow mixing windows and 
windows8 aliases
+opts.platforms = opts.platforms.map(function(platform) {
+// allow using old windows8 alias for new unified windows 
platform
--- End diff --

Do we really want to allow that? Sounds like it's better to warn here and 
ask to stop using the windows8 alias. If they already know about the unified 
platform and even added it, why would they use the windows8 alias? And if they 
do out of habit, why would we encourage that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread kamrik
Github user kamrik commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/181#discussion_r14029489
  
--- Diff: src/cli.js ---
@@ -165,6 +165,20 @@ function cli(inputArgs) {
 throw new CordovaError(msg)
 }
 
+// CB-6976 Windows Universal Apps. Allow mixing windows and 
windows8 aliases
+opts.platforms = opts.platforms.map(function(platform) {
+// allow using old windows8 alias for new unified windows 
platform
+if (platform == 'windows8' && 
require('fs').existsSync('platforms/windows')) {
+return 'windows';
+} 
+// allow using new windows alias for old windows8 platform
+if (platform == 'windows' && 
!require('fs').existsSync('platforms/windows') 
+&& require('fs').existsSync('platforms/windows8')) {
+return 'windows8';
--- End diff --

Looks like this makes it impossible to use whatever is in platforms/windows.
Both widows and windows8 platforms passed to the cli will refer to 
platforms/windows8
Is this the intent?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread kamrik
Github user kamrik commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/181#discussion_r14029357
  
--- Diff: src/cli.js ---
@@ -165,6 +165,20 @@ function cli(inputArgs) {
 throw new CordovaError(msg)
 }
 
+// CB-6976 Windows Universal Apps. Allow mixing windows and 
windows8 aliases
+opts.platforms = opts.platforms.map(function(platform) {
+// allow using old windows8 alias for new unified windows 
platform
+if (platform == 'windows8' && 
require('fs').existsSync('platforms/windows')) {
--- End diff --

please, require('fs') at the top of the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: [CB-6140] Don't allow deletion of platfo...

2014-06-20 Thread kamrik
Github user kamrik commented on the pull request:

https://github.com/apache/cordova-lib/pull/38#issuecomment-46700279
  
Merged it. But it would be awesome if at this opportunity you could also 
replace the direct XML parsing of the plugin.xml with PluginInfo object and 
PluginInfo.getDependencies(platform) which, I think, already does the right 
thing, though it looks under current platform rather than all the platforms.
PluginInfo usage examples can be found in plubman/insatll.js


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: [CB-6140] Don't allow deletion of platfo...

2014-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/38


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Getting " 'type' of undefined " in LogCat

2014-06-20 Thread Josh Soref
‎Ray wrote:‎
> In general, support questions should be posted to Stack Overflow, or the 
> Google group.
> This list is for the *development* of Cordova itself.

> That being said, you probably forgot to add the plugin.
 ‎
Ray is probably right, but I'll add two other notes:

>  src="../../js/cordova-2.2.0.js">

The current version of Cordova is 3.5...

> function checkConnection() {
> var networkState = navigator.connection.type;
> var states = {};
> states[Connection.UNKNOWN] = 'Unknown connection';
...
> states[Connection.NONE] = 'No network connection';

You really shouldn't build an object like this for one time use. Either create 
the object once somewhere, or use a switch statement.

> alert('Connection type: ' + states[networkState]);
> }



RE: Getting " 'type' of undefined " in LogCat

2014-06-20 Thread Ray Camden
In general, support questions should be posted to Stack Overflow, or the Google 
group. This list is for the *development* of Cordova itself.

That being said, you probably forgot to add the plugin. Follow the instructions 
here:

https://github.com/apache/cordova-plugin-network-information/blob/master/doc/index.md

From: dheeraj.she...@thomsonreuters.com 
Sent: Friday, June 20, 2014 8:56 AM
To: dev@cordova.apache.org
Subject: Getting  " 'type' of undefined " in LogCat

Hi,

  We are developing a android app using Cordova. We are trying to detect the 
network connection ,we are not able to get the network connection. Please guide 
us on this regard.

Sample code  for your reference,



  
navigator.connection.type Example




// Wait for device API libraries to load
//
document.addEventListener("deviceready", onDeviceReady, false);

// device APIs are available
//
function onDeviceReady() {
checkConnection();
}

function checkConnection() {


var networkState = navigator.connection.type;

var states = {};
states[Connection.UNKNOWN]  = 'Unknown connection';
states[Connection.ETHERNET] = 'Ethernet connection';
states[Connection.WIFI] = 'WiFi connection';
states[Connection.CELL_2G]  = 'Cell 2G connection';
states[Connection.CELL_3G]  = 'Cell 3G connection';
states[Connection.CELL_4G]  = 'Cell 4G connection';
states[Connection.CELL] = 'Cell generic connection';
states[Connection.NONE] = 'No network connection';

alert('Connection type: ' + states[networkState]);
}


  
  
A dialog box will report the network state.
  


Regards,
Dheeraj


Getting " 'type' of undefined " in LogCat

2014-06-20 Thread dheeraj.shetty
Hi,

  We are developing a android app using Cordova. We are trying to detect the 
network connection ,we are not able to get the network connection. Please guide 
us on this regard.

Sample code  for your reference,



  
navigator.connection.type Example




// Wait for device API libraries to load
//
document.addEventListener("deviceready", onDeviceReady, false);

// device APIs are available
//
function onDeviceReady() {
checkConnection();
}

function checkConnection() {


var networkState = navigator.connection.type;

var states = {};
states[Connection.UNKNOWN]  = 'Unknown connection';
states[Connection.ETHERNET] = 'Ethernet connection';
states[Connection.WIFI] = 'WiFi connection';
states[Connection.CELL_2G]  = 'Cell 2G connection';
states[Connection.CELL_3G]  = 'Cell 3G connection';
states[Connection.CELL_4G]  = 'Cell 4G connection';
states[Connection.CELL] = 'Cell generic connection';
states[Connection.NONE] = 'No network connection';

alert('Connection type: ' + states[networkState]);
}


  
  
A dialog box will report the network state.
  


Regards,
Dheeraj


Re: Should use only drawable folder for single application icon

2014-06-20 Thread Joe Bowser
I don't see the point of the change.  However, you can re-open the
issue and assign it to yourself.

On Fri, Jun 20, 2014 at 6:47 AM, Andrew Grieve  wrote:
> I didn't see any reason against deleting the default icons in there. To be
> clear, what we're talking about is:
>
> CLI's config.xml has an icon:
>   Yes: Delete template icons then copy in
>   No: Leave template icons
>
> Right now what happens is:
>   Yes: Leave template icons and copy in app icons
>   No: Leave template icons
>
> It's a subtle change, but a good one I think.
>
>
>
>
>
> On Thu, Jun 19, 2014 at 10:03 PM, Joe Bowser  wrote:
>
>> On Thu, Jun 19, 2014 at 6:01 PM, Andrew Grieve 
>> wrote:
>> > I don't think it should resize it, but I do agree we should delete the
>> > template ones if any are present. Right now you aren't sure if the 
>> > tag even did anything if you fail to replace the right size.
>>
>> The icon tag is ignored entirely if you're not using the CLI, and it's
>> only a CLI thing.  The problem I have with this right now is that it
>> doesn't provide a good solution to this problem, since as you stated
>> earlier, you won't get through App Store review on iOS, and Android
>> requires numerous icons when you submit your app anyway.  This stupid
>> anti-feature is what's preventing the platforms from being treated as
>> build artifacts.
>>
>> > Android and
>> > iOS both do a pretty good job at resizing at runtime if only one large
>> icon
>> > is present (although you won't get through app-store review).
>> >
>>
>> I disagree about Android doing a good job.  We just don't notice it
>> because we happen to have stupidly high quality template icons and we
>> mostly test on hdpi and xhdpi devices.  I'm sure if I ran this on an
>> mdpi or ldpi device, the icon would be all distorted.
>>
>> >
>> >
>> >
>> > On Thu, Jun 19, 2014 at 5:17 PM, Joe Bowser  wrote:
>> >
>> >> So, it resizes the icon? If not, then the point is still valid.
>> >> On Jun 19, 2014 2:11 PM, "Darryl Pogue"  wrote:
>> >>
>> >> > On 19 June 2014 13:52, Joe Bowser  wrote:
>> >> > > > It's really not neccessary to have 5 not similar, but exactly same
>> >> icon
>> >> > > > files, when we can have only 1 icon file.
>> >> > >
>> >> > > People should be changing their icons anyway, and I don't believe we
>> >> > > actually landed any support for the icon element in config.xml.
>> >> >
>> >> > This support landed in cordova-cli 3.5.0.
>> >> >
>> >>
>>


Re: Amazon Fire Phone

2014-06-20 Thread Mike Billau
Does anybody know if the device will be available unlocked, or will the
unlocked version be delayed like what Apple sometimes does?
I've also been badgering for a device, but since we have to take the
corporate path it will probably be a few days (weeks?) after July 25 that
we get some.


On Thu, Jun 19, 2014 at 4:42 PM, Michael Brooks 
wrote:

> Heads up, I believe we (Adobe) are getting one of the devices for testing.
>
>
> On Wed, Jun 18, 2014 at 12:41 PM, Carlos Santana 
> wrote:
>
> > Announced today:
> >
> > http://www.amazon.com/gp/product/B00EOE0WKQ/
> >
> > Runs Fire OS 3.5
> >
> >
> https://developer.amazon.com/appsandservices/solutions/devices/fire-phone
> >
> >
> > --
> > Carlos Santana
> > 
> >
>


[GitHub] cordova-lib pull request: CB-3571: support for element in...

2014-06-20 Thread kamrik
Github user kamrik commented on the pull request:

https://github.com/apache/cordova-lib/pull/30#issuecomment-46689209
  
For this particular PR. Thanks for fixing the indentation.
With JSHint added yesterday, "npm test" now runs JSHint on all the files. 
Please run it and fix the JSHint errors, they are minor, mostly about forgotten 
"var"s.
If you want to disable the constraint for consistent quotation marks, use 
quotmark:false in JSHint config line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-3571: support for element in...

2014-06-20 Thread kamrik
Github user kamrik commented on the pull request:

https://github.com/apache/cordova-lib/pull/30#issuecomment-46688510
  
The "Merge remote..." commits are not that horrible, we have plenty of 
those in our repos and they have some benefits. But if you want to avoid them, 
try some of the below

git checkout YourBranch
git rebase master
git checkout master
git merge YourBranch
OR
git checkout master
git cherry-pick 

The disadvantage is that it creates a new commit with (nearly) identical 
content but different hash. But we often do it anyway when editing a commit 
message with git commit --amend to add stuff like 
github: clonse PRnumber

A simple and somewhat brutal way of squashing a pull request into a single 
commit without preserving authorship or any other info from the original 
commits in the PR
curl https://github.com/apache/cordova-lib/pull/30.diff | git apply

A similar way to just apply all the commits from a PR onto you current HEAD 
while preserving all the commit info. Similar to first rebasing and then 
merging.
curl https://github.com/apache/cordova-lib/pull/30.patch | git am

In some cases, if the conflicts are annoying enough, I just use a graphical 
diffing/merging tool (like meld) between two independent clones of the repo to 
copy the changes as a new commit on top of master. Especially when I need to 
break one commit into several (the opposite of squashing).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-file-transfer pull request: Update index.md

2014-06-20 Thread cfjedimaster
GitHub user cfjedimaster opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/33

Update index.md

Simply add the values for the constants.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cfjedimaster/cordova-plugin-file-transfer 
patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #33


commit 318c9412bca4ae8e2398085b24f9d727c124e0fb
Author: Raymond Camden 
Date:   2014-06-20T14:48:25Z

Update index.md

Simply add the values for the constants.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-20 Thread jonathandelgado
Github user jonathandelgado commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46686865
  
@clelland Thanks for that! Forgot about that functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: CB-6728 Support chip architecture

2014-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/180


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-20 Thread clelland
Github user clelland commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46683835
  
If you want to use this right now, you can install from github directly:

cordova plugin add 
https://github.com/apache/cordova-plugin-network-information.git

You don't technically need to wait for an official release if you just want 
this bug fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Should use only drawable folder for single application icon

2014-06-20 Thread Andrew Grieve
I didn't see any reason against deleting the default icons in there. To be
clear, what we're talking about is:

CLI's config.xml has an icon:
  Yes: Delete template icons then copy in
  No: Leave template icons

Right now what happens is:
  Yes: Leave template icons and copy in app icons
  No: Leave template icons

It's a subtle change, but a good one I think.





On Thu, Jun 19, 2014 at 10:03 PM, Joe Bowser  wrote:

> On Thu, Jun 19, 2014 at 6:01 PM, Andrew Grieve 
> wrote:
> > I don't think it should resize it, but I do agree we should delete the
> > template ones if any are present. Right now you aren't sure if the 
> > tag even did anything if you fail to replace the right size.
>
> The icon tag is ignored entirely if you're not using the CLI, and it's
> only a CLI thing.  The problem I have with this right now is that it
> doesn't provide a good solution to this problem, since as you stated
> earlier, you won't get through App Store review on iOS, and Android
> requires numerous icons when you submit your app anyway.  This stupid
> anti-feature is what's preventing the platforms from being treated as
> build artifacts.
>
> > Android and
> > iOS both do a pretty good job at resizing at runtime if only one large
> icon
> > is present (although you won't get through app-store review).
> >
>
> I disagree about Android doing a good job.  We just don't notice it
> because we happen to have stupidly high quality template icons and we
> mostly test on hdpi and xhdpi devices.  I'm sure if I ran this on an
> mdpi or ldpi device, the icon would be all distorted.
>
> >
> >
> >
> > On Thu, Jun 19, 2014 at 5:17 PM, Joe Bowser  wrote:
> >
> >> So, it resizes the icon? If not, then the point is still valid.
> >> On Jun 19, 2014 2:11 PM, "Darryl Pogue"  wrote:
> >>
> >> > On 19 June 2014 13:52, Joe Bowser  wrote:
> >> > > > It's really not neccessary to have 5 not similar, but exactly same
> >> icon
> >> > > > files, when we can have only 1 icon file.
> >> > >
> >> > > People should be changing their icons anyway, and I don't believe we
> >> > > actually landed any support for the icon element in config.xml.
> >> >
> >> > This support landed in cordova-cli 3.5.0.
> >> >
> >>
>


[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...

2014-06-20 Thread jonathandelgado
Github user jonathandelgado commented on the pull request:


https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46679052
  
+1 for bump


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-cli pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread sgrebnov
GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-cli/pull/181

CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)

https://issues.apache.org/jira/browse/CB-6976

* Allow using new windows alias to work with old windows8 platform
* Allow using old windows8 alias to work with new windows universal apps

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-cli win81

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #181


commit 4de816dd5f9454f35ea75b8667fe55c4b8868483
Author: sgrebnov 
Date:   2014-06-20T13:17:45Z

CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-6976 Add support for Windows Universa...

2014-06-20 Thread sgrebnov
GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-lib/pull/39

CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)

https://issues.apache.org/jira/browse/CB-6976

* Added new windows platform
* New platform can detect and correctly build both old Windows8 and new 
Windows project templates
* To have existing plugins working and for smooth transition added logic to 
re-use windows8 configuration settings (plugin.xml, config.xml).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib win81

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #39


commit 7ed25a53a793a2af3ff3bc51799ef65fa302a643
Author: sgrebnov 
Date:   2014-06-20T12:53:45Z

CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-plugin-splashscreen pull request: Fix logic when setting t...

2014-06-20 Thread stevesims
Github user stevesims commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/19#issuecomment-46674239
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-windows pull request: CB-6976 Add support for Windows Univ...

2014-06-20 Thread sgrebnov
GitHub user sgrebnov opened a pull request:

https://github.com/apache/cordova-windows/pull/35

CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)

https://issues.apache.org/jira/browse/CB-6976

* Renamed windows8 platform to windows. 
* Windows platform can build apps for Windows 8, Windows 8.1 and Windows 
Phone 8.1 (project is now based on Windows Universal app template).
* There is separate solution just for Windows 8.0 to be able to build 
platform using Visual Studio 2012 (build script automatically handles this 
case).
* Update script can update existing windows8 template a new one (cordova 
platform update windows8).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows win81

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit 29d15d6ef847d430747a7abdd9ed7c95d0289f85
Author: sgrebnov 
Date:   2014-06-20T11:38:19Z

CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-lib pull request: CB-3571: support for element in...

2014-06-20 Thread AxelNennker
Github user AxelNennker commented on the pull request:

https://github.com/apache/cordova-lib/pull/30#issuecomment-46670164
  
@jsoref How do I do the rebase to get rid of "Merge remote-tracking branch 
'upstream/master'" commits.
I wrecked my other repo (for cordova-cli) so I am cautious.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---