[Freeciv-Dev] [patch #7735] Goods help page

2016-10-01 Thread Jacob Nevins 
Follow-up Comment #2, patch #7735 (project freeciv):

This causes my Qt-client build to die:


helpdlg.cpp: In member function 'void help_widget::set_topic(const
help_item*)':
helpdlg.cpp:668:10: error: enumeration value 'HELP_GOODS' not handled in
switch [-Werror=switch]


Patch #7740, once submitted, will presumably resolve this.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24725] Animal nation can be created with no cities or units

2016-10-01 Thread Marko Lindqvist 
Follow-up Comment #1, bug #24725 (project freeciv):

Even if the nation dies at first turn, it has a player slot assigned. For lua
scripting purposes I'd rather be consistent about existence of that slot on
animals > 0 games -> keep current behavior.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25070] civ2civ3: prevent building Harbour next to Lake

2016-10-01 Thread Jacob Nevins 
Update of bug #25070 (project freeciv):

 Assigned to:None => jtn
 Summary: civ2civ3: prevent building Harbour next to Lake? =>
civ2civ3: prevent building Harbour next to Lake

___

Follow-up Comment #5:

Version for commit, with improved help text.

(file #28812)
___

Additional Item Attachment:

File name: trunk-S2_6-civ2civ3-lake-harbour-bis.patch Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7742] civ2civ3: allow building wonders next to Deep Ocean?

2016-10-01 Thread Jacob Nevins 
Update of patch #7742 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-civ2civ3-deep-ocean-wonders.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7744] sandbox: import rule changes from 2.6 experimental ruleset

2016-10-01 Thread Jacob Nevins 
URL:
  

 Summary: sandbox: import rule changes from 2.6 experimental
ruleset
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 01 Oct 2016 03:11:03 PM BST
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0-beta1, 3.0.0
 Contains string changes: None

___

Details:

Some rule changes were made to the 2.6 experimental ruleset before we decided
to create 'sandbox'.

Copy them across, so that we have all the new weird in one place.
* patch #5132: Explorer can establish embassy after Writing discovered
* patch #5295: Spies can bribe / sabotage units that aren't alone
* patch #6078: "Personal Freedom" policy/multiplier

(I haven't checked whether there are rules in trunk's experimental ruleset
that should be copied across.)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7743] Rebase sandbox ruleset from civ2civ3 ruleset

2016-10-01 Thread Jacob Nevins 
URL:
  

 Summary: Rebase sandbox ruleset from civ2civ3 ruleset
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 01 Oct 2016 03:10:34 PM BST
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0-beta1, 3.0.0
 Contains string changes: Yes

___

Details:

The sandbox ruleset is advertised as a modified copy of civ2civ3. But civ2civ3
has moved on since sandbox forked from it in November 2015 (patch #6452).

It would be less confusing to describe the differences if sandbox reflected
the civ2civ3 rules at 2.6.0 release.

The attached patch brings the following recent changes from civ2civ3 to
sandbox:
* patch #5915: mining changes
* patch #5007: engineer veteran names
* patch #7078, bug #24616: KillCitizen changes
* patch #5597: culture and achievements
* patch #7160: enable tired_attack
* patch #7159: Ecclesiastical Palace + Federation luxury bonus
* patch #7080: enable happyborders by default
* Trade routes with enemies impossible (part of patch #7137)
* Merchants subject to ZOC (part of patch #7137)
* Not yet committed patches:
** bug #25070: Lakes don't allow building Harbour
** patch #7742: coastal wonders allowed by Deep Ocean

I have deliberately not taken most of patch #7137 about merchants:
* The movement restrictions are good rules for finding bugs in the game
engine.
* One of sandbox's tweaks concerns Enter Marketplace, so at least some of the
one-time TradeRoute unit revenues need to stay.

I've not taken patch #7096 (radius_sq_city_permanent), as I'll be modifying
this specifically for sandbox in another patch shortly.

I've reviewed the remaining diffs between civ2civ3 and sandbox on S2_6 and
trunk.

Update README.sandbox for the resulting differences, and also differences that
weren't previously documented.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7745] sandbox: Allow stealing outer ring of city territory only

2016-10-01 Thread Jacob Nevins 
URL:
  

 Summary: sandbox: Allow stealing outer ring of city territory
only
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 01 Oct 2016 03:11:25 PM BST
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0-beta1, 3.0.0
 Contains string changes: No

___

Details:

Patch #6036 gives rulesets some control of which tiles can be stolen from one
city by another's influence.

Use this to give behaviour intermediate between classic (no stealing) and
civ2civ3 (any tile can be stolen). Tiles adjacent to a city cannot be stolen
once claimed, but tiles further afield can be stolen.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7735] Goods help page

2016-10-01 Thread Marko Lindqvist 
Follow-up Comment #3, patch #7735 (project freeciv):

> Patch #7740, once submitted, will presumably resolve this.

Waiting that, I'm going to commit attached emergency fix.

(file #28814)
___

Additional Item Attachment:

File name: GoodsQtEmergency.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7742] civ2civ3: allow building wonders next to Deep Ocean?

2016-10-01 Thread Jacob Nevins 
URL:
  

 Summary: civ2civ3: allow building wonders next to Deep Ocean?
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 01 Oct 2016 11:25:06 AM BST
Category: rulesets
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: Yes

___

Details:

Currently, civ2civ3 requires Ocean terrain to build the coastal wonders
(Lighthouse and Magellan's Expedition). Neither Deep Ocean nor Lake suffices.

Bug #25070 is introducing a "Sea" TerrainFlag. We could use this to simplify
the rules to allow building these wonders in a city which has only Deep Ocean
tiles adjacent. (This is unlikely to come up with a generated map, but could
happen in a scenario.)

(One could argue that requiring Ocean specifically makes some narrative sense,
something about requiring gentle seas to nurture naval competence. But I think
the rules simplification probably outweighs that.)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7742] civ2civ3: allow building wonders next to Deep Ocean?

2016-10-01 Thread Jacob Nevins 
Follow-up Comment #1, patch #7742 (project freeciv):

Rebase against file #28815.

(file #28816)
___

Additional Item Attachment:

File name: trunk-S2_6-civ2civ3-deep-ocean-wonders-bis.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25136] Remove JumpTo/JumpFrom from civ2civ3 ruleset

2016-10-01 Thread Jacob Nevins 
URL:
  

 Summary: Remove JumpTo/JumpFrom from civ2civ3 ruleset
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 01 Oct 2016 03:11:35 PM BST
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: No

___

Details:

Patch #6728 added JumpTo/JumpFrom between civ2civ3 roads and rivers to avoid a
regression in merchant movement between 2.5 and 2.6. Since then, patch #7137
removed the restrictions on merchant movement, making this unnecessary.

(Use of JumpTo/JumpFrom will live on in the sandbox ruleset, after patch
#.)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7745] sandbox: Allow stealing outer ring of city territory only

2016-10-01 Thread Jacob Nevins 
Update of patch #7745 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-sandbox-border-stealing.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7744] sandbox: import rule changes from 2.6 experimental ruleset

2016-10-01 Thread Jacob Nevins 
Update of patch #7744 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-sandbox-import-from-experimental.patch Size:4 KB
File name: S2_6-sandbox-import-from-experimental.patch Size:4 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7743] Rebase sandbox ruleset from civ2civ3 ruleset

2016-10-01 Thread Jacob Nevins 
Update of patch #7743 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-sandbox-rebase-from-civ2civ3.patch Size:37 KB
File name: S2_6-sandbox-rebase-from-civ2civ3.patch Size:36 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7744] sandbox: import rule changes from 2.6 experimental ruleset

2016-10-01 Thread Jacob Nevins 
Update of patch #7744 (project freeciv):

  Depends on: => patch #7743


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25070] civ2civ3: prevent building Harbour next to Lake

2016-10-01 Thread Jacob Nevins 
Additional Item Attachment, bug #25070 (project freeciv):

File name: trunk-S2_6-civ2civ3-lake-harbour-ter.patch Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7737] Remove doube [[braces]] around configure default values in help

2016-10-01 Thread Marko Lindqvist 
Update of patch #7737 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7743] Rebase sandbox ruleset from civ2civ3 ruleset

2016-10-01 Thread Jacob Nevins 
Update of patch #7743 (project freeciv):

  Depends on: => patch #7742


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25136] Remove JumpTo/JumpFrom from civ2civ3 ruleset

2016-10-01 Thread Jacob Nevins 
Update of bug #25136 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-civ2civ3-no-jumpfromto.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7597] Use Output_Waste_By_Rel_Distance for sandbox ruleset Republic

2016-10-01 Thread Marko Lindqvist 
Update of patch #7597 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7744] sandbox: import rule changes from 2.6 experimental ruleset

2016-10-01 Thread Jacob Nevins 
Additional Item Attachment, patch #7744 (project freeciv):

File name: trunk-sandbox-import-from-experimental.patch Size:4 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7678] Libgreattao's modpack installer

2016-10-01 Thread Sławomir Lach 
Follow-up Comment #9, patch #7678 (project freeciv):

I'm the only one author of libgreattao, so I can change or add license.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24843] Hard to start all-AI game as player observer from the GUI

2016-10-01 Thread Jacob Nevins 
Follow-up Comment #2, bug #24843 (project freeciv):

What I was thinking when I raised this:

Goal: I want to start an all-AI game from the client, and watch it from that
client.

By default, the pregame UI (Gtk2 for concreteness) comes up with a game
containing a human player (me) and four AIs.

I try to absent myself from the game by right-clicking the line for myself and
selecting "Observe this player", but I run into the quoted check.

However:

Now that I come back to look at it, clicking the big "Observe" button (to
become a global observer) is probably more likely to be what someone trying to
do this would do; and that does work.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25128] Newly built Factory does not allow power power plants

2016-10-01 Thread Jacob Nevins 
Update of bug #25128 (project freeciv):

  Status:None => Invalid
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24843] Hard to start all-AI game as player observer from the GUI

2016-10-01 Thread Marko Lindqvist 
Follow-up Comment #1, bug #24843 (project freeciv):

This prevents observing the player you currently control, but not switching to
observing some other player, or?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7746] Correct minimum gtk3x-client requirements in INSTALL

2016-10-01 Thread Marko Lindqvist 
URL:
  

 Summary: Correct minimum gtk3x-client requirements in INSTALL
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 01 Oct 2016 06:49:24 PM EEST
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:





___

File Attachments:


---
Date: Sat 01 Oct 2016 06:49:24 PM EEST  Name: Gtk3xMinimumINSTALL.patch  Size:
2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7743] Rebase sandbox ruleset from civ2civ3 ruleset

2016-10-01 Thread Jacob Nevins 
Additional Item Attachment, patch #7743 (project freeciv):

File name: trunk-sandbox-rebase-from-civ2civ3.patch Size:37 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7742] civ2civ3: allow building wonders next to Deep Ocean

2016-10-01 Thread Jacob Nevins 
Update of patch #7742 (project freeciv):

 Summary: civ2civ3: allow building wonders next to Deep Ocean?
=> civ2civ3: allow building wonders next to Deep Ocean

___

Follow-up Comment #2:

This seems uncontroversial enough that I plan to commit it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7742] civ2civ3: allow building wonders next to Deep Ocean

2016-10-01 Thread David Fernandez 
Follow-up Comment #3, patch #7742 (project freeciv):

>This seems uncontroversial enough that I plan to commit it.
I agree, and I like the change.

___

Reply to this item at:

  

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7748] Act sel dlg: pre select current target unit

2016-10-01 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Act sel dlg: pre select current target unit
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 02 Oct 2016 12:24:13 AM UTC
Category: client-gtk-3+
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0
 Contains string changes: No

___

Details:

Select the unit the action selection dialog currently is targeting when
changing unit target.



___

File Attachments:


---
Date: Sun 02 Oct 2016 12:24:13 AM UTC  Name:
3.0-Act-sel-dlg-pre-select-current-target-unit.patch  Size: 2kB   By: sveinung


---
Date: Sun 02 Oct 2016 12:24:13 AM UTC  Name:
2.6-Act-sel-dlg-pre-select-current-target-unit.patch  Size: 1kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7747] Support forcing action enabler target reqs

2016-10-01 Thread Sveinung Kvilhaugsvik 
Update of patch #7747 (project freeciv):

Category:rulesets => general


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7747] Support forcing action enabler target reqs

2016-10-01 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Support forcing action enabler target reqs
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sat 01 Oct 2016 11:44:42 PM UTC
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: No

___

Details:

Introduce action_blocked_by_situation_tgt(). Don't use it yet.



___

File Attachments:


---
Date: Sat 01 Oct 2016 11:44:42 PM UTC  Name:
0003-Support-forcing-action-enabler-target-reqs.patch  Size: 2kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev