[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773038#comment-17773038
]
Michael Osipov commented on MNG-7875:
-
Fixed with
[74fc34158f79b06e71866b465a3e7b266a0e05a8|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=74fc34158f79b06e71866b465a3e7b266a0e05a8]
for {{maven-3.8.x}} branch.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 4.0.0-alpha-8, 3.9.5
>
> Attachments: MNG-7875_before_output.png,
> MNG-7875_colorized_output.png, MNG-7875_colorized_output_second.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763824#comment-17763824
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy merged PR #1231:
URL: https://github.com/apache/maven/pull/1231
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png,
> MNG-7875_colorized_output.png, MNG-7875_colorized_output_second.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763808#comment-17763808
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1714227158
here it is:
probably less surprising to end-users
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763766#comment-17763766
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1714078071
dropped the layout-specific colorization as asked
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763672#comment-17763672
]
ASF GitHub Bot commented on MNG-7875:
-
michael-o commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713724463
> > Please note that we do have different listeners already which are
activated through other flags indirectly.
>
> Can you elaborate? I already asked you about it: [#1231
(comment)](https://github.com/apache/maven/pull/1231#discussion_r1320858589)
Look at impl if the interface. We have for nop, slf4j, no progress and this
one for the tty.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763671#comment-17763671
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713723818
Also, I am willing to accept following PR:
* for 3.9: emphasize (with color) the repoId and baseUrl, leave everything
else as is and make no assumptions about layout
* for 4: do something along the lines of @gnodet idea
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763670#comment-17763670
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713720193
> Please note that we do have different listeners already which are
activated through other flags indirectly.
Can you elaborate? I already asked you about it:
https://github.com/apache/maven/pull/1231#discussion_r1320858589
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763663#comment-17763663
]
ASF GitHub Bot commented on MNG-7875:
-
michael-o commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713691345
Please note that we do have different listeners already which are activated
through other flags indirectly.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763649#comment-17763649
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713661630
> As a user, I'm usually not interested in knowing which exacts artifacts
are downloaded, but mainly by the fact that the build is actually downloading
artifacts.
...completely agree, except with this last line (where am more at @hboutemy
side): baseUrl used in download is good to be visible, as a cautious developer
can catch from very first few lines of downloads if the env is not right (ie.
mirror not properly set up, etc). This is why I keep saying that am personally
uninterested in the "Downloading..." line, but am very interested in
"Downloaded..." line.
Thinking more, I kinda agree with @gnodet to keep build logs unspoiled with
downloading/downloaded lines (just to have some deleted line, so progress
should be visible), and maybe at the build end (a la validation) have some
summary table? Like by repoId/baseUrl/countOfDowmloaded artifacts?
Basically, _current Maven logging_ could be called "detailed" (as Maven
3.9.x behaves today), and introduce something like
`maven.download.logging=summary` where NO downloading/downloaded are emitted,
but only a summary at build end?
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763644#comment-17763644
]
ASF GitHub Bot commented on MNG-7875:
-
gnodet commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713641040
Another possibility would be to implement something different when in
interactive mode:
* when some downloads starts, print a line saying saying Maven is
downloading
* eventually put some progression, but all on a single line (i.e. only the
last line is ever modified
* when downloads are done, completely erase the download line and continue
with normal build log
This can be easily achieved using JLine... (as has already been proven to
work inside Maven Daemon)
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763604#comment-17763604
]
ASF GitHub Bot commented on MNG-7875:
-
laeubi commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713448740
If the problem is "transfer message are currently hard to read for many
users" I must confess that I agree that adding color make them not easier to
read (for me as a user) and maybe one should better try to enhance the
message?
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763601#comment-17763601
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713435810
if the goal is https://issues.apache.org/jira/browse/MNG-7875 (please take
time to read it), it reaches its goal
if there is another goal (and I understand there is), please open a Jira
issue describing the goal: I don't get fully this other goal
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763566#comment-17763566
]
ASF GitHub Bot commented on MNG-7875:
-
rmannibucau commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713265044
@hboutemy not imposing anything, was just sharing my feedback that I think
this PR is a noop regarding the goal which is something I share. Due to the
regular feedback we have on this part I don't think this step is that useful
and I think we can skip it but no issue for me if you want to merge it - code
is more than ok. It is just it does not reach its real goal and just push back
the actual issue IMHO so thought it would be worth thinking to a global
solution instead of a quick workaround.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763564#comment-17763564
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713261184
disagree on everything: the PR does what the Jira title and description say
= color to ease understanding
which solve my improvement expectation
your expectations are different, probably complementary, then to be done
separately if you need it: going to slf4j will have other independent impact
I'm not saying that your expectations are wrong: just saying that they are
independent and should not be conflated (or even imposed on something
independent)
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763529#comment-17763529
]
ASF GitHub Bot commented on MNG-7875:
-
rmannibucau commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1713081100
> using slf4j vs console is completely orthogonal: it does not change
anything to this issue. Don't hesitate to open a Jira and a PR in parallel
Yes and no, using colors does not solve the issue you mention for me, using
loggers is a proposal so somehow it does IMHO.
> we don't have gavce in the API: we can't do that
We can for 2 reasons:
* We own aether
* Worse case a thread local solves that since transport is sadly for now
> effective url base is useful (depends on user settings)
Agree, this is why I said it would be debug level cause most of the time it
is not but if needed it can be enabled with --loggin-level which sounds like
solving the issue you reference for me.
> gavce can't display maven-metadata.xml
Why? you can reference it in the mesage but it stays readable compared to an
url randomized on the output.
> it is already readable without anything else IMHO
Ok, I disagree on that point for the two mentionned reasons
> for sure, it's done as pure color enhancement, absolutely not any other
change: then data exactly is the same, just color to help see the important
different fields and cases
This is why for me it is not better, several cases will not have colors,
contrast will not always make it better - can make it worse btw - and length
stays the same.
> ask a normal user about the difference between "Downloading" and
"Downloaded", ask about the url structure
for you and every Maven developer, there is no problem (just hard to read
output: you need to concentrate to see the different parts)
Feedback I encountered were, rest was either "it is too verbose but I
filtered it after or it was ok":
* It is not readable - note: literally - cause of the output interleaving I
mentionned
* what is the link with my pom (repo in parents)
> I know this output is new and made by someone else: take time to use it
and see live why it was done the way of was done...
I appreciate the proposal but my point is I think it does not address the
referenced ticket at the end - and I'm saying that after being one to think
about that some years ago - was with sed to add colors at that time. Just
trying to ensure we dont mark resolved a ticket we didnt address.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763485#comment-17763485
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320862296
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
As we know, by default Maven "leaks" your artifact paths, and **only
reason** "Downloading" log line is useful is only this one: it makes user
**aware** Maven is making HTTP request against the logged baseUrl. OTOH, due
overwhelming amount of Maven logging, this information is usually lost, due
log-noise.
To properly fix "leaking", use
[RRF](https://maven.apache.org/resolver/remote-repository-filtering.html) but
that is another thing.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763482#comment-17763482
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320858589
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
> This should be a separate discussion. Foe this we have other listeners.
What other listeners we have for this? WDYM?
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763481#comment-17763481
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320858231
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
Well JIRA currently states following:
>transfer message are currently hard to read for many users
> (logging example cut for brevity)
> * it's interweaved into normal build messages
> * users don't really see the difference between "Downloading" (transfert
started, may eventually fail with 404) and "Downloaded" (done successfully)
> * repository id is not so visible in the middle of the message
> * the download url has much info in it to see: base url, groupId as
directory, artifactId, version, and filename
So, based on this above, I assumed, that: is interweave and too chatty, so
cut it down, and if "users don't see the difference", they are right: As I
said, this logger when 5 repositories are defined will emit 5 "Downloading" and
1 "Downloaded", and the one "Downloaded" matters, the 5 "Downloading" does not
(better check with effective-pom what reposes you have instead to repeat it to
each artifact you need to download).
Unsure how JIRA comes to conclusion based on these 4 bullets above "ok,
let's color it!", when it is ONLY solving the last bullet (is not solving it
actually, as when this listener is involved, layout is already applied, and we
do not speak about "artifacts" but about "resources" that are resolved against
some baseUrl/repository, so this is another problem).
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763480#comment-17763480
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320858231
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
Well JIRA currently states following:
>transfer message are currently hard to read for many users
> (logging example cut for brevity)
> * it's interweaved into normal build messages
> * users don't really see the difference between "Downloading" (transfert
started, may eventually fail with 404) and "Downloaded" (done successfully)
> * repository id is not so visible in the middle of the message
> * the download url has much info in it to see: base url, groupId as
directory, artifactId, version, and filename
So, based on this above, I assumed, that: is interweave and too chatty, so
cut it down, and if "users don't see the difference", they are right: As I
said, this logger when 5 repositories are defined will emit 5 "Downloading" and
1 "Downloaded", and the one "Downloaded" matters, the 5 "Downloading" does not
(better check with effective-pom what reposes you have instead to repeat it to
each artifact you need to download).
Unsure how JIRA comes to conclusion based on these 4 bullets above "ok,
let's color it!", when it is ONLY solving the last bullet.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763479#comment-17763479
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320858231
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
Well JIRA currently states following:
>transfer message are currently hard to read for many users
> (logging example cut for brevity)
> * it's interweaved into normal build messages
> * users don't really see the difference between "Downloading" (transfert
started, may eventually fail with 404) and "Downloaded" (done successfully)
> * repository id is not so visible in the middle of the message
> * the download url has much info in it to see: base url, groupId as
directory, artifactId, version, and filename
So, based on this above, I assumed, that: is interweave and too chatty, so
cut it down, and if "users don't see the difference", they are right: As I
said, this logger when 5 repositories are defined will emit 5 "Downloading" and
1 "Downloaded", and the one "Downloaded" matters, the 5 "Downloading" does not
(better check with effective-pom what reposes you have).
Unsure how JIRA comes to conclusion based on these 4 bullets above "ok,
let's color it!", when it is ONLY solving the last bullet.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_before_output.png, MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763478#comment-17763478
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320857116
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(darkOn).append('
').append(direction).append(' ');
+message.append(darkOff).append(resource.getRepositoryId());
+message.append(darkOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(darkOff);
+appendResource(message, resource.getResourceName());
+message.append(darkOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(darkOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled() ||
resource.endsWith("/maven-metadata.xml")) {
+message.append(resource);
+return;
+}
+// use Maven2 layout for non-metadata files:
https://maven.apache.org/repositories/layout.html
Review Comment:
Please do not make wrong assumptions.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763476#comment-17763476
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320856876
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(darkOn).append('
').append(direction).append(' ');
+message.append(darkOff).append(resource.getRepositoryId());
+message.append(darkOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(darkOff);
+appendResource(message, resource.getResourceName());
+message.append(darkOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(darkOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled() ||
resource.endsWith("/maven-metadata.xml")) {
+message.append(resource);
+return;
+}
+// use Maven2 layout for non-metadata files:
https://maven.apache.org/repositories/layout.html
Review Comment:
please don't do what? use Maven 2 repository layout as a fact?
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763477#comment-17763477
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320856958
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
this line is not about cutting logging: it's about adding color when color
enabled
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763474#comment-17763474
]
ASF GitHub Bot commented on MNG-7875:
-
michael-o commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320855548
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
This should be a separate discussion. Foe this we have other listeners.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763472#comment-17763472
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320853920
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
If we want to cut logging (and I do agree with @elharo we log way too much),
I'd just remove this method (make it no op).
Or just leave it for PUT (leave it as before), and do not log for the rest.
Reason is simple: if you have 5 reposes, you will have 5 "Downloading"
but only one "Downloaded", and the latter matter.s
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763471#comment-17763471
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320854377
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(lowOn).append('
').append(direction).append(' ');
+message.append(lowOff).append(resource.getRepositoryId());
+message.append(lowOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(lowOff);
+appendResource(message, resource.getResourceName());
+message.append(lowOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(lowOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled()) {
+message.append(resource);
+return;
+}
+int filename = resource.lastIndexOf('/');
+int version = resource.substring(0, filename).lastIndexOf('/');
+int artifactId = resource.substring(0, version).lastIndexOf('/');
Review Comment:
Layout is delegated to resolver. since Maven3.0. Maven cannot and should not
make any assumptions here, all Maven can do is to control what layout is to be
used with resolver. Doing assumptions like these is plain wrong.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763470#comment-17763470
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320853920
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
If we want to cut logging (and I do agree with @elharo we log way too much),
I'd just remove this method (make it no op).
Or just leave it for PUT (leave it as before), and do not log nothing for
the rest.
Reason is simple: if you have 5 reposes, you will have 5 "Downloading"
but only one "Downloaded", and the latter matter.s
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763469#comment-17763469
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320853920
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -184,14 +189,19 @@ protected AbstractMavenTransferListener(PrintStream out) {
@Override
public void transferInitiated(TransferEvent event) {
+String darkOn = MessageUtils.isColorEnabled() ? ANSI_DARK_SET : "";
Review Comment:
If we want to cut logging (and I do agree with @elharo we log way too much),
I'd just remove this method (make it no op).
Or just leave it for PUT (leave it as before), and do not log nothing for
the rest.
Reason is simple: if you have 5 reposes, you will have 5 "Downloading"
but only one "Downloaded", and the latter matter.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763468#comment-17763468
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320853550
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(darkOn).append('
').append(direction).append(' ');
+message.append(darkOff).append(resource.getRepositoryId());
+message.append(darkOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(darkOff);
+appendResource(message, resource.getResourceName());
+message.append(darkOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(darkOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled() ||
resource.endsWith("/maven-metadata.xml")) {
+message.append(resource);
+return;
+}
+// use Maven2 layout for non-metadata files:
https://maven.apache.org/repositories/layout.html
Review Comment:
By the way, since Maven3 it is called "default" layout, not "maven2 layout"
(as Maven2 did support "maven1" layout as well, but Maven3 does not).
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763467#comment-17763467
]
ASF GitHub Bot commented on MNG-7875:
-
cstamas commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320853289
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(darkOn).append('
').append(direction).append(' ');
+message.append(darkOff).append(resource.getRepositoryId());
+message.append(darkOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(darkOff);
+appendResource(message, resource.getResourceName());
+message.append(darkOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(darkOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled() ||
resource.endsWith("/maven-metadata.xml")) {
+message.append(resource);
+return;
+}
+// use Maven2 layout for non-metadata files:
https://maven.apache.org/repositories/layout.html
Review Comment:
Please don't do this: we want a LONG road from Maven2 to NOT have code (and
assumptions) like this sprinkled across the codebase.
The API offers you repositoryBaseUrl and relative resource path, so just
color those two differently (as I agree, repo URL IS important, it may be
affected by user settings) while resource path IS NOT important
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,38 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(darkOn).append('
').append(direction).append(' ');
+message.append(darkOff).append(resource.getRepositoryId());
+message.append(darkOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(darkOff);
+appendResource(message, resource.getResourceName());
+message.append(darkOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(darkOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled() ||
resource.endsWith("/maven-metadata.xml")) {
+message.append(resource);
+return;
+}
+// use Maven2 layout for non-metadata files:
https://maven.apache.org/repositories/layout.html
Review Comment:
Please don't do this: we went a LONG road from Maven2 to NOT have code (and
assumptions) like this sprinkled across the codebase.
The API offers you repositoryBaseUrl and relative resource path, so just
color those two differently (as I agree, repo URL IS important, it may be
affected by user settings) while resource path IS NOT important
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763463#comment-17763463
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1712915939
using slf4j vs console is completely orthogonal: it does not change anything
to this issue. Don't hesitate to open a Jira and a PR in parallel
on `Downloading org.apache.maven:foo:1.2.3 from apache-snapshots`:
- we don't have gavce in the API: we can't do that
- effective url base is useful (depends on user settings)
- gavce can't display `maven-metadata.xml`
> it is already readable without anything else IMHO
ask a normal user about the difference between "Downloading" and
"Downloaded", ask about the url structure
for you and every Maven developer, there is no problem (just hard to read
output: you need to concentrate to see the different parts)
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763457#comment-17763457
]
ASF GitHub Bot commented on MNG-7875:
-
rmannibucau commented on PR #1231:
URL: https://github.com/apache/maven/pull/1231#issuecomment-1712887752
Not sure it is easier to read, what about keeping them at debug/fine level
and use something maven oriented by default (info: `Downloading
org.apache.maven:foo:1.2.3 from apache-snapshots`, here colors can optionally
be used on the gav and repoId if needed but it is already readable without
anything else IMHO)?
The fact it does not use a logger already messes up the output depending the
build mode and mojos (due to stdout usage directly) so maybe migrate to slf4j
impl first then use the levels and be it, looks better to solve the issue than
working it around with colors which don't really enhance it for end users in
the previous mentionned case(s).
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763450#comment-17763450
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320812506
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(lowOn).append('
').append(direction).append(' ');
+message.append(lowOff).append(resource.getRepositoryId());
+message.append(lowOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(lowOff);
+appendResource(message, resource.getResourceName());
+message.append(lowOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(lowOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled()) {
+message.append(resource);
+return;
+}
+int filename = resource.lastIndexOf('/');
+int version = resource.substring(0, filename).lastIndexOf('/');
+int artifactId = resource.substring(0, version).lastIndexOf('/');
Review Comment:
testing on https://github.com/eclipse-tycho/tycho/tree/master/demo/itp04-rcp
```
❯ \rm -rf ~/.m2/repository/p2/
❯ mvn package
[INFO] Scanning for projects...
[INFO] Resolving target definition
file:/home/herve/tmp/tycho/demo/itp04-rcp/mars/mars.target for
environments=[win32/win32/x86_64, linux/gtk/x86_64, macosx/cocoa/x86_64],
include source mode=honor, execution environment=StandardEEResolutionHints
[executionEnvironment=OSGi profile 'JavaSE-11' { source level: 11, target
level: 11}], remote p2 repository
options=org.eclipse.tycho.p2.remote.RemoteAgent@77db231c...
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
[INFO] Resolving dependencies of MavenProject:
example.group:eclipse-repository:1.0.0-SNAPSHOT @
/home/herve/tmp/tycho/demo/itp04-rcp/eclipse-repository/pom.xml
[INFO] Resolving dependencies of MavenProject:
example.group:example-bundle:0.1.0-SNAPSHOT @
/home/herve/tmp/tycho/demo/itp04-rcp/example-bundle/pom.xml
[INFO] Fetching 202206151000=fr=1=xml from
https://www.eclipse.org/downloads/download.php?format=xml=/releases/2022-06/
[INFO] Fetching com.ibm.icu_67.1.0.v20200706-1749.jar from
https://mirror.aarnet.edu.au/pub/eclipse/releases/2022-06/202206151000/plugins/
(12,94MB)
[INFO] Fetching com.ibm.icu_67.1.0.v20200706-1749.jar from
https://mirror.aarnet.edu.au/pub/eclipse/releases/2022-06/202206151000/plugins/
(179,24kB of 12,94MB at 175,24kB/s)
[INFO] Fetching com.ibm.icu_67.1.0.v20200706-1749.jar from
https://mirror.aarnet.edu.au/pub/eclipse/releases/2022-06/202206151000/plugins/
(1,67MB of 12,94MB at 782,9kB/s)
[INFO] Fetching com.ibm.icu_67.1.0.v20200706-1749.jar from
https://mirror.aarnet.edu.au/pub/eclipse/releases/2022-06/202206151000/plugins/
(6,32MB of 12,94MB at 2,1MB/s)
...
```
transfer from p2 seems to be implemented outside Maven core, then not
affected
assumption of Maven 2 repository layout seems reasonable
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763449#comment-17763449
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320808439
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(lowOn).append('
').append(direction).append(' ');
+message.append(lowOff).append(resource.getRepositoryId());
+message.append(lowOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(lowOff);
+appendResource(message, resource.getResourceName());
+message.append(lowOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(lowOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled()) {
+message.append(resource);
+return;
+}
+int filename = resource.lastIndexOf('/');
+int version = resource.substring(0, filename).lastIndexOf('/');
+int artifactId = resource.substring(0, version).lastIndexOf('/');
Review Comment:
@laeubi is that transfer message used by Tycho to display download from p2
repositories?
is the assumption of using Maven 2 layout only reasonable?
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763448#comment-17763448
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320808439
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(lowOn).append('
').append(direction).append(' ');
+message.append(lowOff).append(resource.getRepositoryId());
+message.append(lowOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(lowOff);
+appendResource(message, resource.getResourceName());
+message.append(lowOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(lowOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled()) {
+message.append(resource);
+return;
+}
+int filename = resource.lastIndexOf('/');
+int version = resource.substring(0, filename).lastIndexOf('/');
+int artifactId = resource.substring(0, version).lastIndexOf('/');
Review Comment:
@laeubi is that transfer message used by Tycho?
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763444#comment-17763444
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320794768
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(lowOn).append('
').append(direction).append(' ');
+message.append(lowOff).append(resource.getRepositoryId());
+message.append(lowOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(lowOff);
+appendResource(message, resource.getResourceName());
+message.append(lowOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(lowOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled()) {
+message.append(resource);
+return;
+}
+int filename = resource.lastIndexOf('/');
+int version = resource.substring(0, filename).lastIndexOf('/');
+int artifactId = resource.substring(0, version).lastIndexOf('/');
Review Comment:
thinking twice: there is an edge case on `maven-metadata.xml`, that can be
also at groupId or atifactId level
I'll need to add a test for that, not a problem
and yes, I'll add some more comments and links
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763440#comment-17763440
]
ASF GitHub Bot commented on MNG-7875:
-
michael-o commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320792496
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(lowOn).append('
').append(direction).append(' ');
+message.append(lowOff).append(resource.getRepositoryId());
+message.append(lowOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(lowOff);
+appendResource(message, resource.getResourceName());
+message.append(lowOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(lowOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled()) {
+message.append(resource);
+return;
+}
+int filename = resource.lastIndexOf('/');
+int version = resource.substring(0, filename).lastIndexOf('/');
+int artifactId = resource.substring(0, version).lastIndexOf('/');
Review Comment:
Then add a comment and link to the resource and that we assume only the
default Maven repository layout. If someone, does custom stuff with a custom
repo format, e.g., p2, then this listener will be broken.
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
> Attachments: MNG-7875_colorized_output.png
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763439#comment-17763439
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320790948
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(lowOn).append('
').append(direction).append(' ');
+message.append(lowOff).append(resource.getRepositoryId());
+message.append(lowOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(lowOff);
+appendResource(message, resource.getResourceName());
+message.append(lowOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(lowOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled()) {
+message.append(resource);
+return;
+}
+int filename = resource.lastIndexOf('/');
+int version = resource.substring(0, filename).lastIndexOf('/');
+int artifactId = resource.substring(0, version).lastIndexOf('/');
Review Comment:
AFAIK, it is based on repository layout:
https://maven.apache.org/repositories/layout.html
then I don't see what can happen in this code that would not fully break the
repository
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
> Fix For: 3.9.5
>
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763431#comment-17763431
]
ASF GitHub Bot commented on MNG-7875:
-
michael-o commented on code in PR #1231:
URL: https://github.com/apache/maven/pull/1231#discussion_r1320770513
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java:
##
@@ -214,18 +227,37 @@ public void transferSucceeded(TransferEvent event) {
FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
StringBuilder message = new StringBuilder();
-message.append(action).append(' ').append(direction).append('
').append(resource.getRepositoryId());
-message.append(": ");
-
message.append(resource.getRepositoryUrl()).append(resource.getResourceName());
-message.append(" (").append(format.format(contentLength));
+message.append(action).append(lowOn).append('
').append(direction).append(' ');
+message.append(lowOff).append(resource.getRepositoryId());
+message.append(lowOn).append(": ");
+message.append(resource.getRepositoryUrl()).append(lowOff);
+appendResource(message, resource.getResourceName());
+message.append(lowOn).append("
(").append(format.format(contentLength));
long duration = System.currentTimeMillis() -
resource.getTransferStartTime();
if (duration > 0L) {
double bytesPerSecond = contentLength / (duration / 1000.0);
message.append(" at ").append(format.format((long)
bytesPerSecond)).append("/s");
}
-message.append(')');
+message.append(')').append(lowOff);
out.println(message.toString());
}
+
+private void appendResource(StringBuilder message, String resource) {
+if (!MessageUtils.isColorEnabled()) {
+message.append(resource);
+return;
+}
+int filename = resource.lastIndexOf('/');
+int version = resource.substring(0, filename).lastIndexOf('/');
+int artifactId = resource.substring(0, version).lastIndexOf('/');
Review Comment:
Can we fully make this assumption?
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7875) colorize transfer messages
[
https://issues.apache.org/jira/browse/MNG-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763396#comment-17763396
]
ASF GitHub Bot commented on MNG-7875:
-
hboutemy opened a new pull request, #1231:
URL: https://github.com/apache/maven/pull/1231
https://issues.apache.org/jira/browse/MNG-7875
> colorize transfer messages
> --
>
> Key: MNG-7875
> URL: https://issues.apache.org/jira/browse/MNG-7875
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.9.4
>Reporter: Herve Boutemy
>Priority: Major
>
> transfer message are currently hard to read for many users
> {noformat}
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/doxia/doxia-decoration-model/1.11.1/doxia-decoration-model-1.11.1.pom
> (3.4 kB at 851 kB/s)
> D
> {noformat}
> - it's interweaved into normal build messages
> - users don't really see the difference between "Downloading" (transfert
> started, may eventually fail with 404) and "Downloaded" (done successfully)
> - repository id is not so visible in the middle of the message
> - the download url has much info in it to see: base url, groupId as
> directory, artifactId, version, and filename
> adding darker color to "hide" less important info will help output reading
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
