[kudu-CR] KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5822

Change subject: KUDU-1851 - [python] TableAlterer direct instantiation causes 
SIGSEGV
..

KUDU-1851 - [python] TableAlterer direct instantiation causes SIGSEGV

The python client is currently crashing when a TableAlterer is directly
instantiated as opposed to instantiating via the new_table_alterer method
in the Client class. This patch addresses this issue and includes a new
unit test.

Change-Id: I074737c8f6992a7cd21f72f711337e915ffe2e82
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 24 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/22/5822/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5822
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I074737c8f6992a7cd21f72f711337e915ffe2e82
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1691 - [python] Updated Column Encoding Types

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4824

to look at the new patch set (#3).

Change subject: KUDU-1691 - [python] Updated Column Encoding Types
..

KUDU-1691 - [python] Updated Column Encoding Types

GROUP_VARINT encoding has been depricated and as thus been removed from
the Python client. Additionally, bit shuffle and dictionary encoding have
been added. This patch includes updated unit tests.

Change-Id: I18a611e746d48879d6e9988abcee42e0354dcfdc
---
M python/kudu/__init__.py
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_schema.py
4 files changed, 17 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/4824/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4824
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18a611e746d48879d6e9988abcee42e0354dcfdc
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: g.kocu...@gmail.com
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: g.kocu...@gmail.com

[kudu-CR] [python] - Enable Session.apply for list of WriteOperations

[Jordan Birdsell (Code Review)]

Jordan Birdsell has abandoned this change.

Change subject: [python] - Enable Session.apply for list of WriteOperations
..


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/5231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I637e08547e2f710dded8248a18652b575b239cbe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [python] - Enable Session.apply for list of WriteOperations

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: [python] - Enable Session.apply for list of WriteOperations
..


Patch Set 1:

After thinking about it a bit further, i agree. Going to withdraw this.

-- 
To view, visit http://gerrit.cloudera.org:8080/5231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I637e08547e2f710dded8248a18652b575b239cbe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
..


Patch Set 10:

Is this still going on?

-- 
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland 
Gerrit-Reviewer: Brock Noland 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4315

to look at the new patch set (#2).

Change subject: KUDU-1593 - [python] Allow to set the number of replicas per 
tablet at table creation time
..

KUDU-1593 - [python] Allow to set the number of replicas per tablet at table 
creation time

Currently the Kudu Python client does not allow for the number of replicas to 
be set at
table creation time because the num_replicas method of the KuduTableCreator is 
not
exposed to the Python class. This patch exposes that method as well as it 
exposes the
num_replicas method of the KuduTable class so that the number of replicas for a 
table
can be retrieved from the cluster.  This patch includes a test.

Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 28 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/4315/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1593 - [python] Allow to set the number of replicas per 
tablet at table creation time
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4315/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 114: 
> I don't think we need to test this, though I'm curious: where did you get t
I removed the test, the thought was that we could ensure that proper error 
handling was in place when the number of replicas exceeded the number of 
tservers.  As for the number, since the number of tservers in the test could be 
changed, I wanted to be sure that this test would pass regardless of how many 
tservers are configured, so I chose the max value for a signed 16 bit int.


http://gerrit.cloudera.org:8080/#/c/4315/2/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 98: name = "no_replica_table"
> final nit: could you iterate and create tables with 1,3 and 5 replicas (jus
Since the test is setup up for 3 tservers today, if its ever 
increased/decreased, having this set to 1 will always effectively test this, 
no?  If its decreased to 1, there would be no test to be had really since you 
cant got any lower.


-- 
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4315

to look at the new patch set (#3).

Change subject: KUDU-1593 - [python] Allow to set the number of replicas per 
tablet at table creation time
..

KUDU-1593 - [python] Allow to set the number of replicas per tablet at table 
creation time

Currently the Kudu Python client does not allow for the number of replicas to 
be set at
table creation time because the num_replicas method of the KuduTableCreator is 
not
exposed to the Python class. This patch exposes that method as well as it 
exposes the
num_replicas method of the KuduTable class so that the number of replicas for a 
table
can be retrieved from the cluster.  This patch includes a test.

Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 26 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/4315/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1593 - [python] Allow to set the number of replicas per 
tablet at table creation time
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4315/2/python/kudu/libkudu_client.pxd
File python/kudu/libkudu_client.pxd:

Line 526: 
> this is internal so likely no need for this comment.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1593 - [python] Allow to set the number of replicas per 
tablet at table creation time
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4315/2/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 111: self.client.delete_table(name)
> missed this before: why the double delete_table?
In case the assertion fails, this makes sure we still delete the table.


-- 
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1593 - [python] Allow to set the number of replicas per tablet at table creation time

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4315

to look at the new patch set (#6).

Change subject: KUDU-1593 - [python] Allow to set the number of replicas per 
tablet at table creation time
..

KUDU-1593 - [python] Allow to set the number of replicas per tablet at table 
creation time

Currently the Kudu Python client does not allow for the number of replicas to 
be set at
table creation time because the num_replicas method of the KuduTableCreator is 
not
exposed to the Python class. This patch exposes that method as well as it 
exposes the
num_replicas method of the KuduTable class so that the number of replicas for a 
table
can be retrieved from the cluster.  This patch includes a test.

Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 28 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/4315/6
-- 
To view, visit http://gerrit.cloudera.org:8080/4315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9dcac887029ef22e850ea8be72e71b684e6bee05
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4328

Change subject: KUDU-1304 - [python] Enable listing of tablet servers
..

KUDU-1304 - [python] Enable listing of tablet servers

Kudu's python client currently doesn't expose the ListTabletServers
method. To date, this has presented issues with unit tests executing
before the tservers have started.  This patch exposes the method and
integrates it into the unit tests so that race conditions no longer
occur.  This patch also includes an additional test to confirm the
integrity of the data returned from the method.

Change-Id: I51794168750b358d8c1b371ac2bd08b5c8f15395
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
4 files changed, 54 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/4328/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I51794168750b358d8c1b371ac2bd08b5c8f15395
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4344

Change subject: KUDU-854 - [python] Expose additional scanner projection methods
..

KUDU-854 - [python] Expose additional scanner projection methods

Kudu's python client does not currently expose all Scanner projection
methods.  This patch adds the bindings for the SetProjectedColumnIndexes
and GetProjectionSchema methods of the KuduScanner class. The patch
includes a unit test to validate the column index projection method
and to ensure that the GetProjectionSchema method returns a result.

Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
3 files changed, 62 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/4344/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] [python] Implement Scan Token API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4367

to look at the new patch set (#7).

Change subject: [python] Implement Scan Token API
..

[python] Implement Scan Token API

First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401.  I included several
unit tests, most of which were based on the current scanner unit tests.

Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/setup.py
5 files changed, 623 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/7
-- 
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1301 - [python] Tests leak tmp directory

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1301 - [python] Tests leak tmp directory
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4372/1//COMMIT_MSG
Commit Message:

Line 11: commit 89380b53d48b085dfe394b9966360d1ef1a4b038, the check for
> nit: better to mention it by its commit hash (since in 5 years the gerrit s
Done


Line 13: fixes both the temp directory and the process leak and re-enables
> does it also fix the process leak?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I95d03ab1c23c7712ab647e37a646d5e22a758a9b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [python] Implement Scan Token API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4367

to look at the new patch set (#6).

Change subject: [python] Implement Scan Token API
..

[python] Implement Scan Token API

First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401.  I included several
unit tests, most of which were based on the current scanner unit tests.

Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/setup.py
5 files changed, 627 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/6
-- 
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] [python] Implement Scan Token API

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: [python] Implement Scan Token API
..


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4367/5/python/kudu/tests/test_scantoken.py
File python/kudu/tests/test_scantoken.py:

Line 35: Stolen from the the test scanner given the similarity in
> Stolen & Similarity are mispelled
Done


Line 77: builder = self.table.scan_token_builder()
> It looks like this line and below is repeated for the three tests, could yo
Cant move it to _get_scan_token_results since I need to serialize the tokens in 
the main thread before shipping to the new threads. However, I did create a 
helper function within the class to clean this up a bit.


http://gerrit.cloudera.org:8080/#/c/4367/5/python/requirements.txt
File python/requirements.txt:

Line 6
> This is a test-only dependency, right?  Is there anyway to express that wit
Good point, i moved this to setup.py in the tests_require list.


-- 
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4378

Change subject: KUDU-1604 - [python] Fix bug getting table column by index
..

KUDU-1604 - [python] Fix bug getting table column by index

There is currently a bug when attempting to access a table column
by its index. When attempted, the column definition returned has
the index value as the column name. This patch fixes this bug so
that the appropriate column name is set and returned. An existing
test has been updated to account for this usage.

Change-Id: If754ddb463223430c7fe3c8920e433031162562e
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 11 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/4378/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1611 - [python] Enable setting scanner selection policy

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1611 - [python] Enable setting scanner selection policy
..


Patch Set 2:

The latter. That being said, if we do decide to use this client as a backbone 
for pyspark integration would what alternatives would we have for executor 
locality? I don't know how related it is but the MR and spark libraries are 
struggling with this now. Is there another means of determining the closest 
replicas?

-- 
To view, visit http://gerrit.cloudera.org:8080/4408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09d9cd081c037e3284370943e2cae348476df26c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4328

to look at the new patch set (#2).

Change subject: KUDU-1304 - [python] Enable listing of tablet servers
..

KUDU-1304 - [python] Enable listing of tablet servers

Kudu's python client currently doesn't expose the ListTabletServers
method. To date, this has presented issues with unit tests executing
before the tservers have started.  This patch exposes the method and
integrates it into the unit tests so that race conditions no longer
occur.  This patch also includes an additional test to confirm the
integrity of the data returned from the method.

Change-Id: I51794168750b358d8c1b371ac2bd08b5c8f15395
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
4 files changed, 73 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/4328/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51794168750b358d8c1b371ac2bd08b5c8f15395
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4344

to look at the new patch set (#2).

Change subject: KUDU-854 - [python] Expose additional scanner projection methods
..

KUDU-854 - [python] Expose additional scanner projection methods

Kudu's python client does not currently expose all Scanner projection
methods.  This patch adds the bindings for the SetProjectedColumnIndexes
and GetProjectionSchema methods of the KuduScanner class. The patch
includes a unit test to validate the column index projection method
and to ensure that the GetProjectionSchema method returns a result.

Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
4 files changed, 90 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/4344/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4344

to look at the new patch set (#3).

Change subject: KUDU-854 - [python] Expose additional scanner projection methods
..

KUDU-854 - [python] Expose additional scanner projection methods

Kudu's python client does not currently expose all Scanner projection
methods.  This patch adds the bindings for the SetProjectedColumnIndexes
and GetProjectionSchema methods of the KuduScanner class. The patch
includes a unit test to validate the column index projection method
and to ensure that the GetProjectionSchema method returns a result.

Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
4 files changed, 86 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/4344/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-854 - [python] Expose additional scanner projection methods

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-854 - [python] Expose additional scanner projection methods
..


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4344/2/python/kudu/schema.pyx
File python/kudu/schema.pyx:

Line 327: fluid programming style. This method allows the SchemaBuilder 
to be
> typo
Done


Line 328: more easily used to build a new Schema from an existing one.
> period at the end
Done


http://gerrit.cloudera.org:8080/#/c/4344/2/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

Line 100: def test_index_projection_with_schema(self):
> seems like these should be two different tests (even 2 different patches)
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4344
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8284af0841d681d1d7c704e1f57edc90c9f5ed6a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [python] Implement Scan Token API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4367

to look at the new patch set (#3).

Change subject: [python] Implement Scan Token API
..

[python] Implement Scan Token API

First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401.  I included several
unit tests, most of which were based on the current scanner unit tests.

Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/requirements.txt
5 files changed, 611 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [python] Implement Scan Token API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4367

to look at the new patch set (#2).

Change subject: [python] Implement Scan Token API
..

[python] Implement Scan Token API

First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401.  I included several
unit tests, most of which were based on the current scanner unit tests.

Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/requirements.txt
5 files changed, 638 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] python: bump version number to 0.3.0

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: python: bump version number to 0.3.0
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4364
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c874f9f9fb235b979e3120304d52d59061a26d6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] python: update cython version check in setup.py

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: python: update cython version check in setup.py
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4368
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id44a716a6917bfdc37a96ba4759cc007805285a5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [python] Implement Scan Token API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4367

to look at the new patch set (#4).

Change subject: [python] Implement Scan Token API
..

[python] Implement Scan Token API

First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401.  I included several
unit tests, most of which were based on the current scanner unit tests.

Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/requirements.txt
5 files changed, 608 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [python] Implement Scan Token API

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4367

to look at the new patch set (#5).

Change subject: [python] Implement Scan Token API
..

[python] Implement Scan Token API

First attempt at implementing the
[Scan Token API](http://gerrit.cloudera.org:8080/#/c/2443/) for the Python
client. This patch should also resolve KUDU-1401.  I included several
unit tests, most of which were based on the current scanner unit tests.

Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
A python/kudu/tests/test_scantoken.py
M python/requirements.txt
5 files changed, 623 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/4367/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I710c93e51ab5f0f5ed038aaaf1925b58c576b655
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1604 - [python] Fix bug getting table column by index
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4378/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 38: cols = [(table['key'], 'key', 'int32'),
> since you're here, could you test getting another non-0 col?
Changed to test a negative and a positive index


-- 
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4378

to look at the new patch set (#2).

Change subject: KUDU-1604 - [python] Fix bug getting table column by index
..

KUDU-1604 - [python] Fix bug getting table column by index

There is currently a bug when attempting to access a table column
by its index. When attempted, the column definition returned has
the index value as the column name. This patch fixes this bug so
that the appropriate column name is set and returned. An existing
test has been updated to account for this usage.

Change-Id: If754ddb463223430c7fe3c8920e433031162562e
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 13 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/4378/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1611 - [python] Enable setting scanner selection policy

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4408

to look at the new patch set (#2).

Change subject: KUDU-1611 - [python] Enable setting scanner selection policy
..

KUDU-1611 - [python] Enable setting scanner selection policy

Currently the python client cannot set the scanner selection policy.
This patch enables that both for the Scanner class and the
ScanTokenBuilder.  This patch includes two unit tests.

Change-Id: I09d9cd081c037e3284370943e2cae348476df26c
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
5 files changed, 122 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/4408/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09d9cd081c037e3284370943e2cae348476df26c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1611 - [python] Enable setting scanner selection policy

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1611 - [python] Enable setting scanner selection policy
..


Patch Set 2:

Gotcha, I'll withdraw this one

-- 
To view, visit http://gerrit.cloudera.org:8080/4408
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09d9cd081c037e3284370943e2cae348476df26c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

[Jordan Birdsell (Code Review)]

Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4417

to look at the new patch set (#5).

Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros
..

KUDU-1614 - [python] Enable Set/Get of unixtime_micros

Currently, the python client in Kudu does not support setting or
getting columns with the unixtime_micros type. This patch enables
this capability and includes a unit test. This patch also fixes
a minor bug with write operations using column indexes (KUDU-1615).
This fix is reflected in the unit test associated with this patch.

Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
A python/kudu/tests/util.py
M python/kudu/util.py
8 files changed, 266 insertions(+), 63 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4417/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

[Jordan Birdsell (Code Review)]

Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4417

to look at the new patch set (#6).

Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros
..

KUDU-1614 - [python] Enable Set/Get of unixtime_micros

Currently, the python client in Kudu does not support setting or
getting columns with the unixtime_micros type. This patch enables
this capability and includes a unit test. This patch also fixes
a minor bug with write operations using column indexes (KUDU-1615).
This fix is reflected in the unit test associated with this patch.

Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
A python/kudu/tests/util.py
M python/kudu/util.py
M python/requirements.txt
M python/setup.py
10 files changed, 268 insertions(+), 64 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4417/6
-- 
To view, visit http://gerrit.cloudera.org:8080/4417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1304 - [python] Enable listing of tablet servers
..


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4328/2/python/kudu/client.pyx
File python/kudu/client.pyx:

PS2, Line 368: ts = TabletServer()
 : result.append(ts._init(tservers[i])
> I assume this 'init' thing is because it's not possible to do a normal __in
Yep, annoying, seemed like the only other option was to deconstruct/reconstruct 
the class altogether but that seemed like a worse idea.


PS2, Line 499: Repres
> typo
Done


PS2, Line 500: TabletSe
> expand out the abbreviation here 'TabletServers'
Done


PS2, Line 507: _init
> does this show up as a method in the generated python class? If so, maybe i
Done


Line 510: 
> I think we need some __dealloc__ here which takes care of deleting _tserver
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51794168750b358d8c1b371ac2bd08b5c8f15395
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1304 - [python] Enable listing of tablet servers

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4328

to look at the new patch set (#3).

Change subject: KUDU-1304 - [python] Enable listing of tablet servers
..

KUDU-1304 - [python] Enable listing of tablet servers

Kudu's python client currently doesn't expose the ListTabletServers
method. To date, this has presented issues with unit tests executing
before the tservers have started.  This patch exposes the method and
integrates it into the unit tests so that race conditions no longer
occur.  This patch also includes an additional test to confirm the
integrity of the data returned from the method.

Change-Id: I51794168750b358d8c1b371ac2bd08b5c8f15395
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
4 files changed, 77 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/4328/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4328
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51794168750b358d8c1b371ac2bd08b5c8f15395
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4520/2/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 1305: "Snapshot Timestamps be greater than the unix 
epoch.")
> is there a way that we can return the error status returned by SetSnapshotM
We wouldn't get that far here really, the error returned otherwise is an 
overflow error b/c of the unsigned int and I didnt think that would be 
preferred.


http://gerrit.cloudera.org:8080/#/c/4520/2/python/kudu/tests/util.py
File python/kudu/tests/util.py:

Line 122: self.snapshot_timestamp = datetime.datetime.utcnow()
> there is no guarantee that the snapshot timestamp will be in between the de
Since this op is being flushed why would it not be guaranteed? Since its 
blocking the call, would that not guarantee that the latest observed timestamp 
after the op is at least less than this "snapshot timestamp"?  I get that using 
the latest observed timestamp is probably better form but I want to make sure I 
understand, also the TestScanAtSnapshot C++ test seems to also use system time, 
so we may need to fix that as well if its an issue.


-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [docs] Python updates for development page

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: [docs] Python updates for development page
..


Patch Set 1:

Going to table this until closer to release timemay be some significant 
changes by that time.

-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
..


Patch Set 6: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland 
Gerrit-Reviewer: Brock Noland 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4520/4/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

Line 176: scanner.set_read_mode(kudu.READ_LATEST)\
> yeah, precisely.
Making sure I'm clear, are we talking about looping until we get the correct 
result or, rather, some sort of 50 ms pause or something (Not sure what the 
appropriate wait time here would be).


-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] [python] - Expand gitignore for python

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4616

Change subject: [python] - Expand gitignore for python
..

[python] - Expand gitignore for python

Adding additional exclusion rules for python to .gitignore.

Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
---
M .gitignore
1 file changed, 24 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/4616/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4520/4/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 257: Note: The latest observed timestamp can also be used to start 
a
> there's ongoing discussion the this is more like a hack, and not why this a
Done


http://gerrit.cloudera.org:8080/#/c/4520/4/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

Line 176: scanner.set_read_mode(kudu.READ_LATEST)\
> I imagine you'd have to loop to make this non-flaky.
To account for a non-leader replica selection?


-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4520

to look at the new patch set (#5).

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..

KUDU-1612 - [python] Enable setting of read mode for scanning

Currently the python client is unable to set the read mode for
scanning, so all scans are done as READ_LATEST.  This patch enables
the ability to set the read mode so that the python client can read
at snapshots. This patch includes multiple tests.

Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/kudu/util.py
7 files changed, 280 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/4520/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [docs] - Impala Hash Partition Example Correction

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4615

Change subject: [docs] - Impala Hash Partition Example Correction
..

[docs] - Impala Hash Partition Example Correction

The Impala doc has a basic hash partitioning examples
and incorrectly explains the hash partition that is
created. This fix corrects that.

Change-Id: I4039f6326602fe854a090dc16cf65b5807d4617f
---
M docs/kudu_impala_integration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/4615/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4615
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4039f6326602fe854a090dc16cf65b5807d4617f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1684 - [python] Add Scan Resource Metrics Capabilities

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4675

Change subject: KUDU-1684 - [python] Add Scan Resource Metrics Capabilities
..

KUDU-1684 - [python] Add Scan Resource Metrics Capabilities

Currently, the python client doesn't expose scanner resource metrics.
This patch enables this ability and includes tests.

Change-Id: Ib6c4057bd2644e46bdbf8bae0d4a768306e2dbd9
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
4 files changed, 103 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/4675/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6c4057bd2644e46bdbf8bae0d4a768306e2dbd9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1649 - [python] Add Binary Type Support

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new patch set (#2).

Change subject: KUDU-1649 - [python] Add Binary Type Support
..

KUDU-1649 - [python] Add Binary Type Support

The Python client currently does not support the Binary type.
This patch adds this type and contains test updates.

Change-Id: Ib13539d040b754399c13031003a2cf64c71ba151
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
5 files changed, 46 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/4653/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib13539d040b754399c13031003a2cf64c71ba151
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1649 - [python] Add Binary Type Support

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4653

Change subject: KUDU-1649 - [python] Add Binary Type Support
..

KUDU-1649 - [python] Add Binary Type Support

The Python client currently does not support the Binary type.
This patch adds this type and contains test updates.

Change-Id: Ib13539d040b754399c13031003a2cf64c71ba151
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
5 files changed, 47 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/4653/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4653
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib13539d040b754399c13031003a2cf64c71ba151
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4520

to look at the new patch set (#7).

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..

KUDU-1612 - [python] Enable setting of read mode for scanning

Currently the python client is unable to set the read mode for
scanning, so all scans are done as READ_LATEST.  This patch enables
the ability to set the read mode so that the python client can read
at snapshots. This patch includes multiple tests.

Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
---
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
2 files changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/4520/7
-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1640 - [python] Add IN-list predicate support
..


Patch Set 7:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4548/6/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 816: col_name_slice = Slice( _name, len(_name))
> This is already done by the C++ client, so you shouldn't need to do it here
Done


Line 819: for val in values:
> is this returning a boolean?
no, the column class overrides the == comparison operator and instead creates a 
predicate. See the __richcmp__ method.  At any rate, removed since this is 
addressed with the C++ client.


Line 827: 
> The issue isn't clearing the vector, but instead freeing all of the contain
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [python] - Expand gitignore for python

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4616

to look at the new patch set (#2).

Change subject: [python] - Expand gitignore for python
..

[python] - Expand gitignore for python

Adding additional exclusion rules for python to .gitignore.

Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
---
M python/.gitignore
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/4616/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4548

to look at the new patch set (#7).

Change subject: KUDU-1640 - [python] Add IN-list predicate support
..

KUDU-1640 - [python] Add IN-list predicate support

This patch adds IN list predicate support for the python client.
This patch includes a test.

Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
4 files changed, 123 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/4548/7
-- 
To view, visit http://gerrit.cloudera.org:8080/4548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional 
types
..


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4589/2/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 1797: to_unixtime_micros(value))
> just so that I understand you changed to_unixtime_micros to be able to take
yep


http://gerrit.cloudera.org:8080/#/c/4589/2/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

Line 159: # Using the incoming list of predicates, verify that the row 
returned
> xxxs nit: wrap this comment so that we use less lines.
Done


PS2, Line 161: 
> typo
Done


Line 189: self._test_float_pred()
> why?
Python floats are actually doubles (retrieving the value back from kudu casts 
to a double), so verifying the values here will get annoying. I was thinking 
that by confirming row count we at least confirm the predicate portion is 
working (since casts from double to float are ok). Should I add some sort of 
rounded comparison of the value or some bit manipulation/comparison?  Note: In 
the future, likely when pandas is integrated, we will probably use numpy which 
will support the single precision floats.


http://gerrit.cloudera.org:8080/#/c/4589/2/python/kudu/util.py
File python/kudu/util.py:

Line 66: elif isinstance(timestamp, tuple):
> oh you did.
:)


-- 
To view, visit http://gerrit.cloudera.org:8080/4589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5766d24055dfba5fa371fc61c6dfd66adc54273
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4589

to look at the new patch set (#3).

Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional 
types
..

KUDU-1671 - [python] Enable predicate pushdown for additional types

Currently, the python client does not support predicate pushdown for
boolean and unixtime_micros values. Additionally, as pointed out in
KUDU-1672, float predicates have a bug. This patch addresses both
of these issues.  Test cases have been added to validate this
functionality.  Two minor namespace issues were addressed as well
for float and boolean types.

Change-Id: If5766d24055dfba5fa371fc61c6dfd66adc54273
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/kudu/util.py
6 files changed, 182 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/4589/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5766d24055dfba5fa371fc61c6dfd66adc54273
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [python] - Expand gitignore for python

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: [python] - Expand gitignore for python
..


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4616/1/.gitignore
File .gitignore:

> Since all of this stuff is rooted in python/, can you make a second .gitign
Done


Line 74
> How could egg files leak out of the python subdirectory? That seems like so
My mistake, not happening, also moved to the python gitignore


-- 
To view, visit http://gerrit.cloudera.org:8080/4616
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b7bcac00a88678a555a4d85419c22decac23b58
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4520

to look at the new patch set (#9).

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..

KUDU-1612 - [python] Enable setting of read mode for scanning

Currently the python client is unable to set the read mode for
scanning, so all scans are done as READ_LATEST.  This patch enables
the ability to set the read mode so that the python client can read
at snapshots. This patch includes multiple tests.

Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/kudu/util.py
7 files changed, 287 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/4520/9
-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4520

to look at the new patch set (#10).

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..

KUDU-1612 - [python] Enable setting of read mode for scanning

Currently the python client is unable to set the read mode for
scanning, so all scans are done as READ_LATEST.  This patch enables
the ability to set the read mode so that the python client can read
at snapshots. This patch includes multiple tests.

Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/kudu/util.py
7 files changed, 289 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/4520/10
-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..


Patch Set 10:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4520/4/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

Line 176: """
> Making sure I'm clear, are we talking about looping until we get the correc
done


-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4520

to look at the new patch set (#8).

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..

KUDU-1612 - [python] Enable setting of read mode for scanning

Currently the python client is unable to set the read mode for
scanning, so all scans are done as READ_LATEST.  This patch enables
the ability to set the read mode so that the python client can read
at snapshots. This patch includes multiple tests.

Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/kudu/util.py
7 files changed, 281 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/4520/8
-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

[Jordan Birdsell (Code Review)]

Hello David Ribeiro Alves, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4589

to look at the new patch set (#4).

Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional 
types
..

KUDU-1671 - [python] Enable predicate pushdown for additional types

Currently, the python client does not support predicate pushdown for
boolean and unixtime_micros values. Additionally, as pointed out in
KUDU-1672, float predicates have a bug. This patch addresses both
of these issues.  Test cases have been added to validate this
functionality.  Two minor namespace issues were addressed as well
for float and boolean types.

Change-Id: If5766d24055dfba5fa371fc61c6dfd66adc54273
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/kudu/util.py
6 files changed, 183 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/4589/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5766d24055dfba5fa371fc61c6dfd66adc54273
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..


Patch Set 10:

This is revised to master so you're good

-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..


Patch Set 10:

Revised*... autocorrect

-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4417/1//COMMIT_MSG
Commit Message:

Line 11: this capability and includes a unit test. This patch also fixes
> this are two different things likely tested in different tests, can you spl
Heres the first one, i'll post the other soon


-- 
To view, visit http://gerrit.cloudera.org:8080/4417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new patch set (#4).

Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros
..

KUDU-1614 - [python] Enable Set/Get of unixtime_micros

Currently, the python client in Kudu does not support setting or
getting columns with the unixtime_micros type. This patch enables
this capability and includes a unit test. This patch also fixes
a minor bug with write operations using column indexes (KUDU-1615).
This fix is reflected in the unit test associated with this patch.

Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
A python/kudu/tests/util.py
M python/kudu/util.py
8 files changed, 237 insertions(+), 63 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4417/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] Python - Bump version package to 0.4.0

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/

Change subject: Python - Bump version package to 0.4.0
..

Python - Bump version package to 0.4.0

There have been additional changes to the python client since the
0.3.0 release so the version number needs bumped before the next
release.

Change-Id: Iff66be56a55f5f75c20bd2183d4ffad54edf46f1
---
M python/setup.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44//1
-- 
To view, visit http://gerrit.cloudera.org:8080/
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff66be56a55f5f75c20bd2183d4ffad54edf46f1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] Python - Bump package version to 0.4.0

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/

to look at the new patch set (#2).

Change subject: Python - Bump package version to 0.4.0
..

Python - Bump package version to 0.4.0

There have been additional changes to the python client since the
0.3.0 release so the version number needs bumped before the next
release.

Change-Id: Iff66be56a55f5f75c20bd2183d4ffad54edf46f1
---
M python/setup.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44//2
-- 
To view, visit http://gerrit.cloudera.org:8080/
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff66be56a55f5f75c20bd2183d4ffad54edf46f1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros
..


Patch Set 9:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4417/8/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 1772: elif t == KUDU_DOUBLE:
> where are these capabilities documented? maybe PartialRow should have a pyd
Agreed, so, the pydoc stuff is going to take some rework of the docstrings and 
some structure of the package after looking through it. Are you thinking we 
should address it class by class or do the api docs for the whole package at 
once. If we want to do it all at once, would it make sense to throw together 
something on the website in asciidoc for some common usage examples?


Line 1779: slc = new Slice(cpython.PyBytes_AsString(value))
> while we're here, maybe we should add a blanket else: raise Exception("Unab
Done


http://gerrit.cloudera.org:8080/#/c/4417/8/python/kudu/util.py
File python/kudu/util.py:

Line 26: timezone provided.
> nit: trailing space
Done


Line 68: if timestamp.tzinfo and timestamp.utcoffset():
> https://docs.python.org/2/library/datetime.html#datetime.datetime.now says 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1614 - [python] Enable Set/Get of unixtime micros

[Jordan Birdsell (Code Review)]

Hello David Ribeiro Alves, Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4417

to look at the new patch set (#9).

Change subject: KUDU-1614 - [python] Enable Set/Get of unixtime_micros
..

KUDU-1614 - [python] Enable Set/Get of unixtime_micros

Currently, the python client in Kudu does not support setting or
getting columns with the unixtime_micros type. This patch enables
this capability and includes a unit test. This patch also fixes
a minor bug with write operations using column indexes (KUDU-1615).
This fix is reflected in the unit test associated with this patch.

Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
A python/kudu/tests/util.py
M python/kudu/util.py
M python/requirements.txt
M python/setup.py
10 files changed, 287 insertions(+), 67 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/4417/9
-- 
To view, visit http://gerrit.cloudera.org:8080/4417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id428cbd072b7de7a75e58b66e4de89acd381fdca
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4520

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..

KUDU-1612 - [python] Enable setting of read mode for scanning

Currently the python client is unable to set the read mode for
scanning, so all scans are done as READ_LATEST.  This patch enables
the ability to set the read mode so that the python client can read
at snapshots. This patch includes tests.

Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
6 files changed, 244 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/4520/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1637 - [python] Add Support for < and > Predicates

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1637 - [python] Add Support for < and > Predicates
..


Patch Set 1:

Yea, the test_scan_rows_string_predicate_and_projection test uses <= and >=.

-- 
To view, visit http://gerrit.cloudera.org:8080/4524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic78dcf58949277fc8363d4d5b3bfa6067932a823
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: No

[kudu-CR] KUDU-1637 - [python] Add Support for < and > Predicates

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4524

to look at the new patch set (#2).

Change subject: KUDU-1637 - [python] Add Support for < and > Predicates
..

KUDU-1637 - [python] Add Support for < and > Predicates

Currently the python client doesn't support < and > predicates.
This patch adds that support and includes changes to existing tests.

Change-Id: Ic78dcf58949277fc8363d4d5b3bfa6067932a823
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
4 files changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/4524/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic78dcf58949277fc8363d4d5b3bfa6067932a823
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1653 - [python] Python 3 Failing to Deserialize Token

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4542

Change subject: KUDU-1653 - [python] Python 3 Failing to Deserialize Token
..

KUDU-1653 - [python] Python 3 Failing to Deserialize Token

Python 3 is failing to deserialize tokens because it is forcing it
to decode in UTF-8.  The serialized tokens should be left as byte
strings to avoid this issue. This patch is tested by existing tests.

Change-Id: I1969d67fa75db28626e0d4e130f1d68a5fd3b1d5
---
M python/kudu/client.pyx
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/4542/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1969d67fa75db28626e0d4e130f1d68a5fd3b1d5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4543

Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: 
test_table_column
..

KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column

Python 3 fails the test_table_column test because it is is attempting
to cast a string to bytes without an encoding argument. In Python 3,
this is a required parameter as bytes and strings are no longer
synonymous. This patch utilizes the kudu.compat.frombytes method
which was written for this purpose.

Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9
---
M python/kudu/tests/test_client.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4543/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4520/2/python/kudu/tests/util.py
File python/kudu/tests/util.py:

Line 122: self.snapshot_timestamp = 
self.client.latest_observed_timestamp()
> because the server's clock might not have the same time as the system's clo
I follow, done. I took an approach that converts hybridtime to datetimes (via 
micros) to keep it a bit cleaner on the interface side if someone wanted to do 
anything with the latest observed timestamp value.


-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1612 - [python] Enable setting of read mode for scanning

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4520

to look at the new patch set (#3).

Change subject: KUDU-1612 - [python] Enable setting of read mode for scanning
..

KUDU-1612 - [python] Enable setting of read mode for scanning

Currently the python client is unable to set the read mode for
scanning, so all scans are done as READ_LATEST.  This patch enables
the ability to set the read mode so that the python client can read
at snapshots. This patch includes multiple tests.

Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/kudu/util.py
7 files changed, 275 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/4520/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4520
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c61ef09f6e15bad2c44d9caf85b2cc2582b8a49
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [WIP]KUDU-1640 - [python] Add IN-list predicate support

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4548

to look at the new patch set (#3).

Change subject: [WIP]KUDU-1640 - [python] Add IN-list predicate support
..

[WIP]KUDU-1640 - [python] Add IN-list predicate support

This patch adds IN list predicate support for the python client.
This patch includes a test.

Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
3 files changed, 27 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/4548/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4543

to look at the new patch set (#2).

Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: 
test_table_column
..

KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column

Python 3 fails the test_table_column test because it is is attempting
to cast a string to bytes without an encoding argument. In Python 3,
this is a required parameter as bytes and strings are no longer
synonymous. This patch utilizes the kudu.compat.frombytes method
which was written for this purpose.

Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 8 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4543/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: 
test_table_column
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4543/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

Line 45: assert col.name == name
> given that column names should typically be human-readable (and are Strings
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1654 - [python] Python 3 Client Test Failure: test table column

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4543

to look at the new patch set (#3).

Change subject: KUDU-1654 - [python] Python 3 Client Test Failure: 
test_table_column
..

KUDU-1654 - [python] Python 3 Client Test Failure: test_table_column

Python 3 fails the test_table_column test because it is is attempting
to cast a string to bytes without an encoding argument. In Python 3,
this is a required parameter as bytes and strings are no longer
synonymous. This patch utilizes the kudu.compat.frombytes method
which was written for this purpose.

Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/4543/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7184639426b7f2528523209152dafd5fa39fecf9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [python] KUDU-1563. Add support for INSERT IGNORE

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: [python] KUDU-1563. Add support for INSERT IGNORE
..


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4522/5/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:

PS5, Line 164: self.assertRaises(Exception, session.apply, op)
I think this test would now fail since the last write op will be an insert 
ignore. Maybe flip the insert ignore to be on even rows?


PS5, Line 187: op = table.new_update()
Is this supposed to be new_insert_ignore?


-- 
To view, visit http://gerrit.cloudera.org:8080/4522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c45a50d4b87d8f7c4f0f83fbc72932d056d3a79
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [WIP]KUDU-1640 - [python] Add IN-list predicate support

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4548

Change subject: [WIP]KUDU-1640 - [python] Add IN-list predicate support
..

[WIP]KUDU-1640 - [python] Add IN-list predicate support

This patch adds IN list predicate support for the python client.
This patch includes a test.

Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
3 files changed, 27 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/4548/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] [docs] - Impala doc - partitioning required

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4595

Change subject: [docs] - Impala doc - partitioning required
..

[docs] - Impala doc - partitioning required

It seems a blurb in the impala page got missed when partitioning
became required on table create.  Updated verbage without removing
reference links.

Change-Id: I022b49c4e0b17031b9f14648ef0216ba0094b92b
---
M docs/kudu_impala_integration.adoc
1 file changed, 5 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/4595/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I022b49c4e0b17031b9f14648ef0216ba0094b92b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] [docs] - Impala doc - partitioning required

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new patch set (#2).

Change subject: [docs] - Impala doc - partitioning required
..

[docs] - Impala doc - partitioning required

It seems a blurb in the impala page got missed when partitioning
became required on table create.  Updated verbiage without removing
reference links.

Change-Id: I022b49c4e0b17031b9f14648ef0216ba0094b92b
---
M docs/kudu_impala_integration.adoc
1 file changed, 5 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/4595/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4595
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I022b49c4e0b17031b9f14648ef0216ba0094b92b
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4548

to look at the new patch set (#5).

Change subject: KUDU-1640 - [python] Add IN-list predicate support
..

KUDU-1640 - [python] Add IN-list predicate support

This patch adds IN list predicate support for the python client.
This patch includes a test.

Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
4 files changed, 112 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/4548/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Python - Clean up distutils classifiers and package information

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4579

Change subject: Python - Clean up distutils classifiers and package information
..

Python - Clean up distutils classifiers and package information

Updated development status to beta (from alpha) and added several
new classifiers. Additionally, updated url to kudu.apache.org.

Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
---
M python/setup.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/4579/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] Python - Clean up distutils classifiers and package information

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: Python - Clean up distutils classifiers and package information
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4579/1/python/setup.py
File python/setup.py:

Line 134: 'Topic :: Scientific/Engineering :: Interface Engine/Protocol 
Translator',
> I have no idea what this means/comes from, I'm going to trust you do :)
Its one of the "topics" in the distutils classifiers.  Seemed relevant and on 
par with some other db interfaces.


-- 
To view, visit http://gerrit.cloudera.org:8080/4579
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98313df2a939339f4e8a3cbd1b8580d0760e856
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4589

Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional 
types
..

KUDU-1671 - [python] Enable predicate pushdown for additional types

Currently, the python client does not support predicate pushdown for
boolean and unixtime_micros values. Additionally, as pointed out in
KUDU-1672, float predicates have a bug. This patch addresses both
of these issues.  Test cases have been added to validate this
functionality.  Two minor namespace issues were addressed as well
for float and boolean types.

Change-Id: If5766d24055dfba5fa371fc61c6dfd66adc54273
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
5 files changed, 176 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/4589/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If5766d24055dfba5fa371fc61c6dfd66adc54273
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KUDU-1671 - [python] Enable predicate pushdown for additional types

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4589

to look at the new patch set (#2).

Change subject: KUDU-1671 - [python] Enable predicate pushdown for additional 
types
..

KUDU-1671 - [python] Enable predicate pushdown for additional types

Currently, the python client does not support predicate pushdown for
boolean and unixtime_micros values. Additionally, as pointed out in
KUDU-1672, float predicates have a bug. This patch addresses both
of these issues.  Test cases have been added to validate this
functionality.  Two minor namespace issues were addressed as well
for float and boolean types.

Change-Id: If5766d24055dfba5fa371fc61c6dfd66adc54273
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/kudu/util.py
6 files changed, 183 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/4589/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If5766d24055dfba5fa371fc61c6dfd66adc54273
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [docs] Python updates for development page

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4586

Change subject: [docs] Python updates for development page
..

[docs] Python updates for development page

Updates to the Developing Applications with Kudu page for Python.
Additionally, this updates some of the github example references.

Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
---
M docs/developing.adoc
1 file changed, 113 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/4586/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I028e86b6bc35f36fd1a4752b52463f5d0fd75f76
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] KuduPredicate::Clone on IN list predicate causes segfault

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KuduPredicate::Clone on IN list predicate causes segfault
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I977691390535273c37aa90c3a3663a7c09ea67fc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1640 - [python] Add IN-list predicate support

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1640 - [python] Add IN-list predicate support
..


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/4548/5/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 768: col_name_slice = Slice( _name, len(_name))
> fixup indentation
Done


Line 822: 
> fixup indentation
Done


Line 824: for val in values:
> If box_value throws a TypeError, will this leak the already constructed val
Done


http://gerrit.cloudera.org:8080/#/c/4548/5/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

Line 77: def test_scan_rows_in_list_predicate(self):
> Could you add a test with mistyped values in the list, both that the python
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4548
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I932dfded62e162cf85e0e12432cf6716311957de
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

[Jordan Birdsell (Code Review)]

Jordan Birdsell has posted comments on this change.

Change subject: KUDU-1680 - [python] Improve PartialRow Usability
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4760/3/python/kudu/client.pyx
File python/kudu/client.pyx:

PS3, Line 692: 
> nit: extra "s."
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c9f57358e5048528398818fc80f32b27531a423
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4760

to look at the new patch set (#4).

Change subject: KUDU-1680 - [python] Improve PartialRow Usability
..

KUDU-1680 - [python] Improve PartialRow Usability

The current semantics for setting values in a PartialRow are not
very elegant or comfortable for Python developers. This patch
improves this API by providing the ability to "load" a PartialRow
from a list, tuple or dictionary.  Some existing tests were modified,
however, some tests will continue to use the old API to ensure
backwards compatibility.

Change-Id: I5c9f57358e5048528398818fc80f32b27531a423
---
A python/kudu/client.pxd
M python/kudu/client.pyx
M python/kudu/compat.py
M python/kudu/schema.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_client.py
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
9 files changed, 248 insertions(+), 83 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/4760/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4760
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c9f57358e5048528398818fc80f32b27531a423
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [WIP]KUDU-1638 - [python] Add Alter Table Support

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4823

to look at the new patch set (#2).

Change subject: [WIP]KUDU-1638 - [python] Add Alter Table Support
..

[WIP]KUDU-1638 - [python] Add Alter Table Support

The Python client currently doesn't support the ability to alter
table. This patch adds this capability and includes tests.

Change-Id: If72c76e1ea7c80452b401c55b19df4fbac7dd2d7
---
M python/kudu/client.pxd
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
4 files changed, 330 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4823/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If72c76e1ea7c80452b401c55b19df4fbac7dd2d7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1638 - [python] Add Alter Table Support

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4823

to look at the new patch set (#3).

Change subject: KUDU-1638 - [python] Add Alter Table Support
..

KUDU-1638 - [python] Add Alter Table Support

The Python client currently doesn't support the ability to alter
table. This patch adds this capability and includes tests.

Change-Id: If72c76e1ea7c80452b401c55b19df4fbac7dd2d7
---
M python/kudu/client.pxd
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_client.py
5 files changed, 392 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4823/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If72c76e1ea7c80452b401c55b19df4fbac7dd2d7
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [python] - Expose Hash Partition with Seed Method Signature

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new patch set (#2).

Change subject: [python] - Expose Hash Partition with Seed Method Signature
..

[python] - Expose Hash Partition with Seed Method Signature

The Kudu Python client currently doesn't expose the hash partition
with seed capability. This patch adds this functionality and
includes an update to a test.

Change-Id: I33a7f411c5a92583e85e445634c2e119f5ddee73
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 25 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/4882/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I33a7f411c5a92583e85e445634c2e119f5ddee73
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] [python] - Update kudu.connect to enable multi-master

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4883

Change subject: [python] - Update kudu.connect to enable multi-master
..

[python] - Update kudu.connect to enable multi-master

Currently, the kudu.connect method does not support multi-master.
This patch addresses that and also adds a default for the port.
Additionally, this patch modifies the existing test bed to run on
a multi-master instance.

Change-Id: Ia2721236d5f92ced2afb4a867511c4144a2ab16a
---
M python/kudu/__init__.py
M python/kudu/tests/common.py
M python/kudu/tests/test_client.py
M python/kudu/tests/test_scantoken.py
M python/setup.py
5 files changed, 76 insertions(+), 57 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/4883/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2721236d5f92ced2afb4a867511c4144a2ab16a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] [python] - Expose Hash Partition with Seed Method Signature

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4882

Change subject: [python] - Expose Hash Partition with Seed Method Signature
..

[python] - Expose Hash Partition with Seed Method Signature

The Kudu Python client currently doesn't expose the hash partition
with seed capability. This patch adds this functionality and
includes an update to a test.

Change-Id: I33a7f411c5a92583e85e445634c2e119f5ddee73
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 19 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/4882/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33a7f411c5a92583e85e445634c2e119f5ddee73
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] [python] - Expand KuduError capabilities

[Jordan Birdsell (Code Review)]

Jordan Birdsell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4885

Change subject: [python] - Expand KuduError capabilities
..

[python] - Expand KuduError capabilities

The Python client currently doesn't support the full error reporting
capabilities of the KuduError class. This patch exposes most of them
and includes tests.

Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 46 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/4885/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4885
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4947a663ae09ec2fc9580876521252670d081aa1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 

[kudu-CR] [python] - Expose Hash Partition with Seed Method Signature

[Jordan Birdsell (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4882

to look at the new patch set (#3).

Change subject: [python] - Expose Hash Partition with Seed Method Signature
..

[python] - Expose Hash Partition with Seed Method Signature

The Kudu Python client currently doesn't expose the hash partition
with seed capability. This patch adds this functionality and
includes an update to an existing test.

Change-Id: I33a7f411c5a92583e85e445634c2e119f5ddee73
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 25 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/4882/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4882
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I33a7f411c5a92583e85e445634c2e119f5ddee73
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley