Change in vdsm[master]: migration: wait properly for migration to begin

[tjelinek]

Tomas Jelinek has posted comments on this change.

Change subject: migration: wait properly for migration to begin
..


Patch Set 9: Verified+1

done

-- 
To view, visit https://gerrit.ovirt.org/60073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba369a0992c2473acf1395fad0b0c260c250ba
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: wait properly for migration to begin

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: wait properly for migration to begin
..


Patch Set 9:

* #1354344::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354344::OK, public bug
* Check Product::#1354344::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba369a0992c2473acf1395fad0b0c260c250ba
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Modify reports to metrics

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Modify reports to metrics
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 450: 'Metric collector type (supporting statsd or hawkular)'),
Line 451: 
Line 452: ('queue_size', '100',
Line 453: 'Number of metrics to queue if collector is not 
responsive.'
Line 454: ' When the queue is full, oldest metrics are dropped. 
Used only'
> We sample the system and report bunch of metrics on each sampling cycle. We
this is why we write metrics and not a single metric.. oldest metrics are 
dropped is what we do. Number of metrics to queue is also quite clear. however, 
this parameter relate to  queries. do you want me to change it to "number of 
queries to queue" - the queue relates only to queries directly to hawkular 
anyway. 

The rest of the above docs look alright to me
Line 455: ' by hawkular-client collector (default 100).'),
Line 456: ]),
Line 457: 
Line 458: # Section: [devel]


-- 
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: build: enable vdsm-gluster build

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: build: enable vdsm-gluster build
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60329
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Sahina Bose 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: image: Add timing for copy volume operations

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: image: Add timing for copy volume operations
..


Patch Set 1: Verified+1

Verified on master

-- 
To view, visit https://gerrit.ovirt.org/60542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a509397c756a51bfed43b89a2505e3e4cbb9edc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: image: Add timing for copy volume operations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: image: Add timing for copy volume operations
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a509397c756a51bfed43b89a2505e3e4cbb9edc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: image: Add timing for copy volume operations

[nsoffer]

Hello Adam Litke, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/60542

to review the following change.

Change subject: image: Add timing for copy volume operations
..

image: Add timing for copy volume operations

Report the time for each volume copy operation:

...::vds.stopwatch::.. Copy volume xxxyyyzzz: 123.45 seconds

When copying an image with multiple volumes we will see one line for
each volume.

These logs should help to diagnose issues with slow storage.

Change-Id: I8a509397c756a51bfed43b89a2505e3e4cbb9edc
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/60164
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Adam Litke 
---
M vdsm/storage/image.py
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/60542/1

diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index 4a9b9bc..082fb39 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -26,6 +26,7 @@
 
 import volume
 from vdsm import qemuimg
+from vdsm import utils
 from vdsm import virtsparsify
 from vdsm.config import config
 from vdsm.storage import constants as sc
@@ -483,7 +484,8 @@
 dstFormat=dstFormat,
 backing=backing,
 backingFormat=backingFormat)
-self._wait_for_qemuimg_operation(operation)
+with utils.stopwatch("Copy volume %s" % srcVol.volUUID):
+self._wait_for_qemuimg_operation(operation)
 except ActionStopped:
 raise
 except se.StorageException:
@@ -890,7 +892,8 @@
 dstPath,
 srcFormat=sc.fmt2str(volParams['volFormat']),
 dstFormat=sc.fmt2str(dstVolFormat))
-self._wait_for_qemuimg_operation(operation)
+with utils.stopwatch("Copy volume %s" % srcVol.volUUID):
+self._wait_for_qemuimg_operation(operation)
 except ActionStopped:
 raise
 except qemuimg.QImgError as e:
@@ -1133,7 +1136,8 @@
 newVol.getVolumePath(),
 srcFormat=sc.fmt2str(srcVolParams['volFormat']),
 dstFormat=sc.fmt2str(volParams['volFormat']))
-self._wait_for_qemuimg_operation(operation)
+with utils.stopwatch("Copy volume %s" % srcVol.volUUID):
+self._wait_for_qemuimg_operation(operation)
 except qemuimg.QImgError:
 self.log.exception('conversion failure for volume %s',
srcVol.volUUID)


-- 
To view, visit https://gerrit.ovirt.org/60542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a509397c756a51bfed43b89a2505e3e4cbb9edc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: properties: Add properties module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: properties: Add properties module
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/40822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62175172dddce7f84319e3c8669747994e06a697
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: properties: Add properties module

[alitke]

Adam Litke has submitted this change and it was merged.

Change subject: properties: Add properties module
..


properties: Add properties module

Properties are reusable objects similar to builtin property() function,
adding input validation and initialization guarantees.

Examples

class Foo(properties.Owner):

uuid = properties.UUID(required=True)
format = properties.Enum(values=("cow", "raw"), required=True)
size = properties.Integer(minval=0)
name = properties.String()

def __init__(self, uuid, format, size=0):
self.uuid = uuid
self.format = format
self.size = size

Creating an object with invalid properties or with uninitialized
required properties would raise:

Foo("not-a-uuid", "raw")
Foo("49d8842d-43e8-4c33-b588-b5538df4ed8a", "invalid format")
Foo("49d8842d-43e8-4c33-b588-b5538df4ed8a", "raw", size=-1)

Attempting to set invalid value would raise:

foo = Foo("49d8842d-43e8-4c33-b588-b5538df4ed8a", "raw")
foo.size = -1  # Raises ValueError

Accessing uninitialized properties does not raise AttributeError.
Instead, the default value is returned:

foo.name  # None

Change-Id: I62175172dddce7f84319e3c8669747994e06a697
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/40822
Continuous-Integration: Jenkins CI
Tested-by: Adam Litke 
Reviewed-by: Adam Litke 
---
M lib/vdsm/Makefile.am
A lib/vdsm/properties.py
M tests/Makefile.am
A tests/properties_test.py
M vdsm.spec.in
5 files changed, 748 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/40822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62175172dddce7f84319e3c8669747994e06a697
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: properties: Add properties module

[alitke]

Adam Litke has posted comments on this change.

Change subject: properties: Add properties module
..


Patch Set 9: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/40822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62175172dddce7f84319e3c8669747994e06a697
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Support volume leases

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Support volume leases
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60425
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb8711b9a88b8b57ed79cb3a246bbf3fcb9b2025
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Unify getVolumeLease signature

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Unify getVolumeLease signature
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85d3f754c266ce5296d2e52ec9bd544728723a94
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Support for multiple leases

[automation]

gerrit-hooks has posted comments on this change.

Change subject: clusterlock: Support for multiple leases
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60422
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7903b13bd017e3da6762e8979f7f4dfc6520de9e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Move getVolumeLease to StorageDomainManifest
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60282
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60b35e9a41d73ecba741d6fb9f90cdaeb35b3e3b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: properties: Add properties module

[alitke]

Adam Litke has posted comments on this change.

Change subject: properties: Add properties module
..


Patch Set 9: Verified+1

No users, so verified using supplied tests.

-- 
To view, visit https://gerrit.ovirt.org/40822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62175172dddce7f84319e3c8669747994e06a697
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Daniel Erez 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Raise if lock is used improperly

[automation]

gerrit-hooks has posted comments on this change.

Change subject: clusterlock: Raise if lock is used improperly
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia616070615a02fc86f85329e334d0af773e678b0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

[automation]

gerrit-hooks has posted comments on this change.

Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b604b9600db45ffa9092776c94f0278feb4746
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: fix make_block_volume size units

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: fix make_block_volume size units
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/60408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd582110ffe7c8e6c6dfb94cc90d63770d59e170
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: fix make_block_volume size units

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: fix make_block_volume size units
..


tests: fix make_block_volume size units

The utility function make_block_volume takes size in bytes.
Unfortunately we were not converting the value properly for LVM (which
accepts MB) and the volume metadata (which takes sectors).

Further, LVM rounds volume sizes to VG extent granularity (128M).  But
this detail shouldn't really be known to make_block_volume.  Instead, it
should pass a value in MB to lvm and then check what size was actually
created before proceeding with the metadata creation.

Change-Id: Idd582110ffe7c8e6c6dfb94cc90d63770d59e170
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/60408
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/storagetestlib.py
M tests/storagetestlibTests.py
2 files changed, 36 insertions(+), 5 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/60408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idd582110ffe7c8e6c6dfb94cc90d63770d59e170
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Unify getVolumeLease signature

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sd: Unify getVolumeLease signature
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85d3f754c266ce5296d2e52ec9bd544728723a94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sd: Move getVolumeLease to StorageDomainManifest
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/60282/2/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 410: 
Line 411: def hasVolumeLeases(self):
Line 412: return self._domainLock.supports_volume_leases
Line 413: 
Line 414: def getVolumeLease(self, imgUUID, volUUID):
> Since this is already defined in both the file and block manifests, I don't
This is part of the interface, so we need here either an empty version that you 
can inherit, or a version that raises NotImplementedError. We cannot have 
method defined only on subclass, this make understanding the code much harder.

Since we had an empty method before, I'm keeping the original behavior.
Line 415: """
Line 416: Return the volume lease (leasePath, leaseOffset)
Line 417: """
Line 418: return None, None


-- 
To view, visit https://gerrit.ovirt.org/60282
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60b35e9a41d73ecba741d6fb9f90cdaeb35b3e3b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b604b9600db45ffa9092776c94f0278feb4746
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Support for multiple leases

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: clusterlock: Support for multiple leases
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/60422/2/lib/vdsm/storage/clusterlock.py
File lib/vdsm/storage/clusterlock.py:

Line 422: 
Line 423: def getHostStatus(self, hostId):
Line 424: return HOST_STATUS_UNAVAILABLE
Line 425: 
Line 426: def acquire(self, hostId, lease):
> Hmm, so we accept the lease param and ignore it.  I think we should either 
The next patch handles this, comparing the the lease used in initLock()
Line 427: with self._globalLockMapSync:
Line 428: self.log.info("Acquiring local lock for domain %s (id: 
%s)",
Line 429:   self._sdUUID, hostId)
Line 430: 


-- 
To view, visit https://gerrit.ovirt.org/60422
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7903b13bd017e3da6762e8979f7f4dfc6520de9e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Fix double close on EINTR

[automation]

gerrit-hooks has posted comments on this change.

Change subject: clusterlock: Fix double close on EINTR
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cae714af9646e268f40ff1ff3cdb3f6b048e6e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cluserlock: Use errno instead of os.errno
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15714261c3b25ccc90e98199225d61f134980788
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: cluserlock: Use errno instead of os.errno
..

cluserlock: Use errno instead of os.errno

The errno attribute in the os module is not part of the module api but a
side effect of python import. Code that need to error number should
import the errno module.

Change-Id: I15714261c3b25ccc90e98199225d61f134980788
Signed-off-by: Nir Soffer 
---
M lib/vdsm/storage/clusterlock.py
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/60538/1

diff --git a/lib/vdsm/storage/clusterlock.py b/lib/vdsm/storage/clusterlock.py
index 5243a7c..9317b0a 100644
--- a/lib/vdsm/storage/clusterlock.py
+++ b/lib/vdsm/storage/clusterlock.py
@@ -20,6 +20,7 @@
 
 from __future__ import absolute_import
 
+import errno
 import fcntl
 import logging
 import os
@@ -239,7 +240,7 @@
 sanlock.add_lockspace(self._sdUUID, hostId, self._idsPath,
   async=async)
 except sanlock.SanlockException as e:
-if e.errno == os.errno.EINPROGRESS:
+if e.errno == errno.EINPROGRESS:
 # if the request is not asynchronous wait for the ongoing
 # lockspace operation to complete
 if not async and not sanlock.inq_lockspace(
@@ -247,7 +248,7 @@
 raise se.AcquireHostIdFailure(self._sdUUID, e)
 # else silently continue, the host id has been acquired
 # or it's in the process of being acquired (async)
-elif e.errno != os.errno.EEXIST:
+elif e.errno != errno.EEXIST:
 raise se.AcquireHostIdFailure(self._sdUUID, e)
 
 self.log.debug("Host id for domain %s successfully acquired "
@@ -262,7 +263,7 @@
 sanlock.rem_lockspace(self._sdUUID, hostId, self._idsPath,
   async=async, unused=unused)
 except sanlock.SanlockException as e:
-if e.errno != os.errno.ENOENT:
+if e.errno != errno.ENOENT:
 raise se.ReleaseHostIdFailure(self._sdUUID, e)
 
 self.log.debug("Host id for domain %s released successfully "
@@ -311,7 +312,7 @@
 self.getLockDisk(),
 slkfd=SANLock._sanlock_fd)
 except sanlock.SanlockException as e:
-if e.errno != os.errno.EPIPE:
+if e.errno != errno.EPIPE:
 raise se.AcquireLockFailure(
 self._sdUUID, e.errno,
 "Cannot acquire cluster lock", str(e))
@@ -444,7 +445,7 @@
 del self._globalLockMap[self._sdUUID]
 
 # Raise any other unkown error.
-if e.errno != os.errno.EBADF:
+if e.errno != errno.EBADF:
 raise
 else:
 self.log.debug("Local lock already acquired for domain "
@@ -458,7 +459,7 @@
  fcntl.LOCK_EX | fcntl.LOCK_NB)
 except IOError as e:
 utils.NoIntrCall(os.close, lockFile)
-if e.errno in (os.errno.EACCES, os.errno.EAGAIN):
+if e.errno in (errno.EACCES, errno.EAGAIN):
 raise se.AcquireLockFailure(
 self._sdUUID, e.errno, "Cannot acquire local lock",
 str(e))


-- 
To view, visit https://gerrit.ovirt.org/60538
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15714261c3b25ccc90e98199225d61f134980788
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Fix double close on EINTR

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: clusterlock: Fix double close on EINTR
..

clusterlock: Fix double close on EINTR

If os.close(fd) was interrupted by signal, we would try to close again -
this may lead to closing other thread file descriptor.

close(2) warns not to retry close() after EINTR:

Note that the return value should be used only for diagnostics. In
particular close() should not be retried after an EINTR since this
may cause a reused descriptor from another thread to be closed.

See also this discussion about close and EINTR on linux:
http://lwn.net/Articles/576478/

This patch removes the utils.NoIntrCall around os.close() calls and
ignore EINTR instead. The behavior on other error is not changed, we
will raise the error.

Since we try os.close() inside the try block of the original error, we
have to keep the original exception for reraising it.

Change-Id: I3cae714af9646e268f40ff1ff3cdb3f6b048e6e9
Signed-off-by: Nir Soffer 
---
M lib/vdsm/storage/clusterlock.py
1 file changed, 14 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/60539/1

diff --git a/lib/vdsm/storage/clusterlock.py b/lib/vdsm/storage/clusterlock.py
index 9317b0a..30b4352 100644
--- a/lib/vdsm/storage/clusterlock.py
+++ b/lib/vdsm/storage/clusterlock.py
@@ -25,11 +25,13 @@
 import logging
 import os
 import subprocess
+import sys
 import threading
 
 from contextlib import nested
 
 import sanlock
+import six
 
 from vdsm import constants
 from vdsm import utils
@@ -458,12 +460,17 @@
 utils.NoIntrCall(fcntl.flock, lockFile,
  fcntl.LOCK_EX | fcntl.LOCK_NB)
 except IOError as e:
-utils.NoIntrCall(os.close, lockFile)
+t, v, tb = sys.exec_info()
+try:
+os.close(lockFile)
+except OSError as ce:
+if ce.errno != errno.EINTR:
+raise
 if e.errno in (errno.EACCES, errno.EAGAIN):
 raise se.AcquireLockFailure(
 self._sdUUID, e.errno, "Cannot acquire local lock",
 str(e))
-raise
+six.reraise(t, v, tb)
 else:
 self._globalLockMap[self._sdUUID] = (hostId, lockFile)
 
@@ -486,7 +493,11 @@
self._sdUUID)
 return
 
-utils.NoIntrCall(os.close, lockFile)
+try:
+os.close(lockFile)
+except OSError as e:
+if e.errno != errno.EINTR:
+raise
 self._globalLockMap[self._sdUUID] = (hostId, None)
 
 self.log.debug("Local lock for domain %s successfully released",


-- 
To view, visit https://gerrit.ovirt.org/60539
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cae714af9646e268f40ff1ff3cdb3f6b048e6e9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Support volume leases

[alitke]

Adam Litke has posted comments on this change.

Change subject: sd: Support volume leases
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60425
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb8711b9a88b8b57ed79cb3a246bbf3fcb9b2025
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Support for multiple leases

[alitke]

Adam Litke has posted comments on this change.

Change subject: clusterlock: Support for multiple leases
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/60422/2/lib/vdsm/storage/clusterlock.py
File lib/vdsm/storage/clusterlock.py:

Line 422: 
Line 423: def getHostStatus(self, hostId):
Line 424: return HOST_STATUS_UNAVAILABLE
Line 425: 
Line 426: def acquire(self, hostId, lease):
Hmm, so we accept the lease param and ignore it.  I think we should either 
require it to be None for localLock or pass the real values when initializing 
it.
Line 427: with self._globalLockMapSync:
Line 428: self.log.info("Acquiring local lock for domain %s (id: 
%s)",
Line 429:   self._sdUUID, hostId)
Line 430: 


-- 
To view, visit https://gerrit.ovirt.org/60422
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7903b13bd017e3da6762e8979f7f4dfc6520de9e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

[alitke]

Adam Litke has posted comments on this change.

Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0b604b9600db45ffa9092776c94f0278feb4746
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

[alitke]

Adam Litke has posted comments on this change.

Change subject: sd: Move getVolumeLease to StorageDomainManifest
..


Patch Set 2: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/60282/2/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 410: 
Line 411: def hasVolumeLeases(self):
Line 412: return self._domainLock.supports_volume_leases
Line 413: 
Line 414: def getVolumeLease(self, imgUUID, volUUID):
Since this is already defined in both the file and block manifests, I don't 
think we need this implementation.
Line 415: """
Line 416: Return the volume lease (leasePath, leaseOffset)
Line 417: """
Line 418: return None, None


-- 
To view, visit https://gerrit.ovirt.org/60282
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60b35e9a41d73ecba741d6fb9f90cdaeb35b3e3b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add make_volume to FakeEnv

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add make_volume to FakeEnv
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieba0617c10e10005e706d9f2a7d4800f077e1c2b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: fix make_block_volume size units

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: fix make_block_volume size units
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd582110ffe7c8e6c6dfb94cc90d63770d59e170
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: base.Job should not always require host_id

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: base.Job should not always require host_id
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60418
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab0ebfe221c8dc9ac21f0dbd509033f838f107af
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the SDM.copy_data API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Define the SDM.copy_data API
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60419
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id90a39820141365b865e861e1f89704947452c78
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Implement SDM.copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Implement SDM.copy_data
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60420
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff635c0c73f67b296033b4a506fc3b9ededfbe
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdc: Safer way to access storage domain manifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdc: Safer way to access storage domain manifest
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58879
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274c58fc60f40a9f7396d6be05dfe9b461bc2c8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add tmpdir and sdcache to FakeEnv

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add tmpdir and sdcache to FakeEnv
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60416
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31b91a977957a8253e67c4c861a9b0a15fbb8840
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: fix make_block_volume size units

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: fix make_block_volume size units
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd582110ffe7c8e6c6dfb94cc90d63770d59e170
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Modify reports to metrics

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Modify reports to metrics
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 450: 'Metric collector type (supporting statsd or hawkular)'),
Line 451: 
Line 452: ('queue_size', '100',
Line 453: 'Number of metrics to queue if collector is not 
responsive.'
Line 454: ' When the queue is full, oldest metrics are dropped. 
Used only'
> that's where we were wrong. metrics == מדדים. we send the metrics - not sam
We sample the system and report bunch of metrics on each sampling cycle. We 
queue groups of metrics, not single metrics. Make the comment clear about that.
Line 455: ' by hawkular-client collector (default 100).'),
Line 456: ]),
Line 457: 
Line 458: # Section: [devel]


-- 
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tox: fail make process if required tox version isn't installed.
..


Patch Set 21: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Modify reports to metrics

[oourfali]

Oved Ourfali has posted comments on this change.

Change subject: Modify reports to metrics
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Modify reports to metrics

[oourfali]

Oved Ourfali has posted comments on this change.

Change subject: Modify reports to metrics
..


Patch Set 2:

We don't want to use the terminology "reports" at all here, as it confused with 
other reports mechanism we used to have. 

Please make sure this gets merged ASAP. 
Nir, we discussed it and we want to avoid the reports. I'll appreciate asking 
this on a short loop. If you don't like metrics alone, we can use metrics 
dispatching or metrics broadcasting.

-- 
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 9:

done

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: docs: add README about logging configuration
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: docs: add README about logging configuration

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: docs: add README about logging configuration
..

docs: add README about logging configuration

Most notably, document how to tune the logging
settings of Vdsm at runtime, using Vdsclient

Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Backport-To: 4.0
Signed-off-by: Francesco Romani 
---
A README.logging
1 file changed, 48 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/60533/1

diff --git a/README.logging b/README.logging
new file mode 100644
index 000..c769585
--- /dev/null
+++ b/README.logging
@@ -0,0 +1,48 @@
+Logging in Vdsm
+===
+
+Basic configuration
+---
+
+Vdsm uses the python standard module[1] for logging.
+It can be configured using /etc/vdsm/logger.conf;
+the supervdsm logging is configured separately, using
+/etc/vdsm/svdsm.logger.conf
+
+Tuning the logging at runtime
+-
+
+Vdsm logging could be configured extensively[2]
+using the configuration files, but this requires a restart of the daemon.
+
+You can also configuring the logging to some extent at runtime, without
+any restart, using vdsClient as explained below.
+Please note that any change you make using vdsClient is not permanent, and
+will be lost once Vdsm is restarted.
+
+Using vdsClient, you can tune the log level of any logger Vdsm uses.
+The basic syntax is:
+
+# vdsClient [options] setLogLevel LEVEL [logger]
+
+`LEVEL` is one of DEBUG, INFO, WARNING, ERROR, CRITICAL
+`logger` is any logger Vdsm uses. Please check the configuration file
+to learn about some predefined loggers.
+
+If no logger is given, the root logger default level is changed.
+
+Please note that the logging configuration of Vdsm is quite complex, so
+few trivial settings may yield surprising results.
+
+Examples of runtime tuning of logging
+-
+
+WRITEME
+
+Notes
+-
+
+[1] https://docs.python.org/2/library/logging.html
+[2] 
https://docs.python.org/2/library/logging.config.html#logging-config-fileformat
+
+


-- 
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2653c2a68fcf42b1e085ae1ee703fb119a0cf1fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

[fromani]

Francesco Romani has posted comments on this change.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: gluster:enforce gluster fencing policies

[mperina]

Martin Peřina has posted comments on this change.

Change subject: gluster:enforce gluster fencing policies
..


Patch Set 4: Code-Review-1

I'd really like to move get_gluster_volinfo(), get_gluster_vol_status(), 
is_gluster_quorum_met() and get_brick() methods into some gluster part of VDSM. 
Only really necessary part of logic from can_fence_gluster_hosts() may be 
included in fence related part similarly as we do in host lease checking part 
(all host lease logic is hidden in _irs.getHostLeaseStatus().

Also please add new parameters of fenceNode verb into lib/api/vdsm-api.yml

-- 
To view, visit https://gerrit.ovirt.org/59600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c18571209a3a7682a43bd2814b9ee3f0a69c55f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Darshan N 
Gerrit-Reviewer: Eli Mesika 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Limit the number of workers in executor

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Limit the number of workers in executor
..


Patch Set 18: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/57754/18/tests/executorTests.py
File tests/executorTests.py:

Line 177: 
Line 178: # The other tasks shouldn't be unblocked and executed, 
let's check
Line 179: # things go as expected before proceeding (however we 
don't want to
Line 180: # stop and wait on each of the tasks, the first one is 
enough)
Line 181: self.assertFalse(tasks[0].executed.wait(1))
> I think it's better to give more chance than a fraction of second to potent
fair point.
Line 182: self.assertEqual([t for t in tasks if 
t.executed.is_set()],
Line 183:  [tasks[-1]])
Line 184: 
Line 185: # Extra tasks are not blocking, they were blocked just by 
the


-- 
To view, visit https://gerrit.ovirt.org/57754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba56d91474c6b14a1cfe2db827b6fd61843a1db2
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Fix return value names for VM.ioTune calls

[msivak]

Martin Sivák has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 1:

But I am still getting the same error while doing 
jsonrpcvdscli.connect(requestQueue=..).getIoTunePolicy("vmid")

[error 5] Response is missing 'ioTunePolicyList' member

I wonder why..

-- 
To view, visit https://gerrit.ovirt.org/60513
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 8: Code-Review-1

This patch (commit message) lacks explanation why is the move needed.

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

[fromani]

Francesco Romani has posted comments on this change.

Change subject: v2v: Log detailed output of virt-v2v
..


Patch Set 6:

(1 comment)

partial review, but as the story unfolds, the shell redirect approach is 
gaining some momentum.

https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG
Commit Message:

Line 13: It would be cleaner to modify execCmd() to store the log output, but
Line 14: this can dangerous without the function being refactored first.
Line 15: Therefore we resort to a dirty hack with shell to redirect stderr to
Line 16: stdout and store everything in a log file. This hack should be cleaned
Line 17: once execCmd() is updated.
> I don't know about any BZ. I'll try to find out or create a new one, if the
Yes Tomas, please file a new bug if we don't have one already.
Line 18: 
Line 19: Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Line 20: Bug-Url: https://bugzilla.redhat.com/1350465


-- 
To view, visit https://gerrit.ovirt.org/59834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Modify reports to metrics

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Modify reports to metrics
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 450: 'Metric collector type (supporting statsd or hawkular)'),
Line 451: 
Line 452: ('queue_size', '100',
Line 453: 'Number of metrics to queue if collector is not 
responsive.'
Line 454: ' When the queue is full, oldest metrics are dropped. 
Used only'
> again, metrics is not clear and confusing, we drop oldest samples, each sam
that's where we were wrong. metrics == מדדים. we send the metrics - not samples 
(sample is when you read the data) and not reports (report is when you query 
the data).
Line 455: ' by hawkular-client collector (default 100).'),
Line 456: ]),
Line 457: 
Line 458: # Section: [devel]


-- 
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 8: Code-Review-1

Martin's right, I remember _now_ why this is a good idea, but what about in 3 
months? Yaniv, please just add a few lines to document what we want to achieve 
here.

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

[rmohr]

Roman Mohr has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..


Patch Set 1:

* #1353559::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1353559::OK, public bug
* Check Product::#1353559::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1353559::ERROR, wrong target milestone for stable branch, 
ovirt-4.0.1 should match ^.*3.6.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

[msivak]

Martin Sivák has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: wait properly for migration to begin

[fromani]

Francesco Romani has posted comments on this change.

Change subject: migration: wait properly for migration to begin
..


Patch Set 8: Code-Review+1

please just amend the commit message adding Backport-To: 4.0 and it should be 
fine. Partial ACK meanwhile.

-- 
To view, visit https://gerrit.ovirt.org/60073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1ba369a0992c2473acf1395fad0b0c260c250ba
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Configure mom to ignore missing balloon device
..


Patch Set 1:

* #1337882::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1337882::OK, public bug
* Check Product::#1337882::OK, Correct classification oVirt
* Check TM::#1337882::OK, correct target milestone ovirt-3.6.8
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

[msivak]

Hello Dan Kenigsberg, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/60525

to review the following change.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..

sla: Use GuestIoTuneOptional collector in MOM

All major collectors in MOM now have the optional variant
that makes sure the VM can be processed even when some of
the functionality is missing.

The IoTune collector was the last one affected by this.

Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353559
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/59936
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit a030644e6ba0c05b438f80c59c451839adffb353)
Reviewed-on: https://gerrit.ovirt.org/59988
Continuous-Integration: Francesco Romani 
---
M vdsm.spec.in
M vdsm/mom.conf.in
M vdsm/mom.d/05-iotune.policy
3 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/60525/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 142e2e1..1f093a7 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -84,7 +84,7 @@
 BuildRequires: libselinux-python
 BuildRequires: libvirt-python
 BuildRequires: m2crypto
-BuildRequires: mom >= 0.5.4
+BuildRequires: mom >= 0.5.5
 BuildRequires: openssl
 BuildRequires: policycoreutils-python
 BuildRequires: psmisc
diff --git a/vdsm/mom.conf.in b/vdsm/mom.conf.in
index 0388162..f079673 100644
--- a/vdsm/mom.conf.in
+++ b/vdsm/mom.conf.in
@@ -81,4 +81,4 @@
 
 [guest]
 # A comma-separated list of Collector plugins to use for Guest data collection.
-collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloonOptional, 
GuestCpuTune, GuestIoTune
+collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloonOptional, 
GuestCpuTune, GuestIoTuneOptional
diff --git a/vdsm/mom.d/05-iotune.policy b/vdsm/mom.d/05-iotune.policy
index 3132986..b9d845c 100644
--- a/vdsm/mom.d/05-iotune.policy
+++ b/vdsm/mom.d/05-iotune.policy
@@ -30,7 +30,8 @@
 
 ### Main Script
 (if (== True ioTuneEnabled) {
-(with Guests guest (set_io_limits guest))
+(with Guests guest (if (valid guest.io_tune) (set_io_limits guest) 0))
 }{
-(with Guests guest (reset_io_limits guest))
-})
\ No newline at end of file
+(with Guests guest (if (valid guest.io_tune) (reset_io_limits guest) 0))
+})
+


-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Configure mom to ignore missing balloon device

[msivak]

Hello Roman Mohr, Dan Kenigsberg, Francesco Romani, Roy Golan,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/60524

to review the following change.

Change subject: Configure mom to ignore missing balloon device
..

Configure mom to ignore missing balloon device

In the past MOM was only responsible for ballooning. But now it also
manages some CPU and storage QoS settings. When there is no ballooning
device on the VM, MOM completely ignores that VM and therefore does not
set QoS attributes for CPU and storage.

Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1337882
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/57796
Reviewed-by: Roman Mohr 
Reviewed-by: Roy Golan 
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
(cherry picked from commit 77e45363ffbafe3e4edae313adb49b1dfc7a8bfe)
Reviewed-on: https://gerrit.ovirt.org/59058
---
M vdsm.spec.in
M vdsm/mom.conf.in
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/60524/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 58ad541..142e2e1 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -84,7 +84,7 @@
 BuildRequires: libselinux-python
 BuildRequires: libvirt-python
 BuildRequires: m2crypto
-BuildRequires: mom >= 0.5.3
+BuildRequires: mom >= 0.5.4
 BuildRequires: openssl
 BuildRequires: policycoreutils-python
 BuildRequires: psmisc
diff --git a/vdsm/mom.conf.in b/vdsm/mom.conf.in
index fbcb56a..0388162 100644
--- a/vdsm/mom.conf.in
+++ b/vdsm/mom.conf.in
@@ -81,4 +81,4 @@
 
 [guest]
 # A comma-separated list of Collector plugins to use for Guest data collection.
-collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloon, GuestCpuTune, 
GuestIoTune
+collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloonOptional, 
GuestCpuTune, GuestIoTune


-- 
To view, visit https://gerrit.ovirt.org/60524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I855b62fcf835aa3520037a863c3dbc6681fee360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Fix return value names for VM.ioTune calls

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Fix return value names for VM.ioTune calls
..


Patch Set 1: Code-Review+1

it seems I missed this when reviewing the original patches :\

-- 
To view, visit https://gerrit.ovirt.org/60513
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[fromani]

Francesco Romani has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 9:

looks good to me, but it seems one comment from Nir about vol.isSparse(0 was 
not handled.

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 8: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: try lock when executing user initated pool upgrade
..


Patch Set 2: -Verified

* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1260428::OK, public bug
* Check Product::#1260428::OK, Correct classification oVirt
* Check TM::#1260428::OK, correct target milestone ovirt-4.0.1
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdscli: added DeprecationWarning to module

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: vdscli: added DeprecationWarning to module
..


Patch Set 8:

can you post the output ?

-- 
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I728db1ed55e1449000f82c78d26f2774a2650c7e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

[laravot]

Liron Aravot has posted comments on this change.

Change subject: sp: try lock when executing user initated pool upgrade
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 7: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/57820/7/lib/vdsm/common/virt/vmstatus.py
File lib/vdsm/common/virt/vmstatus.py:

PS7, Line 2: 2013
2013-2016


-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: adding handling for NGN in osinfo.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: adding handling for NGN in osinfo.py
..


Patch Set 4:

* #1324447::Update tracker: OK
* Set MODIFIED::bug 1324447#1324447OK

-- 
To view, visit https://gerrit.ovirt.org/60433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida119527b263302bf3f78e359bac12113718b744
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Eli Mesika 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eli Mesika 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm: adding handling for NGN in osinfo.py

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vdsm: adding handling for NGN in osinfo.py
..


vdsm: adding handling for NGN in osinfo.py

Current osinfo.py implementation lacks handling for NGN (New Generation
Node).

This patch adds another parameter in addition to the osname, release and
version named pretty_name, that is empty by default and if
/etc/os-release file exists on the OS, will return the content of the
PRETTY_NAME value (if exists) from that file.

Change-Id: Ida119527b263302bf3f78e359bac12113718b744
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1324447
Signed-off-by: emesika 
Reviewed-on: https://gerrit.ovirt.org/59431
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-on: https://gerrit.ovirt.org/60433
Reviewed-by: Yaniv Bronhaim 
---
M lib/api/vdsm-api.yml
M lib/vdsm/osinfo.py
2 files changed, 31 insertions(+), 9 deletions(-)

Approvals:
  Eli Mesika: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/60433
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida119527b263302bf3f78e359bac12113718b744
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Eli Mesika 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eli Mesika 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..


Patch Set 2: -Verified

* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1260428::OK, public bug
* Check Product::#1260428::OK, Correct classification oVirt
* Check TM::#1260428::OK, correct target milestone ovirt-4.0.1
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60519
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

[laravot]

Liron Aravot has posted comments on this change.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..


Patch Set 1: Verified+1

Rerun-hooks: all

-- 
To view, visit https://gerrit.ovirt.org/60519
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60519/1//COMMIT_MSG
Commit Message:

Line 20: wasn't completed yet for will be upgraded to the new version.
Line 21: 
Line 22: Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Line 23: Bug-Url: https://bugzilla.redhat.com/1260428
Line 24: Signed-off-by: Liron Aravot 
Please add the metadata from the master patches. Waiting until master is merge 
will save time for you and for reviewers.


-- 
To view, visit https://gerrit.ovirt.org/60519
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sp: try lock when executing user initated pool upgrade
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60520/1//COMMIT_MSG
Commit Message:

Line 18: is rare and if it happens the user can simply try again.
Line 19: 
Line 20: Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Line 21: Bug-Url: https://bugzilla.redhat.com/1260428
Line 22: Signed-off-by: Liron Aravot 
Please add the metadata from the master patches. Waiting until master is merge 
will save time for you and for reviewers.


-- 
To view, visit https://gerrit.ovirt.org/60520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp: try lock when executing user initated pool upgrade

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: try lock when executing user initated pool upgrade
..


Patch Set 8:

* #1260428::Update tracker: OK
* Set MODIFIED::bug 1260428#1260428IGNORE, not all related patches are 
closed, check 60519

-- 
To view, visit https://gerrit.ovirt.org/59514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..


sp: allow executing upgradePool even if there is a pending update

Currently when a pool upgrade is initated (either by startSpm() or by
executing upgradePool() explicitly) the _domainsToUpgrade member of the
storage pool is initiated with the active domains, when each domain
upgrade is completed (or if the upgrade is unneeded) its id is removed
from that list.

When there is an unavailable domain, it'll remain on that list until its
update is complete - while it's unavailable other upgrade can't be
executed.
This patch changes that, we should allow upgrading the pool even if an
older upgrade wasn't complete yet - the domains that the old update
wasn't completed yet for will be upgraded to the new version.

Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Bug-Url: https://bugzilla.redhat.com/1260428
Signed-off-by: Liron Aravot 
Reviewed-on: https://gerrit.ovirt.org/57188
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm/storage/sp.py
1 file changed, 4 insertions(+), 29 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/57188
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..


Patch Set 11:

* #1260428::Update tracker: OK
* Set MODIFIED::bug 1260428#1260428IGNORE, not all related patches are 
closed, check 59514

-- 
To view, visit https://gerrit.ovirt.org/57188
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp: try lock when executing user initated pool upgrade

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: sp: try lock when executing user initated pool upgrade
..


sp: try lock when executing user initated pool upgrade

When attempting to execute upgradeStoragePool a concurrent
update on one of the pool domains may be during execution and hold
the pool upgrade lock.
In that case, the request to acquire the lock will wait for the lock
to be released which may cause the request to take longer then 3 minutes
and cause to engine failover.

When attempting to upgrade we should attempt to acquire the lock without
wait (try to lock) and if we fail return error immediately, that scenario
is rare and if it happens the user can simply try again.

Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Bug-Url: https://bugzilla.redhat.com/1260428
Signed-off-by: Liron Aravot 
Reviewed-on: https://gerrit.ovirt.org/59514
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
2 files changed, 32 insertions(+), 25 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Liron Aravot: Verified



-- 
To view, visit https://gerrit.ovirt.org/59514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: move metadata handling into helpers

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vmxml: move metadata handling into helpers
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57380
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb931f33ab83577ae6913ce8e99e6654a2183305
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: move namespace declaration

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vmxml: move namespace declaration
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/57381
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie33d816707cc76d4cce61a7d61d42a4304737ee6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Modify reports to metrics

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Modify reports to metrics
..


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 446: ('collector_address', 'localhost',
Line 447: 'Metric collector address (default localhost)'),
Line 448: 
Line 449: ('collector_type', 'statsd',
Line 450: 'Metric collector type (supporting statsd or hawkular)'),
> I should use always metrics
Automatic replacement of reports with metrics is wrong, do this.
Line 451: 
Line 452: ('queue_size', '100',
Line 453: 'Number of metrics to queue if collector is not 
responsive.'
Line 454: ' When the queue is full, oldest metrics are dropped. 
Used only'


Line 449: ('collector_type', 'statsd',
Line 450: 'Metric collector type (supporting statsd or hawkular)'),
Line 451: 
Line 452: ('queue_size', '100',
Line 453: 'Number of metrics to queue if collector is not 
responsive.'
> nope.. that's exactly the point.
metrics is not clear - we queue metric reports. If you think report may be 
confusing, use metric samples.
Line 454: ' When the queue is full, oldest metrics are dropped. 
Used only'
Line 455: ' by hawkular-client collector (default 100).'),
Line 456: ]),
Line 457: 


Line 450: 'Metric collector type (supporting statsd or hawkular)'),
Line 451: 
Line 452: ('queue_size', '100',
Line 453: 'Number of metrics to queue if collector is not 
responsive.'
Line 454: ' When the queue is full, oldest metrics are dropped. 
Used only'
> why? "oldest metrics are dropped" is the right term
again, metrics is not clear and confusing, we drop oldest samples, each sample 
contains many metrics.
Line 455: ' by hawkular-client collector (default 100).'),
Line 456: ]),
Line 457: 
Line 458: # Section: [devel]


-- 
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0aa10042b1c50fbdd94ae69053c74b57c3e6f40
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: split device init from domDependentInit
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..


Patch Set 1: Verified-1

* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1260428::OK, public bug
* Check Product::#1260428::OK, Correct classification oVirt
* Check TM::#1260428::OK, correct target milestone ovirt-4.0.1
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/60519
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: try lock when executing user initated pool upgrade
..


Patch Set 1: Verified-1

* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1260428::OK, public bug
* Check Product::#1260428::OK, Correct classification oVirt
* Check TM::#1260428::OK, correct target milestone ovirt-4.0.1
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/60520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: allow executing upgradePool even if there is a pending u...

[laravot]

Liron Aravot has uploaded a new change for review.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..

sp: allow executing upgradePool even if there is a pending update

Currently when a pool upgrade is initated (either by startSpm() or by
executing upgradePool() explicitly) the _domainsToUpgrade member of the
storage pool is initiated with the active domains, when each domain
upgrade is completed (or if the upgrade is unneeded) its id is removed
from that list.

When there is an unavailable domain, it'll remain on that list until its
update is complete - while it's unavailable other upgrade can't be
executed.
This patch changes that, we should allow upgrading the pool even if an
older upgrade wasn't complete yet - the domains that the old update
wasn't completed yet for will be upgraded to the new version.

Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Bug-Url: https://bugzilla.redhat.com/1260428
Signed-off-by: Liron Aravot 
---
M vdsm/storage/sp.py
1 file changed, 4 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/60519/1

diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 4347d3c..24b7d2b 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -175,8 +175,8 @@
exc_info=True)
 return
 
-with rmanager.acquireResource(sc.STORAGE, "upgrade_" + sdUUID,
-  rm.LockType.exclusive):
+with rmanager.acquireResource(sc.STORAGE, "upgrade_" + self.spUUID,
+  rm.LockType.shared):
 with rmanager.acquireResource(sc.STORAGE, sdUUID,
   rm.LockType.exclusive):
 if sdUUID not in self._domainsToUpgrade:
@@ -352,31 +352,13 @@
 self.log.debug("Shutting down upgrade process")
 with rmanager.acquireResource(sc.STORAGE, "upgrade_" + self.spUUID,
   rm.LockType.exclusive):
-domains = self._domainsToUpgrade[:]
 try:
 self.domainMonitor.onDomainStateChange.unregister(
 self._upgradeCallback)
 except KeyError:
 pass
-requests = []
 
-def cancelUpgrade(sdUUID, req, res):
-try:
-self._domainsToUpgrade.remove(sdUUID)
-except ValueError:
-pass
-
-res.release()
-
-for sdUUID in domains:
-req = rmanager.registerResource(sc.STORAGE,
-"upgrade_" + sdUUID,
-rm.LockType.exclusive,
-partial(cancelUpgrade, sdUUID))
-requests.append(req)
-
-for req in requests:
-req.wait()
+self._domainsToUpgrade = []
 
 @classmethod
 def cleanupMasterMount(cls):
@@ -440,9 +422,6 @@
 def _upgradePool(self, targetDomVersion):
 with rmanager.acquireResource(sc.STORAGE, "upgrade_" + self.spUUID,
   rm.LockType.exclusive):
-if len(self._domainsToUpgrade) > 0:
-raise se.PoolUpgradeInProgress(self.spUUID)
-
 sd.validateDomainVersion(targetDomVersion)
 self.log.info("Trying to upgrade master domain `%s`",
   self.masterDomain.sdUUID)
@@ -461,11 +440,7 @@
 self.domainMonitor.onDomainStateChange.register(
 self._upgradeCallback)
 self.log.debug("Running initial domain upgrade threads")
-# We need to copy the list as the domain monitor registered
-# callback and the initiated update threads may modify the list
-# while we iterate over it.
-# http://bugzilla.redhat.com/1319523
-for sdUUID in self._domainsToUpgrade[:]:
+for sdUUID in self._domainsToUpgrade:
 concurrent.thread(self._upgradeCallback,
   args=(sdUUID, True),
   kwargs={"__securityOverride": True},


-- 
To view, visit https://gerrit.ovirt.org/60519
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Liron Aravot 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sp: try lock when executing user initated pool upgrade

[laravot]

Liron Aravot has uploaded a new change for review.

Change subject: sp: try lock when executing user initated pool upgrade
..

sp: try lock when executing user initated pool upgrade

When attempting to execute upgradeStoragePool a concurrent
update on one of the pool domains may be during execution and hold
the pool upgrade lock.
In that case, the request to acquire the lock will wait for the lock
to be released which may cause the request to take longer then 3 minutes
and cause to engine failover.

When attempting to upgrade we should attempt to acquire the lock without
wait (try to lock) and if we fail return error immediately, that scenario
is rare and if it happens the user can simply try again.

Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Bug-Url: https://bugzilla.redhat.com/1260428
Signed-off-by: Liron Aravot 
---
M vdsm/storage/hsm.py
M vdsm/storage/sp.py
2 files changed, 32 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/60520/1

diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 359b2b3..e92edfd 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3342,7 +3342,7 @@
 # activateSD/deactivateSD) as the operation uses the pool metadata.
 vars.task.getExclusiveLock(STORAGE, spUUID)
 pool = self.getPool(spUUID)
-pool._upgradePool(targetDomVersion)
+pool._upgradePool(targetDomVersion, lockTimeout=0)
 return {"upgradeStatus": "started"}
 
 def _getDomsStats(self, domainMonitor, doms):
diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index 24b7d2b..bb55fd2 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -419,32 +419,39 @@
 
 self.spmRole = SPM_FREE
 
-def _upgradePool(self, targetDomVersion):
-with rmanager.acquireResource(sc.STORAGE, "upgrade_" + self.spUUID,
-  rm.LockType.exclusive):
-sd.validateDomainVersion(targetDomVersion)
-self.log.info("Trying to upgrade master domain `%s`",
-  self.masterDomain.sdUUID)
-with rmanager.acquireResource(sc.STORAGE, self.masterDomain.sdUUID,
-  rm.LockType.exclusive):
-self._convertDomain(self.masterDomain, str(targetDomVersion))
+def _upgradePool(self, targetDomVersion, lockTimeout=None):
+try:
+with rmanager.acquireResource(sc.STORAGE, "upgrade_" + self.spUUID,
+  rm.LockType.exclusive,
+  timeout=lockTimeout):
+sd.validateDomainVersion(targetDomVersion)
+self.log.info("Trying to upgrade master domain `%s`",
+  self.masterDomain.sdUUID)
+with rmanager.acquireResource(sc.STORAGE,
+  self.masterDomain.sdUUID,
+  rm.LockType.exclusive):
+self._convertDomain(self.masterDomain,
+str(targetDomVersion))
 
-self.log.debug("Marking all domains for upgrade")
-self._domainsToUpgrade = self.getDomains(activeOnly=True).keys()
-try:
-self._domainsToUpgrade.remove(self.masterDomain.sdUUID)
-except ValueError:
-pass
+self.log.debug("Marking all domains for upgrade")
+self._domainsToUpgrade = self.getDomains(activeOnly=True)\
+.keys()
+try:
+self._domainsToUpgrade.remove(self.masterDomain.sdUUID)
+except ValueError:
+pass
 
-self.log.debug("Registering with state change event")
-self.domainMonitor.onDomainStateChange.register(
-self._upgradeCallback)
-self.log.debug("Running initial domain upgrade threads")
-for sdUUID in self._domainsToUpgrade:
-concurrent.thread(self._upgradeCallback,
-  args=(sdUUID, True),
-  kwargs={"__securityOverride": True},
-  logger=self.log.name).start()
+self.log.debug("Registering with state change event")
+self.domainMonitor.onDomainStateChange.register(
+self._upgradeCallback)
+self.log.debug("Running initial domain upgrade threads")
+for sdUUID in self._domainsToUpgrade:
+concurrent.thread(self._upgradeCallback,
+  args=(sdUUID, True),
+  kwargs={"__securityOverride": True},
+  logger=self.log.name).start()
+except rm.RequestTimedOutError:

Change in vdsm[master]: vm: split vcpu settings from domDependentInit

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: split vcpu settings from domDependentInit
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59813
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9907a428b00d5851ece0037acfcc1ad72442ae46
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp: allow executing upgradePool even if there is a pending u...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: allow executing upgradePool even if there is a pending 
update
..


Patch Set 10:

* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1260428::OK, public bug
* Check Product::#1260428::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57188
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e14a3aa33bfab4751ab5d1e3becbeda892da4c3
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp: try lock when executing user initated pool upgrade

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sp: try lock when executing user initated pool upgrade
..


Patch Set 7:

* #1260428::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1260428::OK, public bug
* Check Product::#1260428::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp: try lock when executing user initated pool upgrade

[laravot]

Liron Aravot has posted comments on this change.

Change subject: sp: try lock when executing user initated pool upgrade
..


Patch Set 6: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/59514
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93bfdcb19437fdc8901c08ea17dc80fe9c1e5510
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder sampling initialization

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: reorder sampling initialization
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59815
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77e9575ade075d21b36f72915e4d4f2bf5badf92
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split guest agent init from domDependentInit

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: split guest agent init from domDependentInit
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59816
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I13e456d101659848c494f2c27912303c294ccf9f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 9:

* #734120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#734120::OK, public bug
* Check Product::#734120::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add inplace virt-sparsify support

[smelamud]

Shmuel Leib Melamud has posted comments on this change.

Change subject: storage: Add inplace virt-sparsify support
..


Patch Set 9:

(5 comments)

https://gerrit.ovirt.org/#/c/57347/8/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 7763: added: '3.2'
Line 7764: description: Clone an image structure from a source domain to a 
destination
Line 7765: domainwithin the same Storage Pool.
Line 7766: params:
Line 7767: -   description: The UUID of the Image
> Please match the copy_data api:
Done
Line 7768: name: imageID
Line 7769: type: *UUID
Line 7770: 
Line 7771: -   description: The UUID of the Storage Pool associated with 
the Image


https://gerrit.ovirt.org/#/c/57347/8/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:

Line 66: """
Line 67: cmd = [_VIRTSPARSIFY.cmd, '--machine-readable', '--in-place', 
vol_path]
Line 68: 
Line 69: rc, out, err = commands.execCmd(cmd, env={'LIBGUESTFS_BACKEND': 
'direct'})
Line 70: 
> You can remove the deathSignal, we are in the process of removing them in o
Done
Line 71: if rc != 0:


https://gerrit.ovirt.org/#/c/57347/8/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1621:   tmpSdUUID, tmpImgUUID, tmpVolUUID, 
dstSdUUID,
Line 1622:   dstImgUUID, dstVolUUID)
Line 1623: 
Line 1624: @public
Line 1625: def sdm_sparsify_inplace(self, job_id, vol_info):
> Lets use the new style used by sdm verbs:
Done
Line 1626: """
Line 1627: Reduce sparse image size by converting free space on image 
to free
Line 1628: space on storage domain using virt-sparsify --inplace 
(without using
Line 1629: a temporary volume).


Line 1632: vol = sdCache.produce(vol_info.sd_id).produceVolume(
Line 1633:   
imgUUID=vol_info.img_id,
Line 1634:   
volUUID=vol_info.vol_id)
Line 1635: if not vol.isSparse():
Line 1636: raise se.VolumeNotSparse()
> You need to take shared lock on the domain:
Done
Line 1637: 
Line 1638: vars.task.getSharedLock(STORAGE, vol_info.sd_id)
Line 1639: host_id = self.domainMonitor.getHostId(vol_info.sd_id)
Line 1640: job = sdm.api.sparsify_inplace.Job(job_id, vol_info, host_id)


https://gerrit.ovirt.org/#/c/57347/8/vdsm/storage/sdm/api/sparsify_inplace.py
File vdsm/storage/sdm/api/sparsify_inplace.py:

Line 41: 
Line 42: image_res_ns = sd.getNamespace(self.vol_info.sd_id, 
IMAGE_NAMESPACE)
Line 43: with rmanager.acquireResource(image_res_ns, 
self.vol_info.img_id,
Line 44:   rm.LockType.exclusive):
Line 45: vol = dom.produceVolume(imgUUID=self.vol_info.img_id,
> This is needed only for metadata operations, while this data operation.
Done
Line 46: volUUID=self.vol_info.vol_id)
Line 47: vol_path = vol.volumePath()
Line 48: vol.prepare()
Line 49: try:


-- 
To view, visit https://gerrit.ovirt.org/57347
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Shmuel Leib Melamud 
Gerrit-Reviewer: Shmuel Melamud 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Define the SDM.copy_data API

[alitke]

Adam Litke has posted comments on this change.

Change subject: Define the SDM.copy_data API
..


Patch Set 1:

(5 comments)

https://gerrit.ovirt.org/#/c/60419/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 6956: values:
Line 6957: - *vmUpdateInterfaceDeviceParams
Line 6958: - *vmUpdateGraphicsDeviceParams
Line 6959: 
Line 6960: CopyDataEndpointType: 
> Endpoint is too abstract, we need a more concrete name.
Suggestions?  I think CopyDataEndpoint is very clear since it includes the 
context of the verb where it will be used.
Line 6961: added: '4.1'
Line 6962: description: An enumeration of possible CopyDataEndpoint 
types
Line 6963: name: CopyDataEndpointType
Line 6964: type: enum


Line 6964: type: enum
Line 6965: values:
Line 6966: div: A vdsm volume identified by domain, image, and 
volume UUIDs
Line 6967: 
Line 6968: CopyDataDIVEndpoint: 
> How about VdsmVolume or OvirtVolume?
You initially suggested PDIV.  Do you now prefer VdsmVolume?
Line 6969: added: '4.1'
Line 6970: description: An endpoint describing a Volume on a vdsm 
Storage Domain.
Line 6971: properties:
Line 6972: -   description: The UUID of the Storage Domain


Line 6979: 
Line 6980: -   description: The UUID of the Volume
Line 6981: name: vol_id
Line 6982: type: *UUID
Line 6983: type: object
> object?
Yes, any dict type must have this.
Line 6984: 
Line 6985: CopyDataEndpoint: 
Line 6986: added: '4.1'
Line 6987: description: A discriminated record containing an endpoint 
for a


Line 6989: name: CopyDataEndpoint
Line 6990: properties:
Line 6991: -   description: The specific type of endpoint.
Line 6992: name: endpoint_type
Line 6993: type: *CopyDataEndpointType
> Why do we need a description object with name and type?
This is 'endpoint_type' which identifies the 'scheme' of this endpoint.  This 
way, vdsm doesn't need to infer the type it can do something like:

 if src['endpoint_type'] != 'div' or dst['endpoint_type'] != 'div':
 raise NotSupportedError("copy_data is only supported between vdsm volumes')
Line 6994: type: union
Line 6995: values:
Line 6996: - *CopyDataDIVEndpoint
Line 6997: 


Line 6992: name: endpoint_type
Line 6993: type: *CopyDataEndpointType
Line 6994: type: union
Line 6995: values:
Line 6996: - *CopyDataDIVEndpoint
> I used "scheme" here as an example, taken from urls, which are somewhat sim
The union syntax in the schema is a bit clunky but what is written in this 
patch basically agrees with what you have above.  You define a container of 
type union (CopyDataEndpoint) which has one property in common with all 
possible types/schemes (endpoint_type) which code can use to know which other 
fields will be present based on other defined types (CopyDataDIVEndpoint).

Here is some example json to copy from one vdsm volume to another:

 params = ('3e1ca477-f619-4638-a68c-dda71a665c36', # job_id
   {'endpoint_type': 'div',
'sd_id': 'a2aaf2d8-a7f5-4a3d-b21d-c0228a662abf',
'img_id': 'd2914456-9eb8-4cef-b7a9-800924f2e848',
'vol_id': '8e757f67-926b-4002-a5ce-e180e850bf31'
   }, # src endpoint
   {'endpoint_type': 'div',
'sd_id': '9b49f998-b1c5-4df6-8c8a-dbf4dd205a83',
'img_id': 'd2914456-9eb8-4cef-b7a9-800924f2e848',
'vol_id': '8e757f67-926b-4002-a5ce-e180e850bf31'
   } # dst endpoint
  )
 call('SDM.copy_data', params)
Line 6997: 
Line 6998: 
Line 6999: Host.setupNetworks:
Line 7000: added: '3.1'


-- 
To view, visit https://gerrit.ovirt.org/60419
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id90a39820141365b865e861e1f89704947452c78
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Moving vmstatus to vdsm.common.virt
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org