Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> On 18 Dec 2017, at 17:52, David Holmes wrote: > > On 19/12/2017 11:42 AM, Paul Sandoz wrote: >> Looks good to me. >> I am including HS dev for the class file version changes: >> http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version/webrev/ >> http://cr.openjdk.java.net/~psando

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

On 19/12/2017 11:42 AM, Paul Sandoz wrote: Looks good to me. I am including HS dev for the class file version changes: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version/webrev/ http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version-build-changes/webrev/ We ca

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Thanks Paul. I'm doing final checks and preparations of fixes to JDK-8173382: Add -source 11 and -target 11 to javac JDK-8193291: Add SourceVersion.RELEASE_11 and expect to push shortly. Cheers, -Joe On 12/18/2017 5:42 PM, Paul Sandoz wrote: Looks good to me. I am including HS dev

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Looks good to me. I am including HS dev for the class file version changes: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version/webrev/ http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-class

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hello, A follow-up on defining a final field RELEASE_CURRENT as an alias for the latest SourceVersion constant to allow easier updating of annotations using SourceVersion constants. Somewht surprisingly, this is not legal Java code; an annotation must use an enum constant directly and not a

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

ubject: Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11 Looking at JDK-8188015, I was just reminded of JDK-8188012 and JDK-8188013 which indicates that we have more than one place where 10 needs to be bump

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Here are two webrevs (in order that can be merged with the other): the class file version changes; and the build changes related to that. http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version/webrev/ http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-classfile-version-build-

RE: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> To: joe darcy ; compiler-...@openjdk.java.net; > build-dev ; STUART.MARKS > > Cc: David Holmes > Subject: Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and > -target 11 to javac - Java Bug System & JDK-8193291: Add > SourceVersion.RELEASE_11 > > Looking at

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

S > Cc: David Holmes > Subject: Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 > to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11 > > Looking at JDK-8188015, I was just reminded of JDK-8188012 and > JDK-8188013 which indicates that

RE: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

anks, iris -Original Message- From: Erik Joelsson Sent: Friday, December 15, 2017 4:41 AM To: joe darcy ; compiler-...@openjdk.java.net; build-dev ; STUART.MARKS Cc: David Holmes Subject: Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System &am

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Looking at JDK-8188015, I was just reminded of JDK-8188012 and JDK-8188013 which indicates that we have more than one place where 10 needs to be bumped to 11 make/BuildNashorn.gmk make/langtools/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java /Erik On 2017-12-12 16:36, Eri

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> On 13 Dec 2017, at 19:51, mark.reinh...@oracle.com wrote: > > 2017/12/13 15:49:53 -0800, paul.san...@oracle.com: >> On 13 Dec 2017, at 14:36, mark.reinh...@oracle.com wrote: >>> I understand that other incoming changes are waiting for the 11 version >>> bump, but can't we at least do the strai

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> On 14 Dec 2017, at 03:58, Erik Joelsson wrote: > > And here it is: http://cr.openjdk.java.net/~erikj/8173382/webrev.01/ > > Feel free to incorporate this into whichever changeset you want, or I can > push this separately. > Thanks! that is exactly what i was looking for. I will merge it i

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

And here it is: http://cr.openjdk.java.net/~erikj/8173382/webrev.01/ Feel free to incorporate this into whichever changeset you want, or I can push this separately. /Erik On 2017-12-14 10:37, Erik Joelsson wrote: On 2017-12-14 05:40, David Holmes wrote: On 14/12/2017 1:51 PM, mark.reinh..

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

On 2017-12-14 05:40, David Holmes wrote: On 14/12/2017 1:51 PM, mark.reinh...@oracle.com wrote: I just went through this for the versioning changes.  The attached patch (against d2a837cf9ff1) does what you want, I think. We can't do that. src/java.base/share/native/include/classfile_constant

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

On 14/12/2017 1:51 PM, mark.reinh...@oracle.com wrote: 2017/12/13 15:49:53 -0800, paul.san...@oracle.com: On 13 Dec 2017, at 14:36, mark.reinh...@oracle.com wrote: I understand that other incoming changes are waiting for the 11 version bump, but can't we at least do the straightforward paramete

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017/12/13 15:49:53 -0800, paul.san...@oracle.com: > On 13 Dec 2017, at 14:36, mark.reinh...@oracle.com wrote: >> I understand that other incoming changes are waiting for the 11 version >> bump, but can't we at least do the straightforward parameterizations and >> introduce _CURRENT constants in th

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi David, On 12/13/2017 5:16 PM, David Holmes wrote: Hi Joe, On 14/12/2017 4:36 AM, joe darcy wrote: There are various changes associated with a JDK N to (N+1) update including (but not limited to): 1) New -source/-target value in javac 2) Make new -source/-target value the defaul

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi Joe, On 14/12/2017 4:36 AM, joe darcy wrote: There are various changes associated with a JDK N to (N+1) update including (but not limited to):     1) New -source/-target value in javac     2) Make new -source/-target value the default in javac     3) Change build of the JDK to use new -s

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hello, On 12/13/2017 1:18 PM, mark.reinh...@oracle.com wrote: 2017/12/13 8:44:33 -0800, paul.san...@oracle.com: On 12 Dec 2017, at 20:56, david.hol...@oracle.com wrote: [snip] Looking at Joe's webrev, many of the changes from 10 to 11 could instead be changed to Runtime.getRuntime().versi

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> On 13 Dec 2017, at 14:36, mark.reinh...@oracle.com wrote: > > 2017/12/13 14:09:44 -0800, paul.san...@oracle.com: >>> On 13 Dec 2017, at 13:18, mark.reinh...@oracle.com wrote: >>> How much of this can we parameterize and/or automate? >> >> I suspect quite a bit, as you present below, and i agr

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017/12/13 14:09:44 -0800, paul.san...@oracle.com: >> On 13 Dec 2017, at 13:18, mark.reinh...@oracle.com wrote: >> How much of this can we parameterize and/or automate? > > I suspect quite a bit, as you present below, and i agree we should try > and automate as much as possible. At the moment it’s

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Don't forget to add the new version to the list of validated versions in multi-release JARs... On 12/13/2017 1:36 PM, joe darcy wrote: There are various changes associated with a JDK N to (N+1) update including (but not limited to):     1) New -source/-target value in javac     2) Make new

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> On 13 Dec 2017, at 13:18, mark.reinh...@oracle.com wrote: > > 2017/12/13 8:44:33 -0800, paul.san...@oracle.com: >>> On 12 Dec 2017, at 20:56, david.hol...@oracle.com wrote: >>> >>> Anyway, none of the proposed changes have any impact on hotspot >>> AFAICT. It is only when the actual version i

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

2017/12/13 8:44:33 -0800, paul.san...@oracle.com: >> On 12 Dec 2017, at 20:56, david.hol...@oracle.com wrote: >> >> Anyway, none of the proposed changes have any impact on hotspot >> AFAICT. It is only when the actual version is updated to 11 that >> hotspot, and other entities will have to be upd

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

On 12/13/17 10:36 AM, joe darcy wrote: Hi David, On 12/12/2017 8:56 PM, David Holmes wrote: Hi Joe, On 13/12/2017 9:20 AM, joe darcy wrote: Hi David, On 12/12/2017 1:32 PM, David Holmes wrote: [snip] For background, what we've done in the past is at the very start of a new JDK

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi David, On 12/12/2017 8:56 PM, David Holmes wrote: Hi Joe, On 13/12/2017 9:20 AM, joe darcy wrote: Hi David, On 12/12/2017 1:32 PM, David Holmes wrote: [snip] For background, what we've done in the past is at the very start of a new JDK release, first create -source/-target ${N+

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Joe, Here's a patch on top of your patch: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8173382-release-classfile-version/webrev/ Currently building/testing with both patches applied. Paul. > On 13 Dec

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> On 12 Dec 2017, at 20:56, David Holmes wrote: > > Anyway, none of the proposed changes have any impact on hotspot AFAICT. It is > only when the actual version is updated to 11 that hotspot, and other > entities will have to be updated. I'm still unclear if someone is actually > driving the

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi Joe, On 13/12/2017 9:20 AM, joe darcy wrote: Hi David, On 12/12/2017 1:32 PM, David Holmes wrote: Hi Joe, On 13/12/2017 7:27 AM, joe darcy wrote: Hi David, On 12/12/2017 1:11 PM, David Holmes wrote: Hi Joe, On 12/12/2017 5:04 PM, joe darcy wrote: Hello, With the JDK 11 line of deve

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi David, On 12/12/2017 1:32 PM, David Holmes wrote: Hi Joe, On 13/12/2017 7:27 AM, joe darcy wrote: Hi David, On 12/12/2017 1:11 PM, David Holmes wrote: Hi Joe, On 12/12/2017 5:04 PM, joe darcy wrote: Hello, With the JDK 11 line of development opening up in a few days, a few changes a

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi Joe, On 13/12/2017 7:27 AM, joe darcy wrote: Hi David, On 12/12/2017 1:11 PM, David Holmes wrote: Hi Joe, On 12/12/2017 5:04 PM, joe darcy wrote: Hello, With the JDK 11 line of development opening up in a few days, a few changes are needed to prepared to turn a JDK 10 code base into a

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi David, On 12/12/2017 1:11 PM, David Holmes wrote: Hi Joe, On 12/12/2017 5:04 PM, joe darcy wrote: Hello, With the JDK 11 line of development opening up in a few days, a few changes are needed to prepared to turn a JDK 10 code base into a JDK 11 one including: JDK-8173382: Add -so

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi Joe, On 12/12/2017 5:04 PM, joe darcy wrote: Hello, With the JDK 11 line of development opening up in a few days, a few changes are needed to prepared to turn a JDK 10 code base into a JDK 11 one including:     JDK-8173382: Add -source 11 and -target 11 to javac     JDK-8193291: Add So

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> On 12 Dec 2017, at 10:03, Paul Sandoz wrote: > > > >> On 12 Dec 2017, at 09:52, joe darcy wrote: >> >> Hi Paul, >> >> There is sense in working in including the class file version update at the >> same time if the added complexity doesn't delay the changes. >> > > I sense it should be

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

> On 12 Dec 2017, at 09:52, joe darcy wrote: > > Hi Paul, > > There is sense in working in including the class file version update at the > same time if the added complexity doesn't delay the changes. > I sense it should be so complex and delay since the additional code changes can be copi

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi Paul, There is sense in working in including the class file version update at the same time if the added complexity doesn't delay the changes. Did the patch for the increment to 54 require previous changes in the bundled ASM? Thanks, -Joe On 12/12/2017 9:31 AM, Paul Sandoz wrote: Hi

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hi Joe, I would like to see the class file version increment [*] in the same patch (the unified repo makes this easier now). Then we have everything in one changeset (except for any ctsym changes?) that can be easily templated when the next increment is required, since we will be doing this fa

Re: Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Build change looks good. /Erik On 2017-12-12 08:04, joe darcy wrote: Hello, With the JDK 11 line of development opening up in a few days, a few changes are needed to prepared to turn a JDK 10 code base into a JDK 11 one including:     JDK-8173382: Add -source 11 and -target 11 to javac   

Initial JDK 11 RFR of JDK-8173382: Add -source 11 and -target 11 to javac - Java Bug System & JDK-8193291: Add SourceVersion.RELEASE_11

Hello, With the JDK 11 line of development opening up in a few days, a few changes are needed to prepared to turn a JDK 10 code base into a JDK 11 one including: JDK-8173382: Add -source 11 and -target 11 to javac JDK-8193291: Add SourceVersion.RELEASE_11 Webev: http://cr