[PATCH] D52271: [Sema] Ensure that we retain __restrict qualifiers when substituting a reference type.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. https://reviews.llvm.org/D52271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

shuaiwang marked 5 inline comments as done. shuaiwang added inline comments. Comment at: unittests/Analysis/ExprMutationAnalyzerTest.cpp:67 +if (const auto *DRE = dyn_cast(E)) { + if (DRE->getNameInfo().getAsString()[0] == 'p') +Finder = PointeeMutationFinder;

[PATCH] D52271: [Sema] Ensure that we retain __restrict qualifiers when substituting a reference type.

erik.pilkington updated this revision to Diff 166224. erik.pilkington added a comment. Sure, the new patch just preserves __restrict qualifiers. Thanks! https://reviews.llvm.org/D52271 Files: clang/lib/Sema/TreeTransform.h clang/test/SemaCXX/subst-restrict.cpp Index:

[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL342614: [PowerPC] [Clang] Add vector int128 pack/unpack builtins (authored by qshanz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52271: [Sema] Ensure that we retain __restrict qualifiers when substituting a reference type.

rjmccall added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:4268 +Quals.removeVolatile(); + } `restrict` is unique in being able to be applied to reference types. You should just rebuild `Quals` from scratch, preserving only `restrict`.

[PATCH] D52267: [AST] Various optimizations + refactoring in DeclarationName(Table)

rjmccall added a comment. Conceptually, this change looks great. And it should be fine to require extra alignment on `IdentifierInfo` on 32-bit hosts; I doubt that will have measurable impact. I believe it's possible to eliminate the need for most, perhaps all, of these `static_asserts` by

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

wzssyqa updated this revision to Diff 166220. wzssyqa added a comment. remove mips64(el)-linux-gnu from path search. Repository: rC Clang https://reviews.llvm.org/D51464 Files: lib/Basic/Targets/Mips.h lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp

[PATCH] D50850: clang: Add triples support for MIPS r6

wzssyqa updated this revision to Diff 166219. Repository: rC Clang https://reviews.llvm.org/D50850 Files: lib/Driver/ToolChains/Arch/Mips.cpp lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/CodeGen/atomics-inlining.c test/CodeGen/mips-zero-sized-struct.c

[PATCH] D52021: Fix Bug 38926: don't merge short case labels if followed by a block

owenpan added a comment. This fix has become obvious, but I still prefer that it gets reviewed before I commit it. Repository: rC Clang https://reviews.llvm.org/D52021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

steven.zhang added a comment. I will commit the patch for you. Repository: rC Clang https://reviews.llvm.org/D52074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52021: Fix Bug 38926: don't merge short case labels if followed by a block

owenpan updated this revision to Diff 166216. owenpan added a comment. Simplified the fix and improved the test case. Repository: rC Clang https://reviews.llvm.org/D52021 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

Szelethus added inline comments. Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:86 +// - Pointer to non-const +// - Pointer-like type with `operator*` returning non-const reference +bool isPointeeMutable(const Expr *Exp, const ASTContext ) { Didn't you mean

Re: r229575 - clang-cl: Disable frame pointer elimination at -O0

The generic O flag handling doesn't support 0 either. Would you be ok with removing this? Does /Od do what you want? On Wed, Sep 19, 2018 at 4:52 PM Reid Kleckner wrote: > I was probably using it myself, and was surprised that /O0 and -O0 had > different behavior, because -O0 will hit the

[PATCH] D52259: [CUDA] Rearrange search path ordering to fix two test case failures

gaijiading updated this revision to Diff 166206. gaijiading added a comment. Apologies for having uploaded the wrong patch in my original review request. Please help review this version instead. Thanks. Repository: rC Clang https://reviews.llvm.org/D52259 Files:

[PATCH] D51901: Thread Safety Analysis: warnings for attributes without arguments

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. In https://reviews.llvm.org/D51901#1239759, @delesley wrote: > This looks okay to me, but I have not tested it on a large code base to see > if it breaks anything. On our code base (not as large as Google's) there

r342605 - Thread Safety Analysis: warnings for attributes without arguments

Author: aaronpuchert Date: Wed Sep 19 17:39:27 2018 New Revision: 342605 URL: http://llvm.org/viewvc/llvm-project?rev=342605=rev Log: Thread Safety Analysis: warnings for attributes without arguments Summary: When thread safety annotations are used without capability arguments, they are assumed

[PATCH] D51901: Thread Safety Analysis: warnings for attributes without arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rC342605: Thread Safety Analysis: warnings for attributes without arguments (authored by aaronpuchert, committed by ). Changed prior to commit: https://reviews.llvm.org/D51901?vs=165004=166205#toc

[PATCH] D44263: Implement LWG 2221 - No formatted output operator for nullptr

davide added a comment. This broke all the lldb bots as well, FWIW. https://reviews.llvm.org/D44263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r342601 - [Clang-tidy] Alphabetical sort of files/checks. Add space after clang-tidy in source code headers.

Author: eugenezelenko Date: Wed Sep 19 17:02:55 2018 New Revision: 342601 URL: http://llvm.org/viewvc/llvm-project?rev=342601=rev Log: [Clang-tidy] Alphabetical sort of files/checks. Add space after clang-tidy in source code headers. Modified:

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

This revision was automatically updated to reflect the committed changes. Closed by commit rC342600: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate (authored by aaronpuchert, committed by ). Changed prior to commit:

r342600 - Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

Author: aaronpuchert Date: Wed Sep 19 16:57:38 2018 New Revision: 342600 URL: http://llvm.org/viewvc/llvm-project?rev=342600=rev Log: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate Summary: This imitates the code for MemberExpr. Fixes PR38896. Reviewers:

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

aaronpuchert added a comment. It seems that `self` is an ordinary `DeclRefExpr` unlike `this`, which is a `CXXThisExpr`. Which means we'd have to make it dependent on the name whether we drop it, but `self` in C/C++ is just an ordinary variable. So I think I'll leave the `self->` part for now.

[PATCH] D44263: Implement LWG 2221 - No formatted output operator for nullptr

vsapsai added a comment. Reverted in r342599 . https://reviews.llvm.org/D44263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51187: [RFC] Thread safety analysis: Track status of scoped capability

delesley added inline comments. Comment at: lib/Analysis/ThreadSafety.cpp:929 + return Handler.handleDoubleLock(DiagKind, entry.toString(), entry.loc()); +Locked = true; + It's been a while since I last looked at this code, but I don't think you can

[PATCH] D52268: [AST] Squeeze some bits in LinkageComputer

george.burgess.iv added a comment. Thanks for this! LGTM after erichkeane's comments are resolved. > I did a little digging on this, and it seems to be to keep track of a > declarations linkage for caching sake Yeah, otherwise, we get exponential behavior on some pathological template-y

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

Eugene.Zelenko added a comment. Looks like you patch is not based on trunk. Please rebase. Comment at: docs/ReleaseNotes.rst:60 +- New `modernize-replace-generic-functor-call + `_

[PATCH] D44263: Implement LWG 2221 - No formatted output operator for nullptr

vsapsai added a comment. Seems like revert didn't go through. I suspect it is causing build failure in http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/49593/consoleText SANITIZER_TEST_OBJECTS.sanitizer_vector_test.cc.i386.o SANITIZER_TEST_OBJECTS.gtest-all.cc.i386.o

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

Eugene.Zelenko added inline comments. Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:114 +} +} // namespace modernize +} // namespace tidy Please insert empty line above. Repository: rCTE Clang Tools Extra

[PATCH] D52281: Use std::invoke in generic code

Eugene.Zelenko added inline comments. Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:1 +//===--- ReplaceGenericFunctorCallCheck.cpp - clang-tidy---===// +// Please add space after clang-tidy. Comment at:

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

manojgupta added a comment. As per https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80868, I thought GCC also emits this error but only with -pedantic. So probably should keep this error but under -Wextra or another appropriate group? Repository: rC Clang https://reviews.llvm.org/D52248

Re: r342525 - [NFC] Fix uncompilable test cases of ExprMutationAnalyzer.

Thanks! That sorted us right out. Dave From: Shuai Wang Sent: 19 September 2018 21:32 To: David Green Cc: cfe-commits@lists.llvm.org Subject: Re: r342525 - [NFC] Fix uncompilable test cases of ExprMutationAnalyzer. On Wed, Sep 19, 2018 at 3:10 AM David Green

[PATCH] D52281: Use std::invoke in generic code

boga95 created this revision. boga95 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgorny. In generic code (e.g.: in a type dependent expression), the `std::invoke` should be used, in order to support functors, function pointers, pointers to members, regular

[PATCH] D52280: Don't trim non-alphanumeric characters in 'file not found' errors for include directives.

jgorbe created this revision. jgorbe added reviewers: christylee, rsmith, aaron.ballman. r342177 introduced a hint in cases where an #included file is not found. It tries to find a suggestion by removing leading or trailing non-alphanumeric characters and

[PATCH] D44263: Implement LWG 2221 - No formatted output operator for nullptr

mclow.lists added a comment. Symbol added: _ZNSt3__113basic_ostreamIcNS_11char_traitsIcEEElsEDn {'is_defined': True, 'type': 'FUNC', 'name': '_ZNSt3__113basic_ostreamIcNS_11char_traitsIcEEElsEDn'} Symbol added: _ZNSt3__113basic_ostreamIwNS_11char_traitsIwEEElsEDn {'is_defined': True,

[PATCH] D44263: Implement LWG 2221 - No formatted output operator for nullptr

mclow.lists reopened this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Reverted in r342590 while I investigate additions to the dylib. https://reviews.llvm.org/D44263 ___ cfe-commits mailing list

r342586 - [NFC] Declare instead of define non-void functions in unit tests.

Author: shuaiwang Date: Wed Sep 19 13:27:25 2018 New Revision: 342586 URL: http://llvm.org/viewvc/llvm-project?rev=342586=rev Log: [NFC] Declare instead of define non-void functions in unit tests. Modified: cfe/trunk/unittests/Analysis/ExprMutationAnalyzerTest.cpp Modified:

[PATCH] D52259: [CUDA] Rearrange search path ordering to fix two test case failures

tra added a comment. The patch does not seem to match the description and appears to have nothing to do with rearranging include paths. Could you check if these are the changes you intended to send for review. Repository: rC Clang https://reviews.llvm.org/D52259

[PATCH] D52200: Thread safety analysis: Handle ObjCIvarRefExpr in SExprBuilder::translate

delesley added inline comments. Comment at: lib/Analysis/ThreadSafetyCommon.cpp:362 + til::Project *P = new (Arena) til::Project(E, D); + if (hasCppPointerType(BE)) +P->setArrow(true); aaronpuchert wrote: > rjmccall wrote: > > aaron.ballman wrote: > > > I

[PATCH] D52261: [Sema] Generate completion fix-its for C code as well

ilya-biryukov added a comment. It's the responsibility of the caller to provide a corrected expression, this keeps the completion function simpler. I suggest we stick to this contract. We do something in `getLangOpts().CPlusPlus` case to create a corrected expression, let's just implement a

[PATCH] D50948: lambdas in modules: change storage for LambdaDefinitionData

elsteveogrande added a comment. I did try a copy of https://reviews.llvm.org/D50949 again, locally and without this diff, to see if I can avoid messing with this structure altogether. But then I get a `SEGV`. The reason behind this diff is to try to make the logic a little safer, though it's

r342581 - test: actually fix the condition properly

Author: compnerd Date: Wed Sep 19 12:20:30 2018 New Revision: 342581 URL: http://llvm.org/viewvc/llvm-project?rev=342581=rev Log: test: actually fix the condition properly I had locally changed the test to add an explicit triple to figure out the issue with the SCEI buildbots, and that hid the

[PATCH] D51901: Thread Safety Analysis: warnings for attributes without arguments

delesley accepted this revision. delesley added a comment. This revision is now accepted and ready to land. This looks okay to me, but I have not tested it on a large code base to see if it breaks anything. Comment at: lib/Sema/SemaDeclAttr.cpp:589 +<< AL <<

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. ilya-biryukov added a dependency: D52274: [clangd] Collect and store expected types in the index. ilya-biryukov planned changes to this revision.

[PATCH] D52276: [clangd] Add type boosting in code completion

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. Ranking-related code should be moved to `Quality.cpp` Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52276 ___ cfe-commits mailing list

[PATCH] D52275: [Index] Expose USR generation for types

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric. Herald added a subscriber: kadircet. Used in clangd. Repository: rC Clang https://reviews.llvm.org/D52275 Files: include/clang/Index/USRGeneration.h lib/Index/USRGeneration.cpp Index:

[PATCH] D52274: [clangd] Collect and store expected types in the index

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. Need to store the types in RIFF format too Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52274: [clangd] Collect and store expected types in the index

ilya-biryukov created this revision. ilya-biryukov added reviewers: ioeric, sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. And add a hidden option to control whether the types are collected. For experiments, will be removed when expected types implementation is

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added inline comments. Comment at: clangd/ExpectedTypes.h:119 + explicit SType(SHA1Array Data); + SHA1Array Data; +}; I assume this will be controversial. Happy to discuss/change. We are currently building this representation based on USRs for

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added a comment. The implementation might look a bit scary, please feel free to ask for comments/clarifications! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52273 ___ cfe-commits mailing list

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. Provides facilities to model the C++ conversion rules without the AST. The introduced representation can be stored in the index and used

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

wgml marked 2 inline comments as done. wgml added inline comments. Comment at: clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:102-108 + if (childrenCount(ND.decls()) == 0) { +SourceRange Removal(Namespaces.front().Begin, Namespaces.front().RBrace); + +

r342569 - test: improve condition for the check

Author: compnerd Date: Wed Sep 19 11:41:07 2018 New Revision: 342569 URL: http://llvm.org/viewvc/llvm-project?rev=342569=rev Log: test: improve condition for the check When the type of `wint_t` is `int`, the promotion will allow this to pass. Check this explicitly rather than using the size.

Re: r342214 - remove 11 years old videos from the homepage. if you have a suggestion, please drop me an email

Both videos return 404  anyway :) I created a redirect to llvm.org S Le 17/09/2018 à 22:02, David Blaikie a écrit : > If you're going to remove these, might as well remove the html files > they link to? > > On the other hand, might be worth keeping these around/linked to, but > for

r342568 - redirecting to llvm.org/devmtg

Author: sylvestre Date: Wed Sep 19 11:39:15 2018 New Revision: 342568 URL: http://llvm.org/viewvc/llvm-project?rev=342568=rev Log: redirecting to llvm.org/devmtg Modified: cfe/trunk/www/clang_video-05-25-2007.html cfe/trunk/www/clang_video-07-25-2007.html Modified:

[PATCH] D44263: Implement LWG 2221 - No formatted output operator for nullptr

mclow.lists closed this revision. mclow.lists added a comment. Landed as revision 342566 https://reviews.llvm.org/D44263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52271: [Sema] Ensure that we retain __restrict qualifiers when substituting a reference type.

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall. Herald added a subscriber: dexonsmith. Fixes rdar://43760099. Thanks for taking a look! Repository: rC Clang https://reviews.llvm.org/D52271 Files: clang/lib/Sema/TreeTransform.h

[PATCH] D51868: [libcxx] Build and test fixes for Windows

hamzasood added inline comments. Comment at: test/support/verbose_assert.h:26 static_assert(ST == -1, "specialization required for ST != -1"); static void Print(Tp const&) { std::clog << "Value Not Streamable!\n"; } }; mclow.lists wrote: > > The renaming

r342565 - Sema: handle `wint_t` more carefully for printf checking

Author: compnerd Date: Wed Sep 19 11:13:34 2018 New Revision: 342565 URL: http://llvm.org/viewvc/llvm-project?rev=342565=rev Log: Sema: handle `wint_t` more carefully for printf checking In the case that `win_t` is an `unsigned short` (e.g. on Windows), we would previously incorrectly diagnose

[PATCH] D50948: lambdas in modules: change storage for LambdaDefinitionData

elsteveogrande updated this revision to Diff 166148. elsteveogrande added a comment. Change `Optional` to `unique_ptr` instead, to at least save an allocation and keep the same semantics. Reverified with `ninja check-clang`. Repository: rC Clang https://reviews.llvm.org/D50948 Files:

r342562 - [analyzer] Fix nullptr access when processing instantiated function in ExprMutationAnalyzer.

Author: shuaiwang Date: Wed Sep 19 11:00:55 2018 New Revision: 342562 URL: http://llvm.org/viewvc/llvm-project?rev=342562=rev Log: [analyzer] Fix nullptr access when processing instantiated function in ExprMutationAnalyzer. Modified: cfe/trunk/lib/Analysis/ExprMutationAnalyzer.cpp

[PATCH] D50551: [libcxx] [test] Add missing to several tests.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LFTM https://reviews.llvm.org/D50551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50799: Fix for PR 38495: no longer compiles on FreeBSD, due to lack of timespec_get()

mclow.lists closed this revision. mclow.lists added a comment. Landed as r339816 https://reviews.llvm.org/D50799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50815: Establish the header

mclow.lists closed this revision. mclow.lists added a comment. Landed as r339943 https://reviews.llvm.org/D50815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50876: Clean up newly created header

mclow.lists closed this revision. mclow.lists added a comment. Landed as r340049 https://reviews.llvm.org/D50876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52268: [AST] Squeeze some bits in LinkageComputer

erichkeane added subscribers: gbiv, george.burgess.iv. erichkeane added a comment. In https://reviews.llvm.org/D52268#1239557, @riccibruno wrote: > In https://reviews.llvm.org/D52268#1239538, @erichkeane wrote: > > > Does this still work with 32 bit hosts? Does PointerIntPair have 3 bits in >

[PATCH] D51868: [libcxx] Build and test fixes for Windows

mclow.lists added inline comments. Comment at: test/support/verbose_assert.h:26 static_assert(ST == -1, "specialization required for ST != -1"); static void Print(Tp const&) { std::clog << "Value Not Streamable!\n"; } }; > The renaming is to clarify that

[PATCH] D52268: [AST] Squeeze some bits in LinkageComputer

riccibruno added a comment. In https://reviews.llvm.org/D52268#1239538, @erichkeane wrote: > Does this still work with 32 bit hosts? Does PointerIntPair have 3 bits in > that case? Is the alignof static_assert valid in that case? I think it does since Decl is manually over-aligned to 8

[PATCH] D52267: [AST] Various optimizations + refactoring in DeclarationName(Table)

riccibruno added inline comments. Comment at: include/clang/AST/DeclarationName.h:243 + /// C++ literal operator, or C++ using directive. uintptr_t Ptr = 0; erichkeane wrote: > There is an llvm type for storing something in the lower bits of a pointer.

r342557 - Basic: correct `__WINT_TYPE__` on Windows

Author: compnerd Date: Wed Sep 19 09:18:55 2018 New Revision: 342557 URL: http://llvm.org/viewvc/llvm-project?rev=342557=rev Log: Basic: correct `__WINT_TYPE__` on Windows Windows uses `unsigned short` for `wint_t`. Correct the type definition as vended by the compiler. This type is defined in

[PATCH] D52268: [AST] Squeeze some bits in LinkageComputer

erichkeane added a comment. Does this still work with 32 bit hosts? Does PointerIntPair have 3 bits in that case? Is the alignof static_assert valid in that case? Comment at: lib/AST/Linkage.h:40 + enum { NumLVComputationKindBits = 3 }; + I'm not sure

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. > clang-cl isn't supposed to do (explicit) registry accesses when you hold it > right (pass in -fms-compatibility-version etc). Have you seen registry access > costs, or is that speculation? No speculation, I will share the FileMon logs shortly. It is indirectly

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

thakis added a comment. Since it helps existing msbuild configs, adding this seems like a good thing to me. clang-cl isn't supposed to do (explicit) registry accesses when you hold it right (pass in -fms-compatibility-version etc). Have you seen registry access costs, or is that speculation?

[PATCH] D52267: [AST] Various optimizations + refactoring in DeclarationName(Table)

erichkeane added a comment. A few drive-by comments... This is a patch with interactions I'm not sure I feel comfortable approving myself, so I'll count on @rjmccall to do so. Comment at: include/clang/AST/DeclarationName.h:243 + /// C++ literal operator, or C++ using

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

twoh added a comment. ping! Repository: rC Clang https://reviews.llvm.org/D38061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52268: [AST] Squeeze some bits in LinkageComputer

riccibruno created this revision. riccibruno added reviewers: erichkeane, rjmccall. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Since Decls are already aligned explicitly to 8 bytes, stash the 3 bits representing an LVComputationKind into the lower 3 bits of the

[PATCH] D52267: [AST] Various optimizations + refactoring in DeclarationName(Table)

riccibruno created this revision. riccibruno added reviewers: erichkeane, rjmccall. riccibruno added a project: clang. Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini. Introduce the following optimizations in DeclarationName(Table) 1. Store common kinds inline in DeclarationName

[PATCH] D52266: [clang-cl] Provide separate flags for all the /O variants

thakis added a comment. FWIW the recommendation against /Ox in my version is because of https://github.com/ulfjack/ryu/pull/70#issuecomment-412168459 https://reviews.llvm.org/D52266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52266: [clang-cl] Provide separate flags for all the /O variants

thakis added inline comments. Comment at: include/clang/Driver/CLCompatOptions.td:129 +def _SLASH_Oy : CLFlag<"Oy">, Alias<_SLASH_O>, AliasArgs<["y"]>, HelpText<"Enable frame pointer omission (x86 only)">; +def _SLASH_Oy_ : CLFlag<"Oy-">, Alias<_SLASH_O>, AliasArgs<["y-"]>,

[PATCH] D52266: [clang-cl] Provide separate flags for all the /O variants

compnerd added inline comments. Comment at: test/Driver/Xarch.c:5 +// RUN: not grep ' "-O3" ' %t.log +// RUN: grep "argument unused during compilation: '-Xarch_i386 -O3'" %t.log // RUN: not %clang -target i386-apple-darwin9 -m32 -Xarch_i386 -o -Xarch_i386 -S %s -S -Xarch_i386

[PATCH] D50949: lambdas in modules: handle lambdas in .pcm [de]serialization

elsteveogrande updated this revision to Diff 166130. elsteveogrande added a comment. rebase atop https://reviews.llvm.org/D50948 (correctly this time) to exclude those changes Repository: rC Clang https://reviews.llvm.org/D50949 Files: include/clang/AST/LambdaCapture.h

[PATCH] D52266: [clang-cl] Provide separate flags for all the /O variants

hans created this revision. hans added reviewers: thakis, rnk. This provides better help text in "clang-cl /?". Also it cleans things up a bit: previously "/Od" could be handled either as a separate flag aliased to "-O0", or by the main optimization flag processing in TranslateOptArg. With

[PATCH] D51868: [libcxx] Build and test fixes for Windows

hamzasood added inline comments. Comment at: include/filesystem:1396 - _LIBCPP_FUNC_VIS void __create_what(int __num_paths); compnerd wrote: > This possibly changes the meaning on other targets. What was the error that > this triggered? I've re-uploaded

[PATCH] D51868: [libcxx] Build and test fixes for Windows

hamzasood updated this revision to Diff 166124. hamzasood added a comment. Herald added a subscriber: christof. I've added a fix for another related issue: the tests would fail to link if libc++ is built only as a DLL. The auto-linking doesn't look for a dynamic library unless `_DLL` is defined

[PATCH] D50214: Add inherited attributes before parsed attributes.

Meinersbur added a comment. ping Repository: rC Clang https://reviews.llvm.org/D50214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

aganea added a comment. In https://reviews.llvm.org/D52193#1239171, @hans wrote: > Thanks for adding the Ninja numbers. It confirms that Ninja is significantly > faster than MSBuild + /MP. It is true for the 6-cores Xeon, but not for the dual-18-cores. I think there are two issues there,

[PATCH] D52264: Deduplicate replacements from diagnostics.

ioeric created this revision. ioeric added a reviewer: bkramer. Herald added a subscriber: cfe-commits. After r329813, clang-apply-replacements stopped deduplicating identical replacements; however, tools like clang-tidy relies on the deduplication of identical dignostics replacements from

[PATCH] D52261: [Sema] Generate completion fix-its for C code as well

yvvan updated this revision to Diff 166110. yvvan added a comment. Test is added https://reviews.llvm.org/D52261 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/member-access.c Index: test/CodeCompletion/member-access.c

[clang-tools-extra] r342540 - [clang-tidy] run-clang-tidy.py - fails using python 3.7

Author: abpostelnicu Date: Wed Sep 19 04:52:20 2018 New Revision: 342540 URL: http://llvm.org/viewvc/llvm-project?rev=342540=rev Log: [clang-tidy] run-clang-tidy.py - fails using python 3.7 Differential Revision: https://reviews.llvm.org/D51220 Modified:

[PATCH] D52261: [Sema] Generate completion fix-its for C code as well

yvvan created this revision. yvvan added reviewers: nik, ilya-biryukov. Current completion fix-its approach does not provide OtherOpBase for C code. But we can easily proceed in this case taking the original Base type. https://reviews.llvm.org/D52261 Files: lib/Sema/SemaCodeComplete.cpp

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

This revision was automatically updated to reflect the committed changes. Closed by commit rL342540: [clang-tidy] run-clang-tidy.py - fails using python 3.7 (authored by Abpostelnicu, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D51220: [clang-tidy] run-clang-tidy fails using python 3.7

Abpostelnicu updated this revision to Diff 166095. https://reviews.llvm.org/D51220 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/tool/run-clang-tidy.py +++

[PATCH] D52173: Python bindings TypeError in reparse method

bdcht edited reviewers, added: sylvestre.ledru; removed: clang. bdcht added a comment. changed reviewers. Repository: rC Clang https://reviews.llvm.org/D52173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta added a comment. PTAL again. I confirmed that current patch can link chrome and functions with local static variable are exported. But current ToT clang was not improved well by this patch. I guess there is some change recently making effect of this patch smaller. Or chromium has

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta updated this revision to Diff 166087. takuto.ikuta retitled this revision from "[WIP] Add /Zc:DllexportInlines option to clang-cl" to "Add /Zc:DllexportInlines option to clang-cl". takuto.ikuta edited the summary of this revision. https://reviews.llvm.org/D51340 Files:

[PATCH] D51214: [clangd] Add option to enable/disable function argument snippets.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342533: [clangd] Add option to enable/disable function argument snippets. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D51214?vs=166076=166082#toc

[clang-tools-extra] r342533 - [clangd] Add option to enable/disable function argument snippets.

Author: kadircet Date: Wed Sep 19 03:16:44 2018 New Revision: 342533 URL: http://llvm.org/viewvc/llvm-project?rev=342533=rev Log: [clangd] Add option to enable/disable function argument snippets. Summary: Currently LSP clients cannot directly change EnableFunctionArgSnippets parameter. This

[clang-tools-extra] r342529 - [clangd] Store preamble macros in dynamic index.

Author: ioeric Date: Wed Sep 19 02:35:04 2018 New Revision: 342529 URL: http://llvm.org/viewvc/llvm-project?rev=342529=rev Log: [clangd] Store preamble macros in dynamic index. Summary: Pros: o Loading macros from preamble for every completion is slow (see profile). o Calculating macro USR is

[PATCH] D52078: [clangd] Store preamble macros in dynamic index.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342529: [clangd] Store preamble macros in dynamic index. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D52078?vs=165959=166078#toc Repository: rCTE Clang

[PATCH] D52079: [Sema] Do not load macros from preamble when LoadExternal is false.

This revision was automatically updated to reflect the committed changes. Closed by commit rC342528: [Sema] Do not load macros from preamble when LoadExternal is false. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D52079?vs=165969=166077#toc

r342528 - [Sema] Do not load macros from preamble when LoadExternal is false.

Author: ioeric Date: Wed Sep 19 02:34:55 2018 New Revision: 342528 URL: http://llvm.org/viewvc/llvm-project?rev=342528=rev Log: [Sema] Do not load macros from preamble when LoadExternal is false. Reviewers: ilya-biryukov Reviewed By: ilya-biryukov Subscribers: cfe-commits Differential

  1   2   >