[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 351628. RedDocMD added a comment. Fixed up technique used to find inner pointer type, put TODO's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/lib/S

[PATCH] D98618: [clang-tidy] Add --skip-headers, part 1 (with TopLevelDecl bit)

chh added a comment. Please review https://reviews.llvm.org/D98710, which uses get/setTraversalScope instead of adding a TopLevelDecl bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98618/new/ https://reviews.llvm.org/D98618 ___ cfe-commi

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

MaskRay added inline comments. Comment at: clang/docs/AddressSanitizer.rst:17 * Use-after-free -* Use-after-return (runtime flag `ASAN_OPTIONS=detect_stack_use_after_return=1`) +* Use-after-return (clang flag `-fsanitize-address-use-after-return=(always|runtime|never)` default

[PATCH] D98709: [clang-tidy] Add --skip-headers, part 1

chh updated this revision to Diff 351617. chh retitled this revision from "clang-tidy skip-headers; Alt#1; fewer changes" to "[clang-tidy] Add --skip-headers, part 1". chh edited the summary of this revision. chh added a comment. Herald added subscribers: cfe-commits, xazax.hun. sync with latest

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1

chh updated this revision to Diff 351616. chh retitled this revision from "WIP; clang-tidy skip-headers; Alt#2; need more changes" to "[clang-tidy] Add --skip-headers, part 1". chh edited the summary of this revision. chh added a comment. Herald added subscribers: cfe-commits, xazax.hun. sync wit

[PATCH] D98618: [clang-tidy] Add --skip-headers, part 1

chh updated this revision to Diff 351615. chh added a comment. Herald added a subscriber: cfe-commits. sync with latest clang/llvm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98618/new/ https://reviews.llvm.org/D98618 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-

[PATCH] D104088: Add clang frontend flags for MIP

ellis updated this revision to Diff 351604. ellis added a comment. Move llvm-strip logic into its own commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104088/new/ https://reviews.llvm.org/D104088 Files: clang/include/clang/Driver/Options.td

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

amccarth added a comment. This patch was reverted a while back because a couple DirectoryWatcher tests routinely timed out on build bots even though they work when run in isolation. I believe the problem is that, on a machine busy doing a build, the startup of the watcher thread is delayed (eit

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. In D103131#2814015 , @dblaikie wrote: > In D103131#2811969 , @kamleshbhalui > wrote: > >> In D103131#2811220 , @dblaikie >> wrote: >> >>>

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

mcgrathr added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_fuchsia.cpp:29 + +uptr kHighMemEnd; +uptr kHighMemBeg; leonardchan wrote: > mcgrathr wrote: > > These need comments about what they are and why they need to exist as > > runtime variables

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

mcgrathr added a comment. Usually we like to split changes up into separate small changes for the pure refactoring, and then changes that purely add new Fuchsia-specific code. I'll do an initial review round of the Fuchsia code here since you've sent it. But then I think this review should be t

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 351571. kda marked an inline comment as done. kda added a comment. - Revised according to feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D104155 Files: clang/docs/Ad

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

vitalybuka added inline comments. Comment at: clang/docs/AddressSanitizer.rst:18 +* Use-after-return (clang flag `-fsanitize-address-use-after-return=(always|runtime|never)` default: runtime) + * Add runtime flag `ASAN_OPTIONS=detect_stack_use_after_return=1` to enable when co

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda created this revision. kda added a reviewer: vitalybuka. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. for issue: https://github.com/google/sanitizers/issues/1394 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

[PATCH] D103623: [Clang] Test case for -Wunused-but-set-variable, warn for volatile.

mbenfield updated this revision to Diff 351563. mbenfield added a comment. rebase and rerun builds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103623/new/ https://reviews.llvm.org/D103623 Files: clang/test/Sema/warn-unused-but-set-variables.c

[PATCH] D104138: Create install targets for scan-build-py.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104138/new/ https://reviews.llvm.org/D104138 ___

[clang] 22dea69 - [clang][ObjC] allow the use of NSAttributedString * argument type with format attribute

Author: Alex Lorenz Date: 2021-06-11T13:24:32-07:00 New Revision: 22dea6923155b18d172db64e5dab4b71afe19e6e URL: https://github.com/llvm/llvm-project/commit/22dea6923155b18d172db64e5dab4b71afe19e6e DIFF: https://github.com/llvm/llvm-project/commit/22dea6923155b18d172db64e5dab4b71afe19e6e.diff L

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

vsavchenko added a comment. In D104135#2814081 , @NoQ wrote: > P.S. I like this design! > > I'm trying to remember why we needed a factory in the first place. Who's gonna carry your callbacks for ya, huh? > I think a lot of tags work just fine as static

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

davidxl added a comment. Adding Wei to help measure performance impact on our internal workloads. Also add Wenlei to help measure impact with FB's workloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D1040

[PATCH] D103184: [AArch64] handle -Wa,-march=

nickdesaulniers added a comment. In D103184#2813748 , @thakis wrote: > In D103184#2804241 , @jcai19 wrote: > >> In D103184#2803768 , @thakis wrote: >> >>> FWIW the failure

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. P.S. I like this design! I'm trying to remember why we needed a factory in the first place. I think a lot of tags work just fine as static variables. In case of D104136

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0b469ffa142: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang. (authored by kda). Repository: rG LLVM Github Monorepo CHAN

[clang] e0b469f - [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

Author: Kevin Athey Date: 2021-06-11T12:07:35-07:00 New Revision: e0b469ffa142353fc90bfc6eadb638a805ebed75 URL: https://github.com/llvm/llvm-project/commit/e0b469ffa142353fc90bfc6eadb638a805ebed75 DIFF: https://github.com/llvm/llvm-project/commit/e0b469ffa142353fc90bfc6eadb638a805ebed75.diff L

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks added a comment. Can you also add tests with the alignment of declarations? We already have such for pointers. Comment at: clang/include/clang/Format/Format.h:2706 + /// references). + ReferenceAlignmentStyle ReferenceAlignment; + Please m

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

dblaikie added a comment. In D103888#2813236 , @RKSimon wrote: > In D103888#2811305 , @dblaikie > wrote: > >> Sounds OK. >> >> I wouldn't mind the places that can use op<< to use that - not sure >> preserving th

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx added a comment. I'm aware that this commit triggers one failure in ASan/Windows -- I have posted a patch for review to address that here: https://reviews.llvm.org/D104141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/new/

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

HazardyKnusperkeks added a comment. Going the full way, to fix the number of empty lines after/before/between elements would be real nice. But even nicer would be if you can state a range. But I think all those proposed options should not be added in one go. In D104044#2812399

[PATCH] D103131: support debug info for alias variable

dblaikie added a comment. In D103131#2811969 , @kamleshbhalui wrote: > In D103131#2811220 , @dblaikie > wrote: > >> Any idea if the GDB test suite covers this functionality? I'd hope so, but >> maybe it doesn't

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:953-957 + // Let's traverse... + for (const ExplodedNode *N = ExprNode; + // ...all the nodes corresponding to the given expression... +

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:777 static bool classof(const ProgramPointTag *T) { return T->getTagKind() == &Kind; } It sounds like `NoteTag` `isn't` despite inheriting from it

[PATCH] D104082: [CodeGen] Don't create a fake FunctionDecl when generating block/block_byref copy/dispose helper functions

dblaikie added a comment. In D104082#2812088 , @ahatanak wrote: > Also, is it okay to emit the `linkageName`, but not the `name` for the helper > functions? It seems okay to me, but I'm not sure. Not 100% sure - perhaps @aprantl can weigh in on this. If

[PATCH] D104046: [analyzer] Simplify the process of producing notes for stores

vsavchenko updated this revision to Diff 351515. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104046/new/ https://reviews.llvm.org/D104046 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter

[PATCH] D103644: [analyzer] Refactor StoreSiteFinder and extract DefaultStoreHandler

vsavchenko updated this revision to Diff 351512. vsavchenko marked 2 inline comments as done. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103644/new/ https://reviews.llvm.org/D103644 Files: clang/

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:201-202 +const TypedValueRegion *TVR = llvm::dyn_cast(ThisRegion); +assert(TVR && "expected std::make_unique to return a std::unique_ptr " + "object (which is ty

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_fuchsia.cpp:29 + +uptr kHighMemEnd; +uptr kHighMemBeg; mcgrathr wrote: > These need comments about what they are and why they need to exist as runtime > variables at all. `kHighMemEnd`

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan updated this revision to Diff 351510. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103936/new/ https://reviews.llvm.org/D103936 Files: compiler-rt/lib/hwasan/CMakeLists.txt compiler-rt/l

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2813797 , @phosek wrote: > In D101479#2813724 , @mstorsjo > wrote: > >> Couldn’t this commit have been kept in, and just reverting the one for using >> it in the fuchsia cmak

[PATCH] D103087: [clang-tidy] performances-unnecessary-* checks: Extend isOnlyUsedAsConst to expressions and catch const methods returning non-const references/pointers.

flx added a comment. In D103087#2793673 , @ymandel wrote: > I have some concerns about the cost of this checks as it used matching over > entire contexts quite extensively. At this point, the facilities involved > seem quite close to doing dataflow ana

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. Ah, sorry I missed where you mentioned LSR. If this pass is causing regressions in multiple places, even on X86, then I think it does make sense to remove it. I've added some people that m

[PATCH] D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

kda added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2973 IRBuilder<> IRB(*C); - switch (ClUseAfterReturn) { - case AsanDetectStackUseAfterReturnMode::Always: -for (int i = 0; i <= kMaxAsanStackMallocSizeClass; i++) { - std

[PATCH] D104076: [clang-cl][sanitizer] Add -fsanitize-address-use-after-return to clang.

kda updated this revision to Diff 351505. kda marked 9 inline comments as done. kda added a comment. - fixed up conflicting command line parameters. - only emit asan_stack_malloc calls when needed. - trimmed namespace ('llvm'). - improved tests. - Changed default parameters from Never to Runtime.

[PATCH] D104135: [analyzer] Decouple NoteTag from its Factory

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, manas, RedDocMD. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision.

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. In D101479#2813724 , @mstorsjo wrote: > Couldn’t this commit have been kept in, and just reverting the one for using > it in the fuchsia cmake cache? (I’m not using this particular commit myself, > just observing.) The problem i

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

MyDeveloperDay added a comment. My point being there is inconsistency between how different types of blocks of code are handled, and rather than trying to fix another corner case maybe we should take a more holistic approach, all these KeepEmptyLines and EmptyLineAfterXXX options and what you'l

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri added a comment. In D104099#2813743 , @aeubanks wrote: > Which pass that comes after SpeculateAroundPHIs in the X86 pipeline (either > in the optimization or codegen) would undo its effects? As i have wrote in some other review, the pass i sa

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce44fe199bbf: [Sema] Address-space sensitive check for unbounded arrays (v2) (authored by chrish_ericsson_atx). Repository: rG LLVM Github Monorep

[clang] ce44fe1 - [Sema] Address-space sensitive check for unbounded arrays (v2)

Author: eahcmrh Date: 2021-06-11T19:34:03+02:00 New Revision: ce44fe199bbfd4b5a44764b678c431fdc117116a URL: https://github.com/llvm/llvm-project/commit/ce44fe199bbfd4b5a44764b678c431fdc117116a DIFF: https://github.com/llvm/llvm-project/commit/ce44fe199bbfd4b5a44764b678c431fdc117116a.diff LOG:

[PATCH] D103184: [AArch64] handle -Wa,-march=

thakis added a comment. In D103184#2804241 , @jcai19 wrote: > In D103184#2803768 , @thakis wrote: > >> FWIW the failure goes away locally if I revert this change here, so it's >> definitely due to this change her

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

aeubanks added a comment. Which pass that comes after SpeculateAroundPHIs in the X86 pipeline (either in the optimization or codegen) would undo its effects? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D10409

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx updated this revision to Diff 351491. chrish_ericsson_atx added a comment. Corrected APSInt.toString() usage to comply with intervening change 61cdaf66fe22be2b5 Repository: rG LLVM Github Monorepo CHAN

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. Couldn’t this commit have been kept in, and just reverting the one for using it in the fuchsia cmake cache? (I’m not using this particular commit myself, just observing.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1014

[PATCH] D103928: [IR] make -warn-frame-size into a module attr

nickdesaulniers added a comment. FWIW, it was pointed out to me that the commit message doesn't precisely match the actual attribute name. The actual attribute name is `warn-stack-size`, but the commit message uses `-warn-frame-size`. Oh well. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri added a comment. In D104099#2813713 , @aeubanks wrote: > Some backends don't run SimplifyCFG, e.g. X86. I believe the pass was > originally created specifically for X86 (the header has some X86 examples) > and may or may not extend to other t

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

aeubanks added a comment. Some backends don't run SimplifyCFG, e.g. X86. I believe the pass was originally created specifically for X86 (the header has some X86 examples) and may or may not extend to other targets (I'm not very familiar with the pass itself). I'm not opposed to landing this an

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

darwin added a comment. In D104044#2813491 , @MyDeveloperDay wrote: > Devils advocate how is this any different from > > class Foo { > > class Bar {} ; > } > > }; > > This would become > > class Foo { > class Bar {}; > }; > > i.e.

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 351485. RedDocMD added a comment. Removed un-necessary check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtrModel

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

MyDeveloperDay added a comment. A new nits but I'd say it was pretty good. Comment at: clang/lib/Format/Format.cpp:1356 Style.PointerAlignment = FormatStyle::PAS_Left; + Style.ReferenceAlignment = FormatStyle::RAS_Pointer; Style.SpaceBeforeCpp11BracedList = true; ---

[PATCH] D104062: [HIP] Fix --hip-version flag with 0 as component

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2cc0427b13e: [HIP] Fix --hip-version flag with 0 as component (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[clang] f2cc042 - [HIP] Fix --hip-version flag with 0 as component

Author: Aaron En Ye Shi Date: 2021-06-11T16:25:03Z New Revision: f2cc0427b13ef10e67eed6eab9eefb58e8aef3d9 URL: https://github.com/llvm/llvm-project/commit/f2cc0427b13ef10e67eed6eab9eefb58e8aef3d9 DIFF: https://github.com/llvm/llvm-project/commit/f2cc0427b13ef10e67eed6eab9eefb58e8aef3d9.diff LO

[PATCH] D103849: Fix undeduced type when instanciating template member

aaron.ballman added a comment. I think this is reasonable, but I'd like to hear from @rsmith before landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-commits mailing list cfe-com

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx reopened this revision. chrish_ericsson_atx added a comment. This revision is now accepted and ready to land. Reverted commit due to buildbot failures -- will update shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/ne

[clang] 82a3b60 - Update the C status page somewhat.

Author: Aaron Ballman Date: 2021-06-11T12:06:50-04:00 New Revision: 82a3b606b01d2da23a40785222f3f7d15401dda0 URL: https://github.com/llvm/llvm-project/commit/82a3b606b01d2da23a40785222f3f7d15401dda0 DIFF: https://github.com/llvm/llvm-project/commit/82a3b606b01d2da23a40785222f3f7d15401dda0.diff

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp updated this revision to Diff 351467. stefanp added a comment. Updated the name of the option to vector-compare compat. Added clang test lines to the test cases. Added deprecation warnings to the current default behaviour of vector bool and vector pixel. Repository: rG LLVM Github Mono

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

MyDeveloperDay added a comment. We should have perhaps though about this when we added ```EmptyLineAfterAccessModifier ``` and ```EmptyLineBeforeAccessModifier ``` Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104044/new/ https://reviews.llvm.org/D

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

MyDeveloperDay added a comment. Do we need a set options for when we want to insert/retain/add a newline after various constructs? frankly I've been mulling over the concept of adding a NewLinesBetweenFunctions: 1 I personally don't like code written like this as I find it hard to read, I'd

[PATCH] D104125: [PowerPC] Moving defineXLCompatMacros() definition

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] Moving the definition of the defineXLCompatMacros function from the header file clang/lib/Basic

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp added a comment. In D103615#2799498 , @bmahjour wrote: > As far as I can see, there is no good reason for the special treatment of > vector bool/pixel going forward. Could we drop this special treatment, or at > least change the default to use s

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

MyDeveloperDay added a comment. Devils advocate how is this any different from class Foo { class Bar {} ; } }; This would become class Foo { class Bar {}; }; i.e. its going to remove the extra lines, just asking so we can understand if the removal of the line is the err

[PATCH] D104124: [IR] Simplify createReplacementInstr

foad added reviewers: yaxunl, robertlytton. foad added a comment. Given how simple createReplacementInstr is now, this does make me wonder if it was really worth creating ReplaceConstant.{cpp,h} in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D104124: [IR] Simplify createReplacementInstr

foad created this revision. Herald added subscribers: dexonsmith, hiraditya. foad requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. NFCI, although the test change shows that ConstantExpr::getAsInstruction is better than the

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 351462. mizvekov added a comment. Look through AttributedType when obtaining FunctionDecl return type. Adds a couple more test cases to cover this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ htt

[clang] 7e9822c - Revert "[Sema] Address-space sensitive check for unbounded arrays (v2)"

Author: eahcmrh Date: 2021-06-11T17:44:06+02:00 New Revision: 7e9822cc55065b7c450dda254340765794e11fe3 URL: https://github.com/llvm/llvm-project/commit/7e9822cc55065b7c450dda254340765794e11fe3 DIFF: https://github.com/llvm/llvm-project/commit/7e9822cc55065b7c450dda254340765794e11fe3.diff LOG:

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov reopened this revision. mizvekov added a comment. This revision is now accepted and ready to land. Thank you @stella.stamenova and @aeubanks for reporting and reverting this. Turns out was a silly mistake where we were not digging down through AttributedType nodes in order to get the fu

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe42a347b7440: [Sema] Address-space sensitive check for unbounded arrays (v2) (authored by chrish_ericsson_atx). Changed prior to commit: https://r

[clang] e42a347 - [Sema] Address-space sensitive check for unbounded arrays (v2)

Author: eahcmrh Date: 2021-06-11T17:36:16+02:00 New Revision: e42a347b74400b7212ceaaea6d39562a0435df42 URL: https://github.com/llvm/llvm-project/commit/e42a347b74400b7212ceaaea6d39562a0435df42 DIFF: https://github.com/llvm/llvm-project/commit/e42a347b74400b7212ceaaea6d39562a0435df42.diff LOG:

[PATCH] D102901: [HWASan] Add basic stack tagging support for LAM.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0867edfc6438: [HWASan] Add basic stack tagging support for LAM. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D102901: [HWASan] Add basic stack tagging support for LAM.

morehouse updated this revision to Diff 351459. morehouse added a comment. - Fix clang test failure on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102901/new/ https://reviews.llvm.org/D102901 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart updated this revision to Diff 351454. stuart added a comment. Add missing trailing commas to CHECK lines of FileCheck test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104118/new/ https://reviews.llvm.org/D104118 Files: clang/lib/CodeGe

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart added a comment. Note: there is currently no DWARF language code defined for //C++ for OpenCL//, so we must use DW_LANG_C_plus_plus* if we wish to be able to determine whether output has been generated from //C++ for OpenCL// source or from //OpenCL C// source. I have raised DWARF issue

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri updated this revision to Diff 351445. lebedev.ri added a comment. ... and upload the right patch this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 Files: clang/test/CodeGen/thinlto-d

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

lebedev.ri updated this revision to Diff 351444. lebedev.ri added a comment. Herald added a subscriber: zzheng. Update a few more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 Files: clang/test

[PATCH] D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C

stuart created this revision. stuart added reviewers: Anastasia, keith.walker.arm, svenvh, aprantl, SouraVX, shchenz, jzzheng22. Herald added subscribers: ldrumm, yaxunl. stuart requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Objective-C lets you u

[clang] 150f7ce - Referencing a static function defined in an opnemp clause, is

Author: Zahira Ammarguellat Date: 2021-06-11T06:56:01-07:00 New Revision: 150f7cedfb2e072804f4a0887d14c97a7fe3f374 URL: https://github.com/llvm/llvm-project/commit/150f7cedfb2e072804f4a0887d14c97a7fe3f374 DIFF: https://github.com/llvm/llvm-project/commit/150f7cedfb2e072804f4a0887d14c97a7fe3f374

[PATCH] D104112: [clang-tidy] cppcoreguidelines-avoid-init-default-constructors: a new check

Eugene.Zelenko added a comment. What about bit filed members - their initialization is supported only in C++20. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104112/new/ https://reviews.llvm.org/D104112

[PATCH] D104112: [clang-tidy] cppcoreguidelines-avoid-init-default-constructors: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidInitDefaultConstructorsCheck.h:28 + bool isLanguageVersionSupported(const LangOptions &LangOpts) const override { +return LangOpts.CPlusPlus; + } Shouldn'

[clang] f7bc9db - Fix Wdocumentation missing parameter warnings. NFCI.

Author: Simon Pilgrim Date: 2021-06-11T14:32:35+01:00 New Revision: f7bc9db95aba77157f10b627a4dea32c3174e148 URL: https://github.com/llvm/llvm-project/commit/f7bc9db95aba77157f10b627a4dea32c3174e148 DIFF: https://github.com/llvm/llvm-project/commit/f7bc9db95aba77157f10b627a4dea32c3174e148.diff

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

RKSimon added a comment. In D103888#2811305 , @dblaikie wrote: > Sounds OK. > > I wouldn't mind the places that can use op<< to use that - not sure > preserving the explicit radix argument is super high value. (I think people > would generally assume th

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

bjope added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1449 - // inserting redundancies into the program. This even includes SimplifyCFG. - OptimizePM.addPass(SpeculateAroundPHIsPass()); - lebedev.ri wrote: > nikic wrote: > > As it has been in

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

bjope added a comment. Kind of the same take on this as @thopre . I wrote https://bugs.llvm.org/show_bug.cgi?id=48821 , and proposed https://reviews.llvm.org/D95789 , when I noticed that this pass caused troubles for two reasons: 1. to avoid that others would stumble upon the same problem (get

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx marked an inline comment as done. flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:98-101 auto Matches = match(findAll(declStmt(has(varDecl(equalsNode(&InitializingVar .bi

[PATCH] D104099: [NewPM] Remove SpeculateAroundPHIs pass from pipeline

thopre added a comment. +1 for this change but being a downstream target only I prefer to let someone else approve this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104099/new/ https://reviews.llvm.org/D104099 __

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx updated this revision to Diff 351425. flx marked an inline comment as not done. flx added a comment. Use more efficient method to check for local variable declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103021/new/ https://reviews.ll

[PATCH] D104097: [analyzer] Fix calculating offset for fields with an empty type

jubnzv updated this revision to Diff 351423. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104097/new/ https://reviews.llvm.org/D104097 Files: clang/lib/StaticAnalyzer/Checkers/PaddingChecker.cpp clang/test/Analysis/padding_no_unique_address.cpp Index: clang/test/Analysis/padding_n

[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6aca6032c5b6: [AST] Include the TranslationUnitDecl when traversing with TraversalScope (authored by sammccall). Changed prior to commit: https://

[clang] 6aca603 - [AST] Include the TranslationUnitDecl when traversing with TraversalScope

Author: Sam McCall Date: 2021-06-11T14:29:45+02:00 New Revision: 6aca6032c5b62b5d26999da5f55779a1b08ec6a2 URL: https://github.com/llvm/llvm-project/commit/6aca6032c5b62b5d26999da5f55779a1b08ec6a2 DIFF: https://github.com/llvm/llvm-project/commit/6aca6032c5b62b5d26999da5f55779a1b08ec6a2.diff LO

[PATCH] D104071: [AST] Include the TranslationUnitDecl when traversing with TraversalScope

sammccall added a comment. In D104071#2812870 , @hokein wrote: > Per https://reviews.llvm.org/harbormaster/unit/view/779496/, window test > seems to be failing... Oops, there was a test I forgot to update (failed on all platforms). Fixed. > Thanks! I t

[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61cdaf66fe22: [ADT] Remove APInt/APSInt toString() std::string variants (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D

[clang-tools-extra] 61cdaf6 - [ADT] Remove APInt/APSInt toString() std::string variants

Author: Simon Pilgrim Date: 2021-06-11T13:19:15+01:00 New Revision: 61cdaf66fe22be2b5942ddee4f46a998b4f3ee29 URL: https://github.com/llvm/llvm-project/commit/61cdaf66fe22be2b5942ddee4f46a998b4f3ee29 DIFF: https://github.com/llvm/llvm-project/commit/61cdaf66fe22be2b5942ddee4f46a998b4f3ee29.diff

  1   2   >