On Fri, 29 Apr 2022 12:29:35 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: updated to use lines()
test/lib/j
On Fri, 29 Apr 2022 12:35:59 GMT, Daniel Fuchs wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285452: updated to use lines()
>
> test/lib/jdk/test/lib/util/FileUtils.java line 3
On Fri, 29 Apr 2022 13:02:06 GMT, Weijun Wang wrote:
>> Also calling trim() assumes that white spaces are not significant. This
>> might not be the case in the general case (for instance - think of markdown
>> files were leading spaces are significant).
>
> The comparison is intentionally made
On Fri, 29 Apr 2022 18:28:45 GMT, Weijun Wang wrote:
>> Shouldn't the comparison be better implemented by the caller then, who will
>> know whether spaces are important or not? That's why I had suggested taking
>> a `Predicate` that could be called with each line removed, and the
>> caller cou
On Mon, 2 May 2022 13:01:40 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: Tests updated
LGTM
-
On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote:
>> Method `Class.isAssignableFrom` is often used in form of:
>>
>> if (clazz.isAssignableFrom(obj.getClass())) {
>> Such condition could be simplified to more shorter and performarnt code
>>
>> if (clazz.isInstance(obj)) {
>>
Hi Rafael,
On 09/05/2022 22:43, Rafael Winterhalter wrote:
Hello,
looking at thread dumps, I realized that the HttpClient implementation does
not offer an explicit way to release its threads. Currently, the client:
1. maintains a cached thread pool with a retention size of 60 seconds. If
many
On Tue, 10 May 2022 11:31:16 GMT, Andrey Turbanov wrote:
>> src/java.desktop/share/classes/javax/imageio/spi/ServiceRegistry.java line
>> 230:
>>
>>> 228: List l = new ArrayList<>();
>>> 229: for (Class c : categoryMap.keySet()) {
>>> 230: if (c.isInstance(provider))
On 10/05/2022 14:39, Remi Forax wrote:
This is not a big problem but I have seen peaks with suddenly many, many
threads (in test code) where many HttpClients were created for single use
and I was wondering if it was ever considered to add a method for disposing
the threads explicitly?
You can ch
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
On Fri, 13 May 2022 10:04:36 GMT, Jorn Vernee wrote:
> Address possible lossy conversion warning in `ProgrammableInvoker`.
>
> Testing: `run-test-jdk_foreign`, testing with patch from
> https://github.com/openjdk/jdk/pull/8599 to see if the warning is gone.
src/java.base/share/classes/jdk/inte
On Fri, 13 May 2022 12:06:45 GMT, Jorn Vernee wrote:
>> Address possible lossy conversion warning in `ProgrammableInvoker`.
>>
>> Testing: `run-test-jdk_foreign`, testing with patch from
>> https://github.com/openjdk/jdk/pull/8599 to see if the warning is gone.
>
> Jorn Vernee has updated the p
On Fri, 13 May 2022 14:36:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as s
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Logging/JNDI OK
-
Marked as revi
On Thu, 19 May 2022 13:05:54 GMT, Alan Bateman wrote:
> This is the implementation of JEP 428: Structured Concurrency (Incubator).
>
> This is a non-final API that provides a gentle on-ramp to structure a task as
> a family of concurrent subtasks, and to coordinate the subtasks as a unit.
src/
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
LGTM - but it may be good to have an other reviewer (@mlchung ?)
test/li
On Fri, 6 May 2022 22:05:35 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>> ([Preview](https://cr.openjdk.java.net/~liach/8178355/IdentityHashMap.html#remove(java.lang.Objec
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
test/jdk/com/
On Wed, 1 Jun 2022 15:41:57 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
Marked as revi
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Changes to `net` and `http` look good.
-
Marked as reviewed by dfuchs (Reviewe
On Thu, 2 Jun 2022 13:59:50 GMT, Сергей Цыпанов wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments, eagerly convert sooner in tryFinally
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles
On Sun, 29 May 2022 20:22:55 GMT, Andrey Turbanov wrote:
> In [JDK-8273098](https://bugs.openjdk.java.net/browse/JDK-8273098) I missed
> one place, where Vector could be replaced with ArrayList.
> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
> use `ArrayList` if
On Fri, 10 Jun 2022 12:16:17 GMT, Matthias Baesken wrote:
> When trying to construct an LdapURL object with a bad input string (in this
> example the _ in ad_jbs is causing issues), and not using
> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
> into the exceptio
On Tue, 14 Jun 2022 12:18:52 GMT, Matthias Baesken wrote:
>> When trying to construct an LdapURL object with a bad input string (in this
>> example the _ in ad_jbs is causing issues), and not using
>> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we
>> run into the exce
Changeset: d8b6af0f01f6
Author:dfuchs
Date: 2008-03-03 12:29 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d8b6af0f01f6
6651382: The Java JVM SNMP provider reports incorrect stats when asked for
multiple OIDs
Summary: The JvmMemPoolEntryImpl must use the row index when cach
Changeset: b64e68bf6b0b
Author:dfuchs
Date: 2008-05-29 15:33 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b64e68bf6b0b
6673853: LegacyIntrospectorTest is testing an old deprecated com.sun API not
present in OpenJDK.
Summary: Removed test from open test suite - the correspo
Changeset: 6ca4564520e7
Author:dfuchs
Date: 2008-05-30 14:35 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6ca4564520e7
6592586: RequiredModelMBean prints a WARNING message when calling
getAttributes() for a non-existing attr
Summary: Switched traces to FINER - except when
Changeset: 8c667d55b79e
Author:dfuchs
Date: 2008-07-29 19:21 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c667d55b79e
6402254: Revisit ModelMBean DescriptorSupport implementation of equals and
hashCode.
Reviewed-by: emcmanus
! src/share/classes/com/sun/jmx/mbeanserver/Ut
Changeset: 914370f03119
Author:dfuchs
Date: 2008-07-31 12:41 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/914370f03119
6730926: Document that create/registerMBean can throw RuntimeMBeanException
from postRegister
Reviewed-by: emcmanus
! src/share/classes/com/sun/jmx/inter
Changeset: 7622f1de1486
Author:dfuchs
Date: 2008-07-31 14:20 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7622f1de1486
6689505: Improve MBeanServerNotification.toString
Reviewed-by: emcmanus
! src/share/classes/javax/management/MBeanServerNotification.java
+ test/javax/man
Changeset: 98caad5c563c
Author:dfuchs
Date: 2008-07-31 17:38 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98caad5c563c
6616825: JMX query returns no value in 1.0 compatibility mode - deserialization
bug in readObject()
Reviewed-by: emcmanus
! src/share/classes/javax/manag
Changeset: e0dc076d99b8
Author:dfuchs
Date: 2008-08-01 11:41 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0dc076d99b8
6732192: CORE_PKGS.gmk: need to declare javax.management.event in the CORE_PKGS
variable
Reviewed-by: emcmanus
! make/docs/CORE_PKGS.gmk
Changeset: 233f8854d8b4
Author:dfuchs
Date: 2008-08-08 14:24 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/233f8854d8b4
6733294: MBeans tab - UI issues with writable attributes
Reviewed-by: emcmanus
! make/netbeans/jconsole/build.properties
! make/netbeans/jconsole/build.xm
Changeset: 9145ff046bb4
Author:dfuchs
Date: 2008-09-04 14:46 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9145ff046bb4
5072476: RFE: support cascaded (federated) MBean Servers
6299231: Add support for named MBean Servers
Summary: New javax.management.namespace package.
Revi
Changeset: 5778303e2e14
Author:dfuchs
Date: 2008-09-09 17:01 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5778303e2e14
6745832: jmx namespaces: Some refactoring/commenting would improve code
readability.
Reviewed-by: emcmanus
! src/share/classes/com/sun/jmx/interceptor/De
Changeset: 3e7b9a0f3a6f
Author:dfuchs
Date: 2008-09-10 16:27 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e7b9a0f3a6f
6746754: jmx namespace: test for leading separator missing
6669137: RFE: InstanceNotFoundException should have a constructor that takes an
ObjectName
6746
Changeset: 6a49dd6635ba
Author:dfuchs
Date: 2008-09-12 17:58 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a49dd6635ba
6747899: jmx namespaces: hooks for permission checks should be defined in
HandlerInterceptor
Reviewed-by: emcmanus
! src/share/classes/com/sun/jmx/namesp
Changeset: 09a7e38337e9
Author:dfuchs
Date: 2008-09-12 19:06 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/09a7e38337e9
6747983: jmx namespace: unspecified self-link detection logic
Reviewed-by: emcmanus
! src/share/classes/com/sun/jmx/namespace/NamespaceInterceptor.java
!
Changeset: 044bfa235270
Author:dfuchs
Date: 2008-09-17 13:40 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/044bfa235270
6748745: JConsole: plotters don't resize well when the window is resized
Summary: part of the fix was contributed by jfdenise
Reviewed-by: jfdenise
! src/
Changeset: 6a76dcaf15e3
Author:dfuchs
Date: 2008-10-09 14:10 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a76dcaf15e3
6332953: JMX agent should bind to loopback address when starting the local
connector server
Reviewed-by: emcmanus
! src/share/classes/sun/management/jmxr
Changeset: f50f9b0d18a8
Author:dfuchs
Date: 2008-10-10 10:58 +0200
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f50f9b0d18a8
6758165: ConnectorBootstrap.DefaultValues should have a default value for
USE_LOCAL_ONLY
Reviewed-by: alanb, emcmanus
! src/share/classes/sun/management/
Changeset: 67718d2bd49c
Author:dfuchs
Date: 2008-11-14 17:22 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/67718d2bd49c
6683213: CounterMonitor's derived Gauge badly initialized
Reviewed-by: emcmanus
! src/share/classes/javax/management/monitor/CounterMonitor.java
! src/sha
Changeset: 97e2e87aa035
Author:dfuchs
Date: 2008-11-21 18:18 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/97e2e87aa035
6774170: LocalRMIServerSocketFactory should protect against
ServerSocket.accept().getInetAddress() being null
Reviewed-by: emcmanus, jfdenise
! src/share
Changeset: a99a2d2f3249
Author:dfuchs
Date: 2008-12-04 17:58 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a99a2d2f3249
6319823: new mbean register/unregister notification for groups of mbeans
6779698: Merge error caused duplicate example code in MBeanServerNotification
Revi
Changeset: 61e73bc43e72
Author:dfuchs
Date: 2008-12-09 20:20 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/61e73bc43e72
6768935: Clarify the behaviour of ObjectName pattern matching with regards to
namespaces
Reviewed-by: emcmanus
! src/share/classes/com/sun/jmx/intercepto
Changeset: fa87de6b1ac3
Author:dfuchs
Date: 2009-03-12 15:36 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa87de6b1ac3
6661448: Make the SNMP agent optional when OPENJDK=true and
IMPORT_BINARY_PLUGS=false
Reviewed-by: mchung, ohair
! make/com/sun/jmx/Makefile
! make/java/
Hi,
Please find below a fix for
https://bugs.openjdk.java.net/browse/JDK-8080933
8080933: LogManager.demandSystemLogger should accept a
'caller' argument.
http://cr.openjdk.java.net/~dfuchs/webrev_8080933/webrev.00
LogManager.demandLogger accepts a caller argument which is later used
Hi,
Please find below a patch for
8129572 - Cleanup usage of getResourceAsStream in jaxp
https://bugs.openjdk.java.net/browse/JDK-8129572
http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/
This removes a bunch of unused getResourceAsStream methods
and sanitizes the few that remain.
On 23/06/15 17:14, Claes Redestad wrote:
"priveleged" typo in:
http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/jaxp/src/java.xml/share/classes/com/sun/org/apache/xpath/internal/functions/FuncSystemProperty.java.udiff.html
The line isn't touched by the patch, but might be a nice driv
On 23/06/15 16:44, Alan Bateman wrote:
On 23/06/2015 15:16, Daniel Fuchs wrote:
Hi,
Please find below a patch for
8129572 - Cleanup usage of getResourceAsStream in jaxp
https://bugs.openjdk.java.net/browse/JDK-8129572
http://cr.openjdk.java.net/~dfuchs/webrev_8129572/webrev.00/
This removes
Hi Frank,
The proposed changes look good to me.
best regards,
-- daniel
On 24/06/15 09:58, Frank Yuan wrote:
Hi,
Would you like to have a review for bug
https://bugs.openjdk.java.net/browse/JDK-8080266?
This bug is caused by jigsaw change, the context class loader can't load
internal resour
Hi Frank,
I could push it for you.
-- daniel
On 6/25/15 5:05 AM, Frank Yuan wrote:
So, would you like to push the code for me?
Best Regards
Frank
-Original Message-
From: huizhe wang [mailto:huizhe.w...@oracle.com]
Sent: Thursday, June 25, 2015 12:57 AM
To: Daniel Fuchs
Cc: Frank
Hi,
Please find below a cleanup patch for jaxp:
https://bugs.openjdk.java.net/browse/JDK-8129880
8129880 - Cleanup usage of getResource in jaxp
Class.getResource(classFile) was used for printing the class
location for debuging purposes. CodeSource.getLocation() is a better
fit for that.
http:/
Hi,
It was brought to my attention that CodeSource.getLocation()
might return null. The javadoc is not very clear on the subject,
leading me to believe it could not.
Here is a trivial change (with some trivial additional cleanup)
that adds guards against null before calling
getLocation().toStrin
45 PM, Daniel Fuchs wrote:
Hi,
It was brought to my attention that CodeSource.getLocation()
might return null. The javadoc is not very clear on the subject,
leading me to believe it could not.
Here is a trivial change (with some trivial additional cleanup)
that adds guards against null before ca
On 29/06/15 10:06, Paul Sandoz wrote:
That's odd i would of expected it to work. Here's Joe's patch to changes in the
JDK:
http://cr.openjdk.java.net/~darcy/8078467.0/jdk.patch
(Search for "new PrivilegedAction" in the patch.)
e.g. an expression in java.io.ObjectInputStream:
http://hg.ope
Thanks Paul.
I have another cleaner patch coming - I'll include those
changes as well.
-- daniel
On 29/06/15 11:13, Paul Sandoz wrote:
On Jun 29, 2015, at 10:35 AM, Daniel Fuchs wrote:
On 29/06/15 10:06, Paul Sandoz wrote:
That's odd i would of expected it to work. Here's
On 29/06/15 11:13, Paul Sandoz wrote:
NetBeans didn't suggest replacing with diamonds either - which it
>usually does - but then maybe it was busy scanning classpath;-)
>
This is a relatively new 9-based language feature, so i don't expect the IDEs
have caught up yet (IntelliJ 15 EAP has not fo
Hi,
Please find below a patch that cleans up some of the
reflection usage in jaxp.
https://bugs.openjdk.java.net/browse/JDK-8130051
http://cr.openjdk.java.net/~dfuchs/webrev_8130051/webrev.00/
This is not a deep cleanup - it is just a first pass...
There may be some opportunity to get rid of so
On 29/06/15 20:06, huizhe wang wrote:
Maybe it's better to live with PrivilegedAction and
PrivilegedAction instead? I'm using NetBeans 8.0.2, it looks
like it doesn't support "source level" beyond JDK 1.8. It's a bit
bothersome to have "red flags". Plus, we won't be able to build with JDK
8. Wh
review!
best regards,
-- daniel
Thanks,
Joe
On 6/29/2015 4:17 AM, Daniel Fuchs wrote:
Hi,
Please find below a patch that cleans up some of the
reflection usage in jaxp.
https://bugs.openjdk.java.net/browse/JDK-8130051
http://cr.openjdk.java.net/~dfuchs/webrev_8130051/webrev.00/
This is not
Hi Joe, Paul,
On 30/06/15 10:47, Daniel Fuchs wrote:
OK - I will replace the offending diamonds before pushing.
On 30/06/15 10:49, Paul Sandoz wrote:> I am beseech you not to do that!
>
> Unless there is a really strong reason why JAXP 8 code should be the
> same as JAXP 9 code
Hi,
Please find below a trivial patch that removes
com.sun.org.apache.xalan.internal.xsltc.cmdline
This package is not used in the JDK.
http://cr.openjdk.java.net/~dfuchs/webrev_8130238/webrev.00/
Jaxp tests passed locally (jaxp/test, jdk/test/javax/xml/jaxp)
JCK for XML APIs also passed.
More
Please find below a changeset to address:
8130649: java/util/logging/LoggingDeadlock2.java times out
https://bugs.openjdk.java.net/browse/JDK-8130649
The proposed changeset doesn't fix the issue but instruments
the test a bit more so that we can get a clue of what is
happening.
http://cr.openjd
Or Stream.of("1", "2", "3").collect(Collectors.toList()); :-)
-- daniel
On 09/07/15 19:46, Louis Wasserman wrote:
Pavel, what you can do there is new ArrayList<>(Arrays.asList("1", "2",
"3", "4", "5"));
On Thu, Jul 9, 2015 at 10:40 AM Pavel Rappo wrote:
Not quite. You don't have the abilit
On 13/07/15 14:53, FELIX YANG wrote:
Hi Daniel,
please help to review the change for 8129833.
Issue:https://bugs.openjdk.java.net/browse/JDK-8129833
Patch:http://cr.openjdk.java.net/~fyuan/felix/8129833/
The patch add a new class to try rmic with. It covers a problem of
locating t
On 13/07/15 11:19, Paul Sandoz wrote:
Hi
Stefan, thanks.
See below for a patch to the documentation of all abstract spliterators.
Looks good to me Paul.
best regards,
-- daniel
Paul.
diff -r a3175de2e354 src/java.base/share/classes/java/util/Spliterators.java
--- a/src/java.base/share/c
On 16/07/15 12:00, Daniel Fuchs wrote:
On 13/07/15 11:19, Paul Sandoz wrote:
Hi
Stefan, thanks.
See below for a patch to the documentation of all abstract spliterators.
Looks good to me Paul.
Sorry - re reading my mail I see that you have an extreneous '}'
at the three last pla
Hi Joe,
Looks good to me!
nit: the two statics don't agree on style:
'private static final' vs 'private final static'
best regards,
-- daniel
On 20/07/15 23:47, huizhe wang wrote:
Please review a change that removes unnecessary class loading.
http://cr.openjdk.java.net/~joehw/jdk9/813190
Hi,
Please find below a patch that fixes
8132256: jaxp: Investigate removal of
com/sun/org/apache/bcel/internal/util/ClassPath.java
https://bugs.openjdk.java.net/browse/JDK-8132256
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8132256/webrev.00
The class com.sun.org.appache
Hi,
Please find below a fix for yet another cleanup for jaxp:
8130059: jaxp: Investigate removal of
com/sun/org/apache/xalan/internal/xslt/EnvironmentCheck.java
https://bugs.openjdk.java.net/browse/JDK-8130059
http://cr.openjdk.java.net/~dfuchs/webrev_8130059/webrev.00/
EnvironmentChe
On 28/07/15 19:20, huizhe wang wrote:
Hi Daniel,
On 7/28/2015 8:22 AM, Daniel Fuchs wrote:
Hi,
Please find below a fix for yet another cleanup for jaxp:
Thanks for yet another cleanup! And, there is a lot more to come :-)
8130059: jaxp: Investigate removal of
com/sun/org/apache/xalan
Hi Kim,
I agree with your proposed fix.
I see that you have added a comment for future maintainers.
Thanks for that - as the implication of the ordering between
the two volatile writes is not immediately perceptible to
the casual reader.
You have good eyes - I hadn't spotted the race condition,
Hi,
Please find below a patch that removes a bunch of unused files
in jdk9/dev/jaxp:
https://bugs.openjdk.java.net/browse/JDK-8130058
8130058: jaxp: Investigate removal of
com/sun/org/apache/xalan/internal/xslt/Process.java
http://cr.openjdk.java.net/~dfuchs/webrev_8130058/webrev.00/
Hi Peter,
I'm glad you're looking at this too! We can't have too many eyes :-)
On 30/07/15 10:38, Peter Levart wrote:
Suppose we have a Reference 'r' and it's associated ReferenceQueue 'q'.
Currently it can happen that the following evaluates to true, which is
surprising:
q.poll() == null && r
On 30/07/15 12:20, Peter Levart wrote:
On 07/30/2015 11:12 AM, Daniel Fuchs wrote:
Hi Peter,
I'm glad you're looking at this too! We can't have too many eyes :-)
On 30/07/15 10:38, Peter Levart wrote:
Suppose we have a Reference 'r' and it's associated Refere
On 30/07/15 13:37, Peter Levart wrote:
poll() returning null by itself is not surprising, but if 'r' appears to
be "enqueued" before and after the fact, this is surprising.
Agreed - not disputing this.
The question for me is whether this should be fixed in the same
changeset - or whether we s
will use its own dummy ErrorHandler
if it can't managed to instantiate the internal class.
This way - we can keep the test :-)
best regards,
-- daniel
On 29/07/15 17:02, Daniel Fuchs wrote:
Hi,
Please find below a patch that removes a bunch of unused files
in jdk9/dev/jaxp:
On 30/07/15 17:55, huizhe wang wrote:
Hi Daniel,
On 7/30/2015 6:38 AM, Daniel Fuchs wrote:
Hi,
Please find below an updated webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8130058/webrev.01/
Looks good to me. The only nit is it seems createDefaultErrorHandler
method is a dup of
On 30/07/15 18:16, huizhe wang wrote:
On 7/30/2015 9:08 AM, Daniel Fuchs wrote:
On 30/07/15 17:55, huizhe wang wrote:
Hi Daniel,
On 7/30/2015 6:38 AM, Daniel Fuchs wrote:
Hi,
Please find below an updated webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8130058/webrev.01/
Looks good to
I vote for 1.
:-)
cheers,
-- daniel
On 7/30/15 9:54 PM, Kim Barrett wrote:
On Jul 30, 2015, at 8:09 AM, David Holmes wrote:
On 30/07/2015 9:57 PM, Peter Levart wrote:
'r' has been enqueued.
Thread-1:
r.isEnqueued() &&
q.poll() == null &&
r.isEnqueued()
Thread-2:
q.poll();
Sequence of
On 31/07/15 00:56, Kim Barrett wrote:
On Jul 30, 2015, at 5:33 PM, David Holmes wrote:
So I think I can either:
1. Go ahead with my change + Peter's change.
2. Give this back to core-libs while I step carefully away :-)
I *think* option (1) is at least an improvement. But I completely
mis
Hi,
Please find below a fix for:
https://bugs.openjdk.java.net/browse/JDK-8132550
8132550: java/util/logging/LoggingDeadlock2.java times out
I was able to reproduce the deadlock consistently by inserting
some Thread.sleep() statements at the critical places.
The webrev still shows that (as comm
On 03/08/15 11:31, Alexander Stepanov wrote:
Hello,
Could you please review the following fix:
http://cr.openjdk.java.net/~avstepan/8132468/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8132468
Just some cleanup for docs (replacing obsolete "").
Thanks,
Alexander
Hi Alexander,
mos
Hi Alexander,
I had a look at
http://cr.openjdk.java.net/~avstepan/8132877/webrev.01/jdk.patch, and
there's nothing that caught my eye.
However - it would be good if you could generate a specdiff so that
we could verify that no mistake has crept in.
best regards,
-- daniel
On 03/08/15 17:3
Hi Alexander,
src/java.base/share/classes/java/io/File.java
1.
- *
- * new File( f.{@link #toURI()
toURI}()).equals( f.{@link #getAbsoluteFile()
getAbsoluteFile}())
- *
+ *
+ * {@code new File(f.}{@link
+ * #toURI() toURI}{@code ()).equals(f.}{@link
+ * #getAbs
webrev (please update the web-page):
http://cr.openjdk.java.net/~avstepan/8132877/webrev.01/index.html
sdiff out (0 changes at the moment):
http://cr.openjdk.java.net/~avstepan/8132877/specdiff.01/overview-summary.html
Looks good for me then.
best regards,
-- daniel
Regards,
Alexander
On
'f' should be restored. In the case of File.toURI() it appears that
the resulting code is now malformed, so there's clearly an error here.
You and Daniel Fuchs had an exchange about this a bit earlier. I
suspect the reason for the that appears between the opening
parenthesis an
Hi Alexander,
Cursory inspection of the patch file has not revealed anything wrong.
Specdiff looks OK, so that's good for me.
best regards,
-- daniel
On 05/08/15 19:37, Alexander Stepanov wrote:
> javax.management - one (expected) change in TabularDataSupport:
(full package diff:
http://cr.o
Hi Roger,
Not a math expert, but this looks good to me :-)
best regards,
-- daniel
On 06/08/15 17:33, Roger Riggs wrote:
Please review a small fix and test for Instant.toEpochMilli
ArithmeticOverflow.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-overflow-8133022/
Issue:
https:
Hi Vyom,
Thanks for taking care of this issue.
This looks good to me as well.
I can sponsor this change for you.
best regards,
-- daniel
On 01/09/15 10:38, Vyom Tewari wrote:
Hi everyone,
Can you please review my changes for below bug.
Bug:
JDK-8064470 : JNI exception pending in
jdk/s
Hi Vyom,
I'm not a net/JNI expert but what you are proposing
looks good to me too. Ivan has already given his assent.
Unless I hear objections - or comments from other reviewers,
I will sponsor this change and push it for you (I'll wait
for Monday).
best regards,
-- daniel
On 02/09/15 15:55,
Hi Vyom,
I will sponsor that and push it for you.
best regards,
-- daniel
On 07/09/15 18:52, Alan Bateman wrote:
On 07/09/2015 14:08, Vyom Tewari wrote:
Hi All,
Please find the latest diff, which contains the latest fix.
http://cr.openjdk.java.net/~dfuchs/vyom/8080402/webrev.02/
I thin
Oh - sorry - I hadn't seen Mark question.
I will wait until those are resolved...
On 07/09/15 19:24, Daniel Fuchs wrote:
Hi Vyom,
I will sponsor that and push it for you.
best regards,
-- daniel
On 07/09/15 18:52, Alan Bateman wrote:
On 07/09/2015 14:08, Vyom Tewari wrote:
H
On 09/09/15 17:54, Mark Sheppard wrote:
Hi Vyom,
yes, I believe the consensus is to proceed with the changes.
OK - I will be pushing them then.
best regards,
-- daniel
regards
Mark
On 09/09/2015 16:23, Vyom Tewari wrote:
Hi Mark,
Is it OK to go ahead with the patch as it is, or you
Hi,
Please find below a candidate fix for:
8033661: readConfiguration does not cleanly reinitialize the
logging system
https://bugs.openjdk.java.net/browse/JDK-8033661
http://cr.openjdk.java.net/~dfuchs/webrev_8033661/webrev.00/
LogManager.readConfiguration() presents a number of flaw
Hi Mandy,
Thanks a lot for the feedback!
On 13/09/15 00:44, Mandy Chung wrote:
On Sep 9, 2015, at 9:55 AM, Daniel Fuchs wrote:
Hi,
Please find below a candidate fix for:
8033661: readConfiguration does not cleanly reinitialize the
logging system
https://bugs.openjdk.java.net
Hi Mandy,
On 13/09/15 00:44, Mandy Chung wrote:
Have you considered keeping the same method name, readConfiguration
with the new remapper parameter? The downside is the difference that
the reset is not invoked. It might not matter because as you add in
@apiNote that the existing readConfigurat
Hi Vyom,
I will sponsor your change and push the fix for you.
I'll sync up with Rob to check that we don't step on each other's toes.
best regards,
-- daniel
On 16/09/15 16:03, Chris Hegarty wrote:
The changes look good to me Vyom.
-Chris.
On 16/09/15 10:08, Vyom Tewari wrote:
Hi All,
Ple
501 - 600 of 1615 matches
Mail list logo
