Re: [Merge] Palo Alto Networks firewall integration to master

2014-02-03 Thread Will Stevens
Sorry, I thought I had responded to you on this, but I just realized I hadn't. I tested all my functionality a couple days ago and everything is working so this issue is resolved. Thanks... On Wed, Jan 15, 2014 at 6:14 PM, Animesh Chaturvedi < animesh.chaturv...@citrix.com> wrote: > Will > > I

RE: [Merge] Palo Alto Networks firewall integration to master

2014-01-15 Thread Animesh Chaturvedi
Will I was doing some housekeeping for release and noticed that the JIRA ticket [5] was unresolved and not tagged for 4.3. I have updated it as resolved and tagged for 4.3. Let me know if this is not correct Animesh -Original Message- From: williamstev...@gmail.com [mailto:williamstev

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Chip Childers
On Thu, Nov 07, 2013 at 06:59:25PM +, Animesh Chaturvedi wrote: > mvn --projects='org.apache.cloudstack:cloudstack' > org.apache.rat:apache-rat-plugin:0.8:check s/0.8/0.10 if you want the latest

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Will Stevens
tils/HttpClientWrapper.java > > > > > > > > > > > > > -Original Message----- > > > > > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] > On > > > > > Behalf Of Will Stevens > > > > > Sent: Wednesday,

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Sheng Yang
> > > > plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java > > > > > > > > > > -Original Message- > > > > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On > > > > Behalf Of Will Stevens &

RE: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Animesh Chaturvedi
013 10:51 AM > To: dev@cloudstack.apache.org > Subject: Re: [Merge] Palo Alto Networks firewall integration to master > > Just so I know, can you explain what it means to 'Fail RAT'? Thx... > > > On Thu, Nov 7, 2013 at 1:46 PM, Sheng Yang wrote: > > > Fixed. > &

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Will Stevens
> > Sent: Wednesday, November 06, 2013 10:15 AM > > > To: dev@cloudstack.apache.org > > > Subject: Re: [Merge] Palo Alto Networks firewall integration to master > > > > > > Great! Thank you Sheng... > > > > > > >

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Sheng Yang
From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On > > Behalf Of Will Stevens > > Sent: Wednesday, November 06, 2013 10:15 AM > > To: dev@cloudstack.apache.org > > Subject: Re: [Merge] Palo Alto Networks firewall integration to master > > > > Great! Thank y

RE: [Merge] Palo Alto Networks firewall integration to master

2013-11-07 Thread Animesh Chaturvedi
AM > To: dev@cloudstack.apache.org > Subject: Re: [Merge] Palo Alto Networks firewall integration to master > > Great! Thank you Sheng... > > > On Wed, Nov 6, 2013 at 1:10 PM, Sheng Yang wrote: > > > Looks good to me. > > > > Applied to MASTER branch. Thanks! >

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-06 Thread Will Stevens
Great! Thank you Sheng... On Wed, Nov 6, 2013 at 1:10 PM, Sheng Yang wrote: > Looks good to me. > > Applied to MASTER branch. Thanks! > > --Sheng > > > On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens > wrote: > > > @Sheng: This should be ready to go now. I built the patch from > tonight's > >

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-06 Thread Sheng Yang
Looks good to me. Applied to MASTER branch. Thanks! --Sheng On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens wrote: > @Sheng: This should be ready to go now. I built the patch from tonight's > master and I included a more detailed commit message as you requested. Let > me know if you have any

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-05 Thread Will Stevens
@Sheng: This should be ready to go now. I built the patch from tonight's master and I included a more detailed commit message as you requested. Let me know if you have any questions/problems... @David: As per this discussion (and a previous one [1]), I have moved this code from being built wit

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-05 Thread Will Stevens
Thanks for that David. You are absolutely correct, this plugin has no dependencies on any 3rd party code at build or runtime. Everything the plugin requires is built into the plugin. I was unclear if its dependance on a 3rd party API and appliance to be functional was relevant. I think you are

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-05 Thread David Nalley
So perhaps a bit of history. nonoss/noredist is for targets that aren't built 'by default' (e.g. you must explicitly turn them on). We do this because the ASF wants the default build to be truly unencumbered and where there are dependencies on non-open source, or non-Apache compatible code, we typ

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-05 Thread Will Stevens
Its dependence on a third party API and appliance, similar to the srx and netscaler. I am not convinced it should be in noredist, but I was following the same model as other similar plugins. Feedback on this would be helpful. Ws On Tuesday, November 5, 2013, David Nalley wrote: > On Mon, Nov 4,

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-04 Thread David Nalley
On Mon, Nov 4, 2013 at 7:32 PM, Will Stevens wrote: > Sheng, I will rebuild the patch for the latest master. The latest master > has depreciated the 'nonoss' flag in favour of 'noredist'. I was building > in nonoss previously. I am guessing I should use the noredist flag now? > Will - what is ca

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-04 Thread Will Stevens
Sheng, I will rebuild the patch for the latest master. The latest master has depreciated the 'nonoss' flag in favour of 'noredist'. I was building in nonoss previously. I am guessing I should use the noredist flag now? Cheers, Will On Monday, November 4, 2013, Sheng Yang wrote: > Sure, I would

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-04 Thread Sheng Yang
Sure, I would be glad to commit it for 4.3 release. --Sheng On Mon, Nov 4, 2013 at 8:19 AM, Chip Childers wrote: > On Mon, Nov 04, 2013 at 10:59:30AM -0500, Will Stevens wrote: > > Well its not in master yet. That is the intent of this thread... > > > > I can definitely do some testing for the

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-04 Thread Chip Childers
On Mon, Nov 04, 2013 at 10:59:30AM -0500, Will Stevens wrote: > Well its not in master yet. That is the intent of this thread... > > I can definitely do some testing for the 4.3 test cycle. > > Will Shoot, I misread Sheng's email. Sorry about that. I thought he said that he "Checked *in*" the

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-04 Thread Will Stevens
Well its not in master yet. That is the intent of this thread... I can definitely do some testing for the 4.3 test cycle. Will On Mon, Nov 4, 2013 at 10:56 AM, Chip Childers wrote: > On Mon, Nov 04, 2013 at 10:49:29AM -0500, Will Stevens wrote: > > Anything I can do to help get this patch int

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-04 Thread Will Stevens
Anything I can do to help get this patch into 4.3.0? Thanks, Will On Fri, Nov 1, 2013 at 2:47 PM, Sheng Yang wrote: > Nice work Will! > > I've checked the code, it included the UI part and unit test as well. > Really impressed! > > Just one comment: you can git-format-patch to generate the pa

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-04 Thread Chip Childers
On Mon, Nov 04, 2013 at 10:49:29AM -0500, Will Stevens wrote: > Anything I can do to help get this patch into 4.3.0? > > Thanks, > > Will If it's in master, it'll be in 4.3... so help by testing during the 4.3 test cycle! -chip

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-01 Thread Will Stevens
Great, thank you Sheng... I have updated the diff for the patch review with a new version which was created using the 'git format-patch' format. A note that may help others. I found this very helpful when squashing my branch of changes to a patch for master: http://stackoverflow.com/questions/61

Re: [Merge] Palo Alto Networks firewall integration to master

2013-11-01 Thread Sheng Yang
Nice work Will! I've checked the code, it included the UI part and unit test as well. Really impressed! Just one comment: you can git-format-patch to generate the patch. It would includes author and description information automatically, which is easier for applying. +1! --Sheng On Thu, Oct