Re: [VOTE] Apache Hive 2.3.9 Release Candidate 0

+1. Thank Chao for doing this. I performed the following actions: 1. Downloaded the release candidate artifacts and verified the signatures and checksums. 2. Built from the source. 3. Initialized schema using schematool and launched hive metastore service on top of it. 4. Used Hive client to conne

Re: [ANNOUNCE] New Hive Committer - Eugene Koifman

Congratulations, Eugene! --Xuefu On Fri, Sep 12, 2014 at 4:08 PM, Gunther Hagleitner < ghagleit...@hortonworks.com> wrote: > Congrats Eugene! > > Cheers, > Gunther. > > On Fri, Sep 12, 2014 at 3:47 PM, Prasanth Jayachandran < > pjayachand...@hortonworks.com> wrote: > >> Congrats Eugene! >> >> T

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

e a boolean. Callers will only need to pass a boolean. Also, both methods are new and private. I'm not sure if I undertand the complexity of the change. - Xuefu Zhang On Sept. 12, 2014, 9:51 p.m., david seraf wrote: > > --- >

Re: Review Request 25619: HIVE-8054:Disable hive.optimize.union.remove when hive.execution.engine=spark [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25619/#review53284 --- Ship it! Ship It! - Xuefu Zhang On Sept. 14, 2014, 6:38 a.m

Re: Review Request 25178: HIVE-7100 Add DROP TABLE PURGE

), we just need to get a boolean value (ifPurge) from the context. The signature of the API doesn't need to change. - Xuefu Zhang On Sept. 12, 2014, 9:51 p.m., david seraf wrote: > > --- > This is an automatically gen

Re: Review Request 25595: HIVE-8083: Authorization DDLs should not enforce hive identifier syntax for user or group namesname that

tps://reviews.apache.org/r/25595/#comment93330> Is this supposed to be just identifier itself? - Xuefu Zhang On Sept. 16, 2014, 6:29 p.m., Prasad Mujumdar wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 25720: HIVE-8141:Refactor the GraphTran code by moving union handling logic to UnionTran [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25720/#review53676 --- Ship it! Ship It! - Xuefu Zhang On Sept. 16, 2014, 11:56 p.m

Re: Edit access to the Hive Wiki

Done! On Fri, Sep 19, 2014 at 8:55 AM, Pavan Lanka wrote: > Hi, > > I have registered myself as pavibhai on the https://cwiki.apache.org and > would like change privilege so that I can contribute to the content. > > > Regards, > Pavan >

Re: Review Request 25394: HIVE-7503: Support Hive's multi-table insert query with Spark [Spark Branch]

ava/org/apache/hadoop/hive/ql/parse/spark/SparkTableScanProcessor.java <https://reviews.apache.org/r/25394/#comment93847> Here we are mapping the children of lca to lca itself. Why is this necessary, as you can find the chidren of lca later without the map. Cannot we just store lca here

Re: Review Request 25394: HIVE-7503: Support Hive's multi-table insert query with Spark [Spark Branch]

t;https://reviews.apache.org/r/25394/#comment93869> Okay. Fair enough. - Xuefu Zhang On Sept. 18, 2014, 6:38 p.m., Chao Sun wrote: > > --- > This is an automatically generated

Re: Review Request 25394: HIVE-7503: Support Hive's multi-table insert query with Spark [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25394/#review54056 --- Ship it! Ship It! - Xuefu Zhang On Sept. 20, 2014, 12:04 a.m

Re: Review Request 26007: HIVE-8249 - Refactoring SparkPlan and SparkPlanGenerator [Spark Branch]

<https://reviews.apache.org/r/26007/#comment94628> Nit: could we rename it to IdentityTran, as this has nothing close to union any more? - Xuefu Zhang On Sept. 24, 2014, 10:50 p.m., Chao Sun wrote: > > --- > This is a

Re: Restarting hadoop-1 builds

Yes, I think we should have randomness (or some rotation) in picking Hadoop-1 vs Hadoop-2. This will not eliminate the problem, but contain it at a tolerable minimum. Otherwise, this sort of build failure will keep coming. Thanks, Xuefu On Thu, Sep 25, 2014 at 7:17 PM, Navis류승우 wrote: > Hi, >

Re: Review Request 25497: HIVE-7627, FSStatsPublisher does fit into Spark multi-thread task mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25497/#review54777 --- Ship it! Ship It! - Xuefu Zhang On Sept. 28, 2014, 9:50 a.m

Re: Review Request 25497: HIVE-7627, FSStatsPublisher does fit into Spark multi-thread task mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25497/#review54837 --- Ship it! Ship It! - Xuefu Zhang On Sept. 28, 2014, 9:50 a.m

Re: Review Request 26112: HIVE-8130 : Support Date in Avro

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26112/#review54869 --- Ship it! Ship It! - Xuefu Zhang On Sept. 27, 2014, 1:38 a.m

Re: Review Request 26120: HIVE-8278 - Restoring a graph representation of SparkPlan [Spark Branch]

l/exec/spark/SparkPlan.java <https://reviews.apache.org/r/26120/#comment95252> Can we make this private? Also, some comments would be good (similar to getAllWorks() in SparkWork). - Xuefu Zhang On Sept. 29, 2014, 8:16 p.

Re: Review Request 26120: HIVE-8278 - Restoring a graph representation of SparkPlan [Spark Branch]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26120/#review54941 --- Ship it! Ship It! - Xuefu Zhang On Sept. 30, 2014, 12:06 a.m

Hive User Group Meeting, Oct. 15th, New York

* Hive on Spark, by Xuefu Zhang * Cost-Based Optimization, Optiq, and Materialized Views, by Julian Hyde * Updates on Hive Thrift Protocol, by George Chow * What's new in Apache Sentry, by Prasad Mujumdar * Insert, update, and delete in Hive, by Owen O'Malley * Overcoming data wareh

Re: Review Request 26296: HIVE-8331 - HIVE-8303 followup, investigate result diff [Spark Branch]

tps://reviews.apache.org/r/26296/#comment95675> Had discussion with Tez folks and were told that thread-local for this map will not work for Tez. Have you found the root cause? - Xuefu Zhang On Oct. 2, 2014, 11:43 p.m., Chao Sun

Re: [VOTE] officially stop supporting hadoop 0.20.x in hive 0.14 ?

I'd like to understand the motivation a bit. I'm okay to drop the support, but given a release that's pending, sudden move seems rather rushy, given user no time to react. It might be more considerate to communicate it at the beginning of the release cycle rather than a few days before the release.

Re: [VOTE] officially stop supporting hadoop 0.20.x in hive 0.14 ?

hs or so of notice. I don't think that matters a lot. > As I mentioned earlier, I really doubt if people on hadoop 0.20 (if > any) are going to upgrade to newer versions of hive. The added dev > burden is unwarranted. > > > On Tue, Oct 7, 2014 at 6:54 PM, Xuefu Zhang wrote:

Re: Review Request 25495: HIVE-7776, enable sample10.q

/HiveMapFunction.java <https://reviews.apache.org/r/25495/#comment96513> Can we combine this line with the previous one? ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunction.java <https://reviews.apache.org/r/25495/#comment96517> Same as above. - Xuefu Zhang On Oct. 10, 20

Re: Review Request 26569: HIVE-8276 - Separate shuffle from ReduceTran and so create ShuffleTran [Spark Branch]

ore natural? - Xuefu Zhang On Oct. 11, 2014, 12:31 a.m., Chao Sun wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Hive User Group Meeting, Oct. 15th, New York

36 AM, Xuefu Zhang wrote: > Dear Hive users/developers, > > The next Hive user group meeting is around the corner. It will be held on > Oct. 15th, from 6:30pm to 9:00pm at 1500 Broadway, 6th floor, New York, NY > 10036. This will be a great opportunity for vast users and developers

Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList

container are protected resources and they need to be in the synchnized block. ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestHiveKVResultCache.java <https://reviews.apache.org/r/26661/#comment96784> Same here. - Xuefu Zhang On Oct. 13, 2014

Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList

/spark/HiveKVResultCache.java <https://reviews.apache.org/r/26661/#comment96842> Yeah. Let's make this thread safe for read also. Otherwise, it's error prone and hard to understand. We also need to make clear() thread safe, probably. - Xuefu Zhang On Oct. 13, 2014, 9:33 p

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

tps://reviews.apache.org/r/26706/#comment97036> Let's not to use * in imports. - Xuefu Zhang On Oct. 14, 2014, 9:17 p.m., Chao Sun wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 26661: HIVE-7873 Re-enable lazy HiveBaseFunctionResultList

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26661/#review56698 --- Ship it! Ship It! - Xuefu Zhang On Oct. 15, 2014, 12:55 p.m

Update: Hive user group meeting tonight

Hi all, Quick update, you should be able to attend as long as you have an ID with you. (Sorry about the confusion.) For those willing to dial in, the info is on the meetup page. http://www.meetup.com/Hive-User-Group-Meeting/events/202007872/ Regards, Xuefu

Appreciation: Hive user group meeting NY

Hi all, About an half an hour ago, the Hive user group meetup NY was concluded. It had 7 talks and a lot of content was covered. Representing Hive community, I'd like to thank those who gave talks or participated in the meetup. Especially, many thanks to about.com for hosting event. I look forwar

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

6/#comment97859> Could we put this test as spark only, as splitting doesn't apply mr or tez? I think we have a dir for spark only tests. ql/src/test/queries/clientpositive/spark_multi_insert_split_work.q <https://reviews.apache.org/r/26706/#comment97860> Nit: t

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

> On Oct. 19, 2014, 12:15 a.m., Xuefu Zhang wrote: > > ql/src/test/queries/clientpositive/spark_multi_insert_split_work.q, line 1 > > <https://reviews.apache.org/r/26706/diff/4/?file=724864#file724864line1> > > > > Could we put this test as spark only,

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

ents here? I guess the test case is special in that some inserts are map only while others invovles a shuffle. - Xuefu Zhang On Oct. 20, 2014, 5:38 p.m., Chao Sun wrote: > > --- > This is an automatically generated e

Re: Review Request 26706: HIVE-8436 - Modify SparkWork to split works with multiple child works [Spark Branch]

tps://reviews.apache.org/r/26706/#comment98143> We might need to change this as well. - Xuefu Zhang On Oct. 20, 2014, 9:10 p.m., Chao Sun wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 26867: HIVE-7709 Create SparkReporter[Spark Branch]

/SparkRecordHandler.java <https://reviews.apache.org/r/26867/#comment98322> I'm wondering why we don't need this line. It seems that counter stats publisher (CounterStatsPublisher class) is using this to publish statistics. - Xuefu Zhang On Oct. 20, 2014, 9:11 a.m., che

Re: Is "How to Contribute to Apache Hive" up-to-date?

Hi Paul, Please refer to the following link to build Hive. https://cwiki.apache.org/confluence/display/Hive/HiveDeveloperFAQ Thanks, Xuefu On Wed, Nov 13, 2013 at 12:22 PM, Paul Rubio wrote: > From the document at "How to Contribute to Apache Hive" Contribute to Apache Hive>

Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF implementations

/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6 Diff: https://reviews.apache.org/r/15113/diff/ Testing --- Full set of unit tests is to be run. Old testcases are also migrated. Thanks, Xuefu

Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF implementations

Got it. Thanks for pointing this out. - Xuefu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15113/#review28904 --- On Nov. 14, 2013, 8:44 p.m., Xuefu

Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF implementations

/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6 Diff: https://reviews.apache.org/r/15113/diff/ Testing --- Full set of unit tests is to be run. Old testcases are also migrated. Thanks, Xuefu

Re: Review Request 15497: HIVE-5741 - Hcatalog needs to be added to the binary tar

the version of a dependent in a child pom is unnecessary if the dependent is specified in the parent dependent management. Specifying them in both places might create inconsistency in a long run. - Xuefu Zhang On Nov. 15, 2013, 5:24 p.m., Brock Noland wrote

Re: Review Request 15497: HIVE-5741 - Hcatalog needs to be added to the binary tar

> On Nov. 15, 2013, 5:25 p.m., Xuefu Zhang wrote: > > Patch looks good to me. One thing to consider is that specifying the > > version of a dependent in a child pom is unnecessary if the dependent is > > specified in the parent dependent management. Specifying them in b

Review Request 15588: HIVE-5565: Limit Hive decimal type maximum precision and scale to 38

accordingly. Manual testing passsed. Thanks, Xuefu Zhang

Re: Review Request 15607: HIVE-5825 Case statement type checking too restrictive for parameterized types

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15607/#review29006 --- Ship it! Ship It! - Xuefu Zhang On Nov. 16, 2013, 3:29 a.m

Re: Review Request 15588: HIVE-5565: Limit Hive decimal type maximum precision and scale to 38

/ Testing --- Unit tests are modified accordingly. Manual testing passsed. Thanks, Xuefu Zhang

Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF implementations

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15113/#review28976 --- On Nov. 14, 2013, 10:11 p.m., Xuefu Zhang wrote: > > --

Re: [ANNOUNCE] New Hive Committer and PMC Member - Lefty Leverenz

Congratulations, Lefty! --Xuefu On Mon, Nov 18, 2013 at 3:52 PM, Vikram Dixit wrote: > Congrats Lefty! This is awesome. > > > On Sun, Nov 17, 2013 at 7:53 AM, Jarek Jarcec Cecho >wrote: > > > Congratulations Lefty! > > > > Jarcec > > > > On Sat, Nov 16, 2013 at 09:20:00PM -0800, Carl Steinbach

Re: Review Request 15666: HIVE-5847 DatabaseMetadata.getColumns() doesn't show correct column size for char/varchar/decimal

nsider for numeric types the sign and decimal point itself? In other words, is this same as display size? - Xuefu Zhang On Nov. 19, 2013, 3:28 a.m., Jason Dere wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 15561: HIVE-5771 Constant propagation optimizer for Hive

ment56247> What is this fix for? - Xuefu Zhang On Nov. 17, 2013, 12:37 p.m., Ted Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: [ANNOUNCE] New Hive Committers - Jitendra Nath Pandey and Eric Hanson

This is really nice. Congratulations, Jitendra and Eric! --Xuefu On Thu, Nov 21, 2013 at 3:56 PM, Thejas Nair wrote: > Congrats! > > > On Thu, Nov 21, 2013 at 3:46 PM, Shreepadma Venugopalan > wrote: > > Congrats guys! > > > > > > On Thu, Nov 21, 2013 at 3:37 PM, Vinod Kumar Vavilapalli < > v

Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

passed. Thanks, Xuefu Zhang

Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

/test/results/clientpositive/vectorized_math_funcs.q.out 8bb0edf ql/src/test/results/compiler/plan/udf4.q.xml 145e244 Diff: https://reviews.apache.org/r/15777/diff/ Testing --- All new tests and old test passed. Thanks, Xuefu Zhang

Review Request 15804: HIVE-5866: Hive divide operator generates wrong results in certain cases

: https://reviews.apache.org/r/15804/diff/ Testing --- Thanks, Xuefu Zhang

Review Request 15820: HIVE-5839: BytesRefArrayWritable compareTo violates contract

/apache/hadoop/hive/serde2/columnar/TestBytesRefArrayWritable.java PRE-CREATION Diff: https://reviews.apache.org/r/15820/diff/ Testing --- Added new test case. Fixed a old test case. Thanks, Xuefu Zhang

Re: Review Request 15804: HIVE-5866: Hive divide operator generates wrong results in certain cases

type is required. Otherwise, double might be better. Thus, a decimal number of a certain decimal type needs to comply with the type's precision/scale. I don't think we should store number 456.78 to a type decimal(6,4), about which we already concluded the discussion. - Xuefu Zhang

Re: Review Request 15804: HIVE-5866: Hive divide operator generates wrong results in certain cases

/ql_rewrite_gbtoidx.q.out 83787ee ql/src/test/results/clientpositive/vectorization_5.q.out 54aad90 ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1 Diff: https://reviews.apache.org/r/15804/diff/ Testing --- Thanks, Xuefu Zhang

Re: Review Request 15804: HIVE-5866: Hive divide operator generates wrong results in certain cases

/ql_rewrite_gbtoidx.q.out 83787ee ql/src/test/results/clientpositive/vectorization_5.q.out 54aad90 ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1 Diff: https://reviews.apache.org/r/15804/diff/ Testing --- Thanks, Xuefu Zhang

Re: Hive install doc: "$ ant package"

I think the replacement in doc would be good, though the subsequent text also needs to be replaced. Specifically, the hive dist directory will be at a different place. You need -Pdist in above first maven command to generate the distribution directory. The current distribution directory is located

Re: Hive install doc: "$ ant package"

ll -DskipTests -Pdist > cd itests > mvn clean install -DskipTests > > > Yes. -Pdist is needed to generated the dist directory. > -- Lefty > > > On Sun, Nov 24, 2013 at 7:11 PM, Xuefu Zhang wrote: > > > I think the replacement in doc would be good, though the su

Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

programming problem, which seems proper for this case. That's, unless I programmed wrong, it shouldn't happen, which is exactly the case. I'm not sure if other type exception really buy us anything. - Xuefu Zhang On Nov. 22, 2013, 5

Build seems broken

[INFO] BUILD FAILURE [INFO] [INFO] Total time: 5.604s [INFO] Finished at: Mon Nov 25 17:53:20 PST 2013 [INFO] Final Memory: 29M/283M [INFO] [ERROR] Faile

Re: Review Request 15777: HIVE-5706: Move a few numeric UDFs to generic implementations

> On Nov. 25, 2013, 11:27 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNegative.java, > > line 85 > > <https://reviews.apache.org/r/15777/diff/3/?file=389817#file389817line85> > > > > Runtime exceptions re

Re: Review Request 15387: HIVE-5684 Serde support for char

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15387/#review29457 --- Ship it! Ship It! - Xuefu Zhang On Nov. 10, 2013, 2:19 a.m

Re: Review Request 15965: Show partition command doesn't support db.table

tps://reviews.apache.org/r/15965/#comment57068> Please remove the trailing space Patch looks good. However, please fill out the fields of the review request, such as bug number branch. The topic should start with the bug number also. Please find other review request as an example. - Xuefu

Review Request 16008: HIVE-5872: Make UDAFs such as GenericUDAFSum report accurate precision/scale for decimal types

/ Testing --- More tests are added. Existing test output are modified accordingly. Thanks, Xuefu Zhang

Re: Review Request 16008: HIVE-5872: Make UDAFs such as GenericUDAFSum report accurate precision/scale for decimal types

tps://reviews.apache.org/r/16008/#comment57247> This was probably due to HIVE-5947. Once HIVE-5947 is in, the diff here will disappear. - Xuefu Zhang On Dec. 4, 2013, 7:31 p.m., Xuefu Zhang wrote: > > --- > This is an automatica

Re: Review Request 16207: HIVE-1466: Add NULL DEFINED AS to ROW FORMAT specification

tps://reviews.apache.org/r/16207/#comment58009> It would be nice to remove the leading tabs. - Xuefu Zhang On Dec. 12, 2013, 8:20 p.m., Prasad Mujumdar wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 16239: HIVE-6022 Load statements with incorrect order of partitions put input files to unreadable places

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16239/#review30334 --- Ship it! Ship It! - Xuefu Zhang On Dec. 13, 2013, 5 a.m

Review Request 16328: HIVE-5992: Hive inconsistently converts timestamp in AVG and SUM UDAF's

/generic/GenericUDAFSum.java 41d5efd ql/src/test/queries/clientpositive/timestamp_3.q e5a4345 ql/src/test/results/clientpositive/timestamp_3.q.out 8544307 Diff: https://reviews.apache.org/r/16328/diff/ Testing --- Unit test. New unit test. Regression suite. Thanks, Xuefu Zhang

Review Request 16329: HIVE-6039: Round, AVG and SUM functions reject char/varch input while accepting string input

://reviews.apache.org/r/16329/diff/ Testing --- Unit tested. New test added. Test suite passed. Thanks, Xuefu Zhang

Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

ws.apache.org/r/15654/#comment58617> instanceof might be better used here as you would need exception handling. ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java <https://reviews.apache.org/r/15654/#comment58618> I don't think we need the bridge udf for ge

Re: Review Request 16329: HIVE-6039: Round, AVG and SUM functions reject char/varch input while accepting string input

ess a different JIRA is more appropriate. Thanks. - Xuefu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16329/#review30678 --------

Re: Review Request 16329: HIVE-6039: Round, AVG and SUM functions reject char/varch input while accepting string input

> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java, > > line 151 > > <https://reviews.apache.org/r/16329/diff/1/?file=398948#file398948line151> > > > > I do agree that "Only numeric data types allowed" is a bit misleading > > s

Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

/GenericUDFBaseTrim.java <https://reviews.apache.org/r/15654/#comment58824> I was thinking of doing this: if (!(auguments[0] instanceof PrimitiveObjectInspector)) { ... } - Xuefu Zhang On Dec. 18, 2013, 3:16 a.m., Mohammad Islam

Re: Review Request 15654: Rewrite Trim and Pad UDFs based on GenericUDF

> On Dec. 20, 2013, 2:37 a.m., Mohammad Islam wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java, > > line 47 > > > > > > Even if I implement it this way won't I still have to cast arg

Review Request 16412: HIVE-6048: Hive load data command rejects file with '+' in the name

piler/plan/subq.q.xml 8990b76 ql/src/test/results/compiler/plan/union.q.xml 6cab061 Diff: https://reviews.apache.org/r/16412/diff/ Testing --- New unit tests are added. Some old tests have newly generated output. Thanks, Xuefu Zhang

Re: Review Request 16412: HIVE-6048: Hive load data command rejects file with '+' in the name

ple7.q.xml 152cc08 ql/src/test/results/compiler/plan/subq.q.xml 8990b76 ql/src/test/results/compiler/plan/union.q.xml 6cab061 Diff: https://reviews.apache.org/r/16412/diff/ Testing --- New unit tests are added. Some old tests have newly generated output. Thanks, Xuefu Zhang

Re: Review Request 16480: Refactoring patch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16480/#review30897 --- Ship it! Ship It! - Xuefu Zhang On Dec. 27, 2013, 2:36 a.m

Re: [ANNOUNCE] New Hive PMC Member - Gunther Hagleitner

Many congratulations, Gunther! --Xuefu On Thu, Dec 26, 2013 at 8:59 PM, Carl Steinbach wrote: > I am pleased to announce that Gunther Hagleitner has been elected to the > Hive Project Management Committee. Please join me in congratulating > Gunther! > > Thanks. > > Carl >

Re: Review Request 16502: Use paths consisently - 3

<https://reviews.apache.org/r/16502/#comment59216> It would be nice if this can be reformatted: tab/space. - Xuefu Zhang On Dec. 29, 2013, 4:22 a.m., Ashutosh Chauhan wrote: > > --- > This is an automatically generated e

Re: Review Request 16502: Use paths consisently - 3

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16502/#review30993 --- Ship it! Ship It! - Xuefu Zhang On Dec. 30, 2013, 6:29 p.m

Re: Review Request 16526: more usage of paths

reviews.apache.org/r/16526/#comment59320> Same as above. trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/LoadTableDesc.java <https://reviews.apache.org/r/16526/#comment59341> Could you confirm that tmpDir isn't used? The old code seemed spending quite some effort generating the

Review Request 16593: HIVE-3611: Hive JDBC doesn't support BINARY column

://reviews.apache.org/r/16593/diff/ Testing --- Changed existing test cases to include binary data type in TestJdbcDriver2. Thanks, Xuefu Zhang

Re: Building Hive

You will need either "-Phadoop-1" or "-Phadoop-2" option. On Mon, Jan 6, 2014 at 12:33 PM, Konstantin Weitz < konstantin.we...@gmail.com> wrote: > I'm trying to build Hive from the trunk source. I ran > > mvn compile > > But I got the following error messages. > What am I doing wrong? > Is there

Re: Review Request 16727: Review Board for HIVE-5446 Hive can CREATE an external table but not SELECT from it when file path have spaces

e.org/r/16727/#comment59814> I don't know why we need to make change here. tblDir is already an instance of Path. If it has issue, that means it's not constructed correctly. We should fix that instead. - Xuefu Zhang

Re: Review Request 16727: Review Board for HIVE-5446 Hive can CREATE an external table but not SELECT from it when file path have spaces

che.org/r/16727/#comment59910> I think we we need to be consistent here. Returning null seems more appropriate. In any case, logging a meaningful message is helpful. - Xuefu Zhang On Jan. 9, 2014, 1:57 a.m., Shuaishu

Re: Review Request 16727: Review Board for HIVE-5446 Hive can CREATE an external table but not SELECT from it when file path have spaces

c/java/org/apache/hadoop/hive/ql/metadata/Table.java <https://reviews.apache.org/r/16727/#comment59954> Okay. Either way, I think this needs to be consistent with Partition.getPartitionPath() in terms of error handling. - Xuefu Zhang On Jan. 9, 2014, 1:57 a.m., Shuaishu

Re: Review Request 16727: Review Board for HIVE-5446 Hive can CREATE an external table but not SELECT from it when file path have spaces

-- > > (Updated Jan. 9, 2014, 9:46 p.m.) > > > Review request for hive, Thejas Nair and Xuefu Zhang. > > > Bugs: HIVE-5446 > https://issues.apache.org/jira/browse/HIVE-5446 > > > Repository: hive-git > > > Description >

Review Request 16806: HIVE-6185: DDLTask is inconsistent in creating a table and adding a partition when dealing with location

/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java 69d1896 Diff: https://reviews.apache.org/r/16806/diff/ Testing --- No new test. Thanks, Xuefu Zhang

Review Request 16807: HIVE-6174: Beeline "set varible" doesn't show the value of the variable as Hive CLI

.java f3ea07c ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java c27b689 Diff: https://reviews.apache.org/r/16807/diff/ Testing --- Added HiveServer2 test and Beeline test. Thanks, Xuefu Zhang

Re: hive unit test report question

You probably needs "cd itests" in the middle of your two steps. --Xuefu On Mon, Jan 13, 2014 at 1:59 PM, Shanyu Zhao wrote: > Hi, > > I was trying to build hive trunk, run all unit tests and generate reports, > but I'm not sure what's the correct command line. I was using: > mvn clean install

Re: Review Request 16899: Path refactor patch

name and method name from ...URI to ...Path or ...Dir to reflect the meaning? 2. I saw a few places that use Path.toUri().toString() instead of Path.toString(). Any catch here? - Xuefu Zhang On Jan. 15, 2014, 5:45 a.m., Ashutosh Chauhan wrote

Review Request 16910: HIVE-6173: Beeline doesn't accept --hiveconf option as Hive CLI does

/DatabaseConnection.java 553722d beeline/src/main/resources/BeeLine.properties 408286d itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 539ebdb Diff: https://reviews.apache.org/r/16910/diff/ Testing --- Unit test added. Thanks, Xuefu Zhang

Re: Review Request 16910: HIVE-6173: Beeline doesn't accept --hiveconf option as Hive CLI does

added. Thanks, Xuefu Zhang

Re: Review Request 17097: Consistent path usage

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17097/#review32255 --- Ship it! Ship It! - Xuefu Zhang On Jan. 18, 2014, 10:03 p.m

Review Request 17169: HIVE-6217: Refactor Beeline's JDBC connection to use property map instead of long url

--- No new test. Test suit passed. Thanks, Xuefu Zhang

Re: Review Request 17169: HIVE-6217: Refactor Beeline's JDBC connection to use property map instead of long url

://reviews.apache.org/r/17169/diff/ Testing --- No new test. Test suit passed. Thanks, Xuefu Zhang

Review Request 17262: HIVE-6246: Sign(a) UDF is not supported for decimal type

sting --- Unit test is added. Thanks, Xuefu Zhang

Re: Review Request 17262: HIVE-6246: Sign(a) UDF is not supported for decimal type

() is a good name? A result of C&P. Will change it. - Xuefu --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17262/#review32677 --------

Could anyone take a look at the testing issue described in HIVE-6293?

Thanks, Xuefu

  1   2   3   4   5   6   7   8   9   10   >