Re: Comments on accept-mutex/single-listen patch ??

2001-08-30 Thread Jim Jagielski
Peace! I'll commit minus SingleListen :) -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ A society that will trade a little liberty for a little order will lose

Re: Comments on accept-mutex/single-listen patch ??

2001-08-30 Thread Dirk-Willem van Gulik
On Wed, 29 Aug 2001, Jim Jagielski wrote: Jeff Trawick wrote: how would it not work? fubar kernel? The trick would be in it *working*... NONE implies no mutexing at all, even for multiple listeners. And *that's* the exception. In some environments - for example with a clever linux or

Re: Comments on accept-mutex/single-listen patch ??

2001-08-30 Thread Dirk-Willem van Gulik
On Wed, 29 Aug 2001, Marc Slemko wrote: On Wed, 29 Aug 2001, Jim Jagielski wrote: Marc Slemko wrote: So I don't see how NONE is viable on _ANY_ platform in the multiple listener case. It may seem to mostly work, but it is not reliable and can not be permitted. threaded

Re: Comments on accept-mutex/single-listen patch ??

2001-08-29 Thread Jeff Trawick
Jim Jagielski [EMAIL PROTECTED] writes: At 11:00 AM -0400 8/28/01, Jeff Trawick wrote: HAVE_NONE_xxx means that you can turn the accept mutex into a no-op, even in the multiple-listener case. If we can play around with this on one platform (e.g., Darwin), why can't we play around with

Re: Comments on accept-mutex/single-listen patch ??

2001-08-29 Thread Marc Slemko
On Wed, 29 Aug 2001, Jim Jagielski wrote: recall that the current code *defaults* to NONE (basically, if no other method is compiled in) and will allow that option to be used (but will post a warning unless MULTITHREAD is defined). So we're even *safer* than the current such that if none are

Re: Comments on accept-mutex/single-listen patch ??

2001-08-29 Thread Bill Stoddard
At 11:00 AM -0400 8/28/01, Jeff Trawick wrote: The order it checks for (at the moment :) ) is sysvsem, flock, pthread mutex, fcntl. The last match wins (i.e., fcntl is preferred). This can be overridden on a platform basis in apr_hints.m4 by setting the variable apr_lock_method.

Re: Comments on accept-mutex/single-listen patch ??

2001-08-28 Thread Jim Jagielski
At 10:18 AM -0400 8/28/01, Jeff Trawick wrote: which default stuff is needed in 2.0? Last I looked, APR uses the traditional ordering of which locking method to use. Thus, if SysV, fcntl and flock are available, APR will choose SysV by default, even if it should be fcntl. We know which should

Re: Comments on accept-mutex/single-listen patch ??

2001-08-28 Thread Jeff Trawick
Jim Jagielski [EMAIL PROTECTED] writes: At 10:18 AM -0400 8/28/01, Jeff Trawick wrote: which default stuff is needed in 2.0? Last I looked, APR uses the traditional ordering of which locking method to use. Thus, if SysV, fcntl and flock are available, APR will choose SysV by default,

Re: Comments on accept-mutex/single-listen patch ??

2001-08-28 Thread Jim Jagielski
At 11:00 AM -0400 8/28/01, Jeff Trawick wrote: The order it checks for (at the moment :) ) is sysvsem, flock, pthread mutex, fcntl. The last match wins (i.e., fcntl is preferred). This can be overridden on a platform basis in apr_hints.m4 by setting the variable apr_lock_method. That's cool.

Comments on accept-mutex/single-listen patch ??

2001-08-28 Thread Jim Jagielski
Anyone get a chance to look over and try out the latest patch? -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ A society that will trade a little liberty for a little order

Re: Comments on accept-mutex/single-listen patch ??

2001-08-28 Thread Jim Jagielski
Just noticed some typos (ie: SYSVMEM instead of SYSVSEM)... will fix. -- === Jim Jagielski [|] [EMAIL PROTECTED] [|] http://www.jaguNET.com/ A society that will trade a little liberty for a little order

Re: Comments on accept-mutex/single-listen patch ??

2001-08-28 Thread Dirk-Willem van Gulik
On Tue, 28 Aug 2001, Jim Jagielski wrote: Anyone get a chance to look over and try out the latest patch? Looking at it.. (And trying to compare it with what I've got here to make sure I still have all the functionality I needed). Seems all cool sofar. Dw