[
https://issues.apache.org/jira/browse/KAFKA-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar updated KAFKA-2238:
---
Description:
All metrics config values are not included in KafkaConfig and consequently do
[
https://issues.apache.org/jira/browse/KAFKA-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar updated KAFKA-2238:
---
Summary: KafkaMetricsConfig cannot be configured in broker (KafkaConfig
[
https://issues.apache.org/jira/browse/KAFKA-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar updated KAFKA-2238:
---
Description:
All metrics config values are not included in KafkaConfig and consequently
+1 (non-binding).
One minor comment. Should we rename max.block.ms to max.send.block.ms?
Something that indicates that it is being applied to the send API methods
exposed by KafkaProducer.
Aditya
From: Joel Koshy [jjkosh...@gmail.com]
Sent: Tuesday,
/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
/
Testing
---
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570034#comment-14570034
]
Aditya A Auradkar commented on KAFKA-2084:
--
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2084:
-
Attachment: KAFKA-2084_2015-06-02_17:09:28.patch
byte rate metrics per client ID
31, 2015, Aditya Auradkar aaurad...@linkedin.com.invalid
wrote:
2. There was a typo in my previous email. I meant to say that we should
use snake case because it's more consistent. I couldn't find any examples
of camel case but did find some snake case (jmx_port). Other than that,
most other
Hey everyone,
We have enough KIP's now (25) that it's a bit hard to tell which ones are
adopted or under discussion by glancing at the wiki. Any concerns if I split it
into 3 tables (adopted, discarded and KIP's under discussion)?
bitten.
-Jay
On Thu, May 28, 2015 at 11:22 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Yeah, the same cleaning mechanism will be carried over.
1. Are we introducing a new Java API for the config change protocol and
if
so where will that appear? Is that going to be part
. This changes the format of the notifications, right? How will we
grandfather in the old format? Clusters will have existing change
notifications in the old format so I think the new code will need to be
able to read those?
-Jay
On Thu, May 28, 2015 at 11:41 AM, Aditya Auradkar
aaurad
Auradkar
Sent: Thursday, May 28, 2015 11:22 PM
To: dev@kafka.apache.org
Subject: RE: [VOTE] KIP-21 Dynamic Configuration
Yeah, the same cleaning mechanism will be carried over.
1. Are we introducing a new Java API for the config change protocol and if
so where will that appear? Is that going
ISR for the consumer to choose.
So, perhaps it's worth fixing the ISR inconsistency issue in KAFKA-1367
(there is some new discussion there on what it takes to fix this). If we do
that, we can leave TMR unchanged.
Thanks,
Jun
On Tue, May 26, 2015 at 1:13 PM, Aditya Auradkar
aaurad
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2084:
-
Attachment: KAFKA-2084_2015-05-26_11:50:50.patch
byte rate metrics per client ID
for it?
Aditya Auradkar wrote:
Hey dong, yeah you should submit a patch for it.
Dong Lin wrote:
Sure! I will do it.
Dropping since this is being tracked in a separate ticket.
- Aditya
---
This is an automatically generated e
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559613#comment-14559613
]
Aditya A Auradkar commented on KAFKA-2084:
--
Updated reviewboard https
8014a5a6c362785539f24eb03d77278434614fe6
core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
Andryii,
I made a few edits to this document as discussed in the KIP-21 thread.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations
With these changes. the only difference between TopicMetadataResponse_V1 and V0
is the removal of the
Hey everyone,
Completed the changes to KIP-4. After today's hangout, there doesn't appear to
be anything remaining to discuss on this KIP.
Please vote so we can formally close this.
Thanks,
Aditya
From: Aditya Auradkar
Sent: Thursday, May 21, 2015 11
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2205:
-
Attachment: KAFKA-2205.patch
Generalize TopicConfigManager to handle multiple entity
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554734#comment-14554734
]
Aditya A Auradkar commented on KAFKA-2205:
--
Created reviewboard https
remove the config part in
it?
Thanks,
Jun
On Thu, May 21, 2015 at 10:25 AM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey Jun,
I've added a section on error codes on the KIP-21 wiki.
Here are the proposed changes to KIP-4. I'll update the wiki shortly.
- Change AlterTopic
7877f6ca1845c2edbf96d4a9783a07a552db8f07
Diff: https://reviews.apache.org/r/34554/diff/
Testing (updated)
---
1. Added new testcases for new code.
2. Verified that both topic and client configs can be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar
, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Thanks Andrii. I'll make the changes.
I've also updated KIP-21 to include the new config requests. Take a look
and vote.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration
Aditya
Aditya Auradkar created KAFKA-2209:
--
Summary: Change client quotas dynamically using
DynamicConfigManager
Key: KAFKA-2209
URL: https://issues.apache.org/jira/browse/KAFKA-2209
Project: Kafka
to update the KIP page.
Thanks,
Andrii Biletskyi
On Tue, May 19, 2015 at 11:40 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Updating the discussion with the latest comments.
1. We discussed adding 2 new API's (AlterConfig and DescribeConfig). I'll
update KIP-21 with details
Aditya Auradkar created KAFKA-2206:
--
Summary: Add AlterConfig and DescribeConfig requests to Kafka
Key: KAFKA-2206
URL: https://issues.apache.org/jira/browse/KAFKA-2206
Project: Kafka
Issue
Aditya Auradkar created KAFKA-2205:
--
Summary: Generalize TopicConfigManager to handle multiple entity
configs
Key: KAFKA-2205
URL: https://issues.apache.org/jira/browse/KAFKA-2205
Project: Kafka
Aditya Auradkar created KAFKA-2204:
--
Summary: Dynamic Configuration via ZK
Key: KAFKA-2204
URL: https://issues.apache.org/jira/browse/KAFKA-2204
Project: Kafka
Issue Type: New Feature
to be
ConfigOverrideManager and have it handle all the override types we will
have? I think I may just be unclear on what you are proposing...
-Jay
On Mon, May 18, 2015 at 1:34 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Yeah, that was just a typo. I've fixed it. Thanks for calling it out.
In KIP-4
/MetricsTest.java
https://reviews.apache.org/r/34418/#comment135560
can you remove this?
- Aditya Auradkar
On May 19, 2015, 5:12 p.m., Jay Kreps wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration
Aditya
request or have a combined new request for both topic and client id
level config changes?
A minor point in the wiki, for the json format in ZK, we should change
{X1=Y1,
X2=Y2..} to a json map, right?
Thanks,
Jun
On Mon, May 18, 2015 at 9:48 AM, Aditya Auradkar
aaurad...@linkedin.com.invalid
. making it pluggable?
Any other requirements?
Thanks,
Joel
On Tue, May 05, 2015 at 01:38:09AM +, Aditya
Auradkar
wrote:
Hey Neha,
Thanks
:
There will be 3 paths within config
/config/clients/client_id
/config/topics/topic_name
/config/brokers/broker_id
Didn't we decide that brokers will not be configured dynamically, rather we
will keep the config in the file?
On Fri, May 15, 2015 at 10:46 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid
Rate.record(n), what should be the return value? I think there are two
possibilities: 0 and n/config.timeWindowMs(). I didn't find any use case
where these two values make a difference.
Which value do you think is the best?
Thank you.
Aditya Auradkar wrote:
I think
On May 13, 2015, 5:14 p.m., Jay Kreps wrote:
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java, line
62
https://reviews.apache.org/r/34170/diff/1/?file=958215#file958215line62
Is this actually right? I agree you'll get discontinuities as the
measured time
. In the rare case, there is no
activity for 10 mins (say), this will add 10sec*6*10 = 600 samples which will
be purged immediately on the next record call.
- Aditya Auradkar
On May 13, 2015, 10:32 p.m., Dong Lin wrote
---
On May 11, 2015, 11:17 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540818#comment-14540818
]
Aditya A Auradkar commented on KAFKA-2136:
--
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2136:
-
Attachment: KAFKA-2136_2015-05-12_14:40:44.patch
Client side protocol changes to return
/r/33378/#review83439
---
On May 12, 2015, 9:40 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378
/DelayedOperationTest.scala
f3ab3f4ff8eb1aa6b2ab87ba75f72eceb6649620
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
00d59337a99ac135e8689bd1ecd928f7b1423d79
Diff: https://reviews.apache.org/r/33378/diff/
Testing
---
New tests added
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2136:
-
Attachment: KAFKA-2136_2015-05-11_14:50:56.patch
Client side protocol changes to return
? E.g. making it pluggable?
Any other requirements?
Thanks,
Joel
On Tue, May 05, 2015 at 01:38:09AM +, Aditya Auradkar
wrote:
Hey Neha,
Thanks for the feedback.
1. In my earlier exchange
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538703#comment-14538703
]
Aditya A Auradkar commented on KAFKA-2136:
--
Updated reviewboard https
8014a5a6c362785539f24eb03d77278434614fe6
core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538850#comment-14538850
]
Aditya A Auradkar commented on KAFKA-2084:
--
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2084:
-
Attachment: KAFKA-2084_2015-05-11_16:16:01.patch
byte rate metrics per client ID
8014a5a6c362785539f24eb03d77278434614fe6
core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
/ConsumerConnector.java
https://reviews.apache.org/r/34070/#comment134315
How does this work if the consumer doesn't own these partitions? Is it
possible to commit offsets for any topic? Just curious..
- Aditya Auradkar
On May 12, 2015, 1:39 a.m., Jiangjie Qin wrote
., a DB). Possible options:
- ZooKeeper
- Kafka topic
- other? E.g. making it pluggable?
Any other requirements?
Thanks,
Joel
On Tue, May 05, 2015 at 01:38:09AM +, Aditya Auradkar
wrote:
Hey Neha
,
Aditya Auradkar
.
- Aditya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/#review82389
---
On May 7, 2015, 1:36 a.m., Aditya Auradkar wrote
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531857#comment-14531857
]
Aditya A Auradkar commented on KAFKA-2136:
--
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2136:
-
Attachment: KAFKA-2136_2015-05-06_18:32:48.patch
Client side protocol changes to return
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2136:
-
Attachment: KAFKA-2136_2015-05-06_18:35:54.patch
Client side protocol changes to return
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14531865#comment-14531865
]
Aditya A Auradkar commented on KAFKA-2136:
--
Updated reviewboard https
tests added
Thanks,
Aditya Auradkar
/unit/kafka/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529672#comment-14529672
]
Aditya A Auradkar commented on KAFKA-2084:
--
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2084:
-
Attachment: KAFKA-2084_2015-05-05_17:52:02.patch
byte rate metrics per client ID
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529422#comment-14529422
]
Aditya A Auradkar commented on KAFKA-2084:
--
Updated reviewboard https
/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-2084:
-
Attachment: KAFKA-2084_2015-05-05_15:27:35.patch
byte rate metrics per client ID
[
https://issues.apache.org/jira/browse/KAFKA-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-1984:
-
Attachment: KAFKA-1984_2015-05-04_19:52:19.patch
java producer may miss an available
manager updates this reference.
d. The KafkaConfiguration is the thing that allows doing the
configuration.onChange(my.config, callback)
-Jay
On Tue, Apr 28, 2015 at 3:57 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey everyone,
Wrote up a KIP to update topic, client
://reviews.apache.org/r/33049/#review82382
---
On April 28, 2015, 12:38 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049
8014a5a6c362785539f24eb03d77278434614fe6
core/src/test/scala/unit/kafka/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527818#comment-14527818
]
Aditya A Auradkar commented on KAFKA-1984:
--
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527887#comment-14527887
]
Aditya Auradkar commented on KAFKA-1984:
[~junrao] My bad.. I attached to 1984
-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
/
Testing
---
Thanks,
Aditya Auradkar
gradually.
-Jay
On Mon, May 4, 2015 at 1:31 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey Jay,
Thanks for the feedback.
1. We can certainly discuss what it means to remove the file configuration
as a thought exercise. However, is this something we want to do for real?
IMO
the
configuration.onChange(my.config, callback)
-Jay
On Tue, Apr 28, 2015 at 3:57 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey everyone,
Wrote up a KIP to update topic, client and broker configs dynamically via
Zookeeper.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-21
Hey Joe,
Can you elaborate what you mean by a stop the world change? In this protocol,
we can target notifications to a subset of brokers in the cluster (controller
if we need to). Is the AdminChangeNotification a ZK notification or a request
type exposed by each broker?
Thanks,
Aditya
On Tue, Apr 28, 2015 at 3:57 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Hey everyone,
Wrote up a KIP to update topic, client and broker configs dynamically via
Zookeeper.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration
Please read
Hey Gwen,
Thanks for the feedback. As Joel said, these client configs do not introduce a
producer/consumer zk dependency. It is configuration that is needed by the
broker.
From your comments, I gather that you are more worried about managing broker
internal configs via Zookeeper since we
[
https://issues.apache.org/jira/browse/KAFKA-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522273#comment-14522273
]
Aditya Auradkar commented on KAFKA-2161:
+1 on using Rat. It doesn't seem to have
[
https://issues.apache.org/jira/browse/KAFKA-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14519813#comment-14519813
]
Aditya Auradkar commented on KAFKA-2156:
[~junrao] Do we want to support
Hey everyone,
Wrote up a KIP to update topic, client and broker configs dynamically via
Zookeeper.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration
Please read and provide feedback.
Thanks,
Aditya
PS: I've intentionally kept this discussion separate from KIP-5
/
Testing (updated)
---
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517479#comment-14517479
]
Aditya A Auradkar commented on KAFKA-1886:
--
Updated reviewboard https
since it almost always leads to transient test failures.
Consider using TestUtils.waitUntilTrue().
Aditya Auradkar wrote:
Thanks Neha. I missed this review comment.
I agree sleeping isn't ideal here but I don't think there is a condition
I can wait on to trigger this specific
[
https://issues.apache.org/jira/browse/KAFKA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14517489#comment-14517489
]
Aditya Auradkar commented on KAFKA-1886:
[~nehanarkhede] I've updated the patch
[
https://issues.apache.org/jira/browse/KAFKA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-1886:
-
Attachment: KAFKA-1886_2015-04-28_10:27:39.patch
SimpleConsumer swallowing
://reviews.apache.org/r/30196/diff/
Testing
---
Added an integration test to PrimitiveAPITest.scala.
Thanks,
Aditya Auradkar
-client. That makes sense.
On Fri, Apr 24, 2015 at 11:02:29PM +, Aditya Auradkar wrote:
I think Joel's suggestion is quite good. It's still possible to throttle
other types of requests using purgatory but we will need a separate purgatory
and DelayedOperation variants of different request
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33551/#review81693
---
Ship it!
Ship It!
- Aditya Auradkar
On April 25, 2015, 8:35 p.m
[
https://issues.apache.org/jira/browse/KAFKA-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar updated KAFKA-2103:
---
Assignee: Dong Lin
kafka.producer.AsyncProducerTest failure
://reviews.apache.org/r/33551/#comment132029
I was thinking that you could still process the fetchRequest outside the
locked segment. Is there a reason a flag wouldn't work?
- Aditya Auradkar
On April 25, 2015, 2:48 p.m., Sriharsha Chintalapani wrote
. The fetch request can still be performed outside
the locked segment.
- Aditya Auradkar
On April 25, 2015, 2:48 p.m., Sriharsha Chintalapani wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
[
https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar updated KAFKA-1936:
---
Assignee: Dong Lin (was: Aditya Auradkar)
Track offset commit requests separately from
[
https://issues.apache.org/jira/browse/KAFKA-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510209#comment-14510209
]
Aditya Auradkar commented on KAFKA-2128:
+1
kafka.Kafka should return non-zero
-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505563#comment-14505563
]
Aditya A Auradkar commented on KAFKA-2084:
--
Updated reviewboard https
301 - 400 of 580 matches
Mail list logo