[jira] [Updated] (MESOS-1285) metrics names shouldn't include problematic characters

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1285: - Sprint: Q2'14 Sprint 2 > metrics names shouldn't include problematic characters > ---

[jira] [Updated] (MESOS-1286) metrics Gauge doesn't need to depend on defer

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1286: - Sprint: Q2'14 Sprint 2 > metrics Gauge doesn't need to depend on defer >

[jira] [Updated] (MESOS-1348) The SlaveRecoveryTest.GCExecutor test leaks child processes.

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1348: - Sprint: Q2'14 Sprint 2 > The SlaveRecoveryTest.GCExecutor test leaks child processes. > -

[jira] [Updated] (MESOS-1284) metrics Timer should use Clock

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1284: - Sprint: Q2'14 Sprint 2 > metrics Timer should use Clock > -- > >

[jira] [Updated] (MESOS-1346) Improve flags to parse json to protobuf

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1346: - Sprint: Q2'14 Sprint 2 > Improve flags to parse json to protobuf > --

Re: Review Request 21166: Added resource Gauges to Master.

2014-05-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21166/#review43025 --- Looks good, just a few minor items below. src/master/master.hpp

Re: Review Request 21279: Added task gauges to Master.

2014-05-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21279/#review43033 --- Ship it! Thank you! Will make the minor adjustment below and commit

[jira] [Updated] (MESOS-390) Slave should support file:/// URIs for executor path

2014-05-16 Thread Niklas Quarfot Nielsen (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Quarfot Nielsen updated MESOS-390: - Assignee: Timothy Chen > Slave should support file:/// URIs for executor path > --

Review Request 21277: Passed CommandInfo to mesos-fetcher as JSON.

2014-05-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21277/ --- Review request for mesos, Ben Mahler, Dominic Hamon, and Tom Arnfeld. Bugs: MES

Re: Review Request 21052: Introduced a HealthCheck protobuf.

2014-05-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21052/#review42532 --- Ship it! Ship It! - Niklas Nielsen On May 8, 2014, 12:42 p.m., B

Re: Review Request 21464: Added backoff to slave's initial (re-)registration attempt.

2014-05-16 Thread Jiang Yan Xu
> On May 14, 2014, 9:20 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, lines 562-567 > > > > > > So if a large cluster does require slave authentication, then slaves > > are still going to be bombarding the mast

Re: Review Request 20818: Refactored cgroups::destroy to use a single pass and to reap processes.

2014-05-16 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20818/ --- (Updated May 15, 2014, 10:24 p.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 19966: Enabled whitespace/blank_line rule for cpplint.

2014-05-16 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19966/ --- (Updated May 15, 2014, 4:34 p.m.) Review request for mesos, Benjamin Hindman an

Review Request 21233: Abstracted out invoking 'mesos-fetcher'.

2014-05-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21233/ --- Review request for mesos, Dominic Hamon, Ian Downes, Tom Arnfeld, and Vinod Kone

Re: Review Request 19499: Ported slave statistics over to new metrics library.

2014-05-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19499/#review42593 --- Ship it! Will get this committed! I'll clean up the test a bit and

Re: Review Request 21092: Added timeout to metrics collection.

2014-05-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21092/#review42519 --- Patch looks great! Reviews applied: [21092] All tests passed. - M

Review Request 21457: Changed 'registry' flag default to 'replicated_log'.

2014-05-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21457/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1314 https://issues.ap

Re: Review Request 21167: Added user field to CommandInfo.

2014-05-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21167/ --- (Updated May 8, 2014, 12:04 p.m.) Review request for mesos, Adam B, Benjamin Hi

[jira] [Updated] (MESOS-1346) Improve flags to parse json to protobuf

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1346: -- Sprint: (was: Q2'14 Sprint 2) > Improve flags to parse json to protobuf > ---

Re: Review Request 19545: Ported libprocess system/stats.json endpoint to new metrics library.

2014-05-16 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19545/ --- (Updated May 15, 2014, 11:15 a.m.) Review request for mesos and Ben Mahler. C

[jira] [Comment Edited] (MESOS-1324) Create a network isolator based on port mapping

2014-05-16 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998961#comment-13998961 ] Timothy St. Clair edited comment on MESOS-1324 at 5/15/14 6:00 PM: -

Re: Review Request 21399: Added message counters for all messages types in Master.

2014-05-16 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21399/#review43129 --- src/master/master.hpp

Re: Review Request 21084: [MESOS-1259:MESOS-1293]:Enrich the Java Docs in the src/java files. -- Variable.java

2014-05-16 Thread Bernardo Gomez Palacio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21084/ --- (Updated May 15, 2014, 8:57 p.m.) Review request for mesos and Mesos ReviewBot.

[jira] [Commented] (MESOS-1358) Show when the leading master was elected in the webui

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999337#comment-13999337 ] Vinod Kone commented on MESOS-1358: --- https://reviews.apache.org/r/21501/ > Show when th

Re: Review Request 21442: Introduce a PerfStatistics protobuf.

2014-05-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21442/#review43137 --- ContainerStatistics is a great idea. How big of a change is it? in

[jira] [Updated] (MESOS-1346) Improve flags to parse json to protobuf

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1346: -- Fix Version/s: (was: 0.19.0) > Improve flags to parse json to protobuf > --

Re: Review Request 20918: Timer now uses Clock instead of Stopwatch to enable easier testing.

2014-05-16 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20918/ --- (Updated May 15, 2014, 10:43 a.m.) Review request for mesos and Ben Mahler. C

[jira] [Updated] (MESOS-1376) CHECK failure in the Registrar

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1376: -- Sprint: Q2'14 Sprint 2 > CHECK failure in the Registrar > -- > >

[jira] [Commented] (MESOS-1357) integrate self-bootstrapping self-contained rbt

2014-05-16 Thread Steven Phung (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999482#comment-13999482 ] Steven Phung commented on MESOS-1357: - This seems like a good idea to me, when I was c

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2120

2014-05-16 Thread Apache Jenkins Server
See Changes: [vinod] Revert "Allowed Gauge to take synchronous functions." [vinod] Added test for killing unknown task with Slaves in transitional state. [niklas] Updated CHANGELOG for 0.18.2-rc1. [

[jira] [Created] (MESOS-1375) Log rotation capable

2014-05-16 Thread Damien Hardy (JIRA)
Damien Hardy created MESOS-1375: --- Summary: Log rotation capable Key: MESOS-1375 URL: https://issues.apache.org/jira/browse/MESOS-1375 Project: Mesos Issue Type: Improvement Components

Re: Review Request 21439: Added a pre-commit hook to check style.

2014-05-16 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21439/#review43128 --- Ship it! Ship It! docs/mesos-developers-guide.md

[jira] [Updated] (MESOS-473) Freezer fails fatally when it is unable to write 'FROZEN' to freezer.state

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-473: - Sprint: Q2'14 Sprint 2 > Freezer fails fatally when it is unable to write 'FROZEN' to freezer.state >

Re: Review Request 19966: Enabled whitespace/blank_line rule for cpplint.

2014-05-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19966/#review43148 --- Bad patch! Reviews applied: [19966] Failed command: git apply --in

[jira] [Updated] (MESOS-1283) reintroduce LIBPROCESS_STATISTICS_WINDOW

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1283: -- Sprint: (was: Q2'14 Sprint 2) > reintroduce LIBPROCESS_STATISTICS_WINDOW > --

[jira] [Updated] (MESOS-1373) Add principal field to AuthenticateMessage and FrameworkInfo

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1373: - Sprint: Q2'14 Sprint 2 > Add principal field to AuthenticateMessage and FrameworkInfo > -

[jira] [Updated] (MESOS-1331) SlaveRecoveryTest/0.NonCheckpointingFramework is flaky.

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1331: - Sprint: Q2'14 Sprint 2 > SlaveRecoveryTest/0.NonCheckpointingFramework is flaky. > --

Review Request 21183: MESOS-1310: Changed reply() to send(from) during registration.

2014-05-16 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21183/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1310 https://issues.ap

[jira] [Commented] (MESOS-1329) ProcTest.SingleThread is flacky

2014-05-16 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999149#comment-13999149 ] Ian Downes commented on MESOS-1329: --- Has this been observed since this was committed: c

Re: Review Request 15185: Adjusted Master failover tests to use the same flags across Master runs.

2014-05-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15185/#review43174 --- is this still relevant? - Vinod Kone On Nov. 5, 2013, 10:29 p.m.,

Re: Review Request 21079: [MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosExecutorDriver.java

2014-05-16 Thread Bernardo Gomez Palacio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21079/ --- (Updated May 15, 2014, 8:57 p.m.) Review request for mesos and Mesos ReviewBot.

Re: Review Request 21505: Added stream operator for filter::ip::PortRange.

2014-05-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21505/#review43195 --- Ship it! Ship It! - Vinod Kone On May 16, 2014, 12:22 a.m., Jie

Re: Review Request 21257: rbt runtime error fix and updated revision range usage for rbt 0.6+

2014-05-16 Thread Steven Phung
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21257/ --- (Updated May 16, 2014, 2:02 a.m.) Review request for mesos and Vinod Kone. Ch

[jira] [Commented] (MESOS-1375) Log rotation capable

2014-05-16 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999827#comment-13999827 ] Timothy St. Clair commented on MESOS-1375: -- Worth investigating the standard glog

Re: [VOTE] Release Apache Mesos 0.18.2 (rc1)

2014-05-16 Thread Adam Bordelon
+1 make check passes on Linux Mint 16 (Ubuntu 13.10), gcc 4.8.1 On Wed, May 14, 2014 at 12:06 PM, Niklas Nielsen wrote: > Hi all, > > Please vote on releasing the following candidate as Apache Mesos 0.18.2. > > > 0.18.2 includes the following: > > ---

[jira] [Updated] (MESOS-1370) SlaveRecoveryTest/0.RemoveNonCheckpointingFramework is flaky

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1370: - Sprint: Q2'14 Sprint 2 > SlaveRecoveryTest/0.RemoveNonCheckpointingFramework is flaky > -

Re: Review Request 21082: [MESOS-1259]:Enrich the Java Docs in the src/java files. -- SchedulerDriver.java

2014-05-16 Thread Bernardo Gomez Palacio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21082/ --- (Updated May 15, 2014, 8:57 p.m.) Review request for mesos and Mesos ReviewBot.

Re: Review Request 21080: [MESOS-1259]:Enrich the Java Docs in the src/java files. -- MesosSchedulerDriver.java

2014-05-16 Thread Bernardo Gomez Palacio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21080/ --- (Updated May 15, 2014, 8:56 p.m.) Review request for mesos and Niklas Nielsen.

Re: Review Request 21257: rbt runtime error fix and updated revision range usage for rbt 0.6+

2014-05-16 Thread Steven Phung
> On May 15, 2014, 6:32 a.m., Vinod Kone wrote: > > can you run this script against a branch that has multiple commits and see > > if it works as expected? > > Steven Phung wrote: > Just tried this out, things seem to work as expected. Actually I think I may have found a difference with th

Re: Review Request 21078: [MESOS-1259]:Enrich the Java Docs in the src/java files. -- Log.java

2014-05-16 Thread Bernardo Gomez Palacio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21078/ --- (Updated May 15, 2014, 8:58 p.m.) Review request for mesos and Mesos ReviewBot.

Re: Review Request 21439: Added a pre-commit hook to check style.

2014-05-16 Thread Vinod Kone
> On May 15, 2014, 5:38 p.m., Dominic Hamon wrote: > > docs/mesos-developers-guide.md, line 35 > > > > > > should we point to 'how to install a pre-commit hook' documentation? added a blurb to look at the scrip for ins

[jira] [Updated] (MESOS-1346) Improve flags to parse json to protobuf

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1346: -- Labels: (was: 2) > Improve flags to parse json to protobuf > ---

Re: Review Request 21451: Add sampling support to the perf_event isolator.

2014-05-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21451/#review43144 --- src/slave/containerizer/isolators/cgroups/perf_event.cpp

[jira] [Commented] (MESOS-1374) Verify static libprocess scheduler port works with Mesos Master

2014-05-16 Thread Dominic Hamon (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998993#comment-13998993 ] Dominic Hamon commented on MESOS-1374: -- Thanks, [~kevints], for the confirmation. How

Re: Review Request 21130: Updated 'recover' implementation to forward to the ECP.

2014-05-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21130/#review42589 --- Ship it! src/slave/containerizer/external_containerizer.hpp

[jira] [Commented] (MESOS-1351) Fix issues from static analysis(Coverity) scan

2014-05-16 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999886#comment-13999886 ] Timothy St. Clair commented on MESOS-1351: -- Might also want to run it through the

Re: [VOTE] Release Apache Mesos 0.18.2 (rc1)

2014-05-16 Thread Tom Arnfeld
+1 make check on OSX 10.9.1 (gcc-4.8) > On 15 May 2014, at 15:55, Niklas Nielsen wrote: > > Hi all, > > Please vote on releasing the following candidate as Apache Mesos 0.18.2. > > > 0.18.2 includes the following: >

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2120

2014-05-16 Thread Apache Jenkins Server
See Changes: [idownes] ProcTest.MultipleThreads waits for /proc to update. [bmahler] Ported some of the slave statistics to the new metrics library. --

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #88

2014-05-16 Thread Apache Jenkins Server
See

[jira] [Updated] (MESOS-1342) Add authorization support.

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-1342: - Component/s: master > Add authorization support. > -- > >

Re: Review Request 21092: Added timeout to metrics collection.

2014-05-16 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21092/ --- (Updated May 7, 2014, 9:19 p.m.) Review request for mesos and Ben Mahler. Cha

Re: Review Request 21246: Fixed Protobuf to JSON serialization of optional fields with default values.

2014-05-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21246/#review42557 --- Bad patch! Reviews applied: [21246] Failed command: git apply --in

Review Request 21501: Added elected time to master's web ui.

2014-05-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21501/ --- Review request for mesos, Dominic Hamon and Jiang Yan Xu. Bugs: MESOS-1358

[jira] [Commented] (MESOS-1355) Use of untrusted string value in jvm.cpp

2014-05-16 Thread Timothy St. Clair (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999881#comment-13999881 ] Timothy St. Clair commented on MESOS-1355: -- False positive imho, let me know if y

Re: [VOTE] Release Apache Mesos 0.18.2 (rc1)

2014-05-16 Thread Till Toenshoff
+1 Fedora 20 (Heisenbug), g++ (GCC) 4.8.2 20131212 (Red Hat 4.8.2-7) Ubuntu 13.10, g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1 OSX 10.9.2, Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn) configure && make check => all passed

Re: MESOS-695 / Automated self-healing and coordinated repair to Mesos

2014-05-16 Thread Jeff Currier
+Charlie Tom, Charlie is heading up this work now so he can likely better speak to what's taking place on this ticket then I can at the moment. --Jeff-- On Fri, May 16, 2014 at 9:05 AM, Tom Arnfeld wrote: > Hi all, > > Wasn’t sure if it was right to start this thread on the JIRA issue.. I > j

MESOS-695 / Automated self-healing and coordinated repair to Mesos

2014-05-16 Thread Tom Arnfeld
Hi all, Wasn’t sure if it was right to start this thread on the JIRA issue.. I just came across MESOS-695 (and what seems to be something almost finished!) about implementing some kind of self-healing mechanism in mesos, and also picked up on mentions of monit. From what I could tell based on t

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

2014-05-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21424/ --- (Updated May 16, 2014, 4:13 p.m.) Review request for mesos, Ben Mahler and Nikl

Re: Review Request 21182: Refactored ZooKeeperImpl into ZooKeeperProcess.

2014-05-16 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21182/#review42523 --- Ship it! I have drawn out the call sequences for the "recursion via

Re: Question on resource offers and framework failover

2014-05-16 Thread Benjamin Mahler
Thanks for providing more details! I'm not sure these two cases are any different. The TASK_INVALID_OFFER would model a terminal state for the task. Afterwards, one still has to generate a new "TaskInfo" in so far as the TaskID should not be re-used across launch requests. *For example, what if r

Re: Review Request 21081: [MESOS-1259]:Enrich the Java Docs in the src/java files. -- Scheduler.java

2014-05-16 Thread Bernardo Gomez Palacio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21081/ --- (Updated May 15, 2014, 8:57 p.m.) Review request for mesos and Mesos ReviewBot.

[jira] [Updated] (MESOS-764) Implement Master persistence using the Registrar.

2014-05-16 Thread Chris Lambert (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lambert updated MESOS-764: Epic Colour: ghx-label-6 > Implement Master persistence using the Registrar. > -

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2123

2014-05-16 Thread Apache Jenkins Server
See

Review Request 21175: Moved ReconcileTaskTest test to its own file.

2014-05-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21175/ --- Review request for mesos and Dominic Hamon. Bugs: MESOS-1320 https://issues

[jira] [Updated] (MESOS-1149) SlaveRecovery.Reboot test doesn't reap executor

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1149: -- Fix Version/s: 0.19.0 > SlaveRecovery.Reboot test doesn't reap executor > -

[jira] [Updated] (MESOS-1278) Add a perf_event isolator

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1278: -- Sprint: (was: Q2'14 Sprint 1) > Add a perf_event isolator > - > >

[jira] [Updated] (MESOS-1332) Improve Master and Slave metric names

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1332: -- Sprint: (was: Q2'14 Sprint 1) > Improve Master and Slave metric names > -

Re: Review Request 20958: Make execute in MesosContainerizer async signal safe.

2014-05-16 Thread Tobias Weingartner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review43231 --- In general, I'd love to see us actually print out either the errno v

Re: Review Request 21399: Added message counters for all messages types in Master.

2014-05-16 Thread Jiang Yan Xu
> On May 15, 2014, 10:42 a.m., Dominic Hamon wrote: > > src/master/master.hpp, line 498 > > > > > > I thought we decided on: > > > > messages_framework_register > > messages_framework_reregister > > me

Re: Review Request 21077: [MESOS-1259]:Enrich the Java Docs in the src/java files. -- ExecutorDriver.java

2014-05-16 Thread Bernardo Gomez Palacio
> On May 16, 2014, 4:13 p.m., Niklas Nielsen wrote: > > BTW It looks like you have a common diff for all the JavaDoc RR's - would > > you mind split up of pack in one review? :) Originally it was one review per file but apparently I don't know how to use the post-reviews.py since it applied th

[jira] [Commented] (MESOS-1339) Add "per-framework-principal" counters for all messages from a scheduler on Master

2014-05-16 Thread Yan Xu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1409#comment-1409 ] Yan Xu commented on MESOS-1339: --- [~adam-mesos] Yeah we anticipated this scenario and are not

Re: Review Request 21257: rbt runtime error fix and updated revision range usage for rbt 0.6+

2014-05-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21257/#review43226 --- Hmm. I tested this on a branch with two commits. Neither the diffs n

[jira] [Updated] (MESOS-1377) Update configuration documentation to reflect 0.19.0 master flags.

2014-05-16 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-1377: --- Summary: Update configuration documentation to reflect 0.19.0 master flags. (was: --work_dir

[jira] [Assigned] (MESOS-1376) CHECK failure in the Registrar

2014-05-16 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler reassigned MESOS-1376: -- Assignee: Benjamin Mahler > CHECK failure in the Registrar > --

Re: Review Request 21077: [MESOS-1259]:Enrich the Java Docs in the src/java files. -- ExecutorDriver.java

2014-05-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21077/#review43215 --- BTW It looks like you have a common diff for all the JavaDoc RR's -

Re: Review Request 21424: Fixed orphaned container handling in the ExternalContainerizer recover implementation.

2014-05-16 Thread Till Toenshoff
> On May 15, 2014, 12:58 a.m., Ben Mahler wrote: > > src/slave/containerizer/external_containerizer.cpp, line 267 > > > > > > state.get() will fail if state is none! Thanks, that is a bad one. - Till -

Re: Review Request 21257: rbt runtime error fix and updated revision range usage for rbt 0.6+

2014-05-16 Thread Steven Phung
> On May 15, 2014, 6:32 a.m., Vinod Kone wrote: > > can you run this script against a branch that has multiple commits and see > > if it works as expected? Just tried this out, things seem to work as expected. - Steven --- This is an a

Re: Review Request 21236: Fixed tasks reconciliation and added tests.

2014-05-16 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21236/#review42540 --- Ship it! Glad we found this bug! src/master/master.cpp

Re: Review Request 21443: Support for running `perf stat`.

2014-05-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21443/#review43141 --- src/linux/perf.hpp

[jira] [Created] (MESOS-1378) Contender cancel should check whether the membership is already cancelled.

2014-05-16 Thread Yan Xu (JIRA)
Yan Xu created MESOS-1378: - Summary: Contender cancel should check whether the membership is already cancelled. Key: MESOS-1378 URL: https://issues.apache.org/jira/browse/MESOS-1378 Project: Mesos I

[jira] [Created] (MESOS-1379) Provide a reconciliation mechanism for tasks unknown to the framework.

2014-05-16 Thread Benjamin Mahler (JIRA)
Benjamin Mahler created MESOS-1379: -- Summary: Provide a reconciliation mechanism for tasks unknown to the framework. Key: MESOS-1379 URL: https://issues.apache.org/jira/browse/MESOS-1379 Project: Mes

[jira] [Updated] (MESOS-1344) Add flags support for ACLs

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1344: -- Fix Version/s: 0.19.0 > Add flags support for ACLs > -- > > Key

Re: Review Request 20987: Added sanitize method to clean up potential metric names.

2014-05-16 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20987/ --- (Updated May 15, 2014, 11:04 a.m.) Review request for mesos and Ben Mahler. C

[jira] [Updated] (MESOS-184) Log has a space leak

2014-05-16 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler updated MESOS-184: -- Affects Version/s: 0.19.0 0.18.2 0.18.1

[jira] [Updated] (MESOS-1332) Improve Master and Slave metric names

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1332: -- Sprint: Q2'14 Sprint 2 > Improve Master and Slave metric names > -

[jira] [Updated] (MESOS-1285) metrics names shouldn't include problematic characters

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1285: -- Sprint: (was: Q2'14 Sprint 2) > metrics names shouldn't include problematic characters >

[jira] [Updated] (MESOS-1278) Add a perf_event isolator

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1278: -- Sprint: Q2'14 Sprint 2 > Add a perf_event isolator > - > > Key:

[jira] [Updated] (MESOS-1149) SlaveRecovery.Reboot test doesn't reap executor

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-1149: -- Sprint: Q2'14 Sprint 2 > SlaveRecovery.Reboot test doesn't reap executor >

[jira] [Updated] (MESOS-473) Freezer fails fatally when it is unable to write 'FROZEN' to freezer.state

2014-05-16 Thread Vinod Kone (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinod Kone updated MESOS-473: - Sprint: (was: Q2'14 Sprint 1) > Freezer fails fatally when it is unable to write 'FROZEN' to freezer.sta

[jira] [Resolved] (MESOS-1376) CHECK failure in the Registrar

2014-05-16 Thread Benjamin Mahler (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler resolved MESOS-1376. Resolution: Fixed {noformat} commit 299fe28dc66ca9f9a72bf07205c07f1025a7981a Author: Benjam

  1   2   3   >