Re: Scanning for annotated classes in MyFaces 2

2009-01-11 Thread Simon Kitching
On Sat, 2009-01-10 at 19:56 -0700, Matthias Wessendorf wrote: > On Sat, Jan 10, 2009 at 11:21 AM, Jan-Kees van Andel > wrote: > > I don't think Scannotation itself is an issue, but it has a required > > dependency on Javassist, which has an LGPL license. Isn't that a > > problem? > > hrm, I think

RE: Scanning for annotated classes in MyFaces 2

2009-01-11 Thread Mario Ivankovits
Hi! > -Original Message- > From: Jan-Kees van Andel [mailto:jankeesvanan...@gmail.com] > Mario, I've been looking at the Shale code that handles the annotation > scanning, but I saw it uses Reflection and standard Java ClassLoaders > for scanning the classpath for JSF artifacts. What's you

Re: Scanning for annotated classes in MyFaces 2

2009-01-11 Thread Mark Struberg
Fwik Javassist uses a Mozilla Public License 1.1 not a pure LGPL (though I've not checked explicitly for the javassist version we use). MPL 1.1 is explicitly listed as appropriate license at least. Maybe we can kick scannotation, and do the scanning ourself (in a later phase). But Javassist is

RE: Scanning for annotated classes in MyFaces 2

2009-01-11 Thread Mario Ivankovits
Hi! > not sure on the PERF, but if it is really (proven) the case, I am with > you. > Well... startup time isn't really a big problem, right? :-) Is that ironic? In projects with 3000 classes and 60 jar files you are up to 30 seconds, or even more, scanning time. Under load, with shale, I saw sc

Re: Scanning for annotated classes in MyFaces 2

2009-01-11 Thread Simon Kitching
Yep, I should have checked the original statement. The javassist website here: http://www.jboss.org/javassist/ states clearly that: License: You can choose either MPL or LGPL. Surprising for a jboss project, but the website clearly says so. The MPL is no problem. So using Scannotation is also

Re: Scanning for annotated classes in MyFaces 2

2009-01-11 Thread Cagatay Civici
I've checked mojarra 2.0 some time ago to see how do they implemented this, well they're using reflection/class way. Spring's scanning mechanism also gives out of memory if you dont specify a sub package name to scan. So, my thought is to implement this in myfaces, it's not a complicated task as

Re: Scanning for annotated classes in MyFaces 2

2009-01-11 Thread Stephen Friedrich
My 2 cents: Don't load classes to use java.lang.reflect on it: - What if a class does something bad (or just about anything) in a static initializer? For example try to run the code below. It will EXIT THE VM - Can you be sure that those classes are unloaded again? - Performance: It is _faster

Re: Scanning for annotated classes in MyFaces 2

2009-01-11 Thread Matthias Wessendorf
On Sun, Jan 11, 2009 at 4:46 AM, Mario Ivankovits wrote: > Hi! > >> not sure on the PERF, but if it is really (proven) the case, I am with >> you. >> Well... startup time isn't really a big problem, right? :-) > > Is that ironic? ;-) I really hate to wait on the boot-up. :-) > In projects with