RE: [VOTE] Apache POI 3.15 (RC2)

2016-09-15 Thread Allison, Timothy B.
With the exception of the ppt master slide text, the content looks consistent across the POI file types. Found two bugs in my eval code, but no regressions that would hold up the release :)

RE: [VOTE] Apache POI 3.15 (RC2)

2016-09-15 Thread Allison, Timothy B.
r 15, 2016 9:15 AM To: POI Developers List Subject: Re: [VOTE] Apache POI 3.15 (RC2) Hi, The mem-leak patch looks good and sane! I am still not sure how they end up with such a large amount of allocated memory for one file, but it is surely better to not keep the buffers if we do not need th

RE: [VOTE] Apache POI 3.15 (RC2)

2016-09-15 Thread Allison, Timothy B.
I'm finally taking a look at the new exceptions from the reports. Most of the new exceptions seem to be on attachments within ppt. We recently changed how we handle embedded ole-wrapped attachments in ppt, and we're discovering new embedded file types. [1] Next...to look at the content report.

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-15 Thread Dominik Stadler
gt; Thank you, Andi! > > > -Original Message- > From: David North [mailto:dtn-...@corefiling.co.uk] > Sent: Thursday, September 15, 2016 4:16 AM > To: dev@poi.apache.org > Subject: Re: [VOTE] Apache POI 3.15 (RC2) > > OK, current status: > > * I'll take a l

RE: [VOTE] Apache POI 3.15 (RC2)

2016-09-15 Thread Allison, Timothy B.
who use HSLF about whether to hold up >> another RC for the issue below. > I've already patched the HSLF issue yesterday Thank you, Andi! -Original Message- From: David North [mailto:dtn-...@corefiling.co.uk] Sent: Thursday, September 15, 2016 4:16 AM To: dev@poi.apache.o

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-15 Thread kiwiwings
David North wrote > * I could do with input from those who use HSLF about whether to hold up > another RC for the issue below. I've already patched the HSLF issue yesterday, based on the placeholder being a metroblob shape, but I wanted to think about it, if this is really a good idea or if a diff

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-15 Thread David North
OK, current status: * I'll take a look at the patch on TIKA-2058, if it's low-risk it can go in * I could do with input from those who use HSLF about whether to hold up another RC for the issue below. I may not have time to roll RC3 tonight; if not I'll do it tomorrow night which gives us all the

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-14 Thread Javen O'Neal
The HSLF footer text regression is still open. https://bz.apache.org/bugzilla/show_bug.cgi?id=60003 https://issues.apache.org/jira/browse/TIKA-2013 On Sep 14, 2016 12:43 PM, "Dominik Stadler" wrote: > Hi, > > I'd also rather keep it as is to not break it multiple times. > > Dominik. > > On Wed,

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-14 Thread Dominik Stadler
Hi, I'd also rather keep it as is to not break it multiple times. Dominik. On Wed, Sep 14, 2016 at 4:23 AM, Javen O'Neal wrote: > CellValue#getCellType was changed to return an enum after the 3.14 release. > I reverted that signature change in r1760607 (see bug 59791 comment 13). > > For bug 5

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-14 Thread Dominik Stadler
Hi, I would rather look at using some tools like https://github.com/siom79/japicmp on the CI machine and check the output on a regular basis or fail the build if there are incompatible changes. This way we do not rely on having unit-tests for a method and the old source often will not compile any

RE: [VOTE] Apache POI 3.15 (RC2)

2016-09-14 Thread Allison, Timothy B.
Regression results are here. I haven't had a chance to look. This compares Tika's trunk with poi 3.15-rc1 (? I think?) against 3.15-beta1 in Tika 1.13. Some differences might be changes at the Tika level. I ran this against the full corpus so there are file formats we don't care about. http

RE: [VOTE] Apache POI 3.15 (RC2)

2016-09-14 Thread Allison, Timothy B.
t: Tuesday, September 13, 2016 12:09 PM To: POI Developers List Subject: Re: [VOTE] Apache POI 3.15 (RC2) Thanks - sounds good. I guess I'd better change my +1 to a -1 and try to build a fresh RC tomorrow night. On 13/09/16 17:06, Javen O'Neal wrote: > I will commit a fix for this today with

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-14 Thread Javen O'Neal
I read through all the commits mentioned in the bugs that block bug 59836. These changes, excluding ClientAnchor.getAnchorType(), were made after the release of POI 3.14, so I could safely revert back to the original getter behavior. I have left ClientAnchor.getAnchorType() returning AnchorType enu

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-13 Thread Javen O'Neal
CellValue#getCellType was changed to return an enum after the 3.14 release. I reverted that signature change in r1760607 (see bug 59791 comment 13). For bug 59907, I broke backwards compatibility for ClientAnchor (both HSSF and XSSF) in r1716313 (first appeared in POI 3.14 beta 1 and included in P

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-13 Thread Javen O'Neal
Could we do some checks for backwards compatibility? We need to test an application written for a previous version of POI that exercises most or all of the features, and what better than to use the unit tests from a previous release plus the latest source code? This will include false positives suc

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-13 Thread Aram Mirzadeh
$ ant -v Apache Ant(TM) version 1.9.4 compiled on April 29 2014 Trying the default build file: build.xml This is on a windows machine though so it may have some specific non-os specific paths in the tests. Which I still have not looked at. On Mon, Sep 12, 2016 at 10:34 PM, Javen O'Neal wrote:

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-13 Thread David North
Thanks - sounds good. I guess I'd better change my +1 to a -1 and try to build a fresh RC tomorrow night. On 13/09/16 17:06, Javen O'Neal wrote: > I will commit a fix for this today with the goal for backwards > compatibility. > > Here's the plan: > getX() returns int > getXEnum() returns enum >

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-13 Thread Javen O'Neal
I will commit a fix for this today with the goal for backwards compatibility. Here's the plan: getX() returns int getXEnum() returns enum setX(int) setX(enum) I will also take a look at bug 59907 (client anchor enum) On Sep 13, 2016 6:58 AM, "David North" wrote: > Javen, any thoughts on this o

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-13 Thread David North
Javen, any thoughts on this one? On 13/09/16 12:14, Dominik Stadler wrote: > Hi, > > I really hate to delay this further, but unfortunately we have a similar > problem in class CellValue as we tried to fix in Cell in RC2, the > getCellType() is now an enum whereas it was an int before, so somethi

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-13 Thread Dominik Stadler
Hi, I really hate to delay this further, but unfortunately we have a similar problem in class CellValue as we tried to fix in Cell in RC2, the getCellType() is now an enum whereas it was an int before, so something like the following in user-code does break in POI 3.15: CellValue cellValue = chec

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-12 Thread Javen O'Neal
What version of Ant are you using to build POI and run the unit tests? It's working fine on my computer with Ant 1.9.6. On Sep 12, 2016 14:42, "Aram Mirzadeh" wrote: > > I sort of ran this on the run, so haven't had a chance to look at it yet > but if github is up to date, scratchpad failed with:

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-12 Thread Javen O'Neal
hy B. > wrote: > > > Kicked off regression tests. Should have results by tomorrow. > > > > -Original Message- > > From: David North [mailto:dno...@apache.org] > > Sent: Sunday, September 11, 2016 3:47 PM > > To: POI Developers List > > Subjec

Re: [VOTE] Apache POI 3.15 (RC2)

2016-09-12 Thread Aram Mirzadeh
1, 2016 3:47 PM > To: POI Developers List > Subject: [VOTE] Apache POI 3.15 (RC2) > > Hi everyone, > > My apologies for going AWOL in the middle of the last release attempt. I > didn't anticipate that we'd find problems in review twice in a row, and > things have b

RE: [VOTE] Apache POI 3.15 (RC2)

2016-09-12 Thread Allison, Timothy B.
Kicked off regression tests. Should have results by tomorrow. -Original Message- From: David North [mailto:dno...@apache.org] Sent: Sunday, September 11, 2016 3:47 PM To: POI Developers List Subject: [VOTE] Apache POI 3.15 (RC2) Hi everyone, My apologies for going AWOL in the middle

[VOTE] Apache POI 3.15 (RC2)

2016-09-11 Thread David North
Hi everyone, My apologies for going AWOL in the middle of the last release attempt. I didn't anticipate that we'd find problems in review twice in a row, and things have been very busy for me at work lately. However, I've now rolled a second RC for 3.15. https://dist.apache.org/repos/dist/dev/poi