Re: About socklen_t

2009-02-26 Thread Manuel Teira Paz
Alan Conway escribió: Manuel Teira Paz wrote: Hello again. During the compilation stage of the trunk, I run into this error: source='qpid/broker/Bridge.cpp' object='qpid/broker/Bridge.lo' libtool=yes \ DEPDIR=.deps depmode=dashXmstdout /bin/bash ../build-aux/depcomp \ /bin/bash ../libtoo

Re: Release Schedule

2009-02-26 Thread Manuel Teira Paz
Steve Huston escribió: The dates for each phase would be as follows: End of Development : 2009-03-02 End of Feature Freeze : 2009-03-16 Release : 2009-03-27 This was the last set of dates Martin had put up for 0.5 release. I suspect that it is still worth putting a 0.5 as quite a lot

[jira] Assigned: (QPID-1698) jmx management console confirmation dialogues confusingly have 3 choices

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell reassigned QPID-1698: Assignee: Martin Ritchie (was: Robert Gemmell) Martin, can you review this change please, t

[jira] Updated: (QPID-1698) jmx management console confirmation dialogues confusingly have 3 choices

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1698: - Status: Ready To Review (was: In Progress) > jmx management console confirmation dialogues confus

[jira] Created: (QPID-1698) jmx management console confirmation dialogues confusingly have 3 choices

2009-02-26 Thread Robert Gemmell (JIRA)
jmx management console confirmation dialogues confusingly have 3 choices Key: QPID-1698 URL: https://issues.apache.org/jira/browse/QPID-1698 Project: Qpid Issue Type: B

[jira] Assigned: (QPID-1682) Make it easier to distinguish success and failure dialogues.

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell reassigned QPID-1682: Assignee: Martin Ritchie (was: Robert Gemmell) Martin, can you review this change please, t

[jira] Updated: (QPID-1682) Make it easier to distinguish success and failure dialogues.

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1682: - Status: Ready To Review (was: In Progress) > Make it easier to distinguish success and failure di

Re: Qpid Graduation release

2009-02-26 Thread Sander Striker
On Wed, Feb 18, 2009 at 4:17 PM, Sally Khudairi wrote: > Thanks, Carl. > > Wow -- this is really thorough! Indeed. > I'll run through this and forward suggested edits, if any. We'll also need a > few days to review it within the PRC; hopefully it can be announced early > next week. Looks good

[jira] Updated: (QPID-1681) jmx management console outputs type of every notification recieved to stdout, with a null object name

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1681: - Status: Ready To Review (was: In Progress) > jmx management console outputs type of every notific

[jira] Assigned: (QPID-1681) jmx management console outputs type of every notification recieved to stdout, with a null object name

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell reassigned QPID-1681: Assignee: Martin Ritchie (was: Robert Gemmell) Martin, can you review this change please.

Re: Release Schedule

2009-02-26 Thread Carl Trieloff
Alan Conway wrote: Steve Huston wrote: The dates for each phase would be as follows: End of Development : 2009-03-02 End of Feature Freeze : 2009-03-16 Release : 2009-03-27 This was the last set of dates Martin had put up for 0.5 release. I suspect that it is still worth putting a 0.5 as qu

[jira] Assigned: (QPID-1697) dont show admin mbeans in the navigation tree if the user doesnt have permission to access them

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell reassigned QPID-1697: Assignee: Martin Ritchie (was: Robert Gemmell) Hi Martin, can you review this change please

[jira] Updated: (QPID-1697) dont show admin mbeans in the navigation tree if the user doesnt have permission to access them

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1697: - Status: Ready To Review (was: In Progress) > dont show admin mbeans in the navigation tree if the

[jira] Assigned: (QPID-1679) Do not show Notification areas for MBeans which do not send Notifications

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell reassigned QPID-1679: Assignee: Martin Ritchie (was: Robert Gemmell) Hi Martin, can you review this change please

[jira] Updated: (QPID-1679) Do not show Notification areas for MBeans which do not send Notifications

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1679: - Status: Ready To Review (was: In Progress) > Do not show Notification areas for MBeans which do n

[jira] Assigned: (QPID-1615) [JMX Console] server navigation tree generates a runtime exception on first use

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell reassigned QPID-1615: Assignee: Martin Ritchie (was: Robert Gemmell) Hi Martin, can you take a look at this pleas

[jira] Updated: (QPID-1615) [JMX Console] server navigation tree generates a runtime exception on first use

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1615: - Status: Ready To Review (was: In Progress) > [JMX Console] server navigation tree generates a run

Re: Release Schedule

2009-02-26 Thread Alan Conway
Steve Huston wrote: The dates for each phase would be as follows: End of Development : 2009-03-02 End of Feature Freeze : 2009-03-16 Release : 2009-03-27 This was the last set of dates Martin had put up for 0.5 release. I suspect that it is still worth putting a 0.5 as quite a lot of fixes h

Re: About socklen_t

2009-02-26 Thread Alan Conway
Manuel Teira Paz wrote: Hello again. During the compilation stage of the trunk, I run into this error: source='qpid/broker/Bridge.cpp' object='qpid/broker/Bridge.lo' libtool=yes \ DEPDIR=.deps depmode=dashXmstdout /bin/bash ../build-aux/depcomp \ /bin/bash ../libtool --tag=CXX--mode=comp

[jira] Assigned: (QPID-1615) [JMX Console] server navigation tree generates a runtime exception on first use

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell reassigned QPID-1615: Assignee: Robert Gemmell > [JMX Console] server navigation tree generates a runtime exceptio

[jira] Updated: (QPID-1691) Create Linux x86-64 and Solaris builds of the JMX Management Console

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1691: - Assignee: Robert Gemmell > Create Linux x86-64 and Solaris builds of the JMX Management Console >

[jira] Updated: (QPID-1694) jmx console saves its settings ini file direcly in the user home directory

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1694: - Assignee: Robert Gemmell > jmx console saves its settings ini file direcly in the user home direct

[jira] Updated: (QPID-1680) Remove the fixed value 'domain' option from the add connection dialogue, and node form the navigation tree

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1680: - Assignee: Robert Gemmell Priority: Minor (was: Major) > Remove the fixed value 'domain' optio

[jira] Updated: (QPID-1679) Do not show Notification areas for MBeans which do not send Notifications

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1679: - Assignee: Robert Gemmell > Do not show Notification areas for MBeans which do not send Notificatio

[jira] Updated: (QPID-1697) dont show admin mbeans in the navigation tree if the user doesnt have permission to access them

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1697: - Assignee: Robert Gemmell > dont show admin mbeans in the navigation tree if the user doesnt have

[jira] Updated: (QPID-1682) Make it easier to distinguish success and failure dialogues.

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1682: - Assignee: Robert Gemmell Priority: Minor (was: Major) > Make it easier to distinguish success

[jira] Updated: (QPID-1681) jmx management console outputs type of every notification recieved to stdout, with a null object name

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1681: - Assignee: Robert Gemmell > jmx management console outputs type of every notification recieved to s

[jira] Updated: (QPID-1696) remove unused 'transport' details from jmx management console's connection process

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1696: - Assignee: Robert Gemmell Priority: Minor (was: Major) > remove unused 'transport' details fro

[jira] Updated: (QPID-1683) 'Next' and 'Previous' type buttons are in the wrong order for areas providing TabularData viewing

2009-02-26 Thread Robert Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Gemmell updated QPID-1683: - Assignee: Robert Gemmell Priority: Minor (was: Major) > 'Next' and 'Previous' type buttons ar

[jira] Created: (QPID-1697) dont show admin mbeans in the navigation tree if the user doesnt have permission to access them

2009-02-26 Thread Robert Gemmell (JIRA)
dont show admin mbeans in the navigation tree if the user doesnt have permission to access them --- Key: QPID-1697 URL: https://issues.apache.org/jira/browse/QPID-1697

Re: [c++] Use of @$(ECHO) in generation of example Makefiles

2009-02-26 Thread Nuno Santos
Alan Conway wrote: Gordon Sim wrote: Apparently the ECHO variable is undocumented and is no longer available in the latest versions of autotools. It is used in the generation of simple Makefiles for the examples. We can just use echo Another alternative, if needed, is to declare ECHO before

RE: Release Schedule

2009-02-26 Thread Steve Huston
> > The dates for each phase would be as follows: > > > > End of Development : 2009-03-02 > > End of Feature Freeze : 2009-03-16 > > Release : 2009-03-27 > > > > This was the last set of dates Martin had put up for 0.5 release. I > suspect that > it is still worth putting a 0.5 as quite a lot

Re: Release Schedule

2009-02-26 Thread Carl Trieloff
The dates for each phase would be as follows: End of Development : 2009-03-02 End of Feature Freeze : 2009-03-16 Release : 2009-03-27 This was the last set of dates Martin had put up for 0.5 release. I suspect that it is still worth putting a 0.5 as quite a lot of fixes have been made si

Re: [c++] Use of @$(ECHO) in generation of example Makefiles

2009-02-26 Thread Alan Conway
Gordon Sim wrote: Apparently the ECHO variable is undocumented and is no longer available in the latest versions of autotools. It is used in the generation of simple Makefiles for the examples. The question is, can we just use 'echo' directly? Or was there an issue with that when these were c

[jira] Resolved: (QPID-1695) LVQ does not persist messages

2009-02-26 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-1695. -- Resolution: Fixed Fixed in r748214. > LVQ does not persist messages > - > >

[jira] Created: (QPID-1696) remove unused 'transport' details from jmx management console's connection process

2009-02-26 Thread Robert Gemmell (JIRA)
remove unused 'transport' details from jmx management console's connection process -- Key: QPID-1696 URL: https://issues.apache.org/jira/browse/QPID-1696 Project: Qpid

[jira] Created: (QPID-1695) LVQ does not persist messages

2009-02-26 Thread Gordon Sim (JIRA)
LVQ does not persist messages - Key: QPID-1695 URL: https://issues.apache.org/jira/browse/QPID-1695 Project: Qpid Issue Type: Bug Components: C++ Broker Affects Versions: M4 Reporter: Gor

Re: Welcome Robbie as committer.

2009-02-26 Thread Andrea Gazzarini
Benvenuto a bordo Robbie! Regards Andrea On 2/26/09, Carl Trieloff wrote: > > Robbie was nominated for committer to Qpid, voted in and he accepted. A > warm welcome > to the committer pool and thank you for your continued contributions to > the project. > > Robbie, > > For more details of commit

Welcome Robbie as committer.

2009-02-26 Thread Carl Trieloff
Robbie was nominated for committer to Qpid, voted in and he accepted. A warm welcome to the committer pool and thank you for your continued contributions to the project. Robbie, For more details of committership please see: http://www.apache.org/dev/committers.html If you have any questio

[jira] Created: (QPID-1694) jmx console saves its settings ini file direcly in the user home directory

2009-02-26 Thread Robert Gemmell (JIRA)
jmx console saves its settings ini file direcly in the user home directory -- Key: QPID-1694 URL: https://issues.apache.org/jira/browse/QPID-1694 Project: Qpid Issue Typ

[Fwd: Proposal for improved URL syntax.]

2009-02-26 Thread Alan Conway
I've added this proposal to the wiki at http://cwiki.apache.org/qpid/url-format-proposal.html It was sent to the AMQP working group on 02/18/2009 --- Begin Message --- * Proposed URL syntax This proposal extends the AMQP 0-10 URL syntax to include user:pass@ style authentication information, v

The linker curse (revisited)

2009-02-26 Thread Manuel Teira Paz
A new chapter about linking oddities in the solaris port, asking for advise, comments or ideas. I've identified two problems or differences in the way the combo gcc/binutils works, compared with SunStudio12/SunLinker: 1.-Implicit dependencies. GNU ld follows implicit dependencies (meaning tha

Re: Help with an strange error

2009-02-26 Thread Manuel Teira Paz
Manuel Teira Paz escribió: Hello. During the compilation of the c++ client, I've hit an error I'm not able to figure out what could be the cause: CC -g -m64 -DHAVE_CONFIG_H -I. -Igen -I./gen -DMODULE_DIR=\"/opt/qpid/lib/qpid/client\" -DCONF_FILE=\"/opt/qpid/etc/qpid/qpidc.conf\" -I/opt/qpid

[jira] Commented: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676981#action_12676981 ] Danushka Menikkumbura commented on QPID-1673: - Hi Steve, Please apply the attac

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-src-qpid-sys.v2.patch QPID-1673-src-qpid-manage

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-src-qpid-client.v2.patch > Dynamic Library Build on Windows (D

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-src-qpid-framing.v2.patch > Dynamic Library Build on Windows (

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-src-qpid-amqp_0_10.v2.patch > Dynamic Library Build on Windows

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-src-qpid.v2.patch > Dynamic Library Build on Windows (DLL) > -

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-rubygen.v2.patch > Dynamic Library Build on Windows (DLL) > --

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-src.v2.patch > Dynamic Library Build on Windows (DLL) > --

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-INSTALL-WINDOWS.v2 > Dynamic Library Build on Windows (DLL) >

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-examples-solution.v2.patch > Dynamic Library Build on Windows

[jira] Updated: (QPID-1673) Dynamic Library Build on Windows (DLL)

2009-02-26 Thread Danushka Menikkumbura (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danushka Menikkumbura updated QPID-1673: Attachment: QPID-1673-qpid-solution.v2.patch > Dynamic Library Build on Windows (DLL

Help with an strange error

2009-02-26 Thread Manuel Teira Paz
Hello. During the compilation of the c++ client, I've hit an error I'm not able to figure out what could be the cause: CC -g -m64 -DHAVE_CONFIG_H -I. -Igen -I./gen -DMODULE_DIR=\"/opt/qpid/lib/qpid/client\" -DCONF_FILE=\"/opt/qpid/etc/qpid/qpidc.conf\" -I/opt/qpid/include -library=stlport4 -

[jira] Assigned: (QPID-1637) Update AMQPriorityQueue, potentially creating Purger thread

2009-02-26 Thread Martin Ritchie (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Ritchie reassigned QPID-1637: Assignee: Martin Ritchie > Update AMQPriorityQueue, potentially creating Purger thread > ---

[jira] Resolved: (QPID-1693) Several improvements to cpp/src/tests/failover_soak.cpp

2009-02-26 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-1693. -- Resolution: Fixed Assignee: Gordon Sim Applied as r748081. > Several improvements to cpp/src/tes

[jira] Created: (QPID-1693) Several improvements to cpp/src/tests/failover_soak.cpp

2009-02-26 Thread michael j. goulish (JIRA)
Several improvements to cpp/src/tests/failover_soak.cpp -- Key: QPID-1693 URL: https://issues.apache.org/jira/browse/QPID-1693 Project: Qpid Issue Type: Improvement Compone

[jira] Updated: (QPID-1693) Several improvements to cpp/src/tests/failover_soak.cpp

2009-02-26 Thread michael j. goulish (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] michael j. goulish updated QPID-1693: - Attachment: failover_soak_improvements.diff > Several improvements to cpp/src/tests/failo

[jira] Commented: (QPID-1692) Set the sync bit periodically to force the broker to send completions

2009-02-26 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676911#action_12676911 ] Gordon Sim commented on QPID-1692: -- Setting the sync bit will impact performance (at least