Re: State of affairs for mod_jk 1.2.20

2006-11-24 Thread Mladen Turk
Rainer Jung wrote: In my opinion the only change is: - old code: retries=2 means first try to close all conns and second try with new connection - new code: retries=2 means first try to close all conns and immediate new conn, second try a "real" retry. Right, and that is the problem. With re

Re: svn commit: r479316 [2/2] - /tomcat/connectors/trunk/jk/native/common/jk_status.c

2006-11-26 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Modified: tomcat/connectors/trunk/jk/native/common/jk_status.c URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_status.c?view=diff&rev=479316&r1=479315&r2=479316 == -

Re: svn commit: r479321 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2006-11-26 Thread Mladen Turk
Rainer Jung wrote: since this has already been out in the wild for a few month, You are right. I've reverted the commit. I thought it was introduced more recently. The name should be fine, although it is a little bit strange (route or jvmroute would fit better thought) Regards, Mladen. -

Re: svn commit: r479317 - in /tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp: AjpAprProcessor.java AjpProcessor.java Constants.java

2006-11-26 Thread Mladen Turk
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: +Integer i = responseTransHash.get(header.toLowerCase(Locale.US)); -0. The String operations take away any benefit this could have. Perhaps for CPU usage on the Tomcat, that is annihilated by the lower processing on the mod_jk side. Als

Tomcat web site admin problems.

2006-11-28 Thread Mladen Turk
Remy, Can you change the permissions for the files in /x1/www/tomcat.apache.org/tomcat-6.0-doc-v6.0.2 from 0644 to 0664? Add group write permission, so other can modify the docs. I know, it's a version related, but we should not create a new tag if there is error in the docs thought. Regards, M

[TC6] Minimum coding style

2006-11-28 Thread Mladen Turk
Hi, Just committed two files, and again I've bumped upon the coding style. Although it seems we are quite good relating to the tabs, the trailing spaces are a real mess in some files. There are lots of files where we have if (...) { followed with the one or more spaces. Also there are lots empty

Re: [TC6] Minimum coding style

2006-11-28 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: Comments? -1. This will screw up diffs, and these really irrelevant things will be added back very quickly. Tabs is one thing since it can be hard to work with, but this is simply ridiculous. Right, but at least the empty lines with spaces are

Re: [TC6] Minimum coding style

2006-11-28 Thread Mladen Turk
Remy Maucherat wrote: -1 for enforcing any coding style (except tabs, since it can make code unreadable very easily). You must be joking, right? Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: [TC6] Minimum coding style

2006-11-28 Thread Mladen Turk
Henri Gomez wrote: I remember the cold days of the 'Tab brigade' :) Right. Anyhow, the point of my post was 'minimal', and removing the trailing spaces. It seems that the trailing spaces are very important, so fine with me. Cheers, Mladen. --

Re: svn commit: r480552 - in /tomcat/tc6.0.x/trunk: java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/config/

2006-11-29 Thread Mladen Turk
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Wed Nov 29 04:26:37 2006 New Revision: 480552 URL: http://svn.apache.org/viewvc?view=rev&rev=480552 Log: Commit the voted keepAliveTimeout patch. It is still as bad as what the original version was. -1 for this, +0 for my mod

Re: svn commit: r480558 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/core/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2006-11-29 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: remm -timeout = keepAliveTimeout * 50; +timeout = soTimeout * 50; -sendfilePollset = allocatePoller(size, pool, keepAliveTimeout); +sendfilePollset = allocatePoller(size, pool, soTimeout); -

Re: svn commit: r480558 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/core/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2006-11-29 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: Looks like we can do few things: 1. Revert your patch 2. Revert mine patch 3. Go on and forget all about programming, and do some shepherding. So, please, unless you are going to adopt 3), revert your patch for my patch. You know, Tomcat is not your

Re: svn commit: r480558 - in /tomcat/tc6.0.x/trunk/java/org/apache: catalina/core/ coyote/ajp/ coyote/http11/ tomcat/util/net/

2006-11-29 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: Further more I collected enough votes, so your explanation is useless. I am free to commit things, especially since I actually fixed some of your patch. You are free to veto my commit, in which case it would be time to take this to the PMC for

Re: [VOTE] Tomcat 6.0.3 alpha release

2006-12-04 Thread Mladen Turk
+1 BTW, Can we make minimum native version required for 6.0.x to 1.1.7 (It's 1.1.3 right now copied from 5.5.x)? I mean there was no released versions of 6.0, and the latest one has more stable API. Regards, Mladen. Remy Maucherat wrote: Hi, In line with what Filip wanted to have, I propose

Re: Smooth applications migration in a J2EE cluster [mod_jk]

2006-12-05 Thread Mladen Turk
Anthony Vromant wrote: Would it be possible to integrate such a feature in the original mod_jk ? If yes, we may contribute to the development by providing our code. There is no need to ask something like that. Just like for any other patch bring in the code, and we'll discuss, but it cannot

Re: svn commit: r481745 - in /tomcat/connectors/trunk/procrun/bin: tomcat5.exe tomcat5.exe.amd64 tomcat5w.exe tomcat5w.exe.amd64

2006-12-05 Thread Mladen Turk
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Sun Dec 3 01:49:18 2006 New Revision: 481745 URL: http://svn.apache.org/viewvc?view=rev&rev=481745 Log: Update binaries with --ServiceUser/ServicePassword option. Modified: tomcat/connectors/trunk/procrun/bin/tomcat5.exe

Re: svn commit: r482093 - /tomcat/connectors/trunk/jk/native/common/jk_status.c

2006-12-06 Thread Mladen Turk
Rainer Jung wrote: I think it's perfectly valid having to simply use "&" in URLs, no need to encode. On the other hand as long as we don't have a proper decoding for the incoming URLs and I don't know, if all supported web servers decode before putting the query string into our service struct,

Re: svn commit: r483021 - in /tomcat/connectors/trunk/jk: native/common/ xdocs/config/ xdocs/miscellaneous/

2006-12-06 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, the different notations confuse me: some parts use "retry_on_status", and some "http_status_fail". I think the implementation does "fail on configured status code", whereas the name of the config param suggests "retry=do not fail on configured status code". I w

Re: mod_jk release preparation: ready for test

2006-12-06 Thread Mladen Turk
Henri Gomez wrote: BTW, windows binaries are very welcome ! I'll prepare them later today, and hand them over to the Rainer. (Well I'll put them on my people.a.o) Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED]

Re: mod_jk release preparation: ready for test

2006-12-07 Thread Mladen Turk
Henri Gomez wrote: There is still a serious problem in jk 1.2.20 when flushing some large file (ie: PDF). Hard to tell without some test case and config files. What is the socket_timeout, what is the ServerTimeout? Regards, Mladen.

Re: mod_jk release preparation: ready for test

2006-12-07 Thread Mladen Turk
Henri Gomez wrote: FYI, when I disable use of Apr, the problem disappears. Does it works with AjpProtocol (not AjpAprProtocol) By default if native load fails, the JK connector is used, that is different then Ajp connector. Can you set the protocol="org.apache.coyote.ajp.AjpProtocol" and if is

Re: mod_jk release preparation: ready for test

2006-12-07 Thread Mladen Turk
="org.apache.coyote.ajp.AjpProtocol" This is not APR protocol, it plain Java! Regards, Mladen 2006/12/7, Mladen Turk <[EMAIL PROTECTED]>: Henri Gomez wrote: > FYI, when I disable use of Apr, the problem disappears. > Does it works with AjpProtocol (not AjpAprProtocol) By default if nat

Re: mod_jk release preparation: ready for test

2006-12-07 Thread Mladen Turk
Henri Gomez wrote: Used : So, it's either AjpAprProtocol or native fault. In any case its not mod_jk fault. Just file the BZ report. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-ma

Re: mod_jk release preparation: ready for test

2006-12-07 Thread Mladen Turk
Henri Gomez wrote: it's a seems to be a tomcat-native (1.1.7) problem And since we discuss Tomcat 6.0.4 release, should we consider that error as a show stopper ? No. It works quite fine on Solaris and RHEL, as well on HP-UX and Windows. I simply cannot reproduce this problem. Regards, Mlade

Re: [VOTE] Tomcat 6.0.4 alpha build

2006-12-07 Thread Mladen Turk
+1 Remy Maucherat wrote: Replacing the 6.0.3 tag, with fixes for the visible glitches: http://people.apache.org/~remm/tomcat-6/v6.0.4/ Votes ? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail:

[OT] Windows cmd parsing

2006-12-08 Thread Mladen Turk
Hi, If anyone has access to the Windows 2000 or Windows NT 4.0 (I have 2k3 and XP, so I know its working), can you do the following: Open cmd.exe C:> set "FOO=FOO BAR" C:> echo %FOO% And give me the output? The problem is that I'm not sure how pre-XP handles the SET directive is there is a sing

Re: [OT] Windows cmd parsing

2006-12-08 Thread Mladen Turk
Fenlason, Josh wrote: Microsoft Windows 2000 [Version 5.00.2195] (C) Copyright 1985-2000 Microsoft Corp. C:\Documents and Settings\stagecoach>set "FOO=FOO BAR" C:\Documents and Settings\stagecoach>echo %FOO% FOO BAR Excellent, so it works on 2K as well! Thanks, Mladen.

Tagging tomcat-native 1.1.8

2006-12-11 Thread Mladen Turk
Hi, I'll tag the 1.1.8 later today and put the distro files in regular places, so they can be used for Tomcat builds. BTW, can we again consider to use the minimum version required to that version (1.1.8). Although the API is compatible with 1.1.3 version, the all versions between 1.1.3 and 1.1.

Re: Tagging tomcat-native 1.1.8

2006-12-11 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: My little tweak will most likely be ported back to 5.5.x. As a result, when you install a new build, you'll get a warning, and the code will not use the problematic method by default. As a result, the forced upgrade is a waste of time for most.

Re: mod_jk 1.2.20 max_packet_size handling

2006-12-12 Thread Mladen Turk
Peter Rossbach wrote: Hi Rainer and Mladen, I made the paketSize port to tomcat 5.5 tree. Now, I start some testing and ... OK. Although it's not that important. It worked already via APR connector. - second use case: Test a post file upload mod_jk don't send more then 8k at a fileupload

Re: [6] New wrap up release

2006-12-14 Thread Mladen Turk
Remy Maucherat wrote: Hi, I plan to produce a new build of Tomcat 6 incorporating the latest fixes (including a new native build). Comments ? Can you hold on for few hours (15:00 GMT) ? I've just tagged the 1.1.8, so it'll need couple of hours to sync. I'd also like to add the [INFO] loggin

Re: Tagging tomcat-native 1.1.8

2006-12-14 Thread Mladen Turk
Peter Rossbach wrote: Hi I have test to compile apr at mac os x 10.4..8 intel and get following warning: src/network.c:449: warning: pointer targets in passing argument 2 of 's->net->send' differ in signedness OK. This should be resolved. Rely don't understand the vast universe of compil

Re: Serious mod_jk performance issue

2006-12-14 Thread Mladen Turk
Jess Holle wrote: > We're seeing a *serious *performance issue with mod_jk and large (e.g. 500MB+) file transfers. [This is with Apache 2.0.55, Tomcat 5.0.30, and various recent mod_jk including 1.2.20.] SunOS dev12.qa.atl.jboss.com 5.9 Generic_118558-25 sun4u sparc SUNW,Sun-Fire-V210 Tomcat

Re: [6] New wrap up release

2006-12-14 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: I've just tagged the 1.1.8, so it'll need couple of hours to sync. I'd also like to add the [INFO] logging for APR with version used when loaded successfully. I am aware of that. It would have been a bit hard to miss given the noi

Re: svn commit: r487168 - /tomcat/tc6.0.x/trunk/res/side_left.bmp

2006-12-16 Thread Mladen Turk
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Thu Dec 14 02:42:33 2006 New Revision: 487168 URL: http://svn.apache.org/viewvc?view=rev&rev=487168 Log: More artwork Modified: tomcat/tc6.0.x/trunk/res/side_left.bmp Your new bitmap does not look good to me: it's stretch

Re: [VOTE] Releasing Tomcat Connectors 1.2.20

2006-12-16 Thread Mladen Turk
Rainer Jung wrote: Apache Tomcat Connectors 1.2.20 is: [X] Stable - no major issues, no regressions Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.6 as alpha

2006-12-16 Thread Mladen Turk
Remy Maucherat wrote: Hi, The vote is to release Apache Tomcat 6.0.6 as alpha. The build is located here: http://people.apache.org/~remm/tomcat-6/v6.0.6/ Votes ? The .exe installer looks really weired due to my fault because I forget to rotate the left side image :( Can you just rebuild the

Re: [VOTE] Release build 6.0.6 as alpha

2006-12-16 Thread Mladen Turk
Remy Maucherat wrote: The .exe installer looks really weired due to my fault because I forget to rotate the left side image :( Can you just rebuild the exe without retaging? The build is supposed to correspond to the tag, so it's not possible to fix it without a new tag. I supposed it wou

Re: tcnative 1.1.8 -- offically released as stable?

2007-01-03 Thread Mladen Turk
Jess Holle wrote: Has tcnative 1.1.8 been officially released, i.e. as stable? There is no vote on tcnative releases. The vote is part of Tomcat release. It seemed like it was going to be from various votes, etc -- but I never saw any form of announcement. Given the serious issues in a num

Re: tcnative 1.1.8 -- offically released as stable?

2007-01-03 Thread Mladen Turk
Fenlason, Josh wrote: Since there is no vote on tcnative, is it always safe to say that the latest native source available in http://archive.apache.org/dist/tomcat/tomcat-connectors/native/ is as close to "official" or "stable" as it's going to get? Will tcnative 1.1.8 work with Tomcat 5.5.20?

Re: libtcnative configure check for apr version

2007-01-04 Thread Mladen Turk
William L. Thomson Jr. wrote: If possible could the configure script for tomcat-native/libtcnative check for apr versions. I wasted quite some time with a libtcnative I compiled against apr 0.x instead of 1.x. Which allowed it to build, but was really tiny and not usable. If the configure checke

Re: new access log valve implementation

2007-01-05 Thread Mladen Turk
Takayuki Kaneko wrote: Is this beneficial? I doubt. The same could be done by simply buffering the log and then flushing to the disk on overflow. Is it beneficial? No, its misleading, because you will never know if your log data is the correct one or there is something in the write buffer wai

Re: [VOTE] Tomcat 6.0.7

2007-01-08 Thread Mladen Turk
Remy Maucherat wrote: Hi, 6.0.7 is: [ ] Alpha [x] Beta -- Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Discussion mod_jk and mod_dir interaction

2007-01-29 Thread Mladen Turk
Rainer Jung wrote: Hi, I want to find out how to correctly fix BZ 41430 and 36121. They have to do with the way mod_dir and mod_jk interact. Before fixing the code I find it necessary to define the correct behaviour, which seems to be non-trivial. It is very trivial. The mod_jk is proxy t

Re: Discussion mod_jk and mod_dir interaction

2007-01-30 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, Things like DirectoryIndex are completely useless and further more breaks the security, because the Tomcat must serve the default content. I simply don't understand, what this means functionally, i.e. how DirectoryIndex and ForwardDirectories should work with mo

Re: Discussion mod_jk and mod_dir interaction

2007-01-30 Thread Mladen Turk
Giampaolo Tomassoni wrote: Finally, it seems to me that mod_jk doesn't map a request to tomcat as a sub-request, but instead seems to tweek the req->main field, which may probably create the kind of problems reported in BZ 36121. I'm not an expert of the apache req structure nor of the mod_jk

Re: Discussion mod_jk and mod_dir interaction

2007-01-30 Thread Mladen Turk
Giampaolo Tomassoni wrote: Any other 'better' integration would probably require patching Apache core, and thats IMHO unfeasible by majority of users. Which one? Checking the 404 response? If mod_jk adopts sub-requests to Tomcat, why should Apache get patched? Or if you mean the JkMount direct

[OT] Problems with [EMAIL PROTECTED]

2007-01-31 Thread Mladen Turk
Hi, Few days ago I changed my email address for Tomcat Users List with standard unsubscribe/subscribe, and although I can receive messages, send messages, I cannot see the messages send by me. (mladen_dot_turk_at_gmail_dot_com) It looks others can see the messages I sent. They are even listed on

Re: [OT] Problems with [EMAIL PROTECTED]

2007-01-31 Thread Mladen Turk
Thanks Mark and Yoav! As I suspected, it is a 'trivial feature' of gmail :) Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: FYI: jk 1.2.20 core on iSeries v5R3

2007-01-31 Thread Mladen Turk
Henri Gomez wrote: Hi to all, I built and installed the jk 1.2.20 on iSeries i5/OS V5R3 Apache 2 server to replace the previous 1.2.19. Think there was some problem with wrong printf format. Rainer fixed that post 1.2.20, but he should know better. Regards, Mladen. -

Re: FYI: jk 1.2.20 core on iSeries v5R3

2007-01-31 Thread Mladen Turk
Eric Wertman wrote: Connector: JkWorkersFile conf/workers.properties JkShmFile logs/mod_jk.shm JkShmSize 8192 This is 8MB of shared memory. Are you sure you have 1 workers? JkLogFile logs/mod_jk.log JkLogLeveldebug Segmentation fault in sig_coredump at 0x10037590 0x1

Re: [VOTE] Release build 6.0.9 as alpha

2007-02-02 Thread Mladen Turk
Remy Maucherat wrote: Candidate binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.9/ Votes ? +1 Tested on Linux, Solaris, HP-UX and WIN64 Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED

Re: Let's get 5.5.21 out the door...

2007-02-02 Thread Mladen Turk
Yoav Shapira wrote: ... it's got a lot of good and important fixes in it. Filip, you up for cutting the release, say this weekend or early next week? ++1 -- Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: Let's get 5.5.21 out the door...

2007-02-02 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: yes, early next week, i'll email when I have a target time for the tag Anyhow, a thing like Remy is doing for 6.0 would be nice to have. It offers a build before official tag Can we have that for 5.5.12 as well? The RM can put 'what will be released' in his priv

Re: Let's get 5.5.21 out the door...

2007-02-02 Thread Mladen Turk
Remy Maucherat wrote: Mladen Turk wrote: Anyhow, a thing like Remy is doing for 6.0 would be nice to have. It offers a build before official tag Yes, and it is useless, and it makes the release procedure days longer. Thanks to this nonsense the release procedure now takes over two weeks

Re: svn commit: r507923 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c

2007-02-15 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Log: Fix bug in adding content-length header (BZ 41610). Analyzed and patch contributed by Boris Maras. if (need_content_length_header && -!strcasecmp(s->headers_values[i], "content-length")) { +!strcasecmp(s->head

Re: svn commit: r509173 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml xdocs/reference/apache.xml xdocs/webserver_howto/apach

2007-02-19 Thread Mladen Turk
[EMAIL PROTECTED] wrote: /* env_name is mandatory, default_value is optional. - * No value means set the variable to an empty string. + * No value means send the attribute only, if the env var is set during runtime. */ Think this will break any existing configuration. Some

Re: Releasing mod_jk 1.2.21

2007-02-22 Thread Mladen Turk
Jean-Frederic wrote: Hi, I think time as arrive to release 1.2.21. Are there pending changes? Or urgent ugly bugs? What about a date like Friday evening (GMT) for tagging? I don't think we'll be able to cut that before Monday. There are few pending things that needs to be ported across serve

Re: Releasing mod_jk 1.2.21

2007-02-23 Thread Mladen Turk
Rainer Jung wrote: What is still open: I would like to give A-C a chance until end of the week and would then This week or a next? We have a Security issue that requires release ASAP. Regards, Mladen. - To unsubscribe, e-m

Re: Releasing mod_jk 1.2.21

2007-02-23 Thread Mladen Turk
Jean-Frederic wrote: C Porting 41439 from IIS to Apache You want to remove sessionid=D5E2FE08F02400159DFD6231 11F98FEE.p-ng-ptom2 from /shoppingcc/img/btn_nav_main_login.gif;jsessionid=D5E2FE08F02400159DFD6231 11F98FEE.p-ng-ptom2 do it with mod_rewrite: RewriteRule ^/(.*).gif;jsessionid=.*$ /$

Re: Releasing mod_jk 1.2.21

2007-02-23 Thread Mladen Turk
Rainer Jung wrote: D New design of interaction of mod_jk ForwardDirectories and httpd DirectoryIndex (BZ 41430, BZ 36121) As I said so many times, any attempt to from DirectoryIndex that will force serving something that is not part of the Tomcat's welcome file list will be vetoed. I would s

Re: Releasing mod_jk 1.2.21

2007-02-23 Thread Mladen Turk
Rainer Jung wrote: Jean-Frederic wrote: On Fri, 2007-02-23 at 09:20 +0100, Rainer Jung wrote: What is still open: A Henri's core dumps on iSeries Wasn't it only a wrong printf? I doubt that very much, at the stack in his core didn't point to these statements. I'm still waiting for feedbac

Re: Releasing mod_jk 1.2.21

2007-02-23 Thread Mladen Turk
Rainer Jung wrote: Yes, but then you ignore the fact, that we already have such a functionality, and that we changed it's behaviour between 1.2.19 and 1.2.20. So at least we need to decide, if it's behaviour should be - disabled completely (breaking existing configs for all versions) My fa

Re: Releasing mod_jk 1.2.21

2007-02-23 Thread Mladen Turk
Jean-Frederic wrote: I also have the pending patch... To prevent typos in the properties no beeing detected what starting httpd. Should I include it? Looks like a good feature for unexperienced admins :) +1 Regards, Mladen. --

Re: Releasing mod_jk 1.2.21

2007-02-23 Thread Mladen Turk
Rainer Jung wrote: and we will get a lot of bug reports, if we break those. So I think all in all we should only check attributes beginning with "worker.". Right, good point. After all this is what matters. Regards, Mladen. ---

Re: svn commit: r511252 - in /tomcat/connectors/trunk/jk/native/iis: Makefile.amd64 Makefile.vc isapi.dsp jk_isapi_plugin.c

2007-02-24 Thread Mladen Turk
William A. Rowe, Jr. wrote: GOOD GOD you can't be serious :) strncat strncpy exist for a reason, C's been safe for decades if only the correct functions are chosen :) Didn't say it's wrong or something like that, but beside constantly fighting with hacking and suppressing newest MS compilers

Re: Releasing mod_jk 1.2.21

2007-02-26 Thread Mladen Turk
Jim Jagielski wrote: On Feb 23, 2007, at 1:10 PM, Jean-Frederic wrote: I also have the pending patch... To prevent typos in the properties no beeing detected what starting httpd. Should I include it? Sorry for the delay... unless it's too late, why the change from HTTP_INTERNAL_SERVER_ERR

Re: Tagging JK 1.2.21

2007-02-28 Thread Mladen Turk
Rainer Jung wrote: I'm travelin at the moment, otherwise I would have suggested to tag even earlier. Anyone planning to apply important changes to trunk before saturday, please show up now :) No changes. I would like to double check the IIS builds, but the testing will be done by Friday.

Re: [VOTE] Releasing Tomcat Connectors 1.2.21

2007-03-01 Thread Mladen Turk
Jean-Frederic wrote: Apache Tomcat Connectors 1.2.21 is: [X] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are --

Re: [ANN] Apache Tomcat JK 1.2.21 Web Server Connector released

2007-03-02 Thread Mladen Turk
Jean-Frederic wrote: Source distribtions can be downloaded from an Apache Software Foundation mirror at: http://tomcat.apache.org/download-connectors.cgi Can you fix the files to 664 in www.apache.org/dist for 1.2.21 ? Regards, Mladen. --

Re: [ANN] Apache Tomcat JK 1.2.21 Web Server Connector released

2007-03-02 Thread Mladen Turk
Jean-Frederic wrote: On Fri, 2007-03-02 at 17:34 +0100, Mladen Turk wrote: Jean-Frederic wrote: Source distribtions can be downloaded from an Apache Software Foundation mirror at: http://tomcat.apache.org/download-connectors.cgi Can you fix the files to 664 in www.apache.org/dist for 1.2.21

Re: JK2 confusion

2007-03-03 Thread Mladen Turk
William A. Rowe, Jr. wrote: Since JK2 is now off the map, does it make sense to update Not even that. We are talking for more then a year for a next generation binary http(s) protocol. Almost everyone agreed that we need at least few things: 1. Encryption 2. Variable sized messages 3. Client

Re: Tomcat 6 Scales

2007-03-09 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: The processSocketWithOptions is a blocking call, hence you wont be able to acccept new connections as long as your worker threads are all busy. Not entirely true. What we need to do, is set the socket options, then simply add the socket to the poller waiting

Re: Tomcat 6 Scales

2007-03-10 Thread Mladen Turk
Henri Gomez wrote: Great article ! I agree. But like Filip said, the entire NIO (as well as APR) is sort of a hack. It is obvious that the current JSE spec doesn't fit for hybrid logic (both blocking and non-blocking) because the cost of switching between them is simply to high for any practic

Re: Tomcat 6 Scales

2007-03-10 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: Mladen Turk wrote: The ultimate goal is to have 20k connections and still handle them evenly. The question is what will you do with those 20K connections. The current servlet implementation as well as http protocol is transactional (request/response), and

Re: Tomcat 6 Scales

2007-03-10 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Mladen Turk wrote: Thanks everyone for the feedback, I'll let you know how everything progresses. Be sure to read the http://www.faqs.org/rfcs/rfc1925.html :) Regards, M

Re: Should we release mod_jk 1.2.21.1 or 1.2.22?

2007-03-11 Thread Mladen Turk
Rainer Jung wrote: What's the preferred solution? [ ] Try to improve the header files for a 1.2.21.1 [X] Simply release 1.2.22 [ ] Don't release at all, wait for more fixes or features before releasing. Regards, Mladen. -

Re: Tomcat 6 Scales

2007-03-11 Thread Mladen Turk
Costin Manolache wrote: Yes, 100 concurent requests is a sign you need lb - serving 1000 on Sometimes it is desired to have the capability of serving 1000 concurrent connections (not requests). The typical situation is when the frontend server is used for delivering a static content with higher

Re: mod_jk 1.2.22-dev test

2007-03-12 Thread Mladen Turk
Henri Gomez wrote: I'm tracking right now the iSeries problem (present in 1.2.20 and 1.2.21) and it's located somewhere in jk_log() (jk_util.c). That would be great, since only you reported that there is a core on that platform. Nevertheless, I presume it is either compiler or OS issue, since

Re: svn commit: r518581 - /tomcat/connectors/trunk/jk/native/common/jk_shm.c

2007-03-15 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, I didn't really read this commit, but it's Log entry reminds me of the following: This is for shm lock, not for the shared memory, so the name is irrelevant, and will be destroyed on exit. Also, we store workers in shared memory, so any attempt to have a share

Re: svn commit: r518581 - /tomcat/connectors/trunk/jk/native/common/jk_shm.c

2007-03-15 Thread Mladen Turk
Jim Jagielski wrote: Do we *really* want 0666 on these things? Wouldn't 0644 be better? Of course. I just made that compile time enabled for faulty kernels. I'll check if the 0644 works for flock. Regards, Mladen. - To unsu

Re: svn commit: r518581 - /tomcat/connectors/trunk/jk/native/common/jk_shm.c

2007-03-15 Thread Mladen Turk
Jim Jagielski wrote: On Mar 15, 2007, at 9:36 AM, Mladen Turk wrote: Jim Jagielski wrote: Do we *really* want 0666 on these things? Wouldn't 0644 be better? Of course. I just made that compile time enabled for faulty kernels. I'll check if the 0644 works for flock. It shoul

Re: svn commit: r518581 - /tomcat/connectors/trunk/jk/native/common/jk_shm.c

2007-03-15 Thread Mladen Turk
Rainer Jung wrote: I have the impression, that this would be nice for our shm file too. Right, it can be done with ease, just like we append .lock to JkShmFile we can append the pid Regards, Mladen. - To unsubscribe, e-mail

Re: svn commit: r519367 - /tomcat/connectors/trunk/jni/

2007-03-17 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Modified: tomcat/connectors/trunk/jni/ (props changed) Propchange: tomcat/connectors/trunk/jni/ -- --- svn:ignore (added) +++ svn:ignore Sat Mar 17 09:51:13 2007 Can you explain why you

Re: svn commit: r520029 - /tomcat/connectors/trunk/jk/native/apache-2.0/bldjk.qclsrc

2007-03-19 Thread Mladen Turk
[EMAIL PROTECTED] wrote: Author: hgomez Modified: tomcat/connectors/trunk/jk/native/apache-2.0/bldjk.qclsrc URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/bldjk.qclsrc?view=diff&rev=520029&r1=520028&r2=520029 ==

Re: [Fwd: Vendor Notification VU#239041 - apache-tomcat]

2007-03-20 Thread Mladen Turk
Remy Maucherat wrote: Tomcat permits both '\' and '%5C' as path delimiters. When Tomcat is used behind a proxy (including, but not limited to, Apache HTTP server with mod_proxy and mod_jk) configured to only proxy some contexts, a HTTP request containing strings like "/\../" may allow attacke

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-03-26 Thread Mladen Turk
Rainer Jung wrote: I think I added those after I was frustrated by a customer whose mod_jk logs had all non-windows line endings. Sorry, I didn't really test your change, but my experience questions this patch. With you patch the line endings were \r,\r,\n Do we need to set text mode on th

Tagging TOMCAT_NATIVE_1_1_9

2007-03-29 Thread Mladen Turk
Hi, I'll tag the tcnative to 1.1.9. It fixes the JVM core in case the acceptor breaks when we are inside the Socket.accept, and adds OpenBSD platform detection. -- Regards, Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For

Re: Tagging TOMCAT_NATIVE_1_1_9

2007-03-29 Thread Mladen Turk
William L. Thomson Jr. wrote: I never got a chance to make patch since I am not to familiar with configure. But would be nice for tcnative, to know during configure that it needs >=apr-1.x. If a check can't be added less a patch. I will get with another Gentoo dev, and get a patch made and to yo

Re: Tagging TOMCAT_NATIVE_1_1_9

2007-03-29 Thread Mladen Turk
Filip Hanik - Dev Lists wrote: cool, yes, lets get this done before 6.0.11 Right, that is the idea, because of .tar.gz and binary dependencies. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional comm

Re: mktemp didn't exist on i5

2007-03-29 Thread Mladen Turk
Henri Gomez wrote: While rebuild trunk from mod_jk I got an error on iSeries about missing mktemp in iSeries. if (!jk_shmem.lockname) { #ifnedef WHATEVER if (shm_lock_reopen) { int i; jk_shmem.fd_lock = -1; mode_t mask = umask(0); for (i

Re: mktemp didn't exist on i5

2007-03-29 Thread Mladen Turk
Henri Gomez wrote: Good thanks Check now. I put that inside #ifdef JK_SHM_LOCK_REOPEN, like before, but now, the entire code is compile time dependent instead just using a var. Regards, Mladen. - To unsubscribe, e-mail: [EM

Re: strange problem on i5

2007-03-30 Thread Mladen Turk
Henri Gomez wrote: It works back when jklog is : int jk_log(jk_logger_t *l, const char *file, int line, const char *funcname, int level, const char *fmt, ...) { int rc = 0; /* Need to reserve space for newline and terminating zero byte. */ static int usable_size = H

Re: strange problem on i5

2007-03-30 Thread Mladen Turk
Henri Gomez wrote: I allready told you that you didn't have to delay the release for i5 problems and you could go on with it. Sounds fair. If you came up with the patches, we can bump a next release that'll fix them. However, since we got that far I wonder why the logging is faulty. Can it be

TC 6.0.X SVN repo

2007-03-31 Thread Mladen Turk
Hi, I have deleted and added as external trunk/native/connector, because there is no reason to have that duplicated. Perhaps the similar (via external) can be done for org/apache/tomcat/jni as well. Comments? Regards, Mladen.

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-01 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, I think we don't use stdio. APR has apr_file_open() which uses CreateFile() and apr_file_write() which goes back to WriteFile() on Windows. We are using stdio for other web servers, so if you add CRLF then the IIS will be broken. Perhaps opening the files as bina

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-01 Thread Mladen Turk
Rainer Jung wrote: Hi Mladen, I built against an installed form of the official download apache_1.3.37-win32-x86-src.msi. ... and you are using VS 2005 I suppose? That won't work cause you have different MSVCRT's Regards, Mladen. -

Re: svn commit: r524660 - in /tomcat/tc6.0.x/trunk: build.properties.default java/org/apache/catalina/core/AprLifecycleListener.java res/tomcat.nsi

2007-04-01 Thread Mladen Turk
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: mturk Date: Sun Apr 1 12:37:58 2007 New Revision: 524660 URL: http://svn.apache.org/viewvc?view=rev&rev=524660 Log: Use the tomcat-native-1.1.9 as recommended version. I am against this change. Other than minor fixes, existing users shou

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-01 Thread Mladen Turk
Rainer Jung wrote: I used 2003 .net, but this includes a 7.0 version of msvcrt.dll. I build apache httpd 1.3 by myself and then mod_jk, and now everything works as expected. So you are right, the binary httpd download is not compatible with module compilation by vc++ 7.0. Any idea how one can m

Re: svn commit: r521417 - /tomcat/connectors/trunk/jk/native/common/jk_util.c

2007-04-02 Thread Mladen Turk
Henri Gomez wrote: May be at some time in the future we should think about a mod_jk 2.x requiring and using APR to remove all platform complexity :-) Think we tried that with jk2 and failed. Even on Apache 1.3 we could have jk bundled with APR statically Don't think so. Regards, Mladen.

<    1   2   3   4   5   6   7   8   9   10   >