Re: [DISCUSS]: change suggestion for small improvements/ Github Pull for Yetus

2016-10-04 Thread Casey Brotherton
Hello, For the initial question, it seems that for small changes, an individual jira is best for each suggestion. -- Current risks with using github PR's, -- as well as some folks use the Jira text for commit messages. Beyond that, there are a couple of action items that we should track: 1)

Re: [DISCUSS]: change suggestion for small improvements/ Github Pull for Yetus

2016-10-01 Thread Allen Wittenauer
> On Oct 1, 2016, at 5:52 AM, Sean Busbey wrote: > > Does this also happen if a patch file on JIRA contains multiple commits? Yes. However, git format-patch makes multiple files which is clearly awkward from a JIRA attachment perspective. So users either switch to git diff or squash

Re: [DISCUSS]: change suggestion for small improvements/ Github Pull for Yetus

2016-10-01 Thread Sean Busbey
On Sep 29, 2016 14:02, "Allen Wittenauer" wrote: > > > On Sep 28, 2016, at 7:37 AM, Casey Brotherton wrote: > > 2) Open a Github pull request > > I realize you are thinking about small/single line patches, but it's worthwhile pointing out that precommit can fall apart if commits aren't s

Re: [DISCUSS]: change suggestion for small improvements/ Github Pull for Yetus

2016-10-01 Thread Sean Busbey
One problem with #2 is that it means the contributor need not have created an account on the ASF JIRA. Generally I think of this as an advantage, since making yet another account is a pretty high bar for participation from casuals. But! We rely on the information in JIRA for authorship when making

Re: [DISCUSS]: change suggestion for small improvements/ Github Pull for Yetus

2016-09-29 Thread Allen Wittenauer
> On Sep 28, 2016, at 7:37 AM, Casey Brotherton > wrote: > 2) Open a Github pull request I realize you are thinking about small/single line patches, but it's worthwhile pointing out that precommit can fall apart if commits aren't squashed. There's a very big risk that github PR's are

[DISCUSS]: change suggestion for small improvements/ Github Pull for Yetus

2016-09-28 Thread Casey Brotherton
Hello, In walking through the code, I had seen a couple of places where a minor change would be beneficial to the overall project. ( Clarifying a log message, adding a log message, etc ) What would be the best vehicle for encouraging contributor patches for small improvements? Discussed offline