size_t should print using %zu, but here it was using %d and hence we
were getting warning while printing.
Signed-off-by: Sudip Mukherjee
---
I think it will be easy to remove the other warnings if all the typedefs
are removed first.
drivers/staging/wilc1000/wilc_spi.c | 2
On Tue, Jun 02, 2015 at 06:59:38AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Tue, Jun 02, 2015 at 11:32:00AM +0530, Sudip Mukherjee wrote:
> > On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > From: Guj
On Sun, May 31, 2015 at 10:01:13PM -0700, Isaac Assegai wrote:
> Insert Spaces after commas to rectify the following checkpatch
> errors in ddk750_mode.c, sm750_accel.c and sm750_help.h:
> ERROR: space required after that ','
>
> Signed-off-by: Isaac Assegai
> ---
> drivers/staging/sm750fb/ddk75
On Sun, May 31, 2015 at 10:01:11PM -0700, Isaac Assegai wrote:
> Insert Spaces after commas to rectify the following
> checkpatch errors in ddk750_help.c and ddk750_mode.c:
> ERROR: space required after that ','
>
> Signed-off-by: Isaac Assegai
> ---
>
>
> - ulTmpValue =
> FIELD
On Sun, May 31, 2015 at 10:01:04PM -0700, Isaac Assegai wrote:
> Insert Spaces after commas to rectify the
> following checkpatch errors in sm750.h:
> ERROR: space required after that ','
>
> Signed-off-by: Isaac Assegai
> ---
> drivers/staging/sm750fb/sm750.h | 35 ++
On Sun, May 31, 2015 at 10:01:03PM -0700, Isaac Assegai wrote:
> Insert Spaces after commas to rectify the
> following checkpatch errors in sm750_help.h:
> ERROR: space required after that ','
>
> Signed-off-by: Isaac Assegai
> ---
> drivers/staging/sm750fb/sm750_help.h | 12 ++--
> 1 fi
On Mon, Jun 01, 2015 at 10:38:10AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> From: Gujulan Elango Hari Prasath
>
> Remove the unwanted else block
i think you need to refresh your tree. This was already removed by
86b4e7e270d9c08b ('staging: dgnc: remove some dead code from dgnc_tty.c');
On Mon, Jun 01, 2015 at 09:43:31PM -0300, Gaston Gonzalez wrote:
> Fix the following sparse warnings:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
On Mon, Jun 01, 2015 at 01:26:39PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Mon, Jun 01, 2015 at 04:18:17PM +0300, Dan Carpenter wrote:
> > Really both patches should have been folded together.
> >
> > regards,
> > dan carpenter
> >
>
> Yes Dan they can very well be a single patch.I
On Mon, Jun 01, 2015 at 12:39:31PM +, Dhere, Chaitanya (C.) wrote:
> From: Chaitanya Dhere
>
> This change was detected with help of coccinelle tool.
Hi,
can you please let me know how to use coccinelle to detect indention
issues. I never knew coccinelle can be used to check these also.
rega
On Mon, Jun 01, 2015 at 03:18:11PM +0900, Greg Kroah-Hartman wrote:
> On Mon, Jun 01, 2015 at 11:16:51AM +0530, Sudip Mukherjee wrote:
> > On Mon, Jun 01, 2015 at 07:05:30AM +0900, Greg Kroah-Hartman wrote:
> > > On Wed, May 20, 2015 at 08:56:56PM +0530, Sudip Mukherjee wrote
On Mon, Jun 01, 2015 at 07:05:30AM +0900, Greg Kroah-Hartman wrote:
> On Wed, May 20, 2015 at 08:56:56PM +0530, Sudip Mukherjee wrote:
> > After 5 versions of WIP, finally a patch submission.
> > parport subsystem is now in the transition stage and supports the old
> > mod
On Fri, May 29, 2015 at 04:00:53PM -0700, Colin Cronin wrote:
> Fixed a few spelling errors in commented code, helpline text, and a TODO list
> Files changed:
>
> diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO
> index 2b2c6ea..cbc679d 100644
> --- a/drivers/staging/dgnc/TODO
>
On Sat, May 30, 2015 at 12:45:22AM +0300, Vladimirs Ambrosovs wrote:
> The functions iio_dummy_remove(), iio_simple_dummy_events_unregister() and
> iio_dummy_evgen_release_irq() were changed to return void instead of int,
> because these functions always return 0.
>
> Signed-off-by: Vladimirs Amb
On Fri, May 29, 2015 at 10:52:25PM +0200, Arnd Bergmann wrote:
> The various semaphore functions all directly translate into
> sema_init(), down() and up(), so we can just remove the API.
>
> This is a mostly automated conversion using simple sed scripts,
> plus some manual changes to account for
On Fri, May 29, 2015 at 10:52:16PM +0200, Arnd Bergmann wrote:
> The abstraction for time in this driver is completely
> unused, so remove it.
>
> Signed-off-by: Arnd Bergmann
> ---
> drivers/staging/wilc1000/wilc_osconfig.h | 1 -
> drivers/staging/wilc1000/wilc_oswrapper.h | 5 -
> driver
On Fri, May 29, 2015 at 08:16:21AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> Remove the unwanted else block
something is wrong. This patch is also not applying.
I am on staging-testing.
regards
sudip
___
devel mailing list
de...@linuxdriverproj
On Fri, May 29, 2015 at 07:17:37AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> This patch deletes all references to 'flipbuf'.Memory is allocated and
> freed but never used anywhere in the driver.Also deleted an ununsed
> Macro defined in the header file.
after your patch MYFLIPLEN becomes u
On Thu, May 28, 2015 at 12:35:22PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> Check the return value of kcalloc first and then use the pointer.
>
> Signed-off-by: Gujulan Elango Hari Prasath
> ---
> -
> - if (!brd->msgbuf) {
> + if (!brd->msgbuf_head) {
> kfree(brd)
On Wed, May 27, 2015 at 05:05:26PM +0800, Simon Guo wrote:
> Delare request_cache variable as static.
Is it Declare?
regards
sudip
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-dev
On Wed, May 27, 2015 at 12:07:06PM +, Harisangam, Sharvari (S.) wrote:
> On Tue, May 26, 2015 at 10:35:57AM +0530, Sudip Mukherjee wrote:
> > On Mon, May 25, 2015 at 12:22:25PM +, Harisangam, Sharvari (S.) wrote:
> > > Modified the if-else statements to remove unnec
On Wed, May 27, 2015 at 05:38:42AM -0700, gre...@linuxfoundation.org wrote:
> On Wed, May 27, 2015 at 11:49:47AM +0530, Sudip Mukherjee wrote:
> > > May i know whats wrong with the patch ? I am able to apply it without
> > > any issue.
> >
> > ERROR: patch
On Wed, May 27, 2015 at 11:37:19AM +0300, Dan Carpenter wrote:
> On Wed, May 27, 2015 at 01:29:31PM +0530, Sudip Mukherjee wrote:
> > tested again.
> > strange behaviour.
> > if i send your patch to checkpatch from mutt via pipe I am getting these
> > errors but if i sa
On Wed, May 27, 2015 at 07:53:02AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Wed, May 27, 2015 at 01:07:17PM +0530, Sudip Mukherjee wrote:
> > On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
> > > On Wed, May 27, 2015 at 11:10:34AM +0530, Sud
On Wed, May 27, 2015 at 10:28:54AM +0300, Dan Carpenter wrote:
> On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
> > On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > replace kzalloc with devm_kzalloc thereby re
On Tue, May 26, 2015 at 05:22:39PM +0200, Michel von Czettritz wrote:
> As suggested by Sudip this patch removes the redundant 1360x768@60
> option from the fb_videomode struct array.
this can be in the comments but should not be there in the commit message.
regards
sudip
> The removed option and
On Wed, May 27, 2015 at 05:56:27AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> On Wed, May 27, 2015 at 11:10:34AM +0530, Sudip Mukherjee wrote:
> > On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > replace kzalloc w
On Tue, May 26, 2015 at 02:50:30PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> The Kconfig dependency for this driver should include the kernel
> configuration FB_MODE_HELPERS which defines the vesa_modes
> structure.Without this dependency,the driver build generates a linker
> error if bui
On Tue, May 26, 2015 at 10:04:44AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> replace kzalloc with devm_kzalloc thereby removing the corresponding
> kfree.
your patch is corrupt and can not be applied.
But even then, can this be called as code improvement?
regards
sudip
>
> Signed-off-by:
On Mon, May 25, 2015 at 10:07:59PM -0700, Joe Perches wrote:
> On Tue, 2015-05-26 at 10:32 +0530, Sudip Mukherjee wrote:
> > On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
> > > On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
> > > > On Mon, Ma
On Mon, May 25, 2015 at 07:50:55PM -0300, Gaston Gonzalez wrote:
> On 25/05/15 13:35, Dan Carpenter wrote:
> > This is also wrong then.
> >
> > regards,
> > dan carpenter
> Hi Dan,
>
> Yes, you are right. It is the next sparse warning in line for that file.
> Including the fix for that, the patch
On Mon, May 25, 2015 at 12:22:25PM +, Harisangam, Sharvari (S.) wrote:
> Modified the if-else statements to remove unnecessary comparisons.
> This change was detected with the help of coccinelle tool
>
> Signed-off-by: Harisangam Sharvari S
you should not use initials in the Signed-off-by nam
On Mon, May 25, 2015 at 09:55:08PM -0700, Joe Perches wrote:
> On Tue, 2015-05-26 at 10:16 +0530, Sudip Mukherjee wrote:
> > On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
> > > It'd be better if the approved patches from the intern list
> > > (no idea
On Mon, May 25, 2015 at 07:22:40PM +0300, Dan Carpenter wrote:
> On Fri, May 15, 2015 at 03:46:49PM +0530, Sudip Mukherjee wrote:
> > On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote:
> > > On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote:
> >
On Mon, May 25, 2015 at 10:37:28AM -0700, Joe Perches wrote:
> It'd be better if the approved patches from the intern list
> (no idea what that is) were sent to lkml/devel@driverdev lists
> for review before actually being applied.
Its the outreachy program. And http://kernelnewbies.org/OutreachyAp
>I haven't been using kernel v4.1 so I haven't seen this warning, but looking
>at the code it seems to originate from the two recent patches to remove
>_cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml
>[1]
>that changes del_timer_sync back to del_timer in more places. P
On Sat, May 23, 2015 at 07:53:28PM -0700, tolga ceylan wrote:
> On 05/12/2015 08:55 PM, Tolga Ceylan wrote:
> >
> >
>
> I haven't gotten a response for this patch. Just checking back.
no response means no one is having anything to say about it. Final say
will be Greg's when he reviews that when h
On Sat, May 23, 2015 at 08:09:54AM -0400, Michael Shuey wrote:
> BTW, you keep mentioning a v5 that I sent. Where is that, exactly?
> The last round of patches I sent I've kept labeled as "PATCH v4", and
> I only hit git send-email once. Could you forward me something from
> this v5 series, so I
Modify i2c-parport driver to use the new parallel port device model.
Tested-by: Jean Delvare
Acked-by: Wolfram Sang
Signed-off-by: Sudip Mukherjee
---
v2: Changed to one space instead of tab in i2c_parport_driver.
i2c_parport_cb is made local, devmodel added to driver structure,
and probe
On Wed, May 20, 2015 at 10:36:04PM +0200, Richard Weinberger wrote:
> Am 20.05.2015 um 18:33 schrieb One Thousand Gnomes:
> > On Wed, 20 May 2015 17:46:44 +0200
> > Richard Weinberger wrote:
> >
> >> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> >&
On Wed, May 20, 2015 at 09:28:16AM -0700, Joe Perches wrote:
> On Wed, 2015-05-20 at 17:46 +0200, Richard Weinberger wrote:
> > On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> > wrote:
> > > Lets give the parport subsystem a proper name and start
> > > maintain
On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
> On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> > Modify i2c-parport driver to use the new parallel port device model.
> >
> > Tested-by: Jean Delvare
> > Signed-off-by: Sudip Mukherj
Modify paride driver to use the new parallel port device model.
Tested-by: Alan Cox
Signed-off-by: Sudip Mukherjee
---
One change after testing by Alan, par_cb is made a local variable
instead of a global one.
drivers/block/paride/paride.c | 57
Lets give the parport subsystem a proper name and start
maintaining the files.
Signed-off-by: Sudip Mukherjee
---
MAINTAINERS | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 86d9398..0eb5ce2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Modify i2c-parport driver to use the new parallel port device model.
Tested-by: Jean Delvare
Signed-off-by: Sudip Mukherjee
---
i2c_parport_cb is made local, devmodel added to driver structure,
and probe removed.
drivers/i2c/busses/i2c-parport.c | 15 ++-
1 file
.
Sudip Mukherjee (6):
parport: add device-model to parport subsystem
staging: panel: use new parport device model
i2c-parport: define ports to connect
i2c-parport: use new parport device model
paride: use new parport device model
MAINTAINERS: maintain parport
MAINTAINERS
As of now i2c-parport was connecting to all the available parallel
ports. Lets limit that to maximum of 4 instances and at the same time
define which instance connects to which parallel port.
Tested-by: Jean Delvare
Signed-off-by: Sudip Mukherjee
---
MODULE_PARM_DESC modified
drivers/i2c
Converted to use the new device-model parallel port.
Signed-off-by: Sudip Mukherjee
---
The comment about panel_cb.flags can be removed, it is kept just
for the comment to remind us that it might be better to use
PARPORT_DEV_EXCL.
drivers/staging/panel/panel.c | 14 +-
1 file
parport subsystem starts using the device-model. Drivers using the
device-model has to define devmodel as true and should register the
device with parport using parport_register_dev_model().
Tested-by: Jean Delvare
Tested-by: Alan Cox
Signed-off-by: Sudip Mukherjee
---
patch: renaming of cnt
On Wed, May 20, 2015 at 10:00:45AM +0100, Ian Abbott wrote:
> On 20/05/15 09:22, Sudip Mukherjee wrote:
> >On Wed, May 20, 2015 at 09:24:18AM +0200, Amaury Denoyelle wrote:
> >>Sudip Mukherjee wrote:
> >>
> >>>On Tue, May 19, 2015 at 07:57:49PM +0200,
On Wed, May 20, 2015 at 09:24:18AM +0200, Amaury Denoyelle wrote:
> Sudip Mukherjee wrote:
>
> > On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
> >
> > > @@ -1381,7 +1382,9 @@ static int set_ai_fifo_segment_length(struct
> > > comedi
On Tue, May 19, 2015 at 07:57:49PM +0200, Amaury Denoyelle wrote:
> This patch fixes coding style errors reported by checkpatch.pl for
> cb_pcidas64.c, about too long source code lines.
>
> Signed-off-by: Amaury Denoyelle
> ---
> drivers/staging/comedi/drivers/cb_pcidas64.c | 14 ++
>
On Mon, May 18, 2015 at 08:51:29PM +0200, Amaury Denoyelle wrote:
> > Sudip Mukherjee wrote:
> >
> > > On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote:
> Thanks for your review. I was aware of the coding style for multi-line
> comments, but I chose to
On Tue, May 19, 2015 at 01:32:22AM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.
I would have split this patch into three.
1) introduce pr_fmt and remove "ieee80211
On Tue, May 19, 2015 at 01:50:10AM -0300, Douglas Figueiredo wrote:
> From: douglasbsf
>
> Fixed Coding Style Problem in drivers/staging/wlan-ng/prism2fw.c
1) mention which coding style problem you fixed in the commit message.
2) no need to mention the challenge in the subject, the subject can b
On Mon, May 18, 2015 at 09:26:03AM -0700, Joe Perches wrote:
> On Mon, 2015-05-18 at 21:35 +0530, Sudip Mukherjee wrote:
> > On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.)
> > wrote:
> > > setup_timer is used for timer parameter setup rather than
On Mon, May 18, 2015 at 07:36:23PM +0200, Pedro Marzo Perez wrote:
> Merge two pr_debug lines with literal strings splitted across several lines
> into one single line, simplifying prism2_wep_init error check code.
> Openning braces should never be in a new line, move them to the end of
> the previ
On Mon, May 18, 2015 at 02:44:15PM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
> setup_timer is used for timer parameter setup rather than direct
> assignment
>
> Signed-off-by: Gnanachandran Dhanapal
your From: name and Signed-off-by: names are not matching. They should
be same.
> ---
> --- a/
On Mon, May 18, 2015 at 11:45:49AM +0200, Wim de With wrote:
> This is a patch that fixes the function declarations in
> visorbus/visorchipset.c by removing newlines after the function return
> type
But this is not an error nor it is a coding style error. Instead your
patch will now introduce new
On Sat, May 16, 2015 at 09:31:28PM +0200, Michel von Czettritz wrote:
> It appears that 'FB_SYNC_HOR_HIGH_ACT' should be assined to 'sync'
> and 'FB_VMODE_NONINTERLACED' is a flag for 'vmode'.
>
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 77310ff..8
On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote:
> This patch fixes coding style errors reported by checkpatch.pl for
> cb_pcidas64.c, about too long source code lines.
>
> Signed-off-by: Amaury Denoyelle
> ---
> }
>
> -/* adjusts the size of hardware fifo (which determines b
On Fri, May 15, 2015 at 02:11:40AM -0700, Colin Cronin wrote:
> Fixed comment spelling errors
>
> Signed-off-by Colin Cronin
this is wrong. should be Signed-off-by:
regards
sudip
> ---
___
devel mailing list
de...@linuxdriverproject.org
http://driverd
On Thu, May 14, 2015 at 06:18:59PM +0300, Dan Carpenter wrote:
> On Thu, May 14, 2015 at 07:55:59PM +0530, Sudip Mukherjee wrote:
> > the if comparison is always true as anything bitwise and-ing with 0x1E
> > can never be equal to 0x03.
> >
> > Fixes bugzilla:
ted-by: Arek Rusniak
Signed-off-by: Sudip Mukherjee
---
how to close the bug in bugzilla? The FAQ page says VERIFIED and CLOSE
status, but Arek says he can only see RESOLVED and NEW.
drivers/staging/rtl8712/rtl8712_led.c | 144 +++---
drivers/staging/rtl8712/rtl
the if comparison is always true as anything bitwise and-ing with 0x1E
can never be equal to 0x03.
Fixes bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=69881
Reported-by: David Binderman
Signed-off-by: Sudip Mukherjee
---
drivers/staging/rts5208/sd.c | 6 ++
1 file changed, 2
On Tue, May 12, 2015 at 06:57:46PM -0700, Tolga Ceylan wrote:
> To fix sparse warning of incorrect type when calling vfree()
> (different address space), added annotation __force.
Garret Kelly posted a similar patch before, please see the discussion
about that patch at https://lkml.org/lkml/2015/4
On Tue, May 12, 2015 at 11:01:44PM +0200, Mateusz Kulikowski wrote:
> On 10.05.2015 09:49, Sudip Mukherjee wrote:
> > On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
>
> You're running checkpatch --strict right?
>
> > 1) multiple blank li
the detach
function, which should be the ideal case as the detach will be called if
we try to unregister the driver or if the parport is removed.
Fixes: bb046fef9668 ('staging: panel: register reboot')
Signed-off-by: Sudip Mukherjee
---
v3: mention commit id in proper format
v2: addded p
On Tue, May 12, 2015 at 02:27:13PM +0300, Dan Carpenter wrote:
> On Tue, May 12, 2015 at 04:45:44PM +0530, Sudip Mukherjee wrote:
> > if we load the module, unload and then again try to load the module, we
> > will get a stackdump. In the module_exit function we are unregistering
detach will be called if
we try to unregister the driver or if the parport is removed.
Signed-off-by: Sudip Mukherjee
---
v2: addded previous commit id to commit message
Faced this problem while working on the device-model code of
parallelport.
drivers/staging/panel/panel.c | 44
On Mon, May 11, 2015 at 02:31:02PM +0300, Dan Carpenter wrote:
> On Mon, May 11, 2015 at 04:17:10PM +0530, Sudip Mukherjee wrote:
> > - if (set->set_pga) {
> > - int len = set->set_oabufs * sizeof(*set->set_pga);
> > + if (set->set_pga)
> >
to unregister the driver or if the parport is removed.
Signed-off-by: Sudip Mukherjee
---
This was caused by one of my patch :(
Faced this problem while working on the device-model code of
parallelport.
drivers/staging/panel/panel.c | 44 +--
1 file
there variables were not used anywhere and was showing as build warning.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/lustre/lustre/lov/lov_request.c | 4 +---
drivers/staging/lustre/lustre/obdclass/acl.c| 1 -
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers
On Sun, May 10, 2015 at 03:01:30PM +0200, Greg Kroah-Hartman wrote:
> On Fri, May 08, 2015 at 01:06:19PM +0530, Sudip Mukherjee wrote:
> > these functions were just defined and never used. after removing the
> > functions the variable visorchipset_cache_buffers_in_use is becoming
On Sat, May 09, 2015 at 11:18:55PM +0200, Mateusz Kulikowski wrote:
> Replace all RTLLIB_DEBUG(RTLLIB_DL_ERR, *) calls with netdev_err()
> for errors that really should be reported to user.
> Use netdev_warn() for the rest.
> Rephrase some of the messages to make them more readable/compact.
checkpa
On Sat, May 09, 2015 at 11:18:52PM +0200, Mateusz Kulikowski wrote:
> Move MFIE_TYPE_GENERIC handler to rtllib_parse_mife_generic() function.
> Code was not altered significantly, therefore in some places it generates
> LONG_LINE checkpatch.pl warnings.
apart from long line it is also giving warnin
dgap_sindex() is being only called from dgap_getword() which searches
for either ' ' or '\t' or '\n'. this part of the code with '^' at the
beginning is never used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 21 --
On Fri, May 08, 2015 at 05:04:28PM +0800, Huacai Chen wrote:
> If image->depth != 1, lynxfb_ops_imageblit() should fallback to call
> cfb_imageblit(), not return directly. Otherwise it can't display the
> boot logo.
why resending?
regards
sudip
___
dev
On Fri, May 08, 2015 at 10:34:49AM +0300, Dan Carpenter wrote:
> On Fri, May 08, 2015 at 09:54:44AM +0530, Sudip Mukherjee wrote:
> > On Thu, May 07, 2015 at 10:04:32PM +0200, Greg Kroah-Hartman wrote:
> > > On Thu, May 07, 2015 at 03:06:52PM +0530, Sudip Mukherjee wrote:
&g
these functions were just defined and never used. after removing the
functions the variable visorchipset_cache_buffers_in_use is becoming
unused, so removed it as well.
Signed-off-by: Sudip Mukherjee
---
v2: combined both patches of v1 together
drivers/staging/unisys/visorchipset
On Thu, May 07, 2015 at 10:04:32PM +0200, Greg Kroah-Hartman wrote:
> On Thu, May 07, 2015 at 03:06:52PM +0530, Sudip Mukherjee wrote:
> > the previous patch of the series made this variable unused.
>
> What do you mean? There was only one other patch in this series, never
>
On Thu, May 07, 2015 at 08:01:53AM -0500, Jaime Arrocha wrote:
>
>
> On 05/07/2015 12:34 AM, Sudip Mukherjee wrote:
> >On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
> >>Errors found by checkpatch.pl.
> >>ERROR: code indent should use tabs wh
will be left in an inconsistent state.
So moved the cleanups in the remove callback and since there was no
reference of dgap_driver in remove_one(), so had to define the
pci_driver in the function.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 49
move the cleanup function before the remove call as the next patch of
the series is going to use that.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/dgap/dgap.c | 61 ++---
1 file changed, 30 insertions(+), 31 deletions(-)
diff --git a/drivers
the previous patch of the series made this variable unused.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorchipset/visorchipset_main.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c
b/drivers/staging/unisys
these functions were just defined and never used.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/unisys/visorchipset/visorchipset.h | 4 ---
.../unisys/visorchipset/visorchipset_main.c| 41 --
2 files changed, 45 deletions(-)
diff --git a/drivers/staging/unisys
On Wed, May 06, 2015 at 05:13:41PM -0500, Jaime Arrocha wrote:
> Errors found by checkpatch.pl.
> ERROR: code indent should use tabs where possible
> /drivers/staging/comedi/drivers/das16m1.c:49
> /drivers/staging/comedi/drivers/das16m1.c:50
>
> Signed-off-by: Jaime Arrocha
> ---
you are sending
there variables were not used anywhere and was showing as build warning.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/lustre/lustre/llite/file.c | 2 --
drivers/staging/lustre/lustre/llite/llite_lib.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre
On Wed, May 06, 2015 at 08:02:55AM -0400, Mike Shuey wrote:
> Clean up spacing in some variable declarations, to be more consistent.
>
> It's small, but I need to start somewhere. Please let me know if I'm not
> adhering to proper procedure for trivial cleanups.
these comments should not come he
On Wed, May 06, 2015 at 10:06:21AM +0300, Dan Carpenter wrote:
> Looks good.
but its applying to linux-next and not applying to staging-testing.
There are a few patches which Greg applied to staging-testing before the
merge-window but they were not applied to staging-next. I guess he has
been busy
On Mon, Apr 27, 2015 at 02:36:53PM +, Teddy Wang 王力强 wrote:
> The image->depth != 1 case means the image is color.
>
> The current driver only does 2d in mono color image. I think we can let the
> driver fall back to cfb_imageblit() currently. Then we implement the color
> image 2d later.
>
On Mon, Apr 27, 2015 at 04:10:53PM +0800, Huacai Chen wrote:
> If image->depth != 1, lynxfb_ops_imageblit() should fallback to call
> cfb_imageblit(), not return directly. Otherwise it can't display the
> boot logo.
I think it is wrong. lynxfb_ops_imageblit() is the imageblit callback
if 2D accele
On Fri, Apr 24, 2015 at 03:33:58PM +0800, 陈华才 wrote:
> Hi, Sudip,
>
> Upstream driver still can't show logo, we are debugging.
Hi Huacai,
I checked with the upstream driver only.
I checked with next-20150423 and it showed me the penguin logo on upper
left hand corner of my screen when CONFIG_FB_S
On Thu, Apr 23, 2015 at 05:04:08PM -0400, Charles Rose wrote:
> This patch fixes "space prohibited" errors reported by checkpatch.pl
> and related indentation. The module builds without error.
>
> Signed-off-by: Charles Rose
> - if ( x == 800 && y == 600 )
> - dispControl = FIELD_SET(dis
On Thu, Apr 23, 2015 at 03:00:14PM +, DHANAPAL, GNANACHANDRAN (G.) wrote:
> This patch removes unused return variable in this file.
>
> Signed-off-by: Gnanachandran Dhanapal
> ---
your From: name and Signed-off-by: name is not matching.
regards
sudip
instance of "sfb->fb." has been changed into "sfb->fb->".
now we will get build warning about smtc_alloc_fb_info() and
smtc_free_fb_info() to be unused which will be removed in the next
patch of the series.
Signed-off-by: Sudip Mukherjee
---
tested on hardware.
drivers/st
removed the smtc_alloc_fb_info() and smtc_free_fb_info() functions which
were not used anymore.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 32
1 file changed, 32 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers
On Thu, Apr 23, 2015 at 10:29:48AM +0530, Sudip Mukherjee wrote:
> On Thu, Apr 23, 2015 at 12:43:40PM +0800, 陈华才 wrote:
> > Hi, Teddy,
> >
> > In the code It seems that only SM718/SM750 is supported in Sudip's driver.
>
> Hi Huacai,
>
> The driver that Ted
On Thu, Apr 23, 2015 at 12:43:40PM +0800, 陈华才 wrote:
> Hi, Teddy,
>
> In the code It seems that only SM718/SM750 is supported in Sudip's driver.
Hi Huacai,
The driver that Teddy gave me originally was a mix driver of
SM712/SM750/SM502. The one in staging is only SM750, since we already
have SM71
rency was too high and since this I do just for
my interest and not part of my dayjob, so there is no funding also :(
regards
sudip
>
> Huacai
>
> -- Original --
> From: "Sudip Mukherjee";
> Date: Wed, Apr 22, 2015 12:59 PM
> To
601 - 700 of 1044 matches
Mail list logo
