http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
File user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
(right):
http://gwt-code-reviews.appspot.com/1861804/diff/1/user/src/com/google/gwt/resources/css/CssGenerationV
http://gwt-code-reviews.appspot.com/1861804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: mdempsky,
Description:
CSS Media types are comma separated.
Please review this at http://gwt-code-reviews.appspot.com/1861804/
Affected files:
M user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
M user/test/com/google/gwt/resources/css/CssNodeClonerTest.java
M us
http://gwt-code-reviews.appspot.com/1863803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1863803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
This is partially from a patch contributed by an external developer. See
http://gwt-code-reviews.appspot.com/1862803/
http://gwt-code-reviews.appspot.com/1863803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Resubmitting internally at
http://gwt-code-reviews.appspot.com/1863803
On 2012/10/26 04:44:12, Andrew Bachmann wrote:
Thanks for the patch. Nice find.
http://gwt-code-reviews.appspot.com/1862803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: skybrian,
Description:
Thanks minichate!
GWT CSS parser was dropping media types.
Fixes issue: 4911
Please review this at http://gwt-code-reviews.appspot.com/1863803/
Affected files:
M user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
M user/src/com/google/gwt/res
LGTM
http://gwt-code-reviews.appspot.com/1847805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11231.
http://gwt-code-reviews.appspot.com/1794803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1794803/diff/4001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):
http://gwt-code-reviews.appspot.com/1794803/diff/4001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#
http://gwt-code-reviews.appspot.com/1794803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ping
http://gwt-code-reviews.appspot.com/1794803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ping.
On 2012/08/10 15:33:27, rchandia wrote:
Ready for a second round.
On 2012/08/08 14:10:11, rchandia wrote:
>
http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
> File user/src/com/google/gwt/uibinder/
Ready for a second round.
On 2012/08/08 14:10:11, rchandia wrote:
http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
(right):
http://gwt-code-reviews.appspot.com
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml
File samples/mobilewebapp/pom.xml (right):
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/pom.xml#newcode183
samples/mobilewebapp/pom.xml:183: 1.6
Change tabs to spaces
http://gwt-code-revie
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml
File samples/mobilewebapp/src/main/webapp/WEB-INF/appengine-web.xml
(right):
http://gwt-code-reviews.appspot.com/1806803/diff/1/samples/mobilewebapp/src/main/webapp/WEB-INF/appengine
http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
(right):
http://gwt-code-reviews.appspot.com/1794803/diff/1/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java#
http://gwt-code-reviews.appspot.com/1794803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Allows UiRenderer styles before the first call to render()
Fields are initialized both upon construction and on a call to render()
Also ensured that ui:with fields never get optimized as final.
Please review this at http://gwt-code-reviews.appspot.com/1794803/
Submitted as r11159.
http://gwt-code-reviews.appspot.com/1769803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11159.
On 2012/07/01 04:22:08, skybrian wrote:
LGTM
http://gwt-code-reviews.appspot.com/1768804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Reposting at http://gwt-code-reviews.appspot.com/1768804
http://gwt-code-reviews.appspot.com/1769803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: skybrian,
Description:
Include sources in gwt-codeserver.jar
Repost of issue 1769803. Thanks Thomas!
This should fix the Maven deployment to Central, which requires sources
(at least now there's a gwt-codeserver-${gwt.version}-sources.jar
artifact
generated and deployed).
Fixes issu
Submitted as r11136
http://gwt-code-reviews.appspot.com/1758804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1758804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1758804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1758804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Fix DynaTableRf build config
Please review this at http://gwt-code-reviews.appspot.com/1758804/
Affected files:
M distro-source/core/src/samples/build.xml
M samples/dynatablerf/build.xml
Index: distro-source/core/src/samples/build.xml
=
LGTM
http://gwt-code-reviews.appspot.com/1742803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1736805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11057
http://gwt-code-reviews.appspot.com/1734804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1624803/diff/18001/user/src/com/google/gwt/aria/client/CommonAttributeTypes.java
File user/src/com/google/gwt/aria/client/CommonAttributeTypes.java
(right):
http://gwt-code-reviews.appspot.com/1624803/diff/18001/user/src/com/google/gwt/aria/client/CommonAttrib
Reviewers: rdayal, tbroyer,
Description:
Update POM versions to 2.5.0-rc1
Please review this at http://gwt-code-reviews.appspot.com/1734804/
Affected files:
M samples/dynatablerf/pom.xml
M samples/expenses/pom.xml
M samples/mobilewebapp/pom.xml
M samples/validation/pom.xml
Index: sam
Submitted as r11052
http://gwt-code-reviews.appspot.com/1726805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/06/13 16:23:11, kromanovs wrote:
Well, you can add dependency to 2.5.0-SNAPSHOT if it's available in
the maven
central repo. If it's not - then I think it's not yet a time to push
this change
out.
GWT 2.5 is in the process of being released. I rather think it is time
to update the v
Great change, but UiRenderer is not a part of GWT 2.4.0 release while
project's
pom file depend on it. Any comments?
That'd be a bug. I guess it should be 2.5.0, but that version has not
been released yet. What is the Maven way to do this?
http://gwt-code-reviews.appspot.com/1733805/
--
ht
Reviewers: rdayal,
Description:
MeniItem should use ScheduledCommand instead of Command
Repost of 1698803
Thanks Patrick!
Patch by: tucker...@gmail.com
Please review this at http://gwt-code-reviews.appspot.com/1726805/
Affected files:
M tools/api-checker/config/gwt24_25userApi.conf
M user
http://gwt-code-reviews.appspot.com/1730805/diff/1/user/test/com/google/gwt/editor/client/DirtyEditorTest.java
File user/test/com/google/gwt/editor/client/DirtyEditorTest.java
(right):
http://gwt-code-reviews.appspot.com/1730805/diff/1/user/test/com/google/gwt/editor/client/DirtyEditorTest.java#
http://gwt-code-reviews.appspot.com/1730805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Adds a comment requesting an method type parameter to be kept,
even though it looks redundant, to satisfy OpenJDK.
Please review this at http://gwt-code-reviews.appspot.com/1730805/
Affected files:
M user/test/com/google/gwt/editor/client/DirtyEditorTest.java
Submitted as r11035
http://gwt-code-reviews.appspot.com/1733805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11034
http://gwt-code-reviews.appspot.com/1725807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11034
http://gwt-code-reviews.appspot.com/1565806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Checkstyle fixes
Repost of 1565806
Thanks Stephen!
Patch by: stephen.haber...@gmail.com
Please review this at http://gwt-code-reviews.appspot.com/1725807/
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/StandardPublicResource.java
M de
Submitted as r11033
http://gwt-code-reviews.appspot.com/1737804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
On 2012/06/08 18:27:29, stephenh wrote:
> I was putzing around with ant trying to get it to fail the compile
so didn't
have Eclipse to flag the error.
Huh, I thought I had Eclipse configured to show checkstyle errors like
that--but
I don't see it. I see other errors like methods not i
LGTM. With a Nit.
http://gwt-code-reviews.appspot.com/1565806/diff/8001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java
File user/test/com/google/gwt/editor/client/DirtyEditorTest.java
(right):
http://gwt-code-reviews.appspot.com/1565806/diff/8001/user/test/com/google/gwt/editor/cli
Reviewers: rdayal,
Description:
Complete text-* support for Style
Reposting of 1736803
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1737804/
Affected files:
M user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java
M user/src/com/google/gwt/dom/builde
Reviewers: rdayal,
Description:
Use UiRenderer (Uibinder for cells) in MobileWebApp sample.
Please review this at http://gwt-code-reviews.appspot.com/1733805/
Affected files:
D
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/DesktopTaskEditView.css
M
Submitted as r11028
http://gwt-code-reviews.appspot.com/1700803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11027
http://gwt-code-reviews.appspot.com/1733804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11027
http://gwt-code-reviews.appspot.com/1605803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Reposted at http://gwt-code-reviews.appspot.com/1733804/
http://gwt-code-reviews.appspot.com/1605803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Add javadocs for ExternalTextResource.getText
Repost of 1605803.
Thanks Stephen!
Fixes issue: 7035
Please review this at http://gwt-code-reviews.appspot.com/1733804/
Affected files:
M user/src/com/google/gwt/resources/client/ExternalTextResource.java
Index:
http://gwt-code-reviews.appspot.com/1565806/diff/4001/user/test/com/google/gwt/editor/client/DirtyEditorTest.java
File user/test/com/google/gwt/editor/client/DirtyEditorTest.java
(right):
http://gwt-code-reviews.appspot.com/1565806/diff/4001/user/test/com/google/gwt/editor/client/DirtyEditorTest
Submitted as r11026
http://gwt-code-reviews.appspot.com/1728804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11026
http://gwt-code-reviews.appspot.com/1602803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Reposting at http://gwt-code-reviews.appspot.com/1728804
http://gwt-code-reviews.appspot.com/1602803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Fix showcase lastNameColumn/ageColumn typo
Repost of 1602803.
Thanks Stephen!
Please review this at http://gwt-code-reviews.appspot.com/1728804/
Affected files:
M
samples/showcase/src/com/google/gwt/sample/showcase/client/content/cell/CwDataGrid.java
Ind
Submitted as r11025
http://gwt-code-reviews.appspot.com/1725806/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11025
http://gwt-code-reviews.appspot.com/1585805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Reposting at http://gwt-code-reviews.appspot.com/1725806
http://gwt-code-reviews.appspot.com/1585805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Fix !important css typo
Repost of 1585805.
Thanks Stephen!
Please review this at http://gwt-code-reviews.appspot.com/1725806/
Affected files:
M
dev/core/src/com/google/gwt/core/ext/linker/impl/installLocationIframe.js
Index:
dev/core/src/com/google/gwt
Submitted as r11023
http://gwt-code-reviews.appspot.com/1727805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11023
http://gwt-code-reviews.appspot.com/1614808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitting TBR
http://gwt-code-reviews.appspot.com/1733803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Rolling back, breaks other projects.
*** Original change description ***
MenuItem should use ScheduledCommand instead of Command
Repost of 1698803
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1733803/
Affected files:
M tools/api
Reviewers: rdayal,
Description:
MenuItem should use ScheduledCommand instead of Command
Repost of 1698803
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1732803/
Affected files:
M tools/api-checker/config/gwt24_25userApi.conf
M user/src/com/google/gwt/user/clien
LGTM2! Reposting at http://gwt-code-reviews.appspot.com/1727805
http://gwt-code-reviews.appspot.com/1614808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Add HasEnabled to FileUpload.
Repost of 1614808.
Thanks Stephen!
Fixes issues: 5677
Please review this at http://gwt-code-reviews.appspot.com/1727805/
Affected files:
M user/src/com/google/gwt/user/client/ui/FileUpload.java
Index: user/src/com/google/gwt/u
http://gwt-code-reviews.appspot.com/1605803/diff/1/user/src/com/google/gwt/resources/client/ExternalTextResource.java
File user/src/com/google/gwt/resources/client/ExternalTextResource.java
(right):
http://gwt-code-reviews.appspot.com/1605803/diff/1/user/src/com/google/gwt/resources/client/Exter
http://gwt-code-reviews.appspot.com/1565806/diff/1/user/test/com/google/gwt/editor/client/DirtyEditorTest.java
File user/test/com/google/gwt/editor/client/DirtyEditorTest.java
(right):
http://gwt-code-reviews.appspot.com/1565806/diff/1/user/test/com/google/gwt/editor/client/DirtyEditorTest.java#
Submitted as r11015
http://gwt-code-reviews.appspot.com/1731803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11015
http://gwt-code-reviews.appspot.com/1720803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Repost at http://gwt-code-reviews.appspot.com/1731803
http://gwt-code-reviews.appspot.com/1720803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Add clear support to Style
Repost of 1720803
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1731803/
Affected files:
M user/src/com/google/gwt/dom/client/Style.java
M user/src/com/google/gwt/safecss/shared/SafeStylesBuilder.java
Submitted as r11014
http://gwt-code-reviews.appspot.com/1725805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11014
http://gwt-code-reviews.appspot.com/1697803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Repost at http://gwt-code-reviews.appspot.com/1725805
http://gwt-code-reviews.appspot.com/1697803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
WindowImplIE should use ScheduledCommand instead of Command
Repost of 1697803
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1725805/
Affected files:
M user/src/com/google/gwt/user/client/impl/WindowImplIE.java
Index: user/src/com
Submitted as r11013
http://gwt-code-reviews.appspot.com/1725803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11013
http://gwt-code-reviews.appspot.com/1730803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM.
Reposting at http://gwt-code-reviews.appspot.com/1730803
http://gwt-code-reviews.appspot.com/1725803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
VerticalSplitPanel should not use DeferredCommand
Repost of issue 1725803
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1730803/
Affected files:
M user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java
Index: user/src/com
On 2012/06/05 01:09:12, Patrick Tucker wrote:
Is this acceptable, or should I modify the patch?
I think the change in this patch is good. What is needed is for this
patch to also modify
tools/api-checker/config/gwt24_25userApi.conf
to allow the API change.
http://gwt-code-reviews.appspot.com
Submitted as r11012
http://gwt-code-reviews.appspot.com/1725804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11012
http://gwt-code-reviews.appspot.com/1694804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Reposting at http://gwt-code-reviews.appspot.com/1725804
http://gwt-code-reviews.appspot.com/1694804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
JsonpRequest should not use DeferredCommand
Repost of 1694804
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1725804/
Affected files:
M user/src/com/google/gwt/jsonp/client/JsonpRequest.java
Index: user/src/com/google/gwt/jsonp/c
Submitted as r11011
http://gwt-code-reviews.appspot.com/1729803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11011
http://gwt-code-reviews.appspot.com/1696803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Reposting at http://gwt-code-reviews.appspot.com/1729803
http://gwt-code-reviews.appspot.com/1696803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
PopupImplMozilla should not use DeferredCommand
Repost of issue 1696803.
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1729803/
Affected files:
M user/src/com/google/gwt/user/client/ui/impl/PopupImplMozilla.java
Index: user/src/c
Submitted as r11010.
http://gwt-code-reviews.appspot.com/1728803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted as r11010.
http://gwt-code-reviews.appspot.com/1693804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Reposting as http://gwt-code-reviews.appspot.com/1728803
http://gwt-code-reviews.appspot.com/1693804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
RenderablePanel should use ScheduledCommand instead of Command
Resubmission of issue 1693804
Thanks Patrick!
Please review this at http://gwt-code-reviews.appspot.com/1728803/
Affected files:
M user/src/com/google/gwt/user/client/ui/RenderablePanel.java
Ind
com.google.gwt.core.client.Scheduler.ScheduledCommand
[java] API compatibility check FAILED
BUILD FAILED
/usr/local/google/users/rchandia/src/gwt-trunk_Piper/google3/third_party/java_src/gwt/svn/trunk/build.xml:189:
Java returned: 1
http://gwt-code-reviews.appspot.com/1698803/
--
http://groups.google.com
http://gwt-code-reviews.appspot.com/1700803/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):
http://gwt-code-reviews.appspot.com/1700803/diff/7001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter
1 - 100 of 637 matches
Mail list logo