Re: [PATCH] gnu: Add qscintilla.

2016-10-03 Thread Ludovic Courtès
Kei Kebreau skribis: > From ae862b8a51d15f165dc9b40dc46c2e209736f3a8 Mon Sep 17 00:00:00 2001 > From: Kei Kebreau > Date: Mon, 19 Sep 2016 10:11:20 -0400 > Subject: [PATCH] gnu: Add qscintilla-qt4. > > * gnu/packages/maths.scm (qscintilla-qt4): New variable. > --- > gnu

Re: [PATCH] gnu: Add qscintilla.

2016-09-25 Thread Kei Kebreau
Leo Famulari writes: > On Sat, Sep 24, 2016 at 01:13:33AM -0400, Kei Kebreau wrote: >> Leo Famulari writes: >> > I was getting failures reminiscent of an ABI break. But, I can't >> > reproduce it now. >> > >> > Kei, maybe you should try applying the patches to a fresh Git checkout? >> > If they

Re: [PATCH] gnu: Add qscintilla.

2016-09-25 Thread Leo Famulari
On Sat, Sep 24, 2016 at 01:13:33AM -0400, Kei Kebreau wrote: > Leo Famulari writes: > > I was getting failures reminiscent of an ABI break. But, I can't > > reproduce it now. > > > > Kei, maybe you should try applying the patches to a fresh Git checkout? > > If they work like that, then I think it

Re: [PATCH] gnu: Add qscintilla.

2016-09-23 Thread Kei Kebreau
Leo Famulari writes: > On Thu, Sep 22, 2016 at 09:02:20PM +0200, Ricardo Wurmus wrote: >> >> Leo Famulari writes: >> >> > I'm not sure yet about the other problem. I tried to define 'hi', which >> > inherits from 'hello', and I got a similar error. >> >> I don’t understand this. What is the

Re: [PATCH] gnu: Add qscintilla.

2016-09-23 Thread Leo Famulari
On Thu, Sep 22, 2016 at 09:02:20PM +0200, Ricardo Wurmus wrote: > > Leo Famulari writes: > > > I'm not sure yet about the other problem. I tried to define 'hi', which > > inherits from 'hello', and I got a similar error. > > I don’t understand this. What is the problem here? > > I’m successfu

Re: [PATCH] gnu: Add qscintilla.

2016-09-22 Thread Ricardo Wurmus
Leo Famulari writes: > I'm not sure yet about the other problem. I tried to define 'hi', which > inherits from 'hello', and I got a similar error. I don’t understand this. What is the problem here? I’m successfully inheriting from packages in other modules. For example, we have a separate mo

Re: [PATCH] gnu: Add qscintilla.

2016-09-19 Thread Leo Famulari
On Mon, Sep 19, 2016 at 05:45:35PM -0400, Kei Kebreau wrote: > * gnu/packages/qt.scm (qscintilla): New variable. > + (uri (string-append > "mirror://sourceforge/QScintilla2/QScintilla-" > + version "/QScintilla_gpl-" version > ".tar.gz")) This URI r

Re: [PATCH] gnu: Add qscintilla.

2016-09-19 Thread Kei Kebreau
..)) >> >> gives me an unbound variable error. Any idea what's going wrong here? > > Can you send the patch that gives the error? Sure thing. It's the combination of these two patches. From f60fc09f3f200276b2789a5e305efd5df17666d2 Mon Sep 17 00:00:00 2001 From: Kei

Re: [PATCH] gnu: Add qscintilla.

2016-09-19 Thread Leo Famulari
On Mon, Sep 19, 2016 at 10:47:56AM -0400, Kei Kebreau wrote: > Using > > #:use-module (gnu packages qt) > > and > > (define qscintilla-qt4 > (package > (inherit qscintilla) > ...)) > > gives me an unbound variable error. Any idea what's going wrong here? Can you send the pa

Re: [PATCH] gnu: Add qscintilla.

2016-09-19 Thread Kei Kebreau
Ricardo Wurmus writes: > Kei Kebreau writes: > >> (how do I inherit a package from another module?) > > Just like inheriting from any other package: you declare that the module > containing the package variable be used, and then inherit from the > package variable. > > ~~ Ricardo Using #:use

Re: [PATCH] gnu: Add qscintilla.

2016-09-19 Thread Andreas Enge
On Mon, Sep 19, 2016 at 09:18:45AM -0400, Kei Kebreau wrote: > To get this right: qscintilla will be defined publicly in qt.scm, > qscintilla-qt4 will be defined privately in maths.scm (how do I inherit > a package from another module?), and Octave will include qscintilla-qt4 > and qt-4 as inputs.

Re: [PATCH] gnu: Add qscintilla.

2016-09-19 Thread Ricardo Wurmus
Kei Kebreau writes: > (how do I inherit a package from another module?) Just like inheriting from any other package: you declare that the module containing the package variable be used, and then inherit from the package variable. ~~ Ricardo

Re: [PATCH] gnu: Add qscintilla.

2016-09-19 Thread Kei Kebreau
Efraim Flashner writes: > On Sun, Sep 18, 2016 at 04:56:34PM -0400, Leo Famulari wrote: >> On Sun, Sep 18, 2016 at 04:10:15PM -0400, Kei Kebreau wrote: >> > Andreas Enge writes: >> > > On Tue, Sep 13, 2016 at 04:37:35PM -0400, Kei Kebreau wrote: >> > >> In this case, should I leave qtscintilla-q

Re: [PATCH] gnu: Add qscintilla.

2016-09-18 Thread Efraim Flashner
On Sun, Sep 18, 2016 at 04:56:34PM -0400, Leo Famulari wrote: > On Sun, Sep 18, 2016 at 04:10:15PM -0400, Kei Kebreau wrote: > > Andreas Enge writes: > > > On Tue, Sep 13, 2016 at 04:37:35PM -0400, Kei Kebreau wrote: > > >> In this case, should I leave qtscintilla-qt4 as a public package in > > >

Re: [PATCH] gnu: Add qscintilla.

2016-09-18 Thread Leo Famulari
On Sun, Sep 18, 2016 at 04:10:15PM -0400, Kei Kebreau wrote: > Andreas Enge writes: > > On Tue, Sep 13, 2016 at 04:37:35PM -0400, Kei Kebreau wrote: > >> In this case, should I leave qtscintilla-qt4 as a public package in qt.scm > >> instead of maths.scm as Leo suggested? > > > > since it is used

Re: [PATCH] gnu: Add qscintilla.

2016-09-18 Thread Kei Kebreau
Andreas Enge writes: > Hello, > > On Tue, Sep 13, 2016 at 04:37:35PM -0400, Kei Kebreau wrote: >> In this case, should I leave qtscintilla-qt4 as a public package in qt.scm >> instead of maths.scm as Leo suggested? > > since it is used for only one package and relies on the deprecated qt@4, > I w

Re: [PATCH] gnu: Add qscintilla.

2016-09-18 Thread Andreas Enge
Hello, On Tue, Sep 13, 2016 at 04:37:35PM -0400, Kei Kebreau wrote: > In this case, should I leave qtscintilla-qt4 as a public package in qt.scm > instead of maths.scm as Leo suggested? since it is used for only one package and relies on the deprecated qt@4, I would leave it private, regardless i

Re: [PATCH] gnu: Add qscintilla.

2016-09-15 Thread Kei Kebreau
Kei Kebreau writes: > Efraim Flashner writes: > >> On September 14, 2016 11:37:46 PM GMT+03:00, Kei Kebreau >> wrote: >>>Leo Famulari writes: >>> On Wed, Sep 14, 2016 at 02:11:44PM -0400, Kei Kebreau wrote: > Leo Famulari writes: > > > On Tue, Sep 13, 2016 at 08:48:43PM +000

Re: [PATCH] gnu: Add qscintilla.

2016-09-15 Thread Kei Kebreau
quot; ,python-pyqt) + ("qt" ,qtbase))) ; for qmake +(home-page "https://www.riverbankcomputing.com/software/qscintilla/intro";) + (synopsis "Qt5 port of the Scintilla editing component") +(description + "QScintilla is a port to Qt of Neil Hodgson's Scintilla C++ editor con

Re: [PATCH] gnu: Add qscintilla.

2016-09-14 Thread Efraim Flashner
On September 14, 2016 11:37:46 PM GMT+03:00, Kei Kebreau wrote: >Leo Famulari writes: > >> On Wed, Sep 14, 2016 at 02:11:44PM -0400, Kei Kebreau wrote: >>> Leo Famulari writes: >>> >>> > On Tue, Sep 13, 2016 at 08:48:43PM +, Efraim Flashner wrote: >>> >> On September 13, 2016 11:37:35 PM

Re: [PATCH] gnu: Add qscintilla.

2016-09-14 Thread Kei Kebreau
on + "QScintilla is a port to Qt of Neil Hodgson's Scintilla C++ editor control. +As well as features found in standard text editing components, QScintilla +includes features especially useful when editing and debugging source code. +These include support for syntax styling, error indicators, code completion

Re: [PATCH] gnu: Add qscintilla.

2016-09-14 Thread Leo Famulari
On Wed, Sep 14, 2016 at 02:11:44PM -0400, Kei Kebreau wrote: > Leo Famulari writes: > > > On Tue, Sep 13, 2016 at 08:48:43PM +, Efraim Flashner wrote: > >> On September 13, 2016 11:37:35 PM GMT+03:00, Kei Kebreau > >> wrote: > >> >In this case, should I leave qtscintilla-qt4 as a public pack

Re: [PATCH] gnu: Add qscintilla.

2016-09-14 Thread Kei Kebreau
Octave's Qt 4 GUI." :) From 9304e67ff085853ebbd5d7f1c976171de498bf5b Mon Sep 17 00:00:00 2001 From: Kei Kebreau Date: Wed, 14 Sep 2016 13:56:33 -0400 Subject: [PATCH] gnu: Add qscintilla. * gnu/packages/qt.scm (qscintilla): New variable. --- gnu/packages/qt.scm | 68 ++

Re: [PATCH] gnu: Add qscintilla.

2016-09-14 Thread Leo Famulari
On Tue, Sep 13, 2016 at 08:48:43PM +, Efraim Flashner wrote: > On September 13, 2016 11:37:35 PM GMT+03:00, Kei Kebreau > wrote: > >In this case, should I leave qtscintilla-qt4 as a public package in > >qt.scm > >instead of maths.scm as Leo suggested? > > That's where I would leave it. You c

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Efraim Flashner
On September 13, 2016 11:37:35 PM GMT+03:00, Kei Kebreau wrote: >Efraim Flashner writes: > >> On Tue, Sep 13, 2016 at 02:01:33PM -0400, Kei Kebreau wrote: >>> Leo Famulari writes: >>> >>> > On Tue, Sep 13, 2016 at 10:37:56AM -0400, Kei Kebreau wrote: >>> >> Kei Kebreau writes: >>> >> > A co

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Kei Kebreau
Efraim Flashner writes: > On Tue, Sep 13, 2016 at 02:01:33PM -0400, Kei Kebreau wrote: >> Leo Famulari writes: >> >> > On Tue, Sep 13, 2016 at 10:37:56AM -0400, Kei Kebreau wrote: >> >> Kei Kebreau writes: >> >> > A component necessary for GNU Octave's GUI. >> >> > How does it look? >> >> Not

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Kei Kebreau
Leo Famulari writes: > On Tue, Sep 13, 2016 at 02:59:31PM -0400, Kei Kebreau wrote: >> Leo Famulari writes: >> >> > On Tue, Sep 13, 2016 at 02:01:33PM -0400, Kei Kebreau wrote: >> >> Like below? And how could I then access qscintilla-for-octave from >> >> maths.scm if it isn't defined publicly?

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Efraim Flashner
On Tue, Sep 13, 2016 at 02:01:33PM -0400, Kei Kebreau wrote: > Leo Famulari writes: > > > On Tue, Sep 13, 2016 at 10:37:56AM -0400, Kei Kebreau wrote: > >> Kei Kebreau writes: > >> > A component necessary for GNU Octave's GUI. > >> > How does it look? > >> Not sure how packaging Qt packages goes

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Leo Famulari
On Tue, Sep 13, 2016 at 02:59:31PM -0400, Kei Kebreau wrote: > Leo Famulari writes: > > > On Tue, Sep 13, 2016 at 02:01:33PM -0400, Kei Kebreau wrote: > >> Like below? And how could I then access qscintilla-for-octave from > >> maths.scm if it isn't defined publicly? > > > > Yes, that looks right

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Leo Famulari
On Tue, Sep 13, 2016 at 02:01:33PM -0400, Kei Kebreau wrote: > Like below? And how could I then access qscintilla-for-octave from > maths.scm if it isn't defined publicly? Yes, that looks right. But I would put qscintilla-for-octave in maths.scm to avoid the issue you describe. signature.asc Des

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Kei Kebreau
Leo Famulari writes: > On Tue, Sep 13, 2016 at 02:01:33PM -0400, Kei Kebreau wrote: >> Like below? And how could I then access qscintilla-for-octave from >> maths.scm if it isn't defined publicly? > > Yes, that looks right. But I would put qscintilla-for-octave in > maths.scm to avoid the issue y

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Kei Kebreau
Leo Famulari writes: > On Tue, Sep 13, 2016 at 10:37:56AM -0400, Kei Kebreau wrote: >> Kei Kebreau writes: >> > A component necessary for GNU Octave's GUI. >> > How does it look? >> Not sure how packaging Qt packages goes, but I've discovered that >> GNU Octave's GUI only builds with Qt4 support

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Leo Famulari
On Tue, Sep 13, 2016 at 10:37:56AM -0400, Kei Kebreau wrote: > Kei Kebreau writes: > > A component necessary for GNU Octave's GUI. > > How does it look? > Not sure how packaging Qt packages goes, but I've discovered that > GNU Octave's GUI only builds with Qt4 support. I've changed the patch to >

Re: [PATCH] gnu: Add qscintilla.

2016-09-13 Thread Kei Kebreau
s is and add a qt4 package that inherits from it? From 51da032547ed3e1c2b7825b35b1f39a5e922b44b Mon Sep 17 00:00:00 2001 From: Kei Kebreau Date: Tue, 13 Sep 2016 10:34:59 -0400 Subject: [PATCH] gnu: Add qscintilla. * gnu/packages/qt.scm (qscintilla): New variable. ---

[PATCH] gnu: Add qscintilla.

2016-09-12 Thread Kei Kebreau
A component necessary for GNU Octave's GUI. How does it look? From c6f182688ab5bd59aeca2e29d67bf527df869963 Mon Sep 17 00:00:00 2001 From: Kei Kebreau Date: Mon, 12 Sep 2016 13:27:05 -0400 Subject: [PATCH] gnu: Add qscintilla. * gnu/packages/qt.scm (qscintilla): New variable. --- gnu/pac