exceptionfactory commented on PR #6995:
URL: https://github.com/apache/nifi/pull/6995#issuecomment-1449258278
Thanks for the thoughtful reply @ChrisSamo632.
For the simple things first, it seems like the following items could be
pulled out to a simpler PR:
- address shellcheck
levilentz commented on PR #6848:
URL: https://github.com/apache/nifi/pull/6848#issuecomment-1449251032
Leaving a comment here so it doesn't go stale. Let me know if this needs any
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/NIFI-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-6250:
---
Affects Version/s: (was: 1.9.2)
> Add Kerberos authentication support to InvokeHTTP
[
https://issues.apache.org/jira/browse/NIFI-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann reassigned NIFI-6250:
--
Assignee: (was: Peter Wicks)
> Add Kerberos authentication support to InvokeHTTP
exceptionfactory commented on PR #6990:
URL: https://github.com/apache/nifi/pull/6990#issuecomment-1448952310
Thanks for the reply @nandorsoma.
The deprecation logs are a tool, sometimes suggesting alternatives, but
sometimes no alternatives are available. The log message indicating
nandorsoma commented on PR #6990:
URL: https://github.com/apache/nifi/pull/6990#issuecomment-1448936748
Thank you for the review, @exceptionfactory! I didn't know that the logger
should reference the componentClass, but it is a good idea to pass it instead
of the processorName.
szaszm commented on code in PR #1517:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1517#discussion_r1120777278
##
thirdparty/ossp-uuid/ossp-uuid-update-config-guess.patch:
##
@@ -0,0 +1,5538 @@
+diff --git a/config.guess b/config.guess
+index ca2a03c..69188da 100755
[
https://issues.apache.org/jira/browse/NIFI-11212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694734#comment-17694734
]
Joe Witt commented on NIFI-11212:
-
Agree with [~mosermw]. That said I think we went a little overboard on
[
https://issues.apache.org/jira/browse/NIFI-11212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael W Moser resolved NIFI-11212.
Resolution: Not A Bug
> default schedule time in processor changed
>
[
https://issues.apache.org/jira/browse/NIFI-11212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694733#comment-17694733
]
Michael W Moser commented on NIFI-11212:
This change was intentional, under NIFI-10628, for
szaszm commented on code in PR #1518:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1518#discussion_r1120710054
##
extensions/standard-processors/processors/ListFile.h:
##
@@ -81,19 +81,15 @@ class ListFile : public core::Processor {
private:
struct ListedFile :
fgerlits opened a new pull request, #1518:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1518
On a sample test data of 20,000 files on Windows, `onTrigger` now takes ~2.5
sec instead of ~7.5 sec in the case when all 20,000 files have been processed
already. The main changes are:
exceptionfactory commented on PR #6996:
URL: https://github.com/apache/nifi/pull/6996#issuecomment-1448769027
> If that works I want to get the unit test into a state where it is
mergeable.
Thanks, adding the unit test to the PR would be very helpful.
--
This is an
Chrzi commented on PR #6996:
URL: https://github.com/apache/nifi/pull/6996#issuecomment-1448764306
I have confirmed the behaviour using the unit test provided in the Issue,
which I also used to reproduce the bug.
At the moment I am having issues executing `mvn clean install -P
[
https://issues.apache.org/jira/browse/NIFI-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694718#comment-17694718
]
Paul Grey commented on NIFI-11233:
--
{noformat}
Error: Failed to execute goal on project
Paul Grey created NIFI-11233:
Summary: adjust Github runner configuration to use HTTP connection
pooling
Key: NIFI-11233
URL: https://issues.apache.org/jira/browse/NIFI-11233
Project: Apache NiFi
[
https://issues.apache.org/jira/browse/NIFI-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Grey reassigned NIFI-11233:
Assignee: Paul Grey
> adjust Github runner configuration to use HTTP connection pooling
>
ChrisSamo632 commented on PR #6995:
URL: https://github.com/apache/nifi/pull/6995#issuecomment-1448750600
@exceptionfactory I agree that there's utility in discussing some of the
changes being made herein, it was the main driver for raising a Draft PR
(rather than pushing through with more
Chrzi opened a new pull request, #6996:
URL: https://github.com/apache/nifi/pull/6996
# Summary
[NIFI-11232](https://issues.apache.org/jira/browse/NIFI-11232)
Under some circumstances the buffer is not recreated correctly in
[
https://issues.apache.org/jira/browse/NIFI-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694679#comment-17694679
]
Christian Wahl edited comment on NIFI-11232 at 2/28/23 6:30 PM:
Sure here
[
https://issues.apache.org/jira/browse/NIFI-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi resolved NIFI-11158.
Fix Version/s: 2.0.0
Resolution: Fixed
> PutSalesforceObject processor improvements
[
https://issues.apache.org/jira/browse/NIFI-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694681#comment-17694681
]
ASF subversion and git services commented on NIFI-11158:
Commit
asfgit closed pull request #6959: NIFI-11158 PutSalesforceObject processor
improvements
URL: https://github.com/apache/nifi/pull/6959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ChrisSamo632 opened a new pull request, #6995:
URL: https://github.com/apache/nifi/pull/6995
# Summary
[NIFI-7060](https://issues.apache.org/jira/browse/NIFI-7060) populate NiFi
and NiFi Registry properties files using env vars in
[
https://issues.apache.org/jira/browse/NIFI-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Wahl updated NIFI-11232:
--
Attachment: TestContentClaimInputStream.java
> FlowFileAccessException using
[
https://issues.apache.org/jira/browse/NIFI-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694679#comment-17694679
]
Christian Wahl commented on NIFI-11232:
---
Sure here is a test case (added to
szaszm commented on code in PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#discussion_r1120572943
##
extensions/rocksdb-repos/FlowFileRepository.cpp:
##
@@ -200,6 +200,20 @@ bool FlowFileRepository::initialize(const
std::shared_ptr )
}
[
https://issues.apache.org/jira/browse/NIFI-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694675#comment-17694675
]
ASF subversion and git services commented on NIFI-7060:
---
Commit
turcsanyip commented on PR #6959:
URL: https://github.com/apache/nifi/pull/6959#issuecomment-1448653284
@krisztina-zsihovszki Thanks for the improvements!
@mark-bathori @Lehel44 Thanks for your reviews!
Merging to main.
--
This is an automated message from the Apache Git
tpalfy commented on code in PR #6769:
URL: https://github.com/apache/nifi/pull/6769#discussion_r1113403669
##
nifi-nar-bundles/nifi-asn1-bundle/nifi-asn1-services/src/main/java/org/apache/nifi/jasn1/JASN1Reader.java:
##
@@ -134,17 +135,32 @@ public class JASN1Reader extends
tpalfy commented on code in PR #6769:
URL: https://github.com/apache/nifi/pull/6769#discussion_r1113397901
##
nifi-nar-bundles/nifi-asn1-bundle/nifi-asn1-services/src/main/java/org/apache/nifi/jasn1/preprocess/NiFiASNPreprocessor.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to
tpalfy commented on code in PR #6769:
URL: https://github.com/apache/nifi/pull/6769#discussion_r1120547354
##
nifi-nar-bundles/nifi-asn1-bundle/nifi-asn1-services/src/test/java/org/apache/nifi/jasn1/JASN1ReaderTest.java:
##
@@ -84,6 +84,7 @@ public void
tpalfy commented on code in PR #6769:
URL: https://github.com/apache/nifi/pull/6769#discussion_r1120545224
##
nifi-nar-bundles/nifi-asn1-bundle/nifi-asn1-services/src/main/resources/docs/org.apache.nifi.jasn1.JASN1Reader/additionalDetails.html:
##
@@ -122,5 +122,61 @@
tpalfy commented on code in PR #6769:
URL: https://github.com/apache/nifi/pull/6769#discussion_r1120544810
##
nifi-nar-bundles/nifi-asn1-bundle/nifi-asn1-services/src/test/java/org/apache/nifi/jasn1/preprocess/NiFiASNPreprocessorEngineTest.java:
##
@@ -0,0 +1,139 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/NIFI-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694669#comment-17694669
]
Joe Witt commented on NIFI-11232:
-
[~cwahl] Can you share an example that exposes it by chance? The PR
Christian Wahl created NIFI-11232:
-
Summary: FlowFileAccessException using ContentClaimInputStream
Key: NIFI-11232
URL: https://issues.apache.org/jira/browse/NIFI-11232
Project: Apache NiFi
[
https://issues.apache.org/jira/browse/NIFI-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Wahl updated NIFI-11232:
--
Description:
NIFI-10888 introduced a BufferedInputStream inside of the
[
https://issues.apache.org/jira/browse/NIFI-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694647#comment-17694647
]
ASF subversion and git services commented on NIFI-11161:
Commit
greyp9 closed pull request #6939: NIFI-11161 Simplify
KeyedCipherPropertyEncryptor
URL: https://github.com/apache/nifi/pull/6939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/NIFI-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Grey updated NIFI-11210:
-
Status: Patch Available (was: In Progress)
> Missing network read timeout in
greyp9 opened a new pull request, #6994:
URL: https://github.com/apache/nifi/pull/6994
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira
Lehel44 commented on PR #6959:
URL: https://github.com/apache/nifi/pull/6959#issuecomment-1448470323
Thanks for the changes @krisztina-zsihovszki. LGTM+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Lehel44 commented on code in PR #6959:
URL: https://github.com/apache/nifi/pull/6959#discussion_r1120139647
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/util/SalesforceRestService.java:
##
@@ -103,6
slambrose opened a new pull request, #6993:
URL: https://github.com/apache/nifi/pull/6993
# Summary
[NIFI-11231](https://issues.apache.org/jira/browse/NIFI-11231)
# Tracking
Please complete the following tracking steps
[
https://issues.apache.org/jira/browse/NIFI-11231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dye357 updated NIFI-11231:
--
Summary: Stateless Nifi Supports Secure Parameter Context Variables (was:
Stateless Nifi Supports Secure
Dye357 created NIFI-11231:
-
Summary: Stateless Nifi Supports Secure Parameter Contexts
Key: NIFI-11231
URL: https://issues.apache.org/jira/browse/NIFI-11231
Project: Apache NiFi
Issue Type: Bug
exceptionfactory commented on code in PR #6990:
URL: https://github.com/apache/nifi/pull/6990#discussion_r1120240266
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-shared/src/main/java/org/apache/nifi/kafka/shared/validation/KafkaDeprecationValidator.java:
##
@@ -0,0 +1,57 @@
szaszm commented on code in PR #1515:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1515#discussion_r1120199726
##
extensions/windows-event-log/wel/JSONUtils.cpp:
##
@@ -162,9 +186,4 @@ std::string jsonToString(const rapidjson::Document& doc) {
doc.Accept(writer);
martinzink commented on code in PR #1515:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1515#discussion_r1120173953
##
extensions/windows-event-log/wel/JSONUtils.cpp:
##
@@ -162,9 +186,4 @@ std::string jsonToString(const rapidjson::Document& doc) {
doc.Accept(writer);
Lehel44 commented on code in PR #6959:
URL: https://github.com/apache/nifi/pull/6959#discussion_r1120139647
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/util/SalesforceRestService.java:
##
@@ -103,6
Lehel44 commented on code in PR #6959:
URL: https://github.com/apache/nifi/pull/6959#discussion_r1120139647
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/util/SalesforceRestService.java:
##
@@ -103,6
Lehel44 commented on code in PR #6959:
URL: https://github.com/apache/nifi/pull/6959#discussion_r1120120932
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/PutSalesforceObject.java:
##
@@ -170,24 +177,30
Lehel44 commented on code in PR #6959:
URL: https://github.com/apache/nifi/pull/6959#discussion_r1120117231
##
nifi-mock/src/main/java/org/apache/nifi/util/TestRunner.java:
##
@@ -1062,4 +1063,6 @@ void assertAttributes(
*/
void setRunSchedule(long runSchedule);
+
Lehel44 commented on code in PR #6959:
URL: https://github.com/apache/nifi/pull/6959#discussion_r1120116567
##
nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java:
##
@@ -1056,4 +1058,12 @@ public void assertAllConditionsMet(final Relationship
martinzink commented on code in PR #1517:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1517#discussion_r1120105930
##
libminifi/test/unit/StringUtilsTests.cpp:
##
@@ -388,30 +390,22 @@ TEST_CASE("TestStringUtils::testBase64Decode", "[test
base64 decode]") {
martinzink commented on code in PR #1517:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1517#discussion_r1120105778
##
thirdparty/ossp-uuid/ossp-uuid-update-config-guess.patch:
##
@@ -0,0 +1,5538 @@
+diff --git a/config.guess b/config.guess
+index ca2a03c..69188da
szaszm commented on code in PR #1517:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1517#discussion_r1120058939
##
libminifi/test/unit/StringUtilsTests.cpp:
##
@@ -388,30 +390,22 @@ TEST_CASE("TestStringUtils::testBase64Decode", "[test
base64 decode]") {
szaszm commented on code in PR #1517:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1517#discussion_r1120056512
##
thirdparty/ossp-uuid/ossp-uuid-update-config-guess.patch:
##
@@ -0,0 +1,5538 @@
+diff --git a/config.guess b/config.guess
+index ca2a03c..69188da 100755
szaszm commented on code in PR #1517:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1517#discussion_r1120055690
##
libminifi/test/unit/StringUtilsTests.cpp:
##
@@ -388,30 +390,22 @@ TEST_CASE("TestStringUtils::testBase64Decode", "[test
base64 decode]") {
[
https://issues.apache.org/jira/browse/MINIFICPP-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-2058:
---
Description:
With the [MINIFICPP-2048 ARM64 support part
Martin Zink created MINIFICPP-2058:
--
Summary: AWS extension fails to load on ARM64
Key: MINIFICPP-2058
URL: https://issues.apache.org/jira/browse/MINIFICPP-2058
Project: Apache NiFi MiNiFi C++
[
https://issues.apache.org/jira/browse/MINIFICPP-2049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-2049:
---
Status: Patch Available (was: Open)
https://github.com/apache/nifi-minifi-cpp/pull/1517
[
https://issues.apache.org/jira/browse/MINIFICPP-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-2050:
---
Status: Patch Available (was: Open)
https://github.com/apache/nifi-minifi-cpp/pull/1517
[
https://issues.apache.org/jira/browse/MINIFICPP-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-2052:
---
Status: Patch Available (was: Open)
https://github.com/apache/nifi-minifi-cpp/pull/1517
[
https://issues.apache.org/jira/browse/MINIFICPP-2051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-2051:
---
Status: Patch Available (was: Open)
https://github.com/apache/nifi-minifi-cpp/pull/1517
[
https://issues.apache.org/jira/browse/MINIFICPP-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-2047:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
szaszm commented on code in PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#discussion_r1120017294
##
libminifi/test/rocksdb-tests/DBContentRepositoryTests.cpp:
##
@@ -159,7 +159,7 @@ TEST_CASE("Delete NonExistent Claim", "[TestDBCR4]") {
[
https://issues.apache.org/jira/browse/MINIFICPP-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-1887:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
adamdebreceni commented on code in PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#discussion_r1120015965
##
libminifi/test/rocksdb-tests/DBContentRepositoryTests.cpp:
##
@@ -159,7 +159,7 @@ TEST_CASE("Delete NonExistent Claim", "[TestDBCR4]") {
adamdebreceni commented on code in PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#discussion_r1120013803
##
libminifi/test/rocksdb-tests/DBContentRepositoryTests.cpp:
##
@@ -159,7 +159,7 @@ TEST_CASE("Delete NonExistent Claim", "[TestDBCR4]") {
szaszm commented on code in PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#discussion_r112653
##
libminifi/test/rocksdb-tests/DBContentRepositoryTests.cpp:
##
@@ -159,7 +159,7 @@ TEST_CASE("Delete NonExistent Claim", "[TestDBCR4]") {
szaszm closed pull request #1510: MINIFICPP-2047 added reverseDnsLookup to
Expression Language
URL: https://github.com/apache/nifi-minifi-cpp/pull/1510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
szaszm closed pull request #1501: MINIFICPP-1887 Add default connection size
limits
URL: https://github.com/apache/nifi-minifi-cpp/pull/1501
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
adamdebreceni commented on code in PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#discussion_r1119993446
##
extensions/rocksdb-repos/DatabaseContentRepository.cpp:
##
@@ -72,13 +87,40 @@ bool DatabaseContentRepository::initialize(const
adamdebreceni commented on code in PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#discussion_r1119992159
##
libminifi/test/rocksdb-tests/DBContentRepositoryTests.cpp:
##
@@ -159,7 +159,7 @@ TEST_CASE("Delete NonExistent Claim", "[TestDBCR4]") {
martinzink opened a new pull request, #1517:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1517
MINIFICPP-2049 update crc32c
MINIFICPP-2050 AWS tests compilation fix for ARM
MINIFICPP-2051 updated ossp-uuid config.guess
MINIFICPP-2052 unsigned/signed char fixes
With
szaszm commented on code in PR #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516#discussion_r1119956317
##
libminifi/test/rocksdb-tests/DBContentRepositoryTests.cpp:
##
@@ -159,7 +159,7 @@ TEST_CASE("Delete NonExistent Claim", "[TestDBCR4]") {
adamdebreceni opened a new pull request, #1516:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1516
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
pvillard31 commented on code in PR #6991:
URL: https://github.com/apache/nifi/pull/6991#discussion_r1119946978
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/QuerySalesforceObject.java:
##
@@ -326,24
[
https://issues.apache.org/jira/browse/MINIFICPP-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-2050:
---
Summary: AWS tests compile failure on ARM (was: AWS extension compile
failure on ARM)
80 matches
Mail list logo
