hg: jigsaw/jake/jdk: 8136433: Intermittent NPE in ResourceBundle

2015-09-24 Thread mandy . chung
Changeset: a4ab00fa0f96 Author:okutsu Date: 2015-09-24 16:49 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a4ab00fa0f96 8136433: Intermittent NPE in ResourceBundle Reviewed-by: naoto, mchung ! src/java.base/share/classes/sun/util/resources/Bundles.java ! src/java.base/s

Re-examine ClassLoader.getPackage(s) methods

2015-09-25 Thread Mandy Chung
In Jake, we fixed several long-standing issues about ClassLoader::getPackage(s) and ClassLoader::definePackage method. 4302423: class loaders should support "local" creation of Package objects 4841786: (cl) flaw in ClassLoader getPackage/definePackage API 4302406 Package sealing and crea

Re: Re-examine ClassLoader.getPackage(s) methods

2015-09-26 Thread Mandy Chung
> On Sep 26, 2015, at 7:33 AM, Alan Bateman wrote: > This looks good. I think I would lean more to deprecating getPackage as just > too fragile and leads to difficult to diagnose bugs. Are you also suggesting to deprecate ClassLoader::getPackages as well? > BTW: I assume the proxy test is a s

Re: Re-examine ClassLoader.getPackage(s) methods

2015-09-28 Thread Mandy Chung
On 09/27/2015 01:29 AM, Alan Bateman wrote: On 26/09/2015 19:28, Mandy Chung wrote: On Sep 26, 2015, at 7:33 AM, Alan Bateman wrote: This looks good. I think I would lean more to deprecating getPackage as just too fragile and leads to difficult to diagnose bugs. Are you also suggesting

hg: jigsaw/jake/jdk: 8136444: ClassLoader::getPackage stop looking at parent class loader prevent NB starting

2015-09-28 Thread mandy . chung
Changeset: 5805781b9370 Author:mchung Date: 2015-09-28 16:30 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5805781b9370 8136444: ClassLoader::getPackage stop looking at parent class loader prevent NB starting Reviewed-by: abuckley, alanb ! src/java.base/share/classes/j

hg: jigsaw/jake/jdk: 2 new changesets

2015-09-28 Thread mandy . chung
Changeset: 5f781c90d35b Author:mchung Date: 2015-09-28 16:31 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5f781c90d35b New test to create proxies with layer + test/jdk/jigsaw/reflect/Proxy/ProxyLayerTest.java Changeset: 189f83e533d0 Author:mchung Date: 2015-0

hg: jigsaw/jake/jdk: Update module-summary.html

2015-09-28 Thread mandy . chung
Changeset: e922b207c170 Author:mchung Date: 2015-09-28 18:44 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e922b207c170 Update module-summary.html ! make/src/classes/build/tools/jigsaw/ModuleSummary.java

Re: Re-examine ClassLoader.getPackage(s) methods

2015-09-29 Thread Mandy Chung
ing)? > Good catch. It should for the same reason as described in ClassLoader::getPackage. Mandy > best regards, > > -- daniel > > > > On 28/09/15 21:36, Mandy Chung wrote: >> >> >> On 09/27/2015 01:29 AM, Alan Bateman wrote: >>> >&

hg: jigsaw/jake/jaxws: Update jaxws to look up resources from named modules

2015-09-29 Thread mandy . chung
Changeset: 49c4220a2a43 Author:mkos Date: 2015-09-29 11:03 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/49c4220a2a43 Update jaxws to look up resources from named modules ! src/java.xml.ws/share/classes/com/sun/xml/internal/ws/api/server/SDDocumentSource.java ! src/

hg: jigsaw/jake/jdk: Deprecate Package::getPackage as ClassLoader::getPackage does

2015-09-29 Thread mandy . chung
Changeset: deb77851e5fd Author:mchung Date: 2015-09-29 12:36 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/deb77851e5fd Deprecate Package::getPackage as ClassLoader::getPackage does ! src/java.base/share/classes/java/lang/Package.java ! src/java.desktop/share/classes/ja

hg: jigsaw/jake/jdk: Remove workaround to filter _the.* files from jmod

2015-10-01 Thread mandy . chung
Changeset: d885f95c958a Author:mchung Date: 2015-10-01 15:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d885f95c958a Remove workaround to filter _the.* files from jmod ! make/src/classes/build/tools/jigsaw/ModuleSummary.java

hg: jigsaw/jake/jdk: Class::getPackage should return null for array type, primitive type or void

2015-10-02 Thread mandy . chung
Changeset: 375469dd1809 Author:mchung Date: 2015-10-02 08:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/375469dd1809 Class::getPackage should return null for array type, primitive type or void ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/c

hg: jigsaw/jake/jdk: Remove temporary check in MethodUtil.invoke

2015-10-02 Thread mandy . chung
Changeset: b2bb04afd368 Author:mchung Date: 2015-10-02 08:26 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/b2bb04afd368 Remove temporary check in MethodUtil.invoke ! src/java.base/share/classes/sun/reflect/misc/MethodUtil.java

hg: jigsaw/jake/jdk: jdk.hprof.agent has been removed and module loader map needs update

2015-10-02 Thread mandy . chung
Changeset: 937f4cfe2cab Author:mchung Date: 2015-10-02 16:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/937f4cfe2cab jdk.hprof.agent has been removed and module loader map needs update ! make/gensrc/GensrcModuleLoaderMap.gmk

jlink plugin experiment to improve jake startup time

2015-10-05 Thread Mandy Chung
I have been experimenting a jlink plugin to improve the module system startup time. On a Quad-Core Intel Xeon E5 @3.7 GHz, 16G memory (Mac Pro) machine, the module system startup takes 110 ms and 75% of it is to reconstitute 64 module descriptors with 2388 packages altogether. This high overh

Review request 8132297: JDK9 build.tools.module.ImageBuilder does not filter out .class.bc files

2015-10-05 Thread Mandy Chung
JDK 9 currently use a build tool (ImageBuilder) to create the JDK modular image. A in-house tool doing static analysis generates additional files that should be excluded in the image. jlink and jmod tool in jake build has the option to exclude specific files. This patch proposes to fix the int

hg: jigsaw/jake/jdk: Update test/java/util/ResourceBundle/Bug6299235Test.sh to use -Xpatch

2015-10-05 Thread mandy . chung
Changeset: 9a3cd31c64df Author:mchung Date: 2015-10-05 18:03 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/9a3cd31c64df Update test/java/util/ResourceBundle/Bug6299235Test.sh to use -Xpatch ! test/ProblemList.jake.txt ! test/java/util/ResourceBundle/Bug6299235Test.sh

Re: jlink plugin experiment to improve jake startup time

2015-10-06 Thread Mandy Chung
I realize I missed the attachment after seeing Claes’ question. This includes the heap usage after GC. > On Oct 5, 2015, at 2:13 PM, Mandy Chung wrote: > > I have been experimenting a jlink plugin to improve the module system startup > time. On a Quad-Core Intel Xeon E5 @

Re: RFR: JDK-8138960 - Module version is checked incorrectly in libjimage

2015-10-06 Thread Mandy Chung
> On Oct 6, 2015, at 6:28 AM, Alan Bateman wrote: > > > On 06/10/2015 14:22, Jim Laskey (Oracle) wrote: >> Verona pit failing do to NEXT_VERSION +1 . libjimage code assumed that the >> module version would be constant until some later date. >> >> http://cr.openjdk.java.net/~jlaskey/8138960/w

Re: jlink plugin experiment to improve jake startup time

2015-10-06 Thread Mandy Chung
See http://cr.openjdk.java.net/~mchung/jigsaw/jake-startup.20151005.pdf Mandy p.s. In fact the attachment got trimmed. > On Oct 6, 2015, at 7:31 AM, Mandy Chung wrote: > > I realize I missed the attachment after seeing Claes’ question. This > includes the heap us

Re: jlink plugin experiment to improve jake startup time

2015-10-06 Thread Mandy Chung
> On Oct 6, 2015, at 4:38 AM, Claes Redestad wrote: > > Hi Mandy, > > On 2015-10-05 23:13, Mandy Chung wrote: >> I have been experimenting a jlink plugin to improve the module system >> startup time. On a Quad-Core Intel Xeon E5 @3.7 GHz, 16G memory (Mac Pro) &g

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-07 Thread Mandy Chung
ToolProvider.getSystemJavaCompiler() will return the system compiler (javac) from the image. Is there any reason why you can’t use that? It seems to me that the exception is thrown because com.sun.tools.javac.api.JavacTool member is called. Mandy > On Oct 7, 2015, at 6:01 PM, Keimpe Bronkhor

hg: jigsaw/jake/jdk: 8137317: InternalError thrown when Logger.getLogger loads resource bundle from an unnamed module

2015-10-08 Thread mandy . chung
Changeset: e105625ec661 Author:mchung Date: 2015-10-08 10:32 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e105625ec661 8137317: InternalError thrown when Logger.getLogger loads resource bundle from an unnamed module Contributed-by: masayoshi.oku...@oracle.com ! src/ja

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Mandy Chung
On 10/08/2015 04:49 AM, Jaroslav Bachorik wrote: Please, review the following change Issue : https://bugs.openjdk.java.net/browse/JDK-7199353 Webrev: http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/top http://cr.openjdk.java.net/~jbachorik/7199353/webrev.00/jdk I think #2 in the rul

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-08 Thread Mandy Chung
On 10/08/2015 05:41 AM, Alan Bateman wrote: I'm not sure that I agree with logging a warning when java.beans.ConstructorProperties is used. I would be tempted to leave that out. The idea is that we want users to stop using @j.b.CP for JMX purposes. So we might as well warn them about the sub

Re: Warning: Cannot use jsr199 Javac from jrt-fs.jar"

2015-10-08 Thread Mandy Chung
What is the parent class loader of the class loader defining the class from JDK 8 tools.jar? Is it null? Mandy > On Oct 8, 2015, at 2:08 PM, Keimpe Bronkhorst > wrote: > > Alan, > > I'm running JDeveloper with jigsaw build > 1.9.0-ea-jigsaw-nightly-h3477-20150929-b83. Compiling in-process

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-09 Thread Mandy Chung
On 10/09/2015 11:33 AM, Alex Buckley wrote: On 10/9/2015 1:03 AM, Jaroslav Bachorik wrote: Well, if anything the @CP annotation is related to javax.management.openmbean package. All the OpenType and CompositeData definitions are in this package. @CP annotation is used to influence the way a Comp

hg: jigsaw/jake/jdk: Fix InternalError thrown by Class.forName

2015-10-12 Thread mandy . chung
Changeset: f7e100339605 Author:mchung Date: 2015-10-12 20:22 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f7e100339605 Fix InternalError thrown by Class.forName ! src/java.base/share/classes/java/lang/Class.java

Re: Review request for 8139508 Debug option does not work in appletviewer

2015-10-13 Thread Mandy Chung
> On Oct 13, 2015, at 7:00 AM, Alan Bateman wrote: > > > On 13/10/2015 14:33, Alexander Scherbatiy wrote: >> >> Hello, >> >> Could you review the fix: >> bug: https://bugs.openjdk.java.net/browse/JDK-8139508 >> webrev: http://cr.openjdk.java.net/~alexsch/8139508/webrev.00 >> >> This is th

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-14 Thread Mandy Chung
> On Oct 14, 2015, at 7:25 AM, Alan Bateman wrote: > >> Hm, shouldn't we name the new annotation differently then? >> @ConstructorMapping ? It is not mandatory that we keep the actual name - we >> are changing the package anyway ... > This may have been discussed previously, Mandy might know.

Re: RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-14 Thread Mandy Chung
> On Oct 14, 2015, at 2:36 AM, Jaroslav Bachorik > wrote: > > On 8.10.2015 13:49, Jaroslav Bachorik wrote: >> Please, review the following change >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-7199353 > > Round 2 webrev: http://cr.openjdk.java.net/~jbachorik/7199353/webrev.01 That lo

hg: jigsaw/jake/jdk: 8129126: New logging tests to work with modules

2015-10-15 Thread mandy . chung
Changeset: 4ee3a4b785ef Author:mchung Date: 2015-10-15 21:06 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/4ee3a4b785ef 8129126: New logging tests to work with modules Reviewed-by: dfuchs, mchung Contributed-by: huaming...@oracle.com + test/java/util/logging/modules/Get

Re: InternalError on Class.getPackage()

2015-10-19 Thread Mandy Chung
Hi Chris, Thanks for reporting this (this is not a known issue). java.lang.InternalError: unnamed package in named module java.base The case with the unnamed package defined by the boot loader is the types from -Xbootclasspath/a. Is -Xbootclasspath/a being used? Mandy On 10/19/2015 02:50 P

Re: jmx-dev RFR 7199353: Allow ConstructorProperties annotation from any package

2015-10-19 Thread Mandy Chung
> On Oct 16, 2015, at 5:04 AM, Jaroslav Bachorik > wrote: > > On 15.10.2015 21:32, Alan Bateman wrote: >> >> On 15/10/2015 16:55, Jaroslav Bachorik wrote: >>> >>> Any objections to changing the annotation name to @ConstructorMapping >>> to make it better distinguishable from >>> @java.beans.C

hg: jigsaw/jake/jdk: Improve error message in Class.getPackage to help troubeshooting

2015-10-19 Thread mandy . chung
Changeset: d7adac71ce63 Author:mchung Date: 2015-10-19 18:35 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/d7adac71ce63 Improve error message in Class.getPackage to help troubeshooting ! src/java.base/share/classes/jdk/internal/misc/BuiltinClassLoader.java

Re: InternalError on Class.getPackage()

2015-10-19 Thread Mandy Chung
> On Oct 19, 2015, at 6:04 PM, Alan Bateman wrote: > > On 19/10/2015 22:58, Mandy Chung wrote: >> Hi Chris, >> >> Thanks for reporting this (this is not a known issue). >> >> java.lang.InternalError: unnamed package in named module java.base >> &g

Re: InternalError on Class.getPackage()

2015-10-20 Thread Mandy Chung
Thanks Chris for trying this. I tried a test program calling boolean.class.getPackage(). I can reproduce this with jake b83 but no longer able to reproduce with jake's tip. I also tried building JITWatch and it works (I’m not sure if I set up everything right). Lois and Harold, do you reco

hg: jigsaw/jake/langtools: Initial support for jdeps -genmoduleinfo option

2015-10-20 Thread mandy . chung
Changeset: 9504efc77849 Author:mchung Date: 2015-10-20 23:13 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/9504efc77849 Initial support for jdeps -genmoduleinfo option ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Analyzer.java + src/jdk.jdeps/share/classes/co

hg: jigsaw/jake/langtools: Should not generate module-info.java if it contains an unnamed package

2015-10-20 Thread mandy . chung
Changeset: ce2237f87c34 Author:mchung Date: 2015-10-20 23:47 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/ce2237f87c34 Should not generate module-info.java if it contains an unnamed package ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleInfoBuilder.java

hg: jigsaw/jake/langtools: Add jdeps -R -ct option.

2015-10-21 Thread mandy . chung
Changeset: f99c96f9f9f9 Author:mchung Date: 2015-10-21 22:29 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f99c96f9f9f9 Add jdeps -R -ct option. Also remove -verify:access option. ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/Analyzer.java ! src/jdk.jdeps/shar

hg: jigsaw/jake/jdk: 8138626: java.awt.Window.applyResourceBundle fails to find resource bundle

2015-10-25 Thread mandy . chung
Changeset: 22839e63cbda Author:okutsu Date: 2015-10-25 19:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/22839e63cbda 8138626: java.awt.Window.applyResourceBundle fails to find resource bundle Reviewed-by: mchung ! src/java.desktop/share/classes/java/awt/Window.java

Re: RFR: 8140336: Add @modules for exported dependencies to jdk_core tests

2015-10-26 Thread Mandy Chung
> On Oct 26, 2015, at 10:13 AM, Alexandre (Shura) Iline > wrote: > > Hi. > > Could you please take a look on the suggested change in tests belonging to > jdk_core test group. > > Pls notice that the dependencies which would later be removed by fixing > JDK-8139430 we not added in this chang

hg: jigsaw/jake/jdk: Jlink plugin for fast reconstitution of module descriptors of installed modules

2015-10-26 Thread mandy . chung
Changeset: 06bc945b812d Author:mchung Date: 2015-10-26 17:56 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/06bc945b812d Jlink plugin for fast reconstitution of module descriptors of installed modules To enable this plugin, use jlink --gen-installed-modules on option. -

hg: jigsaw/jake/jdk: Jake patch for 8140336: Add @modules for exported dependencies to jdk_core tests

2015-10-27 Thread mandy . chung
Changeset: 1b632228f7e5 Author:shurailine Date: 2015-10-27 20:12 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1b632228f7e5 Jake patch for 8140336: Add @modules for exported dependencies to jdk_core tests Reviewed-by: alanb, mchung ! test/java/lang/Class/GetModuleTest.j

Re: RFR: 8140336: Add @modules for exported dependencies to jdk_core tests

2015-10-27 Thread Mandy Chung
> On Oct 27, 2015, at 6:36 AM, Alexandre (Shura) Iline > wrote: > > I have created two separate reviews: > http://cr.openjdk.java.net/~shurailine/8140336/webrev.jdk9.02/ > http://cr.openjdk.java.net/~shurailine/8140336/webrev.jake.02/ Thanks. I have pushed webrev.jdk9.02 to jdk9/dev and webre

Re: RFR 9: 8139390 : Very long classname in jimage causes SIGSEGV

2015-10-29 Thread Mandy Chung
Resource file of zero-length module name and package name should not be allowed to be written to jimage. The moduleName > 0 and packageName > 0 should be an assertion; exception if fails. Mandy > On Oct 29, 2015, at 1:09 PM, Dmitry Samersoff > wrote: > > Roger, > > ImageNativeSubstrate.cpp

Re: RFR 9: 8139390 : Very long classname in jimage causes SIGSEGV

2015-10-29 Thread Mandy Chung
> On Oct 27, 2015, at 11:40 PM, Roger Riggs wrote: > > Please review an update to the jimage reader implementation to correct the > case where a class name is very long causing a SEGV due to buffer overruns. > > The fix will be pushed to the hs-comp repo; the bug was first spotted there. I sug

Re: RFR 9: 8139390 : Very long classname in jimage causes SIGSEGV

2015-10-29 Thread Mandy Chung
> On Oct 29, 2015, at 4:22 PM, Roger Riggs wrote: > > Hi Mandy, > > Collapsing the emails. > > As for asserting that module name is never null; > it appears that the module name is not being supplied by the VM. (in hs-comp > or jdk9). > > On 10/29/15 12:59

Re: RFR: 8139067: Re-examine if a consumer module should load bundles from unnamed module

2015-10-29 Thread Mandy Chung
> On Oct 29, 2015, at 4:55 PM, Masayoshi Okutsu > wrote: > > Hello, > > Please review the change for JDK-8139067. A consumer module > (ResourceBundle.getBundle caller) will no longer load resource bundles from > the class-path if the consumer module is a named module. Test programs, basic >

hg: jigsaw/jake/jdk: 8139067: Re-examine if a consumer module should load bundles from unnamed module

2015-10-29 Thread mandy . chung
Changeset: 1ac78e4a10d5 Author:okutsu Date: 2015-10-29 19:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/1ac78e4a10d5 8139067: Re-examine if a consumer module should load bundles from unnamed module Reviewed-by: alanb, mchung, naoto ! src/java.base/share/classes/sun/

Re: JOSM feedback on Java 7,8,9, including Jigsaw EA

2015-10-30 Thread Mandy Chung
Thanks for reporting these issues. > On Oct 30, 2015, at 8:29 AM, Vincent Privat > wrote: > > Concerning Jigsaw: > - We have reported 3 bugs. All made it to the public JIRA: 8138878, > 8140477, 8140481. The second one is a bit problematic for our tests as it > basically kills our Jenkins instan

hg: jigsaw/jake/jdk: Update java.util.spi.AbstractResourceBundleProvider javadoc per the fix for 8139067

2015-10-31 Thread mandy . chung
Changeset: 0b5cbd1f966e Author:mchung Date: 2015-10-31 21:55 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0b5cbd1f966e Update java.util.spi.AbstractResourceBundleProvider javadoc per the fix for 8139067 ! src/java.base/share/classes/java/util/spi/AbstractResourceBundl

hg: jigsaw/jake/langtools: Update T6769027.java to use JavacMessages.add(ResourceBundleHelper)

2015-11-01 Thread mandy . chung
Changeset: 056daf65e292 Author:mchung Date: 2015-11-01 20:05 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/056daf65e292 Update T6769027.java to use JavacMessages.add(ResourceBundleHelper) ! test/tools/javac/Diagnostics/6769027/T6769027.java

hg: jigsaw/jake/jdk: Class.forName(Module, String) supports for unnamed module

2015-11-06 Thread mandy . chung
Changeset: a87d4be5e220 Author:mchung Date: 2015-11-06 22:37 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/a87d4be5e220 Class.forName(Module, String) supports for unnamed module ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/C

hg: jigsaw/jake/jdk: Enable jlink gen-installed-modules plugin by default

2015-11-07 Thread mandy . chung
Changeset: 3f859f4a29bf Author:mchung Date: 2015-11-07 13:02 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/3f859f4a29bf Enable jlink gen-installed-modules plugin by default ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/InstalledModuleDescriptorPlugin.j

Re: Technical question about the Java Dependency Analysis Tool

2015-11-10 Thread Mandy Chung
jdeps already has the option finding the JAR files needed to compile A.jar. There is a new jdeps option added to Jigsaw EA build [1] to make this easier: $ jdeps -s -ct -R -cp lib/* A.jar This will transitively find all dependencies from the references in A.jar and shows the summary of the JAR-

Re: RFR: 8139430

2015-11-10 Thread Mandy Chung
> On Nov 10, 2015, at 10:11 AM, Alexandre (Shura) Iline > wrote: > >> >> On Nov 10, 2015, at 9:04 PM, Mandy Chung wrote: >> >> Hi Shura, >> >> Thanks for doing it and it’s good to see the unnecessary dependency to >> java.management el

Re: RFR: 8139430

2015-11-10 Thread Mandy Chung
Hi Shura, Thanks for doing it and it’s good to see the unnecessary dependency to java.management eliminated. The new jdk.testlibrary.management package name is fine. It’s okay to keep the class name InputArguments as Jaroslav suggests and it’s easier to tell what this class is about. There i

Re: RFR: 8139430

2015-11-10 Thread Mandy Chung
> On Nov 10, 2015, at 12:42 PM, Alan Bateman wrote: > > Would it break many tests if getProcessId were changed to return long to > match ProcessHandle::getPid? There are not small number of tests doing Integer.toString(ProcessTools.getProcessId())); Most of them are in hotspot and there a

Re: Proposal to enhance jdeps tool to search split packages/add some kind of general API

2015-11-12 Thread Mandy Chung
> On Nov 12, 2015, at 2:39 AM, Patrick Reinhart wrote: > > Hi there, > > I like to do some early adoption tests with software using the new module > system. Now we got an unknown amount of split packages in our system, the we > will need to fix in order to migrate our codebase. > > I could i

hg: jigsaw/jake/jdk: Backout compressed resource header length change that breaks windows build

2015-11-12 Thread mandy . chung
Changeset: 103e023995ba Author:mchung Date: 2015-11-12 18:51 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/103e023995ba Backout compressed resource header length change that breaks windows build ! src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressedR

Re: Proposal to enhance jdeps tool to search split packages/add some kind of general API

2015-11-13 Thread Mandy Chung
> On Nov 13, 2015, at 1:03 AM, Patrick Reinhart wrote: > > I do not actually understand, what you mean by overlapping vs. partitioned > ones? I somehow did not got it… Let’s say package p is split across three jar files: jar1 contains p.P1, p.P2, p.P3 jar2 contains p.P1 jar3 contains p.P4, p

hg: jigsaw/jake: 65 new changesets

2015-11-13 Thread mandy . chung
Changeset: 0c140bff9257 Author:lana Date: 2015-10-19 00:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/0c140bff9257 Added tag jdk9-b87 for changeset fd4f4f756107 ! .hgtags Changeset: a7ec2278c13d Author:ihse Date: 2015-10-12 11:49 +0200 URL: http://hg.open

hg: jigsaw/jake/jdk: 161 new changesets

2015-11-13 Thread mandy . chung
Changeset: 0198481aa9bd Author:lana Date: 2015-10-19 00:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/0198481aa9bd Added tag jdk9-b87 for changeset 110fc90bdfa0 ! .hgtags Changeset: e860e54043fd Author:aefimov Date: 2015-10-10 12:52 +0300 URL: http://

hg: jigsaw/jake/jaxws: 12 new changesets

2015-11-13 Thread mandy . chung
Changeset: 136e8bcba562 Author:lana Date: 2015-10-19 00:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/136e8bcba562 Added tag jdk9-b87 for changeset f7dba191a38c ! .hgtags Changeset: 3d533243505d Author:aefimov Date: 2015-10-16 19:07 +0300 URL: http:

hg: jigsaw/jake/corba: 13 new changesets

2015-11-13 Thread mandy . chung
Changeset: 00f48ecbc099 Author:lana Date: 2015-10-19 00:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/00f48ecbc099 Added tag jdk9-b87 for changeset a5c40ac9b916 ! .hgtags Changeset: 98075de2b055 Author:lana Date: 2015-10-22 08:47 -0700 URL: http://h

hg: jigsaw/jake/nashorn: 43 new changesets

2015-11-13 Thread mandy . chung
Changeset: 061682b25ca9 Author:lana Date: 2015-10-19 00:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/061682b25ca9 Added tag jdk9-b87 for changeset 0bf2fe0c7b32 ! .hgtags Changeset: 0cae16c0043d Author:attila Date: 2015-10-12 10:27 +0200 URL: http

hg: jigsaw/jake: Add hotspot to javadoc -modulesourcepath

2015-11-13 Thread mandy . chung
Changeset: cdf7dd951649 Author:mchung Date: 2015-11-13 21:51 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/cdf7dd951649 Add hotspot to javadoc -modulesourcepath ! make/Javadoc.gmk

hg: jigsaw/jake/jdk: Add new modular resource bundle test

2015-11-13 Thread mandy . chung
Changeset: f83388bef364 Author:okutsu Date: 2015-11-13 22:20 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/f83388bef364 Add new modular resource bundle test + test/java/util/ResourceBundle/modules/visibility/src/embargo/jdk/embargo/TestWithNoModuleArg.java + test/java

Re: JDeps: detecting offending packages

2015-11-14 Thread Mandy Chung
> On Nov 14, 2015, at 7:20 AM, Alan Bateman wrote: > > On 13/11/2015 21:58, Robert Scholte wrote: >> : >> >> Previous versions of JDK9 gave me the following output: >> >> classes -> java.base >>(classes) >> -> java.io >> -> java.lang >> -> sun.misc

hg: jigsaw/jake/langtools: 39 new changesets

2015-11-16 Thread mandy . chung
Changeset: 288f18dd9157 Author:lana Date: 2015-10-19 00:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/288f18dd9157 Added tag jdk9-b87 for changeset 45f796d8cdcd ! .hgtags Changeset: 79e637c1e083 Author:mcimadamore Date: 2015-10-12 12:24 +0100 URL:

hg: jigsaw/jake/jaxp: 18 new changesets

2015-11-16 Thread mandy . chung
Changeset: 4700fd67e942 Author:lana Date: 2015-10-19 00:25 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/4700fd67e942 Added tag jdk9-b87 for changeset eb435c878c2c ! .hgtags Changeset: 27b625ce80f4 Author:lana Date: 2015-10-22 08:47 -0700 URL: http://hg

hg: jigsaw/jake/hotspot: 226 new changesets

2015-11-16 Thread mandy . chung
Changeset: bc48b669bc66 Author:lana Date: 2015-10-19 00:24 -0700 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/bc48b669bc66 Added tag jdk9-b87 for changeset d7ffd16382fe ! .hgtags Changeset: b0e0a53226fd Author:lana Date: 2015-10-22 08:47 -0700 URL: http:/

hg: jigsaw/jake/jdk: 3 new changesets

2015-11-16 Thread mandy . chung
Changeset: 5babde7bd078 Author:jjg Date: 2015-11-13 15:55 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/5babde7bd078 8142996: move jdk java/util/streams tests into java.base directories Reviewed-by: mchung ! test/java/util/stream/bootlib/TEST.properties + test/java/util

hg: jigsaw/jake/hotspot: Add uses/provides for jdk.vm.ci module

2015-11-16 Thread mandy . chung
Changeset: 40952d9e4128 Author:mchung Date: 2015-11-16 22:11 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/40952d9e4128 Add uses/provides for jdk.vm.ci module ! src/jdk.vm.ci/share/classes/module-info.java

Re: JDeps: detecting offending packages

2015-11-17 Thread Mandy Chung
The RFE for jdeps would be to take into the module descriptor into account and see what other thing it could report (e.g. missing require public, stale require, etc). Mandy > regards, > Robert > > Op Sat, 14 Nov 2015 17:29:58 +0100 schreef Alan Bateman > : > &

Re: RFR: 8139430

2015-11-17 Thread Mandy Chung
> On Nov 16, 2015, at 5:38 AM, Alan Bateman wrote: > > > > On 16/11/2015 13:01, Alexandre (Shura) Iline wrote: >> V6: >> http://cr.openjdk.java.net/~shurailine/8139430/webrev.06/ >> >> > This looks okay to me. For completeness then I assume the > THreadMXBeanTool.waitUntilXXX methods should

Re: RFR: 8143126

2015-11-17 Thread Mandy Chung
> On Nov 17, 2015, at 4:39 AM, Jean-Francois Denise > wrote: > > Hi, > I removed a noisy call to System.out. > Webrev http://cr.openjdk.java.net/~jfdenise/8143126 +1 Mandy

hg: jigsaw/jake/jdk: 2 new changesets

2015-11-17 Thread mandy . chung
Changeset: e5fcea3aa679 Author:mchung Date: 2015-11-17 15:12 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e5fcea3aa679 Enable the test case to verify unnamed module fails to load properties bundle from named module ! test/java/util/logging/modules/pkgs/p3/test/Resourc

hg: jigsaw/jake/jdk: 2 new changesets

2015-11-19 Thread mandy . chung
Changeset: e6921b23f45b Author:mchung Date: 2015-11-19 14:03 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/e6921b23f45b ClassLoader::loadLocalClass should call findClass only if not loaded ! src/java.base/share/classes/java/lang/ClassLoader.java Changeset: f1fff0daf868

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

2015-11-19 Thread Mandy Chung
I reviewed the top repo change. modules.xml looks fine. jdk.dynalink should be in MAIN_MODULES since it has exported APIs. jdk.scripting.nashorn should be moved too. They are not sole service providers. Since you are on this file, can you move jdk.scripting.nashorn to MAIN_MODULES as well?

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

2015-11-19 Thread Mandy Chung
we will fix it when the changeset propagates to jake. Mandy > On Nov 19, 2015, at 7:00 PM, Mandy Chung wrote: > > I reviewed the top repo change. > > modules.xml looks fine. > > jdk.dynalink should be in MAIN_MODULES since it has exported APIs. > jdk.scripting.nas

Re: About 8056174: New APIs for jar signing

2015-11-19 Thread Mandy Chung
This looks okay. We will push this fix once we pull down your changeset to jake. One question: is “altsignerpath” and “altsigner” properties are only for the existing jarsigner -altsigner option to work? Is it the plan to deprecate this -altsigner option? Mandy > On Nov 19, 2015, at 4:40 PM

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

2015-11-23 Thread Mandy Chung
> On Nov 23, 2015, at 7:40 AM, Alan Bateman wrote: > > > > On 23/11/2015 15:27, Attila Szegedi wrote: >> Folks, >> >> I integrated the changes Mandy suggested; please review these (build >> related) changes: >> jdk9 top level: >>

Re: Review request for JDK-8141338: Move jdk.internal.dynalink package to jdk.dynalink

2015-11-23 Thread Mandy Chung
> On Nov 23, 2015, at 8:42 AM, Alan Bateman wrote: > > We need to do a bit of clean-up in Images.gmk to make things clearer as this > MAIN vs. PROVIDER topic has caused confusion on a few cases. If we can keep > the lists separate to the list of modules for the compact profile builds then > t

Re: RFR: 8139430

2015-11-23 Thread Mandy Chung
ssume re-throwing the > InterruptedException is a better choice. > > http://cr.openjdk.java.net/~shurailine/8139430/webrev.07/test/lib/testlibrary/jdk/testlibrary/management/ThreadMXBeanTool.java.html > > Shura > >> On Nov 16, 2015, at 8:33 PM, Mandy Chung wrote: >>

hg: jigsaw/jake/jdk: Throw IAE if the proxy module can't access interface

2015-11-23 Thread mandy . chung
Changeset: 89fb05b6e864 Author:mchung Date: 2015-11-23 19:22 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/89fb05b6e864 Throw IAE if the proxy module can't access interface ! src/java.base/share/classes/java/lang/reflect/Proxy.java ! test/jdk/jigsaw/reflect/Proxy/ProxyC

hg: jigsaw/jake/langtools: Fix langtools/tools/jdeps/APIDeps.java to reference internal type

2015-11-23 Thread mandy . chung
Changeset: f7876cd903aa Author:mchung Date: 2015-11-23 22:02 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/f7876cd903aa Fix langtools/tools/jdeps/APIDeps.java to reference internal type ! test/tools/jdeps/APIDeps.java ! test/tools/jdeps/VerboseFormat/JdepsDependen

hg: jigsaw/jake/jdk: 8139430: Refactor test library to decrease module dependencies of tests

2015-11-24 Thread mandy . chung
Changeset: 45cb94eef0ec Author:shurailine Date: 2015-11-23 11:49 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/45cb94eef0ec 8139430: Refactor test library to decrease module dependencies of tests Reviewed-by: mchung, alanb ! test/java/util/logging/TestLoggerWeakRefLeak.

Re: Apple internal api's

2015-11-24 Thread Mandy Chung
com.apple.eawt is in java.desktop module. Try this: java -XaddExports:java.desktop/com.apple.eawt=ALL-UNNAMED Mandy > On Nov 24, 2015, at 5:52 PM, Michael Hall wrote: > > I know these are being addressed as part of JEP 272 [1], but for now. > I have a shell script that will launch my OS X ap

hg: jigsaw/jake: 22 new changesets

2015-12-01 Thread mandy . chung
Changeset: 58e1d618b84c Author:bobv Date: 2015-10-19 13:21 -0400 URL: http://hg.openjdk.java.net/jigsaw/jake/rev/58e1d618b84c 8136556: Add the ability to perform static builds of MacOSX x64 binaries Reviewed-by: ihse, bdelsart, gadams, lfoltan, rriggs, hseigel, twisti ! common/auto

hg: jigsaw/jake/corba: 7 new changesets

2015-12-01 Thread mandy . chung
Changeset: e7ddf972e152 Author:chegar Date: 2015-11-11 11:31 + URL: http://hg.openjdk.java.net/jigsaw/jake/corba/rev/e7ddf972e152 8140606: Update library code to use internal Unsafe Reviewed-by: alanb, mchung, psandoz, weijun ! src/java.corba/share/classes/com/sun/corba/se/impl

hg: jigsaw/jake/hotspot: 157 new changesets

2015-12-01 Thread mandy . chung
Changeset: 029a2b20b570 Author:stefank Date: 2015-10-13 10:06 +0200 URL: http://hg.openjdk.java.net/jigsaw/jake/hotspot/rev/029a2b20b570 8058563: InstanceKlass::_dependencies list isn't cleared from empty nmethodBucket entries Reviewed-by: mgerdin, vlivanov ! src/share/vm/code/nme

hg: jigsaw/jake/jdk: 101 new changesets

2015-12-01 Thread mandy . chung
Changeset: 612588a68bd3 Author:psandoz Date: 2015-11-09 09:23 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/jdk/rev/612588a68bd3 8141630: Specification of Collections.synchronized* need to state traversal constraints Reviewed-by: psandoz Contributed-by: Tagir Valeev ! src/jav

hg: jigsaw/jake/langtools: 33 new changesets

2015-12-01 Thread mandy . chung
Changeset: 16d09290bb2a Author:sadayapalam Date: 2015-11-06 14:45 +0530 URL: http://hg.openjdk.java.net/jigsaw/jake/langtools/rev/16d09290bb2a 8138612: Do not retain declaration annotations on lambda formal parameters Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/to

hg: jigsaw/jake/jaxws: 3 new changesets

2015-12-01 Thread mandy . chung
Changeset: e8d15c61400c Author:lana Date: 2015-11-19 09:36 -0800 URL: http://hg.openjdk.java.net/jigsaw/jake/jaxws/rev/e8d15c61400c Added tag jdk9-b93 for changeset 5e94fbbb7032 ! .hgtags Changeset: 3e03ddaaac65 Author:lana Date: 2015-11-29 11:00 -0800 URL: http://h

hg: jigsaw/jake/jaxp: 12 new changesets

2015-12-01 Thread mandy . chung
Changeset: 1528075e9d88 Author:chegar Date: 2015-11-11 11:33 + URL: http://hg.openjdk.java.net/jigsaw/jake/jaxp/rev/1528075e9d88 8140606: Update library code to use internal Unsafe Reviewed-by: alanb, mchung, psandoz, weijun ! src/java.xml/share/classes/com/sun/org/apache/xml/

hg: jigsaw/jake/nashorn: 25 new changesets

2015-12-01 Thread mandy . chung
Changeset: 752ca580b176 Author:attila Date: 2015-11-09 14:03 +0100 URL: http://hg.openjdk.java.net/jigsaw/jake/nashorn/rev/752ca580b176 8141541: Simplify Nashorn's Context class loader handling Reviewed-by: hannesw, sundar ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/inte

Re: CFV: New Jigsaw Committer: Jan Lahoda

2015-12-02 Thread Mandy Chung
Vote: yes Mandy

Re: Is there really a jdk.proxy1 module?

2015-12-08 Thread Mandy Chung
> On Dec 8, 2015, at 7:10 AM, Stephane Epardaud wrote: > > On 08/12/15 16:07, Peter Levart wrote: >> >> >> Do you really have to addRead() ? Visibility of of classes >> (Class.forName()) should only depend on class loader delegation. >> Enumerating members, when you already have a java.lang.Cl

<    3   4   5   6   7   8   9   10   11   12   >