[
https://issues.apache.org/jira/browse/KAFKA-14934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726127#comment-17726127
]
Owen C.H. Leung edited comment on KAFKA-14934 at 5/27/23 2:49 AM:
--
Hi
vamossagar12 commented on code in PR #13504:
URL: https://github.com/apache/kafka/pull/13504#discussion_r1207577607
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java:
##
@@ -700,9 +714,28 @@ private class HandleRebalance implements
jolshan commented on PR #13768:
URL: https://github.com/apache/kafka/pull/13768#issuecomment-1565102014
Thanks for the PR! This looks promising. As Ismael said, let's share in
trunk first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
gharris1727 opened a new pull request, #13771:
URL: https://github.com/apache/kafka/pull/13771
The DelegatingClassLoader has a large number of fields and methods for
keeping track of known PluginDesc objects. It has this in common with the
PluginScanResult data object, which has a similar
Greg Harris created KAFKA-15031:
---
Summary: Add plugin.discovery worker configuration
Key: KAFKA-15031
URL: https://issues.apache.org/jira/browse/KAFKA-15031
Project: Kafka
Issue Type: New
Greg Harris created KAFKA-15030:
---
Summary: Add connect-plugin-path command line tool
Key: KAFKA-15030
URL: https://issues.apache.org/jira/browse/KAFKA-15030
Project: Kafka
Issue Type: New
jolshan commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1207484112
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -683,6 +702,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
validateAndAssignOffsets = false,
jolshan commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1207484112
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -683,6 +702,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
validateAndAssignOffsets = false,
[
https://issues.apache.org/jira/browse/KAFKA-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mehari Beyene reassigned KAFKA-14991:
-
Assignee: Mehari Beyene
> Improving Producer's record timestamp validation
>
jolshan commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1207324170
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -683,6 +702,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
validateAndAssignOffsets = false,
mumrah commented on code in PR #13767:
URL: https://github.com/apache/kafka/pull/13767#discussion_r1207482435
##
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##
@@ -145,44 +144,47 @@ class ZkMigrationClient(
topicClient.iterateTopics(
jolshan opened a new pull request, #13770:
URL: https://github.com/apache/kafka/pull/13770
Originally part of https://github.com/apache/kafka/pull/13608/files. Since
there are so many files changed, I decided to just pull this out into its own
PR.
I have moved this config into
jolshan opened a new pull request, #13769:
URL: https://github.com/apache/kafka/pull/13769
Originally part of https://github.com/apache/kafka/pull/13608, Artem made a
good point that this change was unrelated, so I'm making a minor PR to cover it.
Cleaning up the
cmccabe commented on code in PR #13759:
URL: https://github.com/apache/kafka/pull/13759#discussion_r1207395237
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -223,6 +283,21 @@ public BrokerHeartbeatState next() {
}
}
+
cmccabe commented on code in PR #13759:
URL: https://github.com/apache/kafka/pull/13759#discussion_r1207382044
##
server-common/src/main/java/org/apache/kafka/server/metrics/WindowedEventCounter.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jolshan commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1207368803
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -45,35 +45,48 @@ class AddPartitionsToTxnManager(config: KafkaConfig,
client:
jolshan commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1207333185
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -671,6 +671,7 @@ class ReplicaManager(val config: KafkaConfig,
val sTime = time.milliseconds
jolshan commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1207330097
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -45,35 +45,48 @@ class AddPartitionsToTxnManager(config: KafkaConfig,
client:
jolshan commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1207324170
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -683,6 +702,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
validateAndAssignOffsets = false,
cmccabe closed pull request #13766: KAFKA-14996: Limit partition count in
Create Topic and Create Partitions
URL: https://github.com/apache/kafka/pull/13766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cmccabe commented on PR #13766:
URL: https://github.com/apache/kafka/pull/13766#issuecomment-1564905334
Thanks @edoardocomar. Closing as duplicate of #13742 .
If you're interested in doing more here, check out the discussion on the
other PR about a possible KIP we could have (to add
artemlivshits commented on code in PR #13608:
URL: https://github.com/apache/kafka/pull/13608#discussion_r1206199912
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -579,10 +579,28 @@ class UnifiedLog(@volatile var logStartOffset: Long,
result
}
+ def
ijuma commented on PR #13768:
URL: https://github.com/apache/kafka/pull/13768#issuecomment-1564903842
We typically make changes to master first. Would you be willing to submit a
PR for that instead?
--
This is an automated message from the Apache Git Service.
To respond to the message,
cmccabe commented on PR #13742:
URL: https://github.com/apache/kafka/pull/13742#issuecomment-1564904075
Thanks for all the reviews, and thanks @mumrah for the LGTM. Since this is a
3.5 blocker I am getting it in today so that it will be in the next RC.
As I said before, this doesn't
cmccabe merged PR #13742:
URL: https://github.com/apache/kafka/pull/13742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726728#comment-17726728
]
Ruslan Scherbakov edited comment on KAFKA-9693 at 5/26/23 8:05 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726728#comment-17726728
]
Ruslan Scherbakov edited comment on KAFKA-9693 at 5/26/23 8:00 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726728#comment-17726728
]
Ruslan Scherbakov commented on KAFKA-9693:
--
Related pull request:
novosibman opened a new pull request, #13768:
URL: https://github.com/apache/kafka/pull/13768
Related issue https://issues.apache.org/jira/browse/KAFKA-9693
The issue with repeating latency spikes during Kafka log segments rolling
still reproduced on the latest versions including
cmccabe commented on code in PR #13767:
URL: https://github.com/apache/kafka/pull/13767#discussion_r1207234024
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java:
##
@@ -194,23 +195,44 @@ void handleTopicsDelta(Function
cmccabe commented on code in PR #13767:
URL: https://github.com/apache/kafka/pull/13767#discussion_r1207225622
##
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##
@@ -145,44 +144,47 @@ class ZkMigrationClient(
topicClient.iterateTopics(
mumrah commented on PR #13757:
URL: https://github.com/apache/kafka/pull/13757#issuecomment-1564750482
The jira for this is KAFKA-15017 btw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mumrah commented on PR #13766:
URL: https://github.com/apache/kafka/pull/13766#issuecomment-1564748396
@edoardocomar, thanks for taking a look at this. This issue is a little bit
tricky since PartitionRecords are not the only thing inside the topic creation
batch. There's also a
cmccabe commented on PR #13742:
URL: https://github.com/apache/kafka/pull/13742#issuecomment-1564712814
Hi all,
Thanks for the reviews and comments.
> @divijvaidya : But I was wondering if an additional guard could be to have
a default TopicCreationPolicy with a MaxValue of X
cmccabe commented on code in PR #13742:
URL: https://github.com/apache/kafka/pull/13742#discussion_r1207123242
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -457,9 +466,13 @@ private Throwable handleEventException(String name,
long
cmccabe commented on code in PR #13742:
URL: https://github.com/apache/kafka/pull/13742#discussion_r1207117766
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -160,6 +161,14 @@
* the controller can fully initialize.
*/
public final class
cmccabe commented on code in PR #13742:
URL: https://github.com/apache/kafka/pull/13742#discussion_r1207117766
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -160,6 +161,14 @@
* the controller can fully initialize.
*/
public final class
mumrah commented on code in PR #13767:
URL: https://github.com/apache/kafka/pull/13767#discussion_r1207096649
##
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##
@@ -145,44 +144,47 @@ class ZkMigrationClient(
topicClient.iterateTopics(
mumrah opened a new pull request, #13767:
URL: https://github.com/apache/kafka/pull/13767
This PR builds on top of #13736.
Fixes the following:
* Topic configs are not sycned while handling snapshot.
* New broker/topic configs in KRaft that did not exist in ZK will not be
[
https://issues.apache.org/jira/browse/KAFKA-14996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726688#comment-17726688
]
Edoardo Comar commented on KAFKA-14996:
---
Opened a PR to allow responding gracefully with
erikvanoosten commented on PR #13678:
URL: https://github.com/apache/kafka/pull/13678#issuecomment-1564684675
> @philipnee I will try to review it this week. Thanks!
Hi @dajac, did you already get the chance to look at this PR?
--
This is an automated message from the Apache Git
edoardocomar opened a new pull request, #13766:
URL: https://github.com/apache/kafka/pull/13766
Limit partition count in Create Topic and Create Partitions
to avoid exceeding the QuorumController's MAX_RECORDS_PER_BATCH,
and respond gracefully to the client.
--
This is an
yashmayya commented on PR #13465:
URL: https://github.com/apache/kafka/pull/13465#issuecomment-1564677170
Thanks Chris!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
splett2 commented on code in PR #13765:
URL: https://github.com/apache/kafka/pull/13765#discussion_r1207073563
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1087,12 +1087,14 @@ class Partition(val topicPartition: TopicPartition,
// avoid unnecessary
C0urante merged PR #13334:
URL: https://github.com/apache/kafka/pull/13334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hachikuji commented on code in PR #13267:
URL: https://github.com/apache/kafka/pull/13267#discussion_r1207028405
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -113,38 +142,113 @@ class ProducerIdManagerTest {
}
C0urante commented on code in PR #13334:
URL: https://github.com/apache/kafka/pull/13334#discussion_r1207028289
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java:
##
@@ -188,11 +191,34 @@ public static boolean isClassFile(Path path) {
C0urante merged PR #13356:
URL: https://github.com/apache/kafka/pull/13356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rondagostino commented on code in PR #13759:
URL: https://github.com/apache/kafka/pull/13759#discussion_r1207013139
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -223,6 +283,21 @@ public BrokerHeartbeatState next() {
}
}
rondagostino commented on code in PR #13759:
URL: https://github.com/apache/kafka/pull/13759#discussion_r1207013139
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -223,6 +283,21 @@ public BrokerHeartbeatState next() {
}
}
rondagostino commented on code in PR #13759:
URL: https://github.com/apache/kafka/pull/13759#discussion_r1207013139
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -223,6 +283,21 @@ public BrokerHeartbeatState next() {
}
}
C0urante merged PR #13465:
URL: https://github.com/apache/kafka/pull/13465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rondagostino commented on code in PR #13759:
URL: https://github.com/apache/kafka/pull/13759#discussion_r1207013139
##
metadata/src/main/java/org/apache/kafka/controller/BrokerHeartbeatManager.java:
##
@@ -223,6 +283,21 @@ public BrokerHeartbeatState next() {
}
}
jolshan commented on code in PR #13493:
URL: https://github.com/apache/kafka/pull/13493#discussion_r1206991344
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int,
* The most important
C0urante commented on code in PR #13504:
URL: https://github.com/apache/kafka/pull/13504#discussion_r1206885931
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java:
##
@@ -695,9 +705,28 @@ private class HandleRebalance implements
ijuma commented on code in PR #13742:
URL: https://github.com/apache/kafka/pull/13742#discussion_r1206985698
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -457,9 +466,13 @@ private Throwable handleEventException(String name,
long
ijuma commented on code in PR #13742:
URL: https://github.com/apache/kafka/pull/13742#discussion_r1206985698
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -457,9 +466,13 @@ private Throwable handleEventException(String name,
long
machi1990 commented on PR #13611:
URL: https://github.com/apache/kafka/pull/13611#issuecomment-1564562097
Thanks @jsancio for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jsancio merged PR #13611:
URL: https://github.com/apache/kafka/pull/13611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mumrah commented on PR #13742:
URL: https://github.com/apache/kafka/pull/13742#issuecomment-1564483362
@divijvaidya Colin can correct me if I'm mistaken, but I believe this patch
is mainly about closing an existing edge case until we implement KIP-868
(metadata transactions). Once we have
vvcephei merged PR #13455:
URL: https://github.com/apache/kafka/pull/13455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
machi1990 commented on PR #13664:
URL: https://github.com/apache/kafka/pull/13664#issuecomment-1564402596
Thanks @philipnee @vvcephei for the review and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vvcephei merged PR #13664:
URL: https://github.com/apache/kafka/pull/13664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Hangleton commented on code in PR #13493:
URL: https://github.com/apache/kafka/pull/13493#discussion_r1206778975
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int,
* The most
dajac commented on PR #13764:
URL: https://github.com/apache/kafka/pull/13764#issuecomment-1564350280
I have a few comments/questions:
* I am not really comfortable with merging this without the server side
implementation. @clolov Is there a strong reason to not do them together?
* I
dajac commented on code in PR #13493:
URL: https://github.com/apache/kafka/pull/13493#discussion_r1206732981
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int,
* The most important
Hangleton commented on code in PR #13493:
URL: https://github.com/apache/kafka/pull/13493#discussion_r1206702136
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int,
* The most
Hangleton commented on PR #13558:
URL: https://github.com/apache/kafka/pull/13558#issuecomment-1564157619
Hi, Igor, thanks for the review. I added the changes you reminded me about
above. I am going through an additional test runs for this integration test to
ensure there is no
mimaison commented on PR #13748:
URL: https://github.com/apache/kafka/pull/13748#issuecomment-1564113409
Good catch!
Yes it would be good to have this in 3.5. @krespo can you update your PR
with the suggestions from @gharris1727 ? Thanks
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726550#comment-17726550
]
Luke Chen commented on KAFKA-14953:
---
Sounds good! Thank you!
> Add metrics for tiered storage
>
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1206322259
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -0,0 +1,876 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on code in PR #13639:
URL: https://github.com/apache/kafka/pull/13639#discussion_r1206317753
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java:
##
@@ -0,0 +1,500 @@
+/*
+ * Licensed to the Apache Software
72 matches
Mail list logo