Re: [PATCH] mtd: atmel-quadspi: add suspend/resume hooks

2018-05-29 Thread Boris Brezillon
On Wed, 23 May 2018 19:08:48 +0300 Claudiu Beznea wrote: > Implement suspend/resume hooks. > > Signed-off-by: Claudiu Beznea > --- > drivers/mtd/spi-nor/atmel-quadspi.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/drivers/mtd/spi-nor/atmel-quadspi.c > b/d

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-05-29 Thread Boris Brezillon
On Tue, 29 May 2018 17:46:21 +0200 Boris Brezillon wrote: > On Tue, 29 May 2018 18:21:40 +0300 > Eugen Hristev wrote: > > > On 29.05.2018 18:15, Boris Brezillon wrote: > > > On Tue, 29 May 2018 18:01:40 +0300 &g

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-05-29 Thread Boris Brezillon
On Tue, 29 May 2018 18:21:40 +0300 Eugen Hristev wrote: > On 29.05.2018 18:15, Boris Brezillon wrote: > > On Tue, 29 May 2018 18:01:40 +0300 > > Eugen Hristev wrote: > > > >> [...] > >> > >> > >>> > >>> I think you

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-05-29 Thread Boris Brezillon
On Tue, 29 May 2018 18:01:40 +0300 Eugen Hristev wrote: > [...] > > > > > > I think you're missing something here. We use the DMA engine in memcpy > > mode (SRAM -> DRAM), not in device mode (dev -> DRAM or DRAM -> dev). > > So there's no dmas prop defined in the DT and there should not be. >

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-05-29 Thread Boris Brezillon
Hi Eugen, On Tue, 29 May 2018 09:30:54 +0300 Eugen Hristev wrote: > On 28.05.2018 13:10, Peter Rosin wrote: > > On 2018-05-28 00:11, Peter Rosin wrote: > >> On 2018-05-27 11:18, Peter Rosin wrote: > >>> On 2018-05-25 16:51, Tudor Ambarus wrote: > We think the best way is to keep LCD o

Re: [PATCH v2 3/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-28 Thread Boris Brezillon
On Mon, 28 May 2018 18:41:26 +0200 Benjamin Lindqvist wrote: > Note that it's certainly possible to encode U-Boot and kernel with > RS[4] and still use RS[8] for the rootfs even if the boot rom doesn't > support it. Not if you want to read/write from/to the uboot partition from Linux. Per-parti

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-05-28 Thread Boris Brezillon
On Mon, 28 May 2018 17:52:53 +0200 Peter Rosin wrote: > On 2018-05-28 16:27, Boris Brezillon wrote: > > Hi Peter, > > > > On Mon, 28 May 2018 12:10:02 +0200 > > Peter Rosin wrote: > > > >> On 2018-05-28 00:11, Peter Rosin wrote: > >>>

Re: [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused

2018-05-28 Thread Boris Brezillon
+Thierry Hi Arnd, On Fri, 25 May 2018 17:50:15 +0200 Arnd Bergmann wrote: > These two functions are unused in some configurations, and using > __maybe_unused > is the easiest way to shut up the harmless warnings: > > drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error: 'cdns_dsi_suspend' defined

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-05-28 Thread Boris Brezillon
Hi Peter, On Mon, 28 May 2018 12:10:02 +0200 Peter Rosin wrote: > On 2018-05-28 00:11, Peter Rosin wrote: > > On 2018-05-27 11:18, Peter Rosin wrote: > >> On 2018-05-25 16:51, Tudor Ambarus wrote: > >>> We think the best way is to keep LCD on DDR Ports 2 and 3 (8th and 9th > >>> slaves), to

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-27 Thread Boris Brezillon
On Sun, 27 May 2018 17:54:03 +0200 Miquel Raynal wrote: > Hi Boris, > > On Sun, 27 May 2018 17:13:37 +0200, Boris Brezillon > wrote: > > > On Sun, 27 May 2018 16:18:32 +0200 > > Miquel Raynal wrote: > > > > > Hi Stefan, > > > >

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-27 Thread Boris Brezillon
On Sun, 27 May 2018 16:18:32 +0200 Miquel Raynal wrote: > Hi Stefan, > > On Thu, 24 May 2018 14:19:18 +0200, Stefan Agner > wrote: > > > On 24.05.2018 13:53, Boris Brezillon wrote: > > > Hi Benjamin, > > > > > > On Thu, 24 May 201

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-24 Thread Boris Brezillon
On Thu, 24 May 2018 14:23:56 +0200 Boris Brezillon wrote: > On Thu, 24 May 2018 13:09:53 +0200 > Stefan Agner wrote: > > > On 24.05.2018 10:56, Boris Brezillon wrote: > > > On Thu, 24 May 2018 10:46:27 +0200 > > > Stefan Agner wrote: > > > >

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-24 Thread Boris Brezillon
On Thu, 24 May 2018 13:09:53 +0200 Stefan Agner wrote: > On 24.05.2018 10:56, Boris Brezillon wrote: > > On Thu, 24 May 2018 10:46:27 +0200 > > Stefan Agner wrote: > > > >> Hi Boris, > >> > >> Thanks for the initial review! One small ques

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-24 Thread Boris Brezillon
On Thu, 24 May 2018 13:09:53 +0200 Stefan Agner wrote: > On 24.05.2018 10:56, Boris Brezillon wrote: > > On Thu, 24 May 2018 10:46:27 +0200 > > Stefan Agner wrote: > > > >> Hi Boris, > >> > >> Thanks for the initial review! One small ques

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-24 Thread Boris Brezillon
Hi Benjamin, On Thu, 24 May 2018 13:30:14 +0200 Benjamin Lindqvist wrote: > Hi Stefan, > > It seems to me that a probe similar to what the BootROM does shouldn't > be awfully complicated to implement - just cycle through the switch > cases in case of an ECC error. But I guess that's more of an

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-24 Thread Boris Brezillon
On Thu, 24 May 2018 13:00:41 +0200 Stefan Agner wrote: > > > > > Note that we're in fact using this patch set in Linux today, but > > we had to remove the oobsize inference part. Currently we're > > simply hard coding it to CFG_TVAL_4, but maybe it would be > > cleaner to add ECC algo as a boar

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-24 Thread Boris Brezillon
On Thu, 24 May 2018 10:46:27 +0200 Stefan Agner wrote: > Hi Boris, > > Thanks for the initial review! One small question below: > > On 23.05.2018 16:18, Boris Brezillon wrote: > > Hi Stefan, > > > > On Tue, 22 May 2018 14:07:06 +0200 > > Stefan Agner

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-23 Thread Boris Brezillon
Hi Stefan, On Tue, 22 May 2018 14:07:06 +0200 Stefan Agner wrote: > + > +struct tegra_nand { > + void __iomem *regs; > + struct clk *clk; > + struct gpio_desc *wp_gpio; > + > + struct nand_chip chip; > + struct device *dev; > + > + struct completion command_complete; > +

Re: [PATCH] mtd: cmdlinepart: Update comment for introduction of OFFSET_CONTINUOUS

2018-05-23 Thread Boris Brezillon
On Tue, 22 May 2018 17:07:53 +0200 Geert Uytterhoeven wrote: > The comment about offset zero was not updated when changing behavior: > - Automatic offset calculation is indicated by OFFSET_CONTINUOUS, > - Zero really means offset zero. > > Fixes: b175d03dd2072836 ("[PATCH] mtd cmdlinepart: a

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-05-23 Thread Boris Brezillon
On Tue, 22 May 2018 20:03:41 +0200 Peter Rosin wrote: > On 2018-04-11 17:34, Nicolas Ferre wrote: > > On 11/04/2018 at 16:44, Peter Rosin wrote: > >> Hi Nicolas, > >> > >> Boris asked for your input on this (the datasheet difference appears to > >> have no bearing on the issue) elsewhere in the

Re: [PATCH] mtd: cmdlinepart: Update comment for introduction of OFFSET_CONTINUOUS

2018-05-22 Thread Boris Brezillon
On Tue, 22 May 2018 17:07:53 +0200 Geert Uytterhoeven wrote: > The comment about offset zero was not updated when changing behavior: > - Automatic offset calculation is indicated by OFFSET_CONTINUOUS, > - Zero really means offset zero. > > Fixes: b175d03dd2072836 ("[PATCH] mtd cmdlinepart: a

Re: [RESEND PATCH 2/5] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver

2018-05-22 Thread Boris Brezillon
Hi Stefan, On Tue, 22 May 2018 16:53:46 +0200 Stefan Agner wrote: > Hi, > > I do have some questions for some areas I wanted to improve in the next > revision. But I would like to make sure that the way I would like to > implement aligns with the MTD subsystem. I won't have time to review the

Re: [RESEND PATCH 1/5] mtd: rawnand: tegra: add devicetree binding

2018-05-22 Thread Boris Brezillon
Hello Stefan, On Tue, 22 May 2018 14:07:05 +0200 Stefan Agner wrote: > From: Lucas Stach > > This adds the devicetree binding for the Tegra 2 NAND flash > controller. > > Signed-off-by: Lucas Stach > Signed-off-by: Stefan Agner > --- > .../bindings/mtd/nvidia,tegra20-nand.txt | 29 +++

Re: [PATCH 043/102] mtd: spi-nor: stm32-quadspi: explicitly request exclusive reset control

2018-05-18 Thread Boris Brezillon
> control behavior. Convert all drivers requesting exclusive resets to the > explicit API call so the temporary transition helpers can be removed. > > No functional changes. > > Cc: Cyrille Pitchen > Cc: Marek Vasut > Cc: David Woodhouse > Cc: Brian Norris > Cc

Re: [PATCH V2 RFC] mtd: spi-nor: intel: provide a range for poll_timout

2018-05-18 Thread Boris Brezillon
esterberg Queued to spi-nor/next. Thanks, Boris > > __ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v8 2/3] mtd: spi-nor: add rockchip serial flash controller driver

2018-05-18 Thread Boris Brezillon
Hi Andy, Sorry for the late reply. On Thu, 8 Feb 2018 20:18:47 +0800 Andy Yan wrote: > From: Shawn Lin Commit message please. > > Add Rockchip SFC(serial flash controller) driver. > > Signed-off-by: Shawn Lin > Signed-off-by: Andy Yan > Acked-by: Marek Vasut > > --- > > Changes in v8

Re: Some questions about the spi mem framework

2018-05-17 Thread Boris Brezillon
On Fri, 18 May 2018 13:50:00 +0800 Xiangsheng Hou wrote: > Hi Boris, > > On Thu, 2018-05-17 at 09:42 +0200, Boris Brezillon wrote: > > On Thu, 17 May 2018 15:35:04 +0800 > > Xiangsheng Hou wrote: > > > > > On Thu, 2018-05-17 at 09:13 +0200, Boris Brezi

Re: Some questions about the spi mem framework

2018-05-17 Thread Boris Brezillon
On Thu, 17 May 2018 15:35:04 +0800 Xiangsheng Hou wrote: > On Thu, 2018-05-17 at 09:13 +0200, Boris Brezillon wrote: > > On Thu, 17 May 2018 14:58:24 +0800 > > Xiangsheng Hou wrote: > > > > > Hi Boris, > > > > > > On Wed, 2018-05-16 at 14:4

Re: [PATCH v7] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-16 Thread Boris Brezillon
On Wed, 16 May 2018 09:42:27 +0200 Miquel Raynal wrote: > Hi Chris, > > > >>> +static void nand_bit_wise_majority(const void **srcbufs, > > >>> + unsigned int nsrcbufs, > > >>> + void *dstbuf, > > >>> +

Re: [PATCH v7] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-16 Thread Boris Brezillon
On Wed, 16 May 2018 09:32:57 +0200 Chris Moore wrote: > Hi, > > Le 15/05/2018 à 09:34, Boris Brezillon a écrit : > > On Tue, 15 May 2018 06:45:51 +0200 > > Chris Moore wrote: > > > >> Hi, > >> > >> Le 13/05/2018 à 06:30, Wan,

Re: [PATCH v5 2/2] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-15 Thread Boris Brezillon
On Tue, 15 May 2018 23:23:02 +0300 Andy Shevchenko wrote: > On Tue, May 15, 2018 at 11:03 AM, Boris Brezillon > wrote: > > On Tue, 15 May 2018 10:46:00 +0300 > > Andy Shevchenko wrote: > > > >> On Tue, May 15, 2018 at 10:35 AM, Boris Brezillon > >>

Re: [PATCH] mtd: nand: Fix return type of __DIVIDE() when called with 32-bit

2018-05-15 Thread Boris Brezillon
On Mon, 14 May 2018 14:13:39 +0200 Boris Brezillon wrote: > On Mon, 14 May 2018 14:00:19 +0200 > Geert Uytterhoeven wrote: > > > Hi Boris, > > > > On Mon, May 14, 2018 at 1:46 PM, Boris Brezillon > > wrote: > > > On Mon, 14 May 2018 13:3

Re: [PATCH v5 2/2] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-15 Thread Boris Brezillon
On Tue, 15 May 2018 10:46:00 +0300 Andy Shevchenko wrote: > On Tue, May 15, 2018 at 10:35 AM, Boris Brezillon > wrote: > > On Mon, 14 May 2018 20:54:36 +0300 > > Andy Shevchenko wrote: > > > >> On Thu, May 10, 2018 at 3:03 PM, Boris Brezillon > >>

Re: [PATCH v5 2/2] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-15 Thread Boris Brezillon
On Mon, 14 May 2018 20:54:36 +0300 Andy Shevchenko wrote: > On Thu, May 10, 2018 at 3:03 PM, Boris Brezillon > wrote: > > >> +#define GET_BIT(bit, val) (((val) >> (bit)) & 0x01) > > > > Not sure we need that macro, see below. > > +1. We ha

Re: [PATCH v7] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-15 Thread Boris Brezillon
On Tue, 15 May 2018 06:45:51 +0200 Chris Moore wrote: > Hi, > > Le 13/05/2018 à 06:30, Wan, Jane (Nokia - US/Sunnyvale) a écrit : > > Per ONFI specification (Rev. 4.0), if all parameter pages have invalid CRC > > values, the bit-wise majority may be used to recover the contents of the > > para

Re: [PATCH] mtd: nand: Fix return type of __DIVIDE() when called with 32-bit

2018-05-14 Thread Boris Brezillon
On Mon, 14 May 2018 14:00:19 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Mon, May 14, 2018 at 1:46 PM, Boris Brezillon > wrote: > > On Mon, 14 May 2018 13:32:30 +0200 > > Geert Uytterhoeven wrote: > >> On Mon, May 14, 2018 at 1:23 PM, Boris Brezillon

Re: [PATCH] mtd: nand: Fix return type of __DIVIDE() when called with 32-bit

2018-05-14 Thread Boris Brezillon
On Mon, 14 May 2018 13:46:07 +0200 Boris Brezillon wrote: > On Mon, 14 May 2018 13:32:30 +0200 > Geert Uytterhoeven wrote: > > > Hi Boris, > > > > On Mon, May 14, 2018 at 1:23 PM, Boris Brezillon > > wrote: > > > On Mon, 14 May 2018 12:4

Re: [PATCH] mtd: nand: Fix return type of __DIVIDE() when called with 32-bit

2018-05-14 Thread Boris Brezillon
On Mon, 14 May 2018 13:32:30 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Mon, May 14, 2018 at 1:23 PM, Boris Brezillon > wrote: > > On Mon, 14 May 2018 12:49:37 +0200 > > Geert Uytterhoeven wrote: > >> The __DIVIDE() macro checks whether it

Re: [PATCH] mtd: nand: Fix return type of __DIVIDE() when called with 32-bit

2018-05-14 Thread Boris Brezillon
On Mon, 14 May 2018 12:49:37 +0200 Geert Uytterhoeven wrote: > The __DIVIDE() macro checks whether it is called with a 32-bit or 64-bit > dividend, to select the appropriate divide-and-round-up routine. > As the check uses the ternary operator, the result will always be > promoted to a type that

Re: [PATCH 4.16 41/72] mtd: rawnand: Make sure we wait tWB before polling the STATUS reg

2018-05-14 Thread Boris Brezillon
lease let me > > > know. > > > > > > -- > > > > > > From: Boris Brezillon > > > > > > commit 3057fcef385348fe85173f1b0c824d89f1176f72 upstream. > > > > > > NAND chips require a bit of time to take the NA

Re: [Ksummit-discuss] bug-introducing patches

2018-05-14 Thread Boris Brezillon
+Fengguang On Mon, 14 May 2018 10:40:10 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Mon, May 14, 2018 at 10:34 AM, Boris Brezillon > wrote: > > On Mon, 14 May 2018 10:29:04 +0200 > > Geert Uytterhoeven wrote: > >> On Mon, May 14, 2018 at 10:1

Re: [Ksummit-discuss] bug-introducing patches

2018-05-14 Thread Boris Brezillon
On Mon, 14 May 2018 10:29:04 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Mon, May 14, 2018 at 10:12 AM, Boris Brezillon > wrote: > > On Mon, 14 May 2018 10:00:30 +0200 > > Geert Uytterhoeven wrote: > >> On Tue, May 1, 2018 at 10:00 PM, Sasha Levin >

Re: [Ksummit-discuss] bug-introducing patches

2018-05-14 Thread Boris Brezillon
On Mon, 14 May 2018 10:00:30 +0200 Geert Uytterhoeven wrote: > On Tue, May 1, 2018 at 10:00 PM, Sasha Levin > wrote: > > On Tue, May 01, 2018 at 03:44:50PM -0400, Theodore Y. Ts'o wrote: > >>On Tue, May 01, 2018 at 04:38:21PM +, Sasha Levin wrote: > >>> - A merge window commit spent 50%

[PATCH] m68k: Implement ndelay() as an inline function to force type checking/casting

2018-05-13 Thread Boris Brezillon
link time. Fix that by making ndelay() an inline function and then defining dummy ndelay() macro that redirects to the ndelay() function (it's how most archs do to implement ndelay()). Fixes: c8ee038bd148 ("m68k: Implement ndelay() based on the existing udelay() logic") Signed-off-

Re: [PATCH v7] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-13 Thread Boris Brezillon
Applied after fixing a few things (see below). Changed the subject to "mtd: rawnand: use bit-wise majority to recover the ONFI param page" On Sun, 13 May 2018 04:30:02 + "Wan, Jane (Nokia - US/Sunnyvale)" wrote: > Per ONFI specification (Rev. 4.0), if all parameter pages have invalid CRC >

Re: [PATCH] mtd: nand: Add support for reading ooblayout from device tree

2018-05-12 Thread Boris Brezillon
On Sat, 12 May 2018 19:42:49 +0200 Paul Cercueil wrote: > >> >> My motivation is to get rid of this (move it to devicetree): > >> >> > >> >> > >> https://elixir.bootlin.com/linux/latest/source/arch/mips/jz4740/board-qi_lb60.c#L93 > >> > >> >> And enable the support of other boards wit

Re: [PATCH] mtd: nand: Add support for reading ooblayout from device tree

2018-05-12 Thread Boris Brezillon
On Sat, 12 May 2018 11:38:26 -0300 Paul Cercueil wrote: > Le sam. 12 mai 2018 à 10:42, Boris Brezillon > a écrit : > > On Sat, 12 May 2018 08:55:40 -0300 > > Paul Cercueil wrote: > > > >> Hi Boris, > >> > >> Le 12 mai 2018 02:55, Bo

Re: [PATCH] mtd: nand: Add support for reading ooblayout from device tree

2018-05-12 Thread Boris Brezillon
On Sat, 12 May 2018 08:55:40 -0300 Paul Cercueil wrote: > Hi Boris, > > Le 12 mai 2018 02:55, Boris Brezillon a écrit : > > > > Hi Paul, > > > > On Fri, 11 May 2018 23:29:12 +0200 > > Paul Cercueil wrote: > > > > > By specifying

Re: [PATCH v6] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-12 Thread Boris Brezillon
On Thu, 10 May 2018 14:28:37 -0700 Jane Wan wrote: > Per ONFI specification (Rev. 4.0), if all parameter pages have invalid > CRC values, the bit-wise majority may be used to recover the contents of > the parameter pages from the parameter page copies present. > > Signed-off-by: Jane Wan > ---

Re: [PATCH] mtd: nand: Add support for reading ooblayout from device tree

2018-05-11 Thread Boris Brezillon
Hi Paul, On Fri, 11 May 2018 23:29:12 +0200 Paul Cercueil wrote: > By specifying the properties "mtd-oob-ecc" and "mtd-oob-free", it is > now possible to specify from devicetree where the ECC data is located > inside the OOB region. Why would we want to do that? I mean, ECC/free regions are ECC

[GIT PULL] mtd: Fixes for 4.17-rc5

2018-05-11 Thread Boris Brezillon
polling the status REG - Fix BCH write in the the Marvell NAND controller driver - Fix wrong picosec to msec conversion in the Marvell NAND controller driver - Fix DMA handling in the TI OneNAND controllre driver Boris Brezillon (1

Re: [PATCH v5 2/2] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-10 Thread Boris Brezillon
Hi Jane, Subject prefix should be "[PATCH v5] ...", the 2/2 is no longer valid since you only have one patch here. On Wed, 9 May 2018 19:46:40 -0700 Jane Wan wrote: > Per ONFI specification (Rev. 4.0), if all parameter pages have invalid > CRC values, the bit-wise majority may be used to recov

Re: [Ksummit-discuss] bug-introducing patches

2018-05-09 Thread Boris Brezillon
Hi Stephen, On Wed, 9 May 2018 20:47:27 +1000 Stephen Rothwell wrote: > On Wed, 9 May 2018 18:03:46 +0900 Mark Brown wrote: > > > > On Wed, May 09, 2018 at 10:47:57AM +0200, Daniel Vetter wrote: > > > On Wed, May 9, 2018 at 10:44 AM, Mark Brown wrote: > > > > > > > > > I think this i

Re: [PATCH 16/18] mtd: rawnand.h: use nested union kernel-doc markups

2018-05-09 Thread Boris Brezillon
On Mon, 7 May 2018 06:35:52 -0300 Mauro Carvalho Chehab wrote: > Gets rid of those warnings and better document the parameters. > > ./include/linux/mtd/rawnand.h:752: warning: Function parameter or member > 'timings.sdr' not described in 'nand_data_interface' > ./include/linux/mtd/rawnand.

Re: [PATCH v4 1/2] mtd: rawnand: fsl_ifc: fix FSL NAND driver to read all ONFI parameter pages

2018-05-09 Thread Boris Brezillon
On Tue, 8 May 2018 14:19:53 -0700 Jane Wan wrote: > Per ONFI specification (Rev. 4.0), if the CRC of the first parameter page > read is not valid, the host should read redundant parameter page copies. > Fix FSL NAND driver to read the two redundant copies which are mandatory > in the specificati

Re: [PATCH v2] mtd: nxp-spifi: release flash_np in nxp_spifi_probe()

2018-05-09 Thread Boris Brezillon
On Wed, 9 May 2018 17:56:46 +0300 Alexey Khoroshilov wrote: > nxp_spifi_probe() increments refcnt of SPI flash device node by > of_get_next_available_child() and leaves it undecremented on both > successful and error paths. > > Found by Linux Driver Verification project (linuxtesting.org). > >

Re: [PATCH] mtd: nxp-spifi: decrement flash_np refcnt on error paths

2018-05-09 Thread Boris Brezillon
On Wed, 9 May 2018 17:35:41 +0300 Alexey Khoroshilov wrote: > On 09.05.2018 12:42, Boris Brezillon wrote: > > On Tue, 8 May 2018 23:47:36 +0300 > > Alexey Khoroshilov wrote: > > > >> nxp_spifi_probe() increments refcnt of SPI flash device node by > >>

Re: [PATCH v4 2/2] mtd: rawnand: use bit-wise majority to recover the contents of ONFI parameter

2018-05-09 Thread Boris Brezillon
On Tue, 8 May 2018 14:19:54 -0700 Jane Wan wrote: > Per ONFI specification (Rev. 4.0), if all parameter pages have invalid > CRC values, the bit-wise majority may be used to recover the contents of > the parameter pages from the parameter page copies present. > > Signed-off-by: Jane Wan > ---

Re: [PATCH v4 1/2] mtd: rawnand: fsl_ifc: fix FSL NAND driver to read all ONFI parameter pages

2018-05-09 Thread Boris Brezillon
On Tue, 8 May 2018 14:19:53 -0700 Jane Wan wrote: > Per ONFI specification (Rev. 4.0), if the CRC of the first parameter page > read is not valid, the host should read redundant parameter page copies. > Fix FSL NAND driver to read the two redundant copies which are mandatory > in the specificati

Re: [PATCH/RFC] mtd: spi-nor: honour max_message_size for spi-nor writes.

2018-05-09 Thread Boris Brezillon
On Fri, 27 Apr 2018 16:18:05 +1000 NeilBrown wrote: > Hi, > I've labeled this an RFC because I'm really not sure about removing the > error path from spi_nor_write() -- maybe that really matters. But on > my hardware, performing multiple small spi writes to the flash seems > to work. > > T

Re: [PATCH 16/18] mtd: rawnand.h: use nested union kernel-doc markups

2018-05-09 Thread Boris Brezillon
On Wed, 9 May 2018 09:10:34 -0300 Mauro Carvalho Chehab wrote: > Hi Boris, > > Em Mon, 7 May 2018 08:32:32 -0300 > Mauro Carvalho Chehab escreveu: > > > Hi Boris, > > > > Em Mon, 7 May 2018 11:46:50 +0200 > > Boris Brezillon escreveu: > > >

Re: [PATCH 16/18] mtd: rawnand.h: use nested union kernel-doc markups

2018-05-09 Thread Boris Brezillon
On Mon, 7 May 2018 08:32:32 -0300 Mauro Carvalho Chehab wrote: > Hi Boris, > > Em Mon, 7 May 2018 11:46:50 +0200 > Boris Brezillon escreveu: > > > Hi Mauro, > > > > diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h > > &g

Re: [PATCH] mtd: nxp-spifi: decrement flash_np refcnt on error paths

2018-05-09 Thread Boris Brezillon
On Tue, 8 May 2018 23:47:36 +0300 Alexey Khoroshilov wrote: > nxp_spifi_probe() increments refcnt of SPI flash device node by > of_get_next_available_child() and then it passes the node > to mtd device in nxp_spifi_setup_flash(). > But if a failure happens before mtd_device_register() succeed, >

Re: [PATCH v3 2/2] mtd: rawnand: fsl_ifc: use bit-wise majority to recover the contents of ONFI parameter

2018-05-08 Thread Boris Brezillon
On Mon, 7 May 2018 09:34:15 -0700 Jane Wan wrote: > Per ONFI specification (Rev. 4.0), if all parameter pages have invalid > CRC values, the bit-wise majority may be used to recover the contents of > the parameter pages from the parameter page copies present. > > Signed-off-by: Jane Wan I nev

Re: [PATCH 16/18] mtd: rawnand.h: use nested union kernel-doc markups

2018-05-07 Thread Boris Brezillon
Hi Mauro, On Mon, 7 May 2018 06:35:52 -0300 Mauro Carvalho Chehab wrote: > Gets rid of those warnings and better document the parameters. > > ./include/linux/mtd/rawnand.h:752: warning: Function parameter or member > 'timings.sdr' not described in 'nand_data_interface' > ./include/linux/m

Re: [PATCH v2 03/14] dt-bindings: qcom_nandc: make nand-ecc-strength optional

2018-05-07 Thread Boris Brezillon
On Thu, 3 May 2018 17:50:30 +0530 Abhishek Sahu wrote: > Now, nand-ecc-strength is optional. If specified in DT, then > controller will use this ECC strength otherwise ECC strength will > be calculated according to chip requirement and available OOB size. > > Signed-off-by: Abhishek Sahu > ---

Re: [PATCH] spi-nor: Add support for Atmel Dataflash memories

2018-05-07 Thread Boris Brezillon
Hi Nicolas, On Mon, 7 May 2018 10:23:56 +0200 Nicolas Ferre wrote: > On 04/05/2018 at 20:38, Boris Brezillon wrote: > > Hi Radu, > > > > Sorry for the late reply. > > > > On Wed, 28 Feb 2018 13:55:01 +0200 > > Radu Pirea wrote: > > > >

Re: [PATCH v2 04/14] mtd: rawnand: qcom: use the ecc strength from device parameter

2018-05-07 Thread Boris Brezillon
On Thu, 3 May 2018 17:50:31 +0530 Abhishek Sahu wrote: > Currently the driver uses the ECC strength specified in DT. > The QPIC/EBI2 NAND supports 4 or 8-bit ECC correction. The same > kind of board can have different NAND parts so use the ECC > strength from device parameters if it is not speci

Re: [PATCH v2 01/14] mtd: rawnand: helper function for setting up ECC parameters

2018-05-07 Thread Boris Brezillon
On Thu, 3 May 2018 17:50:28 +0530 Abhishek Sahu wrote: > commit 2c8f8afa7f92 ("mtd: nand: add generic helpers to check, > match, maximize ECC settings") provides generic helpers which > drivers can use for setting up ECC parameters. > > Since same board can have different ECC strength nand chip

Re: [PATCH] mtd: rawnand: marvell: pass ms delay to wait_op

2018-05-07 Thread Boris Brezillon
On Thu, 3 May 2018 14:21:28 +1200 Chris Packham wrote: > marvell_nfc_wait_op() expects the delay to be expressed in milliseconds > but nand_sdr_timings uses picoseconds. Use PSEC_TO_MSEC when passing > tPROG_max to marvell_nfc_wait_op(). > > Fixes: 02f26ecf8c772 ("mtd: nand: add reworked Marvel

Re: [PATCH v2 01/14] mtd: rawnand: helper function for setting up ECC parameters

2018-05-07 Thread Boris Brezillon
On Mon, 7 May 2018 12:40:39 +0900 Masahiro Yamada wrote: > 2018-05-03 21:20 GMT+09:00 Abhishek Sahu : > > commit 2c8f8afa7f92 ("mtd: nand: add generic helpers to check, > > match, maximize ECC settings") provides generic helpers which > > drivers can use for setting up ECC parameters. > > > > Sin

Re: [PATCH] mtd: spi-nor: add support for Microchip 25LC256

2018-05-04 Thread Boris Brezillon
On Fri, 4 May 2018 18:54:04 +0300 Radu Pirea wrote: > Added geometry description for Microchip 25LC256 memory. Same as for the dataflash stuff you posted a few weeks ago: I don't think this device belongs in the SPI NOR framework. > > Signed-off-by: Radu Pirea > --- > drivers/mtd/devices/m25

Re: [PATCH] spi-nor: Add support for Atmel Dataflash memories

2018-05-04 Thread Boris Brezillon
Hi Radu, Sorry for the late reply. On Wed, 28 Feb 2018 13:55:01 +0200 Radu Pirea wrote: > This patch add support in spi-nor for allmost all dataflash memories > supported by old mtd_dataflash driver. Those devices clearly use a different instruction set, so I don't think they fit in this frame

Re: [PATCH v2 1/2] mtd: rawnand: fsl_ifc: fix FSL NAND driver to read

2018-05-04 Thread Boris Brezillon
Hi Jane, On Fri, 4 May 2018 01:35:37 + "Wan, Jane (Nokia - US/Sunnyvale)" wrote: > Hi Miquel and Boris, > > Thank you for your response. The following is the reposting the v2 version > of the patch (also in the attachment). No need to attach the patch, and this message should not be plac

Re: [PATCH v2] mtd: chips: Replace printk() with pr_*()

2018-05-03 Thread Boris Brezillon
On Sat, 24 Mar 2018 22:01:45 +0530 Arushi Singhal wrote: > Using pr_() is more concise than printk(KERN_). > This patch: > * Replace printks having a log level with the appropriate > pr_*() macros. > * Indent the code where possible. > * Remove periods from messages. > > Signed-off-by: Arushi Si

Re: [PATCH] mtd: devices: check mtd_device_register() return code

2018-05-03 Thread Boris Brezillon
On Sat, 24 Mar 2018 16:48:20 +0530 Arushi Singhal wrote: Subject prefix should be "mtd: devices: st_spi_fsm: ", and it's really about checking return code which was already propagated to the lower layer (platform bus), but it's about making sure we disable the clk we have previously enabled in ca

Re: [PATCH] mtd: nand: do not initialise statics to 0 or NULL

2018-05-03 Thread Boris Brezillon
Hi Arushi, On Sat, 24 Mar 2018 15:47:27 +0530 Arushi Singhal wrote: > This patch fixes the checkpatch.pl error to ams-delta.c. > ERROR: do not initialise statics to 0 or NULL Can you rebase on top of nand/next [1] and use "mtd: rawnand: ams-delta: " for the subject prefix? Thanks, Boris [1]h

Re: [PATCH v3] mtd: onenand: omap2: Disable DMA for HIGHMEM buffers

2018-05-03 Thread Boris Brezillon
On Wed, 2 May 2018 12:41:32 +0200 Ladislav Michl wrote: > dma_map_single does not work for vmalloc-ed buffers, > so disable DMA in this case. > > Signed-off-by: Ladislav Michl > Reported-by: "H. Nikolaus Schaller" > Tested-by: "H. Nikolaus Schaller" Applied to mtd/master. Will be part of the

Re: [PATCH] mtd: rawnand: marvell: pass ms delay to wait_op

2018-05-03 Thread Boris Brezillon
Hi Chris, On Thu, 3 May 2018 05:28:32 + Chris Packham wrote: > On 03/05/18 14:21, Chris Packham wrote: > > marvell_nfc_wait_op() expects the delay to be expressed in milliseconds > > but nand_sdr_timings uses picoseconds. Use PSEC_TO_MSEC when passing > > tPROG_max to marvell_nfc_wait_op().

Re: [PATCH] drm/vc4: Fix oops dereferencing DPI's connector since panel_bridge.

2018-05-02 Thread Boris Brezillon
e want. Some day it would be good to have that > part of display_info attached to the bridge, instead. > > Signed-off-by: Eric Anholt > Fixes: 7b1298e05310 ("drm/vc4: Switch DPI to using the panel-bridge helper.") > Cc: Boris Brezillon Reviewed-by: Boris Brezillon &

Re: [PATCH 1/2] Fix FSL NAND driver to read all ONFI parameter pages

2018-05-02 Thread Boris Brezillon
On Tue, 1 May 2018 05:01:23 + "Wan, Jane (Nokia - US/Sunnyvale)" wrote: > Hi Miquèl and Boris, > > Thank you for your response and feedback. I've modified the fix based on > your comments. > Please see the updated patch file at the end of this message (also in > attachment). > My answer

Re: [PATCH 2/2] Use bit-wise majority to recover the contents of ONFI parameter

2018-05-02 Thread Boris Brezillon
On Wed, 2 May 2018 12:25:45 +0200 Boris Brezillon wrote: > Hi Jane, > > On Thu, 26 Apr 2018 17:19:56 -0700 > Jane Wan wrote: > > > Signed-off-by: Jane Wan > > --- > > drivers/mtd/nand/nand_base.c | 35 +++ > > 1 file

Re: [PATCH 2/2] Use bit-wise majority to recover the contents of ONFI parameter

2018-05-02 Thread Boris Brezillon
Hi Jane, On Thu, 26 Apr 2018 17:19:56 -0700 Jane Wan wrote: > Signed-off-by: Jane Wan > --- > drivers/mtd/nand/nand_base.c | 35 +++ > 1 file changed, 31 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.

Re: [PATCH v2] mtd: onenand: omap2: Disable DMA for HIGHMEM buffers

2018-05-02 Thread Boris Brezillon
On Wed, 2 May 2018 10:06:36 +0200 Ladislav Michl wrote: > Hi Boris, > > (and apologies for delay) > > On Fri, Apr 20, 2018 at 10:01:34PM +0200, Boris Brezillon wrote: > > Hi Ladislav, > > > > On Mon, 16 Apr 2018 08:52:59 +0200 > > Ladislav Michl wrote:

Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect

2018-05-01 Thread Boris Brezillon
On Tue, 1 May 2018 16:01:42 +0530 Sekhar Nori wrote: > On Monday 30 April 2018 03:39 PM, Boris Brezillon wrote: > > Hi Bartosz, > > > > On Mon, 30 Apr 2018 10:24:41 +0200 > > Bartosz Golaszewski wrote: > > > >> From: Bartosz Golaszewski &g

Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect

2018-04-30 Thread Boris Brezillon
On Mon, 30 Apr 2018 18:45:06 +0200 Bartosz Golaszewski wrote: > 2018-04-30 12:09 GMT+02:00 Boris Brezillon : > > Hi Bartosz, > > > > On Mon, 30 Apr 2018 10:24:41 +0200 > > Bartosz Golaszewski wrote: > > > >> From: Bartosz Golaszewski > >> &

Re: [PATCH v2] mtd: nftl: Remove VLA usage

2018-04-30 Thread Boris Brezillon
On Sun, 29 Apr 2018 08:00:53 -0700 Kees Cook wrote: > On the quest to remove all stack VLAs from the kernel[1] this changes > the check_free_sectors() routine to use a kmalloc()ed buffer instead > of a large VLA stack buffer. > > [1] > https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6

Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect

2018-04-30 Thread Boris Brezillon
Hi Bartosz, On Mon, 30 Apr 2018 10:24:41 +0200 Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We have the 'ti,davinci-chipselect' property in the device tree, but > when using platform data the driver silently uses the id field of > struct platform_device as the chipselect. This is

Re: [PATCH 1/2] Fix FSL NAND driver to read all ONFI parameter pages

2018-04-30 Thread Boris Brezillon
Hi Jane, On Thu, 26 Apr 2018 17:19:55 -0700 Jane Wan wrote: > Signed-off-by: Jane Wan > --- > drivers/mtd/nand/fsl_ifc_nand.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c > index ca36b35

Re: [PATCH v4 00/10] Add the I3C subsystem

2018-04-30 Thread Boris Brezillon
Hi Greg, On Sun, 29 Apr 2018 15:36:42 +0200 Greg Kroah-Hartman wrote: > On Mon, Apr 23, 2018 at 07:56:46PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Apr 23, 2018 at 07:38:14PM +0200, Boris Brezillon wrote: > > > Hi, > > > > > > On Fri, 30 Mar 2018

Re: [PATCH v4 03/10] i3c: Add sysfs ABI spec

2018-04-30 Thread Boris Brezillon
Hi Greg, On Sun, 29 Apr 2018 15:37:00 +0200 Greg Kroah-Hartman wrote: > On Fri, Mar 30, 2018 at 09:47:44AM +0200, Boris Brezillon wrote: > > Document sysfs files/directories/symlinks exposed by the I3C subsystem. > > > > Signed-off-by: Boris Brezillon > > --- &

Re: [PATCH 2/2] drm/panel: Enable DSI transactions on the RPi panel.

2018-04-30 Thread Boris Brezillon
to resolve the sparkling pixels problem I've had. > > Signed-off-by: Eric Anholt > Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" > Touchscreen.") Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panel/panel-raspberrypi-t

Re: [PATCH 1/2] drm/vc4: Skip ULPS latching when we're in that ULPS state already.

2018-04-30 Thread Boris Brezillon
On Tue, 31 Oct 2017 12:32:57 -0700 Eric Anholt wrote: > It seems that trying to go from unlatched to unlatched will time out > waiting for STOP, and we can just skip that. > > Signed-off-by: Eric Anholt Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_dsi.c |

Re: [PATCH V4] clk: at91: PLL recalc_rate() now using cached MUL and DIV values

2018-04-29 Thread Boris Brezillon
quot;clk: > at91: make use of syscon/regmap internally"). > > Fixes: 1bdf02326b71 ("clk: at91: make use of syscon/regmap internally) > Cc: > Signed-off-by: Marcin Ziemianowicz Acked-by: Boris Brezillon > --- > Thank you for bearing with me about this Boris. >

Re: [PATCH] mtd: nftl: Remove VLA usage

2018-04-29 Thread Boris Brezillon
On Sun, 29 Apr 2018 07:31:15 -0700 Kees Cook wrote: > On Sun, Apr 29, 2018 at 2:16 AM, Boris Brezillon > wrote: > > Hi Kees, > > > > On Mon, 23 Apr 2018 13:35:00 -0700 > > Kees Cook wrote: > > > >> On the quest to remove all VLAs from the kerne

Re: [PATCH v3] clk: at91: PLL recalc_rate() now using cached MUL+DIV values

2018-04-29 Thread Boris Brezillon
On Sun, 29 Apr 2018 15:17:10 +0200 Boris Brezillon wrote: > Hi Marcin, > > On Fri, 27 Apr 2018 13:56:09 -0400 > Marcin Ziemianowicz wrote: > > > Stephen Boyd , > > linux-...@vger.kernel.org, > > linux-arm-ker...@lists.infradead.org, > > linux-kerne

Re: [PATCH v3] clk: at91: PLL recalc_rate() now using cached MUL+DIV values

2018-04-29 Thread Boris Brezillon
ter the '---' line, so that it's not part of the commit message. > Thank you for bearing with me about this Boris. > > Changes since V2: > Removed all logging/debug messages I added > > Comment by Boris Brezillon about my fix being wrong addressed > Changes

Re: [PATCH] mtd: nftl: Remove VLA usage

2018-04-29 Thread Boris Brezillon
Hi Kees, On Mon, 23 Apr 2018 13:35:00 -0700 Kees Cook wrote: > On the quest to remove all VLAs from the kernel[1] this changes the > check_free_sectors() routine to use the same stack buffer for both > data byte checks (SECTORSIZE) and oob byte checks (oobsize). Since > these regions aren't need

[GIT PULL] mtd: Fixes for 4.17-rc3

2018-04-27 Thread Boris Brezillon
roller driver ---- Boris Brezillon (1): mtd: nand: Fix nanddev_mtd_erase() Joakim Tjernlund (3): mtd: cfi: cmdset_0001: Do not allow read/write to suspend erase block. mtd: cfi: cmdset_0001: Workaround Micron Erase suspend bug. mtd: cfi

Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-26 Thread Boris Brezillon
On Thu, 26 Apr 2018 19:56:58 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Thu, Apr 26, 2018 at 7:53 PM, Boris Brezillon > wrote: > > On Tue, 10 Apr 2018 15:26:20 +0200 > > Geert Uytterhoeven wrote: > >> On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut &

<    7   8   9   10   11   12   13   14   15   16   >