[PATCHv2] mn88472: move out of staging to media

2016-06-07 Thread Antti Palosaari
Move mn88472 DVB-T/T2/C demod driver out of staging to media. v2: Fix build error reported by kbuild test robot: drivers/staging/media/mn88472/Makefile: No such file or directory Reported-by: kbuild test robot Signed-off-by: Antti Palosaari --- MAINTAINERS

[PATCHv2] rtl28xxu: increase failed I2C msg repeat count to 3

2016-06-07 Thread Antti Palosaari
1 and 2 wasn't enough for mn88472 chip on Astrometa device, so increase it to 3. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-u

Re: [PATCH v2] [media] rtl2832: add support for slave ts pid filter

2016-06-07 Thread Antti Palosaari
Hello That patch does not apply anymore as new register access functions are now regmap ones. Also I don't see reason you set slave_ts value to false on rtl2832_init(). It just be just enough setting its value on rtl2832_slave_ts_ctrl(). regards Antti On 05/22/2016 07:03 PM, Martin Blumenst

[GIT PULL 4.8] mn88473 fixes

2016-06-06 Thread Antti Palosaari
nges up to e8af1316e5b16fb39b8b41274e66f474cc6144fd: mn88473: fix typo (2016-06-07 09:08:21 +0300) -------- Antti Palosaari (1): mn88473: fix error path on probe() Julia Lawall (1): mn88473: fix typo drivers/media/dvb-frontends/mn88473.c | 7 --- 1 fi

[PATCH] af9035: fix logging

2016-06-06 Thread Antti Palosaari
Remove __func__ and KBUILD_MODNAME from logging formatters and pass USB interface device instead, so logging can be done correctly. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9035.c | 193 +- 1 file changed, 97 insertions(+), 96 deletions

Re: [PATCH] media: af9035 I2C combined write + read transaction fix

2016-06-01 Thread Antti Palosaari
Applied for 4.8, thanks! Antti On 04/06/2016 01:23 AM, Alessandro Radicati wrote: This patch will modify the af9035 driver to use the register address fields of the I2C read command for the combined write/read transaction case. Without this change, the firmware issues just a I2C read transacti

Re: [PATCH v2] [media] af9035: fix for MXL5007T devices with I2C read issues

2016-06-01 Thread Antti Palosaari
Applied for 4.8, thanks! Antti On 05/12/2016 01:47 PM, Alessandro Radicati wrote: The MXL5007T tuner will lock-up on some devices after an I2C read transaction. This patch works around this issue by inhibiting such operations and emulating a 0x00 response. The workaround is only applied to US

Re: ascot2e.c off by one bug

2016-05-28 Thread Antti Palosaari
Convert it to regmap at the same (just a hint...) On 05/28/2016 12:28 PM, Saso Slavicic wrote: Hi, Tuning a card with Sony ASCOT2E produces the following error: kernel: i2c i2c-9: wr reg=0006: len=11 is too big! MAX_WRITE_REGSIZE is defined as 10, buf[MAX_WRITE_REGSIZE + 1] buffer is

Re: How should I use kernel-defined i2c structs in this driver

2016-05-26 Thread Antti Palosaari
On 05/26/2016 04:59 PM, Andrey Utkin wrote: Could anybody please give a hint - which kernel-defined i2c objects, and how many of them, I need to define and use to substitute these driver-defined functions i2c_read(), i2c_write() ? https://github.com/bluecherrydvr/linux/blob/release/tw5864/1.16/dr

[PATCHv2 4/6] MAINTAINERS: add zd1301_demod driver

2016-05-21 Thread Antti Palosaari
DVB-T demodulator driver for ZyDAS ZD1301 chip. Signed-off-by: Antti Palosaari --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 090bec2..a4ae460 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12391,6 +12391,15 @@ L: zd1211-d

[PATCHv2 6/6] MAINTAINERS: add zd1301 DVB USB interface driver

2016-05-21 Thread Antti Palosaari
DVB USB interface driver for ZyDAS ZD1301 chip. Signed-off-by: Antti Palosaari --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a4ae460..d2559e1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12400,6 +12400,15 @@ Q: https

[PATCHv2 2/6] mt2060: add param to split long i2c writes

2016-05-21 Thread Antti Palosaari
Add configuration parameter to split long i2c writes as some I2C adapters cannot write 10 bytes used as a one go. Signed-off-by: Antti Palosaari --- drivers/media/tuners/mt2060.c | 21 + drivers/media/tuners/mt2060.h | 3 +++ drivers/media/tuners/mt2060_priv.h

[PATCHv2 5/6] zd1301: ZyDAS ZD1301 DVB USB interface driver

2016-05-21 Thread Antti Palosaari
ZyDAS ZD1301 is chip having USB interface and DVB-T demodulator integrated. This driver is for USB interface part. Device has USB ID 0ace:13a1. Used tuner is MT2060. Signed-off-by: Antti Palosaari --- drivers/media/dvb-core/dvb-usb-ids.h | 1 + drivers/media/usb/dvb-usb-v2/Kconfig | 8

[PATCHv2 3/6] zd1301_demod: ZyDAS ZD1301 DVB-T demodulator driver

2016-05-21 Thread Antti Palosaari
ZyDAS ZD1301 is chip having USB interface and DVB-T demodulator integrated. This driver is for demodulator part. Driver is very reduced, just basic demodulator functionality, no statistics at all. It registers as a platform driver to driver core. Signed-off-by: Antti Palosaari --- drivers/media

[PATCHv2 1/6] mt2060: add i2c bindings

2016-05-21 Thread Antti Palosaari
Add proper i2c driver model bindings. Signed-off-by: Antti Palosaari --- drivers/media/tuners/mt2060.c | 83 ++ drivers/media/tuners/mt2060.h | 20 + drivers/media/tuners/mt2060_priv.h | 2 + 3 files changed, 105 insertions(+) diff --git a

Re: DVBSky T330 DVB-C regression Linux 4.1.12 to 4.3

2016-05-20 Thread Antti Palosaari
On 05/21/2016 01:47 AM, Rolf Evers-Fischer wrote: Dear Antti, I apologize for tackling this old problem, but I just ran into the same situation with my "DVBSky T330 DVB-C" and found that I'm not the only one. . Also, you used 4.0.19 firmware. Could you test that old one: http://palosaari.fi

[PATCH] mn88473: fix error path on probe()

2016-05-13 Thread Antti Palosaari
Latest, 3rd, regmap instance should be freed on error case. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/mn88473.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/mn88473.c b/drivers/media/dvb-frontends/mn88473.c index

[PATCH 2/3] mn88472: finalize driver

2016-05-13 Thread Antti Palosaari
Finalize driver in order to move out of staging. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/mn88472.h| 45 +-- drivers/staging/media/mn88472/mn88472.c | 513 ++- drivers/staging/media/mn88472/mn88472_priv.h | 11 +- 3 files changed, 301

[PATCH 3/3] mn88472: move out of staging to media

2016-05-13 Thread Antti Palosaari
Move mn88472 DVB-T/T2/C demod driver out of staging to media. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/Kconfig | 8 + drivers/media/dvb-frontends/Makefile | 1 + drivers/media/dvb-frontends/mn88472.c| 607 +++ drivers

[PATCH 1/3] rtl28xxu: increase failed I2C msg repeat count to 2

2016-05-13 Thread Antti Palosaari
1 wasn't enough for mn88472 chip on Astrometa device, so increase it by one. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-u

[GIT PULL 4.7] af9035

2016-05-06 Thread Antti Palosaari
9c3cda3783707e8028ec1335e9ec0a63edb4712b: af9035: correct eeprom offsets (2016-04-27 23:08:50 +0300) Antti Palosaari (1): af9035: correct eeprom offsets drivers/media/usb/dvb-usb-v2/af9035.h | 24 1 file changed, 12

Re: [PATCH v7 16/24] i2c: allow adapter drivers to override the adapter locking

2016-05-02 Thread Antti Palosaari
On 04/29/2016 12:16 PM, Peter Rosin wrote: On 2016-04-29 09:16, Wolfram Sang wrote: Yes, obviously... I'll make that change locally and wait for the rest. Another nit: You could use '--strict' with checkpatch and see if you want to fix the issues reported. I am not keen on those (except for 'sp

[PATCH] af9035: correct eeprom offsets

2016-04-27 Thread Antti Palosaari
Used memory mapped eeprom offsets were off-by 8 bytes. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/af9035.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9035.h b/drivers/media/usb/dvb-usb-v2

Re: [PATCH v7 00/24] i2c mux cleanup and locking update

2016-04-20 Thread Antti Palosaari
On 04/20/2016 06:17 PM, Peter Rosin wrote: Retested all the previously tested + now I tested also cx231xx with Hauppauge 930C HD device having eeprom other mux port and demod on the other port. [media] si2168: change the i2c gate to be mux-locked [media] m88ds3103: convert to use an ex

Re: [PATCH] [media] af9035: fix for MXL5007T devices with I2C read issues

2016-04-20 Thread Antti Palosaari
On 04/20/2016 12:13 PM, Alex Rad wrote: On Wed, Apr 20, 2016 at 1:02 AM, Antti Palosaari wrote: Hello I am not happy with that new module parameter as I cannot see real need for it. So get rid of it. My reasoning for this is: 1) We know of just two devices which may have the issue, but there

Re: [PATCH] [media] af9035: fix for MXL5007T devices with I2C read issues

2016-04-19 Thread Antti Palosaari
Hello I am not happy with that new module parameter as I cannot see real need for it. So get rid of it. Better to compare both VID and PID when enabling that work-around. Driver supports currently quite many different USB IDs and there is still small risk duplicate PID will exists at some poi

Fwd: [Bug 116551] media_gobj_create NULL pointer dereference

2016-04-17 Thread Antti Palosaari
Can you look that bug as I think it is media controller related. regards Antti Forwarded Message Subject: [Bug 116551] media_gobj_create NULL pointer dereference Date: Sat, 16 Apr 2016 20:40:18 + From: bugzilla-dae...@bugzilla.kernel.org To: cr...@iki.fi https://bugzilla.

[GIT PULL 4.6] m88ds3103 fix

2016-04-10 Thread Antti Palosaari
That is actually bug fix for 3.19+, but according to my tests its effect is very minor, so no need for stable. It fixes demod carrier offset calculation. The following changes since commit da470473c9cf9c4ebb40d046b306c76427b6df94: [media] media: au0828 fix to clear enable/disable/change sou

Re: AVerMedia HD Volar (A867) AF9035 + MXL5007T driver issues

2016-04-09 Thread Antti Palosaari
On 04/09/2016 07:11 PM, Alessandro Radicati wrote: On Sat, Apr 9, 2016 at 4:25 PM, Antti Palosaari wrote: On 04/09/2016 11:13 AM, Alessandro Radicati wrote: On Sat, Apr 9, 2016 at 4:17 AM, Antti Palosaari wrote: On 04/09/2016 04:52 AM, Alessandro Radicati wrote: On Sat, Apr 9, 2016

Re: AVerMedia HD Volar (A867) AF9035 + MXL5007T driver issues

2016-04-09 Thread Antti Palosaari
On 04/09/2016 11:13 AM, Alessandro Radicati wrote: On Sat, Apr 9, 2016 at 4:17 AM, Antti Palosaari wrote: On 04/09/2016 04:52 AM, Alessandro Radicati wrote: On Sat, Apr 9, 2016 at 3:22 AM, Antti Palosaari wrote: Here is patches to test: http://git.linuxtv.org/anttip/media_tree.git/log/?h

Re: AVerMedia HD Volar (A867) AF9035 + MXL5007T driver issues

2016-04-08 Thread Antti Palosaari
On 04/09/2016 04:52 AM, Alessandro Radicati wrote: On Sat, Apr 9, 2016 at 3:22 AM, Antti Palosaari wrote: Here is patches to test: http://git.linuxtv.org/anttip/media_tree.git/log/?h=af9035 I've done this already in my testing, and it works for getting a correct chip_id response, but

Re: AVerMedia HD Volar (A867) AF9035 + MXL5007T driver issues

2016-04-08 Thread Antti Palosaari
on I2C bus? If it starts working then have to find out way to fix it properly so that any earlier device didn't broke. regards Antti On 04/09/2016 03:50 AM, Antti Palosaari wrote: uh, how it could be so hard? I just made few tests and found 3 ways to read it. OK, one is that Aless

Re: AVerMedia HD Volar (A867) AF9035 + MXL5007T driver issues

2016-04-08 Thread Antti Palosaari
I'll try to push through a patch for just "no_probe". Thanks, Alessandro On Sat, Apr 9, 2016 at 1:13 AM, Jose Alberto Reguero wrote: I made a patch long time ago, but it was not accepted. https://patchwork.linuxtv.org/patch/16242/ Jose Alberto El 06/04/2016 01:00, Alessandro Radi

Re: AVerMedia HD Volar (A867) AF9035 + MXL5007T driver issues

2016-04-05 Thread Antti Palosaari
I found one stick having AF9035 + MXL5007T. It is HP branded A867, so it should be similar. It seems to work all three 12.13.15.0 6.20.15.0 firmwares: http://palosaari.fi/linux/v4l-dvb/firmware/af9035/ mxl5007t 5-0060: creating new instance mxl5007t_get_chip_id: unknown rev (3f) mxl5007t_get_ch

Re: AVerMedia HD Volar (A867) AF9035 + MXL5007T driver issues

2016-04-05 Thread Antti Palosaari
On 04/02/2016 01:44 PM, Alessandro Radicati wrote: Hi, In trying to understand why my DVB USB tuner doesn't work with stock kernel drivers (4.2.0), I decided to pull out my logic analyser and sniff the I2C bus between the AF9035 and MXL5007T. I seem to have uncovered a couple of issues: 1) Atta

Re: [PATCH] si2168: use i2c controlled mux interface

2016-04-05 Thread Antti Palosaari
On 03/23/2016 06:58 PM, Peter Rosin wrote: On 2016-01-06 06:42, Antti Palosaari wrote: Recent i2c mux locking update offers support for i2c controlled i2c muxes. Use it and get the rid of homemade hackish i2c adapter locking code. [actual patch elided] I had a 2nd look and it seems that the

Re: [PATCH v4 00/18] i2c mux cleanup and locking update

2016-03-15 Thread Antti Palosaari
lare that the i2c gate is self-locked b52f766 [media] si2168: convert to use an explicit i2c mux core 4ba9115 [media] rtl2832: convert to use an explicit i2c mux core 3f1778b [media] rtl2830: convert to use an explicit i2c mux core 5c8bfc8 [media] m88ds3103: convert to use an explicit i2c mux core

[PATCH] si2168: add lock to cmd execute

2016-03-15 Thread Antti Palosaari
which did the same job. Cc: Peter Rosin Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/si2168.c | 21 ++--- drivers/media/dvb-frontends/si2168_priv.h | 1 + 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/media/dvb-frontends/si2168.c b

[GIT PULL] mn88473: move out of staging

2016-03-03 Thread Antti Palosaari
/media_tree.git mn88473_pull for you to fetch changes up to 05886118dd140b4d96cf4de5c76b4fb6155316f5: rtl2832: move stats polling to read status (2016-02-14 04:29:33 +0200) Antti Palosaari (4): mn88473: move out of staging

[PATCH] rtl28xxu: retry failed i2c messages

2016-01-07 Thread Antti Palosaari
issue by repeating failed message. Another solution which also works is to add ~100us delay between i2c messages - but repeating sounds more elegant and does not cause any extra delay for success cases. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 8 1

Re: [PATCH v2 0/8] i2c mux cleanup and locking update

2016-01-06 Thread Antti Palosaari
On 01/05/2016 05:57 PM, Peter Rosin wrote: From: Peter Rosin Hi! I have a pair of boards with this i2c topology: GPIO ---| -- BAT1 | v / I2C -+--B---+ MUX | \ EEPROM

Re: [PATCH] si2168: use i2c controlled mux interface

2016-01-06 Thread Antti Palosaari
Moikka! On 01/06/2016 09:14 AM, Peter Rosin wrote: Hi Antti, On 2016-01-06 06:42, Antti Palosaari wrote: Recent i2c mux locking update offers support for i2c controlled i2c muxes. Use it and get the rid of homemade hackish i2c adapter locking code. That looks good on a first glance, and I&#

[PATCH] si2168: use i2c controlled mux interface

2016-01-05 Thread Antti Palosaari
Recent i2c mux locking update offers support for i2c controlled i2c muxes. Use it and get the rid of homemade hackish i2c adapter locking code. Cc: Peter Rosin Cc: Peter Rosin Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/si2168.c | 61 1

[GIT PULL 4.5] rtl2832u changes

2015-12-20 Thread Antti Palosaari
to bbed859d68218c043fa88ccdd9785d9567d8fb5d: rtl2832: do not filter out slave TS null packets (2015-12-20 04:57:20 +0200) Antti Palosaari (3): rtl28xxu: return demod reg page from driver cache rtl2832: print reg

Re: [PATCH 2/3] mn88472: add work around for failing firmware loading

2015-12-20 Thread Antti Palosaari
Hello I am not sure if problem is I2C adapter/bus or that demodulator I2C slave. If it is demod, then that workaround is correct place, but if it is not, then that is wrong and I2C adapter repeating logic should be used. I did some testing again... Loading mn88472 firmware 1000 times, it faile

Re: [PATCH 1/3] rtl2832: add support for slave ts pid filter

2015-12-20 Thread Antti Palosaari
Patch looks acceptable, but it is broken in a mean it does not apply :( $ wget -O - https://patchwork.linuxtv.org/patch/32030/mbox/ | git am -3 -s --2015-12-21 04:40:46-- https://patchwork.linuxtv.org/patch/32030/mbox/ Resolving patchwork.linuxtv.org (patchwork.linuxtv.org)... 130.149.80.248 Con

Re: [PATCH 3/3] rtl28xxu: change Astrometa DVB-T2 to always use hardware pid filters

2015-12-19 Thread Antti Palosaari
Moikka! I did some testing and I cannot see reason to force hw pid filter for that device. I assume you somehow think it does not work without filtering, but I think it does. I tested streaming with mn88472 demod DVB-C and DVB-T2 modes without stream errors. DVB-T2 (live) datarate 45Mbps and

[PATCH] rtl2832: do not filter out slave TS null packets

2015-12-19 Thread Antti Palosaari
Do not remove slave TS NULL padding PID (0x1fff) by default as there is no real need. After that whole TS is passed to kernel sw PID filter. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/rtl2832.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/media

[PATCH 1/2] rtl28xxu: return demod reg page from driver cache

2015-12-19 Thread Antti Palosaari
Return current active rtl2830/rtl2832 register page from the driver cache in order to reduce I2C I/O. Register page is already cached due to I2C write needs. Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 16 +++- 1 file changed, 11 insertions(+), 5

[PATCH 2/2] rtl2832: print reg number on error case

2015-12-19 Thread Antti Palosaari
It is hard to debug possible I2C failures without knowing the possible register itself. Add register number to error printing. Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/rtl2832.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb

Re: [DVBT USB dongle] problem with Zolid Mini DVB-T Stick on linux mint 17.2

2015-11-25 Thread Antti Palosaari
On 11/26/2015 12:57 AM, Antti Palosaari wrote: On 11/26/2015 12:53 AM, Mark Croft wrote: hi hope this is the correct list about trying to get linux to talk to dvb-t usb stick? check out all the logs etc here http://pastebin.com/V3RQ17hz and antenna is plugged and it is good antenna with

Re: [DVBT USB dongle] problem with Zolid Mini DVB-T Stick on linux mint 17.2

2015-11-25 Thread Antti Palosaari
On 11/26/2015 12:53 AM, Mark Croft wrote: hi hope this is the correct list about trying to get linux to talk to dvb-t usb stick? check out all the logs etc here http://pastebin.com/V3RQ17hz and antenna is plugged and it is good antenna with strong signal? Test it first using windows. Logs sa

Re: [PATCH] tda10071: Fix dependency to REGMAP_I2C

2015-11-23 Thread Antti Palosaari
) cx23885_dvb_register() dvb_register failed err = -22 cx23885_dev_setup() Failed to register dvb adapters on VID_B Signed-off-by: Matthias Schwarzott Reviewed-by: Antti Palosaari --- drivers/media/dvb-frontends/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: DVBSky T330 DVB-C regression Linux 4.1.12 to 4.3

2015-11-23 Thread Antti Palosaari
Moikka! On 11/19/2015 01:36 AM, Stephan Eisvogel wrote: Hey Olli, Antti, culprit is: http://git.linuxtv.org/cgit.cgi/linux.git/commit/drivers/media/dvb-frontends/si2168.c?id=7adf99d20ce0e96a70755f452e3a63824b14060f I removed it like this: /* error bit set? */ /* if ((cmd->

Re: [PATCH] [media] tda10023: fix wrong register assignment

2015-11-20 Thread Antti Palosaari
On 09/08/2015 10:43 AM, Manuel Kampert wrote: Register INTP1 (0x12) Bit POCLKP (bit 0) sets the output clock polarity of tda10023 . However, the driver tries to set the parallel output mode in this register which is not correct. Parallel output mode is set on register INTP2 (0x20) INTPSEL (bit 1

Re: PID filter testing

2015-11-20 Thread Antti Palosaari
On 11/20/2015 04:25 PM, Benjamin Larsson wrote: On 11/20/2015 02:27 PM, Honza Petrouš wrote: 2015-11-20 12:00 GMT+01:00 Benjamin Larsson : Hi, what tools can I use to test pid filter support in the drivers ? Zap utility from dvbapps seems to be some simpler way - you can pass them the fixed p

Re: PID filter testing

2015-11-20 Thread Antti Palosaari
On 11/20/2015 01:00 PM, Benjamin Larsson wrote: Hi, what tools can I use to test pid filter support in the drivers ? dvbtraffic shows all the pids from tuned stream, but IIRC it does not work with dvbv5-zap as it opens device blocked mode. dvbv5-zap has itself quite similar mode than dvbtraff

Re: [PATCH 1/6] mt2060: add i2c bindings

2015-11-18 Thread Antti Palosaari
On 11/18/2015 05:01 PM, Mauro Carvalho Chehab wrote: Em Mon, 27 Jul 2015 14:22:05 +0300 Antti Palosaari escreveu: Add proper i2c driver model bindings. Hi Antti, What's the status of this patch series? You submitted them on July, but never sent me a pull request... I noticed I2C ad

Re: [PATCH] [media] hackrf: don't emit dev debug on a kfree'd or null dev

2015-11-11 Thread Antti Palosaari
On 11/11/2015 05:05 PM, Colin King wrote: From: Colin Ian King Static analysis with smatch detected a couple of issues: drivers/media/usb/hackrf/hackrf.c:1533 hackrf_probe() error: we previously assumed 'dev' could be null (see line 1366) drivers/media/usb/hackrf/hackrf.c:1533 hackrf_probe(

[GIT PULL STABLE] airspy: increase USB control message buffer size

2015-11-07 Thread Antti Palosaari
changes up to 79d7c879f3a994da146d7c19feb71cd2ab6b2215: airspy: increase USB control message buffer size (2015-11-05 05:01:30 +0200) Antti Palosaari (1): airspy: increase USB control message buffer size drivers/media/usb

[PATCH] airspy: increase USB control message buffer size

2015-11-07 Thread Antti Palosaari
current and future version strings. Cc: # 3.17+ Link: https://github.com/airspy/host/issues/27 Reported-by: Benjamin Vernoux Signed-off-by: Antti Palosaari --- drivers/media/usb/airspy/airspy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/airspy/airspy.c b

[GIT PULL 4.4] 2 small hackrf changes

2015-11-04 Thread Antti Palosaari
changes up to 15b651b5e0a0f45a770ed1cd0f2b5511c8c103eb: hackrf: move RF gain ctrl enable behind module parameter (2015-10-24 01:01:31 +0300) Antti Palosaari (2): hackrf: fix possible null ptr on debug printing hackrf

[PATCH] hackrf: move RF gain ctrl enable behind module parameter

2015-10-23 Thread Antti Palosaari
;grabbed' state which prevents setting value to the control. Signed-off-by: Antti Palosaari --- drivers/media/usb/hackrf/hackrf.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c index 84e8a42..0fe5cb2 100644

[PATCH] hackrf: fix possible null ptr on debug printing

2015-10-21 Thread Antti Palosaari
drivers/media/usb/hackrf/hackrf.c:1533 hackrf_probe() error: we previously assumed 'dev' could be null (see line 1366) Reported-by: Dan Carpenter Signed-off-by: Antti Palosaari --- drivers/media/usb/hackrf/hackrf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 10/13] hackrf: add support for transmitter

2015-10-16 Thread Antti Palosaari
On 10/16/2015 11:53 AM, Hans Verkuil wrote: On 09/04/2015 12:06 PM, Hans Verkuil wrote: Hi Antti, Two comments, see below: On 09/01/2015 11:59 PM, Antti Palosaari wrote: HackRF SDR device has both receiver and transmitter. There is limitation that receiver and transmitter cannot be used at

Re: [PATCH] rtl28xxu: fix control message flaws

2015-10-14 Thread Antti Palosaari
On 10/15/2015 01:11 AM, Daniel Glöckner wrote: On Sat, Oct 10, 2015 at 07:45:30PM +0300, Antti Palosaari wrote: Add lock to prevent concurrent access for control message as control message function uses shared buffer. Without the lock there may be remote control polling which messes the buffer

Re: [PATCHv5 10/13] hackrf: add support for transmitter

2015-10-11 Thread Antti Palosaari
Moikka! IMHO it is false positive. Variable which is defined on line 777 is used just few lines later on line 782 as can be seen easily. I think it is because option CONFIG_DYNAMIC_DEBUG is not set => dev_dbg_ratelimited() macro is likely just NOP and gives that warning. Maybe some more logic

[PATCHv5 10/13] hackrf: add support for transmitter

2015-10-10 Thread Antti Palosaari
HackRF SDR device has both receiver and transmitter. There is limitation that receiver and transmitter cannot be used at the same time (half-duplex operation). That patch implements transmitter support to existing receiver only driver. Signed-off-by: Antti Palosaari --- drivers/media/usb/hackrf

[PATCHv5 04/13] v4l2: add support for SDR transmitter

2015-10-10 Thread Antti Palosaari
New IOCTL ops: vidioc_enum_fmt_sdr_out vidioc_g_fmt_sdr_out vidioc_s_fmt_sdr_out vidioc_try_fmt_sdr_out New vb2 buffertype: V4L2_BUF_TYPE_SDR_OUTPUT New v4l2 capability: V4L2_CAP_SDR_OUTPUT Acked-by: Hans Verkuil Signed-off-by: Antti Palosaari --- drivers/media/v4l2-core/v4l2-compat-ioctl32

[PATCHv5 01/13] v4l2: rename V4L2_TUNER_ADC to V4L2_TUNER_SDR

2015-10-10 Thread Antti Palosaari
SDR receiver has ADC (Analog-to-Digital Converter) and SDR transmitter has DAC (Digital-to-Analog Converter). Originally I though it could be good idea to have own type for receiver and transmitter, but now I feel one common type for SDR is enough. So lets rename it. Signed-off-by: Antti

[PATCHv5 08/13] hackrf: add control for RF amplifier

2015-10-10 Thread Antti Palosaari
There is Avago MGA-81563 amplifier just right after antenna connector. It could be turned on/off and its gain is around 12dB. Acked-by: Hans Verkuil Signed-off-by: Antti Palosaari --- drivers/media/usb/hackrf/hackrf.c | 26 +- 1 file changed, 25 insertions(+), 1

[PATCHv5 05/13] DocBook: document SDR transmitter

2015-10-10 Thread Antti Palosaari
Add documentation for V4L SDR transmitter (output) devices. Signed-off-by: Antti Palosaari Acked-by: Hans Verkuil --- Documentation/DocBook/media/v4l/compat.xml | 4 +++ Documentation/DocBook/media/v4l/dev-sdr.xml| 30 +++--- Documentation/DocBook/media/v4l

[PATCHv5 06/13] v4l: add type field to v4l2_modulator struct

2015-10-10 Thread Antti Palosaari
Add type field to that struct like it counterpart v4l2_tuner already has. We need type field to distinguish different tuner types from each others for transmitter too. Acked-by: Hans Verkuil Signed-off-by: Antti Palosaari --- drivers/media/v4l2-core/v4l2-ioctl.c | 18

[PATCHv5 02/13] v4l2: add RF gain control

2015-10-10 Thread Antti Palosaari
has integrated LNA/RF amplifier in any case. Acked-by: Hans Verkuil Signed-off-by: Antti Palosaari --- drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/uapi/linux/v4l2-controls.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2

[PATCHv5 07/13] DocBook: add modulator type field

2015-10-10 Thread Antti Palosaari
Add new modulator type field to documentation. Acked-by: Hans Verkuil Signed-off-by: Antti Palosaari --- Documentation/DocBook/media/v4l/vidioc-g-modulator.xml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/v4l/vidioc-g-modulator.xml b

[PATCHv5 12/13] DocBook: add SDR specific info to G_TUNER / S_TUNER

2015-10-10 Thread Antti Palosaari
Add SDR specific notes to G_TUNER / S_TUNER documentation. Add V4L2_TUNER_SDR and V4L2_TUNER_RF to supported tuner types to table. Signed-off-by: Antti Palosaari --- Documentation/DocBook/media/v4l/vidioc-g-tuner.xml | 16 1 file changed, 16 insertions(+) diff --git a

[PATCHv5 09/13] hackrf: switch to single function which configures everything

2015-10-10 Thread Antti Palosaari
-off-by: Antti Palosaari --- drivers/media/usb/hackrf/hackrf.c | 323 +- 1 file changed, 175 insertions(+), 148 deletions(-) diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c index b210510..c7dac68 100644 --- a/drivers/media

[PATCHv5 13/13] DocBook: add SDR specific info to G_MODULATOR / S_MODULATOR

2015-10-10 Thread Antti Palosaari
Add SDR specific notes to G_MODULATOR / S_MODULATOR documentation. Signed-off-by: Antti Palosaari --- Documentation/DocBook/media/v4l/vidioc-g-modulator.xml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/DocBook/media/v4l/vidioc-g-modulator.xml b/Documentation/DocBook

[PATCHv5 11/13] hackrf: do not set human readable name for formats

2015-10-10 Thread Antti Palosaari
Format names are set by core nowadays. Remove name from driver. Signed-off-by: Antti Palosaari Acked-by: Hans Verkuil --- drivers/media/usb/hackrf/hackrf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c index b64acbb

[PATCHv5 03/13] DocBook: document tuner RF gain control

2015-10-10 Thread Antti Palosaari
Add brief description for tuner RF gain control. Acked-by: Hans Verkuil Signed-off-by: Antti Palosaari --- Documentation/DocBook/media/v4l/compat.xml | 4 Documentation/DocBook/media/v4l/controls.xml | 14 ++ Documentation/DocBook/media/v4l/v4l2.xml | 1 + 3 files

[PATCHv5 00/13] SDR transmitter API

2015-10-10 Thread Antti Palosaari
v2: * Allow device open even another device node is active. This means you could use transmitter device even receiver is active and other way around, just streaming is blocked to single node. * Removed V4L2_CID_RF_TUNER_RF_GAIN_AUTO control as it was not used. * Changed RF gain documentation. A

[GIT PULL STABLE] rtl28xxu bugfix

2015-10-10 Thread Antti Palosaari
to fetch changes up to 24df7254d49dc6edd653b3fb412192a9696b92c7: rtl28xxu: fix control message flaws (2015-10-08 03:49:06 +0300) Antti Palosaari (1): rtl28xxu: fix control message flaws drivers/media/usb/dvb-usb-v2

[PATCH] rtl28xxu: fix control message flaws

2015-10-10 Thread Antti Palosaari
://bugzilla.kernel.org/show_bug.cgi?id=103391 Fixes: c56222a6b25c ("[media] rtl28xxu: move usb buffers to state") Cc: # 4.0+ Signed-off-by: Antti Palosaari --- drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 15 +-- drivers/media/usb/dvb-usb-v2/rtl28xxu.h | 2 +- 2 files changed, 14 insert

[GIT PULL STABLE 4.2+] m88ds3103 bugfix

2015-10-07 Thread Antti Palosaari
u to fetch changes up to 52a1d419371a2f8d3cd76d59d5b27309c86d65af: m88ds3103: use own reg update_bits() implementation (2015-10-04 00:59:24 +0300) -------- Antti Palosaari (1): m88ds3103: use own reg update_bits() implementation drivers

[PATCH] m88ds3103: use own reg update_bits() implementation

2015-10-03 Thread Antti Palosaari
+ Reported-by: Mark Clarkstone Tested-by: Mark Clarkstone Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/m88ds3103.c | 73 + 1 file changed, 47 insertions(+), 26 deletions(-) diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb

[PATCH] m88ds3103: use own reg update_bits() implementation

2015-10-03 Thread Antti Palosaari
+ Reported-by: Mark Clarkstone Tested-by: Mark Clarkstone Signed-off-by: Antti Palosaari --- drivers/media/dvb-frontends/m88ds3103.c | 73 + 1 file changed, 47 insertions(+), 26 deletions(-) diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb

Re: Satix S2 driver bug report - kernel tried to execute NX-protected page - exploit attempt?

2015-10-02 Thread Antti Palosaari
Moikka! I wonder if that has something to do with m88ds3103 driver conversion to I2C binding I did... But there is some things I do not understand. According to log it is DVBSky S952 device, cx23885 + m88ds3103, which crash. I see no comments on cx23885 code any Satix S2 model. Also log says it

Re: [PATCH 13/13] DocBook: add SDR specific info to G_MODULATOR / S_MODULATOR

2015-09-04 Thread Antti Palosaari
On 09/04/2015 01:26 PM, Hans Verkuil wrote: On 09/01/2015 11:59 PM, Antti Palosaari wrote: Add SDR specific notes to G_MODULATOR / S_MODULATOR documentation. Signed-off-by: Antti Palosaari --- Documentation/DocBook/media/v4l/vidioc-g-modulator.xml | 9 + 1 file changed, 9

[PATCH 1/2] vivid: SDR cap: add control for FM deviation

2015-09-01 Thread Antti Palosaari
Add user control to adjust generated FM deviation. Default it to 75kHz like public FM radio broadcast. Signed-off-by: Antti Palosaari --- drivers/media/platform/vivid/vivid-core.h| 1 + drivers/media/platform/vivid/vivid-ctrls.c | 37 +++- drivers/media/platform

[PATCH 2/2] vivid: sdr cap: few enhancements

2015-09-01 Thread Antti Palosaari
* Constify struct * Fix comments * Fix alignment * Use modulus to transfer phase angles * Correct float [-1.0, +1.0] to s8 [-128, 127] conversion Signed-off-by: Antti Palosaari --- drivers/media/platform/vivid/vivid-sdr-cap.c | 31 +++- 1 file changed, 12 insertions

[PATCH 01/13] v4l2: rename V4L2_TUNER_ADC to V4L2_TUNER_SDR

2015-09-01 Thread Antti Palosaari
SDR receiver has ADC (Analog-to-Digital Converter) and SDR transmitter has DAC (Digital-to-Analog Converter). Originally I though it could be good idea to have own type for receiver and transmitter, but now I feel one common type for SDR is enough. So lets rename it. Signed-off-by: Antti

[PATCH 12/13] DocBook: add SDR specific info to G_TUNER / S_TUNER

2015-09-01 Thread Antti Palosaari
Add SDR specific notes to G_TUNER / S_TUNER documentation. Add V4L2_TUNER_SDR and V4L2_TUNER_RF to supported tuner types to table. Signed-off-by: Antti Palosaari --- Documentation/DocBook/media/v4l/vidioc-g-tuner.xml | 19 +++ 1 file changed, 19 insertions(+) diff --git a

[PATCH 05/13] DocBook: document SDR transmitter

2015-09-01 Thread Antti Palosaari
Add documentation for V4L SDR transmitter (output) devices. Signed-off-by: Antti Palosaari Acked-by: Hans Verkuil --- Documentation/DocBook/media/v4l/compat.xml | 4 +++ Documentation/DocBook/media/v4l/dev-sdr.xml| 30 +++--- Documentation/DocBook/media/v4l

[PATCH 08/13] hackrf: add control for RF amplifier

2015-09-01 Thread Antti Palosaari
There is Avago MGA-81563 amplifier just right after antenna connector. It could be turned on/off and its gain is around 12dB. Acked-by: Hans Verkuil Signed-off-by: Antti Palosaari --- drivers/media/usb/hackrf/hackrf.c | 26 +- 1 file changed, 25 insertions(+), 1

[PATCH 11/13] hackrf: do not set human readable name for formats

2015-09-01 Thread Antti Palosaari
Format names are set by core nowadays. Remove name from driver. Signed-off-by: Antti Palosaari Acked-by: Hans Verkuil --- drivers/media/usb/hackrf/hackrf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c index b6415b9

[PATCH 07/13] DocBook: add modulator type field

2015-09-01 Thread Antti Palosaari
Add new modulator type field to documentation. Signed-off-by: Antti Palosaari --- Documentation/DocBook/media/v4l/vidioc-g-modulator.xml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/v4l/vidioc-g-modulator.xml b/Documentation/DocBook

[PATCH 09/13] hackrf: switch to single function which configures everything

2015-09-01 Thread Antti Palosaari
-off-by: Antti Palosaari --- drivers/media/usb/hackrf/hackrf.c | 323 +- 1 file changed, 175 insertions(+), 148 deletions(-) diff --git a/drivers/media/usb/hackrf/hackrf.c b/drivers/media/usb/hackrf/hackrf.c index 136de9a..5bd291b 100644 --- a/drivers/media

[PATCH 06/13] v4l: add type field to v4l2_modulator struct

2015-09-01 Thread Antti Palosaari
Add type field to that struct like it counterpart v4l2_tuner already has. We need type field to distinguish different tuner types from each others for transmitter too. Acked-by: Hans Verkuil Signed-off-by: Antti Palosaari --- drivers/media/v4l2-core/v4l2-ioctl.c | 18

[PATCH 10/13] hackrf: add support for transmitter

2015-09-01 Thread Antti Palosaari
HackRF SDR device has both receiver and transmitter. There is limitation that receiver and transmitter cannot be used at the same time (half-duplex operation). That patch implements transmitter support to existing receiver only driver. Signed-off-by: Antti Palosaari --- drivers/media/usb/hackrf

[PATCH 04/13] v4l2: add support for SDR transmitter

2015-09-01 Thread Antti Palosaari
New IOCTL ops: vidioc_enum_fmt_sdr_out vidioc_g_fmt_sdr_out vidioc_s_fmt_sdr_out vidioc_try_fmt_sdr_out New vb2 buffertype: V4L2_BUF_TYPE_SDR_OUTPUT New v4l2 capability: V4L2_CAP_SDR_OUTPUT Signed-off-by: Antti Palosaari Acked-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-dev.c | 14

<    1   2   3   4   5   6   7   8   9   10   >