But my
understanding was that the ZR36067's requirements were making this very
difficult if not impossible.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 15 Feb 2009 21:41:08 +0100, Jean Delvare wrote:
> Hi all,
>
> Today I have hit the following general protection fault when removing
> module cx8800:
This has just happened to me again today, with kernel 2.6.28.7. I have
opened a bug in bugzilla:
http://bugzilla.kernel.org/
Hi Andy,
On Mon, 02 Mar 2009 09:16:05 -0500, Andy Walls wrote:
> On Mon, 2009-03-02 at 13:39 +0100, Jean Delvare wrote:
> > On Sun, 15 Feb 2009 21:41:08 +0100, Jean Delvare wrote:
> > > Hi all,
> > >
> > > Today I have hit the following general protection fau
On Mon, 2 Mar 2009 17:03:49 +0100, Jean Delvare wrote:
> As far as I can see the key difference between bttv-input and
> cx88-input is that bttv-input only uses a simple self-rearming timer,
> while cx88-input uses a timer and a separate workqueue. The timer runs
> the workqueue, whic
Hi Trent,
On Mon, 2 Mar 2009 13:12:24 -0800 (PST), Trent Piepho wrote:
> On Mon, 2 Mar 2009, Jean Delvare wrote:
> > On Mon, 2 Mar 2009 17:03:49 +0100, Jean Delvare wrote:
> > > As far as I can see the key difference between bttv-input and
> > > cx88-input is that bt
On Tue, 3 Mar 2009 01:40:00 -0800 (PST), Trent Piepho wrote:
> On Mon, 2 Mar 2009, Jean Delvare wrote:
> > > Makes the most sense to me. I was just about to make a patch to do the
> > > same thing when I got your email. Though I was going to patch the v4l-dvb
> > >
I2C_M_IGNORE_NAK is defined since kernel 2.5.54 so we don't need to
declare it in the compatibility header.
Signed-off-by: Jean Delvare
---
v4l/compat.h |4
1 file changed, 4 deletions(-)
--- v4l-dvb.orig/v4l/compat.h 2009-03-01 16:09:10.0 +0100
+++ v4l-dvb/v4l/com
On Tue, 3 Mar 2009 12:14:06 -0800 (PST), Trent Piepho wrote:
> On Tue, 3 Mar 2009, Jean Delvare wrote:
> > On Tue, 3 Mar 2009 01:40:00 -0800 (PST), Trent Piepho wrote:
> > > On Mon, 2 Mar 2009, Jean Delvare wrote:
> > > In 2.6.20 delayed_work was split from work_stru
From: Jean Delvare
Subject: cx88: Prevent general protection fault on rmmod
When unloading the cx8800 driver I sometimes get a general protection
fault. Analysis revealed a race in cx88_ir_stop(). It can be solved by
using a delayed work instead of a timer for infrared input polling.
This fixes
From: Jean Delvare
Subject: Fix race in infrared polling on rmmod
The race on rmmod I just fixed in cx88-input affects 3 other drivers.
Fix these the same way.
Signed-off-by: Jean Delvare
---
Note that I do not have any of these devices, so this patch is
untested. Testers welcome!
linux
On Thu, 5 Mar 2009 01:43:55 -0800 (PST), Trent Piepho wrote:
> On Thu, 5 Mar 2009, Jean Delvare wrote:
> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,20)
> > struct work_struct work;
> > struct timer_list timer;
> > +#else
> > + struct delayed_work w
Hi Devin,
On Thu, 5 Mar 2009 13:03:00 -0500, Devin Heitmueller wrote:
> On Thu, Mar 5, 2009 at 4:39 AM, Jean Delvare wrote:
> I would suggest that this patch be broken into three separate patches,
> and then they can go in as the individual maintainers have the
> opportunity to t
The lock_norm module parameter doesn't look terribly useful. If you
don't want to change the norm, just don't change it. As a matter of
fact, no other v4l driver has such a parameter.
Signed-off-by: Jean Delvare
Cc: Trent Piepho
Cc: Hans Verkuil
---
linux/Documentation/vi
kmalloc() can fail for large video buffers. By default the kernel
complains loudly about allocation failures, but we don't want to
frighten the user, so ask kmalloc() to keep quiet on such failures.
Signed-off-by: Jean Delvare
Cc: Trent Piepho
Cc: Hans Verkuil
---
linux/drivers/media/
When unloading the cx8800 driver I sometimes get a general protection
fault. Analysis revealed a race in cx88_ir_stop(). It can be solved by
using a delayed work instead of a timer for infrared input polling.
Signed-off-by: Jean Delvare
---
Thanks to Trent's compatibility patches, we c
The removal of the timer which polls the infrared input is racy.
Replacing the timer with a delayed work solves the problem.
Signed-off-by: Jean Delvare
Cc: Devin Heitmueller
---
linux/drivers/media/video/em28xx/em28xx-input.c | 24 ++-
1 file changed, 7 insertions(+), 17
The removal of the timer which polls the infrared input is racy.
Replacing the timer with a delayed work solves the problem.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/ir-kbd-i2c.c | 22 ++
linux/include/media/ir-kbd-i2c.h |3 +--
2 files changed
The removal of the timer which polls the infrared input is racy.
Replacing the timer with a delayed work solves the problem.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/saa6588.c | 26 +++---
1 file changed, 7 insertions(+), 19 deletions(-)
--- v4l-dvb.orig
On Wed, 11 Mar 2009 04:55:19 +0100, Patch from Jean Delvare wrote:
> The patch number 10935 was added via Mauro Carvalho Chehab
>
> to http://linuxtv.org/hg/v4l-dvb master development tree.
>
> Kernel patches in this development tree may be modified to be backward
> com
Mailing list video4linux-l...@redhat.com is deprecated, so drop
references to it in MAINTAINERS.
Signed-off-by: Jean Delvare
Cc: Mauro Carvalho Chehab
---
MAINTAINERS |2 --
1 file changed, 2 deletions(-)
--- linux-2.6.29-rc8.orig/MAINTAINERS 2009-03-13 08:39:30.0 +0100
The video4linux-l...@redhat.com list is deprecated, point the users to
the new linux-media list instead.
Signed-off-by: Jean Delvare
---
linux/Documentation/video4linux/bttv/README |4 ++--
linux/drivers/media/radio/radio-si470x.c |4 ++--
linux/drivers/media/video/bt8xx/bttv
Hi Hans,
On Sat, 14 Mar 2009 22:39:35 +0100, Hans Verkuil wrote:
> On Saturday 14 March 2009 22:25:14 Jean Delvare wrote:
> > The video4linux-l...@redhat.com list is deprecated, point the users to
> > the new linux-media list instead.
> >
> > Signed-off-by: Jean
I see the following warning when building the zoran driver:
v4l/zoran_card.c: In function 'zoran_probe':
v4l/zoran_card.c:1243: warning: assignment from incompatible pointer type
Fixing the notify callback prototype solves it.
Signed-off-by: Jean Delvare
Cc: Hans Verkuil
Cc: Tr
exported by the
ir-kbd-i2c and tvaudio modules.
But this is all said without having much knowledge of the bttv, tvaudio
and ir-kbd-i2c drivers, so I might as well be completely off track.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 15 Mar 2009 10:42:41 -0700 (PDT), Trent Piepho wrote:
> On Sun, 15 Mar 2009, Jean Delvare wrote:
> > On Sun, 15 Mar 2009 13:44:01 +0100, Hans Verkuil wrote:
> > This is the typical multifunction device problem. It isn't specifically
> > related to I2C, the exac
Hi Andy,
On Sun, 15 Mar 2009 15:34:33 -0400, Andy Walls wrote:
> On Sun, 2009-03-15 at 18:12 +0100, Jean Delvare wrote:
> > Hi Hans,
> >
> > On Sun, 15 Mar 2009 13:44:01 +0100, Hans Verkuil wrote:
> > > Hi Mauro, Jean,
> > >
> > > When conve
y we
> remain bug-compatible with the current situation. Or even slightly better
> since we can now ensure that audio is working at least.
Agreed.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...
So, all in all, great care should always be taken when more than one
driver accesses the same I2C device. And even if only one driver
accesses the I2C device, all accesses that can happen in parallel (for
example triggered by sysfs attribute reads or writes) may have to be
serialized by the driv
Hi Mauro,
On Mon, 16 Mar 2009 06:34:02 -0300, Mauro Carvalho Chehab wrote:
> On Sun, 15 Mar 2009 18:53:13 +0100
> Jean Delvare wrote:
> > On Sun, 15 Mar 2009 10:42:41 -0700 (PDT), Trent Piepho wrote:
> > > You can also split the "device" into multiple devices. Mo
Hi Andy,
On Sun, 15 Mar 2009 20:52:33 -0400, Andy Walls wrote:
> On Sun, 2009-03-15 at 23:26 +0100, Jean Delvare wrote:
> > No. Once again: Linux doesn't support binding more than one driver to a
> > device. This has _nothing_ to do with any choice done in i2c-core.
>
Hi Mauro,
On Mon, 16 Mar 2009 09:52:37 -0300, Mauro Carvalho Chehab wrote:
> On Mon, 16 Mar 2009 12:18:01 +0100
> Jean Delvare wrote:
> > I really don't see any problem there. There are many drivers (i2c or
> > not) in the kernel which do exactly this and this works just f
On Mon, 16 Mar 2009 12:43:33 -0700 (PDT), Trent Piepho wrote:
> On Mon, 16 Mar 2009, Jean Delvare wrote:
> > Come on, just look at ir-kbd-i2c and tvaudio again, see how great are
> > these drivers which have been "designed" on top of the legacy i2c
> > binding model.
Hi Trent,
On Mon, 16 Mar 2009 15:47:17 -0700 (PDT), Trent Piepho wrote:
> On Mon, 16 Mar 2009, Jean Delvare wrote:
> > You are unfair. The pull request came with a short log of all the
> > changes.
>
> "short" log. His entire series was decribed with fewer words
o finished. I'm waiting for a last test by Jean
> Delvare before I post that one as well.
Testing complete, it seems to work just fine. Thanks!
> - Added support for saa6588 to saa7134: needed to drop the legacy i2c API
> from saa6588. This is in my pull request for my v4l-dvb t
ion-ALL-IN-ONE.patch
But for review the individual patches are much better.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
* Return actual error values as returned by the i2c subsystem, rather
than 0 or 1.
* If the registration of the second bus fails, unregister the first one
before exiting, otherwise we are leaking resources.
Signed-off-by: Jean Delvare
Cc: Hans Verkuil
Cc: Andy Walls
---
linux/drivers
In the standard device driver binding model, the name field of
struct i2c_client is used to match devices to their drivers, so we
must stop using it for internal purposes. Define a separate field
in struct IR_i2c as a replacement, and use it.
Signed-off-by: Jean Delvare
---
linux/drivers/media
oard basis. This would be more efficient and less risky than always
probing extra addresses on all boards. I'll give it a try later.
Signed-off-by: Jean Delvare
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Andy Walls
Cc: Mike Isely
---
linux/drivers/media/video/bt8xx/bttv-i2c.c
For specific boards, pass initialization data to ir-kbd-i2c instead
of modifying the settings after the device is initialized. This is
more efficient and easier to read.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/cx231xx/cx231xx-cards.c | 14 ---
linux/drivers/media/video
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The MSI
t...@nywhere Plus is one of these boards.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/saa7134/saa7134-input.c | 27
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The
AVerMedia Cardbus are two of these boards.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/saa7134/saa7134-input.c | 35 +++--
1
Hi Andy,
Thanks for the fast review.
On Sat, 04 Apr 2009 08:46:00 -0400, Andy Walls wrote:
> On Sat, 2009-04-04 at 14:26 +0200, Jean Delvare wrote:
> > * Return actual error values as returned by the i2c subsystem, rather
> > than 0 or 1.
> > * If the registration of
The client_register and client_unregister methods are optional so
there is no point in defining stub ones. Especially when these methods
are likely to be removed soon.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c | 12
1 file changed, 12
Hi Andy,
On Sat, 04 Apr 2009 09:42:09 -0400, Andy Walls wrote:
> On Sat, 2009-04-04 at 14:28 +0200, Jean Delvare wrote:
> > Let card drivers probe for IR receiver devices and instantiate them if
> > found. Ultimately it would be better if we could stop probing
> > completel
ttv driver's I2C adapter ID
(I2C_HW_B_BT848) and was thus affected when ir-kbd-i2c is loaded. This
is the only reason why my patch touches the pvrusb2 driver. If you tell
me you want the ir-kbd-i2c driver to leave pvrusb2 alone, I can drop
all the related changes from my patch, that's very e
e there were some other i2c API
> > changes in 2.6.26 anyway I decided that it made life easier if we put the
> > switchover point at 2.6.26.
>
> Ok.
>
> > There are some other cleanups I could do, but all the important ones are
> > now
> > taken care of.
Hi Andy,
On Sat, 04 Apr 2009 21:50:08 -0400, Andy Walls wrote:
> On Sun, 2009-04-05 at 00:51 +0200, Jean Delvare wrote:
> > On Sat, 04 Apr 2009 09:42:09 -0400, Andy Walls wrote:
> > > I think this is way out of date for cx18 based boards. The only IR chip
> > > I
net/linux/ir-kbd-i2c/
Changes since previous version:
* Dropped cx18 changes on request by Andy Walls.
* Added disable_ir module parameter to all bridge drivers which didn't
have it.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mike,
Selected answers, as most points have already been discussed elsewhere
meanwhile...
On Sat, 4 Apr 2009 18:29:35 -0500 (CDT), Mike Isely wrote:
> On Sun, 5 Apr 2009, Jean Delvare wrote:
> > This is excellent news. As I said in the header comment of the patch,
> > avoiding
hem. As long as they are out-of-tree,
they can fix things after the fact easily. They aren't affected by the
merge window. They'll have several weeks before kernel 2.6.30 is
actually released, which they can use to fix anything that broke.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
tree however, I don't know the latest state of your code.
And I can't see any lirc_zilog module in the CVS repository of lirc
either. But if you show me the i2c code you're worried about, I'll let
you know what I think about it.
--
Jean Delvare
--
To unsubscribe from this lis
s and not others, and you
can probe some addresses and not others. And one i2c drivers can
cleanly support more than one device type.
What should be considered to decide whether two devices should be
supported by the same driver or not, is how much their supporting code
has in common.
--
Jean
#x27;t make any sense of this error. Help anyone?
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
h a MSI t...@nywhere Plus that could help with
testing?
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
1 r1 t0 dev=30 code=8
> ir-kbd-i2c: ir hauppauge (rc5): s1 r1 t0 dev=30 code=8
> ir-kbd-i2c: ir hauppauge (rc5): s1 r1 t1 dev=30 code=9
> ir-kbd-i2c: ir hauppauge (rc5): s1 r1 t1 dev=30 code=2
> ir-kbd-i2c: ir hauppauge (rc5): s1 r1 t1 dev=30 code=2
> ir-kbd-i2c: ir hauppauge (rc5): s1 r1 t0 dev=30 code=0
>
>
> Success.
OK, good to know that adding support for the cx18 will be possible and
easy. I propose that we postpone this addition until after my code is
merged though, to avoid making the situation more complex than it
already is.
Thanks a lot for the testing!
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
_ the i2c
model conversion is done, so that we have a proper changelog entry
saying that we added support for the PVR-150, and that it gets proper
testing. Hiding support addition in a larger patch would probably do
as much harm as good.
--
Jean Delvare
--
To unsubscribe from this list: send the line
the decision about
> loading based on the device hardware. Since this change as a whole is
> mergeable without the rest of your changeset I felt it most expedient
> just to push this up now.
That's alright. In this specific case I really don't care who gets the
fame and fla
Hi Andy,
On Mon, 06 Apr 2009 07:56:22 -0400, Andy Walls wrote:
> On Mon, 2009-04-06 at 10:54 +0200, Jean Delvare wrote:
> > Thanks a lot for the testing!
>
> You're welcome.
>
> Sorry for being such a pain to what I suspect you hoped was to be a
> "simple"
On Mon, 6 Apr 2009 10:32:52 +0200, Jean Delvare wrote:
> My latest pull of the v4l-dvb repository this morning broke the build:
> make[3]: *** No rule to make target `/home/khali/src/v4l-dvb/v4l/cx88-dsp.o',
> needed by `/home/khali/src/v4l-dvb/v4l/tda18271.o'. Stop.
>
&
es not.) We would also need to ensure that
ir-kbd-i2c doesn't crash when it sees a device at an address it doesn't
support.
[1] The I2C device name "ir-kbd" is incorrect, BTW, as dashes aren't
allowed in I2C device names. Not sure how I missed that while I wrote
it half a
e option
> should be expanded and possibly made permanent.
I agree. I presume that this is one of the reasons why some bridge
drivers have a disable_ir parameter (the other reason being lirc). It
would probably make sense to not only keep these module parameters even
after lirc is
Hi Andy,
On Mon, 06 Apr 2009 21:20:37 -0400, Andy Walls wrote:
> On Mon, 2009-04-06 at 17:44 +0200, Jean Delvare wrote:
> > The bottom line is that we have to instantiate I2C devices for IR
> > components regardless of the driver which will handle them (ir-kbd-i2c,
> > lirc_i
Hi Mike,
Glad to see we all mostly agree on what to do now. I'll still answer
some of your questions below, to clarify things even more.
On Tue, 7 Apr 2009 01:19:02 -0500 (CDT), Mike Isely wrote:
> On Mon, 6 Apr 2009, Jean Delvare wrote:
> > The bottom line is that we have to i
Hi Mauro,
On Tue, 7 Apr 2009 07:50:29 -0300, Mauro Carvalho Chehab wrote:
> On Tue, 7 Apr 2009 12:02:09 +0200
> Jean Delvare wrote:
>
> > Hi Mike,
> >
> > Glad to see we all mostly agree on what to do now. I'll still answer
> > some of your questions belo
On Sat, 04 Apr 2009 08:46:00 -0400, Andy Walls wrote:
> On Sat, 2009-04-04 at 14:26 +0200, Jean Delvare wrote:
> > * Return actual error values as returned by the i2c subsystem, rather
> > than 0 or 1.
> > * If the registration of the second bus fails, unregister the f
On Mon, 06 Apr 2009 23:10:36 +0200, hermann pitton wrote:
> Am Montag, den 06.04.2009, 10:40 +0200 schrieb Jean Delvare:
> > Anyone out there with a MSI t...@nywhere Plus that could help with
> > testing?
>
> Here is a link to one of the initial reports by Henry, oth
The history of changes does belong to git.
Signed-off-by: Jean Delvare
---
In general I wouldn't care too much but it happens that this specific
comment triggers a false positive in one of my scripts, so I'd rather
get rid of it.
linux/drivers/media/video/tda7432.c | 14 ---
On Tue, 7 Apr 2009 17:55:17 +0200, Jean Delvare wrote:
> The history of changes does belong to git.
>
> Signed-off-by: Jean Delvare
> ---
> In general I wouldn't care too much but it happens that this specific
> comment triggers a false positive in one of my scripts, so
though, and I don't want to touch that kind of code without
hardware at hand to test my changes.
> The way I'm doing the IR reading is the same as the Windows driver does - I
> got the information through the Qemu with pci-proxy patch applied.
Thanks,
--
Jean Delvare
--
To unsubs
Hi Oldrich,
On Thu, 9 Apr 2009 23:12:51 +0200, Oldrich Jedlicka wrote:
> On Saturday 04 of April 2009 at 14:31:37, Jean Delvare wrote:
> > Now that we instantiate I2C IR devices explicitly, we can skip probing
> > altogether on boards where the I2C IR device address is known. Th
* Return actual error values as returned by the i2c subsystem, rather
than 0 or 1.
* If the registration of the second bus fails, unregister the first one
before exiting, otherwise we are leaking resources.
Signed-off-by: Jean Delvare
Cc: Hans Verkuil
Acked-by: Andy Walls
---
Mauro, can
On Fri, 17 Apr 2009 18:16:06 +0200, Oldrich Jedlicka wrote:
> Hi Jean,
>
> On Friday 17 of April 2009 at 15:45:20, Jean Delvare wrote:
> > Hi Oldrich,
> >
> > On Thu, 9 Apr 2009 23:12:51 +0200, Oldrich Jedlicka wrote:
> > > On Saturday 04 of April 2009 at 14
/ir-kbd-i2c/ir-kbd-i2c-conversion-ALL-IN-ONE.patch
But for review the individual patches are much better.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
In the standard device driver binding model, the name field of
struct i2c_client is used to match devices to their drivers, so we
must stop using it for internal purposes. Define a separate field
in struct IR_i2c as a replacement, and use it.
Signed-off-by: Jean Delvare
---
linux/drivers/media
oard basis. This would be more efficient and less risky than always
probing extra addresses on all boards. I'll give it a try later.
Signed-off-by: Jean Delvare
Cc: Mauro Carvalho Chehab
Cc: Hans Verkuil
Cc: Andy Walls
Cc: Mike Isely
---
linux/drivers/media/video/bt8xx/bttv-i2c.c
For specific boards, pass initialization data to ir-kbd-i2c instead
of modifying the settings after the device is initialized. This is
more efficient and easier to read.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/cx231xx/cx231xx-cards.c |3
linux/drivers/media/video/cx231xx
crash on unsupported IR devices. Simply,
the driver will not bind to the unsupported devices.
Signed-off-by: Jean Delvare
Cc: Andy Walls
---
linux/drivers/media/video/ir-kbd-i2c.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
--- v4l-dvb.orig/linux/drivers/media/video
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The MSI
t...@nywhere Plus is one of these boards.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/saa7134/saa7134-input.c | 28
Now that we instantiate I2C IR devices explicitly, we can skip probing
altogether on boards where the I2C IR device address is known. The
AVerMedia Cardbus E506R is one of these boards.
Signed-off-by: Jean Delvare
Tested-by: Oldrich Jedlicka
---
linux/drivers/media/video/saa7134/saa7134
mainline.
Your first patch is still interesting but it is independent from my own
patches, so it can be merged before or after, it doesn't matter.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to ma
Hi again Mike,
On Sat, 18 Apr 2009 11:25:19 +0200, Jean Delvare wrote:
> On Fri, 17 Apr 2009 18:35:55 -0500 (CDT), Mike Isely wrote:
> > I thought we were going to leave the pvrusb2 driver out of this since
> > I've already got a change ready that also includes additional log
2c fixes this problem.
>
> Signed-off-by: Guennadi Liakhovetski
Looks good to me.
Acked-by: Jean Delvare
> ---
>
> The best way to trigger action is by submitting a patch:-) So, let's see
> what comes out of it - on the one hand I don't see any reason why media
> has
Hi Mike,
Sorry for the late answer.
On Sat, 18 Apr 2009 08:53:35 -0500 (CDT), Mike Isely wrote:
> On Sat, 18 Apr 2009, Jean Delvare wrote:
> > On Sat, 18 Apr 2009 11:25:19 +0200, Jean Delvare wrote:
> > > Hmm, I thought that our latest discussions had (at least partly)
&g
Use the physical device rather than the i2c adapter as the reference
device when loading firmwares. This will prevent the sysfs name
collision with i2c-dev that has been reported many times.
I may have missed other drivers which need the same fix.
Signed-off-by: Jean Delvare
---
Note: this
On Fri, 17 Apr 2009 22:29:27 +0200, Jean Delvare wrote:
> Here comes an update of my conversion of ir-kbd-i2c to the new i2c
> binding model. I've split it into 6 pieces for easier review. (...)
Did anyone test these patches, please?
--
Jean Delvare
--
To unsubscribe from this lis
The new i2c binding model doesn't use i2c_probe.
Signed-off-by: Jean Delvare
---
linux/drivers/media/video/tea6415c.c |1 -
linux/drivers/media/video/tea6420.c |1 -
2 files changed, 2 deletions(-)
--- v4l-dvb.orig/linux/drivers/media/video/tea6415c.c 2009-04-06
10:10:25.
equally informative output. The only difference is that i2c clients
which are not a v4l2 subdev won't show up, but I guess this case is
not supposed to happen anyway.
Signed-off-by: Jean Delvare
Cc: Mike Isely
---
Mike, can you please review and test this patch? Thanks.
linux/drivers/media/
On Fri, 1 May 2009 22:25:28 -0500 (CDT), Mike Isely wrote:
> On Thu, 30 Apr 2009, Mike Isely wrote:
>
> > On Thu, 30 Apr 2009, Jean Delvare wrote:
> >
> > > The i2c core used to maintain a list of client for each adapter. This
> > > is a duplication of what t
l, at this point, pretty much everything
which pushes the ir-kbd-i2c conversion forward is fine with me, as it
seems to be kind of stuck. The theory was that we would use the 2.6.31
development cycle to merge lirc and then convert ir-kbd-i2c, however I
don't see much happening in this direction, w
module parameters in
this driver.
Signed-off-by: Jean Delvare
Cc: Mauro Carvalho Chehab
Cc: Fabio Belavenuto
---
drivers/media/radio/radio-tea5764.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.0-rc6.orig/drivers/media/radio/radio-tea5764.c 2011-05-20
10:4
Hi Andy,
On Friday 08 July 2011 12:34:38 pm Andy Walls wrote:
> Jean Delvare wrote:
> >The third parameter of module_param is supposed to represent sysfs
> >file permissions. A value of "1" leads to the following:
> >
> >$ ls -l /sys/module/radio_tea5764/p
nce. I
would guess that you know what backend is present on a system when you
try to identify it.
At this point, I see the work needed to review your patches, the risk
of regressions due to the large size of the patch set, but I don't see
any immediate benefit. Thus I am not going to look into it at
tring().
But more importantly, I suspect that a better fix would be to not call
these macros when dev or ir, respectively, is NULL. The faulty dprintk
calls in get_key_msi_tvanywhere_plus() and get_key_flydvb_trio() could
be replaced with i2cdprintk (which is misnamed IMHO, BTW.)
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
preferable.
>
> Signed-off-by: Dan Carpenter
> ---
> v2: Jean Delvare suggested that I use i2cdprintk() instead of modifying
> dprintk().
>
> diff --git a/drivers/media/video/saa7134/saa7134-input.c
> b/drivers/media/video/saa7134/saa7134-input.c
> index e5565e2..7691bf2
Hi Dan,
On Tue, 25 May 2010 11:19:53 +0200, Dan Carpenter wrote:
> The problem is that dprintk() dereferences "dev" which is null here.
> The i2cdprintk() uses "ir" so that's OK.
>
> Signed-off-by: Dan Carpenter
> ---
> v2: Jean Delvare suggested t
On Tue, 25 May 2010 11:21:50 +0200, Dan Carpenter wrote:
> The original code had two break statements in a row.
>
> Signed-off-by: Dan Carpenter
Acked-by: Jean Delvare
> ---
> v3: Put this in a seperate patch.
>
> diff --git a/drivers/media/video/saa7134/saa7134-input
custom probing function.
Signed-off-by: Jean Delvare
Tested-by: "Timothy D. Lenz"
---
This fix applies to kernels 2.6.31 to 2.6.34. Should be sent to Linus
quickly. I had already sent on March 29th, but apparently it was
overlooked. I have further i2c patches which depend on this one,
On Sat, 29 May 2010 01:29:54 -0300, Mauro Carvalho Chehab wrote:
> Em Sat, 22 May 2010 22:59:21 +0200
> Jean Delvare escreveu:
> > I would have used "(null)" instead of "" for consistency with
> > lib/vsprintf.c:string().
> >
> > But more import
le gain
> from doing it all in one go.
If I take the patch in my i2c tree, the aim is to merge it upstream
immediately, so merge issues won't exist.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.k
to the core with commit
> e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers.
>
> As there is no need anymore to clear the clientdata-pointer, remove all
> current
> occurrences in the drivers to simplify the code and prevent confusion.
>
> Signed-off-by: Wolfram Sang
101 - 200 of 369 matches
Mail list logo
