Re: [Mesa-dev] [PATCH] glsl: look for frag data bindings with [0] tacked onto the end for arrays

2016-08-09 Thread Eric Anholt
Ilia Mirkin writes: > The GL spec is very unclear on this point. Apparently this is discussed > without resolution in the closed Khronos bugtracker at > https://cvs.khronos.org/bugzilla/show_bug.cgi?id=7829 . The > recommendation is to allow dropping the [0] for looking up the bindings. Reviewed

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 Nicolas Boichat changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #12 from Nicolas

[Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Release previous context's display

2016-08-09 Thread Nicolas Boichat
eglMakeCurrent can also be used to change the active display. In that case, we need to decrement ref_count of the previous display (possibly destroying it), and increment it on the next display. Also, old_dsurf/old_rsurf cannot be non-NULL if old_ctx is NULL, so we only need to test if old_ctx is

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Edward O'Callaghan
Hey guys, Well taking a step back here for a second. My initial thoughts are - what, conceptually, is the primary user of addrlib from an extremely high level view? If the case is mesa3d then perhaps mesa should be treated as the upstream from which other users pull. If the case is that it is ind

Re: [Mesa-dev] [PATCH 0/4] RadeonSI: GPU hang fix + 3 small changes

2016-08-09 Thread Michel Dänzer
On 10/08/16 08:34 AM, Marek Olšák wrote: > Hi, > > The first patch is pretty important and fixes the root cause of > Overlord and Witcher 2 hangs. The GLSL revert can be reverted after > that. I assume you don't mean "revert the revert" literally, but just re-applying the original change again.

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97231 --- Comment #14 from Roland Scheidegger --- (In reply to Jules Blok from comment #13) > Created attachment 125650 [details] > api trace file version 4 > > I've added an apitrace that was captured on Linux, perhaps you will have > less problems r

[Mesa-dev] [PATCH] st/nine: Fix invalid attempt to use indirect draws.

2016-08-09 Thread Trevor Davenport
Since commit 6d7177f01b231e9fe79a558c28d2b562a218d7ea, radeonsi would take a different path if info->indirect_params was not initialized properly. Nine was not initializating this field. --- src/gallium/state_trackers/nine/device9.c | 1 + 1 file changed, 1 insertion(+) diff --git src/gallium/st

[Mesa-dev] [PATCH 4/6] nir: Introduce a nir_opt_move_comparisons() pass.

2016-08-09 Thread Kenneth Graunke
This tries to move comparisons (a common source of boolean values) closer to their first use. For GPUs which use condition codes, this can eliminate a lot of temporary booleans and comparisons which reload the condition code register based on a boolean. Signed-off-by: Kenneth Graunke --- src/co

[Mesa-dev] [PATCH 3/6] nir: Turn -(b2f(a) + b2f(b) >= 0 into !(a || b).

2016-08-09 Thread Kenneth Graunke
On Haswell (GL 3.3): total instructions in shared programs: 6211485 -> 6211427 (-0.00%) instructions in affected programs: 16260 -> 16202 (-0.36%) helped: 25 HURT: 37 On Broadwell (GL 4.4): total instructions in shared programs: 11640288 -> 11640218 (-0.00%) instructions in affected programs: 16

[Mesa-dev] [PATCH 2/6] nir: Turn bcsel of +/- 1.0 and 0.0 into b2f sequences.

2016-08-09 Thread Kenneth Graunke
On Haswell (GL 3.3): total instructions in shared programs: 6208759 -> 6203860 (-0.08%) instructions in affected programs: 856541 -> 851642 (-0.57%) helped: 3157 HURT: 113 LOST: 7 GAINED: 15 On Broadwell (GL 4.4): total instructions in shared programs: 11637854 -> 11632016 (-0.05%) instruction

[Mesa-dev] [PATCH 5/6] i965: Move nir_lower_locals_to_regs a bit later.

2016-08-09 Thread Kenneth Graunke
I'm going to add a boolean scheduling pass that I want run late, but after copy propagation and dead code elimination. Yet, I don't want to have to think about registers. So, move the register conversion a little later. No impact on shader-db. Suggested by Jason Ekstrand. Signed-off-by: Kennet

[Mesa-dev] [PATCH 6/6] i965: Use the nir_move_comparisons pass.

2016-08-09 Thread Kenneth Graunke
On Haswell (GL 3.3): total instructions in shared programs: 6211427 -> 6210079 (-0.02%) instructions in affected programs: 219356 -> 218008 (-0.61%) helped: 567 HURT: 132 No spill/fill changes. LOST: 0 GAINED: 4 On Broadwell (GL 4.4): total instructions in shared programs: 11640218 -> 116321

[Mesa-dev] [PATCH 1/6] nir: Convert ineg(b2i(a)) to a if it's a boolean.

2016-08-09 Thread Kenneth Graunke
On Haswell (GL 3.3): total instructions in shared programs: 6211678 -> 6211584 (-0.00%) instructions in affected programs: 18968 -> 18874 (-0.50%) helped: 62 HURT: 0 LOST: 0 GAINED: 4 On Broadwell (GL 4.4): total instructions in shared programs: 11638930 -> 11638181 (-0.01%) instructions in af

Re: [Mesa-dev] [PATCH] glsl: look for frag data bindings with [0] tacked onto the end for arrays

2016-08-09 Thread Ilia Mirkin
ping? do we want this? should i drop it? On Wed, Jul 13, 2016 at 3:37 PM, Ilia Mirkin wrote: > Thanks for confirming, Corentin. > > Ian, do you have any opinions on this? Seems like a fairly innocuous > thing to be doing... > > On Fri, Jul 8, 2016 at 3:39 PM, Corentin Wallez wrote: >> Not sure h

[Mesa-dev] [PATCH 2/2] aubinator: Fix the tool to correctly decode the DWords

2016-08-09 Thread Sirisha Gandikota
From: Sirisha Gandikota Several fixes have been added as part of this as listed below: 1) Fix the mask and add disassembler handling for STATE_DS, STATE_HS as the mask returned wrong values of the fields. 2) Fix the GEN_TYPE_ADDRESS/GEN_TYPE_OFFSET decoding - the address/ offset were handled th

[Mesa-dev] [PATCH 0/2] *** Aubinator tool for Intel Gen platforms ***

2016-08-09 Thread Sirisha Gandikota
From: Sirisha Gandikota This is a patch series for adding the aubinator tool to the codebase. The aubinator tool is designed to help the driver developers to debug the driver functionality by decoding the data in the .aub files. This tool is for Intel Gen platforms and has been tested for Gen7.5

[Mesa-dev] [PATCH 1/2] aubinator: Add a new tool called Aubinator to the src/intel/tools folder.

2016-08-09 Thread Sirisha Gandikota
From: Kristian Høgsberg Kristensen The Aubinator tool is designed to help the driver developers in debugging the driver functionality by decoding the data in the .aub files. Primary Authors of this tool are Damien Lespiau and Kristian Høgsberg Kristensen . Signed-off-by: Sirisha Gandikota ---

[Mesa-dev] [PATCH 4/4] radeonsi: set CB_COLORn_INFO.ROUND_MODE

2016-08-09 Thread Marek Olšák
From: Marek Olšák just do what the register spec says --- src/gallium/drivers/radeonsi/si_state.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index ebd2b7d..94dbe4c 100644 --- a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 2/4] radeonsi: disallow MIN/MAX blend equations for dual source blending

2016-08-09 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index f5b2330..8f7203e 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++ b/src/g

[Mesa-dev] [PATCH 1/4] radeonsi: only set dual source blending for MRT0

2016-08-09 Thread Marek Olšák
From: Marek Olšák This is the proper fix for Overlord and Witcher 2 hangs. The hang condition is that 1 app must write to MRT0 and MRT1 from a pixel shader while MRT1 is disabled in CB_TARGET_MASK (does this generate unflushable pixel quads? I don't know), and another app (e.g. Glamor) must enab

[Mesa-dev] [PATCH 0/4] RadeonSI: GPU hang fix + 3 small changes

2016-08-09 Thread Marek Olšák
Hi, The first patch is pretty important and fixes the root cause of Overlord and Witcher 2 hangs. The GLSL revert can be reverted after that. Please review. Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/

[Mesa-dev] [PATCH 3/4] radeonsi: set CB_COLORn_INFO.SIMPLE_FLOAT

2016-08-09 Thread Marek Olšák
From: Marek Olšák This can help enable some blend optimizations (see the register spec). Vulkan always sets this. --- src/gallium/drivers/radeonsi/si_state.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c ind

[Mesa-dev] [AppVeyor] mesa master #1900 failed

2016-08-09 Thread AppVeyor
Build mesa 1900 failed Commit 3f100b77f9 by Marek Olšák on 8/1/2016 10:48 PM: gallium/radeon: use unflushed fences for deferred flushes (v2)\n\n+23% Bioshock Infinite performance.\n\nv2: - use the new fence_finish interface\n- allow deferred fences with mul

Re: [Mesa-dev] [PATCH v2 00/27] i965: Rework the blorp API to use ISL

2016-08-09 Thread Jason Ekstrand
On Tue, Aug 9, 2016 at 4:02 PM, Chad Versace wrote: > On 07/26/2016 03:11 PM, Jason Ekstrand wrote: > >> This patch series builds on the previous one I just sent and reworks the >> blorp API to be entirely ISL. The last bits of intel_mipmap_tree are >> removed from the ISL internals and shoved i

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #11 from Alexandr Zelinsky --- fix working if you need logs with last tracing patch https://bpaste.net/show/6b49674b4e26 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.__

Re: [Mesa-dev] [PATCH 1/2] glcpp: Track the actual version instead of just the version_resolved flag

2016-08-09 Thread Timothy Arceri
Both patches are: Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/4] nir: Drop an unused program/hash_table.h include.

2016-08-09 Thread Timothy Arceri
On Tue, 2016-08-09 at 16:06 -0700, Ian Romanick wrote: > With the one comment on patch 3 resolved, this series is > > Reviewed-by: Ian Romanick Series also: Reviewed-by: Timothy Arceri > > On 08/09/2016 10:17 AM, Eric Anholt wrote: > > > > --- > >  src/compiler/nir/nir_lower_samplers.c | 1

Re: [Mesa-dev] [PATCH 1/4] nir: Drop an unused program/hash_table.h include.

2016-08-09 Thread Ian Romanick
With the one comment on patch 3 resolved, this series is Reviewed-by: Ian Romanick On 08/09/2016 10:17 AM, Eric Anholt wrote: > --- > src/compiler/nir/nir_lower_samplers.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/compiler/nir/nir_lower_samplers.c > b/src/compiler/nir/nir_lo

Re: [Mesa-dev] [PATCH 3/4] prog_hash_table: Convert to using util/hash_table.h.

2016-08-09 Thread Ian Romanick
On 08/09/2016 10:17 AM, Eric Anholt wrote: > Improves glretrace -b servo.trace (a trace of Mozilla's servo rendering > engine booting, rendering a page, and exiting) from 1.8s to 1.1s. It uses > a large uniform array of structs, making a huge number of separate program > resources, and the fixed-s

Re: [Mesa-dev] [PATCH v2 00/27] i965: Rework the blorp API to use ISL

2016-08-09 Thread Chad Versace
On 07/26/2016 03:11 PM, Jason Ekstrand wrote: This patch series builds on the previous one I just sent and reworks the blorp API to be entirely ISL. The last bits of intel_mipmap_tree are removed from the ISL internals and shoved into brw_blorp.c/h which simply serves as a wrapper around the ISL

[Mesa-dev] [Bug 97270] [softpipe] piglit ext_framebuffer_multisample-fast-clear GL_ARB_texture_rg single-sample regression

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97270 Bug ID: 97270 Summary: [softpipe] piglit ext_framebuffer_multisample-fast-clear GL_ARB_texture_rg single-sample regression Product: Mesa Version: git Ha

Re: [Mesa-dev] [PATCH v2] egl: android: query native window default width and height

2016-08-09 Thread Chad Versace
On 08/09/2016 01:49 PM, Haixia Shi wrote: > Pinging this thread - any objection to commit this? Thanks. I pushed it. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 Chad Versace changed: What|Removed |Added CC||c...@kiwitree.net -- You are receiving t

[Mesa-dev] [PATCH 2/2] glcpp: Only disallow #undef of pre-defined macros on GLSL ES >= 3.00 shaders

2016-08-09 Thread Ian Romanick
From: Ian Romanick Section 3.4 (Preprocessor) of the GLSL ES 3.00 spec says: It is an error to undefine or to redefine a built-in (pre-defined) macro name. The GLSL ES 1.00 spec does not contain this text. Section 3.3 (Preprocessor) of the GLSL 1.30 spec says: #define and #undef func

[Mesa-dev] [PATCH 1/2] glcpp: Track the actual version instead of just the version_resolved flag

2016-08-09 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/glcpp/glcpp-parse.y | 10 +- src/compiler/glsl/glcpp/glcpp.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/glcpp/glcpp-parse.y b/

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Jason Ekstrand
On Tue, Aug 9, 2016 at 1:12 PM, Dave Airlie wrote: > > > > tbh, git submodules are more annoying than they need to be, and I'm > > not really terribly excited to use that for something that is a build > > dependency. Maybe just move it into libdrm instead? > > > > I've only had to use git submod

Re: [Mesa-dev] [PATCH V2 2/3] anv/pipeline: Add sample locations for gen7-7.5

2016-08-09 Thread Jason Ekstrand
LGTM On Tue, Aug 9, 2016 at 2:41 PM, Anuj Phogat wrote: > V1: Add multisample positions (Nanley) > V2: Fix 8x sample positions to match OpenGL (Anuj) > V3: Vulkan has standard sample locations. They need not be same as > in OpenGL. (Anuj) > > Signed-off-by: Anuj Phogat > Reviewed-by: Jason

[Mesa-dev] [PATCH V2 2/3] anv/pipeline: Add sample locations for gen7-7.5

2016-08-09 Thread Anuj Phogat
V1: Add multisample positions (Nanley) V2: Fix 8x sample positions to match OpenGL (Anuj) V3: Vulkan has standard sample locations. They need not be same as in OpenGL. (Anuj) Signed-off-by: Anuj Phogat Reviewed-by: Jason Ekstrand --- src/intel/vulkan/genX_pipeline_util.h | 47 ++

Re: [Mesa-dev] [PATCH 1/6] gallium/radeon: change the vendor string to Advanced Micro Devices, Inc.

2016-08-09 Thread Marek Olšák
On Sun, Aug 7, 2016 at 12:01 AM, Axel Davy wrote: > Hi, > > This looks like it will perturb driver detection of already written games. > > For example from the dolphin sources, this change would make them detect > catalyst as driver. > > As it is known workarounds are applied depending on the driv

Re: [Mesa-dev] [PATCH v2] egl: android: query native window default width and height

2016-08-09 Thread Haixia Shi
Pinging this thread - any objection to commit this? Thanks. On Thu, Jul 28, 2016 at 8:58 PM, Tomasz Figa wrote: > On Fri, Jul 29, 2016 at 2:51 AM, Haixia Shi wrote: > > On android platform, the width and height of a native window surface may > > be updated after initialization. It is therefore

Re: [Mesa-dev] [PATCH] util: Use win32 intrinsics for util_last_bit if present.

2016-08-09 Thread Brian Paul
On 08/09/2016 01:41 PM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich v2: Split into two patches. v3: Fix off by one problem. Signed-off-by: Mathias Fröhlich --- src/util/bitscan.h | 12 1 file changed, 12 insertions(+) diff --git a/src/util/bitscan.h b/src/util/bit

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Dave Airlie
> > tbh, git submodules are more annoying than they need to be, and I'm > not really terribly excited to use that for something that is a build > dependency. Maybe just move it into libdrm instead? > I've only had to use git submodules once with spice project, and it was a nightmare. It makes pac

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #10 from Nicolas Boichat --- Created attachment 125652 --> https://bugs.freedesktop.org/attachment.cgi?id=125652&action=edit Possible fix Possible fix attached, please give it a try. Thanks! -- You are receiving this mail because

Re: [Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

2016-08-09 Thread Mathias Fröhlich
Hi Brian, On Tuesday, 9 August 2016 08:23:41 CEST Brian Paul wrote: > >> As it fixes something independent, should I push that already? > > > > Sure. For 1 & 3, > > Reviewed-by: Brian Paul > > Tested-by: Brian Paul Pushed. > Yes, we need to add one to the index. I'll re-test that patch when y

[Mesa-dev] [PATCH] util: Use win32 intrinsics for util_last_bit if present.

2016-08-09 Thread Mathias . Froehlich
From: Mathias Fröhlich v2: Split into two patches. v3: Fix off by one problem. Signed-off-by: Mathias Fröhlich --- src/util/bitscan.h | 12 1 file changed, 12 insertions(+) diff --git a/src/util/bitscan.h b/src/util/bitscan.h index 0743fe7..8afef81 100644 --- a/src/util/bitscan.h

[Mesa-dev] [Bug 97231] GL_DEPTH_CLAMP doesn't clamp to the far plane

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97231 Jules Blok changed: What|Removed |Added Attachment #125589|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-09 Thread Christian König
Am 09.08.2016 um 19:21 schrieb Nayan Deshmukh: Hi Christian, A few questions. On Tue, Aug 9, 2016 at 5:10 PM, Christian König mailto:deathsim...@vodafone.de>> wrote: I am more than happy to solve these problems, the Lanczos filtering was getting a little stale anyway because I

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 7:24 PM, Nicolai Hähnle wrote: > > On 09.08.2016 18:22, Erik Faye-Lund wrote: >> >> On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: >>> >>> On 09.08.2016 15:58, Rob Clark wrote: tbh, git submodules are more annoying than they need to be, and I'm no

Re: [Mesa-dev] [PATCH 3/3] anv/gen7_pipeline: Set multisample state using shared function

2016-08-09 Thread Jason Ekstrand
On Tue, Aug 9, 2016 at 11:04 AM, Anuj Phogat wrote: > On Mon, Aug 8, 2016 at 5:09 PM, Jason Ekstrand > wrote: > > Does this fix any tests? If so, we should say so in the commit message. > > With that updated, > > > No it doesn't. It surprised me too but it looks like cts don't have enough > mul

Re: [Mesa-dev] [PATCH 2/2] anv/clear: Clear E5B9G9R9 images as R32_UINT

2016-08-09 Thread Nanley Chery
On Wed, Aug 03, 2016 at 01:06:10PM -0700, Jason Ekstrand wrote: > We can't actually clear these images normally because we can't render to > them. Instead, we have to manually unpack the rgb9e5 color value on the > CPU and clear it as R32_UINT. We still have a bit of work to do to clear > non-pow

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 Nicolas Boichat changed: What|Removed |Added Attachment #125643|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 3/3] anv/gen7_pipeline: Set multisample state using shared function

2016-08-09 Thread Anuj Phogat
On Mon, Aug 8, 2016 at 5:09 PM, Jason Ekstrand wrote: > Does this fix any tests? If so, we should say so in the commit message. > With that updated, > No it doesn't. It surprised me too but it looks like cts don't have enough multisampling tests. > Reviewed-by: Jason Ekstrand > > On Mon, Aug 8,

[Mesa-dev] [PATCH] freedreno/a2xx: add missing casts to silence notices

2016-08-09 Thread Francesco Ansanelli
Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c b/src/gallium/drivers/freedreno/a2xx/ir-a2xx.c index 2b62b3a..163c282 100644 --- a/src/galli

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #8 from Alexandr Zelinsky --- Created attachment 125644 --> https://bugs.freedesktop.org/attachment.cgi?id=125644&action=edit EGL_LOG_LEVEL=debug with patches -- You are receiving this mail because: You are the QA Contact for the

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 18:22, Erik Faye-Lund wrote: On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: On 09.08.2016 15:58, Rob Clark wrote: tbh, git submodules are more annoying than they need to be, and I'm not really terribly excited to use that for something that is a build dependency. Maybe

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-09 Thread Nayan Deshmukh
Hi Christian, A few questions. On Tue, Aug 9, 2016 at 5:10 PM, Christian König wrote: > I am more than happy to solve these problems, the Lanczos filtering was > getting a little stale > anyway because I was not able to reproduce the problems Andy was facing. > > Yeah thought so, the reason i

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 19:18, Marek Olšák wrote: On Tue, Aug 9, 2016 at 5:35 PM, Nicolai Hähnle wrote: On 09.08.2016 17:21, Marek Olšák wrote: On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's deve

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Marek Olšák
On Tue, Aug 9, 2016 at 5:35 PM, Nicolai Hähnle wrote: > On 09.08.2016 17:21, Marek Olšák wrote: >> >> On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: >>> >>> Hi everybody, >>> >>> addrlib is the addressing and alignment calculator which is used by >>> radeonsi. It's developed (and also used

[Mesa-dev] [PATCH 2/4] prog_hash_table: Convert compare funcs to match util/hash_table.h.

2016-08-09 Thread Eric Anholt
I'm going to replace this hash table with util/hash_table.h, and the first step is to compare things the same way. --- src/mesa/program/hash_table.h | 9 - src/mesa/program/prog_hash_table.c | 9 +++-- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/mesa/progra

[Mesa-dev] [PATCH 1/4] nir: Drop an unused program/hash_table.h include.

2016-08-09 Thread Eric Anholt
--- src/compiler/nir/nir_lower_samplers.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler/nir/nir_lower_samplers.c b/src/compiler/nir/nir_lower_samplers.c index 4a4326983a65..e878edd9b54b 100644 --- a/src/compiler/nir/nir_lower_samplers.c +++ b/src/compiler/nir/nir_lower_samplers.

[Mesa-dev] [PATCH 3/4] prog_hash_table: Convert to using util/hash_table.h.

2016-08-09 Thread Eric Anholt
Improves glretrace -b servo.trace (a trace of Mozilla's servo rendering engine booting, rendering a page, and exiting) from 1.8s to 1.1s. It uses a large uniform array of structs, making a huge number of separate program resources, and the fixed-size hash table was killing it. Given how many time

[Mesa-dev] [PATCH 4/4] mesa: Use a temporary set to track whether we've added a resource yet.

2016-08-09 Thread Eric Anholt
Saves another .1s on servo.trace. --- src/compiler/glsl/linker.cpp | 76 +--- 1 file changed, 50 insertions(+), 26 deletions(-) diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp index f4049133ee69..ceb86aa0a929 100644 --- a/src/compil

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #7 from Nicolas Boichat --- Created attachment 125643 --> https://bugs.freedesktop.org/attachment.cgi?id=125643&action=edit Add tracing to egl_dri2.c libEGL debug: EGL user error 0x3001 (EGL_NOT_INITIALIZED) in eglMakeCurrent Is d

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Erik Faye-Lund
On Tue, Aug 9, 2016 at 4:59 PM, Nicolai Hähnle wrote: > On 09.08.2016 15:58, Rob Clark wrote: >> >> tbh, git submodules are more annoying than they need to be, and I'm >> not really terribly excited to use that for something that is a build >> dependency. Maybe just move it into libdrm instead? >

Re: [Mesa-dev] cairo as state tracker

2016-08-09 Thread Jason Ekstrand
On Tue, Aug 9, 2016 at 8:11 AM, Enrico Weigelt, metux IT consult < enrico.weig...@gr13.net> wrote: > On 07.08.2016 12:50, Marek Olšák wrote: > > > It would mainly be a futile task if it had to compete with their > > official Mesa driver. > > Not quite. Would give us all of gallium's capabilities a

Re: [Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Christian König
Am 09.08.2016 um 17:18 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu Reviewed-by: Christian König --- src/gallium/auxiliary/vl/vl_rbsp.h | 14 -- 1 file changed,

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Marek Olšák
On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: > Hi everybody, > > addrlib is the addressing and alignment calculator which is used by > radeonsi. It's developed (and also used) internally at AMD, and so far we've > had one open source copy living in the Mesa repository at > src/gallium/win

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Christian König
Am 09.08.2016 um 15:47 schrieb Nicolai Hähnle: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa repository at src/gallium/winsys/amdgpu/drm

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 17:21, Marek Olšák wrote: On Tue, Aug 9, 2016 at 3:47 PM, Nicolai Hähnle wrote: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Me

Re: [Mesa-dev] cairo as state tracker

2016-08-09 Thread Rob Clark
On Tue, Aug 9, 2016 at 11:11 AM, Enrico Weigelt, metux IT consult wrote: > On 07.08.2016 12:50, Marek Olšák wrote: > >> It would mainly be a futile task if it had to compete with their >> official Mesa driver. > > Not quite. Would give us all of gallium's capabilities also for > the intel chips, f

[Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Leo Liu
This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/vl/vl_rb

Re: [Mesa-dev] cairo as state tracker

2016-08-09 Thread Enrico Weigelt, metux IT consult
On 07.08.2016 12:50, Marek Olšák wrote: > It would mainly be a futile task if it had to compete with their > official Mesa driver. Not quite. Would give us all of gallium's capabilities also for the intel chips, for example having lots of different state trackers. (coming back to my original inte

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Enrico Weigelt, metux IT consult
On 09.08.2016 16:59, Nicolai Hähnle wrote: > So shared linking is right out. Not exactly. Just everything needs to be linked against the matching versions. More a dist-layer problem. addrlibs folks should learn to introduce a proper versioning and provide MVCC-capable build rules. That really is

Re: [Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Christian König
Am 09.08.2016 um 15:56 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/g

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Enrico Weigelt, metux IT consult
On 09.08.2016 15:47, Nicolai Hähnle wrote: > I think the best way forward is to create a dedicated repository for > addrlib which is then integrated into Mesa as a git submodule. If you really wanna make a lot of people, especially dist-maintainers very unhappy ... > From initial experiments, th

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
On 09.08.2016 15:58, Rob Clark wrote: On Tue, Aug 9, 2016 at 9:47 AM, Nicolai Hähnle wrote: Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa

Re: [Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

2016-08-09 Thread Brian Paul
On 08/09/2016 07:46 AM, Brian Paul wrote: On 08/09/2016 12:30 AM, Mathias Fröhlich wrote: Hi Brian, > I don't know why my local build is failing while appveyor and our > in-house automated build seem OK. But applying your patch 3 alone fixes > things for me. As it fixes something independ

Re: [Mesa-dev] [PATCH 2/3] gallivm: add lp_build_alloca_undef

2016-08-09 Thread Roland Scheidegger
Am 09.08.2016 um 12:38 schrieb Nicolai Hähnle: > From: Nicolai Hähnle > > --- > src/gallium/auxiliary/gallivm/lp_bld_flow.c | 19 +++ > src/gallium/auxiliary/gallivm/lp_bld_flow.h | 5 + > 2 files changed, 24 insertions(+) > > diff --git a/src/gallium/auxiliary/gallivm/lp_b

[Mesa-dev] [Bug 97261] vaapi u/v wrong order since vl/util: add copy func for yv12image to nv12surface

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97261 Andy Furniss changed: What|Removed |Added CC||deathsim...@vodafone.de -- You are recei

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #6 from Alexandr Zelinsky --- Created attachment 125640 --> https://bugs.freedesktop.org/attachment.cgi?id=125640&action=edit EGL_LOG_LEVEL=debug -- You are receiving this mail because: You are the QA Contact for the bug. You are

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #5 from Michel Dänzer --- Try EGL_LOG_LEVEL=debug as well. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing

[Mesa-dev] [PATCH v2] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Leo Liu
This is the case when the "00 00 03" is very close to the beginning of nal unit header v2: move the check to rbsp init Signed-off-by: Leo Liu --- src/gallium/auxiliary/vl/vl_rbsp.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/auxiliary/vl/vl_rbsp.h b/src/gallium

Re: [Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Rob Clark
On Tue, Aug 9, 2016 at 9:47 AM, Nicolai Hähnle wrote: > Hi everybody, > > addrlib is the addressing and alignment calculator which is used by > radeonsi. It's developed (and also used) internally at AMD, and so far we've > had one open source copy living in the Mesa repository at > src/gallium/win

[Mesa-dev] [Bug 97261] vaapi u/v wrong order since vl/util: add copy func for yv12image to nv12surface

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97261 Bug ID: 97261 Summary: vaapi u/v wrong order since vl/util: add copy func for yv12image to nv12surface Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [Bug 97214] X not running with error "Failed to make EGL context current"

2016-08-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97214 --- Comment #4 from Alexandr Zelinsky --- Created attachment 125637 --> https://bugs.freedesktop.org/attachment.cgi?id=125637&action=edit xinit log with LIBGL_DEBUG=verbose seems not very usefull what your nickname on #dri-devel? -- You are

[Mesa-dev] Moving amdgpu/addrlib into a git submodule

2016-08-09 Thread Nicolai Hähnle
Hi everybody, addrlib is the addressing and alignment calculator which is used by radeonsi. It's developed (and also used) internally at AMD, and so far we've had one open source copy living in the Mesa repository at src/gallium/winsys/amdgpu/drm/addrlib. The question of using addrlib in non

Re: [Mesa-dev] [PATCH 3/3] gallium: Add c99_compat.h to u_bitcast.h

2016-08-09 Thread Brian Paul
On 08/09/2016 12:30 AM, Mathias Fröhlich wrote: Hi Brian, > I don't know why my local build is failing while appveyor and our > in-house automated build seem OK. But applying your patch 3 alone fixes > things for me. As it fixes something independent, should I push that already? Sure. F

Re: [Mesa-dev] [PATCH] vl/rbsp: add a check for emulation prevention three byte

2016-08-09 Thread Leo Liu
On 08/09/2016 04:26 AM, Christian König wrote: Am 08.08.2016 um 22:10 schrieb Leo Liu: This is the case when the "00 00 03" is very close to the beginning of nal unit header I see where the problem is, but the fix is incorrect. You always search for the emulation prevention three byte even

[Mesa-dev] [PATCH] Fix Android compilation when swrast is enabled

2016-08-09 Thread Mathieu Maret
Swrast add dependency on libdrm, but libdrm is not defined for host build (only for the targeted device). So host modules likes mesa_gen_matypes cannot find there libdrm dependency Signed-off-by: Mathieu Maret --- Android.common.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Android.co

Re: [Mesa-dev] [PATCH 1/2] vl: add a lanczos interpolation filter v3

2016-08-09 Thread Christian König
I am more than happy to solve these problems, the Lanczos filtering was getting a little stale anyway because I was not able to reproduce the problems Andy was facing. Yeah thought so, the reason is probably that you don't have the necessary hardware. Is that why I need to add a PIPE_BIND_LIN

Re: [Mesa-dev] [PATCH 0/8] More state optimizations for st/mesa

2016-08-09 Thread Nicolai Hähnle
I sent comments on patches 4 & 6. Apart from that, the series is Reviewed-by: Nicolai Hähnle On 07.08.2016 03:12, Marek Olšák wrote: PS: In order to make reviewing easier, all my patches have 10 lines of contexts instead of 3. That will be the default for all my work from now on. I like that

Re: [Mesa-dev] [PATCH 4/8] st/mesa: determine states used or affected by shaders at compile time

2016-08-09 Thread Nicolai Hähnle
On 07.08.2016 03:12, Marek Olšák wrote: From: Marek Olšák At compile time, each shader determines which ST_NEW flags should be set at shader bind time. This just sets the new field for all shaders. The next commit will use it. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 175 +

Re: [Mesa-dev] [PATCH 6/8] st/mesa: _NEW_TEXTURE & CONSTANTS shouldn't flag states that aren't used

2016-08-09 Thread Nicolai Hähnle
On 07.08.2016 03:12, Marek Olšák wrote: From: Marek Olšák --- src/mesa/state_tracker/st_context.c | 64 - src/mesa/state_tracker/st_context.h | 6 2 files changed, 62 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/

[Mesa-dev] [PATCH 1/3] gallivm: add create_builder_at_entry helper function

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Reduces code duplication. --- src/gallium/auxiliary/gallivm/lp_bld_flow.c | 45 ++--- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_flow.c b/src/gallium/auxiliary/gallivm/lp_bld_flow.c index f3b3

[Mesa-dev] [PATCH 3/3] gallium/radeon: use lp_build_alloca_undef

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Avoid building all those store 0 / store undef instrucction pairs that end up getting removed anyway. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeon/radeo

[Mesa-dev] [PATCH 2/3] gallivm: add lp_build_alloca_undef

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/auxiliary/gallivm/lp_bld_flow.c | 19 +++ src/gallium/auxiliary/gallivm/lp_bld_flow.h | 5 + 2 files changed, 24 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_flow.c b/src/gallium/auxiliary/gallivm/lp_bld_flow.c index

[Mesa-dev] [PATCH 16/19] gallium/radeon: always do the full store in store_value_to_array

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Doing the write-back of the temporary vector in radeon_llvm_emit_store makes no sense. This also allows us to get rid of get_alloca_for_array. --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 77 -- 1 file changed, 28 insertions(+), 49 deletions(

[Mesa-dev] [PATCH 19/19] gallium/radeon: protect against out of bounds temporary array accesses

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle They can lead to VM faults and worse, which goes against the GL robustness promises. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/galliu

[Mesa-dev] [PATCH 14/19] gallium/radeon: pass indirect register info into get_alloca_for_array

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle To have the same signature as get_array_range. --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_set

[Mesa-dev] [PATCH 08/19] gallium/radeon: clean up emit_declaration for temporaries

2016-08-09 Thread Nicolai Hähnle
From: Nicolai Hähnle In the alloca'd array case, no longer create redundant and unused allocas for the individual elements; create getelementptrs instead. --- .../drivers/radeon/radeon_setup_tgsi_llvm.c| 27 ++ 1 file changed, 18 insertions(+), 9 deletions(-) diff --

  1   2   >