在 2018/6/27 13:52, Martin Storsjö 写道:
> On Wed, 27 Jun 2018, Martin Storsjö wrote:
> And just to make it clear - this is code that builds fine with clang+lld
> as things stand right now (without -fms-extensions anywhere).
>
> What was the exact issue you're trying to fix by tweaking the
> __forc
This adds def files for all the api-ms-win-crt-* dll files. I've tried to
add all the manual modifications from ucrtbase.def.in into these files, so
that linking to libucrt.a should work pretty much the same as linking to
libucrtbase.a, but ending up linking to the api sets dlls.
---
mingw-w64-crt
On Wed, 27 Jun 2018, Martin Storsjö wrote:
On Tue, 26 Jun 2018, Jacek Caban wrote:
On 06/26/2018 01:44 PM, Martin Storsjö wrote:
On Tue, 26 Jun 2018, Jacek Caban wrote:
I still need to run some test, but I it seems ready for review.
The important change is __forceinline. We add extern to G
On Tue, 26 Jun 2018, Jacek Caban wrote:
On 06/26/2018 01:44 PM, Martin Storsjö wrote:
On Tue, 26 Jun 2018, Jacek Caban wrote:
I still need to run some test, but I it seems ready for review.
The important change is __forceinline. We add extern to GCC macro,
because that matches closer intende
On Tue, 26 Jun 2018, Mateusz Mikuła wrote:
I think it's upstream clang bug reported here:
https://github.com/Alexpux/MINGW-packages/issues/1677#issuecomment-394906508
No, that one is unrelated to this matter.
// Martin
--
I think it's upstream clang bug reported here:
https://github.com/Alexpux/MINGW-packages/issues/1677#issuecomment-394906508
wt., 26 cze 2018 o 13:57 Liu Hao napisał(a):
> 在 2018/6/26 19:33, Jacek Caban 写道:
> > I did tests with c89 and c99 before submitting the patch (C++ is
> > irrelevant, I don
在 2018/6/26 20:03, Jacek Caban 写道:
> This fails, good catch. I wonder why my (similar) test did not fail. It
> needs deeper look, I will investigate.
>
>
> Thanks,
>
> Jacek
>
I suggest you leave `__forceinline` alone. I agree with that if the
compiler supports MS extensions it is better pra
On 06/26/2018 01:56 PM, Liu Hao wrote:
> 在 2018/6/26 19:33, Jacek Caban 写道:
>> I did tests with c89 and c99 before submitting the patch (C++ is
>> irrelevant, I don't change behaviour there). I'm also able to build
>> Firefox with this patch (which in the past revealed a few inline
>> problems, so
在 2018/6/26 19:33, Jacek Caban 写道:
> I did tests with c89 and c99 before submitting the patch (C++ is
> irrelevant, I don't change behaviour there). I'm also able to build
> Firefox with this patch (which in the past revealed a few inline
> problems, so that's a nice test). Is there anything in par
On 06/26/2018 01:44 PM, Martin Storsjö wrote:
> On Tue, 26 Jun 2018, Jacek Caban wrote:
>
>> I still need to run some test, but I it seems ready for review.
>>
>> The important change is __forceinline. We add extern to GCC macro,
>> because that matches closer intended behaviour. clang supports
>>
On Tue, 26 Jun 2018, Jacek Caban wrote:
I still need to run some test, but I it seems ready for review.
The important change is __forceinline. We add extern to GCC macro,
because that matches closer intended behaviour. clang supports
__forceinline itself if -fms-extensions is used, so we should
On 06/26/2018 01:14 PM, Liu Hao wrote:
> 在 2018年06月26日 18:35, Jacek Caban 写道:
>> I still need to run some test, but I it seems ready for review.
>>
>> The important change is __forceinline. We add extern to GCC macro,
>> because that matches closer intended behaviour. clang supports
>> __forceinlin
在 2018年06月26日 18:35, Jacek Caban 写道:
> I still need to run some test, but I it seems ready for review.
>
> The important change is __forceinline. We add extern to GCC macro,
> because that matches closer intended behaviour. clang supports
> __forceinline itself if -fms-extensions is used, so we sh
I still need to run some test, but I it seems ready for review.
The important change is __forceinline. We add extern to GCC macro,
because that matches closer intended behaviour. clang supports
__forceinline itself if -fms-extensions is used, so we should just leave
it to the compiler in that case
14 matches
Mail list logo
