Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server

2013-11-04 Thread Max Kellermann
On 2013/11/02 16:11, j...@dockes.org wrote: Hi, I have uploaded the code for a UPnP Database plugin to git://git.musicpd.org/medoc/mpd.git One more thing, I had a very quick look at the first commit that adds code: you added a copy of libexpat. Why that? Why not link this library, like

Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server

2013-11-04 Thread jf
Max Kellermann writes: On 2013/11/02 16:11, j...@dockes.org wrote: Hi, I have uploaded the code for a UPnP Database plugin to git://git.musicpd.org/medoc/mpd.git Your first commit UpNP database plugin: build and configuration refers to files which don't exist (yet). All

Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server

2013-11-04 Thread jf
Max Kellermann writes: On 2013/11/02 16:11, j...@dockes.org wrote: Hi, I have uploaded the code for a UPnP Database plugin to git://git.musicpd.org/medoc/mpd.git One more thing, I had a very quick look at the first commit that adds code: you added a copy of libexpat. Why

Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server

2013-11-04 Thread Max Kellermann
On 2013/11/04 19:02, j...@dockes.org wrote: I wanted to separate the commit that modified existing mpd files from the commits that added new code. I don't follow this argument. Adding a new source code file and registering it in Makefile.am belongs together, that's an operation that cannot be

Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server

2013-11-04 Thread jf
Max Kellermann writes: On 2013/11/04 19:02, j...@dockes.org wrote: I wanted to separate the commit that modified existing mpd files from the commits that added new code. I don't follow this argument. Adding a new source code file and registering it in Makefile.am belongs together,

Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server

2013-11-04 Thread Max Kellermann
On 2013/11/04 19:33, j...@dockes.org wrote: - If nobody is interested in actually trying out the function (as seems to be the case), the merge won't be a concern :) I can't - I have no UPnP hardware. Therefore, I have exactly zero personal interest in the feature ;-)

Re: [Musicpd-dev-team] Using MPD to play music from an UPnP Media Server

2013-11-04 Thread jf
Max Kellermann writes: On 2013/11/04 19:33, j...@dockes.org wrote: - If nobody is interested in actually trying out the function (as seems to be the case), the merge won't be a concern :) I can't - I have no UPnP hardware. Me neither. Therefore, I have exactly zero personal