Re: JDK-8177945 : Single cell selection flickers when adding data to TableView

Thanks for taking a look at this David. Danny > On 3 Mar 2020, at 16:50, David Grieve wrote: > > The importance of 05afad6 Is there in the commit itself: > > +// > +// One idiom employed by developers is to, during the layout pass, > +// add or remove nodes from the

Re: [Rev 01] RFR: 8237926: Potential memory leak of model data in javafx.scene.control.ListView

On Tue, 3 Mar 2020 13:06:52 GMT, Ambarish Rapte wrote: >> The selection model of ListView stores a strong reference to the most >> recently changed item in >> `SelectedItemsReadOnlyObservableList.itemsListChange`, which causes a leak. >> >> Fix: >> The below member variables and method of

RFR: 8240466: AppJSCallback* apps launched by ModuleLauncherTest intermittently hang

While testing JavaFX using gradle 6.3-nightly and JDK 14, I ran into what turned out to be a latent test bug in the AppJSCallback* apps that are launched by ModuleLauncherTest. The launched apps construct a WebView instance, obtain a WebEngine instance from the WebView, add a state listener to

RE: JDK-8177945 : Single cell selection flickers when adding data to TableView

The importance of 05afad6 Is there in the commit itself: +// +// One idiom employed by developers is to, during the layout pass, +// add or remove nodes from the scene. For example, a ScrollPane +// might add scroll bars to itself if it determines during layout +

RFR: 8240451: JavaFX javadoc build fails with JDK 14

The JDK 14 javadoc will emit a warning for an `@pram` tag of a generic parameter if not surrounded by `<` and `>`. This will in turn fail the build, since we treat warnings as errors. There are 5 classes in JavaFX with this error. The fix is to replace `@param T` with `@param ` in those 5

JDK-8177945 : Single cell selection flickers when adding data to TableView

There is currently an open bug to do with the issue of selection flickering when using single cell selection and when adding data to a TableView. https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8177945 This bug seems to be low priority because it hasn’t been looked at since I submitted it

Re: [Integrated] RFR: 8208761: Update constant collections to use the new immutable collections

Changeset: 960f0390 Author:Nir Lisker Date: 2020-03-03 14:04:34 + URL: https://git.openjdk.java.net/jfx/commit/960f0390 8208761: Update constant collections to use the new immutable collections Reviewed-by: arapte, kcr !

Re: RFR: 8237926: Potential memory leak of model data in javafx.scene.control.ListView

On Tue, 3 Mar 2020 12:56:28 GMT, Ambarish Rapte wrote: >> Is it possible to create a test for the leak? > > Hi Kevin, I have updated the PR according to both the comments. Please take a > look. Thanks. I'll put it on my review queue. - PR:

Re: RFR: 8237926: Potential memory leak of model data in javafx.scene.control.ListView

On Mon, 2 Mar 2020 16:47:50 GMT, Kevin Rushforth wrote: >> As I mentioned in the bug report for >> [JDK-8240287](https://bugs.openjdk.java.net/browse/JDK-8240287), I recommend >> using [JDK-8227619](https://bugs.openjdk.java.net/browse/JDK-8227619) as the >> bug ID for this fix (and closing

Re: [Rev 01] RFR: 8237926: Potential memory leak of model data in javafx.scene.control.ListView

> The selection model of ListView stores a strong reference to the most > recently changed item in > `SelectedItemsReadOnlyObservableList.itemsListChange`, which causes a leak. > > Fix: > The below member variables and method of class > SelectedItemsReadOnlyObservableList are not required

Re: RFR: 8236651: Simplify and update glass gtk backend

On Thu, 13 Feb 2020 23:56:42 GMT, Kevin Rushforth wrote: >> **Code Changes** >> >> * glass_window.cpp / glass_window.h >> * Removed WindowContextPlug and WindowContextChild (that were used for >> applets / web start) and moved everything to >> one class named WindowContext (since