Re: Automation and other changes

2017-04-02 Thread Donald Stufft
> On Apr 2, 2017, at 1:26 PM, Donald Stufft wrote: > > Sounds like between my starting to lean towards it, your preference, and the > fact it would trigger a new mail notification for Paul’s workflow too, that a > special command is the way to go. I will go ahead and implement that. Ok! I ha

Re: Automation and other changes

2017-04-02 Thread Donald Stufft
> On Apr 2, 2017, at 1:16 PM, Xavier Fernandez wrote: > > First of all, thanks a lot for all the work you've put in pip, especially > lately. > > Like Paul, I rely mostly on mail notifications to follow new/updated > issues/PR. > I usually read everything and if I don't respond immediately, I

Re: Automation and other changes

2017-04-02 Thread Xavier Fernandez
First of all, thanks a lot for all the work you've put in pip, especially lately. Like Paul, I rely mostly on mail notifications to follow new/updated issues/PR. I usually read everything and if I don't respond immediately, I'm used to leaving the mail as unread to - hopefully - come back to it la

Re: Automation and other changes

2017-04-02 Thread Carol Willing
On Sunday, April 2, 2017 at 6:20:52 AM UTC-7, p.f.moore wrote: > > On 2 April 2017 at 14:18, Donald Stufft > > wrote: > > Ok cool. Let me play around with this some and see what I can come up > with. > > We can always adjust it if we decide the workflow isn’t working for us > :D > > By the

Re: Automation and other changes

2017-04-02 Thread Donald Stufft
> On Apr 2, 2017, at 9:20 AM, Paul Moore wrote: > > On 2 April 2017 at 14:18, Donald Stufft wrote: >> Ok cool. Let me play around with this some and see what I can come up with. >> We can always adjust it if we decide the workflow isn’t working for us :D > > By the way, thanks for doing this i

Re: Automation and other changes

2017-04-02 Thread Paul Moore
On 2 April 2017 at 14:18, Donald Stufft wrote: > Ok cool. Let me play around with this some and see what I can come up with. > We can always adjust it if we decide the workflow isn’t working for us :D By the way, thanks for doing this in the first place - regardless of whether what you do directl

Re: Automation and other changes

2017-04-02 Thread Donald Stufft
> On Apr 2, 2017, at 9:16 AM, Paul Moore wrote: > > On 2 April 2017 at 14:03, Donald Stufft wrote: >> I was just about to ask if you thought if a daily or weekly email to >> pypa-dev enumerating the contents of our review queue (where review queue == >> the list of PRs waiting for action from a

Re: Automation and other changes

2017-04-02 Thread Paul Moore
On 2 April 2017 at 14:03, Donald Stufft wrote: > I was just about to ask if you thought if a daily or weekly email to > pypa-dev enumerating the contents of our review queue (where review queue == > the list of PRs waiting for action from a core dev) would be useful in a > purely email based workf

Re: Automation and other changes

2017-04-02 Thread Donald Stufft
> On Apr 2, 2017, at 9:01 AM, Paul Moore wrote: > > On 2 April 2017 at 13:14, Donald Stufft wrote: >> Another case of this that happens to me is I’ll get an email for the PR, see >> it, review it, think it’s a good idea, but the tests are still running (and >> they take 30+ minutes to run) so I

Re: Automation and other changes

2017-04-02 Thread Paul Moore
On 2 April 2017 at 13:14, Donald Stufft wrote: > Another case of this that happens to me is I’ll get an email for the PR, see > it, review it, think it’s a good idea, but the tests are still running (and > they take 30+ minutes to run) so I’ll wait for that and end up forgetting > about the PR as

Re: Automation and other changes

2017-04-02 Thread Paul Moore
On 2 April 2017 at 13:07, Donald Stufft wrote: > Thoughts? Sounds reasonable - I didn't mean to say that I thought what you were doing was wrong, just that the net effect on me was likely to be minimal because I use a purely email-based workflow. And yes, you're right that does mean that if I don

Re: Automation and other changes

2017-04-02 Thread Donald Stufft
> On Apr 2, 2017, at 8:07 AM, Donald Stufft wrote: > > * Emails are a once and done communication mechanism. It is easy for a PR to > languish waiting on one of us to review and merge it because we didn’t do it > right when the initial email came in. Maybe we were busy and just > archived/del

Re: Automation and other changes

2017-04-02 Thread Donald Stufft
> On Apr 2, 2017, at 7:47 AM, Paul Moore wrote: > > On 2 April 2017 at 12:16, Donald Stufft wrote: >> Correct. Although I’ve warmed up to the idea of (2) if I pair it with a >> (once per PR) automated comment that occurs the first time someone marks a >> PR as “Changes Requested” that tells the

Re: Automation and other changes

2017-04-02 Thread Paul Moore
On 2 April 2017 at 12:16, Donald Stufft wrote: > Correct. Although I’ve warmed up to the idea of (2) if I pair it with a > (once per PR) automated comment that occurs the first time someone marks a > PR as “Changes Requested” that tells them the magic words to say to move > their PR back into our

Re: Automation and other changes

2017-04-02 Thread Donald Stufft
> On Apr 2, 2017, at 6:51 AM, Paul Moore wrote: > > On 1 April 2017 at 23:27, Donald Stufft wrote: >> To make it clearer, what I’m asking here is what do we want to do about >> this? Do we want to just auto clear the requested changes thing whenever the >> PR author pushes changes? I think so,

Re: Automation and other changes

2017-04-02 Thread Paul Moore
On 1 April 2017 at 23:27, Donald Stufft wrote: > To make it clearer, what I’m asking here is what do we want to do about > this? Do we want to just auto clear the requested changes thing whenever the > PR author pushes changes? I think so, for what that looks like I have a demo > at https://github