Ditto :)
Samuel
Samuel Thibault, le sam. 27 oct. 2018 13:11:41 +0200, a ecrit:
> struct socket *
> tcp_listen(Slirp *slirp, uint32_t haddr, u_int hport, uint32_t laddr,
>u_int lport, int flags)
> {
> struct sockaddr_in addr;
> struct socket *so;
> socklen_t a
Hello,
Thanks for working on this!
There is a lot of overlap with tcp_listen. It'd be much better to
refactor it this way:
struct socket *
tcpx_listen(Slirp *slirp, struct sockaddr *addr, socklen_t *addrlen, int flags)
{
... The current content of tcp_listen, with all heading and
Hello,
Fam Zheng, le ven. 14 sept. 2018 15:26:16 +0800, a ecrit:
> This new usernet option can be used to add data for option 66 (tftp
> server name) in the BOOTP reply, which is useful in PXE based automatic
> OS install such as OpenBSD.
Applied to my tree, thanks!
Samuel
Hello,
Fam Zheng, le ven. 14 sept. 2018 15:26:15 +0800, a ecrit:
> When user provides a long domainname or hostname that doesn't fit in the
> DHCP packet, we mustn't overflow the response packet buffer. Instead,
> report errors, following the g_warning() in the slirp->vdnssearch
> branch.
>
> Als
The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2018-10-19 19:01:07 +0100)
are available in the Git repository at:
https://people.debian.org/~sthibault/qemu.git tags/samue
Gerd Hoffmann
Signed-off-by: Samuel Thibault
---
net/slirp.c | 9 +
slirp/bootp.c | 32 ++--
2 files changed, 31 insertions(+), 10 deletions(-)
diff --git a/net/slirp.c b/net/slirp.c
index 99884de204..da6c0a1a5c 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -
From: Fam Zheng
This new usernet option can be used to add data for option 66 (tftp
server name) in the BOOTP reply, which is useful in PXE based automatic
OS install such as OpenBSD.
Signed-off-by: Fam Zheng
Reviewed-by: Thomas Huth
Tested-by: Gerd Hoffmann
Signed-off-by: Samuel Thibault
~sthibault/qemu.git tags/samuel-thibault
for you to fetch changes up to 93a972f8548571d35c718ca3a94d5ab1507b2443:
slirp: Propagate host TCP RST packet to the guest after socket disconnected
(2018-10-07 19:50:48 +0200)
slirp updates
An
guest. SOCK_DGRAM ICMP sockets aren't
supported on other BSDs, but we enable this behavior for them as well to
treat the sockets the same as raw sockets.
Signed-off-by: Andrew Oates
Signed-off-by: Samuel Thibault
---
slirp/ip_icmp.c | 27 ++-
1 file change
occurred. The socket will then be stuck in FIN_WAIT_2,
until the peer sends FIN/ACK or a timeout occurs. Instead we can send a RST
to the peer and transition to the CLOSED state.
Signed-off-by: Gavin Grant
Signed-off-by: Samuel Thibault
---
slirp/socket.c | 13 ++---
1 file changed, 10
From: Peter Maydell
and fix confusing datasize name into gapsize in m_inc.
Signed-off-by: Peter Maydell
Signed-off-by: Samuel Thibault
---
slirp/mbuf.c | 14 +++---
slirp/mbuf.h | 13 +
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/slirp/mbuf.c b/slirp
Hello,
Gavin Grant, le jeu. 30 août 2018 16:57:57 +0100, a ecrit:
> Commit 27d92ebc5ed1bb0b518d0ebc4c609182ad20a799 handled the case where the TCP
> connection is abruptly closed via a RST packet, by checking for the ECONNRESET
> errno. However it does not consider the case where the connection ha
sing virtual clock to the new virtual_ext clock.
>
> Signed-off-by: Pavel Dovgalyuk
As discussed previously
Reviewed-by: Samuel Thibault
> ---
> slirp/ip6_icmp.c |7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/slirp/ip6_icmp.c b/slirp/ip
Hello,
The principle seems sane, I'll have a look.
Thanks,
Samuel
Gavin Grant, le jeu. 30 août 2018 16:57:57 +0100, a ecrit:
> Commit 27d92ebc5ed1bb0b518d0ebc4c609182ad20a799 handled the case where the TCP
> connection is abruptly closed via a RST packet, by checking for the ECONNRESET
> errno.
heir scripts to the new syntax. Time to remove the
> old parameters now.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Samuel Thibault
> ---
> include/net/net.h| 3 --
> include/net/slirp.h | 4 --
> net/slirp.c | 132
> +++--
Hello,
Fam Zheng, le ven. 24 août 2018 21:53:12 +0800, a ecrit:
>const char *vnameserver, const char *vnameserver6,
>const char *smb_export, const char *vsmbserver,
>const char **dnssearch, const char *vdomainname,
and...@andrewoates.com, le mer. 15 août 2018 20:18:45 -0400, a ecrit:
> v4: drop packets that are too short for an IP header
Applied to my tree, thanks!
Samuel
Andrew Oates, le mar. 14 août 2018 22:35:21 -0400, a ecrit:
> On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when
> read from. On macOS, however, the socket acts like a SOCK_RAW socket
> and includes the IP header as well.
>
> This change strips the extra IP header from the r
Andrew Oates, le mar. 14 août 2018 22:35:21 -0400, a ecrit:
> On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when
> read from. On macOS, however, the socket acts like a SOCK_RAW socket
> and includes the IP header as well.
>
> This change strips the extra IP header from the r
From: Peter Maydell
and fix confusing datasize name into gapsize in m_inc.
Signed-off-by: Peter Maydell
Signed-off-by: Samuel Thibault
---
slirp/mbuf.c | 14 +++---
slirp/mbuf.h | 13 +
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/slirp/mbuf.c b/slirp
Peter Maydell, le ven. 10 août 2018 10:02:37 +0100, a ecrit:
> (a) you should add a comment describing what 'gapsize'
> is, ie that there may be a gap between the in-use data and the
> start of the allocated buffer, and
> (b) m_inc() should change its variable name to match.
Right, I have done so
t; Ah OK, thanks.
> (That ascii art could do with being in a comment somewhere!)
Indeed. Peter, maybe your Signed-off-by on this? :)
Samuel
commit 4be85a1eeb6b19e91491e689d4d0d054030cbb49
Author: Peter Maydell
Date: Thu Aug 9 23:52:59 2018 +0200
slirp: document mbuf pointers and sizes
_cat();
> the other three callsites all start with a freshly allocated
> mbuf from m_get(), which will have m->m_size == M_ROOM(m).
>
> Fixes: 864036e251f54c9
> Fixes: https://bugs.launchpad.net/qemu/+bug/1785670
> Signed-off-by: Peter Maydell
Reviewed-by: Samuel Thibault
&
Pavel Dovgalyuk, le mar. 31 juil. 2018 09:58:26 +0300, a ecrit:
> > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org]
> > Pavel Dovgalyuk, le jeu. 26 juil. 2018 11:37:57 +0300, a ecrit:
> > > Or the timers are related to the network devices (e.g., servers in
The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc:
Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100)
are available in the Git repository at:
https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
for you to fetch changes up to
Hello,
aoa...@google.com, le sam. 28 juil. 2018 21:54:26 -0400, a ecrit:
> From: Andrew Oates
>
> On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when
> read from. On macOS, however, the socket acts like a SOCK_RAW socket
> and includes the IP header as well.
>
> This chang
guest.
Signed-off-by: Andrew Oates
Signed-off-by: Samuel Thibault
---
slirp/ip_icmp.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/slirp/ip_icmp.c b/slirp/ip_icmp.c
index 0b667a429a..6316427ed3 100644
--- a/slirp/ip_icmp.c
+++ b/slirp/ip_icmp.c
@@ -420,7
Hello,
aoa...@google.com, le mer. 25 juil. 2018 21:08:12 -0400, a ecrit:
> From: Andrew Oates
>
> On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when
> read from. On macOS, however, the socket acts like a SOCK_RAW socket
> and includes the IP header as well.
>
> This chang
Pavel Dovgalyuk, le jeu. 26 juil. 2018 11:37:57 +0300, a ecrit:
> > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org]
> > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit:
> > > virtual clock should be used by the virtual devices.
> > > slirp mo
Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit:
> virtual clock should be used by the virtual devices.
> slirp module is not the virtual device. Therefore processed packets
> become visible to the guest after passing to the virtual network card.
> Before that it can create any timer
Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:37:03 +0300, a ecrit:
> > From: Samuel Thibault [mailto:samuel.thiba...@gnu.org]
> > Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit:
> > > > As documented:
> > > >
> > > > * @QEMU_CLOCK_REA
Pavel Dovgalyuk, le jeu. 26 juil. 2018 10:08:29 +0300, a ecrit:
> > As documented:
> >
> > * @QEMU_CLOCK_REALTIME: Real time clock
> > *
> > * The real time clock should be used only for stuff which does not
> > * change the virtual machine state, as it runs even if the virtual
> > * machine
Pavel Dovgalyuk, le mer. 25 juil. 2018 15:17:06 +0300, a ecrit:
> ICMP implementation for IPv6 uses timers based on virtual clock.
> This is incorrect because this service is not related to the guest state.
? Why not? The RAs are seen by the guest. As documented:
* @QEMU_CLOCK_REALTIME: Real t
t.
Reported-by: ZDI Disclosures
Signed-off-by: Prasad J Pandit
Signed-off-by: Samuel Thibault
---
slirp/mbuf.c | 11 +--
slirp/mbuf.h | 8 +++-
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/slirp/mbuf.c b/slirp/mbuf.c
index 5ff24559fd..18cbf759a7 100644
--- a/slirp/mbuf.
Move check to where it actually is useful, and reduce scope of 'len'
variable along the way.
Signed-off-by: Samuel Thibault
Reviewed-by: Philippe Mathieu-Daudé
---
slirp/socket.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/slirp/socket.c b/slir
The following changes since commit 9be4af13305f24d2dabf94bb53e6b65c76d08bb2:
Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into
staging (2018-06-01 14:58:53 +0100)
are available in the Git repository at:
https://people.debian.org/~sthibault/qemu.git t
The change missed the 2.12 deadline.
Signed-off-by: Samuel Thibault
Reviewed-by: Eric Blake
---
qapi/net.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/net.json b/qapi/net.json
index 32681a1af7..6b7d93cb59 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -161,7
From: Prasad J Pandit
Coding style changes to the m_inc routine and minor refactoring.
Reported-by: ZDI Disclosures
Signed-off-by: Prasad J Pandit
Signed-off-by: Samuel Thibault
---
slirp/mbuf.c | 34 --
1 file changed, 16 insertions(+), 18 deletions(-)
diff
Signed-off-by: Samuel Thibault
Acked-by: Thomas Huth
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 41cd3736a9..4c73c16fee 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1675,6 +1675,7 @@ S: Maintained
F: slirp/
F: net/slirp.c
F: include
P J P, le mar. 05 juin 2018 23:38:36 +0530, a ecrit:
> From: Prasad J Pandit
>
> Coding style changes to the m_cat routine and minor refactoring.
Fixed a bit and applied to my tree, thanks!
Samuel
Hello,
P J P, le mar. 05 juin 2018 23:38:35 +0530, a ecrit:
> From: Prasad J Pandit
>
> While reassembling incoming fragmented datagrams, 'm_cat' routine
> extends the 'mbuf' buffer, if it has insufficient room. It computes
> a wrong buffer size, which leads to overwriting adjacent heap buffer
>
Ping? I'm not sure who I am supposed to get a review from, or if I have
to have one at all?
Samuel
Samuel Thibault, le jeu. 31 mai 2018 21:48:43 +0200, a ecrit:
> Signed-off-by: Samuel Thibault
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> dif
Hello,
This is indeed not implemented, patches welcome :)
Samuel
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1724590
Title:
Usermode networking hostfwd only listens on IPv4
Status in QEMU:
N
Eric Blake, le ven. 01 juin 2018 09:45:25 -0500, a ecrit:
> On 06/01/2018 08:56 AM, Samuel Thibault wrote:
> > The following changes since commit c181ddaa176856b3cd2dfd12bbcf25fa9c884a97:
> >
> >Merge remote-tracking branch
> > 'remotes/pmaydell/tags/pull-tar
Peter Maydell, le ven. 01 juin 2018 14:50:29 +0100, a ecrit:
> Hi; it looks like you forgot to add your signed-off-by to this
> patch from Benjamin.
Oh? I did have noticed it and rebased, but I guess I forgot to update
the tag.
> Could you add it and respin, please?
I have now fixed the tag and
u.git tags/samuel-thibault
for you to fetch changes up to 47335eeea8f1d14b7c6a1dd585a25a9166721168:
slirp/ncsi: add checksum support (2018-05-31 21:19:24 +0200)
slirp updates
Alexey Kardashevskiy
slirp: Improve debugging message
Move check to where it actually is useful, and reduce scope of 'len'
variable along the way.
Signed-off-by: Samuel Thibault
---
Difference from v1:
- move check instead of initializing len.
slirp/socket.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --g
The change missed the 2.12 deadline.
Signed-off-by: Samuel Thibault
---
qapi/net.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/net.json b/qapi/net.json
index 32681a1af7..6b7d93cb59 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -161,7 +161,7
Signed-off-by: Samuel Thibault
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 41cd3736a9..8822ae9b70 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1675,6 +1675,7 @@ S: Maintained
F: slirp/
F: net/slirp.c
F: include/net/slirp.h
+T: git http
ittle
more the Linux driver.
See section "8.2.2.3 - 2's Complement Checksum Compensation" in the
Network Controller Sideband Interface (NC-SI) Specification for more
details.
Signed-off-by: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Joel Stanley
Signed-off
When DEBUG is enabled, len needs to be updated.
Signed-off-by: Samuel Thibault
---
slirp/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slirp/socket.c b/slirp/socket.c
index e2a71c9b04..3182477ff5 100644
--- a/slirp/socket.c
+++ b/slirp/socket.c
@@ -351,7 +351,7
This follows 3929766fb3e4 ('slirp: disable Nagle in outgoing connections'):
for the same reasons, ingoing connections should have the Nagle algorithm
disabled.
Signed-off-by: Samuel Thibault
Reviewed-by: Philippe Mathieu-Daudé
---
slirp/socket.c | 2 ++
1 file changed, 2 insertion
u.git tags/samuel-thibault
for you to fetch changes up to 528e913612bf22661b169018780d8a6fc678c655:
slirp/ncsi: add checksum support (2018-05-31 20:45:02 +0200)
slirp updates
Alexey Kardashevskiy
slirp: Improve debugging message
Reviewed-by: Kamil Rytarowski
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Samuel Thibault
---
slirp/tcp_subr.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c
index da0d53743f..8d0f94b75f 100644
--- a/slirp/tcp_subr.c
+++ b/slirp/tcp_subr.c
From: Cédric Le Goater
Signed-off-by: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Joel Stanley
Signed-off-by: Samuel Thibault
---
slirp/ncsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/slirp/ncsi.c b/slirp/ncsi.c
index d12ba3e494..02d0e9def3
From: Benjamin Drung
This patch will allow the user to include the domainname option in
replies from the built-in DHCP server.
Signed-off-by: Benjamin Drung
Signed-off-by: Samuel Thibault
---
net/slirp.c | 12 +---
qapi/net.json| 4
qemu-options.hx | 7 +--
slirp
From: Nia Alarie
Signed-off-by: Nia Alarie
Signed-off-by: Samuel Thibault
---
net/slirp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/slirp.c b/net/slirp.c
index 005c2675e6..1e14318b4d 100644
--- a/net/slirp.c
+++ b/net/slirp.c
@@ -492,7 +492,9 @@ void
From: Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy
Signed-off-by: Samuel Thibault
---
slirp/arp_table.c | 4 ++--
slirp/socket.c| 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/slirp/arp_table.c b/slirp/arp_table.c
index bac608f97f..f81963bb88 100644
From: James Clarke
If the receive window presented to the guest closes, slirp should send a
window update once the window reopens sufficiently, rather than forcing
the guest to send a window probe, which can take several seconds.
Signed-off-by: James Clarke
Signed-off-by: Samuel Thibault
: Philippe Mathieu-Daudé
Tested-by: Joel Stanley
Signed-off-by: Samuel Thibault
---
slirp/ncsi.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/slirp/ncsi.c b/slirp/ncsi.c
index 02d0e9def3..7b3fff207a 100644
--- a/slirp/ncsi.c
+++ b/slirp/ncsi.c
@@ -35,6 +35,20
Hello,
Michael S. Tsirkin, le jeu. 03 mai 2018 22:51:01 +0300, a ecrit:
> +#include_next "../slirp/ip6.h"
Mmm, this is the first time #include_next would be used in qemu, and I
don't think this is a standard thing...
Samuel
Hello,
Cédric Le Goater, le mer. 30 mai 2018 08:10:32 +0200, a ecrit:
> Here is a couple of enhancements and fixes for the NC-SI backend used
> on the Aspeed SoC when soldered on OpenPOWER boards.
Applied to my tree, thanks!
(my train is 2h late, so I'll probably have the time to pull-request i
Alexey Kardashevskiy, le lun. 14 mai 2018 17:00:08 +1000, a ecrit:
> On 13/3/18 6:44 pm, Samuel Thibault wrote:
> > Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote:
> >> Signed-off-by: Alexey Kardashevskiy
> >
> > Applied to my tree, thanks!
>
Fam Zheng, le mer. 02 mai 2018 15:29:36 +0800, a ecrit:
> On Tue, 05/01 22:41, Samuel Thibault wrote:
> > I'm sorry I didn't find the time to have a look at it before.
> >
> > In general it looks good, just a few things:
> >
> > Samuel
> >
>
Hello,
I'm sorry I didn't find the time to have a look at it before.
In general it looks good, just a few things:
Samuel
Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ecrit:
> +if (!net_hub_id_for_client(&s->nc, &vlan)) {
That makes me think that IIUC, we shouldn't call them vlan,
Philippe Mathieu-Daudé, le mar. 24 avril 2018 22:25:18 -0300, a ecrit:
> > This is starting to shape up pretty nicely. I was able to add a whole
> > bunch of additional architectures thanks to cross compilers in Debian
> > Sid which are there to support the Debian "ports". These may not be
> > arou
James Clarke, le mar. 17 avril 2018 15:10:58 +0100, a ecrit:
> If the receive window presented to the guest closes, slirp should send a
> window update once the window reopens sufficiently, rather than forcing
> the guest to send a window probe, which can take several seconds.
>
> Signed-off-by: J
Nia Alarie, on ven. 16 mars 2018 14:39:21 +, wrote:
> Signed-off-by: Nia Alarie
Applied to my tree, thanks!
> ---
> net/slirp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/slirp.c b/net/slirp.c
> index 8991816bbf..e938944bd4 100644
> --- a/net/slirp.c
>
Alexey Kardashevskiy, on mar. 13 mars 2018 15:49:44 +1100, wrote:
> Signed-off-by: Alexey Kardashevskiy
Applied to my tree, thanks!
> ---
>
> checkpatch.pl complains on every single changed line as it keeps
> using tabs - do I need to post 's/\t//g'?
>
> ---
> Changes:
> v2:
> * replaced s
Philippe Mathieu-Daudé, on mer. 07 mars 2018 19:57:28 -0300, wrote:
> Reviewed-by: Philippe Mathieu-Daudé
Thanks!
Hello,
Remember to Cc the maintainer, I just can't read qemu-devel fully to
find slirp mails.
Thomas Huth, on mer. 07 mars 2018 07:24:16 +0100, wrote:
> >> diff --git a/slirp/arp_table.c b/slirp/arp_table.c
> >> index 3547043..bac608f 100644
> >> --- a/slirp/arp_table.c
> >> +++ b/slirp/arp_table
Hello,
Thanks for the Cc.
I have applied it to my tree. I don't think there is any reason to
avoid the same change for ingoing connections? Could one of your review
the attached patch doing it?
Samuel
commit 99a9a5028e0e15aa3b17d6f884c1e5f48dccea90
Author: Samuel Thibault
Date: Wed
Hello,
Thomas Huth, on mer. 07 mars 2018 07:30:29 +0100, wrote:
> On 07.03.2018 04:39, Alexey Kardashevskiy wrote:
> > On 08/02/18 15:29, Alexey Kardashevskiy wrote:
> >> On 01/02/18 20:36, Alexey Kardashevskiy wrote:
> >>> If we run QEMU with -netdev user,id=USER0,hostfwd=tcp::-:22, it starts
Benjamin Drung, on mar. 27 févr. 2018 17:06:02 +0100, wrote:
> +int i = 0;
Rather unsigned?
> char *end;
> +unsigned int route_count = 0;
> struct slirp_config_str *config;
> +struct StaticRoute *routes = NULL;
> +const StringList *iter;
>
> if (!ipv4 && (vnetwork
Benjamin Drung, on mar. 27 févr. 2018 17:06:01 +0100, wrote:
> This patch will allow the user to include the domainname option in
> replies from the built-in DHCP server.
>
> Signed-off-by: Benjamin Drung
Reviewed-by: Samuel Thibault
and applied to my tree.
Samuel
> ---
Hello,
Benjamin Drung, on ven. 16 févr. 2018 13:55:03 +0100, wrote:
> Or should the command line option be simpler, but how should it be specified
> then? Maybe
>
> -net
> staticroute=10.0.2.0/24via10.0.2.2,staticroute=192.168.0.0/16via10.0.2.2
I guess
> -net staticroute=10.0.2.0/24:10.0.
We properly computed the capped mask size to be put to the application
buffer, but didn't actually used it. Also, we need to return the capped mask
size instead of 0 on success.
Signed-off-by: Samuel Thibault
---
Difference from v1:
- simplify fix
---
linux-user/syscall.c | 4 +++-
1
Laurent Vivier, on ven. 26 janv. 2018 21:34:38 +0100, wrote:
> Le 26/01/2018 à 19:36, Samuel Thibault a écrit :
> > We properly computed the capped mask size to be put to the application
> > buffer, but didn't actually it. Also, we need to return the capped mask
> > si
Peter Maydell, on ven. 26 janv. 2018 18:23:02 +, wrote:
> On 23 January 2018 at 14:48, Laurent Vivier wrote:
> > From: Samuel Thibault
> >
> > sched_get/setaffinity linux-user syscalls were missing conversions for
> > little/big endian, which is hairy since lon
We properly computed the capped mask size to be put to the application
buffer, but didn't actually it. Also, we need to return the capped mask
size instead of 0 on success.
Signed-off-by: Samuel Thibault
---
linux-user/syscall.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
in the Git repository at:
http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
for you to fetch changes up to 318116a6ff36bee13c725a247a9395e80bcfbd6b:
slirp: add in6_dhcp_multicast() (2018-01-14 18:16:13 +0100)
sli
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Signed-off-by: Samuel Thibault
---
slirp/ip.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/slirp/ip.h b/slirp/ip.h
index 1df6723357..59cf4aa918 100644
--- a/slirp/ip.h
+++ b/slirp
(const void *)(&(a)->s6_addr[0]) == 0) && \
^
Reported-by: John Arbuckle
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Samuel Thibault
---
slirp/ip6_icmp.c | 6 +++---
slirp/ndp_table.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Samuel Thibault
---
slirp/libslirp.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/slirp/libslirp.h b/slirp/libslirp.h
index f90f0f524c..540b3e5903 100644
--- a/slirp/libslirp.h
+++ b/slirp/libslirp.h
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Samuel Thibault
---
slirp/dhcpv6.h | 3 +++
slirp/udp6.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/slirp/dhcpv6.h b/slirp/dhcpv6.h
index 9189cd3f2d..3373f6cb89 100644
--- a/slirp
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Tested-by: Thomas Huth
Signed-off-by: Samuel Thibault
---
slirp/slirp.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/slirp/slirp.h b/slirp/slirp.h
index 898ec9516d..06febfc78b 100644
--- a/slirp/slirp.h
+++ b/slirp
Signed-off-by: Samuel Thibault
---
Difference between v1 and v2: handle failure of put_user_u32 with goto efault;
Difference between v2 and v3: handle failure of sys_getcpu system call
Difference between v3 and v4: use is_error
---
linux-user/syscall.c | 19 +++
1 file changed
Signed-off-by: Samuel Thibault
---
Difference between v1 and v2: handle failure of put_user_u32 with goto efault;
Difference between v2 and v3: handle failure of sys_getcpu system call
---
linux-user/syscall.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/linux-user
Signed-off-by: Samuel Thibault
---
Difference from v1: handle failure of put_user_u32 with goto efault;
---
linux-user/syscall.c | 16
1 file changed, 16 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 11c9116c4a..89d78b7b48 100644
--- a/linux-user
Laurent Vivier, on mer. 10 janv. 2018 16:53:47 +0100, wrote:
> Le 28/12/2017 à 18:39, Laurent Vivier a écrit :
> > Le 28/12/2017 à 16:00, Samuel Thibault a écrit :
> >> Signed-off-by: Samuel Thibault
> >> ---
> >> linux-user/syscall.c | 16
Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:29:04 -0300, wrote:
> Access struct in6_addr with 'void *', then cast to 'u8 *' to avoid alignment
> issues.
Err, I don't understand the point. in6_addr's s6_addr is already a
uint8_t by the standard. There is no non-byte access in the existing
cod
Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:29:01 -0300, wrote:
> Signed-off-by: Philippe Mathieu-Daudé
Applied to my tree.
Thanks,
Samuel
> ---
> slirp/dhcpv6.h | 3 +++
> slirp/udp6.c | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/slirp/dhcpv6.h b/slirp/dh
Thomas Huth, on lun. 08 janv. 2018 20:02:14 +0100, wrote:
> On 08.01.2018 18:29, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé
> > ---
> > slirp/ip.h | 13 -
> > 1 file changed, 13 deletions(-)
> >
> > diff --git a/slirp/ip.h b/slirp/ip.h
> > index e29ccd3c9
Thomas Huth, on lun. 08 janv. 2018 20:01:10 +0100, wrote:
> The subject is missing a word or two.
Applied to my tree with a more complete subject :)
Samuel
Thomas Huth, on lun. 08 janv. 2018 19:54:27 +0100, wrote:
> On 08.01.2018 18:28, Philippe Mathieu-Daudé wrote:
> > Signed-off-by: Philippe Mathieu-Daudé
> > ---
> > slirp/slirp.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/slirp/slirp.h b/slirp/slirp.h
> > index 9a7287e7cc..447
Richard Henderson, on mar. 09 janv. 2018 08:33:22 -0800, wrote:
> On 01/08/2018 09:28 AM, Philippe Mathieu-Daudé wrote:
> > Host: Mac OS 10.12.5
> > Compiler: Apple LLVM version 8.1.0 (clang-802.0.42)
> >
> > slirp/ip6_icmp.c:79:32: warning: taking address of packed member 'ip_src'
> > of class
Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:28:55 -0300, wrote:
> Host: Mac OS 10.12.5
> Compiler: Apple LLVM version 8.1.0 (clang-802.0.42)
>
> slirp/ip6_icmp.c:80:38: warning: taking address of packed member 'ip_src'
> of class or
> structure 'ip6' may result in an unaligned poin
Hello,
Philippe Mathieu-Daudé, on lun. 08 janv. 2018 14:28:53 -0300, wrote:
> struct mbuf_ptr {
> struct mbuf *mptr;
> uint32_t dummy;
> -} QEMU_PACKED;
> +};
> #else
> struct mbuf_ptr {
> struct mbuf *mptr;
> -} QEMU_PACKED;
> +};
> @@ -199,7 +199,7 @@ struct ipovly {
>
sched_get/setaffinity linux-user syscalls were missing conversions for
little/big endian, which is hairy since longs may not be the same size
either.
For simplicity, this just introduces loops to convert bit by bit like is
done for select.
Signed-off-by: Samuel Thibault
Reviewed-by: Laurent
701 - 800 of 1571 matches
Mail list logo
