On Wed, Jul 20, 2016 at 11:06:49AM -0700, Martin Winter wrote:
> On 19 Jul 2016, at 9:01, David Lamparter wrote:
> > I'll add a redirect from HTTP to HTTPS after checking if that breaks
> > Martin's CI scripts again ;)
>
> Done on my side.
HTTP now redirects to
on of a single series of patches not detected as it
> wasn’t sent by git-send-mail)
>
> - Martin
>
> On 13 Jul 2016, at 16:41, Martin Winter wrote:
>
> > On 13 Jul 2016, at 14:25, David Lamparter wrote:
> >> Hi all,
> >>
> >> I've just installe
DNS changed (Thanks Paul!), Certificate rolled out, TLS now available:
https://patchwork.quagga.net/
I'll add a redirect from HTTP to HTTPS after checking if that breaks
Martin's CI scripts again ;)
Enjoy!
-David
On Tue, Jul 19, 2016 at 02:34:46PM +0200, David Lamparter wrote:
> O
On Tue, Jul 19, 2016 at 11:49:06AM +0100, Paul Jakma wrote:
> On Tue, 19 Jul 2016, David Lamparter wrote:
> > Thanks; the problem there is a different one though - my hosting setup
> > has a separate reverse proxy doing all TLS handling; i.e. the
> > patchwork setup
On Tue, Jul 19, 2016 at 11:19:48AM +0100, Paul Jakma wrote:
> On Wed, 13 Jul 2016, David Lamparter wrote:
>
> > I've just installed the most recent version of patchwork; the upgrade
> > was a bit bumpy - please report any malfunctions. It looks quite a
> > bit diff
Hi all,
I've just installed the most recent version of patchwork; the upgrade
was a bit bumpy - please report any malfunctions. It looks quite a bit
different since upstream moved to bootstrap for styling, but
functionally there isn't much different.
There is now also a https URL available at:
On Tue, Jul 05, 2016 at 06:11:19AM -0400, Lou Berger wrote:
> On July 5, 2016 3:10:34 AM Vincent JARDIN wrote:
> > Le 5 juil. 2016 05:50, "Lou Berger" a écrit :
> >>
> >> So in thinking about this a bit, perhaps there's something useful that
> >> we can try in parallel with the single-person focu
Note my comment doesn't indicate a regression or new breakage, it only
notes a caveat: the Solaris OS API doesn't work with unnumbered IPv4.
(Maybe the API changed in the meantime - this patch is pretty old...)
But considering it didn't work at all before, the patch is still an
improvement. I wo
On Thu, Jun 30, 2016 at 03:53:21PM +0200, Philippe Guibert wrote:
> On Thu, Jun 30, 2016 at 9:57 AM, David Lamparter
> wrote:
>
> Hello David,
>
> > I have a rebased/somewhat-cleaned version around, might be more useful
> > to look at that. It's not fully cleane
Hi Philippe,
I have a rebased/somewhat-cleaned version around, might be more useful
to look at that. It's not fully cleaned up yet, but better than what's
currently up there. I'll push it out some time today, will send another
email. (Actually started writing docs for capnp...)
However - the
So -- I'd summarise this as "modularise upwards and downwards, but not
sideways".
Hope this makes sense,
-David
[*] Except SNMP, that should probably use one of the other interfaces
and be out-of-process.
> On Tue, Jun 14, 2016 at 1:59 PM, David Lamparter
> wrote:
&g
On Tue, Jun 14, 2016 at 10:03:41AM -0400, Lou Berger wrote:
> Eak -- the branch doesn't compile with -std=c99 .
Standard for Quagga is currently "-std=gnu99" as seen in configure.ac
line ~140; there seems to be a bug somewhere that the flag isn't
correctly applied?
-David
> On 6/14/2016 9:47 AM,
---
bgpd/bgp_fsm.c | 14 +-
bgpd/bgp_fsm.h | 4
bgpd/bgp_snmp.c | 11 +++
bgpd/bgp_snmp.h | 3 +++
4 files changed, 19 insertions(+), 13 deletions(-)
diff --git a/bgpd/bgp_fsm.c b/bgpd/bgp_fsm.c
index c4cfd58..8b3bb8c 100644
--- a/bgpd/bgp_fsm.c
+++ b/bgpd/bgp_fsm.c
@
---
bgpd/Makefile.am | 1 +
configure.ac | 6 --
lib/Makefile.am| 13 +++--
ospf6d/Makefile.am | 2 +-
ospfd/Makefile.am | 2 +-
ripd/Makefile.am | 2 +-
zebra/Makefile.am | 2 +-
7 files changed, 20 insertions(+), 8 deletions(-)
diff --git a/bgpd/Makefile.am b/b
) 2016 David Lamparter, for NetDEF, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rig
---
bgpd/Makefile.am | 9 +++--
bgpd/bgp_snmp.c | 24 ++--
bgpd/bgp_snmp.h | 31 ---
bgpd/bgpd.c | 9 +++--
bgpd/bgpd.h | 3 +++
5 files changed, 31 insertions(+), 45 deletions(-)
delete mode 100644 bgpd/bgp_snmp.h
diff --git
Hi all,
this series contains support for loading dynamic modules (DSOs) that contain
additional functionality. bgpd's SNMP support is the test target.
THIS IS AN UNFINISHED VERSION TO INVITE FEEDBACK.
In the "big picture", there are some very broad topics that are non-trivial,
first and foremo
inished_loading = 1;
+
+ *qplug_last = rtinfo;
+ qplug_last = &rtinfo->next;
+ return rtinfo;
+
+out_fail:
+ if (rtinfo->load_args)
+ XFREE(MTYPE_PLUGIN_LOADARGS, rtinfo->load_args);
+ XFREE(MTYPE_PLUGIN_LOADNAME, rtinfo->load_name);
+
---
bgpd/bgp_main.c | 17 -
zebra/main.c| 17 +++--
2 files changed, 31 insertions(+), 3 deletions(-)
diff --git a/bgpd/bgp_main.c b/bgpd/bgp_main.c
index 25669a0..0ca2b99 100644
--- a/bgpd/bgp_main.c
+++ b/bgpd/bgp_main.c
@@ -39,6 +39,7 @@ Software Foundation, Inc
- list_add_node_next was in fact unused
- list_add_node_prev performs a subset of listnode_add_before and
its only use in isisd replaced with that.
Signed-off-by: David Lamparter
---
;)
---
isisd/isis_spf.c | 4 ++--
lib/linklist.c | 49
Make it easier to see which bits in *_snmp.c are actually referenced
from non-SNMP parts of the code.
Signed-off-by: David Lamparter
---
bgpd/bgp_snmp.c | 8
ospf6d/ospf6_snmp.c | 6 +++---
ospfd/ospf_snmp.c | 18 +-
ripd/rip_snmp.c | 6 +++---
zebra
sed and is therefore untested.
The most useful documentation on this is actually the blog post Vincent
Bernat wrote when he originally integrated this into lldpd and Quagga:
https://vincent.bernat.im/en/blog/2012-snmp-event-loop.html
Signed-off-by: David Lamparter
---
lib/agen
Another zoo extension, this adds a timer scheduling function that takes
a struct timeval argument (which is actually what the wrappers boil down
to, yet it's not exposed...)
Signed-off-by: David Lamparter
---
lib/thread.c | 11 +++
lib/thread.h | 5 +
2 files changed, 16 inser
Hi all,
this is a bunch of cleanups to the SNMP code, in particular removing the
somewhat ugly event-loop integration.
Unfortunately, it somewhat increases messyness in the linked-list code.
It's like sweeping leaves from one corner of the yard into another... then
again, I think the uglyness in
- supports before == NULL
- returns allocated node
In general, the entire linked-list implementation is in bad shape, and
while it needs a cleanup / rewrite / replacement, this would both cause
significant conflicts and block other cleanups...
Signed-off-by: David Lamparter
---
lib/linklist.c
timer management, has been superseded by
the following one:
commit 4becea724ccd87e88f8454622ae227308b5fa3ce
Author: Christian Franke
AuthorDate: Tue Nov 19 14:11:42 2013 +
Commit: David Lamparter
CommitDate: Tue Apr 22 21:17:00 2014 +0200
lib: use heap to manage timers
Signe
Whoops, the "add" part of this got mixed up in the 1/8 patch...
(Thanks Donald for pointing that out!)
Should've noticed that myself looking at the diffstat...
I'll go fix & resend.
-David
On Tue, May 24, 2016 at 06:26:49PM +0200, David Lamparter wrote:
> From: Chri
Hi again,
unlike isisd, bgpd has its logic very nicely split from its CLI functions.
Still, a few places had (very small) room for improvement :)
[Had to fix some rebasing, hope I didn't break stuff...]
-David
___
Quagga-dev mailing list
Quagga-dev@l
Signed-off-by: David Lamparter
---
bgpd/bgp_table.h | 38 --
1 file changed, 38 deletions(-)
diff --git a/bgpd/bgp_table.h b/bgpd/bgp_table.h
index bee1296..3b4e6cf 100644
--- a/bgpd/bgp_table.h
+++ b/bgpd/bgp_table.h
@@ -118,44 +118,6 @@ bgp_node_table
consumers, matches peer->afc)
Signed-off-by: David Lamparter
---
bgpd/bgpd.c | 13 +++--
bgpd/bgpd.h | 9 +
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
index 249d20f..cadca11 100644
--- a/bgpd/bgpd.c
+++ b/bgpd/bgpd.c
@@ -11
Logic for determining the router-id was spread out over bgp_zebra.c and
bgp_vty.c. Move to bgpd/bgpd.c and have these two call more properly
encapsulated functions.
Signed-off-by: David Lamparter
---
bgpd/bgp_vty.c | 9 +++--
bgpd/bgp_zebra.c | 9 +
bgpd/bgp_zebra.h | 1
Create isis_vty.c and start moving off CLI functions into that. These
then call newly-added "nice" API wrappers.
Patch contains significant work authored by Christian Franke.
Signed-off-by: David Lamparter
---
isisd/Makefile.am| 3 +-
isisd/isis_circu
No setters needed since change of fields doesn't require any
specific action to make it apply. Just move the CLI defs to isis_vty.c.
Signed-off-by: David Lamparter
---
isisd/isis_circuit.c | 705 ---
isisd/isis_vty.c
From: Christian Franke
See previous commits...
Signed-off-by: David Lamparter
---
isisd/isis_circuit.c | 24 --
isisd/isis_vty.c | 565
isisd/isisd.c| 643 ++-
isisd/isisd.h| 4
From: Christian Franke
Yet more CLI functions in isis_vty.c using more nice setters.
Signed-off-by: David Lamparter
---
isisd/isis_events.c | 113 ---
isisd/isis_events.h | 5 --
isisd/isis_vty.c| 126 ++
isisd/isisd.c | 219
From: Christian Franke
Last isisd CLI cleanup for now. This also folds L1 & L2 configs into
common functions, reducing CLI function bloat by a bit.
(This patch contains changes authored by both Christian Franke and David
Lamparter.)
Signed-off-by: David Lamparter
---
isisd/isis_vty.c |
Expense, Error and Delay metrics never quite made it into the real
world. Either way isisd does nothing useful with them, so let's drop
them from the code. If someone wants to implement them, this patch can
still be reverted.
Signed-off-by: David Lamparter
---
isisd/isis_circuit.c
From: Christian Franke
This cleans up circuit password configuration a little bit.
(Restructured several times by both Christian Franke and David
Lamparter.)
Signed-off-by: David Lamparter
---
isisd/isis_circuit.c | 81 +++-
isisd/isis_circuit.h
Hi everyone,
Chris & I have put some work into splitting off actual "execution" / "setter"
functions from their CLI binding code. This covers most isisd basic
configuration.
I've done the final pass & rebase, so any bugs are probably mine :). Had to
make some rebasing fixes too, so it's possibl
From: Christian Franke
Move out basic area configuration (metric type, overload and attachment
bits, dynamic hostname extension enable) into isis_vty.c.
Signed-off-by: David Lamparter
---
isisd/isisd.c | 224 ++
isisd/isisd.h | 6 ++
2
, Paul Jakma wrote:
> On Fri, 20 May 2016, David Lamparter wrote:
> > The event most likely to change my opinion on this is being presented
> > with an actual real-world setup that sees breakage from this. From
> > the way this bug works, I guess it'd need to be a Quagga-
Btw: Donald -- this patch is very early in the Cumulus tree; I assume
it's been part of previous stable releases that are in active use at
customer installations? Have you received any reports of breakage?
-David
On Fri, May 20, 2016 at 04:37:37PM +0200, David Lamparter wrote:
> On
On Fri, May 20, 2016 at 02:12:51PM +0100, Paul Jakma wrote:
> Could we agree that at a minimum there needs to be a config knob, so
> admins can at least manage rolling out updates without introducing
> mixed-environments?
I haven't seen any technical argument that led me to change my opinion
on
Hiya,
so, having taked to Donald, I believe I'm supposed to do /8. I've
suggested taking the cumulus patchset whole and pack the entire thing on
8/proposed, have people test and fix issues on top, and then merge it.
Is that reasonable?
-David
On Thu, Apr 28, 2016 at 08:33:42AM -0400, Lou Berge
On Thu, Apr 21, 2016 at 12:33:50PM +0100, Paul Jakma wrote:
> The previous patch clearly is incomplete, based on the concerns of those
> proposing it and further analysis. Your review of the next patch seems
> to be missing some of the issues, while restating the issue driving this
> that makes
On Wed, Apr 20, 2016 at 04:13:13PM +0100, Paul Jakma wrote:
> The application I developed it for. Being able to take down routers in a
> staged way
[...]
> The OSPF WG is actually standardising behaviour for that. It's useful
> enough they've re-allocated a previously allocated and very precious
On Wed, Apr 20, 2016 at 09:23:50AM -0400, Daniel Walton wrote:
> On Wed, Apr 20, 2016 at 4:15 AM, Paul Jakma wrote:
> > On Tue, 19 Apr 2016, Daniel Walton wrote:
> >
> > How does this work then...is it your word no matter how the rest of the
> >> quagga community feels? That is certainly how it i
On Wed, Apr 20, 2016 at 08:36:04AM -0400, Lennart Sorensen wrote:
> On Wed, Apr 20, 2016 at 07:37:12AM -0400, Lou Berger wrote:
> > ahh - not necessarily -- particularly if it fixes a major interop issue
> > (which is the point of standards after all).
>
> Well if you could fix the interop by chan
+1
-David
On Tue, Apr 19, 2016 at 10:46:43AM -0400, Donald Sharp wrote:
> I'm confused. I thought that was the point of the call to gather consensus
> as a community.
>
> donald
>
> On Tue, Apr 19, 2016 at 10:34 AM, Paul Jakma wrote:
>
> > On Tue, 19
On Tue, Apr 19, 2016 at 04:10:04PM +0200, David Lamparter wrote:
> The default state of this seems to be "infinite", which is not
> RFC-compilant behaviour. There was unanimous consent in the monthly
> meeting that RFC-compliant behaviour should be the default.
s/consent/conse
On Tue, Apr 12, 2016 at 12:58:44PM +0100, Paul Jakma wrote:
> - Makes the SPF behaviour configurable with a
>
> "compatible max-metric (infinite|follow)"
The default state of this seems to be "infinite", which is not
RFC-compilant behaviour. There was unanimous consent in the monthly
mee
pimd, ldpd and nhrpd all use slight variants of kernel style. (With
"kernel" meaning either Linux, FreeBSD or OpenBSD - the styles are
relatively close.)
Also drop RCS keyword foo.
Signed-off-by: David Lamparter
---
With Timo hacking on nhrpd and Renato hacking on ldpd, this see
Hi y'all,
with Easter having passed - what's the status / next steps on this?
Thanks,
-David
On Fri, Dec 11, 2015 at 06:50:44PM -0500, Donald Sharp wrote:
[cut]
___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/
On Tue, Mar 15, 2016 at 04:19:19PM +0100, David Lamparter wrote:
> you can find the slides for the presentation I just gave at the monthly
> meeting up at this URL:
> https://aurora.nox.tf/tmp/quaxolotl_20160315.pdf
> (will probably repost them somewhere else with a more permanent UR
On Thu, Mar 17, 2016 at 08:29:34AM +, Paul Jakma wrote:
> On Wed, 16 Mar 2016, Donald Sharp wrote:
> > Without this patch when I set 'max-metric router-lsa administrative' on a
> > switch, it is no longer considered as part of the spf calculation for
> > routes.
> >
> > Suppose I have
> >
> > s
Hi all,
in the monthly meeting that just ended, there was a bit about security
patches and their handling; I promised to send a mail elaborating on
it further.
In short, I believe there are 2 things that can be improved here:
- raising the bar on what constitutes a security-critical fix
- not m
Sounds good to me.
-David
On Thu, Mar 10, 2016 at 10:33:09AM -0500, Donald Sharp wrote:
> Problem statement:
>
> Patches can be in an unaccepted stated for a long time while the current
> proposed branch is in a frozen state in order to get it ready for release.
> This causes problems for the de
Hi all,
you can find the slides for the presentation I just gave at the monthly
meeting up at this URL:
https://aurora.nox.tf/tmp/quaxolotl_20160315.pdf
(will probably repost them somewhere else with a more permanent URL)
I'll check into pushing the code out to github or so, expect another
mail
On Thu, Mar 10, 2016 at 10:46:45AM -0500, Donald Sharp wrote:
> 1) Proposed branching scheme, sent under cover of another email
> 2) Call for more gatekeepers. Please self nominate!
I guess I'm available to try and share some of Donald's workload.
Let's check the details in Hangout.
-David
My API presentation tomorrow includes a section on why we choose Cap'n
Proto and why it is better than Protobuf ;)
The biggest argument is:
> > - Library routines for working with protobuf, including functions
> > that help translate between common quagga types and their protobuf
> > equ
On Mon, Mar 14, 2016 at 09:32:34AM -0700, Avneesh Sachdev wrote:
> It looks like we agree that:
>
> - test functions should be easier to write.
>
> - test code should not be part of a production build (whether via
> conditional compilation or separate binaries).
>
> Given the above, why not
On Sun, Mar 13, 2016 at 06:29:22PM -0700, Avneesh Sachdev wrote:
> On Sun, Mar 13, 2016 at 1:04 PM, Donald Sharp
> wrote:
> > Can you expand a bit on why adding the ability to call random functions
> > from the cli is better than just adding a 'test XXX' function as needed?
>
> The functionality
cf. https://gcc.gnu.org/onlinedocs/gcc/Typeof.html
(Works on all compilers on Quagga's compiler support list in
doc/overview.texi)
Signed-off-by: David Lamparter
---
Would suggest this additional fix to make the macro less surprising.
-David
---
lib/zebra.h | 12 +---
1 file chang
cf. https://gcc.gnu.org/onlinedocs/gcc/Typeof.html
(Works on all compilers on Quagga's compiler support list in
doc/overview.texi)
Signed-off-by: David Lamparter
---
Would suggest this additional fix to make the macro less surprising.
-David
---
lib/zebra.h | 12 +---
1 file ch
M +, Paul Jakma wrote:
> On Thu, 3 Mar 2016, Paul Jakma wrote:
> > On Thu, 3 Mar 2016, David Lamparter wrote:
> >
> >> As for this discussion, the approach that seemed most fruitful in my view
> >> was to push transaction functionality outside of Quagga. Ther
On Wed, Mar 02, 2016 at 06:09:45PM +, Paul Jakma wrote:
> On Wed, 2 Mar 2016, Paul Jakma wrote:
>
> > Someone mentioned Vyatta had done some work in this area. I think Cumulus
> > might have done some work on other interfaces into things too, but I'm not
>
You could just change Makefile.am to call extract.pl as argument to
perl, as in:
- ./$(EXTRA_DIST) $(vtysh_cmd_FILES) > vtysh_cmd.c
+ $(PERL) ./$(EXTRA_DIST) $(vtysh_cmd_FILES) > vtysh_cmd.c
(On a random sidenote, it's really ugly to use $(EXTRA_DIST) like
that...)
On Thu, Mar 03, 201
On Wed, Mar 02, 2016 at 08:38:05PM -0500, Donald Sharp wrote:
> On a side note, extract.pl.in as far as I can tell only is used to auto
> generate the perl binary location.
Hadn't looked at this before sending my previous e-mail, but - it
actually uses more than the perl binary location:
line 71:
On Fri, Feb 26, 2016 at 03:02:56AM -0800, Martin Winter wrote:
> > Building Stage: Failed
> >
> > CentOS6 amd64 build: Successful
> > Ubuntu1204 amd64 build: Successful
> > NetBSD7 amd64 build: Successful
> > FreeBSD10 amd64 build: Successful
> > OmniOS amd64 build: Successful
> >
Move over to the new allocation counting added in the previous commit.
(This commit is mostly mechanical.)
Signed-off-by: David Lamparter
Acked-by: Vincent JARDIN
---
bgpd/bgp_main.c | 1 +
bgpd/bgp_vty.c | 1 +
isisd/isis_main.c | 1 +
isisd
t.
Signed-off-by: David Lamparter
Acked-by: Vincent JARDIN
Acked-by: Donald Sharp
---
bgpd/Makefile.am | 2 +
bgpd/bgp_community.c | 1 +
bgpd/bgp_memory.c| 99
bgpd/bgp_memory.h| 95
bgpd/bgpd.h
The following commit will recreate memory.[ch].
Signed-off-by: David Lamparter
Acked-by: Vincent JARDIN
Acked-by: Donald Sharp
---
lib/Makefile.am | 8 +-
lib/memory.c | 486 ---
lib/memory.h | 98 +--
lib/memory_vty.c
Signed-off-by: David Lamparter
Acked-by: Vincent JARDIN
Acked-by: Donald Sharp
---
lib/.gitignore | 1 -
lib/Makefile.am | 10 +++---
lib/memtypes.c | 16
lib/memtypes.pl | 6 --
4 files changed, 3 insertions(+), 30 deletions(-)
delete mode 100644 lib/memtypes.c
Signed-off-by: David Lamparter
Acked-by: Vincent JARDIN
Acked-by: Donald Sharp
---
INSTALL.quagga.txt | 1 -
configure.ac | 6 --
2 files changed, 7 deletions(-)
diff --git a/INSTALL.quagga.txt b/INSTALL.quagga.txt
index 11c85b1..b414d94 100644
--- a/INSTALL.quagga.txt
+++ b
This places MTYPE definitions into the files where they're actually
used, making most of them static in the process.
Signed-off-by: David Lamparter
Acked-by: Vincent JARDIN
Acked-by: Donald Sharp
---
lib/buffer.c | 3 ++-
lib/command.c | 4
lib/command.h | 6 +
Hi all,
this is the rebased version of this series, now applying on
ca52365 "FreeBSD Bug: Zebra not deleting routes"
I've also removed the "#if 0" macro branch and fixed remaining
coding style issues I could find.
As these changes are whitespace to the C compiler, I've taken the
liberty of addi
This rewrites Quagga's memory per-type allocation counting, without
using a fixed global list of types. Instead, source files can declare
memory types which get handled through constructor functions called by
the dynamic linker during startup.
Signed-off-by: David Lamparter
Acked-by: Vi
A few places are using 0 in place of the MTYPE_* argument. The
following rewrite of the alloc tracking won't deal with that, so let's
use MTYPE_TMP instead.
Signed-off-by: David Lamparter
Acked-by: Vincent JARDIN
Acked-by: Donald Sharp
---
lib/prefix.c| 2 +-
bgpd, ospf6d, isisd and some tests were reusing MTYPEs defined in the
library for its own use. This is bad practice and will break with the
later commit making the library's MTYPEs static.
Signed-off-by: David Lamparter
Acked-by: Vincent JARDIN
Acked-by: Donald Sharp
---
bgpd/bgp_next
This adapts the dump-at-exit handler and removes the old leftover code.
(Note the text in log_memtype_stderr was actually incorrect as the only
caller in bgpd cleans up configuration before calling it, i.e. any
remaining allocations are missing-cleanup bugs.)
Signed-off-by: David Lamparter
On Wed, Feb 24, 2016 at 06:25:06PM -0500, Donald Sharp wrote:
> I'm not a big fan of #if 0 or #if 1's introduced with this patch. Is there
> someway we can mitigate them?
This is what the comments from Paul & myself in the other mail referred to:
> Paul:
> > - The __builtin_types_{expect,compatib
Apologies if you received (or will receive) duplicates of my messages.
Something seems to be wrong with the mailing list; it lost 3 of my
messages today... can somebody investigate?
Message-ID: <20160224090742.GA873456@eidolon>
Message-ID: <20160224120905.GB873456@eidolon>
Message-ID: <20160224131
On Wed, Feb 24, 2016 at 02:53:19AM -0800, Martin Winter wrote:
> On 24 Feb 2016, at 1:07, David Lamparter wrote:
>
> > On Wed, Feb 24, 2016 at 01:00:03AM -0800, cisys...@netdef.org wrote:
> >> Continous Integration Result: FAILED
> > [...]
> >> T
On Wed, Feb 24, 2016 at 11:58:42AM +, Paul Jakma wrote:
> - This seems to require various extensions to work, some seem to be GCC
>specific?
It's specific to the "GCC-like group". I have tested on:
Linux clang 3.6.1
Linux icc 14.0.3
Linux gcc 4.9.3
Linux gcc 4.7.4
Linux gcc 4.2.4
Linux gc
On Wed, Feb 24, 2016 at 01:00:03AM -0800, cisys...@netdef.org wrote:
> Continous Integration Result: FAILED
[...]
> Tested on top of Git : eae18d1 (as of 20151209.135437 UTC)
As mentioned in the original mail, this patchset applies on top of
"lib: fix vrf_bitmap leak in zclient_free()", not master
[btw, my previous response didn't make the loop back to me, is that just
me or is something stuck on the mailing list?]
On Wed, Feb 24, 2016 at 04:26:58PM +, Paul Jakma wrote:
> Also, does this depend on using dynamic linking? We do have people who
> like to build Quagga with --disable-shared
This places MTYPE definitions into the files where they're actually
used, making most of them static in the process.
Signed-off-by: David Lamparter
---
lib/buffer.c | 3 ++-
lib/command.c | 4
lib/command.h | 6 +
lib/distribute.c | 3 +++
lib/filter.c
t.
Signed-off-by: David Lamparter
---
bgpd/Makefile.am | 2 +
bgpd/bgp_community.c | 1 +
bgpd/bgp_memory.c| 99
bgpd/bgp_memory.h| 95
bgpd/bgpd.h | 1 +
isisd/Makefile.am| 2 +
is
Move over to the new allocation counting added in the previous commit.
(This commit is mostly mechanical.)
Signed-off-by: David Lamparter
---
bgpd/bgp_main.c | 1 +
bgpd/bgp_vty.c | 1 +
isisd/isis_main.c | 1 +
isisd/isis_redist.c | 1 -
lib
Signed-off-by: David Lamparter
---
lib/.gitignore | 1 -
lib/Makefile.am | 10 +++---
lib/memtypes.c | 16
lib/memtypes.pl | 6 --
4 files changed, 3 insertions(+), 30 deletions(-)
delete mode 100644 lib/memtypes.c
delete mode 100755 lib/memtypes.pl
diff --git a
Signed-off-by: David Lamparter
---
INSTALL.quagga.txt | 1 -
configure.ac | 6 --
2 files changed, 7 deletions(-)
diff --git a/INSTALL.quagga.txt b/INSTALL.quagga.txt
index 11c85b1..b414d94 100644
--- a/INSTALL.quagga.txt
+++ b/INSTALL.quagga.txt
@@ -69,7 +69,6 @@ deficient is made
bgpd, ospf6d, isisd and some tests were reusing MTYPEs defined in the
library for its own use. This is bad practice and will break with the
later commit making the library's MTYPEs static.
Signed-off-by: David Lamparter
---
bgpd/bgp_nexthop.c | 8 +---
isisd/isis_memory.c
This rewrites Quagga's memory per-type allocation counting, without
using a fixed global list of types. Instead, source files can declare
memory types which get handled through constructor functions called by
the dynamic linker during startup.
Signed-off-by: David Lamparter
---
lib/Makefi
This adapts the dump-at-exit handler and removes the old leftover code.
(Note the text in log_memtype_stderr was actually incorrect as the only
caller in bgpd cleans up configuration before calling it, i.e. any
remaining allocations are missing-cleanup bugs.)
Signed-off-by: David Lamparter
A few places are using 0 in place of the MTYPE_* argument. The
following rewrite of the alloc tracking won't deal with that, so let's
use MTYPE_TMP instead.
Signed-off-by: David Lamparter
---
lib/prefix.c| 2 +-
ospfclient/ospf_apiclient.h | 2 +-
ospfd/osp
Hi quagga-dev,
this patchset replaces the 1990s-era memory allocation tracking
with a 2010s-era memory allocation tracking. Particularly, it
removes the neccessity to maintain a centralised list of MTYPEs
in the library. Daemons can now just define their own MTYPEs on
the fly, with per-file sta
The following commit will recreate memory.[ch].
Signed-off-by: David Lamparter
---
lib/Makefile.am | 8 +-
lib/memory.c | 486 ---
lib/memory.h | 98 +--
lib/memory_vty.c | 486
Hi quagga-dev,
this is a set of 3 random-cleanup patches fixing things I stumbled upon while
doing other work.
-David
___
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
fix (for all places where the code needs to abort due to internal
errors).
Signed-off-by: David Lamparter
---
isisd/isis_redist.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/isisd/isis_redist.c b/isisd/isis_redist.c
index abb9ecd..552613a 100644
--- a/isisd/isis_redist.c
+++ b/isisd/isis_red
zclient_stop(), which is used as antagonist to zclient_init(), needs to
undo the vrf_bitmap allocation. Otherwise zclient_init() will leak the
allocated memory, for example when zclient_reset() is used.
Reported-by: Lou Berger
Signed-off-by: David Lamparter
---
lib/zclient.c | 10
1 - 100 of 352 matches
Mail list logo
