[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-07 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9538 ) Change subject: IMPALA-6602: fixes flaky expiration test .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9538/3/tests

[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-07 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9538 to look at the new patch set (#4). Change subject: IMPALA-6602: fixes flaky expiration test .. IMPALA-6602: fixes f

[Impala-ASF-CR] IMPALA-6602: fixes flaky expiration test

2018-03-08 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9538 ) Change subject: IMPALA-6602: fixes flaky expiration test .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9538/5/tests/

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9626 Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. IMPALA-6488: removes use-after-free bug in lib_cache Several rec

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. IMPALA-6488: removes use-after-free bug in lib_cache Several rece

[Impala-ASF-CR] IMPALA-5270: Pass resolved exprs into analytic SortInfo.

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9631 ) Change subject: IMPALA-5270: Pass resolved exprs into analytic SortInfo. .. Patch Set 1: (8 comments) several comments while skimming

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has removed Michael Brown from this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Removed reviewer Michael Brown. -- To view, visit http:

[Impala-ASF-CR] IMPALA-5270: Pass resolved exprs into analytic SortInfo.

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9631 ) Change subject: IMPALA-5270: Pass resolved exprs into analytic SortInfo. .. Patch Set 2: (1 comment) thanks for the changes. one more

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Patch Set 2: (5 comments) thanks for the review! http://gerri

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Hello David Knupp, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9626 to look at the new patch set (#3). Change subject: IMPALA-6488: removes use-after-free bug in lib_cache ..

[Impala-ASF-CR] IMPALA-5270: Pass resolved exprs into analytic SortInfo.

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9631 ) Change subject: IMPALA-5270: Pass resolved exprs into analytic SortInfo. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Hello David Knupp, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9626 to look at the new patch set (#4). Change subject: IMPALA-6488: removes use-after-free bug in lib_cache ..

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Patch Set 4: extra changes in last patches are to covert NULL -

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. Patch Set 8: (2 comments) looks good, main questions I hav

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-14 Thread Vuk Ercegovac (Code Review)
Hello David Knupp, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9626 to look at the new patch set (#5). Change subject: IMPALA-6488: removes use-after-free bug in lib_cache ..

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. Patch Set 11: Code-Review+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. Patch Set 11: Before I forget, I was expecting to see tests

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-16 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9697 Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP) .. IMPALA-6670: refresh lib-cache entries from plan (WIP) When an

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/9589/

[Impala-ASF-CR](2.x) IMPALA-5270: Pass resolved exprs into analytic SortInfo.

2018-03-17 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9708 ) Change subject: IMPALA-5270: Pass resolved exprs into analytic SortInfo. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-6643: Add REFRESH fine-grained privilege

2018-03-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH fine-grained privilege .. Patch Set 14: Code-Review+1 thx for the updates! -- To view, visit

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP) .. IMPALA-6670: refresh lib-cache entries from plan (WIP) When an

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP) .. Patch Set 4: latest update: - fix several test cases found by

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-19 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP) .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-19 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#6). Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP)

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-20 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#7). Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP)

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP) .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-20 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#8). Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP)

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan (WIP)

2018-03-20 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan (WIP) .. Patch Set 8: (12 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-20 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#9). Change subject: IMPALA-6670: refresh lib-cache entries from plan ..

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/9697

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#10). Change subject: IMPALA-6670: refresh lib-cache entries from plan .

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/969

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#11). Change subject: IMPALA-6670: refresh lib-cache entries from plan .

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/9697

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 11: (7 comments) http://gerrit.cloudera.org:8080/#/c/969

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#12). Change subject: IMPALA-6670: refresh lib-cache entries from plan .

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/9697

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 12: (3 comments) I also added a test to catch the mismat

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#13). Change subject: IMPALA-6670: refresh lib-cache entries from plan .

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#14). Change subject: IMPALA-6670: refresh lib-cache entries from plan .

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#15). Change subject: IMPALA-6670: refresh lib-cache entries from plan .

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-21 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 14: (5 comments) http://gerrit.cloudera.org:8080/#/c/969

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#16). Change subject: IMPALA-6670: refresh lib-cache entries from plan .

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/969

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#17). Change subject: IMPALA-6670: refresh lib-cache entries from plan .

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/9697

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/9697

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Zach Amsden, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#18). Change subject: IMPALA-6670: refresh lib-cache entries from plan

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 19: (9 comments) http://gerrit.cloudera.org:8080/#/c/969

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Zach Amsden, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#20). Change subject: IMPALA-6670: refresh lib-cache entries from plan

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9697 ) Change subject: IMPALA-6670: refresh lib-cache entries from plan .. Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/969

[Impala-ASF-CR] IMPALA-6670: refresh lib-cache entries from plan

2018-03-22 Thread Vuk Ercegovac (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Zach Amsden, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9697 to look at the new patch set (#21). Change subject: IMPALA-6670: refresh lib-cache entries from plan

[Impala-ASF-CR] IMPALA-6722: include fs prefix for udf test

2018-03-22 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9782 Change subject: IMPALA-6722: include fs prefix for udf test .. IMPALA-6722: include fs prefix for udf test test_native_functions_race fa

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 2: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create function statement

2018-03-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create function statement .. Patch Set 3: (2 comments) http://gerrit.clo

[Impala-ASF-CR](2.x) IMPALA-6743: bump from 2.11 to 2.12

2018-03-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9809 Change subject: IMPALA-6743: bump from 2.11 to 2.12 .. IMPALA-6743: bump from 2.11 to 2.12 Next release is 2.12 so update the 2.x branch

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-26 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6719: Reset metadata database name case sensitivity

2018-03-27 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9788 ) Change subject: IMPALA-6719: Reset metadata database name case sensitivity .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-6724: Incorrect exception handling in create/drop function statements

2018-03-27 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9800 ) Change subject: IMPALA-6724: Incorrect exception handling in create/drop function statements .. Patch Set 5: (10 comments) http://ger

[Impala-ASF-CR] IMPALA-4025: Part 1: Add percentile disc aggregation function

2018-03-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9777 ) Change subject: IMPALA-4025: Part 1: Add percentile_disc aggregation function .. Patch Set 1: (2 comments) initial comment... still re

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-03-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-03-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 11: I got blocked behind some lib-cache stuff, b

[Impala-ASF-CR] IMPALA-6337: Fix infinite loop in Impala shell

2018-04-02 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 ) Change subject: IMPALA-6337: Fix infinite loop in Impala shell .. Patch Set 10: if we're not going forward with this change, pls abando

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-03 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6793: Fix empty metadata after statestore restarts

2018-04-04 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9921 ) Change subject: IMPALA-6793: Fix empty metadata after statestore restarts .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9968 Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215: Removes race when using LibCache. Re-do the previously re

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 1: Code-Review+2 (1 comment) carrying Tim's +2 http://ger

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9968 to look at the new patch set (#2). Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215: R

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 2: Code-Review+2 carrying tim's +2 -- To view, visit http

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 2: noticed that the test litters the test cluster with jars

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9968 to look at the new patch set (#3). Change subject: IMPALA-6215: Removes race when using LibCache. .. IMPALA-6215: R

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-04-10 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9968 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 3: Code-Review+2 carrying tim's +2 -- To view, visit http

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 2: (12 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-24 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11193 to look at the new patch set (#3). Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. ...

[Impala-ASF-CR] IMPALA-7469. Invalidate LocalCatalog cache based on topic updates

2018-08-24 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 ) Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates .. Patch Set 2: (5 comments) comments from initial

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-27 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 3: added detection for catalogd restart, whi

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-27 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11193 to look at the new patch set (#4). Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. ...

[Impala-ASF-CR] IMPALA-7448: Invalidate recently unused tables from catalogd

2018-08-27 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11224 ) Change subject: IMPALA-7448: Invalidate recently unused tables from catalogd .. Patch Set 3: (11 comments) still reviewing, but wante

[Impala-ASF-CR] IMPALA-7448: Invalidate recently unused tables from catalogd

2018-08-27 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11224 ) Change subject: IMPALA-7448: Invalidate recently unused tables from catalogd .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 4: (30 comments) made my way through most o

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-28 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11193 to look at the new patch set (#5). Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. ...

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-28 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11193 to look at the new patch set (#6). Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. ...

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 6: (4 comments) this round completes the fi

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-28 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11193 to look at the new patch set (#7). Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. ...

[Impala-ASF-CR] IMPALA-7424: Optimize in-memory representation of incremental stats

2018-08-28 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Optimize in-memory representation of incremental stats .. Patch Set 4: (22 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-7502: ALTER TABLE RENAME should require ALL on the old table

2018-08-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11344 ) Change subject: IMPALA-7502: ALTER TABLE RENAME should require ALL on the old table .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-29 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 4: (11 comments) main change here is to use

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-29 Thread Vuk Ercegovac (Code Review)
Hello Bharath Vissapragada, Tianyi Wang, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11193 to look at the new patch set (#8). Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. ...

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-7424: Reduce in-memory footprint of incremental stats

2018-08-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 ) Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats .. Patch Set 5: (11 comments) http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-7425: Change incremental stats to pull from catalogd.

2018-08-30 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11193 ) Change subject: IMPALA-7425: Change incremental stats to pull from catalogd. .. Patch Set 8: (2 comments) re-worked the part in compu

<    1   2   3   4   5   6   7   8   9   >