[kudu-CR] webserver: improve SSL certificate handling

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5015 to look at the new patch set (#3). Change subject: webserver: improve SSL certificate handling .. webserver: improv

[kudu-CR] webserver: improve SSL certificate handling

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: webserver: improve SSL certificate handling .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/5015/2/src/kudu/security/test/test_certs.h File src/k

[kudu-CR] WIP: replace gscoped ptr with unique ptr

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: WIP: replace gscoped_ptr with unique_ptr .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/2248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1600 (part 1): bump to CFile version 2 .. KUDU-1600 (part 1): bump to CFile version 2 This is preparatory yak-shaving work for KUDU-1600, an effort t

[kudu-CR] tablet: make time-based flushing configurable

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: tablet: make time-based flushing configurable .. tablet: make time-based flushing configurable We currently prioritize flushes for any in-memory data which has been

[kudu-CR] KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5679 to look at the new patch set (#4). Change subject: KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

[kudu-CR] tablet: make time-based flushing configurable

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tablet: make time-based flushing configurable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5690/1/src/kudu/tablet/tablet_peer_mm_ops.cc File sr

[kudu-CR] KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1600 (part 2): store uncompressed blocks when codec can't compress .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5679/3/src/kudu/cfile/blo

[kudu-CR] tpch: improve encodings and compression

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tpch: improve encodings and compression .. Patch Set 1: Nah, I'd rather keep the old perf data because it's useful to see whether it goes up or down after this pa

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1600 (part 1): bump to CFile version 2 .. Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5678/1/src/kudu/cfile/cfile_reader.cc

[kudu-CR] tpch: improve encodings and compression

2017-01-11 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: tpch: improve encodings and compression .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5689 To unsubscribe, visit http://g

[kudu-CR] tpch: dont clear data when loading is disabled

2017-01-11 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: tpch: dont clear data when loading is disabled .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5691 To unsubscribe, visit h

[kudu-CR] tpch: dont clear data when loading is disabled

2017-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tpch: dont clear data when loading is disabled .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5691 To unsubscribe, visit http://ge

[kudu-CR] tpch: improve encodings and compression

2017-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tpch: improve encodings and compression .. Patch Set 1: Code-Review+2 No point in deleting the old performance data, right? Since scan performance is likely the sa

[kudu-CR] tablet: make time-based flushing configurable

2017-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tablet: make time-based flushing configurable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5690/1/src/kudu/tablet/tablet_peer_mm_ops.cc File src

[kudu-CR] KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

2017-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1600 (part 2): store uncompressed blocks when codec can't compress .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5679/3/src/k

[kudu-CR] KUDU-1751: Change default encodings

2017-01-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1751: Change default encodings .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5169 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] Doc review for 1.2

2017-01-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Doc review for 1.2 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5676 To unsubscribe, visit http://gerrit.cloudera.org:8080/sett

[kudu-CR] tpch: use better encodings, compression in schema

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: tpch: use better encodings, compression in schema .. Abandoned superceded by https://gerrit.cloudera.org/#/c/5689/1 -- To view, visit http://gerrit.cloudera.org:8080/952

[kudu-CR] Doc review for 1.2

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5676 to look at the new patch set (#2). Change subject: Doc review for 1.2 .. Doc review for 1.2 I made a pass through

[kudu-CR] WIP: KUDU-1751: change default BINARY encoding to DICTIONARY

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: WIP: KUDU-1751: change default BINARY encoding to DICTIONARY .. Abandoned Rolled into https://gerrit.cloudera.org/#/c/5169/ -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] Doc review for 1.2

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Doc review for 1.2 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5676/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.ado

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5678 to look at the new patch set (#3). Change subject: KUDU-1600 (part 1): bump to CFile version 2 .

[kudu-CR] tablet: make time-based flushing configurable

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5690 to review the following change. Change subject: tablet: make time-based flushing configurable .. ta

[kudu-CR] tpch: improve encodings and compression

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5689 to review the following change. Change subject: tpch: improve encodings and compression .. tpch: im

[kudu-CR] tpch: dont clear data when loading is disabled

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5691 to review the following change. Change subject: tpch: dont clear data when loading is disabled .. t

[kudu-CR] KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5679 to look at the new patch set (#3). Change subject: KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

[kudu-CR] KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1600 (part 2): store uncompressed blocks when codec can't compress .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/5679/2/src/kudu/cfile/bl

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1600 (part 1): bump to CFile version 2 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5678/1/src/kudu/cfile/cfile_reader.cc File src/kudu/c

[kudu-CR] docs: KUDU-1767. Document possible client op reordering

2017-01-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: KUDU-1767. Document possible client op reordering .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5464/4//COMMIT_MSG Commit

[kudu-CR] KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

2017-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1600 (part 2): store uncompressed blocks when codec can't compress .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/5679/2/src/kudu/cfile/blo

[kudu-CR] docs: KUDU-1767. Document possible client op reordering

2017-01-11 Thread Mike Percy (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5464 to look at the new patch set (#5). Change subject: docs: KUDU-1767. Document possible client op reordering ..

[kudu-CR] docs: KUDU-1767. Document possible client op reordering

2017-01-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: docs: KUDU-1767. Document possible client op reordering .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/5464/4//COMMIT_MSG Commit Message: PS4,

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1600 (part 1): bump to CFile version 2 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5678/1/src/kudu/cfile/cfile_reader.cc File src/kudu

[kudu-CR] KUDU-1751: Change default encodings

2017-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1751: Change default encodings .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5169 To unsubscribe, visit http://gerrit.cloude

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1600 (part 1): bump to CFile version 2 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5678 To unsubscribe, visit http://gerri

[kudu-CR] KUDU-1751: Change default encodings

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5169 to look at the new patch set (#8). Change subject: KUDU-1751: Change default encodings .. KUDU-1751: Change default

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5678 to look at the new patch set (#2). Change subject: KUDU-1600 (part 1): bump to CFile version 2 .. KUDU-1600 (part 1

[kudu-CR] KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5679 to look at the new patch set (#2). Change subject: KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1600 (part 1): bump to CFile version 2 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5678/1/docs/design-docs/cfile.md File docs/design-doc

[kudu-CR] KUDU-1751: Change default INT and BINARY encodings

2017-01-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1751: Change default INT and BINARY encodings .. Patch Set 7: (3 comments) Test failures look legit. http://gerrit.cloudera.org:8080/#/c/5169/7//COMMIT_MSG

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1600 (part 1): bump to CFile version 2 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5678/1/docs/design-docs/cfile.md File docs/design-docs

[kudu-CR] Doc review for 1.2

2017-01-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Doc review for 1.2 .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5676/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.ado

[kudu-CR] Doc review for 1.2

2017-01-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Doc review for 1.2 .. Patch Set 1: (7 comments) Just skimmed quickly on the first pass. http://gerrit.cloudera.org:8080/#/c/5676/1/docs/kudu_impala_integration.

[kudu-CR] Doc review for 1.2

2017-01-11 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Doc review for 1.2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5676/1/docs/kudu_impala_integration.adoc File docs/kudu_impala_integration.adoc

[kudu-CR] [kudu-jepsen] Kudu Jepsen tests

2017-01-11 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#19). Change subject: [kudu-jepsen] Kudu Jepsen tests .. [kudu-jepsen] Kudu Jepsen te

[kudu-CR] KUDU-1771. Java client "connection refused" errors logged as "connection reset"

2017-01-11 Thread Jun He (Code Review)
Jun He has uploaded a new change for review. http://gerrit.cloudera.org:8080/5680 Change subject: KUDU-1771. Java client "connection refused" errors logged as "connection reset" .. KUDU-1771. Java client "connection refused"

[kudu-CR] KUDU-1600 (part 2): store uncompressed blocks when codec can't compress

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5679 to review the following change. Change subject: KUDU-1600 (part 2): store uncompressed blocks when codec can't compress ...

[kudu-CR] KUDU-1751: Change default INT and BINARY encodings

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5169 to look at the new patch set (#7). Change subject: KUDU-1751: Change default INT and BINARY encodings ..

[kudu-CR] KUDU-1600 (part 1): bump to CFile version 2

2017-01-11 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5678 to review the following change. Change subject: KUDU-1600 (part 1): bump to CFile version 2 .. KUDU-1600 (part 1): bump

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-01-11 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5677 to look at the new patch set (#2). Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates ..

[kudu-CR] [java client] KUDU-1643 Prune hash partitions based on IN-list predicates

2017-01-11 Thread Haijie Hong (Code Review)
Haijie Hong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5677 Change subject: [java client] KUDU-1643 Prune hash partitions based on IN-list predicates .. [java client] KUDU-1643 Prune hash partitions