Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 1: (1 inline comment)
File vdsm/vdsmd.service.in
Line 6:
Line 7: [
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 1: (1 inline comment)
File vdsm/init/daemonAdapter
Line 38:
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 1: (3 inline comments)
File vdsm/init/daemonAdapter
Line 38:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: /etc/tmpfiles.d/vdsm.conf
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2781/ : SUCCESS
http://jenkins.ovirt.
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm: /etc/tmpfiles.d/vdsm.conf
..
vdsm: /etc/tmpfiles.d/vdsm.conf
systemd-tmpfiles uses the configuration files from /etc/tmpfiles.d to describe
t
Deepak C Shetty has posted comments on this change.
Change subject: volume: add the BLOCK_SIZE constant
..
Patch Set 2:
For file domains atleast, since its mounted, we can use statfs to get the
blocksize, instead of hardcoding
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: update python-pthreading
..
vdsm.spec: update python-pthreading
F19 and EL7 should require python-pthreading >= 1.0.2
Change-Id: Ie50a5
Douglas Schilling Landgraf has posted comments on this change.
Change subject: volume: add the BLOCK_SIZE constant
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14589
Dan Kenigsberg has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
(A very partial review)
.
Dan Kenigsberg has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15545
To unsubscribe, visit http://gerrit.ovirt
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 1: (5 inline comments)
File vdsm/init/daemonAdapter
Line 38:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2780/ : SUCCESS
http://jenkins.ovirt.org/j
Dan Kenigsberg has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2779/ : SUCCESS
http://jenkins.ovirt.org/j
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/277
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: Multiple Gateways Feature
..
Patch Set 12: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2776/ : SUCCESS
http://jenkins.ovir
oVirt Jenkins CI Server has posted comments on this change.
Change subject: iproute2 binary wrapper
..
Patch Set 10: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2778/ : SUCCESS
http://jenkins.ovirt.org/j
Assaf Muller has posted comments on this change.
Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks
..
Patch Set 2: (1 inline comment)
File vdsm
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Check image alignment using virt-alignment-scan
..
Patch Set 11:
1. the verb is an HSM vm-related verb where Image has no meaning: hotplugDisk,
Giuseppe Vallarelli has posted comments on this change.
Change subject: tests: Adding functional tests for networking
..
Patch Set 19: (5 inline comments)
Dan, thanks for the useful feedback I need to understand why that test i
Allon Mureinik has posted comments on this change.
Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.
..
Patch Set 14: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Yeela Kaplan has posted comments on this change.
Change subject: clientIF: Check image alignment using virt-alignment-scan
..
Patch Set 11:
Dan, you are right, I will add the schema.
Fede, as far as I recall, the API we agreed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: introducing virtio-scsi support
..
introducing virtio-scsi support
Drive class:
* makeName - map 'scsi' to 'sd'
* getXML:
- added 'sgio' flag [1]
- dev
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added 3.3 to SupportedENGINES in dsaversion
..
Added 3.3 to SupportedENGINES in dsaversion
Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911
Signed-
Dan Kenigsberg has posted comments on this change.
Change subject: Added 3.3 to SupportedENGINES in dsaversion
..
Patch Set 1: Looks good to me, approved
Very funny :-(
--
To view, visit http://gerrit.ovirt.org/15675
To unsub
Amador Pahim has posted comments on this change.
Change subject: Added 3.3 to SupportedENGINES in dsaversion
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15675
To unsubscribe, visit http://gerrit.ovirt.or
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Added 3.3 to SupportedENGINES in dsaversion
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.o
Amador Pahim has uploaded a new change for review.
Change subject: Added 3.3 to SupportedENGINES in dsaversion
..
Added 3.3 to SupportedENGINES in dsaversion
Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911
Signed-off-by: Am
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Adding functional tests for networking
..
Patch Set 19: Fails; I would prefer that you didn't submit this
(5 inline comments)
..
oVirt Jenkins CI Server has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2773/ : SUCCESS
http://jenkins.ovirt.org/job/vd
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for editBonding/removeBonding
..
Patch Set 9: (1 inline comment)
File vdsm/net
Dan Kenigsberg has posted comments on this change.
Change subject: Added 3.2 to SupportedENGINES in dsaversion
..
Patch Set 1: Looks good to me, approved
I believe this is indeed required due to vdsm's recent version bump. With
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added 3.2 to SupportedENGINES in dsaversion
..
Added 3.2 to SupportedENGINES in dsaversion
Change-Id: Ia3a0bd0edecd24a00edc0a5b07cad59d2c27bd7e
Signed-
Assaf Muller has posted comments on this change.
Change subject: Added 3.2 to SupportedENGINES in dsaversion
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15663
To unsubscribe, visit http://gerrit.ovirt.or
Assaf Muller has uploaded a new change for review.
Change subject: Added 3.2 to SupportedENGINES in dsaversion
..
Added 3.2 to SupportedENGINES in dsaversion
Change-Id: Ia3a0bd0edecd24a00edc0a5b07cad59d2c27bd7e
Signed-off-by: As
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 6:
modified the after/before_vm_dehibernate hooks to get parameters, and add
'backToSnapshot' parameter which is of boolean type
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsmd.init: ajust libvirt log file
..
vdsmd.init: ajust libvirt log file
Nowadays VDSM configure libvirt daemon to log into /var/log/libvirtd.log.
This
Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd.init: ajust libvirt log file
..
Patch Set 1: Looks good to me, approved
Thanks, Douglas.
--
To view, visit http://gerrit.ovirt.org/14842
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: extend "service" module to check existence of a
service
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15100
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-tool: extend "service" module to check existence of a
service
..
vdsm-tool: extend "service" module to check existence of a service
Add a service
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-tool: avoid service action redirections
..
vdsm-tool: avoid service action redirections
Some smart init system will redirect actions to other init
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: avoid service action redirections
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15099
To unsubscribe, visit h
Dan Kenigsberg has posted comments on this change.
Change subject: QoS feature: Adds bandwitdh elem to a network interface
definition.
..
Patch Set 5: Looks good to me, approved
Thanks, taken.
--
To view, visit http://gerrit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: QoS feature: Adds bandwitdh elem to a network interface
definition.
..
QoS feature: Adds bandwitdh elem to a network interface definition.
NetworkInte
Dan Kenigsberg has posted comments on this change.
Change subject: fix for after_vm_dehibernate hook not being called
..
Patch Set 1: Looks good to me, approved
Ouch. That's an old old bug. I wonder how it was missed for so lon
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fix for after_vm_dehibernate hook not being called
..
fix for after_vm_dehibernate hook not being called
Due to what seems to be a copy-paste or typo p
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fix for after_vm_dehibernate hook not being called
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2771/ : SUCCESS
ht
Yaniv Bronhaim has posted comments on this change.
Change subject: Added code coverage plugin
..
Patch Set 5:
Dan, don't you prefer to have default entries for coverage in config.py.in?
--
To view, visit http://gerrit.ovirt.o
Michal Skrivanek has posted comments on this change.
Change subject: fix for after_vm_dehibernate hook not being called
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Arik Hadas has posted comments on this change.
Change subject: fix for after_vm_dehibernate hook not being called
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/15656
To unsubscribe, visit http://gerrit.ovi
Arik Hadas has uploaded a new change for review.
Change subject: fix for after_vm_dehibernate hook not being called
..
fix for after_vm_dehibernate hook not being called
Due to what seems to be a copy-paste or typo problem, the
Zhou Zheng Sheng has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 10: I would prefer that you didn't submit this
(6 inline comments)
Some min
Alon Bar-Lev has posted comments on this change.
Change subject: vdsmd.init: Add init adapter
..
Patch Set 1: (6 inline comments)
Thanks!!!
Few more questions... sorry for me bothering you.
...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mom: add mom balloon functional tests for running vms
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2770/ : SUCCESS
Sergey Gotliv has posted comments on this change.
Change subject: vm: add the live diskSizeExtend method
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15614
To unsubs
Giuseppe Vallarelli has posted comments on this change.
Change subject: QoS feature: Adds bandwitdh elem to a network interface
definition.
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/15445
To unsubscri
oVirt Jenkins CI Server has posted comments on this change.
Change subject: QoS feature: Adds bandwitdh elem to a network interface
definition.
..
Patch Set 5: No score
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8
58 matches
Mail list logo