Release of libmygpo-qt 1.1.0 (Qt5 based)

[Stefan Derkits]

Dear Amarok, Clementine & gPodder Community,

after more than a year, a new version of libmygpo-qt is ready.

This version is the first one to use Qt5 by default, building with Qt4
is still possible but deprecated.

Changes in 1.1.0:
-) Deprecated Qt4 support, new mimimum Versions: Qt5.2, CMake 2.8.9
-) Improvements in Qt5 support (Thx to Maldela & Heiko Becker)
-) Fix in URL parsing, preventing Double Encoding of URLs

What is libmygpo-qt?

libmygpo-qt is a C++/Qt library wrapping the gpodder.net webservice. It
is used in Amarok & Clementine.

Where to get libmygpo-qt?

Tarball:
http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.1.0.tar.gz
sha256sum:
82765a9baa7b6bb3a3277759cec9c3779eee691db9180affe35a67813346e1cd
md5sum:
02c67ce51f025fcc5f71fbb4d6d029d6

Some more important Links for libmygpo-qt:

Project Website: http://wiki.gpodder.org/wiki/Libmygpo-qt
Git Repository: https://github.com/gpodder/libmygpo-qt
Doxygen Documentation: http://stefan.derkits.at/libmygpo-doc/
gpodder.net API: http://wiki.gpodder.org/wiki/Web_Services/API_2
Bug reports: http://bugs.gpodder.org
Contact: gpod...@freelists.org

Greetings,
Stefan




signature.asc
Description: OpenPGP digital signature

Re: D10831: Ported some services to Qt5/KF5

[Stefan Derkits]

Hi,

On 2018-02-25 14:05, Andreas Sturmlechner wrote:
>   Even though it may not be available on every distro out there yet (for lack 
> of consumers), `libmygpo-qt-1.0.9` supports Qt5 already. At least clementine 
> also makes use of it, but only in their qt5 branch.

Qt5 is supported and I think Qt4 is now dead enough to release a new Qt5
only version of libmygpo-qt. Afair it should work good enough with Qt5.
If you encounter any problems just let me know :)

Stefan



signature.asc
Description: OpenPGP digital signature

Release of libmygpo-qt v1.0.8

[Stefan Derkits]

Dear Amarok, Clementine & gPodder Community,

after more than two years, a new version of libmygpo-qt is ready.

First of all a big thanks to davidsandsome from Clementine for
submitting a total of 7 pull requests since the first version of
libmygpo-qt, 3 of them since 1.0.8

Changes in 1.0.9:
-) Different header installation directories for the qt4 & qt5 version
-) Bugfix: Top level include_install_dir is now respected (thanks to
rdieter)
-) Support for QJson 0.7 (thanks to davidsandsome)
-) Default to https instead of http (thanks to davidsandsome)
-) Bugfix: Allow setting the server URL (thanks to davidsandsome)

What is libmygpo-qt?

libmygpo-qt is a C++/Qt library wrapping the gpodder.net webservice. It
is used in Amarok & Clementine.

Where to get libmygpo-qt?

Tarball:
http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.0.9.tar.gz
sha256sum:
a44ae170ade90bb20c51328a0061929aa0bb2ef341327bf7cca2342bb7804ff3
md5sum:
aead5b0c6707f3e2bd2259cb1db2b7cd

Some more important Links for libmygpo-qt:

Project Website: http://wiki.gpodder.org/wiki/Libmygpo-qt
Git Repository: https://github.com/gpodder/libmygpo-qt
Doxygen Documentation: http://stefan.derkits.at/libmygpo-doc/
gpodder.net API: http://wiki.gpodder.org/wiki/Web_Services/API_2
Bug reports: http://bugs.gpodder.org
Contact: gpod...@freelists.org

Greetings,
Stefan



signature.asc
Description: OpenPGP digital signature

Re: Review Request 125940: Fix mygpo-qt5 library finding

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125940/#review87967
---



cmake/modules/FindLibmygpo-qt.cmake (line 18)
<https://git.reviewboard.kde.org/r/125940/#comment60350>

seems to be installed in a non-standard path by the distribution, because 
the standard path is mygpo-qt for both the qt4 & qt5 build :( which 
distribution are you using?
probably I should fix this upstream, bump the version number and then we 
can merge this review request


- Stefan Derkits


On Nov. 3, 2015, 9:46 p.m., Andrea Scarpino wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125940/
> ---
> 
> (Updated Nov. 3, 2015, 9:46 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> mygpo built with qt5 installs under /usr/include/mygpo-qt5 instead of 
> mygpo-qt.
> 
> 
> Also, update the module name used in CMakeLists.txt
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8cf9af3 
>   cmake/modules/FindLibmygpo-qt.cmake a1af542 
> 
> Diff: https://git.reviewboard.kde.org/r/125940/diff/
> 
> 
> Testing
> ---
> 
> mygpo-qt5 is found.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125940: Fix mygpo-qt5 library finding

[Stefan Derkits]

> On Nov. 3, 2015, 10:04 p.m., Stefan Derkits wrote:
> > cmake/modules/FindLibmygpo-qt.cmake, line 18
> > <https://git.reviewboard.kde.org/r/125940/diff/1/?file=414688#file414688line18>
> >
> > seems to be installed in a non-standard path by the distribution, 
> > because the standard path is mygpo-qt for both the qt4 & qt5 build :( which 
> > distribution are you using?
> > probably I should fix this upstream, bump the version number and then 
> > we can merge this review request
> 
> Andrea Scarpino wrote:
> Ah damn you are right :-(
> Seems libmygpo-qt5-git on Arch is patched to be co-installable with the 
> qt4 version.

I will apply the patch upstream as many distributions seem to have problems if 
two versions of a library (even though they have the same header) use the same 
include path


- Stefan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125940/#review87967
---


On Nov. 3, 2015, 9:46 p.m., Andrea Scarpino wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125940/
> ---
> 
> (Updated Nov. 3, 2015, 9:46 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> mygpo built with qt5 installs under /usr/include/mygpo-qt5 instead of 
> mygpo-qt.
> 
> 
> Also, update the module name used in CMakeLists.txt
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 8cf9af3 
>   cmake/modules/FindLibmygpo-qt.cmake a1af542 
> 
> Diff: https://git.reviewboard.kde.org/r/125940/diff/
> 
> 
> Testing
> ---
> 
> mygpo-qt5 is found.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125937: Port away from qjson

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125937/#review87964
---


Thanks for the review request. The problem is Playdar is dead (last commit & 
website entry were over 5 years ago) and was sort of succeeded by Tomahawk. So 
I don't know how much future the Playdar collection and with it this 
pull-request has.

- Stefan Derkits


On Nov. 3, 2015, 8:27 p.m., Andrea Scarpino wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125937/
> ---
> 
> (Updated Nov. 3, 2015, 8:27 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> We don't need anymore qjson. Use QJsonDocument instead.
> 
> 
> Diffs
> -
> 
>   cmake/modules/FindQJSON.cmake 5fafca5 
>   src/core-impl/collections/playdarcollection/CMakeLists.txt 06def29 
>   src/core-impl/collections/playdarcollection/support/Controller.cpp d584ac1 
>   src/core-impl/collections/playdarcollection/support/Query.cpp 5a28004 
> 
> Diff: https://git.reviewboard.kde.org/r/125937/diff/
> 
> 
> Testing
> ---
> 
> Build.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125394/#review85961
---

Ship it!


Ship It!

- Stefan Derkits


On Sept. 26, 2015, 11:41 a.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125394/
> ---
> 
> (Updated Sept. 26, 2015, 11:41 a.m.)
> 
> 
> Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam 
> Schweingruber.
> 
> 
> Repository: amarok
> 
> 
> Description
> ---
> 
> We need the Qt5 version of LibLastFm (ie liblastfm5) . Even after installing 
> the Qt5 version of the package, CMake showed not found.
> 
> 
> Diffs
> -
> 
>   cmake/modules/FindLibLastFm.cmake 8fa607b 
> 
> Diff: https://git.reviewboard.kde.org/r/125394/diff/
> 
> 
> Testing
> ---
> 
> Builds 100 %
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: kf5port(olivier)

[Stefan Derkits]

Hi,

On 2015-09-14 14:39, RISHABH GUPTA wrote:
> I complied liblastfm from the source(
> https://github.com/lastfm/liblastfm) ,this also didn't provide
> 'liblastfm5.so'. I am kubuntu15.04.What system are you on and how did you
> get liblastfm5?

I also use Kubuntu.

Reading [0], liblastfm tries to use Qt5 by default. Please do the following:
-) make sure you are on the current master branch of liblastfm
-) clean your liblastfm build dir
-) cmake .. (if build dir is a subdirectory of the source dir)
-) check if you get this message: "Found Qt5! Please keep in mind, this
is highly experimental and not our main development target.."

If you get this message, it should build liblasfm with the 5 suffix

Stefan

[0] https://github.com/lastfm/liblastfm/blob/master/CMakeLists.txt



signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: kf5 port(olivier)

[Stefan Derkits]

Hello,

On 2015-09-14 13:36, Aditya Sharma wrote:
> Something related to liblastfm I guess. I have already asked Stefan for
> what he did in the CMakeLists.txt . Waiting for a reply.
>  Backtrace 

you need to make sure that you have a qt5 based liblastfm
(liblastfm5.so). CMakeLists of the kf5 branch should only find and link
to liblastfm5. If your distribution doesn't have qt5 based liblastfm in
the packages you need to compile & install it from source.

You can check what libraries your amarok links to using the following
command: ldd amarok

Stefan



signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: kf5port(olivier)

[Stefan Derkits]

Hi,

On 2015-09-14 15:56, Aditya Sharma wrote:
> One more thing, did installing liblastfm5 overwrite the previous lasftm I
> had ?

no it didn't.

Can you check the output of: ldd amarok

Stefan



signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

KF5 port continued

[Stefan Derkits]

Hey,

thanks Somsubhra for making the port compile.

I compiled it and got a segfault related to liblastfm. Please note that
the Qt5 liblastfm is called liblastfm5.so, I changed this for lastfm &
mygpo-qt in CMakeLists

QJson is also not ported to Qt5 [there exists JSON functionality in Qt5
directly) (can someone find out if it is really only used for the
playdar collection?)

After these two CMake fixes, I get a segfault in:
main.cpp line 311

I think it is related to the following:
KAboutData is KF5 only but KUniqueApplication is KDELibs4Support only.
The KDELibs4Support version of KAboutData is k4aboutdata.h &
K4AboutData. Tried to only use k4aboutdata, Amarok has problems to
compile OcsData.h

So next porting steps seem to be:
Change to K4AboutData and see if it fixes this segfault or port away
from KUniqueApplication

Stefan



signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Idea for the porting

[Stefan Derkits]

Hey,

On 2015-08-30 02:07, Stefan Derkits wrote:
 amarok sql collection

Olivier and me narrowed down the problem why the sql collection  the
sql storage plugins were not buidling:

in StorageFactory.h

#define AMAROK_EXPORT_STORAGE( classname, libname ) \
K_PLUGIN_FACTORY( factory, registerPluginclassname(); ) \
K_EXPORT_PLUGIN( factory( amarok_storage- #libname ) )

1) no idea (after a bit of searching) where factory ever was defined
2) K_EXPORT_PLUGIN is deprecated and it seems the plugin system changed
also a bit

I found:
http://vizzzion.org/blog/2013/08/kde-frameworks-5-plugin-factory-guts/
which explains what has to be changed.
The problem:

I've tried to change the macro to K_PLUGIN_FACTORY( classname,
registerPluginlibname(); ) and removed K_EXPORT_PLUGIN but that
doesn't work that easy.

K_PLUGIN_FACTORY declares and defines the factory, so we would need to
move all code from our init method into the second argument of the macro.

Or, as there anyways already is a base Plugin Factory, just remove the
usage of K_PLUGIN_FACTORY and move the few lines of Code into PluginFactory.

Stefan



signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Idea for the porting

[Stefan Derkits]

Hi,

On 2015-08-30 00:47, Olivier Churlaud wrote:
 I tried to do this just to show you how it could be but it doesn't seem
 to be doable: everything is too connected...

I tried it to and seems good atm, see
http://commits.kde.org/amarok/1f01a5c9cbb1dc841004a800a2ce41353d049c80

I disabled: services, context, every collection except sql, importers

amaroklib is built  linked, make continues to  90 %

what doesn't work on my system: amarok sql collection (even though I
have libwrap  libaio installed, seems to be some build system failure)

attached you find my log in case someone wants to see it

Stefan
[  1%] [  1%] [  1%] [  2%] [  2%] Automatic moc for target amarokcore
Automatic moc for target amarok-transcoding
Automatic moc for target amarokpud
Automatic moc for target amarokshared
Automatic moc for target amarok
[  2%] [  2%] Built target amarok-transcoding_automoc
[  2%] Built target amarokcore_automoc
[  2%] Built target amarokshared_automoc
Built target amarokpud_automoc
[  2%] Built target amarok_automoc
[  2%] [  3%] [  3%] Automatic moc for target amarokocsclient
[  3%] Automatic moc for target amaroklib
[  3%] Automatic moc for target amarok_collection-mysqlcollection
Automatic moc for target amarok-sqlcollection
Automatic moc for target amarok_storage-mysqlestorage
[  3%] Built target amarokocsclient_automoc
[  3%] Built target amarok_collection-mysqlcollection_automoc
[  3%] Built target amarok_storage-mysqlestorage_automoc
[  3%] Built target amarok-sqlcollection_automoc
[  4%] Automatic moc for target amarok_storage-mysqlserverstorage
[  4%] Built target amarokpud
[  4%] Built target amarok_storage-mysqlserverstorage_automoc
[  7%] Built target amarokshared
[  7%] Built target amaroklib_automoc
[ 12%] Built target amarokocsclient
[ 20%] Built target amarokcore
[ 21%] Built target amarok-transcoding
[ 95%] Built target amaroklib
[ 95%] Built target amarok
Linking CXX shared module amarok_storage-mysqlserverstorage.so
Linking CXX shared module amarok_storage-mysqlestorage.so
[ 98%] Built target amarok-sqlcollection
Linking CXX shared module amarok_collection-mysqlcollection.so
/usr/bin/ld: cannot find -lwrap
/usr/bin/ld: cannot find -laio
collect2: error: ld returned 1 exit status
src/core-impl/collections/db/sql/mysqlcollection/CMakeFiles/amarok_collection-mysqlcollection.dir/build.make:137:
 recipe for target 
'src/core-impl/collections/db/sql/mysqlcollection/amarok_collection-mysqlcollection.so'
 failed
make[2]: *** 
[src/core-impl/collections/db/sql/mysqlcollection/amarok_collection-mysqlcollection.so]
 Error 1
CMakeFiles/Makefile2:1529: recipe for target 
'src/core-impl/collections/db/sql/mysqlcollection/CMakeFiles/amarok_collection-mysqlcollection.dir/all'
 failed
make[1]: *** 
[src/core-impl/collections/db/sql/mysqlcollection/CMakeFiles/amarok_collection-mysqlcollection.dir/all]
 Error 2
make[1]: *** Waiting for unfinished jobs
/usr/bin/ld: cannot find -lwrap
/usr/bin/ld: cannot find -laio
collect2: error: ld returned 1 exit status
src/core-impl/storage/sql/mysqlestorage/CMakeFiles/amarok_storage-mysqlestorage.dir/build.make:162:
 recipe for target 
'src/core-impl/storage/sql/mysqlestorage/amarok_storage-mysqlestorage.so' failed
make[2]: *** 
[src/core-impl/storage/sql/mysqlestorage/amarok_storage-mysqlestorage.so] Error 
1
CMakeFiles/Makefile2:1635: recipe for target 
'src/core-impl/storage/sql/mysqlestorage/CMakeFiles/amarok_storage-mysqlestorage.dir/all'
 failed
make[1]: *** 
[src/core-impl/storage/sql/mysqlestorage/CMakeFiles/amarok_storage-mysqlestorage.dir/all]
 Error 2
CMakeFiles/amarok_storage-mysqlserverstorage.dir/MySqlServerStorageFactory.cpp.o:
 In function `factory::factory()':
/home/horrendus/src/amarok/src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp:23:
 undefined reference to `vtable for factory'
CMakeFiles/amarok_storage-mysqlserverstorage.dir/MySqlServerStorageFactory.cpp.o:
 In function `factory::~factory()':
/home/horrendus/src/amarok/src/core-impl/storage/sql/mysqlserverstorage/MySqlServerStorageFactory.cpp:23:
 undefined reference to `vtable for factory'
collect2: error: ld returned 1 exit status
src/core-impl/storage/sql/mysqlserverstorage/CMakeFiles/amarok_storage-mysqlserverstorage.dir/build.make:162:
 recipe for target 
'src/core-impl/storage/sql/mysqlserverstorage/amarok_storage-mysqlserverstorage.so'
 failed
make[2]: *** 
[src/core-impl/storage/sql/mysqlserverstorage/amarok_storage-mysqlserverstorage.so]
 Error 1
CMakeFiles/Makefile2:1723: recipe for target 
'src/core-impl/storage/sql/mysqlserverstorage/CMakeFiles/amarok_storage-mysqlserverstorage.dir/all'
 failed
make[1]: *** 
[src/core-impl/storage/sql/mysqlserverstorage/CMakeFiles/amarok_storage-mysqlserverstorage.dir/all]
 Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2


signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org

Re: Help wanted to evolve KDEs music players

[Stefan Derkits]

Hi,

On 2015-07-31 23:43, kainz.a wrote:
 what's the problem with using Amarok? In kde4 times they are the first
 application that use plasma. now I think an qt 5 port is still open so this
 would be the perfect time to get into an redesign isn't it? If the amarok
 developers don't like an redesign (what I can understand, because the last
 redesign was not that fun) maybe with the port to qt5 the UI can be more
 separate so a lot of code can be shared.

as I wrote in my previous mails, nothing is set in stone yet.

But this will (most probably) not be something like Amarok 3. Why not?
One thing is that you can't throw away probably 70 % of the features,
never ever accept those features back into the application (remember:
This should be a simple music player, designed for standard users of
Plasma 5, not users that want to use tons of features in their music
player) and call it Amarok.

Codebase could probably be shared, but it seems easier to start from a
simpler (e.g. the PMC) codebase. But that is a technical decision that
will be done when a team has formed :)

 baloo integration is for me a must, because plasma offers this and so we
 should use it.

If using baloo fits into the vision (which I think would fit because
non-experienced users maybe don't know where there music is), why not
use it. PMC uses it, Bangarang used Nepomuk.

Stefan




signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Help wanted to evolve KDEs music players

[Stefan Derkits]

Hi,

On 2015-07-30 14:08, Martin Steigerwald wrote:
 Why a new one? Aren´t none of the existing ones in a state that they can´t be 
 evolved into what you envision?

 There is already Amarok, JuK, Bangarang, Clementine, Plasma Media Center and 
 you name it. As a user I am confused. Which do I use? Well for me I started 
 with Amarok and I really do like it a lot, just want to see it modernized 
 instead of looking at all the others to find out which new one to use.

At the moment the only thing we have is a design vision. Of course this
vision replaces most of the things that JuK and Bangarang does. Also
Andrew Lake is the Creator of Bangarang and he is the one who started
the UI mockups  vision development, so you can see it as a replacement
of Bangarang (probably with a new name). JuK has a simillar feature set
than what is planned, but I don't know in what shape the codebase is.

Stefan



signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Help wanted to evolve KDEs music players

[Stefan Derkits]

Hello Teo,

On 2015-07-30 13:30, Teo Mrnjavac wrote:
 Have you thought about picking up and taking over Amarok? A quick look at the 
 commit log for the past few months suggests that it's essentially 
 unmaintained, so if it keeps this pace it's unlikely to stay the swiss-knife 
 of music players as you suggest.
 
 This stuff is hard and time consuming so I think it makes sense to reuse code.
 
 While Amarok does have a sizeable feature set, a good portion of those 
 features are either poorly designed, broken or outdated. Perhaps by taking 
 over as maintainer, yanking out all the cruft and taking UX hints from the 
 VDG 
 you could get a modern and pretty music player up and running more quickly 
 and 
 easily than jumping into the umpteenth magic rewrite that will fix all 
 things 
 forever. You could cut down on the feature set significantly, and present 
 the 
 features that you don't remove in a much better way.

thanks for your answer.

I was definitly thinking about starting (actually I don't feel confident
enough to create the architecture) from an existing codebase, but
probably not from the Amarok codebase (except of reusing some parts). I
also talked with strohel at Akademy who has a better knowledge of the
codebase and his opinion was that UI  backendcode are too much
intertwined to allow replacing the UI easily.

What I don't want to do is to take over Amarok. While it is true that
Amarok is pretty much unmaintained, I don't think a player that has
maybe only a third of the features should be called Amarok.

Codebases I feel that are small and could be a good starting point
(better evaluation is of course needed):
-) Bangarang
-) JuK

And of course inspiration, GPL code and experience can be shared with
many other music players.

Stefan



signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Help wanted to evolve KDEs music players

[Stefan Derkits]

Hello,

On 2015-07-30 12:42, Stefan Derkits wrote:
 What do we need:
 -) More People to discuss  flesh out the vision [1]
 -) A motivated team of designers, software architects, coders  testers,
 dedicated to creating a modern music player for our users

thank you all for your feedback, suggestions  offers for help.

I've decided to move the discussion about this to the (until now unused)
kde multimedia mailinglist, if you are interested, please join it [0].

Also we could use #kde-multimedia IRC channel on freenode for further
discussions (my nick is HorusHorrendus).

Stefan

[0] https://mail.kde.org/mailman/listinfo/kde-multimedia



signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 122797: Fix Gpodder credential service without kwallet

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122797/#review76967
---

Ship it!


Looks good to me. Shipt it, but before please fix that the credentials are not 
saved when the user clicks no.


src/services/gpodder/GpodderServiceConfig.cpp
https://git.reviewboard.kde.org/r/122797/#comment52950

This slot is called when the user clicks on no in the dialog asking if the 
credentials should be stored in plaintext. This means that the credentials 
shouldn't be saved when this slot is called.


- Stefan Derkits


On March 3, 2015, 9:14 p.m., Giuseppe Silletti wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122797/
 ---
 
 (Updated March 3, 2015, 9:14 p.m.)
 
 
 Review request for Amarok.
 
 
 Repository: amarok
 
 
 Description
 ---
 
 Before to fix this bug, the gpodder plugin had problems with saving username 
 and password in plain text. 
 
 There were two problems: 
 
 1) A useless space for the variable m_ignoreWallet was saved in the config 
 file 
 2) The saving of the credential in plain text where made in the wrong way. 
 Now it is called the function askAboutMissingKWallet(), that make the use see 
 a dialog windows where is asked to save the credential in plain text. 
 Credential are now saved in the textDialogYes slot.
 
 
 Diffs
 -
 
   src/services/gpodder/GpodderServiceConfig.cpp 9098d59 
 
 Diff: https://git.reviewboard.kde.org/r/122797/diff/
 
 
 Testing
 ---
 
 It simply works now
 
 
 Thanks,
 
 Giuseppe Silletti
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Newbie, Looking for Work

[Stefan Derkits]

Hi Justin,

On 2014-05-30 16:46, Justin Thomas wrote:
 - Is there something completely different that a beginner, like me,
 should try to tackle?

apart from the Junior Jobs a good place to start is by finding something
that you would like to improve. Some small feature that you think is
missing or that you would really like to have in Amarok.
Maybe you already heard of this phrase, but this is called scratching
your own itch.

And let me tell you, this is a real fun way to start because you know
you like the outcome and make Amarok better for your (and probably also
others) need.

Stefan




signature.asc
Description: OpenPGP digital signature
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 110426: KWalletHelper class for services using the KWallet

[Stefan Derkits]

 On Aug. 26, 2013, 7:07 p.m., Vedant Agarwala wrote:
  Fixed the problems and incorporated Matej's patch.
  
  Builds, passes tests and runs now. I didn't test it fully. I ran Amarok 
  with this patch and at Amarok start-up I got the KWallet Dialog for Amarok 
  (Do you want to allow Amarok to access KWallet?). I selected Allow 
  always and Amarok is working fine. Some more testing with all the cases 
  (missing KWallet, denying usage of KWallet, and working previously save 
  config) might be a good idea.

Less code dupliation sounds good ... it would be a good idea to maybe change 
from using pure KWallet to using the QtKeychain (library for Mac OS Keychain, 
Gnome Keyring, KWallet and secure password Storage on Windows). While this is 
probably not the scope of this patch, now could be a good time to do this 
change (if the other devs agree). Also in the gpodder service you forgot in the 
constructor of GpodderServiceConfig m_enableProvider( false ) ... please add 
this again (explicitly initializing it in the constructor makes things more 
clear)


- Stefan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110426/#review38691
---


On Aug. 26, 2013, 7:03 p.m., Vedant Agarwala wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/110426/
 ---
 
 (Updated Aug. 26, 2013, 7:03 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 I have created a KWalletHelper class so that services like Maganatune, 
 Last.fm and GPodder can use this rather than duplicating code.
 Currently the patch applies only to Magnatune. The KWalletHelper class 
 complies but it doesn't link properly to the MagnatuneConfig class.
 
 
 Diffs
 -
 
   src/CMakeLists.txt d7d11f9 
   src/services/KWalletHelper.h PRE-CREATION 
   src/services/KWalletHelper.cpp PRE-CREATION 
   src/services/gpodder/GpodderServiceConfig.h 90447fd 
   src/services/gpodder/GpodderServiceConfig.cpp 9098d59 
   src/services/gpodder/GpodderServiceSettings.cpp 34280c7 
   src/services/lastfm/CMakeLists.txt a895bba 
   src/services/lastfm/LastFmServiceConfig.h 4b1552e 
   src/services/lastfm/LastFmServiceConfig.cpp 9912b22 
   src/services/magnatune/CMakeLists.txt 91f24c0 
   src/services/magnatune/MagnatuneConfig.h 552bcf8 
   src/services/magnatune/MagnatuneConfig.cpp 5842c63 
   src/services/magnatune/MagnatuneDownloadHandler.h b257440 
   src/services/magnatune/MagnatuneDownloadHandler.cpp 3bce597 
   src/services/magnatune/MagnatuneInfoParser.h 7904b67 
   src/services/magnatune/MagnatuneInfoParser.cpp f10ad13 
   src/services/magnatune/MagnatuneNeedUpdateWidget.cpp 044cf4b 
   src/services/magnatune/MagnatuneRedownloadHandler.cpp 99c1a54 
   src/services/magnatune/MagnatuneSettingsModule.h 4728a34 
   src/services/magnatune/MagnatuneSettingsModule.cpp d45938f 
   src/services/magnatune/MagnatuneStore.h c143d59 
   src/services/magnatune/MagnatuneStore.cpp 2863c5b 
 
 Diff: http://git.reviewboard.kde.org/r/110426/diff/
 
 
 Testing
 ---
 
 The KWalletHelper.cpp complies but fails to link to ManatuneConfig.cpp. 
 Output of make command: http://paste.kde.org/743792/
 
 
 Thanks,
 
 Vedant Agarwala
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 110101: fixes Bug 242256 - JJ: Make Magnatue service use KWallet for password storage

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

On 04/27/2013 11:45 AM, Vedant Agarwala wrote:
 I agree. I will upload another patch making changes to both last.fm
 and magnatune code. I was thinking of a common helper class
 complete with the no KWallet found dialog. Tell me any other
 specifics that should be a part of this KWalletHelper class.

a common KWallet Helper Class (if possible) sounds good, the
GpodderService uses KWallet code that at the time of the creation of
the code was more or less a copy of the last.fm Wallet Code. So maybe
the GpodderService could also be a Candidate for using this
KWalletHelper class ;)

Greetings,
Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlF7pssACgkQlZvAMV/NgGLEkQCgoai1Bi/PzZ4H6P1iNPQ4q42X
b3wAn1SsfeE/9ipouiiVLBtNFB9WDzUg
=5o1m
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Release of libmygpo-qt v1.0.7

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear Amarok, Clementine  gPodder Community,

after exactly half a year, a new version of libmygpo-qt is ready.

Changes in 1.0.7:
- -) New Config Class. This class allows to programmatically to retrieve the
libmygpo-qt version and retrieve and set the gpodder.net API endpoint
(e.g. if you test your
software against a private instance of gpodder.net)
- -) Config Class also allows to set a prefix to the user-agent. Please
never completely overwrite the user-agent set in libmygpo-qt (instead
pre/append your own, e.g. via mygpo::Config::setUserAgentPrefix( ... ) )
- -) fixed a bug that created incomplete Episode Actions if an Episode
Action couldn't be parsed completely by libmygpo-qt
- -) fixed a small bug with the pkgconfig file (thx to davidsansome)
- -) added support for uploading  retrieving flattr Episode Actions to
gpodder.net (this allows you to automatically flattr Podcast Episodes
from any podcatcher that uses libmygpo-qt)

Where to get libmygpo-qt?

Tarball:
http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.0.7.tar.gz
sha256sum:
faade78e1baeeab7f858dec80530ad63c50f683fe511948ab1a45e685828cc74
md5sum:
447e60c8c695b4280a0e20c71abacf49

Some more important Links for libmygpo-qt:

Project Website: http://wiki.gpodder.org/wiki/Libmygpo-qt
Git Repository: https://github.com/gpodder/libmygpo-qt
Doxygen Documentation: http://stefan.derkits.at/libmygpo-doc/
gpodder.net API: http://wiki.gpodder.org/wiki/Web_Services/API_2
Bug reports: http://bugs.gpodder.org
Contact: gpod...@freelists.org

Want to support libmygpo-qt?

You can support the development of libmygpo-qt you can flattr [0] me or
donate via paypal to ste...@derkits.at
You can also send me a book via my Amazon Wishlist [1]

- - --- Infos about libmygpo-qt ---

What is libmygpo-qt?

libmygpo-qt is a Qt/C++ library wrapping the gpodder.net Webservice.
It is currently used in Amarok  Clementine to retrieve a directory of
podcasts  to synchronize podcast subscriptions with gpodder.net

Greetings,
Stefan

[0] https://flattr.com/thing/1250603/Horrendus-on-GitHub
[1] http://www.amazon.de/registry/wishlist/2C1RXFXGF5RMS
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlFpUcsACgkQlZvAMV/NgGLtkACfaz16lfzsXfFP3UhymdnAWIad
Tt4AoIVylJ0tp71fFn16I5VObEi2kO32
=pD6S
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: GSoC 2013 proposals needed

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi all,

On 02/12/2013 01:00 PM, Myriam Schweingruber wrote:
 Hi all,
 
 GSoC 2013 will happen and we need proposals for it. Please add
 them, ideally with a mentor who can volunteer, to this wiki page:

while you are at it, if you have any proposals for a project to be
done between March and June by a group of 4 - 6 students (estimated
workload for them: ~ 150 hours [incl. projectmanagament]) please tell me.

Because additionally to tutoring (Tutor as in Teaching Assistant, my
role is to meet the team personally every week and reviewing their
progress) a general course about Software Engineering  Project
Managment using C++/Qt I tutored last term two groups in a course
about Advanced Software Engineering (free choice of technology, free
choice of project).

Some of the Groups in Advanced Software Engineering have no idea at
the start of the term what they want to do and sometimes they just
choose the 100th BusinessApp (either for a company that anyways will
never use it unless they put another tons of hours in it or to throw
it away at the end of the term) and so it's always good to have some
OpenSource projects available. And it's also a good opportunity for
OpenSource projects to recruit new developers into
Amarok/KDE/OpenSource generally (just take me as an example ;) ).

If you have any questions, just mail me or ask me on IRC (HorusHorrendus).

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAlEaNX4ACgkQlZvAMV/NgGITagCgxTIioxxtnHUS8YNpbquUQ7iF
oj0An38AQJfXKOypbYYpapol0e3yJUht
=BZM1
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

libmygpo-qt Release of v1.0.6

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear Amarok, Clementine  gPodder Community,

long time (nearly a year) passed since the last libmygpo-qt release.
Today there was the first gPodder hackday (of many more to come) and
so it was time to fix some bugs, test the library a little bit and
make a new release ;)

I'm looking for contributors, so if you wanna work on a
interesting library used atm by Amarok, Clementine  Nokia Podcasts,
drop me a line ;)

Changes in 1.0.6:
- -) added support for DeviceSync API [0]. This API makes it possible to
set up synchronization with existing gpodder.net devices from inside
your application
- -) set Contenttype Header to avoid warnings with Qt 4.8
- -) some fixes  enhancements to CMake build system

Where to get libmygpo-qt?

Tarball:
http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.0.6.tar.gz
md5sum: dd07ccc88eac954a3860aeda96aab7b1
sha1sum: 7970c4c43cab4862e220b4239491f2bac2c36f75

Some more important Links for libmygpo-qt:

Project Website: http://wiki.gpodder.org/wiki/Libmygpo-qt
Git Repo: https://github.com/gpodder/libmygpo-qt
Doxygen Documentation: http://stefan.derkits.at/libmygpo-doc/
gpodder.net API: http://wiki.gpodder.org/wiki/Web_Services/API_2
Bugreports: http://bugs.gpodder.org
Contact: gpod...@freelists.org

- - --- Infos about libmygpo-qt ---

What is libmygpo-qt?

libmygpo-qt is a Qt/C++ Library wrapping the gPodder.net Webservice. It
was created as part of a University Course  it is used in
Amarok (since 2.4.1) with the new gpodder.net
Service, that makes the gpodder.net Podcast Directory available from
within Amarok. Also it is used in Nokia Podcasts and will be used in
Clementine from v1.1 onwards.


Greetings,
Stefan

[0] http://wiki.gpodder.org/wiki/Web_Services/API_2#Device_Synchronisation
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAlB5lJAACgkQlZvAMV/NgGItewCfcTsV3rJtlrEM3UxS5iiNNhP3
5QUAoNKmG4AoCYIdRUavLOP9voeAqcWi
=aGBb
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: liblastfm1 port

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105276/#review14826
---


one problem I see are the dependencies of liblastfm 1.0, esp. Qt 4.8

- Stefan Derkits


On June 16, 2012, 10:50 p.m., Harald Sitter wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105276/
 ---
 
 (Updated June 16, 2012, 10:50 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 port to liblastfm1, mind that this is slightly api incompatible with 
 liblastfm0, and retaining ifdef compat does not seem worthwhile given the 
 fact that latter uses exceptions and former does not
 
 
 Diffs
 -
 
   src/services/ampache/LastfmInfoParser.cpp 
 50cb529516ce1358785fa04824cd32642a526495 
   src/services/lastfm/LastFmService.cpp 
 a14d989b3fac81e545df095adee36580b052fea7 
   src/services/lastfm/LastFmServiceCollection.cpp 
 22f49ec0fe8e9f917f8a26f9d546ad147ad04e5b 
   src/services/lastfm/LastFmServiceSettings.cpp 
 2eff71e51dc30605b4d395323a01e24b8fa25d1e 
   src/services/lastfm/LastFmTreeModel.h 
 ac171a57a36ec6bb5443035b11bea77e4ae94720 
   src/services/lastfm/LastFmTreeModel.cpp 
 2d94d67c5fe10bfc1abba3dd9848fd1177daa518 
   src/services/lastfm/ScrobblerAdapter.h 
 67ed73b291cef61ee37b0ddae28ba1eadfd6304d 
   src/services/lastfm/biases/LastFmBias.cpp 
 b011b3299f98d851109d3d9ba52e6fd09855dcff 
   src/services/lastfm/biases/WeeklyTopBias.cpp 
 df6dd6681f05d95a0e281d6e82224de2bbf001e6 
   src/services/lastfm/meta/LastFmMeta.h 
 f7b93c14c92c0bebf99d165656a0e34f8b991cc0 
   src/services/lastfm/meta/LastFmMeta.cpp 
 d8f52845cb801d8ae940bc1bca77c7281ef18379 
   src/services/lastfm/meta/LastFmMeta_p.h 
 c2d88ac79a4dd0fe59b9f889baf72c879833f0d3 
   src/services/lastfm/meta/MultiPlayableCapabilityImpl_p.h 
 1c464cc2635c7d614eab48ca5e4e156c67870f04 
   src/context/engines/upcomingevents/UpcomingEventsEngine.cpp 
 4ae73d892cef3d4a41662f7ed15849ae773c16e3 
   src/core/support/Amarok.h c9852154dee74fb372bae435fdeefa92003d41b1 
   CMakeLists.txt 0d146c58bd382b4d4f379ebedddf1630d73db369 
   cmake/modules/FindLibLastFm.cmake 1d863b08489e27054a049e35d2d94667646db1f7 
   src/LastfmReadLabelCapability.cpp 385e6b9c065009b330e116e3d748b82c24f14e8d 
 
 Diff: http://git.reviewboard.kde.org/r/105276/diff/
 
 
 Testing
 ---
 
 [~] login test in settings (for some reason the service does not pick up 
 changes there until restart, which seems actually architectural as the KCM 
 does not trigger reinitialization of the service)
 [+] streaming
   [+] love
   [+] ban
   [+] next
 [+] friends/neighbors
 [+] upcoming events plasmoid
 [+] related artists plasmoid
 
 
 Thanks,
 
 Harald Sitter
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: liblastfm1 port

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105276/#review14803
---


code looks good, pretty straightforward port. definitly good idea to use 
liblastm-1.0.

- Stefan Derkits


On June 16, 2012, 10:50 p.m., Harald Sitter wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105276/
 ---
 
 (Updated June 16, 2012, 10:50 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 port to liblastfm1, mind that this is slightly api incompatible with 
 liblastfm0, and retaining ifdef compat does not seem worthwhile given the 
 fact that latter uses exceptions and former does not
 
 
 Diffs
 -
 
   src/services/ampache/LastfmInfoParser.cpp 
 50cb529516ce1358785fa04824cd32642a526495 
   src/services/lastfm/LastFmService.cpp 
 a14d989b3fac81e545df095adee36580b052fea7 
   src/services/lastfm/LastFmServiceCollection.cpp 
 22f49ec0fe8e9f917f8a26f9d546ad147ad04e5b 
   src/services/lastfm/LastFmServiceSettings.cpp 
 2eff71e51dc30605b4d395323a01e24b8fa25d1e 
   src/services/lastfm/LastFmTreeModel.h 
 ac171a57a36ec6bb5443035b11bea77e4ae94720 
   src/services/lastfm/LastFmTreeModel.cpp 
 2d94d67c5fe10bfc1abba3dd9848fd1177daa518 
   src/services/lastfm/ScrobblerAdapter.h 
 67ed73b291cef61ee37b0ddae28ba1eadfd6304d 
   src/services/lastfm/biases/LastFmBias.cpp 
 b011b3299f98d851109d3d9ba52e6fd09855dcff 
   src/services/lastfm/biases/WeeklyTopBias.cpp 
 df6dd6681f05d95a0e281d6e82224de2bbf001e6 
   src/services/lastfm/meta/LastFmMeta.h 
 f7b93c14c92c0bebf99d165656a0e34f8b991cc0 
   src/services/lastfm/meta/LastFmMeta.cpp 
 d8f52845cb801d8ae940bc1bca77c7281ef18379 
   src/services/lastfm/meta/LastFmMeta_p.h 
 c2d88ac79a4dd0fe59b9f889baf72c879833f0d3 
   src/services/lastfm/meta/MultiPlayableCapabilityImpl_p.h 
 1c464cc2635c7d614eab48ca5e4e156c67870f04 
   src/context/engines/upcomingevents/UpcomingEventsEngine.cpp 
 4ae73d892cef3d4a41662f7ed15849ae773c16e3 
   src/core/support/Amarok.h c9852154dee74fb372bae435fdeefa92003d41b1 
   CMakeLists.txt 0d146c58bd382b4d4f379ebedddf1630d73db369 
   cmake/modules/FindLibLastFm.cmake 1d863b08489e27054a049e35d2d94667646db1f7 
   src/LastfmReadLabelCapability.cpp 385e6b9c065009b330e116e3d748b82c24f14e8d 
 
 Diff: http://git.reviewboard.kde.org/r/105276/diff/
 
 
 Testing
 ---
 
 [~] login test in settings (for some reason the service does not pick up 
 changes there until restart, which seems actually architectural as the KCM 
 does not trigger reinitialization of the service)
 [+] streaming
   [+] love
   [+] ban
   [+] next
 [+] friends/neighbors
 [+] upcoming events plasmoid
 [+] related artists plasmoid
 
 
 Thanks,
 
 Harald Sitter
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: liblastfm1 port

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105276/#review14804
---



src/services/lastfm/meta/LastFmMeta_p.h
http://git.reviewboard.kde.org/r/105276/#comment11656

a small change would improve consistency here, change the code to:

if( lfm.parse(...) )
{
  do stuff
}
else
{
  debug
}

(like all the other error handling is done)


- Stefan Derkits


On June 16, 2012, 10:50 p.m., Harald Sitter wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105276/
 ---
 
 (Updated June 16, 2012, 10:50 p.m.)
 
 
 Review request for Amarok.
 
 
 Description
 ---
 
 port to liblastfm1, mind that this is slightly api incompatible with 
 liblastfm0, and retaining ifdef compat does not seem worthwhile given the 
 fact that latter uses exceptions and former does not
 
 
 Diffs
 -
 
   src/services/ampache/LastfmInfoParser.cpp 
 50cb529516ce1358785fa04824cd32642a526495 
   src/services/lastfm/LastFmService.cpp 
 a14d989b3fac81e545df095adee36580b052fea7 
   src/services/lastfm/LastFmServiceCollection.cpp 
 22f49ec0fe8e9f917f8a26f9d546ad147ad04e5b 
   src/services/lastfm/LastFmServiceSettings.cpp 
 2eff71e51dc30605b4d395323a01e24b8fa25d1e 
   src/services/lastfm/LastFmTreeModel.h 
 ac171a57a36ec6bb5443035b11bea77e4ae94720 
   src/services/lastfm/LastFmTreeModel.cpp 
 2d94d67c5fe10bfc1abba3dd9848fd1177daa518 
   src/services/lastfm/ScrobblerAdapter.h 
 67ed73b291cef61ee37b0ddae28ba1eadfd6304d 
   src/services/lastfm/biases/LastFmBias.cpp 
 b011b3299f98d851109d3d9ba52e6fd09855dcff 
   src/services/lastfm/biases/WeeklyTopBias.cpp 
 df6dd6681f05d95a0e281d6e82224de2bbf001e6 
   src/services/lastfm/meta/LastFmMeta.h 
 f7b93c14c92c0bebf99d165656a0e34f8b991cc0 
   src/services/lastfm/meta/LastFmMeta.cpp 
 d8f52845cb801d8ae940bc1bca77c7281ef18379 
   src/services/lastfm/meta/LastFmMeta_p.h 
 c2d88ac79a4dd0fe59b9f889baf72c879833f0d3 
   src/services/lastfm/meta/MultiPlayableCapabilityImpl_p.h 
 1c464cc2635c7d614eab48ca5e4e156c67870f04 
   src/context/engines/upcomingevents/UpcomingEventsEngine.cpp 
 4ae73d892cef3d4a41662f7ed15849ae773c16e3 
   src/core/support/Amarok.h c9852154dee74fb372bae435fdeefa92003d41b1 
   CMakeLists.txt 0d146c58bd382b4d4f379ebedddf1630d73db369 
   cmake/modules/FindLibLastFm.cmake 1d863b08489e27054a049e35d2d94667646db1f7 
   src/LastfmReadLabelCapability.cpp 385e6b9c065009b330e116e3d748b82c24f14e8d 
 
 Diff: http://git.reviewboard.kde.org/r/105276/diff/
 
 
 Testing
 ---
 
 [~] login test in settings (for some reason the service does not pick up 
 changes there until restart, which seems actually architectural as the KCM 
 does not trigger reinitialization of the service)
 [+] streaming
   [+] love
   [+] ban
   [+] next
 [+] friends/neighbors
 [+] upcoming events plasmoid
 [+] related artists plasmoid
 
 
 Thanks,
 
 Harald Sitter
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Tidying up password storage in Amarok

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

On 04/10/2012 07:21 PM, Matěj Laitl wrote:
 Hmm, I may want to allow storing last.fm password in plain-text
 while disabling to store MySQL pass in plain-text. The confirmation
 should be probably per-plugin then.

that sounds a little bit not so user-friendly (having to confirm
secure storage for every plugin).
I would suggest to always take the most secure storage available,
without any config options or per plugin options.
If I have a secure password store like KWallet why would I want to
save any password in plain text?

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk+Ec5cACgkQlZvAMV/NgGISmwCfSnJUL9KiTaGIUj9zo7xOy/FS
DwkAniFWoP3KivWSVCgKOx9sT96rTU6n
=CAwO
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Tomahawk features in Amarok Proposal

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

one thing you should add to your proposal:

If you are experienced in developing features that require
communication with more than one project partner (and I know you
are, cause your last SoC was between Amarok  gpodder ;) )

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk90Ii4ACgkQlZvAMV/NgGJ/6gCgpCm0+arbHJb7GJqIMnMIzPa8
KeEAniBLwpFBIo8B5wIG2p9YgBFTPmzN
=xcOb
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Amarok idea Tomahawk features

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

 If you think that my reasons haven't enough sense that would be ok.
 As I said there is no problems for me in using jreen but I'm not
 sure that it has enough features for implementation.

Tomahawk Devs worked with Jreen to get it working for their use-case.
We don't know if QtXMPP  libjingle will work for the same use-cases
(which are pretty specific sometimes).

Why discuss with Tomahawk?

Well this project aims to make these Amarok Features compatible to
Tomahawk (so that I can listen to Collections from People using
Tomahawk), so of course this should be talked over also with the
People from Tomahawk. Maybe you can reuse their code, maybe they can
give you tips, ...

It seems to me you didn't give your propsal much thought, you didn't
investigate much, probably you should go on IRC and talk with all
involved communities (Amarok  Tomahawk) and make a better proposal ;)

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk90I7sACgkQlZvAMV/NgGJ+hgCaA+Fmpu0fYKRKqolK8usg/9sP
JCYAoMJTZpNAgPpZ2iRAPEliu1n75nYp
=Juxn
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Amarok idea Tomahawk features

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

 Here's my proposal, I also need a little feedback about it *) 
 https://docs.google.com/document/d/1XCIZvcssg3DVjGZAr-vZyLBOandf3zPBbNLcKk3xowA/edit

any
 
reason for using QXmpp  libjingle instead jreen [0], that is used
by Tomahawk?
Did you discuss this proposal with Tomahawk?

Stefan

[0] https://github.com/euroelessar/jreen
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk9yvV0ACgkQlZvAMV/NgGI8LACfSZ/DS9tUTt/yM+ozALYYOFaJ
MIkAn1YcLLEEaxJbOuJQBD60ezW61otQ
=quGs
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: GPodder Improvements Patch Rev1

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104335/#review11658
---

Ship it!


only looked at the code, didn't try out yet ... code looks fine


ChangeLog
http://git.reviewboard.kde.org/r/104335/#comment9256

a expected - an expected

so as to synchronize - to snychronise (or change synchronisation to 
synchronization)




src/services/gpodder/GpodderService.cpp
http://git.reviewboard.kde.org/r/104335/#comment9259

maybe merge this debug output into one line



src/services/gpodder/GpodderServiceConfig.cpp
http://git.reviewboard.kde.org/r/104335/#comment9253

what about suggestions? they also need user  password


- Stefan Derkits


On March 19, 2012, 8 p.m., Lucas Gomes wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/104335/
 ---
 
 (Updated March 19, 2012, 8 p.m.)
 
 
 Review request for Amarok, Stefan Derkits and Bart Cerneels.
 
 
 Description
 ---
 
 GPodder Improvements Patch Rev1
 
 Put messages to show that gpodder service failed to get data from
 gpodder.net. Done some cleanup and added some comments.
 
 GPodder Service improvements
 
 Full status synchronisation implemented. Cleanup and some refactoring.
 GPodder Provider saves podcast subscriptions changes if the user closes
 amarok before a expected synchronisation to end, so as to synchronize them
 in the next start. Forcing GPodderService to verify if the username and
 password is not empty before creating a mygpo::ApiRequest. Solved some
 problems related to the KWallet use in GPodderService.
 
 
 Diffs
 -
 
   ChangeLog 0365651b2d4c28f278c7ec7eb7a3a26a95caa4a4 
   src/browsers/playlistbrowser/PlaylistsByProviderProxy.cpp 
 0a450ae2420de11ab221cf2dec9fc942a7118dd1 
   src/browsers/playlistbrowser/PodcastModel.h 
 e88f4a1dea0b41ce6cc21cdbe3809b99c200b5b8 
   src/browsers/playlistbrowser/PodcastModel.cpp 
 18334f6eb970eed241f172cc71396cca8bcaf04b 
   src/core-impl/podcasts/sql/SqlPodcastProvider.h 
 c3d5e56e79c86e2be8c39f47df928bfeb291a920 
   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 
 183005f652989167952b0c8cf16e742de2fb94e1 
   src/services/gpodder/GpodderPodcastRequestHandler.h 
 8c12e5f5a5a63b91670fd8081018b7a017a00bbe 
   src/services/gpodder/GpodderPodcastRequestHandler.cpp 
 66e8ea8a3aeec054c82a180f84d199aba5547f5a 
   src/services/gpodder/GpodderProvider.h 
 4c724cd763b94515e9e90620ad9a4a3fb8f92e2c 
   src/services/gpodder/GpodderProvider.cpp 
 6e3255e5f465287a9fad3454cca5a1d2ce47fc6a 
   src/services/gpodder/GpodderService.cpp 
 b518de33e01d20c7293c50e9edbb2dff78419e53 
   src/services/gpodder/GpodderServiceConfig.h 
 111455aeeb2a579caf1dd938249b8d832a775a89 
   src/services/gpodder/GpodderServiceConfig.cpp 
 750272e4f2c6c7ad411e9d12c622e97789a29bcd 
   src/services/gpodder/GpodderServiceSettings.h 
 81bc218428d2b8bc78235852548a337579b35b24 
   src/services/gpodder/GpodderServiceSettings.cpp 
 8bb8b806927d1dbac47f2a06887c2e2a6dd3d504 
   src/services/gpodder/GpodderSortFilterProxyModel.h 
 638fe992cba553cc317febdf049b6b0f301018b5 
   src/services/gpodder/GpodderSortFilterProxyModel.cpp 
 ed1e8301f6f415e86e5367b7827817fff45feb98 
 
 Diff: http://git.reviewboard.kde.org/r/104335/diff/
 
 
 Testing
 ---
 
 This patch should build. Everything is working as expected and there aren't 
 any known issues.
 
 
 Thanks,
 
 Lucas Gomes
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Should we support building utilities without building player?

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

On 12/19/2011 12:15 AM, Matěj Laitl wrote:
 I can do the b), but is there an actual use-case for building only
 utilities? Would linking to kdelibs hamper this use-case? (Paweł,
 Thomas?)

one use-case is/was to install a utillities package on a server
(without KDE/kdelibs installed), create (takes less time than via e.g.
NFS) a file with collection information via the collectionscanner
executable and import this file on your desktop.

No idea if many people use this anymore ... I used it from time to time.

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk7udSwACgkQlZvAMV/NgGKlLQCeL7JuBgC5dajWhyWuyQUgSXDP
r78An1F/Ofo/pHVNLtEqKFMmA3T7f+8o
=O7AI
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Important bugfixes to Gpodder Service

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103122/#review8174
---

Ship it!


Ship It!

- Stefan Derkits


On Nov. 13, 2011, 2:12 a.m., Lucas Gomes wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/103122/
 ---
 
 (Updated Nov. 13, 2011, 2:12 a.m.)
 
 
 Review request for Amarok, Stefan Derkits and Bart Cerneels.
 
 
 Description
 ---
 
 This patch must be applied prior to next release.
 
 * Fixed a bug in drag'n drop due to an inappropriate handling of 
 SyncedPodcast.
 * Made PodcastModel independent of playlist types.
 * Done some changes at SyncedPlaylist and SyncedPodcast.
 * Remembered to start subscription synchronisation timer.
 
 Special thanks to HorusHorrendus for informing me about the drag'n drop bug 
 in time ^^.
 
 
 Diffs
 -
 
   src/browsers/playlistbrowser/PodcastModel.cpp 1cad82e 
   src/playlistmanager/SyncRelationStorage.cpp 116e23c 
   src/playlistmanager/SyncedPlaylist.h 0e94576 
   src/playlistmanager/SyncedPlaylist.cpp eaa856f 
   src/playlistmanager/SyncedPodcast.h 85c80fc 
   src/playlistmanager/SyncedPodcast.cpp 92dd6f8 
   src/services/gpodder/GpodderProvider.cpp 2ba0bf3 
 
 Diff: http://git.reviewboard.kde.org/r/103122/diff/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Lucas Gomes
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Done some improvements on Gpodder Service

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103034/#review7902
---



src/services/gpodder/GpodderService.cpp
http://git.reviewboard.kde.org/r/103034/#comment6820

I changed this and had my reasons to do it: You should anyways only set 
enableProvider if username  password is correct (and the amarok device was 
found/created sucessfully)

so this is not necessary



src/services/gpodder/GpodderService.cpp
http://git.reviewboard.kde.org/r/103034/#comment6822

I don't see much sense in this block ... polish is called after init on 
service creation

afaik if you change the config of a service the whole Service is anyways 
created again from scratch (and init() called again)

what you could of course do would be to move the enabling of the Provider 
into polish



src/services/gpodder/GpodderService.cpp
http://git.reviewboard.kde.org/r/103034/#comment6821

Again ... this is already implied by enableProvider


- Stefan Derkits


On Nov. 3, 2011, 12:02 a.m., Lucas Gomes wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/103034/
 ---
 
 (Updated Nov. 3, 2011, 12:02 a.m.)
 
 
 Review request for Amarok, Stefan Derkits and Bart Cerneels.
 
 
 Description
 ---
 
 Done some improvements on GPodder Service.
 
 Fixes:
 * Annoying popup related to KIO (wrapper around QNetworkAccessManager) (Seems 
 that the libmygpo-qt version fixed it)
 * GPodderProvider can be loaded in runtime also.
 * Preserve persistence of GPodderService EpisodeActions during shutdown and 
 restart of Amarok. 
 * Now, we send EpisodeActions in Amarok start or when a user stop/pause and 
 doesn't resume listening in 60 seconds.
 
 Know bugs:
 * Even though GpodderProvider can be loaded during runtime, the 
 PodcastBrowser is not showing it :/.
 
 
 Diffs
 -
 
   ChangeLog 0b87f8e 
   src/services/gpodder/GpodderProvider.h 8ddc802 
   src/services/gpodder/GpodderProvider.cpp 15996f8 
   src/services/gpodder/GpodderService.h 02ff539 
   src/services/gpodder/GpodderService.cpp 9e04d38 
   src/services/gpodder/GpodderServiceConfig.cpp 5ff6dea 
   src/services/gpodder/GpodderServiceSettings.h fa53387 
   src/services/gpodder/GpodderServiceSettings.cpp 51ab598 
 
 Diff: http://git.reviewboard.kde.org/r/103034/diff/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Lucas Gomes
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: gpodder.net Amarok Integration - Design Issues

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

 Known problems atm: ... -) Annoying popup related to KIO (wrapper
 around QNetworkAccessManager)
 
 This Popup is related to the isPossibleSpoofingAttack Method in 
 https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/entry/kioslave/http/http.cpp

 
 libmygpo-qt setting the data for http basic auth in the url.

this should be fixed now with the latest GIT Version of libmygpo-qt,
as I now set the auth data in the header of the request, instead of
the URL.

Maybe someone could also test  confirm this ...

Stefan

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk6xMmMACgkQlZvAMV/NgGLJIACfUMcX6D55mWPEIHSA5tTKwwaJ
XN8AoM0kr54FQjYIXnRDFrEyNoZUFIeV
=Ubxu
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

 we can do this way, but I think it isn't efficient. We only want
 to know where we stopped, so there is no need to make more than 
 one episode action. Unless something like play history is a to-do
 for Amarok (Bart should know ^^).
 
 It is, we already keep playback position markers automatically to 
 start playing where amarok stopped before. Full history is not
 really required, unless it is used for chaptering of podcast
 episodes. This could enhance the podcast listening experience on
 Amarok.

so probably at first we don't want to send Playlist Actions also for
skips (I will explain in a few Minutes what this could be good for).

Still we need to change the existing implementation.
Without sending skips and only wanting to know where we stopped, only
1 EpisodeAction for Play should be uploaded to the Server (and not one
every Minute or half Minute).
This Episode Action should probably be sent when the user clicks pause
or stop and doesn't resume listening in e.g. 1 minute.

Of course we know the gpodder.net service can be unreliable from time
to time, but I also think the case where a user stops listening a
Podcast, shuts down Amarok  his computer (and gpodder.net didn't work
and the episode action couldn't be sent in time) and then wants to
continue listening the Podcast on his mobile is not soo common.

Why it makes sense to upload (and it isn't that inefficient, keeping
some data structures in memory and uploading them as a bunch if
nothing [related to this episode or podcast in general] happened for 1
Minute doesn't cost much more then uploading a single action) also
skips?

Atm this Data is only used (and visible) internally in gpodder.net for
Podcast Producers. But Bart made a good point, (crowd-sourcing)
chaptering of podcast episodes would be a cool feature for gpodder.net.

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk6dR0QACgkQlZvAMV/NgGIjbgCeOUl/+ws7LiZSbXn8LQOK7RtW
M08AoK1xYMcQg2fLY144aDZZhVgjMbK2
=vkJp
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

 Good, but you can't use The::networkAccessManager() as the nam or
 KDE will keep asking if you authorize amarok to login in
 gpodder-net. So, the solution is to use or own nam ^^.

We have to find a solution for this, a own nam is not the correct
solution imho. Will check where this authorization comes from and what
can be done to avoid it.

 I'm trying to put the status sync to work only when the user
 stop/pause amarok. The problem is that if the user closes Amarok,
 then we have no guarantee that the status data will be received by
 the server. Any failure will make us loose our status data and
 since the server is a bit unresponsive this problem may happen
 frequently. So we must create, at least, something similar to the
 actual send-by-minute approach or the GPodder Service may not work
 correctly.

Yes, closing Amarok is of course sth that needs consideration, sending
a Status Update every Minute is still not the correct thing to do,
imagine just 100 Amarok User listening to Podcast at the same Time,
would make (at least) 100 Requests/Minute, just from these 100 Users.

So our problem is: We need to make sure that the last Request to
upload an Episode Action was received by gpodder.net. Anyone has an
Idea how to do this, can we do this in Amarok or do I need to
implement Support for that in the Library.

 And what the problem in counting time from the last point where we
 stopped? I use this info to set an auto-bookmark in the seek bar,
 so the user can know where he stopped to listen. Also, every time I
 set the start point to 00:00, then gpodder.net doesn't save the
 last point where I stopped.

Yes, I saw that it was saved, but if I start the Podcast Episode again
at 00:00:00 and listen till 00:05:00 it shouldn't show 00:15:00 to
00:20:00 just because I listened before till 00:15:00.

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk6b8KIACgkQlZvAMV/NgGIqpgCfczhZPWJGJ/VPNp2w0AwIyTxr
JvUAoIBToGOcd2pa0O9G17B6LDLGzbpf
=adoI
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Lucas,

tried the PodcastProvider now that it is in Master.

Fixed some Stuff (use of #DEFINES instead of constants  creation of
own nam), but found some serious Problems:

It uploads an EpisodeAction::PLAY every minute, which is not correct.
Play should only be sent once to the Webservice, when I
stop/pause/seek (not sure about seek, @stefankoegl can you clarify?)
and not every minute.
Please change this asap, cause if more users start using the gpodder
service in Amarok the gpodder Server will receive too many requests.

Also after restarting amarok and starting a podcast episode again from
the start, the time in the EpisodeActions seem to be counted from the
last point where I stopped it and not from the beginning (also try to
find a way to set the start always to 00:00, it is always 00:01).

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk6aByMACgkQlZvAMV/NgGLjcgCgkIAsUvT9IXWvp0b0qO8lnT2u
P14AoJmnL4cDmuTKTMFGleIpzapj1B29
=Kux6
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

libmygpo-qt Release of v1.0.4

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear Amarok  gPodder Community,

Summer (and with it Google Summer of Code) is over and Lucas Lira
Gomes sucessfully finished his GSoC Project (Integration of
gpodder.net into Amarok), so expect to be able to synchronize your
podcasts between Amarok  gpodder.net soon ;)

In addition to that, Ari Hannula from Nokia created Podcasts for the
Nokia N9, which also utilizes libmygpo-qt for synchronizing and
searching podcasts.

Thanks to Lucas  Ari, we found (and fixed ;) ) some Bugs in
libmygpo-qt, so we announce hereby the availability of libmygpo-qt v1.0.4

Changes in 1.0.4:
- -) fixed a bug with an invalid timestamp when uploading EpisodeActions
- -) fixed a bug with a wrong url when retrieving EpisodeActions by Podcast
- -) fixed a crash happening on MeeGo because of the deletion of
QNetworkReply Pointers

Where to get libmygpo-qt?

Tarball:
http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.0.4.tar.gz
md5sum: 9c840d6a7dc96055c6eb5a7d36d02a7c
sha1sum: 7d46fcbcc3c0177bc353f8e15b0bff9fd19013e6

Some more important Links for libmygpo-qt:

Project Website: http://wiki.gpodder.org/wiki/Libmygpo-qt
Git Repo: https://github.com/gpodder/libmygpo-qt
Doxygen Documentation: http://stefan.derkits.at/libmygpo-doc/
gpodder.net API: http://wiki.gpodder.org/wiki/Web_Services/API_2
Bugreports: http://bugs.gpodder.org
Contact: gpodder-de...@lists.berlios.de

- - --- Infos about libmygpo-qt ---

What is libmygpo-qt?

libmygpo-qt is a Qt/C++ Library wrapping the gPodder.net Webservice. It
was created as part of a University Course  it is used in
Amarok (since 2.4.1) with the new gpodder.net
Service, that makes the gpodder.net Podcast Directory available from
within Amarok.

One of the next Versions of Amarok require libmygpo-qt 1.0.4 for the
gPodder PodcastProvider, with which you can synchronize your local
Podcasts between Amarok and gpodder.net (and other podcatchers with
gpodder.net integration).

Greetings,
Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk5qSRAACgkQlZvAMV/NgGKUnACg1VSXY3MKjzw4LLJ5FHzqI6kQ
+tcAoIrIzF90NRjGHrOps1m+Ck5+sfr+
=bj1P
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add new collection filter to find exact matches

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

 This seems like a pretty useful feature and the change is small and
 clean, could someone more knowledgeable take a look so it could be
 added to the edit filter dialog.

The Feature looks usefull, didn't look at the Sourcecode.

But I find it a little bit non-intuitive. OK most user would use it
via the Dialog anyway, but label: vs. label= doesn't sound intuitive
to me.

Maybe we should make this a bigger change, what about:

label:pop vs. label:pop

The first would find all that contain pop, the second one only pop.
Like Google Searches where you can put quotes around it to search for
the exact order of words.

Or is there already a difference in Amarok how it handels foo vs.
foo in the edit filter?

Stefan

P.S.: In a side-note, do more People find the current Edit Filter
Dialog confusing? ;)
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk5PoJEACgkQlZvAMV/NgGK+xACfUjtDI+njrhCEberd3ECDLAjs
K+UAnjRZuQSO+P9CxfmugtRqKFXh/Fwk
=42cp
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add new collection filter to find exact matches

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hey,

 Quotes are already used to treat space seperated words as a whole
 
 ie artist: Arctic Monkeys still does a contains match
 
 what about label: =Arctic Monkeys?

Sure it does, but what would be the use case? Search for artist:Arctic
Monkeys to find everything by the Artist Arctic that also contains as
Artist or Songtitle or Albumtitle the Name Monkeys ... don't know ...
maybe we could change the Tokenizer of the Search Box to treat
everything that has word: in front as new token?

Are there some specifications/standards out there how Search Terms
should look? ;)

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk5PpesACgkQlZvAMV/NgGK4XACfV2dZyRezEVpDabS6bogpyKvA
2eEAoICTER1CfOlL6bBP6F1nE+k2fhmD
=N9HN
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: input for next release schedule

[Stefan Derkits]

Hey,

 We should think about the schedule for the next release. Can you
 please provide input for that in this thread?
 Also please let people know what was discussed at the BoFs in Berlin
 during the Desktop Summit. I was only able to attend an hour of it and
 others are probably interested in the things discussed as well.

some Things I still remember from the Desktop Summit with regard to
Releases:

Next Versions should be 2.5, 2.6, 2.7 ... instead of 2.4.4, 2.4.5 ...
Versions like 2.5.1 should be avoided, except if e.g. 2.6 is still far
away, someone has time and important bugfixes were made -- backporting
important fixes to 2.5.1 (but this should be the exception)
Important for 2.5 is fixing the Media Devices, this has a high priority.

Stefan
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Fwd: Amarok :: DJ level

[Stefan Derkits]

Hello,

there are 2 Options, either make a Amarok Dj Interface, which is more 
DJ fit. Costs development resources, maybe makes code more complicated 
and some of the Amarok Features (e.g. services) are not needed for a DJ 
Programm.


Or we tell him this is not really in our Scope of Development, but tell 
him that there is a nice open source Dj App called Mixx that has most of 
his Features.


I'm for option 2 ;)

Stefan


Generally, i'd love to see Amarok more 'DJ' fit, reaching out beyond
what other music players offer. I'd have many suggestions about that,
but i doubt amarok crew will follow that path. If you think it's worth
i could try to cellect my ideas in a feature request.

Cheers, and many thanks

Michael

party floor :)-





___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Fwd: Amarok :: DJ level

[Stefan Derkits]

Hello Michael,

Mark forwarded your Mail to the Amarok Mailinglist.

Great that you use Amarok, but unfortunatley (after some People looking 
at the Features you need) this is soo much out of scope for Amarok, that 
we don't want to spend Resources at developing DJ Features.


But I know of another great (used it myself on some Parties) Open Source 
DJ Software which I want to recommend you for parties - Mixxx - 
http://www.mixxx.org/


I think this Software should fullfill most (if not all) of the features 
you need.


Hope you have a great time (re)discovering Music with Amarok and rock 
great parties with Mixxx,

Stefan


i'd like to use Amarok for student parties, as DJ, and i need blending
over from one song to another. Also, i need to navigate to and drop
into new songs independently from the running instance. In short, the
easiest way would be to launch another instance of amarok in parallel.
Is that possible, maybe by hacking the lockfile ? But how could i
solve the output problem, with only one Laptop ? Can i assign
different ALSA output ports to a second instance ? I really don't like
to use just 2 laptops.

Generally, i'd love to see Amarok more 'DJ' fit, reaching out beyond
what other music players offer. I'd have many suggestions about that,
but i doubt amarok crew will follow that path. If you think it's worth
i could try to cellect my ideas in a feature request.

Cheers, and many thanks

Michael

party floor :)-





___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Partial Rewrite of ID3v2TagHelper.cpp

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102055/
---

(Updated Aug. 3, 2011, 9:20 p.m.)


Review request for Amarok and Ralf Engels.


Changes
---

also changed VorbisCommentHelper


Summary
---

Rewrite if else else if Constructs to switch statements

Add common Frame Names to m_fieldMap


Diffs (updated)
-

  shared/tag_helpers/ID3v2TagHelper.cpp 
27e0cf0a9f6dc0bfbbd54cab65cb65dd6bef8a33 
  shared/tag_helpers/TagHelper.h f8e7fd9fdad0ac3abd6efd34ad5e00c973233a6d 
  shared/tag_helpers/TagHelper.cpp 96f763e0839b59194484c1aa94cd266d88ad5add 
  shared/tag_helpers/VorbisCommentTagHelper.cpp 
1222f9fc9e0b3f04499d9542e29e58b12d8c5f1b 

Diff: http://git.reviewboard.kde.org/r/102055/diff


Testing
---

compared output of collectionscanner before  after patch - fixed some, but 
still some slight problems with TrackNo


Thanks,

Stefan

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request: Partial Rewrite of ID3v2TagHelper.cpp

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102055/
---

Review request for Amarok and Ralf Engels.


Summary
---

Rewrite if else else if Constructs to switch statements

Add common Frame Names to m_fieldMap


Diffs
-

  shared/tag_helpers/ID3v2TagHelper.cpp 
27e0cf0a9f6dc0bfbbd54cab65cb65dd6bef8a33 

Diff: http://git.reviewboard.kde.org/r/102055/diff


Testing
---

not much ... ;)


Thanks,

Stefan

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Partial Rewrite of ID3v2TagHelper.cpp

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102055/
---

(Updated July 22, 2011, 11:48 p.m.)


Review request for Amarok and Ralf Engels.


Changes
---

Remove all use of FPMS Enum and instead use existing Values Meta::valScore, 
Meta::valRating, Meta::valPlaycount


Summary
---

Rewrite if else else if Constructs to switch statements

Add common Frame Names to m_fieldMap


Diffs (updated)
-

  shared/tag_helpers/ID3v2TagHelper.cpp 
27e0cf0a9f6dc0bfbbd54cab65cb65dd6bef8a33 
  shared/tag_helpers/TagHelper.h f8e7fd9fdad0ac3abd6efd34ad5e00c973233a6d 
  shared/tag_helpers/TagHelper.cpp 96f763e0839b59194484c1aa94cd266d88ad5add 

Diff: http://git.reviewboard.kde.org/r/102055/diff


Testing
---

compared output of collectionscanner before  after patch - fixed some, but 
still some slight problems with TrackNo


Thanks,

Stefan

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

libmygpo-qt Release of v1.0.3.1 [GIT Repo changed!!]

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear all,

Unfortunatly I didn't test the Tarball good enough and didn't find a
serious Bug in the Tag  Tarball before the Release.

I've made a new Tarball, so this is sorf ot v 1.0.3.1 ;)

Tarball: http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.0.3.tar.gz
md5sum: 0ed91cc9483f4634e8709a0ea95baeba
sha1sum: e4ebbed34168517ee7a6b9fc20f59a60af715e23

Greetings,
Stefan

-  Original Release Message 

Dear Amarok  gPodder Community,

Amarok 2.4.1 is released and with it the first Application to use
libmygpo-qt. Thanks for all the Feedback since 1.0.2 ... it's time again
for a new Bugfix Release, so here is libmygpo-qt 1.0.3

The most important Stuff at the Beginning:

libmygpo-qt moved Repository, it can now be found alongside other
gpodder Projects at:
https://github.com/gpodder/libmygpo-qt

The old Repository no longer exists, above Repo is the official
libmygpo-qt Repository.

Changes in 1.0.3:
- -) All the Private Classes used in libmygpo-qt got their own Header
Files (name_p.h) instead of having them in the .cpp Files
- -) UrlBuilder uses now the fast String Concatenation of Qt
- -) Some unneeded Files were removed (RequestHandlerTest 
tests/Makefile.man)
- -) Fixed a Bug in the Build System
- -) General Cleanup of unnecessary Includes

Where to get libmygpo-qt?

Tarball: http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.0.3.tar.gz
md5sum: 5f5995a2e335a3f47487d9b25ef3a16e
sha1sum: 49bbcb886cdb215513ea0e54efb8a488dcc88749

Some more important Links for libmygpo-qt:

Project Website: http://wiki.gpodder.org/wiki/Libmygpo-qt
Git Repo: https://github.com/gpodder/libmygpo-qt
Doxygen Documentation: http://stefan.derkits.at/libmygpo-doc/
gpodder.net API: http://wiki.gpodder.org/wiki/Web_Services/API_2
Bugreports: http://bugs.gpodder.org
Contact: gpodder-de...@lists.berlios.de

- --- Infos about libmygpo-qt ---

What is libmygpo-qt?

libmygpo-qt is a Qt/C++ Library wrapping the gPodder.net Webservice. It
was created as part of a University Course  it is used in
Amarok (since 2.4.1) with the new gpodder.net
Service, that makes the gpodder.net Podcast Directory available from
withing Amarok.

Also at the Moment there is a GSoC Project running, trying to create a

Greetings,
Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk3ZGCkACgkQlZvAMV/NgGJeTgCcD6n4WUKPrX4KVBlqoen0XrPE
vuYAoInNLVGzmj1Hop813m7vE9cMhclM
=rRtx
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Fwd: Review Request: Fix incorrect slot names in gpodder service which causes no such slot runtime error

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Thx Markey for forwarding it  thx Romain for noticing it.

Will have it fixed by tomorrow evening, want to check back with my
Colleague who wrote that Code first if he meant the Slots from the
PodcastRequestHandler (then the Slot Names are wrong) or from the
ServiceModel (where the names would be correct).
Even though I'm sure he meant the first one ... but found some unused
Code  a Pointer that doesn't get deleted so I will go over the code
once more ...

Stefan

On 03/29/2011 07:44 PM, Mark Kretschmann wrote:
 -- Forwarded message --
 From: romain.per...@gmail.com
 Date: Sun, Mar 27, 2011 at 4:55 PM
 Subject: Review Request: Fix incorrect slot names in gpodder service which
 causes no such slot runtime error
 To: Mark Kretschmann kretschm...@kde.org, Harald Sitter 
 sitter.har...@gmail.com
 Cc: romain.per...@gmail.com
 
 
This is an automatically generated e-mail. To reply, visit:
 http://svn.reviewboard.kde.org/r/6639/
   Review request for Harald Sitter and Mark Kretschmann.
 By bambi.
 Description
 
 When you use the gpodder service with amarok 2.4.0.90 sometimes when
 you click on podcast entries you can see the following messages in a
 terminal:
 QObject::connect: No such slot
 GpodderPodcastRequestHandler::topTagsRequestError(QNetworkReply::NetworkError)
 QObject::connect: No such slot 
 GpodderPodcastRequestHandler::topTagsParseError()
 
 These slots do not exist in GpodderPodcastRequestHandler API. Change
 them to requestError(QNetworkReply::NetworkError) and parserError()
 solves the problem.
 See the patch in attachment.
 
   Diffs
 
- src/services/gpodder/GpodderServiceModel.cpp (af48576)
 
 View Diff http://svn.reviewboard.kde.org/r/6639/diff/
 
 
 
 
 
 ___
 Amarok-devel mailing list
 Amarok-devel@kde.org
 https://mail.kde.org/mailman/listinfo/amarok-devel

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk2SXVgACgkQlZvAMV/NgGJ4PwCgings/VHFSPJmw7oimNo2Nhm4
kI0AoMkjh3JnVo5OfGI1qcuzIC5ixxMc
=3e0b
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

libmygpo-qt Release of v1.0.2

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear Amarok  gPodder Community,

after the successfull Amarok 2.4.1 Beta with the new gpodder Service
included, Interest in the Library spiked and some Packagers contacted me
because of Warnings or Inconsistencies in the Library. Thanks for that,
I appreciate all Input ;)

Two important things before:
- -) libmygpo-qt now has a fixed Project Homepage:
http://wiki.gpodder.org/wiki/Libmygpo-qt
- -) Our License was a bit unclear, now it should be clear: libmygpo-qt is
licensed under LGPL v2.1 or later

So here is the 1.0.2 Bugfix Release, containg the following Changes:
- -) Changed SO Version Scheme (again, but now it's final, thx to input of
eean)
- -) Eliminated some Code that created Warnings
- -) Cleaned up the Build System to only install needed Headers
- -) Build System now also outputs no Warnings
- -) Changed README a little bit

http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.1.0.2.tar.gz
md5sum: 6f88444c82e9840638ec16e366457dd7
sha1sum: e1b2b2fe3bf036c2f7753b0c514982e0583871d1

Some more important Links for libmygpo-qt:

Project Website: http://wiki.gpodder.org/wiki/Libmygpo-qt
Git Repo: https://github.com/ase23/libmygpo-qt
Doxygen Documentation: http://stefan.derkits.at/libmygpo-doc/
gpodder.net API: http://wiki.gpodder.org/wiki/Web_Services/API_2
Bugreports: http://bugs.gpodder.org
Contact: gpodder-de...@lists.berlios.de

- --- Infos about libmygpo-qt ---

What is libmygpo-qt?

libmygpo-qt is a Qt/C++ Library wrapping the gPodder.net Webservice. It
was created as part of a University Course  it will is used in
the next Versions of Amarok (2.4.1) with the new gpodder.net
Service, that makes the gpodder.net Podcast Directory available from
withing Amarok.

Greetings,
Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk2JOQgACgkQlZvAMV/NgGL7OACeKatyhliaHJ8YbQIAUvjSrzeT
PdYAoMljBuV9IIEZ8zktUDgJJFCCp4Lq
=POvU
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Another question about Gpodder

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hey,

 That config will probably not be part of the settings dialog though.
 It be accessed via the service actions.

Yeah I thought of that and there are 2 things:

1) we already implemented it as a Setting in the Service Dialog, not
moving the Dialog somewhere else would make it easier for us ;)
2) it will also be used for the Service (at least for Recommendations),
so it also has to be available also for the Service

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk11L3UACgkQlZvAMV/NgGIIgwCfcoL2aqeQfdAOjk+A8bk/MAyt
vqkAniELj89CNh1NCUo6UScf0oqDv3X+
=J4mT
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Filter Editor Dialog restyling

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

On 01/15/2011 09:35 PM, Sergey Ivanov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/100250/#review917
 ---
 
 
 Still works, and mentioned bug still open. Any 
 corrections/suggestions/comments? :)
 
 - Sergey

the Dialog still has a big Bug:

If I choose the Artist Token and enter e.g. Faith No More it creates:
artist:Faith No More ... which does mean artist should be/contain
Faith and Filter (I think without Restriction) for No AND More
If you close the Widget and reopen it, you also see that it's no longer
just an Artist Filter but now it is Artist Name AND Simple Text AND
Simple Text

I think the pretty simple Solution to this is to put the Text that is
entered for a Token under Quotes ... so that it says artist:Faith No More

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk1zdaIACgkQlZvAMV/NgGK17wCfWxD3TgzBCyFR9rOGFdF2CzRV
XUsAn1q3Lb8oXac0KGdyozY6DepYlSES
=rYSZ
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Return Playdarcollection from the Dead ;)

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hey everyone,

after playing around with Playdarcollection [just wanted to port it to
QJson and to test it I had to get into Playdar] I think it's a really
good (but not fully usable) part of Amarok and it would be a pitty if it
would be left to die as a disabled Plugin in the SourceCode.

@Andy:
If Playdar is not dead and it would make Sense to extend/adapt the
PlaydarCollection I have some proposals (that need check from the more
experienced Amarok Devs if they make sense) how to make it better and
would also help you with Parts of it (especially the Service Part):

- -) Make it into a Service like the last.fm Service. This would allow
Users to disable/enable and it would also make it possible to have a
ConfigDialog available (is it possible to run playdar-core on another
Computer then localhost and access it?)

- -) The Search is not soo usable ... would it be possible to search
Playdar for all Songs from Artist foo (without specifying a Title)? If
not that's a pitty and I would hope for playdar to change it; if yes the
search from amarok should be changed to not always look for artist: foo
 song: foo if someone typed foo in the filterwidget.

Greetings,
Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk1lDqwACgkQlZvAMV/NgGIuFQCbBOW18yyM4Jt1iPgmy1OKR8pq
YPsAn2IMrHj7P/2KTpzrELclCxJDozEO
=mgPf
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100607/
---

(Updated Feb. 22, 2011, 4:30 p.m.)


Review request for Amarok.


Changes
---

tested the change  made sure it applies clean to current master - ready to 
ship - only waiting for Ship it ;)


Summary
---

What I did:
-) added cmake/modules/FindQJson.cmake
-) deleted external/JsonQt  adapted external/CmakeLists.txt
-) use QJson in collections/playdarcollection/support/
-) only compile Playdarcollection if QJson was found

Why:
QJson is available via Package on pretty much every System now
Why QJson instead JsonQt? libmygpo-qt uses it, libechonest uses it and both 
Libraries will (sooner or later) be used in Amarok


Diffs (updated)
-

  CMakeLists.txt 11d4c9d5a296560f1c779e1dee4405c9827dac91 
  README d8c142968c2da3888a703cc2b2e38d854f5c868b 
  cmake/modules/FindQJSON.cmake PRE-CREATION 
  external/CMakeLists.txt 0e161c701e0d1a9d7b769a1dda742df9e8f303ae 
  external/JsonQt/CMakeLists.txt 9978895bb72fa4993a4326397fa7284c74fd00ee 
  external/JsonQt/COMPATIBILITY 1a5b6195ca32395657535bd426a91a8a8ee5c22f 
  external/JsonQt/COPYING.HEADER bf9c30eb90c5aa3c04a87a010736bb1c64326885 
  external/JsonQt/Doxyfile.cmake 4d2a4bf7035976f1cd06dcd43a55cb8ab660e47d 
  external/JsonQt/README.txt 4ebcf735ccbff8556914ed687b27f065dfb4a229 
  external/JsonQt/add-copyright-header.sh 
8d21c92fbfa305e0f24d57e9a921235f624aecba 
  external/JsonQt/lib/CMakeLists.txt 3d394572d1af6b062ff6fb10881e462b5b4f7f9e 
  external/JsonQt/lib/JsonQtExport.h 30d5a7569710d4c31d9deffe3798566008fe89bc 
  external/JsonQt/lib/JsonRpc.h 8f0024c03c0c89c021f271421821e57b3d4b9367 
  external/JsonQt/lib/JsonRpc.cpp cbcd16156ac44a55b7c34aae3d2b47b2b776f856 
  external/JsonQt/lib/JsonRpcAdaptor.h 83836c810358b7b5db44d151c6840027ec85586a 
  external/JsonQt/lib/JsonRpcAdaptor.cpp 
18a1504435040a1cb8e6a785ae8093ade7d232ef 
  external/JsonQt/lib/JsonRpcAdaptorPrivate.h 
03c990ce187ff90ccb591052f25de547e5651982 
  external/JsonQt/lib/JsonRpcAdaptorPrivate.cpp 
c8fddb012b45c6117e5ac74b7d36cfa6c02048b1 
  external/JsonQt/lib/JsonToProperties.h 
f04bd586e5d1aae9727d8bc4e218171954d86ec5 
  external/JsonQt/lib/JsonToProperties.cpp 
4859d49b643bcd2e9cfb54c0c64581c94654b3f4 
  external/JsonQt/lib/JsonToVariant.h 82b62c0446b03df25aabcbd508fd24e290a9ac98 
  external/JsonQt/lib/JsonToVariant.cpp 
323e31adfe0558d9b4dd671b7a9409cb9bb202fa 
  external/JsonQt/lib/ParseException.h 2f6566099bc13ab84eba28054330bcb0812e9785 
  external/JsonQt/lib/ParseException.cpp 
c663179388f193175febe0eaaca6a2ce8241c215 
  external/JsonQt/lib/VariantToJson.h 2a1a645e4743af267ce21b55d7c164ea2805940b 
  external/JsonQt/lib/VariantToJson.cpp 
baa7cddb548f10e6ea25e1b194683de7863055fc 
  external/JsonQt/tests/CMakeLists.txt 4954fe78d726afc534b541cd97c79551f40f742a 
  external/JsonQt/tests/JsonRpc.cpp 1ce4c9c59f5739426adbb3ed3ddaf148a3081a50 
  external/JsonQt/tests/JsonRpcAdaptor.cpp 
6e995993c5683f64a8313e97ba4ec687032fc98a 
  external/JsonQt/tests/JsonToProperties.cpp 
e1a0707737dd8051e601283cc0b0069894a095bd 
  external/JsonQt/tests/JsonToVariant.cpp 
414d1c9c0e8da5f1a9a651ddd6a2e2da04395f4e 
  external/JsonQt/tests/VariantToJson.cpp 
dfad043d13b25508785bace2277f3ac24d8dd2d5 
  src/core-impl/collections/CMakeLists.txt 
43217903cadf2f56c1ee8610dacbd4e1b34ebd57 
  src/core-impl/collections/playdarcollection/CMakeLists.txt 
589ab02a8a1a09acdd2289c028fbca7b521b0e6a 
  src/core-impl/collections/playdarcollection/support/Controller.cpp 
f8e78055115f8ff38673c5eba0d493b53a000fa2 
  src/core-impl/collections/playdarcollection/support/Query.cpp 
4815d362a50344c7d1936fe0a98536577393a372 

Diff: http://git.reviewboard.kde.org/r/100607/diff


Testing
---

compiled  run Amarok; didn't specifically try out Playdarcollection, didn't 
know how to activate it


Thanks,

Stefan

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Port PlaydarCollection to QJson instead of JsonQt

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100607/
---

(Updated Feb. 20, 2011, 10:51 p.m.)


Review request for Amarok.


Changes
---

QJson is now an optional dependency, playdar is not compiled if QJson is not 
found

Tested PlaydarCollection by installing playdar-core, adding some files to it  
activating the playdarcollection plugin in 
amarok_collection-playdarcollection.desktop
No Errors found, but Playdarcollection displays 0 Files (does the same if I 
compile  install master branch where JsonQt is used) ... maybe Andy can you 
try the patch again?


Summary (updated)
---

What I did:
-) added cmake/modules/FindQJson.cmake
-) deleted external/JsonQt  adapted external/CmakeLists.txt
-) use QJson in collections/playdarcollection/support/
-) only compile Playdarcollection if QJson was found

Why:
QJson is available via Package on pretty much every System now
Why QJson instead JsonQt? libmygpo-qt uses it, libechonest uses it and both 
Libraries will (sooner or later) be used in Amarok


Diffs (updated)
-

  CMakeLists.txt 11d4c9d5a296560f1c779e1dee4405c9827dac91 
  README d8c142968c2da3888a703cc2b2e38d854f5c868b 
  cmake/modules/FindQJSON.cmake PRE-CREATION 
  external/CMakeLists.txt 0e161c701e0d1a9d7b769a1dda742df9e8f303ae 
  external/JsonQt/CMakeLists.txt 9978895bb72fa4993a4326397fa7284c74fd00ee 
  external/JsonQt/COMPATIBILITY 1a5b6195ca32395657535bd426a91a8a8ee5c22f 
  external/JsonQt/COPYING.HEADER bf9c30eb90c5aa3c04a87a010736bb1c64326885 
  external/JsonQt/Doxyfile.cmake 4d2a4bf7035976f1cd06dcd43a55cb8ab660e47d 
  external/JsonQt/README.txt 4ebcf735ccbff8556914ed687b27f065dfb4a229 
  external/JsonQt/add-copyright-header.sh 
8d21c92fbfa305e0f24d57e9a921235f624aecba 
  external/JsonQt/lib/CMakeLists.txt 3d394572d1af6b062ff6fb10881e462b5b4f7f9e 
  external/JsonQt/lib/JsonQtExport.h 30d5a7569710d4c31d9deffe3798566008fe89bc 
  external/JsonQt/lib/JsonRpc.h 8f0024c03c0c89c021f271421821e57b3d4b9367 
  external/JsonQt/lib/JsonRpc.cpp cbcd16156ac44a55b7c34aae3d2b47b2b776f856 
  external/JsonQt/lib/JsonRpcAdaptor.h 83836c810358b7b5db44d151c6840027ec85586a 
  external/JsonQt/lib/JsonRpcAdaptor.cpp 
18a1504435040a1cb8e6a785ae8093ade7d232ef 
  external/JsonQt/lib/JsonRpcAdaptorPrivate.h 
03c990ce187ff90ccb591052f25de547e5651982 
  external/JsonQt/lib/JsonRpcAdaptorPrivate.cpp 
c8fddb012b45c6117e5ac74b7d36cfa6c02048b1 
  external/JsonQt/lib/JsonToProperties.h 
f04bd586e5d1aae9727d8bc4e218171954d86ec5 
  external/JsonQt/lib/JsonToProperties.cpp 
4859d49b643bcd2e9cfb54c0c64581c94654b3f4 
  external/JsonQt/lib/JsonToVariant.h 82b62c0446b03df25aabcbd508fd24e290a9ac98 
  external/JsonQt/lib/JsonToVariant.cpp 
323e31adfe0558d9b4dd671b7a9409cb9bb202fa 
  external/JsonQt/lib/ParseException.h 2f6566099bc13ab84eba28054330bcb0812e9785 
  external/JsonQt/lib/ParseException.cpp 
c663179388f193175febe0eaaca6a2ce8241c215 
  external/JsonQt/lib/VariantToJson.h 2a1a645e4743af267ce21b55d7c164ea2805940b 
  external/JsonQt/lib/VariantToJson.cpp 
baa7cddb548f10e6ea25e1b194683de7863055fc 
  external/JsonQt/tests/CMakeLists.txt 4954fe78d726afc534b541cd97c79551f40f742a 
  external/JsonQt/tests/JsonRpc.cpp 1ce4c9c59f5739426adbb3ed3ddaf148a3081a50 
  external/JsonQt/tests/JsonRpcAdaptor.cpp 
6e995993c5683f64a8313e97ba4ec687032fc98a 
  external/JsonQt/tests/JsonToProperties.cpp 
e1a0707737dd8051e601283cc0b0069894a095bd 
  external/JsonQt/tests/JsonToVariant.cpp 
414d1c9c0e8da5f1a9a651ddd6a2e2da04395f4e 
  external/JsonQt/tests/VariantToJson.cpp 
dfad043d13b25508785bace2277f3ac24d8dd2d5 
  src/core-impl/collections/CMakeLists.txt 
43217903cadf2f56c1ee8610dacbd4e1b34ebd57 
  src/core-impl/collections/playdarcollection/CMakeLists.txt 
589ab02a8a1a09acdd2289c028fbca7b521b0e6a 
  src/core-impl/collections/playdarcollection/support/Controller.cpp 
f8e78055115f8ff38673c5eba0d493b53a000fa2 
  src/core-impl/collections/playdarcollection/support/Query.cpp 
4815d362a50344c7d1936fe0a98536577393a372 

Diff: http://git.reviewboard.kde.org/r/100607/diff


Testing
---

compiled  run Amarok; didn't specifically try out Playdarcollection, didn't 
know how to activate it


Thanks,

Stefan

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: gpodder.net Service (Podcast Directory Podcast Provider)

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100582/
---

(Updated Feb. 8, 2011, 11:48 p.m.)


Review request for Amarok, Leo Franchi and Bart Cerneels.


Changes
---

What's new since the last diff:
-) Treeview now supports Filtering (debug output is created via qDebug ... we 
will change it to the Amarok Debug soon)
-) GpodderProvider does not activate before entering Username (most of the time 
you need to check the ServiceSettings, enter your Username  Password there and 
click on Test Login)
-) Podcasts are now correctly displayed under the GpodderPodcastProvider
-) You can add Podcasts by dragging them from the Local Provider to the 
GpodderPodcastProvider

Known Bugs:
-) Sometimes the Provider isn't enabled, even though you set correct login data 
 did a Test Login - workaround: set enableProvider in 
~/.kde/share/config/amarokrc to true
-) Episodes in Podcasts in the GpodderProvider are sometimes listed more then 1 
Time


Summary
---

Info about gpodder.net: gpodder.net is a web service to manage your podcast 
subscriptions via the web. You can synchronize your devices, view status 
information and discover new interesting podcasts online.

Note: not yet ready for integration, only wanted to already open the Review 
Request to make our work more public and get Feedback
Additional Note: we've pulled the branch stecchino-IncrementalOpmlDirectory 
into our Branch ... so the Files related to Opml  the OpmlDirectory are not 
up for Review here and will be removed from the diff sometime in the Future ;)

Additional Dependency for this Service: libmygpo-qt 
(http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.0.10.tar.gz or 
https://github.com/ase23/libmygpo-qt)

What is added by this Service:
-) a new ServicePlugin with a Config Dialog for gpodder.net Username 
(synchronise checkbox doesn't do anything at the moment)
-) a gpodder Entry (internet/gpodder) where you can find the TopTags  
TopPodcasts of these Tags from gpodder.net (not many Tags  Podcast per Tag 
yet, after testing is done we will set it to 50 or 100)
-) a PodcastProvider that should display the Podcasts subscribed to on 
gpodder.net and be able to add a Subscription to gpodder.net (subscribing 
doesn't work yet and displaying has some Bugs)

What Features will come in the Future:
-) display Podcast Data from gpodder.net
-) synchronization of Episode Status (if you listen to an Episode on your 
phone, it should show up in Amarok as not new)
-) synchronization of Listening Status (you start to listen to an Episode in 
Amarok, finish it halfways, click pause/stop and 


Diffs (updated)
-

  .gitignore b0ad614ce230efbcfcf4f2a84ee7b499caa09116 
  CMakeLists.txt 11d4c9d5a296560f1c779e1dee4405c9827dac91 
  README d8c142968c2da3888a703cc2b2e38d854f5c868b 
  cmake/modules/FindLibmygpo-qt.cmake PRE-CREATION 
  src/CMakeLists.txt 013021ca4049891685c898249db3055adc563bda 
  src/OpmlOutline.h 8b64dc1c798215e8edbd9081bcd9003a1fe8046e 
  src/OpmlOutline.cpp 5a3d6532b7d06524aeea30705b32fed04426c50e 
  src/OpmlParser.h 28c6c0c1d3ec904f418ef6115bc70258e8badd4a 
  src/OpmlParser.cpp 017c6c28c16079ac62f5a6fc10b225458b26d38e 
  src/OpmlWriter.h c28e76dc73fb575abbc0d8255f0a1d55ca2b5969 
  src/OpmlWriter.cpp 13a9bf8196ed2a2d0ec48ba552103badca9f5236 
  src/browsers/playlistbrowser/PodcastModel.cpp 
c54ba251d3ebcbef83b7f44110bca5e5a846cd98 
  src/core-impl/podcasts/gpodder/GpodderPodcastMeta.h PRE-CREATION 
  src/core-impl/podcasts/gpodder/GpodderPodcastMeta.cpp PRE-CREATION 
  src/core-impl/podcasts/gpodder/GpodderProvider.h PRE-CREATION 
  src/core-impl/podcasts/gpodder/GpodderProvider.cpp PRE-CREATION 
  src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 
9784d089292dd8dc35854570db46a801b3daaf16 
  src/images/CMakeLists.txt 20149eb59120cc5711610908dce8f836d8f0abe3 
  src/images/emblem-gpodder-scalable.svgz PRE-CREATION 
  src/images/emblem-gpodder.png PRE-CREATION 
  src/images/icons/hi16-action-view-services-gpodder-amarok.png PRE-CREATION 
  src/images/icons/hi22-action-view-services-gpodder-amarok.png PRE-CREATION 
  src/images/icons/hi32-action-view-services-gpodder-amarok.png PRE-CREATION 
  src/images/icons/hi48-action-view-services-gpodder-amarok.png PRE-CREATION 
  src/images/icons/svg/action-view-services-gpodder-amarok.svgz PRE-CREATION 
  src/services/CMakeLists.txt 1de81f6fb542d3b9046c408d092c16812724f415 
  src/services/gpodder/CMakeLists.txt PRE-CREATION 
  src/services/gpodder/GpodderConfigWidget.ui PRE-CREATION 
  src/services/gpodder/GpodderMeta.h PRE-CREATION 
  src/services/gpodder/GpodderMeta.cpp PRE-CREATION 
  src/services/gpodder/GpodderPodcastRequestHandler.h PRE-CREATION 
  src/services/gpodder/GpodderPodcastRequestHandler.cpp PRE-CREATION 
  src/services/gpodder/GpodderPodcastTreeItem.h PRE-CREATION 
  src/services/gpodder/GpodderPodcastTreeItem.cpp 

Re: Amarok 2.4

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


 Well, collection scanner runs by timer, there is no file system
 monitor anymore.
 

W00t ... didn't know that, seems many People missed that.

Especially, if we no longer watch the File System, what does the
Checkbox Watch Folder for Change do? This should be removed or
renamed, because it is misleading for the Users.

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk0y7UgACgkQlZvAMV/NgGKIoQCeMycNVhUoFL1nTLBV3oz9Ar1B
uSgAn0qpM448I5bHdmrEMIrE4mqNOd/T
=J3i3
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: 2.4.1 schedule

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 11/01/11 18:48, Lydia Pintscher wrote:
 Heya folks :)
 
 Now that we have 2.4.0 out of the door - woho! - it's time to
 think a bit about 2.4.1. What are your plans?
 
 
 Cheers
 Lydia
 

We plan to create a Review Request for the Gpodder Integration [1]
around End of January and would plan to merge our Branch [2] around
the 10th of February. So the Gpodder Service  Podcast Synchronization
would go into 2.4.1. ;)

Stefan

[1] http://amarok.kde.org/wiki/Proposals/GPodderNet
[2] https://github.com/ase23/amarok-ase/tree/gpodder
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk0s70YACgkQlZvAMV/NgGJICQCaA3O9/TPu3jYHxP5whxP7Qez5
S+oAn3f/T4lbov0eZP1eeYEB7+TpyybM
=x5Fx
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Fix for USB storage mode media players

[Stefan Derkits]

 On 2010-12-27 09:19:36, Sergey Ivanov wrote:
  src/MediaDeviceCache.cpp, line 89
  http://git.reviewboard.kde.org/r/100194/diff/1/?file=4918#file4918line89
 
   has greater priority then , parenthesis don't make difference.

Parenthesis make no difference for the compiler (and most probably also no 
Speed Difference), but in cases where the Operator Precendence is not that well 
known, they make the code easier to read -- I would leave them


- Stefan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100194/#review621
---


On 2010-12-08 21:55:12, Lukáš Tinkl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/100194/
 ---
 
 (Updated 2010-12-08 21:55:12)
 
 
 Review request for Amarok.
 
 
 Summary
 ---
 
 This patch fixes identifying general USB storage mode media players, plus 
 adds some minor fixes and cleanups. The main change is in 
 UmsConnectionAssistant::identify method.
 
 
 Diffs
 -
 
   src/MediaDeviceCache.cpp babb8ff 
   
 src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp 
 92339ff 
   src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp 
 5956a2b 
 
 Diff: http://git.reviewboard.kde.org/r/100194/diff
 
 
 Testing
 ---
 
 
 Screenshots
 ---
 
 Amarok in USB mode
   http://git.reviewboard.kde.org/r/100194/s/21/
 
 
 Thanks,
 
 Lukáš
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Fwd: Release of libmygpo-qt 1.0 Beta (v0.9)

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dear gPodder  Amarok Community,

we are proud to announce the first Beta of libmygpo-qt.
This Version is feature complete, which means that every Feature of the
gpodder.net API is available via libmygpo-qt

You can download the Tarball here:
http://stefan.derkits.at/files/libmygpo-qt/libmygpo-qt.0.9.tar.gz
or you can check our Git Repo at:
https://github.com/ase23/libmygpo-qt

Due to the Fact that we are now Feature Complete we wish for many many
Testers of this Library, as we are in the Process of starting the
Integration of gpodder into Amarok and wanna get a stable libmygpo-qt
v1.0 Release into diverse Repositories of Linux Distributions.
Any Help  Advice on this is very welcome ;)

If you didn't read the last Release Messages or are wondering what
gpodder has to do with Amarok, below you again find all the Infos.

Merry Christmas,
Stefan, Christian  Felix

P.S.: Anyone interested in using our Lib to make a Mobile Client for
Symbian^3/MeeGo with Qt/QML to win the Qtest Mobile App Port Contest?
Contact us via the gpodder Mailinglist: gpodder-de...@lists.berlios.de

- --- Info about libmygpo-qt ---

What is libmygpo-qt?

libmygpo-qt is a Qt/C++ Library wrapping the gPodder.net Webservice. We
are working on it as part of a University Course  it will be used in
one of the next Versions of Amarok when we integrate the gPodder
Webservice into Amarok.
Also it will maybe one Day be used to create a gPodder Client for
MeeGo/Symbian ;)

What is gpodder.net?

gpodder.net is a Webservice, that can be used for Podcast Discovery
(Search, Toplists, Tags, ...) and Subscription/Synchronization of
Podcasts  Podcast Status Synchronization.

You can find a Proposal of the gpodder Integration (to which we will
mostly stick) into Amarok here:
http://amarok.kde.org/wiki/Proposals/GPodderNet

Some Important Links for libmygpo-qt:

Git Repo: https://github.com/ase23/libmygpo-qt
Doxygen Documentation: http://stefan.derkits.at/libmygpo-doc/
Bugreports: http://bugs.gpodder.org
Contact: gpodder-de...@lists.berlios.de
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk0Uh1QACgkQlZvAMV/NgGL19ACfZxfN1ED981nxtXHTcUkoKdAz
0HwAnRjHP/uy/F7LUMilcuCjNd7bs8u3
=MVmY
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Looking for a project to get involved to

[Stefan Derkits]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello Mathieu,

On 18/12/10 14:26, mathieu lornac wrote:
 We are a group of 6 students looking for a project to get involved to.
 We would like to contribute to an existing application such as Amarok
 
 We will work at least 2 days a week for a year, so the project has to be
 quite important
 I'm looking for some ideas or suggestions that some of you might have.

always great for Students to get involved into OpenSource.
Would it be possible for your Project to implement multiple Features? Or
does it have to be one big Feature for this Project.

I am also a Student and currently working with 2 Colleagues on a Feature
for Amarok and have some Proposals for Projects (which are left over
from the Proposals we got) that could be implemented. Here is the List:

* Remote playlists support
Amarok has a powerful playlist framework that is currently
underutilized. It allows for pluggable Playlist Providers that can be
used to expose playlists from web services to the local user.
Supporting Last.fm and/or Ampache playlists natively would be a great
way to add a very useful feature to Amarok. The Last.fm/Ampache
playlists would show up in the Playlist Browser and the user would be
able to create/delete/modify the playlists as if they were normal
local playlists (while they are in reality stored on Last.fm, or
Ampache, etc).

* Extending the Automated Playlist Generator with support for
Last.fm/The Echo Nest recommendations
The Automated Playlist Generator (APG) is a new feature in 2.3.1 that
allows users to specify custom rules for generated one-off playlists.
It is powerful and flexible, sort of a Smart Playlists system on
steroids.  It is lacking support for a similar artists constraint
that would be informed by the Last.fm or The Echo Nest services---with
the addition of this feature, users would be able to create playlists
that take into account the similarity of tracks within them.

* Designing a new APG UI
The APG (Automated Playlist Generator, see above) is powerful and
flexible, but the UI is severely lacking. As it is now it is designed
for geeks, not for the average user. This project would be mostly UI
design and Human-Computer-Interaction---not an easy task. Designing a
powerful but easy to use and intuitive UI for users to create
automated playlists from constraints would do a lot to expose the
awesomeness of the APG to all of Amarok's users.

* Batch Tag Editor and Auto-Tagging UI
This is one of the most requested features in Amarok, a batch-tagging
feature. The backend code will be easy to write, but the complexity is
in the user interface--designing a usable way to easily tag batches of
tracks is NOT an easy problem. Furthermore, an additional part of this
could be to create a way to auto-tag tracks with labels from
last.fm. There is already a Labels Applet that allows the user to add
common tags from Last.fm, but there is no way to automatically tag
multiple songs at once from Last.fm. This could be accomplished as
well.

* Crossfading Support
This is also a much requested Feature. Phonon supports it, and it
shouldn't be that much work, but I heard it would involve some
CleanUp/Redesign Work of the EngineController Class

Stefan
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk0Mzb0ACgkQlZvAMV/NgGJBeQCgw+OIkJc9hRdoYZRJ0006Z/mS
Nc0An2+F+FylDW0IWLvdsVcB6eUbt026
=U3OX
-END PGP SIGNATURE-
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: File tag handler refactoring

[Stefan Derkits]

 On 2010-12-14 14:49:42, Stefan Derkits wrote:
  shared/FileType.h, line 42
  http://git.reviewboard.kde.org/r/100191/diff/4/?file=5006#file5006line42
 
  RealAudio is missing ... maybe some other Types
 
 Sergey Ivanov wrote:
 A lot of them. Added only types supported by taglib, but not listed 
 before.

I think we should add all that are supported by Phonon


- Stefan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100191/#review555
---


On 2010-12-11 11:52:39, Sergey Ivanov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/100191/
 ---
 
 (Updated 2010-12-11 11:52:39)
 
 
 Review request for Amarok.
 
 
 Summary
 ---
 
 Rewrite tag reading stuff to make It more OOP way. Add separat classes for 
 each Tag format (ID3v2, APE, ASF, VorbisComment, MP4, MPC). Exclude almost 
 all magic words (frame/field names) from code.
 TODO:
 Implement charset detection stuff.
 
 
 Diffs
 -
 
   shared/FileType.h dc5e57b 
   shared/FileType.cpp 63d81c7 
   shared/MetaTagLib.h ff27c92 
   shared/MetaTagLib.cpp 3f7e758 
   shared/TagsFromFileNameGuesser.h PRE-CREATION 
   shared/TagsFromFileNameGuesser.cpp PRE-CREATION 
   shared/tag_helpers/APETagHelper.h PRE-CREATION 
   shared/tag_helpers/APETagHelper.cpp PRE-CREATION 
   shared/tag_helpers/ASFTagHelper.h PRE-CREATION 
   shared/tag_helpers/ASFTagHelper.cpp PRE-CREATION 
   shared/tag_helpers/ID3v2TagHelper.h PRE-CREATION 
   shared/tag_helpers/ID3v2TagHelper.cpp PRE-CREATION 
   shared/tag_helpers/MP4TagHelper.h PRE-CREATION 
   shared/tag_helpers/MP4TagHelper.cpp PRE-CREATION 
   shared/tag_helpers/StringHelper.h PRE-CREATION 
   shared/tag_helpers/StringHelper.cpp PRE-CREATION 
   shared/tag_helpers/TagHelper.h PRE-CREATION 
   shared/tag_helpers/TagHelper.cpp PRE-CREATION 
   shared/tag_helpers/VorbisCommentTagHelper.h PRE-CREATION 
   shared/tag_helpers/VorbisCommentTagHelper.cpp PRE-CREATION 
   src/CMakeLists.txt a23bbdb 
   src/core-impl/meta/file/File_p.h 9f1df54 
   src/musicbrainz/MusicBrainzFinder.cpp 78a07a6 
   utilities/collectionscanner/CMakeLists.txt 6be9319 
 
 Diff: http://git.reviewboard.kde.org/r/100191/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Sergey
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: File tag handler refactoring

[Stefan Derkits]

 On 2010-12-13 12:13:59, Ralf Engels wrote:
  Looks nice,
  can we delay the integration until Amarok 2.4 is out?
 
 Stefan Derkits wrote:
 The additional Filetypes in Filetype.h and Filetype.cpp could be cool if 
 they are already in 2.4, cause in 2.4 the Display of the Filetypes is taken 
 from the Database (and also the Type that it puts in the Database).
 So every Filetype that was previously not known (everything except 
 Mp3,Ogg,Wma,Mp4) would be displayed as Other in the Properties of the File 
 and woud get a Database Value of 0.
 
 Sergey Ivanov wrote:
 Yeah, sure It can wait as long as we need. It's not hard to keep It 
 updated, since patch doesn't modify legacy files a lot.
 
 Stefan, It's not critical since all this zeros will get fixed during 
 first collection scanner run after commit.

Yeah but for Users who don't use GIT it's fixed in 2.4.1 or 2.5 .. till then 
they see Unknown for all previously not known Files
But as this is a small Issue, it could wait. On the other Hand, the Changes on 
Filetype.h  Filetype.cpp are pretty small ...


- Stefan


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100191/#review517
---


On 2010-12-11 11:52:39, Sergey Ivanov wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/100191/
 ---
 
 (Updated 2010-12-11 11:52:39)
 
 
 Review request for Amarok.
 
 
 Summary
 ---
 
 Rewrite tag reading stuff to make It more OOP way. Add separat classes for 
 each Tag format (ID3v2, APE, ASF, VorbisComment, MP4, MPC). Exclude almost 
 all magic words (frame/field names) from code.
 TODO:
 Implement charset detection stuff.
 
 
 Diffs
 -
 
   shared/FileType.h dc5e57b 
   shared/FileType.cpp 63d81c7 
   shared/MetaTagLib.h ff27c92 
   shared/MetaTagLib.cpp 3f7e758 
   shared/TagsFromFileNameGuesser.h PRE-CREATION 
   shared/TagsFromFileNameGuesser.cpp PRE-CREATION 
   shared/tag_helpers/APETagHelper.h PRE-CREATION 
   shared/tag_helpers/APETagHelper.cpp PRE-CREATION 
   shared/tag_helpers/ASFTagHelper.h PRE-CREATION 
   shared/tag_helpers/ASFTagHelper.cpp PRE-CREATION 
   shared/tag_helpers/ID3v2TagHelper.h PRE-CREATION 
   shared/tag_helpers/ID3v2TagHelper.cpp PRE-CREATION 
   shared/tag_helpers/MP4TagHelper.h PRE-CREATION 
   shared/tag_helpers/MP4TagHelper.cpp PRE-CREATION 
   shared/tag_helpers/StringHelper.h PRE-CREATION 
   shared/tag_helpers/StringHelper.cpp PRE-CREATION 
   shared/tag_helpers/TagHelper.h PRE-CREATION 
   shared/tag_helpers/TagHelper.cpp PRE-CREATION 
   shared/tag_helpers/VorbisCommentTagHelper.h PRE-CREATION 
   shared/tag_helpers/VorbisCommentTagHelper.cpp PRE-CREATION 
   src/CMakeLists.txt a23bbdb 
   src/core-impl/meta/file/File_p.h 9f1df54 
   src/musicbrainz/MusicBrainzFinder.cpp 78a07a6 
   utilities/collectionscanner/CMakeLists.txt 6be9319 
 
 Diff: http://git.reviewboard.kde.org/r/100191/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Sergey
 


___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helpe

[Stefan Derkits]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100088/
---

(Updated 2010-11-05 17:22:43.248928)


Review request for Amarok.


Changes
---

use constant Reference instead of copying the parameter; changed FileType.h  
FileType.cpp to amarok Coding Style; start iterating through FileTypes at 1 
instead of 0 (fileextension will probably never be other :) )


Summary
---

-) Created new Class with some Helper Functions
-) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
-) Meta::SqlTrack.type() now gets it's Information from the Database instead of 
the FileExtension


Diffs (updated)
-

  shared/FileType.h 55c80b9 
  shared/FileType.cpp PRE-CREATION 
  src/browsers/CollectionTreeItemModelBase.cpp 3f64a73 
  src/core-impl/collections/support/MemoryFilter.cpp e2509ac 
  src/widgets/MetaQueryWidget.cpp 0249edf 
  tests/synchronization/CMakeLists.txt e5df2df 

Diff: http://git.reviewboard.kde.org/r/100088/diff


Testing
---

Tested in the App, found no wrong Behaviour


Thanks,

Stefan

___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel