Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Thanks! On 3/14/2016 12:12 PM, Yuri Nesterenko wrote: +1 -yan On 03/11/2016 06:05 PM, Alexander Scherbatiy wrote: The test looks good to me. Thanks, Alexandr. On 11/03/16 16:19, Alexander Stepanov wrote: Hello Alexandr, Thank you for the explanation. Could you please review the updated test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/ The icon size was reduced. Thanks, Alexander On 3/11/2016 3:14 PM, Alexander Scherbatiy wrote: On 10/03/16 16:22, Alexander Stepanov wrote: Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X) the same for Win. / Ubuntu Linux) // a loop over the L&Fs available should be added to the initial test code. 2. as it was mentioned earlier, if replace tabbedPane.addTab("", icon, p); with tabbedPane.addTab("", p); tabbedPane.setTabComponentAt(0, new JLabel(icon)); in the code, then the user can see small but still blue icon: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png also here: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders. So all the above mentioned causes some feeling of uncoformity :) Should this tab's icon for Mac OS X L&F be allowed to be so "special"? Aqua L&F has been designed to make UI components look in the same way as native Mac OS X controls. In this case the tabbed pane icons should look like icons for NSTabView control. Thanks, Alexandr. Thanks, Alexander On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote: On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
+1 -yan On 03/11/2016 06:05 PM, Alexander Scherbatiy wrote: The test looks good to me. Thanks, Alexandr. On 11/03/16 16:19, Alexander Stepanov wrote: Hello Alexandr, Thank you for the explanation. Could you please review the updated test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/ The icon size was reduced. Thanks, Alexander On 3/11/2016 3:14 PM, Alexander Scherbatiy wrote: On 10/03/16 16:22, Alexander Stepanov wrote: Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X) the same for Win. / Ubuntu Linux) // a loop over the L&Fs available should be added to the initial test code. 2. as it was mentioned earlier, if replace tabbedPane.addTab("", icon, p); with tabbedPane.addTab("", p); tabbedPane.setTabComponentAt(0, new JLabel(icon)); in the code, then the user can see small but still blue icon: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png also here: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders. So all the above mentioned causes some feeling of uncoformity :) Should this tab's icon for Mac OS X L&F be allowed to be so "special"? Aqua L&F has been designed to make UI components look in the same way as native Mac OS X controls. In this case the tabbed pane icons should look like icons for NSTabView control. Thanks, Alexandr. Thanks, Alexander On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote: On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
No, I simply believe that Alexandr is right :) Thanks, Alexander On 3/11/2016 6:32 PM, Sergey Bylokhov wrote: On 11.03.16 15:19, Alexander Stepanov wrote: Hello Alexandr, Thank you for the explanation. Could you please review the updated test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/ Does it mean that you checked behavior of the native components? Are they behave differently? The icon size was reduced. Thanks, Alexander On 3/11/2016 3:14 PM, Alexander Scherbatiy wrote: On 10/03/16 16:22, Alexander Stepanov wrote: Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X) the same for Win. / Ubuntu Linux) // a loop over the L&Fs available should be added to the initial test code. 2. as it was mentioned earlier, if replace tabbedPane.addTab("", icon, p); with tabbedPane.addTab("", p); tabbedPane.setTabComponentAt(0, new JLabel(icon)); in the code, then the user can see small but still blue icon: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png also here: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders. So all the above mentioned causes some feeling of uncoformity :) Should this tab's icon for Mac OS X L&F be allowed to be so "special"? Aqua L&F has been designed to make UI components look in the same way as native Mac OS X controls. In this case the tabbed pane icons should look like icons for NSTabView control. Thanks, Alexandr. Thanks, Alexander On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote: On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
On 11.03.16 15:19, Alexander Stepanov wrote: Hello Alexandr, Thank you for the explanation. Could you please review the updated test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/ Does it mean that you checked behavior of the native components? Are they behave differently? The icon size was reduced. Thanks, Alexander On 3/11/2016 3:14 PM, Alexander Scherbatiy wrote: On 10/03/16 16:22, Alexander Stepanov wrote: Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X) the same for Win. / Ubuntu Linux) // a loop over the L&Fs available should be added to the initial test code. 2. as it was mentioned earlier, if replace tabbedPane.addTab("", icon, p); with tabbedPane.addTab("", p); tabbedPane.setTabComponentAt(0, new JLabel(icon)); in the code, then the user can see small but still blue icon: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png also here: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders. So all the above mentioned causes some feeling of uncoformity :) Should this tab's icon for Mac OS X L&F be allowed to be so "special"? Aqua L&F has been designed to make UI components look in the same way as native Mac OS X controls. In this case the tabbed pane icons should look like icons for NSTabView control. Thanks, Alexandr. Thanks, Alexander On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote: On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander -- Best regards, Sergey.
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
The test looks good to me. Thanks, Alexandr. On 11/03/16 16:19, Alexander Stepanov wrote: Hello Alexandr, Thank you for the explanation. Could you please review the updated test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/ The icon size was reduced. Thanks, Alexander On 3/11/2016 3:14 PM, Alexander Scherbatiy wrote: On 10/03/16 16:22, Alexander Stepanov wrote: Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X) the same for Win. / Ubuntu Linux) // a loop over the L&Fs available should be added to the initial test code. 2. as it was mentioned earlier, if replace tabbedPane.addTab("", icon, p); with tabbedPane.addTab("", p); tabbedPane.setTabComponentAt(0, new JLabel(icon)); in the code, then the user can see small but still blue icon: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png also here: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders. So all the above mentioned causes some feeling of uncoformity :) Should this tab's icon for Mac OS X L&F be allowed to be so "special"? Aqua L&F has been designed to make UI components look in the same way as native Mac OS X controls. In this case the tabbed pane icons should look like icons for NSTabView control. Thanks, Alexandr. Thanks, Alexander On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote: On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Hello Alexandr, Thank you for the explanation. Could you please review the updated test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/ The icon size was reduced. Thanks, Alexander On 3/11/2016 3:14 PM, Alexander Scherbatiy wrote: On 10/03/16 16:22, Alexander Stepanov wrote: Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X) the same for Win. / Ubuntu Linux) // a loop over the L&Fs available should be added to the initial test code. 2. as it was mentioned earlier, if replace tabbedPane.addTab("", icon, p); with tabbedPane.addTab("", p); tabbedPane.setTabComponentAt(0, new JLabel(icon)); in the code, then the user can see small but still blue icon: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png also here: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders. So all the above mentioned causes some feeling of uncoformity :) Should this tab's icon for Mac OS X L&F be allowed to be so "special"? Aqua L&F has been designed to make UI components look in the same way as native Mac OS X controls. In this case the tabbed pane icons should look like icons for NSTabView control. Thanks, Alexandr. Thanks, Alexander On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote: On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
On 10/03/16 16:22, Alexander Stepanov wrote: Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X) the same for Win. / Ubuntu Linux) // a loop over the L&Fs available should be added to the initial test code. 2. as it was mentioned earlier, if replace tabbedPane.addTab("", icon, p); with tabbedPane.addTab("", p); tabbedPane.setTabComponentAt(0, new JLabel(icon)); in the code, then the user can see small but still blue icon: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png also here: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders. So all the above mentioned causes some feeling of uncoformity :) Should this tab's icon for Mac OS X L&F be allowed to be so "special"? Aqua L&F has been designed to make UI components look in the same way as native Mac OS X controls. In this case the tabbed pane icons should look like icons for NSTabView control. Thanks, Alexandr. Thanks, Alexander On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote: On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.03/ - should pass on OS X after JDK-8151303 fix. 16x16 and 32x32 icons are used for the tab; the loop over L&Fs added. Thanks, Alexander On 3/10/2016 3:22 PM, Alexander Stepanov wrote: Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X) the same for Win. / Ubuntu Linux) // a loop over the L&Fs available should be added to the initial test code. 2. as it was mentioned earlier, if replace tabbedPane.addTab("", icon, p); with tabbedPane.addTab("", p); tabbedPane.setTabComponentAt(0, new JLabel(icon)); in the code, then the user can see small but still blue icon: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png also here: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders. So all the above mentioned causes some feeling of uncoformity :) Should this tab's icon for Mac OS X L&F be allowed to be so "special"? Thanks, Alexander On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote: On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Hello Alexandr, Thank you for the comment. Please note that: 1. this hard-coded icon size for the tab is seemingly used only for Mac OS X L&F, please see http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-1.png (for other L&Fs the tab's size is adjusted to the icon's size. L&Fs are: Metal, Nimbus, CDE/Motif, Mac OS X) the same for Win. / Ubuntu Linux) // a loop over the L&Fs available should be added to the initial test code. 2. as it was mentioned earlier, if replace tabbedPane.addTab("", icon, p); with tabbedPane.addTab("", p); tabbedPane.setTabComponentAt(0, new JLabel(icon)); in the code, then the user can see small but still blue icon: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-2.png also here: http://cr.openjdk.java.net/~avstepan/8150724/screenshots/screenshot-3.png it can be seen that the icons for the other components remain hi-res. even when going out of the component borders. So all the above mentioned causes some feeling of uncoformity :) Should this tab's icon for Mac OS X L&F be allowed to be so "special"? Thanks, Alexander On 3/9/2016 7:10 PM, Alexander Scherbatiy wrote: On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
On 03/03/16 18:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. There is no issue because the ImageIcon with base image size 35 and high-resolution image size 70 is requested to be painted into region 32x32 for JTabbedPane icon. In this case the base image has enough quality to be painted in this region. To check that MultiResolutionImage is properly painted for JTabbedIcon it is possible to use BaseMultiResolutionImage with images with sizes 16x16 and 32x32. Thanks, Alexandr. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
They are used for the further coordinates obtaining (on OS X the icon sizes are not equal for the buttons and the tabbed pane - please see the screenshot attached to JDK-8151060): Please see lines 187-189: 187 Component tc = tabbedPane.getTabComponentAt(1); 188 x = tc.getLocationOnScreen().x + tc.getWidth() / 2; 189 c = r.getPixelColor(x, y); It seems to be a quite reliable way to get the proper x coordinate value here instead of guessing. (we do not need that for Linux and Win.) Regards, Alexander On 3/9/2016 6:59 PM, Sergey Bylokhov wrote: Can you please clarify these lines: 117 tabbedPane.addTab("", new JPanel()); 118 tabbedPane.setTabComponentAt(1, new JLabel()); On 09.03.16 18:48, Alexander Stepanov wrote: Hello, Sergey, Please see the updated version of the test: http://cr.openjdk.java.net/~avstepan/8150724/webrev.02/ (covers JDK-8151303 as well). > I suggest to add these lines to the test instead of replace the old lines done. please see "@requires tag" - for now it will stop test run on OS X. Thanks, Alexander On 3/4/2016 7:08 PM, Alexander Stepanov wrote: The test should be updated to cover the related issue https://bugs.openjdk.java.net/browse/JDK-8151303 Regards, Alexander On 3/4/2016 1:15 PM, Alexander Stepanov wrote: Hello, Sergey, We have JLabel(icon) already in the test, and we cannot have both these cases at the same tab. Moreover, we can in principle use some other components as an argument of 'setTabComponentAt', but I'm not sure that these cases have some novelty. So my suggestion is to can simply return to the old version of the test (which will fail on OS X) or add it commented with some "TODO: uncomment / replace after 8151060 fix" instruction in code. Thanks, Alexander On 3/4/2016 1:21 AM, Sergey Bylokhov wrote: Hi, Alexander. I suggest to add these lines to the test instead of replace the old lines. The test will pass after the fix for 8151060. On 03.03.16 17:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Can you please clarify these lines: 117 tabbedPane.addTab("", new JPanel()); 118 tabbedPane.setTabComponentAt(1, new JLabel()); On 09.03.16 18:48, Alexander Stepanov wrote: Hello, Sergey, Please see the updated version of the test: http://cr.openjdk.java.net/~avstepan/8150724/webrev.02/ (covers JDK-8151303 as well). > I suggest to add these lines to the test instead of replace the old lines done. please see "@requires tag" - for now it will stop test run on OS X. Thanks, Alexander On 3/4/2016 7:08 PM, Alexander Stepanov wrote: The test should be updated to cover the related issue https://bugs.openjdk.java.net/browse/JDK-8151303 Regards, Alexander On 3/4/2016 1:15 PM, Alexander Stepanov wrote: Hello, Sergey, We have JLabel(icon) already in the test, and we cannot have both these cases at the same tab. Moreover, we can in principle use some other components as an argument of 'setTabComponentAt', but I'm not sure that these cases have some novelty. So my suggestion is to can simply return to the old version of the test (which will fail on OS X) or add it commented with some "TODO: uncomment / replace after 8151060 fix" instruction in code. Thanks, Alexander On 3/4/2016 1:21 AM, Sergey Bylokhov wrote: Hi, Alexander. I suggest to add these lines to the test instead of replace the old lines. The test will pass after the fix for 8151060. On 03.03.16 17:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander -- Best regards, Sergey.
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Hello, Sergey, Please see the updated version of the test: http://cr.openjdk.java.net/~avstepan/8150724/webrev.02/ (covers JDK-8151303 as well). > I suggest to add these lines to the test instead of replace the old lines done. please see "@requires tag" - for now it will stop test run on OS X. Thanks, Alexander On 3/4/2016 7:08 PM, Alexander Stepanov wrote: The test should be updated to cover the related issue https://bugs.openjdk.java.net/browse/JDK-8151303 Regards, Alexander On 3/4/2016 1:15 PM, Alexander Stepanov wrote: Hello, Sergey, We have JLabel(icon) already in the test, and we cannot have both these cases at the same tab. Moreover, we can in principle use some other components as an argument of 'setTabComponentAt', but I'm not sure that these cases have some novelty. So my suggestion is to can simply return to the old version of the test (which will fail on OS X) or add it commented with some "TODO: uncomment / replace after 8151060 fix" instruction in code. Thanks, Alexander On 3/4/2016 1:21 AM, Sergey Bylokhov wrote: Hi, Alexander. I suggest to add these lines to the test instead of replace the old lines. The test will pass after the fix for 8151060. On 03.03.16 17:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
The test should be updated to cover the related issue https://bugs.openjdk.java.net/browse/JDK-8151303 Regards, Alexander On 3/4/2016 1:15 PM, Alexander Stepanov wrote: Hello, Sergey, We have JLabel(icon) already in the test, and we cannot have both these cases at the same tab. Moreover, we can in principle use some other components as an argument of 'setTabComponentAt', but I'm not sure that these cases have some novelty. So my suggestion is to can simply return to the old version of the test (which will fail on OS X) or add it commented with some "TODO: uncomment / replace after 8151060 fix" instruction in code. Thanks, Alexander On 3/4/2016 1:21 AM, Sergey Bylokhov wrote: Hi, Alexander. I suggest to add these lines to the test instead of replace the old lines. The test will pass after the fix for 8151060. On 03.03.16 17:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Hello, Sergey, We have JLabel(icon) already in the test, and we cannot have both these cases at the same tab. Moreover, we can in principle use some other components as an argument of 'setTabComponentAt', but I'm not sure that these cases have some novelty. So my suggestion is to can simply return to the old version of the test (which will fail on OS X) or add it commented with some "TODO: uncomment / replace after 8151060 fix" instruction in code. Thanks, Alexander On 3/4/2016 1:21 AM, Sergey Bylokhov wrote: Hi, Alexander. I suggest to add these lines to the test instead of replace the old lines. The test will pass after the fix for 8151060. On 03.03.16 17:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Hi, Alexander. I suggest to add these lines to the test instead of replace the old lines. The test will pass after the fix for 8151060. On 03.03.16 17:45, Alexander Stepanov wrote: Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander -- Best regards, Sergey.
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Could you please review the updated version of the test? http://cr.openjdk.java.net/~avstepan/8150724/webrev.01 Line 106 tabbedPane.addTab("", icon, p); was replaced with 109 tabbedPane.addTab("", p); 110 tabbedPane.setTabComponentAt(0, new JLabel(icon)); - in such a case the test passes for OS X (as well as for Windows, Linux). Probably these changes should be reverted after JDK-8151060 fix. Thanks, Alexander On 3/2/2016 7:15 PM, Alexander Stepanov wrote: Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Hello Sergey, It fails because of https://bugs.openjdk.java.net/browse/JDK-8151060 (plus we need here some tricky check for resolution by the analogy with 8150258 because of JDK-8150844). Thanks, Alexander On 2/26/2016 4:25 PM, Sergey Bylokhov wrote: Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander
Re: [9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Hi, Alexander. The test failed on osx 10.11 + retina. Is it expected? On 26.02.16 15:53, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander -- Best regards, Sergey.
[9] RFR for 8150724: [TEST] HiDPI: create a test for multiresolution icons
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8150724/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8150724 ? Just a single test added. Thanks, Alexander