Re: [Axis2] Review API changes for r431798 (Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965))
Ok, great. I had a feeling we must have had a disconnect somewhere :-) I'm more than happy to add a disclaimer in the comments. Thanks, Lori. Lori Van Gulick WebSphere Development IBM Austin (512) 838-7929 Sanjiva Weerawarana [EMAIL PROTECTED] 08/18/2006 12:18 AM Please respond to axis-dev@ws.apache.org To [EMAIL PROTECTED] cc axis-dev@ws.apache.org Subject Re: [Axis2] Review API changes for r431798 (Re: [Axis2][VOTE]handling WSDL's multiple services/ports (JIRA-965)) Ouch. Sorry Lori Dims: I missed what this change was impacting. As this does not touch ServiceClient and is just adding two new classes to do this I'm absolutely fine with it. Please consider my -1 lifted. Lori can you please put some comments there saying that this is a temporary solution which we may improve. Thanks, Sanjiva. On Thu, 2006-08-17 at 08:42 -0400, Davanum Srinivas wrote: Sanjiva, If the concern is about API Change Please *review* the API change: http://ws.zones.apache.org/~dims/r431798/newdocs/changes.html Please note that there are outstanding issue for multiple services in wsdl. We have to start somewhere... http://issues.apache.org/jira/browse/AXIS2-352 We can put a big disclaimer on the 2 new classes which will serve the purpose if dissuading folks who may try to use it. Other than that, it looks ok to me. thanks, dims On 8/17/06, Sanjiva Weerawarana [EMAIL PROTECTED] wrote: On Wed, 2006-08-16 at 14:43 -0500, Lori Van Gulick wrote: Vote: Accept the changes for JIRA-965 as an interim solution. I don't like this .. this is an API change and once we do it we can't remove it. So I'd prefer to fix it properly and am -1 for it. Do you guys need this for 1.1 or can it wait until after 1.1? Why can there not be a private API that does this same function but does not go into the main API right now? Ajith's point is relevant too- unless this is followed thru to codegen then I don't see why a separate class can't be used. (I'm sorry I haven't been more responsive .. I'm been totally swamped with ApacheCon Asia stuff and just haven't been able to keep up.) Sanjiva. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Axis2] Review API changes for r431798 (Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965))
Ok, I have added the following disclaimer to the new classes: * DISCLAIMER: This is intended as a TEMPORARY solution ONLY. * A more permanent solution will involve changes to the description hierarchy to handle * services with multiple ports/endpoints. When the permanent * solution is available this class may no longer be supported. * I have attached Disclaimer_patch.txt to JIRA-965, which contains the addition of the disclaimer to WSDL11ToAllAxisServicesBuilder.java and WSDL20ToAllAxisServicesBuilder.java. Thanks, Lori. Lori Van Gulick WebSphere Development IBM Austin (512) 838-7929 Davanum Srinivas [EMAIL PROTECTED] 08/17/2006 07:42 AM Please respond to axis-dev@ws.apache.org To axis-dev@ws.apache.org cc Subject [Axis2] Review API changes for r431798 (Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965)) Sanjiva, If the concern is about API Change Please *review* the API change: http://ws.zones.apache.org/~dims/r431798/newdocs/changes.html Please note that there are outstanding issue for multiple services in wsdl. We have to start somewhere... http://issues.apache.org/jira/browse/AXIS2-352 We can put a big disclaimer on the 2 new classes which will serve the purpose if dissuading folks who may try to use it. Other than that, it looks ok to me. thanks, dims On 8/17/06, Sanjiva Weerawarana [EMAIL PROTECTED] wrote: On Wed, 2006-08-16 at 14:43 -0500, Lori Van Gulick wrote: Vote: Accept the changes for JIRA-965 as an interim solution. I don't like this .. this is an API change and once we do it we can't remove it. So I'd prefer to fix it properly and am -1 for it. Do you guys need this for 1.1 or can it wait until after 1.1? Why can there not be a private API that does this same function but does not go into the main API right now? Ajith's point is relevant too- unless this is followed thru to codegen then I don't see why a separate class can't be used. (I'm sorry I haven't been more responsive .. I'm been totally swamped with ApacheCon Asia stuff and just haven't been able to keep up.) Sanjiva. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965)
On Wed, 2006-08-16 at 14:43 -0500, Lori Van Gulick wrote: Vote: Accept the changes for JIRA-965 as an interim solution. I don't like this .. this is an API change and once we do it we can't remove it. So I'd prefer to fix it properly and am -1 for it. Do you guys need this for 1.1 or can it wait until after 1.1? Why can there not be a private API that does this same function but does not go into the main API right now? Ajith's point is relevant too- unless this is followed thru to codegen then I don't see why a separate class can't be used. (I'm sorry I haven't been more responsive .. I'm been totally swamped with ApacheCon Asia stuff and just haven't been able to keep up.) Sanjiva. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Axis2] Review API changes for r431798 (Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965))
Sanjiva, If the concern is about API Change Please *review* the API change: http://ws.zones.apache.org/~dims/r431798/newdocs/changes.html Please note that there are outstanding issue for multiple services in wsdl. We have to start somewhere... http://issues.apache.org/jira/browse/AXIS2-352 We can put a big disclaimer on the 2 new classes which will serve the purpose if dissuading folks who may try to use it. Other than that, it looks ok to me. thanks, dims On 8/17/06, Sanjiva Weerawarana [EMAIL PROTECTED] wrote: On Wed, 2006-08-16 at 14:43 -0500, Lori Van Gulick wrote: Vote: Accept the changes for JIRA-965 as an interim solution. I don't like this .. this is an API change and once we do it we can't remove it. So I'd prefer to fix it properly and am -1 for it. Do you guys need this for 1.1 or can it wait until after 1.1? Why can there not be a private API that does this same function but does not go into the main API right now? Ajith's point is relevant too- unless this is followed thru to codegen then I don't see why a separate class can't be used. (I'm sorry I haven't been more responsive .. I'm been totally swamped with ApacheCon Asia stuff and just haven't been able to keep up.) Sanjiva. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965)
Hi Ajith, This change does not affect codegen. Right now we are only concerned with being able to get multiple, unique AxisService objects from a WSDL that contains multiple services/ports. I probably should have included a link to the jira - it contains more info on the design. http://issues.apache.org/jira/browse/AXIS2-965. Thanks, Lori. Lori Van Gulick WebSphere Development IBM Austin (512) 838-7929 Ajith Ranabahu [EMAIL PROTECTED] 08/16/2006 03:24 PM Please respond to axis-dev@ws.apache.org To axis-dev@ws.apache.org, [EMAIL PROTECTED] cc Subject Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965) Hi, Are we talking about generating code for multiple services/ports at the same time ? we could have modified the codegen to run across the diffrent ports/services in seperate passes! Ajith On 8/16/06, Davanum Srinivas [EMAIL PROTECTED] wrote: Don't really need a vote on this. i'll check it in right now. thanks, dims On 8/16/06, Davanum Srinivas [EMAIL PROTECTED] wrote: +1 from me. On 8/16/06, Lori Van Gulick [EMAIL PROTECTED] wrote: Vote: Accept the changes for JIRA-965 as an interim solution. Hi, I have submitted a patch for JIRA-965 which contains an extension to WSDL11ToAxisServiceBuilder which will retrieve all the ports on all the services in the WSDL and return them as a List of AxisService objects. Only users of the new extension would see the new behavior. Existing users of WSDL11ToAxisServiceBuilder will not be affected. I have verified that all the tests still pass with the patch. The patch also contains cooresponding changes for WSDL20ToAxisServiceBuilder, and a new test for the new extensions. Concerns have been expressed here on the mailing list that this is not the correct solution to the problem. A more correct solution would be to add an axisEndpoint object. The details of this change have yet to be worked out, but it seems clear to me that this will be a significant change which we would not want to undertake at this point given that we are trying to stabilize Axis2 for a 1.1 release. I need this functionality as soon as possible, so I would like to be able to commit my change as an interim solution. Once Axis2 1.1 is complete I would like to revisit the topic of adding axisEndpoint and work out all the details at that point. Thanks, Lori. Lori Van Gulick WebSphere Development IBM Austin (512) 838-7929 -- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) -- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ajith Ranabahu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Axis2] Review API changes for r431798 (Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965))
Ouch. Sorry Lori Dims: I missed what this change was impacting. As this does not touch ServiceClient and is just adding two new classes to do this I'm absolutely fine with it. Please consider my -1 lifted. Lori can you please put some comments there saying that this is a temporary solution which we may improve. Thanks, Sanjiva. On Thu, 2006-08-17 at 08:42 -0400, Davanum Srinivas wrote: Sanjiva, If the concern is about API Change Please *review* the API change: http://ws.zones.apache.org/~dims/r431798/newdocs/changes.html Please note that there are outstanding issue for multiple services in wsdl. We have to start somewhere... http://issues.apache.org/jira/browse/AXIS2-352 We can put a big disclaimer on the 2 new classes which will serve the purpose if dissuading folks who may try to use it. Other than that, it looks ok to me. thanks, dims On 8/17/06, Sanjiva Weerawarana [EMAIL PROTECTED] wrote: On Wed, 2006-08-16 at 14:43 -0500, Lori Van Gulick wrote: Vote: Accept the changes for JIRA-965 as an interim solution. I don't like this .. this is an API change and once we do it we can't remove it. So I'd prefer to fix it properly and am -1 for it. Do you guys need this for 1.1 or can it wait until after 1.1? Why can there not be a private API that does this same function but does not go into the main API right now? Ajith's point is relevant too- unless this is followed thru to codegen then I don't see why a separate class can't be used. (I'm sorry I haven't been more responsive .. I'm been totally swamped with ApacheCon Asia stuff and just haven't been able to keep up.) Sanjiva. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965)
Vote: Accept the changes for JIRA-965 as an interim solution. Hi, I have submitted a patch for JIRA-965 which contains an extension to WSDL11ToAxisServiceBuilder which will retrieve all the ports on all the services in the WSDL and return them as a List of AxisService objects. Only users of the new extension would see the new behavior. Existing users of WSDL11ToAxisServiceBuilder will not be affected. I have verified that all the tests still pass with the patch. The patch also contains cooresponding changes for WSDL20ToAxisServiceBuilder, and a new test for the new extensions. Concerns have been expressed here on the mailing list that this is not the correct solution to the problem. A more correct solution would be to add an axisEndpoint object. The details of this change have yet to be worked out, but it seems clear to me that this will be a significant change which we would not want to undertake at this point given that we are trying to stabilize Axis2 for a 1.1 release. I need this functionality as soon as possible, so I would like to be able to commit my change as an interim solution. Once Axis2 1.1 is complete I would like to revisit the topic of adding axisEndpoint and work out all the details at that point. Thanks, Lori. Lori Van Gulick WebSphere Development IBM Austin (512) 838-7929
Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965)
+1 from me. On 8/16/06, Lori Van Gulick [EMAIL PROTECTED] wrote: Vote: Accept the changes for JIRA-965 as an interim solution. Hi, I have submitted a patch for JIRA-965 which contains an extension to WSDL11ToAxisServiceBuilder which will retrieve all the ports on all the services in the WSDL and return them as a List of AxisService objects. Only users of the new extension would see the new behavior. Existing users of WSDL11ToAxisServiceBuilder will not be affected. I have verified that all the tests still pass with the patch. The patch also contains cooresponding changes for WSDL20ToAxisServiceBuilder, and a new test for the new extensions. Concerns have been expressed here on the mailing list that this is not the correct solution to the problem. A more correct solution would be to add an axisEndpoint object. The details of this change have yet to be worked out, but it seems clear to me that this will be a significant change which we would not want to undertake at this point given that we are trying to stabilize Axis2 for a 1.1 release. I need this functionality as soon as possible, so I would like to be able to commit my change as an interim solution. Once Axis2 1.1 is complete I would like to revisit the topic of adding axisEndpoint and work out all the details at that point. Thanks, Lori. Lori Van Gulick WebSphere Development IBM Austin (512) 838-7929 -- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965)
Don't really need a vote on this. i'll check it in right now. thanks, dims On 8/16/06, Davanum Srinivas [EMAIL PROTECTED] wrote: +1 from me. On 8/16/06, Lori Van Gulick [EMAIL PROTECTED] wrote: Vote: Accept the changes for JIRA-965 as an interim solution. Hi, I have submitted a patch for JIRA-965 which contains an extension to WSDL11ToAxisServiceBuilder which will retrieve all the ports on all the services in the WSDL and return them as a List of AxisService objects. Only users of the new extension would see the new behavior. Existing users of WSDL11ToAxisServiceBuilder will not be affected. I have verified that all the tests still pass with the patch. The patch also contains cooresponding changes for WSDL20ToAxisServiceBuilder, and a new test for the new extensions. Concerns have been expressed here on the mailing list that this is not the correct solution to the problem. A more correct solution would be to add an axisEndpoint object. The details of this change have yet to be worked out, but it seems clear to me that this will be a significant change which we would not want to undertake at this point given that we are trying to stabilize Axis2 for a 1.1 release. I need this functionality as soon as possible, so I would like to be able to commit my change as an interim solution. Once Axis2 1.1 is complete I would like to revisit the topic of adding axisEndpoint and work out all the details at that point. Thanks, Lori. Lori Van Gulick WebSphere Development IBM Austin (512) 838-7929 -- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) -- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Axis2][VOTE] handling WSDL's multiple services/ports (JIRA-965)
Hi, Are we talking about generating code for multiple services/ports at the same time ? we could have modified the codegen to run across the diffrent ports/services in seperate passes! Ajith On 8/16/06, Davanum Srinivas [EMAIL PROTECTED] wrote: Don't really need a vote on this. i'll check it in right now. thanks, dims On 8/16/06, Davanum Srinivas [EMAIL PROTECTED] wrote: +1 from me. On 8/16/06, Lori Van Gulick [EMAIL PROTECTED] wrote: Vote: Accept the changes for JIRA-965 as an interim solution. Hi, I have submitted a patch for JIRA-965 which contains an extension to WSDL11ToAxisServiceBuilder which will retrieve all the ports on all the services in the WSDL and return them as a List of AxisService objects. Only users of the new extension would see the new behavior. Existing users of WSDL11ToAxisServiceBuilder will not be affected. I have verified that all the tests still pass with the patch. The patch also contains cooresponding changes for WSDL20ToAxisServiceBuilder, and a new test for the new extensions. Concerns have been expressed here on the mailing list that this is not the correct solution to the problem. A more correct solution would be to add an axisEndpoint object. The details of this change have yet to be worked out, but it seems clear to me that this will be a significant change which we would not want to undertake at this point given that we are trying to stabilize Axis2 for a 1.1 release. I need this functionality as soon as possible, so I would like to be able to commit my change as an interim solution. Once Axis2 1.1 is complete I would like to revisit the topic of adding axisEndpoint and work out all the details at that point. Thanks, Lori. Lori Van Gulick WebSphere Development IBM Austin (512) 838-7929 -- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) -- Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Ajith Ranabahu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
