Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-15 Thread Attila Fülöp 

David Duchscher wrote:

On Nov 11, 2005, at 3:55 PM, Kern Sibbald wrote:


On Friday 11 November 2005 22:33, David Duchscher wrote:


On Nov 11, 2005, at 11:23 AM, Attila Fülöp wrote:


Kern Sibbald wrote:


On Friday 11 November 2005 15:33, Attila Fülöp wrote:


David Duchscher wrote:


On Nov 10, 2005, at 2:39 PM, Kern Sibbald wrote:


On Thursday 10 November 2005 21:22, Attila Fülöp wrote:



snip/


Is the patch mentioned in this thread integrated into 1.38,
that is
do ACLs work with FreeBSD? And second, even more important  to me,
do ACLs work with Solaris clients?



snip/


I can confirm that Solaris doesn't work.  Their is code for  Solaris
ACLs but the configure script does not detect ACL support on
Solaris.
I helped with Darwin and FreeBSD but I have not had time to
really look
at Solaris fully until yesterday.  Seems disaster  recovery is
now top
priority for the next few weeks.  Ah, the life of  changing
priorities.



Ok, than I will try to patch configure.in to detect ACL support
on solaris.



That would be very kind of you ... :-)



All right, I'll do. That said, it may take some time since I've  no sun
at home and are not that familiar with autoconf.



autoconf is easy to fix.  I have detection working now.  There is
also an issue with a ifdef in src/filed/acl.c that now that I look at
the code again, limits 1.38.0 to FreeBSD, Darwin, and Linux.  I had
just added FreeBSD and Darwin to the ifdef when I made my changes.  I
was trying not to change too many things and I had only tested those
platforms.  I am thinking that we should remove the ifdef or at least
enable the POSIX platforms.  Thoughts?



I probably won't have any problems moving a #ifdef, but I'll need  to 
see it. I
consider such changes low impact if it just adds code for another  
platform.




As for Solaris, I have things mostly working on Solaris.  There is at
least one bug in the code currently in 1.38.0 and I am seeing another
strangeness when ACLs are restored.  I also have to figure out the
best way to bypass smartalloc to free the system call memory since I
am very new to smartalloc.  The good news is that we have lots of
Sun's around here that the admins have graciously given me access so
I can test things.  Hopefully I will have things working by the end
of the weekend.



Try: actuallyfree(void *);



Here is the patch to fix ACLs on Solaris systems.  I have tested the  
code on a Solaris 2.6 system and have tested template of the code on  
these systems and filesystems:


  SunOS 5.6 Generic_105181-16UFS
  SunOS 5.8 Generic_108528-08NFS (to SunOS 5.9 Generic_117171-08)
  SunOS 5.8 Generic_108528-23UFS
  SunOS 5.8 Generic_108528-23VxFS
  SunOS 5.9 Generic_112233-05UFS
  SunOS 5.10 Generic_118822-19UFS

Please give it look.

Index: src/filed/acl.c
===
RCS file: /cvsroot/bacula/bacula/src/filed/acl.c,v
retrieving revision 1.10
diff -u -r1.10 acl.c
--- src/filed/acl.c 6 Aug 2005 14:48:19 -   1.10
+++ src/filed/acl.c 14 Nov 2005 19:58:16 -
@@ -47,10 +47,6 @@
#include bacula.h
#include filed.h
-/* So we can free system allocated memory */
-#undef free
-#undef malloc
-#define malloc * dont use malloc in this routine
#else
/*
@@ -117,6 +113,9 @@
|| !( defined(HAVE_LINUX_OS) \
   || defined(HAVE_FREEBSD_OS) \
   || defined(HAVE_DARWIN_OS) \
+  || defined(HAVE_IRIX_OS) \
+  || defined(HAVE_OSF1_OS) \
+  || defined(HAVE_SUN_OS) \
)
/* bacl_get() returns the lenght of the string, or -1 on error. */
@@ -318,7 +317,7 @@
if (acl(jcr-last_fname, GETACL, n, acls) == n) {
   if ((acl_text = acltotext(acls, n)) != NULL) {
  len = pm_strcpy(jcr-acl_text, acl_text);
- free(acl_text);
+ actuallyfree(acl_text);
  free(acls);
  return len;
   }
@@ -336,11 +335,11 @@
if (!acls) {
   return -1;
}
-   if (acl(jcr-last_fname, SETACL, n, acls) != 0) {
-  free(acls);
+   if (acl(jcr-last_fname, SETACL, n, acls) == -1) {
+  actuallyfree(acls);
   return -1;
}
-   free(acls);
+   actuallyfree(acls);
return 0;
}

--
DaveD



Thanks Dave,

I've tested the code on SunOS 5.9 with ufs and it works. I'll be waiting
until the FreeBSD port and the blastwave package of 1.38.1 are out before
putting 1.38.1 into production. Until then i will test more thoroughly.

One thing i noticed while looking at the code is that the code relies on
the fact that the ACLs of directories are restored after the content of
that directory. I think this is always true for bacula.


Attila






---
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_idv28alloc_id845op=click
___

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-14 Thread David Duchscher 

On Nov 10, 2005, at 2:39 PM, Kern Sibbald wrote:


On Thursday 10 November 2005 21:22, Attila Fülöp wrote:

Referring to the thread [Bacula-users] ACL's with Bacula on FreeBSD
(resend) started by Tony Lambregts on 20.07.2005 20:15 I need some
clarifications.

Is the patch mentioned in this thread integrated into 1.38, that is
do ACLs work with FreeBSD? And second, even more important to me,
do ACLs work with Solaris clients?



Skimming over sys/acl.h on
Solaris 2.9 it seems this is quite a different API.

Yes, so are some of the others ...


I'm forced to use ACLs soon, and need a way to back them up. So I
would try to patch in support for Solaris ACLs if it's needed.


To the best of my knowledge with that patch integrated, ACLs
should now work on:

AIX
FreeBSD
Darwin
Irix
OSF1
Linux
HPUX
Solaris

Linux, Darwin, and FreeBSD have been pretty well tested.  The  
others *should*
work, but I don't recall anyone giving definitive feedback (correct  
me if I

am mistaken).


I can confirm that Solaris doesn't work.  Their is code for Solaris  
ACLs but the configure script does not detect ACL support on  
Solaris.  I helped with Darwin and FreeBSD but I have not had time to  
really look at Solaris fully until yesterday.  Seems disaster  
recovery is now top priority for the next few weeks.  Ah, the life of  
changing priorities.


--
DaveD




---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-14 Thread David Duchscher 

On Nov 11, 2005, at 3:55 PM, Kern Sibbald wrote:


On Friday 11 November 2005 22:33, David Duchscher wrote:

On Nov 11, 2005, at 11:23 AM, Attila Fülöp wrote:

Kern Sibbald wrote:

On Friday 11 November 2005 15:33, Attila Fülöp wrote:

David Duchscher wrote:

On Nov 10, 2005, at 2:39 PM, Kern Sibbald wrote:

On Thursday 10 November 2005 21:22, Attila Fülöp wrote:


snip/


Is the patch mentioned in this thread integrated into 1.38,
that is
do ACLs work with FreeBSD? And second, even more important  
to me,

do ACLs work with Solaris clients?


snip/

I can confirm that Solaris doesn't work.  Their is code for  
Solaris

ACLs but the configure script does not detect ACL support on
Solaris.
I helped with Darwin and FreeBSD but I have not had time to
really look
at Solaris fully until yesterday.  Seems disaster  recovery is
now top
priority for the next few weeks.  Ah, the life of  changing
priorities.


Ok, than I will try to patch configure.in to detect ACL support
on solaris.


That would be very kind of you ... :-)


All right, I'll do. That said, it may take some time since I've  
no sun

at home and are not that familiar with autoconf.


autoconf is easy to fix.  I have detection working now.  There is
also an issue with a ifdef in src/filed/acl.c that now that I look at
the code again, limits 1.38.0 to FreeBSD, Darwin, and Linux.  I had
just added FreeBSD and Darwin to the ifdef when I made my changes.  I
was trying not to change too many things and I had only tested those
platforms.  I am thinking that we should remove the ifdef or at least
enable the POSIX platforms.  Thoughts?


I probably won't have any problems moving a #ifdef, but I'll need  
to see it. I
consider such changes low impact if it just adds code for another  
platform.




As for Solaris, I have things mostly working on Solaris.  There is at
least one bug in the code currently in 1.38.0 and I am seeing another
strangeness when ACLs are restored.  I also have to figure out the
best way to bypass smartalloc to free the system call memory since I
am very new to smartalloc.  The good news is that we have lots of
Sun's around here that the admins have graciously given me access so
I can test things.  Hopefully I will have things working by the end
of the weekend.


Try: actuallyfree(void *);


Here is the patch to fix ACLs on Solaris systems.  I have tested the  
code on a Solaris 2.6 system and have tested template of the code on  
these systems and filesystems:


  SunOS 5.6 Generic_105181-16   UFS
  SunOS 5.8 Generic_108528-08   NFS (to SunOS 5.9 Generic_117171-08)
  SunOS 5.8 Generic_108528-23   UFS
  SunOS 5.8 Generic_108528-23   VxFS
  SunOS 5.9 Generic_112233-05   UFS
  SunOS 5.10 Generic_118822-19  UFS

Please give it look.

Index: src/filed/acl.c
===
RCS file: /cvsroot/bacula/bacula/src/filed/acl.c,v
retrieving revision 1.10
diff -u -r1.10 acl.c
--- src/filed/acl.c 6 Aug 2005 14:48:19 -   1.10
+++ src/filed/acl.c 14 Nov 2005 19:58:16 -
@@ -47,10 +47,6 @@
#include bacula.h
#include filed.h
-/* So we can free system allocated memory */
-#undef free
-#undef malloc
-#define malloc * dont use malloc in this routine
#else
/*
@@ -117,6 +113,9 @@
|| !( defined(HAVE_LINUX_OS) \
   || defined(HAVE_FREEBSD_OS) \
   || defined(HAVE_DARWIN_OS) \
+  || defined(HAVE_IRIX_OS) \
+  || defined(HAVE_OSF1_OS) \
+  || defined(HAVE_SUN_OS) \
)
/* bacl_get() returns the lenght of the string, or -1 on error. */
@@ -318,7 +317,7 @@
if (acl(jcr-last_fname, GETACL, n, acls) == n) {
   if ((acl_text = acltotext(acls, n)) != NULL) {
  len = pm_strcpy(jcr-acl_text, acl_text);
- free(acl_text);
+ actuallyfree(acl_text);
  free(acls);
  return len;
   }
@@ -336,11 +335,11 @@
if (!acls) {
   return -1;
}
-   if (acl(jcr-last_fname, SETACL, n, acls) != 0) {
-  free(acls);
+   if (acl(jcr-last_fname, SETACL, n, acls) == -1) {
+  actuallyfree(acls);
   return -1;
}
-   free(acls);
+   actuallyfree(acls);
return 0;
}

--
DaveD



---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-14 Thread Kern Sibbald 
On Monday 14 November 2005 20:58, David Duchscher wrote:
...

 Here is the patch to fix ACLs on Solaris systems.  I have tested the
 code on a Solaris 2.6 system and have tested template of the code on
 these systems and filesystems:

SunOS 5.6 Generic_105181-16UFS
SunOS 5.8 Generic_108528-08NFS (to SunOS 5.9 Generic_117171-08)
SunOS 5.8 Generic_108528-23UFS
SunOS 5.8 Generic_108528-23VxFS
SunOS 5.9 Generic_112233-05UFS
SunOS 5.10 Generic_118822-19   UFS

Impressive testing!  :-)


 Please give it look.

This looks concervative enough that I can include it in 1.38.1.  However, cut 
and paste just doesn't work from email, so I had to apply it by hand.  Please 
check the CVS (revision 1.11) to make sure I didn't botch it up.  It may take 
a few hours for the developer's CVS to filter down ...


 Index: src/filed/acl.c
 ===
 RCS file: /cvsroot/bacula/bacula/src/filed/acl.c,v
 retrieving revision 1.10
 diff -u -r1.10 acl.c
 --- src/filed/acl.c 6 Aug 2005 14:48:19 -   1.10
 +++ src/filed/acl.c 14 Nov 2005 19:58:16 -
 @@ -47,10 +47,6 @@
 #include bacula.h
 #include filed.h
 -/* So we can free system allocated memory */
 -#undef free
 -#undef malloc
 -#define malloc * dont use malloc in this routine
 #else
 /*
 @@ -117,6 +113,9 @@

  || !( defined(HAVE_LINUX_OS) \
  ||
 || defined(HAVE_FREEBSD_OS) \
 || defined(HAVE_DARWIN_OS) \

 +  || defined(HAVE_IRIX_OS) \
 +  || defined(HAVE_OSF1_OS) \
 +  || defined(HAVE_SUN_OS) \
  )
 /* bacl_get() returns the lenght of the string, or -1 on error. */
 @@ -318,7 +317,7 @@
  if (acl(jcr-last_fname, GETACL, n, acls) == n) {
 if ((acl_text = acltotext(acls, n)) != NULL) {
len = pm_strcpy(jcr-acl_text, acl_text);
 - free(acl_text);
 + actuallyfree(acl_text);
free(acls);
return len;
 }
 @@ -336,11 +335,11 @@
  if (!acls) {
 return -1;
  }
 -   if (acl(jcr-last_fname, SETACL, n, acls) != 0) {
 -  free(acls);
 +   if (acl(jcr-last_fname, SETACL, n, acls) == -1) {
 +  actuallyfree(acls);
 return -1;
  }
 -   free(acls);
 +   actuallyfree(acls);
  return 0;
 }

 --
 DaveD

-- 
Best regards,

Kern

  (
  /\
  V_V


---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-13 Thread Kern Sibbald 
On Friday 11 November 2005 22:27, Attila Fülöp wrote:
 Attila Fülöp

Your patch is now integrated.  It will go into the CVS shortly.  Thanks :-)

-- 
Best regards,

Kern

  (
  /\
  V_V


---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-11 Thread Kern Sibbald 
On Friday 11 November 2005 14:09, David Duchscher wrote:
 On Nov 10, 2005, at 2:39 PM, Kern Sibbald wrote:
  On Thursday 10 November 2005 21:22, Attila Fülöp wrote:
  Referring to the thread [Bacula-users] ACL's with Bacula on FreeBSD
  (resend) started by Tony Lambregts on 20.07.2005 20:15 I need some
  clarifications.
 
  Is the patch mentioned in this thread integrated into 1.38, that is
  do ACLs work with FreeBSD? And second, even more important to me,
  do ACLs work with Solaris clients?
 
  Skimming over sys/acl.h on
  Solaris 2.9 it seems this is quite a different API.
 
  Yes, so are some of the others ...
 
  I'm forced to use ACLs soon, and need a way to back them up. So I
  would try to patch in support for Solaris ACLs if it's needed.
 
  To the best of my knowledge with that patch integrated, ACLs
  should now work on:
 
  AIX
  FreeBSD
  Darwin
  Irix
  OSF1
  Linux
  HPUX
  Solaris
 
  Linux, Darwin, and FreeBSD have been pretty well tested.  The
  others *should*
  work, but I don't recall anyone giving definitive feedback (correct
  me if I
  am mistaken).

 I can confirm that Solaris doesn't work.  Their is code for Solaris
 ACLs but the configure script does not detect ACL support on
 Solaris.  

I think I just answered my own question by doing man acl on Solaris.  I see 
detection of the code is probably significantly different ...


 I helped with Darwin and FreeBSD but I have not had time to 
 really look at Solaris fully until yesterday.  Seems disaster
 recovery is now top priority for the next few weeks.  Ah, the life of
 changing priorities.

 --
 DaveD

-- 
Best regards,

Kern

  (
  /\
  V_V


---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-11 Thread Attila Fülöp 

Deim Ágoston wrote:

Skimming over sys/acl.h on
Solaris 2.9 it seems this is quite a different API.


Yes, so are some of the others ...


I'm forced to use ACLs soon, and need a way to back them up. So I
would try to patch in support for Solaris ACLs if it's needed.


To the best of my knowledge with that patch integrated, ACLs
should now work on:





Solaris


If they don't work there's a dirty hack: backup ACLs with command line
tools. Use a ClientRunBeforeJob script to call the tools.


Yeah, thats a good idea. I will use this as a fallback scenario, but
would really prefer the 'clean way'.


bye,
Ago



---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users







---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-11 Thread Attila Fülöp 

David Duchscher wrote:

On Nov 10, 2005, at 2:39 PM, Kern Sibbald wrote:


On Thursday 10 November 2005 21:22, Attila Fülöp wrote:

snip/

Is the patch mentioned in this thread integrated into 1.38, that is
do ACLs work with FreeBSD? And second, even more important to me,
do ACLs work with Solaris clients?

snip/
I can confirm that Solaris doesn't work.  Their is code for Solaris  
ACLs but the configure script does not detect ACL support on  Solaris.  
I helped with Darwin and FreeBSD but I have not had time to  really look 
at Solaris fully until yesterday.  Seems disaster  recovery is now top 
priority for the next few weeks.  Ah, the life of  changing priorities.


Ok, than I will try to patch configure.in to detect ACL support on solaris.
How much effort would it be to back port the ACL changes to 1.36.3? I'm
a bit reluctant to update the production system to 1.38 right now.

Thanks

Attila


--
DaveD







---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-11 Thread Attila Fülöp 

Kern Sibbald wrote:

On Friday 11 November 2005 15:33, Attila Fülöp wrote:


David Duchscher wrote:


On Nov 10, 2005, at 2:39 PM, Kern Sibbald wrote:


On Thursday 10 November 2005 21:22, Attila Fülöp wrote:


snip/


Is the patch mentioned in this thread integrated into 1.38, that is
do ACLs work with FreeBSD? And second, even more important to me,
do ACLs work with Solaris clients?


snip/


I can confirm that Solaris doesn't work.  Their is code for Solaris
ACLs but the configure script does not detect ACL support on  Solaris.
I helped with Darwin and FreeBSD but I have not had time to  really look
at Solaris fully until yesterday.  Seems disaster  recovery is now top
priority for the next few weeks.  Ah, the life of  changing priorities.


Ok, than I will try to patch configure.in to detect ACL support on solaris.



That would be very kind of you ... :-)


All right, I'll do. That said, it may take some time since I've no sun
at home and are not that familiar with autoconf.



How much effort would it be to back port the ACL changes to 1.36.3? I'm
a bit reluctant to update the production system to 1.38 right now.



You could look at it.  Perhaps it wouldn't be too much effort, but the code is 
conciderably changed because it has been moved around a lot (new files).  The 
code is now much simpler (at least the main line code).  However, there might 
be some complications with new features or something.  I'm having trouble 
keeping up as it is, so it isn't something I would do, but I'd be happy to 
answer questions.  

My advice would be to test 1.38 and move up -- aside from problems with 
multiple concurrent jobs accessing autochangers, where users pull cassettes 
in and out, it seems to be very stable (more so than 1.36 IMO).






---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-11 Thread Attila Fülöp 

Attila Fülöp wrote:

Kern Sibbald wrote:

snip/



Ok, than I will try to patch configure.in to detect ACL support on 
solaris.




That would be very kind of you ... :-)



All right, I'll do. That said, it may take some time since I've no sun
at home and are not that familiar with autoconf.


Ok, it was easier than I thought. Currently I only tested autoconf/configure.
I have to compile and tested it yet, but that has to wait 'till Monday.
From what i saw in filed/acl.c I'm quite confident this will work.
A patch is attached. Well you're right backup.c/restore.c changed quite a
bit. I'm not sure if I will back port the changes. Think I'll decide on
Monday.

bash $ uname -iprs
SunOS 5.9 sparc SUNW,Ultra-80
bash $ ./configure-new --enable-client-only

checking sys/acl.h usability... yes
checking sys/acl.h presence... yes
checking for sys/acl.h... yes
checking for acl_get_file... no
checking for acl_get_file in -lacl... no
checking for acltotext in -lsec... yes

  ACL support:yes

bash-2.05$ grep lsec src/filed/Makefile
FDLIBS = -lsec -lz# extra libs for File daemon

Attila





How much effort would it be to back port the ACL changes to 1.36.3? I'm
a bit reluctant to update the production system to 1.38 right now.




You could look at it.  Perhaps it wouldn't be too much effort, but the 
code is conciderably changed because it has been moved around a lot 
(new files).  The code is now much simpler (at least the main line 
code).  However, there might be some complications with new features 
or something.  I'm having trouble keeping up as it is, so it isn't 
something I would do, but I'd be happy to answer questions. 
My advice would be to test 1.38 and move up -- aside from problems 
with multiple concurrent jobs accessing autochangers, where users pull 
cassettes in and out, it seems to be very stable (more so than 1.36 IMO).






---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. 
Download

it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users




Index: configure.in
===
RCS file: /cvsroot/bacula/bacula/autoconf/configure.in,v
retrieving revision 1.191
diff -c -r1.191 configure.in
*** configure.in	3 Nov 2005 14:54:00 -	1.191
--- configure.in	11 Nov 2005 21:24:27 -
***
*** 1575,1581 
  have_acl=no
  AC_CHECK_HEADER(sys/acl.h)
  AC_CHECK_FUNC(acl_get_file, [have_acl=yes],
! 	[AC_CHECK_LIB(acl, acl_get_file, [have_acl=yes; FDLIBS=-lacl $FDLIBS])]
  )
  if test $have_acl = yes; then
 AC_DEFINE(HAVE_ACL)
--- 1575,1583 
  have_acl=no
  AC_CHECK_HEADER(sys/acl.h)
  AC_CHECK_FUNC(acl_get_file, [have_acl=yes],
! 	[AC_CHECK_LIB(acl, acl_get_file, [have_acl=yes; FDLIBS=-lacl $FDLIBS],
! 	[AC_CHECK_LIB(sec, acltotext, [have_acl=yes; FDLIBS=-lsec $FDLIBS])]
! 	)]
  )
  if test $have_acl = yes; then
 AC_DEFINE(HAVE_ACL)

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-11 Thread Kern Sibbald 
On Friday 11 November 2005 22:33, David Duchscher wrote:
 On Nov 11, 2005, at 11:23 AM, Attila Fülöp wrote:
  Kern Sibbald wrote:
  On Friday 11 November 2005 15:33, Attila Fülöp wrote:
  David Duchscher wrote:
  On Nov 10, 2005, at 2:39 PM, Kern Sibbald wrote:
  On Thursday 10 November 2005 21:22, Attila Fülöp wrote:
 
  snip/
 
  Is the patch mentioned in this thread integrated into 1.38,
  that is
  do ACLs work with FreeBSD? And second, even more important to me,
  do ACLs work with Solaris clients?
 
  snip/
 
  I can confirm that Solaris doesn't work.  Their is code for Solaris
  ACLs but the configure script does not detect ACL support on
  Solaris.
  I helped with Darwin and FreeBSD but I have not had time to
  really look
  at Solaris fully until yesterday.  Seems disaster  recovery is
  now top
  priority for the next few weeks.  Ah, the life of  changing
  priorities.
 
  Ok, than I will try to patch configure.in to detect ACL support
  on solaris.
 
  That would be very kind of you ... :-)
 
  All right, I'll do. That said, it may take some time since I've no sun
  at home and are not that familiar with autoconf.

 autoconf is easy to fix.  I have detection working now.  There is
 also an issue with a ifdef in src/filed/acl.c that now that I look at
 the code again, limits 1.38.0 to FreeBSD, Darwin, and Linux.  I had
 just added FreeBSD and Darwin to the ifdef when I made my changes.  I
 was trying not to change too many things and I had only tested those
 platforms.  I am thinking that we should remove the ifdef or at least
 enable the POSIX platforms.  Thoughts?

I probably won't have any problems moving a #ifdef, but I'll need to see it. I 
consider such changes low impact if it just adds code for another platform.


 As for Solaris, I have things mostly working on Solaris.  There is at
 least one bug in the code currently in 1.38.0 and I am seeing another
 strangeness when ACLs are restored.  I also have to figure out the
 best way to bypass smartalloc to free the system call memory since I
 am very new to smartalloc.  The good news is that we have lots of
 Sun's around here that the admins have graciously given me access so
 I can test things.  Hopefully I will have things working by the end
 of the weekend.

Try: actuallyfree(void *); 


-- 
Best regards,

Kern

  (
  /\
  V_V


---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-11 Thread Attila Fülöp 

David Duchscher wrote:

On Nov 11, 2005, at 11:23 AM, Attila Fülöp wrote:


Kern Sibbald wrote:


On Friday 11 November 2005 15:33, Attila Fülöp wrote:


David Duchscher wrote:


On Nov 10, 2005, at 2:39 PM, Kern Sibbald wrote:


On Thursday 10 November 2005 21:22, Attila Fülöp wrote:



snip/


Is the patch mentioned in this thread integrated into 1.38,  that is
do ACLs work with FreeBSD? And second, even more important to me,
do ACLs work with Solaris clients?



snip/


I can confirm that Solaris doesn't work.  Their is code for Solaris
ACLs but the configure script does not detect ACL support on   
Solaris.
I helped with Darwin and FreeBSD but I have not had time to   
really look
at Solaris fully until yesterday.  Seems disaster  recovery is  now 
top
priority for the next few weeks.  Ah, the life of  changing  
priorities.



Ok, than I will try to patch configure.in to detect ACL support  on 
solaris.


That would be very kind of you ... :-)



All right, I'll do. That said, it may take some time since I've no sun
at home and are not that familiar with autoconf.



autoconf is easy to fix.  I have detection working now.  There is  also 
an issue with a ifdef in src/filed/acl.c that now that I look at  the 
code again, limits 1.38.0 to FreeBSD, Darwin, and Linux.  I had  just 
added FreeBSD and Darwin to the ifdef when I made my changes.  I  was 
trying not to change too many things and I had only tested those  
platforms.  I am thinking that we should remove the ifdef or at least  
enable the POSIX platforms.  Thoughts?


Yes you're right, I was fooled by the #elif defined(HAVE_SUN_OS). Well
what about this line:
|| defined(HAVE_SUN_OS)   /* tested   -- compile with -lsec */
Never trust a comment ;-)

Yes i would second enabling the POSIX platforms although my main concern
is now to have it work under Solaris.

As for Solaris, I have things mostly working on Solaris.  There is at  
least one bug in the code currently in 1.38.0 and I am seeing another  
strangeness when ACLs are restored.  I also have to figure out the  best 
way to bypass smartalloc to free the system call memory since I  am very 
new to smartalloc.  The good news is that we have lots of  Sun's around


What about
/*  ACTUALLYFREE  --  Interface to system free() function to release
  buffers allocated by low-level routines. */

void actuallyfree(void *cp)

here that the admins have graciously given me access so  I can test 
things.  Hopefully I will have things working by the end  of the weekend.


That would be *great*. If you need some help don't hesitate to contact me.
Well I'm off the net for the weekend.

Attila




--
DaveD






---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

[Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-10 Thread Attila Fülöp 

Referring to the thread [Bacula-users] ACL's with Bacula on FreeBSD
(resend) started by Tony Lambregts on 20.07.2005 20:15 I need some
clarifications.

Is the patch mentioned in this thread integrated into 1.38, that is
do ACLs work with FreeBSD? And second, even more important to me,
do ACLs work with Solaris clients?  Skimming over sys/acl.h on
Solaris 2.9 it seems this is quite a different API.

I'm forced to use ACLs soon, and need a way to back them up. So I
would try to patch in support for Solaris ACLs if it's needed.

Thanks
Attila



---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-10 Thread Kern Sibbald 
On Thursday 10 November 2005 21:22, Attila Fülöp wrote:
 Referring to the thread [Bacula-users] ACL's with Bacula on FreeBSD
 (resend) started by Tony Lambregts on 20.07.2005 20:15 I need some
 clarifications.

 Is the patch mentioned in this thread integrated into 1.38, that is
 do ACLs work with FreeBSD? And second, even more important to me,
 do ACLs work with Solaris clients?  

 Skimming over sys/acl.h on 
 Solaris 2.9 it seems this is quite a different API.
Yes, so are some of the others ...

 I'm forced to use ACLs soon, and need a way to back them up. So I
 would try to patch in support for Solaris ACLs if it's needed.

To the best of my knowledge with that patch integrated, ACLs 
should now work on:

AIX
FreeBSD
Darwin
Irix
OSF1
Linux
HPUX
Solaris

Linux, Darwin, and FreeBSD have been pretty well tested.  The others *should* 
work, but I don't recall anyone giving definitive feedback (correct me if I 
am mistaken).

-- 
Best regards,

Kern

  (
  /\
  V_V


---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Re: [Bacula-users] File ACLs with FreeBSD and Solaris

2005-11-10 Thread Deim Ágoston 
 Skimming over sys/acl.h on
 Solaris 2.9 it seems this is quite a different API.
 Yes, so are some of the others ...

 I'm forced to use ACLs soon, and need a way to back them up. So I
 would try to patch in support for Solaris ACLs if it's needed.

 To the best of my knowledge with that patch integrated, ACLs
 should now work on:

 Solaris
If they don't work there's a dirty hack: backup ACLs with command line
tools. Use a ClientRunBeforeJob script to call the tools.

bye,
Ago



---
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42 plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
___
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users