Re: completion in latest code

2007-05-31 Thread Dave Goldberg
> On Thu, 31 May 2007 23:42:42 +0200, Robert Widhopf-Fenk <[EMAIL 
> PROTECTED]> said:

> On Thursday, May 31, 2007 at 16:27:21, Dave Goldberg wrote:
>> I get a window displayed now, but special display is not picking it
>> up.

> Too bad, but fixed now ... hopefully. ;-/

Yes it is.  Thanks very much.

-- 
Dave Goldberg
[EMAIL PROTECTED]


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-31 Thread Robert Widhopf-Fenk
On Thursday, May 31, 2007 at 16:27:21, Dave Goldberg wrote:
> I get a window displayed now, but special display is not picking it
> up.

Too bad, but fixed now ... hopefully. ;-/

Bye Robert

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-31 Thread Dave Goldberg
I get a window displayed now, but special display is not picking it up.

Thanks,
-- 
Dave Goldberg
[EMAIL PROTECTED]


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-31 Thread Robert Widhopf-Fenk
On Thursday, May 31, 2007 at 15:41:37, Dave Goldberg wrote:
> I also just tried setting bbdb-use-pop-up to 'horizontal and
> 'vertical.  I still get no display.  And yes, I have tried it with
> xemacs -q to avoid any issues from my init.el.

Could you update an try it again now?

Thanks
Robert

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-31 Thread Dave Goldberg
I also just tried setting bbdb-use-pop-up to 'horizontal and
'vertical.  I still get no display.  And yes, I have tried it with
xemacs -q to avoid any issues from my init.el.

Thanks,
-- 
Dave Goldberg
[EMAIL PROTECTED]


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-31 Thread Robert Widhopf-Fenk
On Wednesday, May 30, 2007 at 22:09:04, Leo wrote:
> - Robert Widhopf-Fenk (2007-05-30) wrote:-
> 
> [...]
> >> Does the following patch looks good:
> >> 
> >> 
> >> --- bbdb.el30 May 2007 00:05:04 +0100  1.246
> >> +++ bbdb.el30 May 2007 00:28:34 +0100  
> >> @@ -1873,8 +1873,8 @@
> >>  (if bbdb-multiple-buffers (bbdb-pop-up-bbdb-buffer))
> >>  
> >>  (save-excursion 
> >> -  (set-buffer bbdb-buffer-name)
> >> -
> >> +  (set-buffer (get-buffer-create bbdb-buffer-name))
> >
> > This line does look good, but
> >
> >> +  (let ((inhibit-read-only t)) (erase-buffer))
> >
> > this one not.  Why do you want to erase the buffer, it
> > should not be necessary.
> 
> Without this line, there is another bug. It can be reproduced this
> way.
> 
>1. M-x bbdb
>2. type something that will match a few records
>3. Change to a mailer, I use message mode, and do a name
>   completion in the 'To' field.
>4. Go back to the *BBDB* buffer, you will see duplicates. When
>   you edit the name of the duplicates, it will show the value of
>   what you type in the mailer.
> 
> The second line I added is trying to mimic
> 'with-output-to-temp-buffer':
> 
> ,[ with-output-to-temp-buffer ] | The buffer is cleared out
> initially, and marked as unmodified when done. `

You are just so right!

I was breaking it here not in bbdb-pop-up-bbdb-buffer.

Thanks you very much for clarifying this to me and the fix.
It is in CVS now.

Bye Robert

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-31 Thread Dave Goldberg
> On Thu, 31 May 2007 21:31:49 +0200, Robert Widhopf-Fenk <[EMAIL 
> PROTECTED]> said:

> On Wednesday, May 30, 2007 at 18:59:17, Dave Goldberg wrote:
>> > On Tue, 29 May 2007 00:03:43 +0100, Leo <[EMAIL PROTECTED]>
>> > said:
> [...]
>> bbdb-use-pop-up nil

> It should work if you do not set `bbdb-use-pop-up' to nil.

No dice.  I set it to t and still no bbdb window gets displayed.  But
I don't want to set it to t.  According to the documentation, if
bbdb-use-pop-up is non-nil then

"...display a continuously-updating bbdb window while in VM, MH,
RMAIL, Gnus or a composition buffer."

I don't want a continuously updating bbdb window.  I just want to see
a bbdb window when I ask for it, typically by running M-x bbdb or M-x
bbdb-create or M-x bbdb-snarf-region.  On occasion I'll hit ':'
(bbdb/gnus-show-sender) in gnus summary mode to either add or update
an address that way but that's it.  Most of my interactive use of bbdb
is strictly for completion when filling out To and CC headers.

Thanks,
-- 
Dave Goldberg
[EMAIL PROTECTED]


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-31 Thread Robert Widhopf-Fenk
On Wednesday, May 30, 2007 at 18:59:17, Dave Goldberg wrote:
> > On Tue, 29 May 2007 00:03:43 +0100, Leo <[EMAIL PROTECTED]>
> > said:
[...]
>  bbdb-use-pop-up nil

It should work if you do not set `bbdb-use-pop-up' to nil.

Bye Robert

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-31 Thread Dave Goldberg
Since I get the list as a digest, I can't follow up directly to my message from 
last night.  Sorry for breaking the thread.

Anyway, I noted that I don't use bbdb-use-popup and the latest fixes result in 
no display of *BBDB* at all when I call M-x bbdb.  The problem is the change to 
save-excursion and set-buffer.  That allows the buffer to be generated but it's 
always left in the background.  Somewhere along the line, display-buffer has to 
be called to bring it to the front.  I don't know where to make that call since 
I don't really understand what the latest changes were intended to fix.  For 
the time being, I've after-advised bbdb to call (display-buffer "*BBDB*") which 
works, but is not really a good solution.

Thanks,
-- 
Dave Goldberg
[EMAIL PROTECTED]


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-30 Thread Dave Goldberg
> On Tue, 29 May 2007 00:03:43 +0100, Leo <[EMAIL PROTECTED]> said:

> After restarting Emacs, I caught another error:

> ,[ error ]
> | Debugger entered--Lisp error: (error "No buffer named *BBDB*")
> |   bbdb-display-records-1((["eddies" nil nil nil nil nil ("[EMAIL 
> PROTECTED]") (... ...) ["eddies" nil # nil]]) nil nil)
> |   bbdb-display-records((["eddies" nil nil nil nil nil ("[EMAIL PROTECTED]") 
> (... ...) ["eddies" nil # nil]]))
> |   bbdb("eddies" nil)
> |   call-interactively(bbdb)
> |   execute-extended-command(nil)
> |   call-interactively(execute-extended-command)

I ran into this too.  Just before writing this note, I did a CVS
update and there was a fix for it.  Thanks!  But now, while the *BBDB*
buffer is nicely set up, it doesn't display at all.  I had been using
special-display to open *BBDB* in its own frame so in case that was a
problem, I ran xemacs -q, added ~/.xemacs/packages/lisp/bbdb to the
front of load-path, verified with (locate-library "bbdb") and again,
no BBDB window shows up at all.  I attach the results of
bbdb-submit-bug-report to the end in case that helps.

Thanks,
-- 
Dave Goldberg
[EMAIL PROTECTED]
Emacs  : XEmacs 21.4 (patch 20) "Double Solitaire" [Lucid] (i686-pc-linux, 
Mule) of Thu Mar  8 2007 on davestoy.homelinux.org
Package: BBDB 2.36 devo

current state:
==
(setq
 emacs-version "21.4 (patch 20) \"Double Solitaire\" XEmacs Lucid"
 bbdb-file-format 6
 bbdb-no-duplicates-p nil
 bbdb-addresses-label-list '("Home" "Office" "Mobile" "Other" "Work" "Main"
 "address")
 bbdb-after-change-hook '(bbdb/gnus-score-invalidate-alist)
 bbdb-after-read-db-hook nil
 bbdb-always-add-addresses nil
 bbdb-auto-revert-p nil
 bbdb-canonicalize-net-hook '(bbdb-obsolete-net-canonicalize-net-hook)
 bbdb-canonicalize-redundant-nets-p t
 bbdb-case-fold-search t
 bbdb-change-hook '(spam-clear-cache-BBDB bbdb-timestamp-hook)
 bbdb-completion-display-record nil
 bbdb-completion-type nil
 bbdb-create-hook 'bbdb-creation-date-hook
 bbdb-default-area-code nil
 bbdb-default-country "USA"
 bbdb-default-domain nil
 bbdb-default-label-list '("Home" "Office" "Mobile" "Other")
 bbdb-define-all-aliases-field 'mail-alias
 bbdb-display-layout 'multi-line
 bbdb-display-layout-alist '((one-line-net (toggle . t) (test . net))
 (one-line (order phones) (name-end . 24)
  (toggle . t))
 (multi-line
  (omit pilot-id pilot-ignore sieve-vendor
   sieve-mitre sieve-junk obsolete-net timestamp
   creation-date)
  (indention . 14) (toggle . t))
 (pop-up-multi-line (indention . 14))
 (full-multi-line (indentation . 14) (toggle . t)))
 bbdb-dwim-net-address-allow-redundancy nil
 bbdb-electric-p nil
 bbdb-extract-address-component-handler 'message
 bbdb-extract-address-component-ignore-regexp 
"\\(\\(undisclosed\\|unlisted\\)[^,]*recipients\\)\\|no To-header on input"
 bbdb-extract-address-component-regexps '(("\"\\([^\"]*\\)\"\\s-*<\\([^>]+\\)>"
   (bbdb-clean-username


 (match-string 1 adstring)


 )
   2)
  ("\\([^<>,][^<>,]+[^<>,   
]\\)\\s-*<\\([^>]+\\)>" 1 2)
  ("<\\([^>,]+\\)>" nil 1)
  
("\\(\\b[^<\",()]+\\b\\)\\s-*(\\([^)]+\\))"
   (car


   (mail-extract-address-components





(concat

 

 

 

 

 

 "\""
 

Re: completion in latest code

2007-05-30 Thread Leo
- Robert Widhopf-Fenk (2007-05-30) wrote:-

[...]
>> Does the following patch looks good:
>> 
>> 
>> --- bbdb.el  30 May 2007 00:05:04 +0100  1.246
>> +++ bbdb.el  30 May 2007 00:28:34 +0100  
>> @@ -1873,8 +1873,8 @@
>>  (if bbdb-multiple-buffers (bbdb-pop-up-bbdb-buffer))
>>  
>>  (save-excursion 
>> -  (set-buffer bbdb-buffer-name)
>> -
>> +  (set-buffer (get-buffer-create bbdb-buffer-name))
>
> This line does look good, but
>
>> +  (let ((inhibit-read-only t)) (erase-buffer))
>
> this one not.  Why do you want to erase the buffer, it
> should not be necessary.

Without this line, there is another bug. It can be reproduced this way.

   1. M-x bbdb
   2. type something that will match a few records
   3. Change to a mailer, I use message mode, and do a name completion
  in the 'To' field.
   4. Go back to the *BBDB* buffer, you will see duplicates. When you
  edit the name of the duplicates, it will show the value of what you
  type in the mailer.

The second line I added is trying to mimic 'with-output-to-temp-buffer':

,[ with-output-to-temp-buffer ]
| The buffer is cleared out initially, and marked as unmodified when done.
`

> I have committed a sightly different bugfix where the buffer is
> created in bbdb-pop-up-bbdb-buffer where I IMHO caused the problem.

It has the same problem as described above.

> While I was not able to reproduce it here (I always have a BBDB buffer
> around :), I hope it fixes it for you.

Since the "*BBDB*" is not associated with any file, you can kill it and
start a bbdb search to see the bug.

> Thanks for reporting this,
> Robert

Best,
-- 
Leo  (GPG Key: 9283AA3F)


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-30 Thread Robert Widhopf-Fenk
On Wednesday, May 30, 2007 at 00:38:03, Leo wrote:
> > After restarting Emacs, I caught another error:
> >
> > ,[ error ] | Debugger entered--Lisp error: (error "No buffer
> > named *BBDB*") | bbdb-display-records-1((["eddies" nil nil nil nil
> > nil ("[EMAIL PROTECTED]") (... ...) ["eddies" nil # > bbdb> nil]]) nil nil) | bbdb-display-records((["eddies" nil nil
> > nil nil nil ("[EMAIL PROTECTED]") (... ...) ["eddies" nil # > 7257 in bbdb> nil]])) | bbdb("eddies" nil) |
> > call-interactively(bbdb) | execute-extended-command(nil) |
> > call-interactively(execute-extended-command) `
> 
> Does the following patch looks good:
> 
> 
> --- bbdb.el   30 May 2007 00:05:04 +0100  1.246
> +++ bbdb.el   30 May 2007 00:28:34 +0100  
> @@ -1873,8 +1873,8 @@
>  (if bbdb-multiple-buffers (bbdb-pop-up-bbdb-buffer))
>  
>  (save-excursion 
> -  (set-buffer bbdb-buffer-name)
> -
> +  (set-buffer (get-buffer-create bbdb-buffer-name))

This line does look good, but

> +  (let ((inhibit-read-only t)) (erase-buffer))

this one not.  Why do you want to erase the buffer, it
should not be necessary.

I have committed a sightly different bugfix where the buffer
is created in bbdb-pop-up-bbdb-buffer where I IMHO caused the
problem.

While I was not able to reproduce it here (I always have a
BBDB buffer around :), I hope it fixes it for you.

Thanks for reporting this,
Robert

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-29 Thread Leo
> After restarting Emacs, I caught another error:
>
> ,[ error ]
> | Debugger entered--Lisp error: (error "No buffer named *BBDB*")
> |   bbdb-display-records-1((["eddies" nil nil nil nil nil ("[EMAIL 
> PROTECTED]") (... ...) ["eddies" nil # nil]]) nil nil)
> |   bbdb-display-records((["eddies" nil nil nil nil nil ("[EMAIL PROTECTED]") 
> (... ...) ["eddies" nil # nil]]))
> |   bbdb("eddies" nil)
> |   call-interactively(bbdb)
> |   execute-extended-command(nil)
> |   call-interactively(execute-extended-command)
> `

Does the following patch looks good:

--- bbdb.el	30 May 2007 00:05:04 +0100	1.246
+++ bbdb.el	30 May 2007 00:28:34 +0100	
@@ -1873,8 +1873,8 @@
 (if bbdb-multiple-buffers (bbdb-pop-up-bbdb-buffer))
 
 (save-excursion 
-  (set-buffer bbdb-buffer-name)
-
+  (set-buffer (get-buffer-create bbdb-buffer-name))
+  (let ((inhibit-read-only t)) (erase-buffer))
   ;; If append is set, clear the buffer, otherwise do clean up.
   (unless append (bbdb-undisplay-records))
 

-- 
Leo  (GPG Key: 9283AA3F)
-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/

Re: completion in latest code

2007-05-28 Thread Leo
- Robert Widhopf-Fenk (2007-05-28) wrote:-

[...]
>> Now it doesn't not honor `bbdb-pop-up-target-lines' etc. For
>> example, the pop up window will always take half of the screen.
>
> Hey, you are right.
>
> It is fixed now, i.e. no window will popup if
> bbdb-use-pop-up is set to nil.
>
> If you want a popup honoring `bbdb-pop-up-target-lines' then
> do not set bbdb-use-pop-up to nil.
>
> Robert.

After restarting Emacs, I caught another error:

,[ error ]
| Debugger entered--Lisp error: (error "No buffer named *BBDB*")
|   bbdb-display-records-1((["eddies" nil nil nil nil nil ("[EMAIL PROTECTED]") 
(... ...) ["eddies" nil # nil]]) nil nil)
|   bbdb-display-records((["eddies" nil nil nil nil nil ("[EMAIL PROTECTED]") 
(... ...) ["eddies" nil # nil]]))
|   bbdb("eddies" nil)
|   call-interactively(bbdb)
|   execute-extended-command(nil)
|   call-interactively(execute-extended-command)
`

Regards,
-- 
Leo  (GPG Key: 9283AA3F)


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-28 Thread Leo
- Robert Widhopf-Fenk (2007-05-28) wrote:-

> On Friday, May 25, 2007 at 19:50:01, Leo wrote:
>> The following message is a courtesy copy of an article
>> that has been posted to gmane.emacs.bbdb.user as well.
>> 
>
>> - Robert Widhopf-Fenk (2007-05-25) wrote:-
>> 
>> >> > No sorry, but I hear some bells now ... it might be related to
>> >> > the PatchSet 945.
>> >> >
>> >> > Does it work with "cvs up -D '2007/04/21 01:14:40'", but not
>> >> > with "cvs up -D '2007/04/21 01:15:00'"?
>> >> >
>> >> > Bye Robert
>> >> 
>> >> It works with "cvs up -D '2007/04/20 01:14:40'" but not "cvs up
>> >> -D '2007/04/21 01:14:40'".
>> >> 
>> >> I use edebug and trace down to the change made to
>> >> bbdb-pop-up-bbdb-buffer.
>> >> 
>> >> When bbdb-use-pop-up is set to nil, the old behavior is using
>> >> horizontal pop up. The new behavior is switch to the *bbdb* and
>> >> delete all other windows.
>> >
>> > So now I see why I did not see it, I have not set it to nil.
>> >
>> > In CVS it is honoring nil now as the docs spell it,
>> > i.e. there will be no popup buffer in that case. 
>> >
>> > Robert
>> 
>> Now it doesn't not honor `bbdb-pop-up-target-lines' etc. For
>> example, the pop up window will always take half of the screen.
>
> Hey, you are right.
>
> It is fixed now, i.e. no window will popup if
> bbdb-use-pop-up is set to nil.
>
> If you want a popup honoring `bbdb-pop-up-target-lines' then
> do not set bbdb-use-pop-up to nil.
>
> Robert.

I just tested it. It works great ;)

-- 
Leo  (GPG Key: 9283AA3F)


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-28 Thread Robert Widhopf-Fenk
On Friday, May 25, 2007 at 19:50:01, Leo wrote:
> The following message is a courtesy copy of an article
> that has been posted to gmane.emacs.bbdb.user as well.
> 
> - Robert Widhopf-Fenk (2007-05-25) wrote:-
> 
> >> > No sorry, but I hear some bells now ... it might be related to
> >> > the PatchSet 945.
> >> >
> >> > Does it work with "cvs up -D '2007/04/21 01:14:40'", but not
> >> > with "cvs up -D '2007/04/21 01:15:00'"?
> >> >
> >> > Bye Robert
> >> 
> >> It works with "cvs up -D '2007/04/20 01:14:40'" but not "cvs up
> >> -D '2007/04/21 01:14:40'".
> >> 
> >> I use edebug and trace down to the change made to
> >> bbdb-pop-up-bbdb-buffer.
> >> 
> >> When bbdb-use-pop-up is set to nil, the old behavior is using
> >> horizontal pop up. The new behavior is switch to the *bbdb* and
> >> delete all other windows.
> >
> > So now I see why I did not see it, I have not set it to nil.
> >
> > In CVS it is honoring nil now as the docs spell it,
> > i.e. there will be no popup buffer in that case. 
> >
> > Robert
> 
> Now it doesn't not honor `bbdb-pop-up-target-lines' etc. For
> example, the pop up window will always take half of the screen.

Hey, you are right.

It is fixed now, i.e. no window will popup if
bbdb-use-pop-up is set to nil.

If you want a popup honoring `bbdb-pop-up-target-lines' then
do not set bbdb-use-pop-up to nil.

Robert.

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-25 Thread Robert Widhopf-Fenk
On Wednesday, May 23, 2007 at 22:20:16, Leo wrote:
> - Robert Widhopf-Fenk (2007-05-23) wrote:-
> 
> >> > You mean there is only one completion for that record and it
> >> > gets completed without a completion choices buffer, right?
> >> 
> >> No.
> >> 
> >> I mean in a frame with only one buffer -- the "*mail*" buffer, if
> >> you try to complete an email address in 'From' field, as soon as
> >> you type , the buffer will be switched to *BBDB* and *BBDB*
> >> is the _only_ visible buffer in the frame.
> >> 
> >> Can you see this now?
> >
> > No sorry, but I hear some bells now ... it might be related
> > to the PatchSet 945.
> >
> > Does it work with "cvs up -D '2007/04/21 01:14:40'", but
> > not with "cvs up -D '2007/04/21 01:15:00'"?
> >
> > Bye Robert
> 
> It works with "cvs up -D '2007/04/20 01:14:40'" but not
> "cvs up -D '2007/04/21 01:14:40'".
> 
> I use edebug and trace down to the change made to
> bbdb-pop-up-bbdb-buffer.
> 
> When bbdb-use-pop-up is set to nil, the old behavior is using
> horizontal pop up. The new behavior is switch to the *bbdb* and
> delete all other windows.

So now I see why I did not see it, I have not set it to nil.

In CVS it is honoring nil now as the docs spell it,
i.e. there will be no popup buffer in that case. 

Robert

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-24 Thread Leo
- Robert Widhopf-Fenk (2007-05-23) wrote:-

>> > You mean there is only one completion for that record and it gets
>> > completed without a completion choices buffer, right?
>> 
>> No.
>> 
>> I mean in a frame with only one buffer -- the "*mail*" buffer, if you
>> try to complete an email address in 'From' field, as soon as you type
>> , the buffer will be switched to *BBDB* and *BBDB* is the _only_
>> visible buffer in the frame.
>> 
>> Can you see this now?
>
> No sorry, but I hear some bells now ... it might be related
> to the PatchSet 945.
>
> Does it work with "cvs up -D '2007/04/21 01:14:40'", but
> not with "cvs up -D '2007/04/21 01:15:00'"?
>
> Bye Robert

It works with "cvs up -D '2007/04/20 01:14:40'" but not
"cvs up -D '2007/04/21 01:14:40'".

I use edebug and trace down to the change made to
bbdb-pop-up-bbdb-buffer.

When bbdb-use-pop-up is set to nil, the old behavior is using horizontal
pop up. The new behavior is switch to the *bbdb* and delete all other
windows.

HTH,
-- 
Leo  (GPG Key: 9283AA3F)

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-24 Thread Robert Widhopf-Fenk
On Wednesday, May 23, 2007 at 02:55:21, Leo wrote:
> - Robert Widhopf-Fenk (2007-05-23) wrote:-
> 
> >> >> I updated to bbdb yesterday and I have noticed one change
> >> >> which I found annoying.
> >> >> 
> >> >> That is, when completing email in Gnus it will go to the bbdb
> >> >> entry. For example, if I type "psm" in the 'From' field,
> >> >> then I will be switched to the *BBDB* buffer of that entry.
> >
> > You mean there is only one completion for that record and it gets
> > completed without a completion choices buffer, right?
> 
> No.
> 
> I mean in a frame with only one buffer -- the "*mail*" buffer, if
> you try to complete an email address in 'From' field, as soon as you
> type , the buffer will be switched to *BBDB* and *BBDB* is the
> _only_ visible buffer in the frame.
> 
> Can you see this now?

No sorry, but I hear some bells now ... it might be related
to the PatchSet 945.

Does it work with "cvs up -D '2007/04/21 01:14:40'", but
not with "cvs up -D '2007/04/21 01:15:00'"?

Bye Robert

-
PatchSet 945
Date: 2007/04/21 01:14:52
Author: fenk
Branch: HEAD
Tag: (none)
Log:
Rewrote the function `bbdb-pop-up-bbdb-buffer' to use PREDICATE
regardless of the split mode selected by `bbdb-use-pop-up'.

`bbdb-use-pop-up' can be used to select the split mode.

Also added the new variable `bbdb-pop-up-target-columns' which is the
number of columns for the BBDB buffer window when splitting vertically.

Members:
ChangeLog:2.193->2.194
lisp/bbdb.el:1.241->1.242

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-24 Thread Leo
- Robert Widhopf-Fenk (2007-05-23) wrote:-

>> >> I updated to bbdb yesterday and I have noticed one change which I
>> >> found annoying.
>> >> 
>> >> That is, when completing email in Gnus it will go to the bbdb
>> >> entry. For example, if I type "psm" in the 'From' field, then
>> >> I will be switched to the *BBDB* buffer of that entry.
>
> You mean there is only one completion for that record and it gets
> completed without a completion choices buffer, right?

No.

I mean in a frame with only one buffer -- the "*mail*" buffer, if you
try to complete an email address in 'From' field, as soon as you type
, the buffer will be switched to *BBDB* and *BBDB* is the _only_
visible buffer in the frame.

Can you see this now?

-- 
Leo  (GPG Key: 9283AA3F)

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-24 Thread Robert Widhopf-Fenk
On Tuesday, May 22, 2007 at 23:36:43, Leo wrote:
> - Robert Widhopf-Fenk (2007-05-22) wrote:-
> 
> > On Tuesday, May 22, 2007 at 15:38:36, Leo wrote:
> >> I updated to bbdb yesterday and I have noticed one change which I
> >> found annoying.
> >> 
> >> That is, when completing email in Gnus it will go to the bbdb
> >> entry. For example, if I type "psm" in the 'From' field,
> >> then I will be switched to the *BBDB* buffer of that entry.

You mean there is only one completion for that record and it
gets completed without a completion choices buffer, right? 

> >> I wonder if this is a bug.
> >
> > It is, just not sure if it is a "No Gnus", Emacs 23 or BBDB bug.
> >
> >> I am running GNU Emacs.
> >
> > Specifically you are running "No Gnus v0.7, Emacs/23.0.0.1
> > (2007-05-18), Fedora 6.93 gnu/linux".
> >
> > But I cannot reproduce this with Emacs 22.1.50.1 and Gnus v5.11.
> >
> >>From what version have you been updating to the head of CVS?
> 
> I upgrade from bbdb cvs 2007-03-08.
> 
> > Could you try if it also occurs with Emacs 22 and older Gnus? 
> >
> > Robert
> 
> My Emacs 22.0.94 seg fault in my system at the moment.
> 
> I have just downgraded bbdb by "cvs up -D 20070310" and it is
> working again. So I guess it must by the change since 20070310.

So IMHO it must be a change in the revisions 1.184 - 1.191
of lisp/bbdb-com.el, but I cannot see any changes causing
this.

Could you please update to the head again and the downgrade
only lisp/bbdb-com.el to revision 1.183 and see if it works
then?

  cvs update -r 1.183 bbdb-com.el

If it works, then bisect to the revision causing the
problem.

If it does not work, then it must be related to some other
change with an odd side effect ... use "cvsps" to identify
patch sets and bisect based on them.  See the patchset
numbers and dates below.

Robert.

PatchSet 939 Date: 2007/04/21 00:48:08
PatchSet 940 Date: 2007/04/21 00:49:24
PatchSet 941 Date: 2007/04/21 00:50:08
PatchSet 942 Date: 2007/04/21 00:51:13
PatchSet 943 Date: 2007/04/21 01:14:21
PatchSet 944 Date: 2007/04/21 01:14:36
PatchSet 945 Date: 2007/04/21 01:14:52
PatchSet 946 Date: 2007/04/21 01:15:09
PatchSet 947 Date: 2007/04/25 21:35:37
PatchSet 948 Date: 2007/05/19 22:29:43
PatchSet 949 Date: 2007/05/19 22:30:32
PatchSet 950 Date: 2007/05/19 22:30:50
PatchSet 951 Date: 2007/05/19 22:31:04

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-22 Thread Leo
- Robert Widhopf-Fenk (2007-05-22) wrote:-

> On Tuesday, May 22, 2007 at 15:38:36, Leo wrote:
>> I updated to bbdb yesterday and I have noticed one change which I
>> found annoying.
>> 
>> That is, when completing email in Gnus it will go to the bbdb
>> entry. For example, if I type "psm" in the 'From' field, then I
>> will be switched to the *BBDB* buffer of that entry.
>> 
>> I wonder if this is a bug.
>
> It is, just not sure if it is a "No Gnus", Emacs 23 or BBDB bug.
>
>> I am running GNU Emacs.
>
> Specifically you are running "No Gnus v0.7, Emacs/23.0.0.1 (2007-05-18),
> Fedora 6.93 gnu/linux".
>
> But I cannot reproduce this with Emacs 22.1.50.1 and Gnus v5.11.
>
>>From what version have you been updating to the head of CVS?

I upgrade from bbdb cvs 2007-03-08.

> Could you try if it also occurs with Emacs 22 and older Gnus? 
>
> Robert

My Emacs 22.0.94 seg fault in my system at the moment.

I have just downgraded bbdb by "cvs up -D 20070310" and it is working
again. So I guess it must by the change since 20070310.


Thanks,
-- 
Leo  (GPG Key: 9283AA3F)


-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/


Re: completion in latest code

2007-05-22 Thread Robert Widhopf-Fenk
On Tuesday, May 22, 2007 at 15:38:36, Leo wrote:
> I updated to bbdb yesterday and I have noticed one change which I
> found annoying.
> 
> That is, when completing email in Gnus it will go to the bbdb
> entry. For example, if I type "psm" in the 'From' field, then I
> will be switched to the *BBDB* buffer of that entry.
> 
> I wonder if this is a bug.

It is, just not sure if it is a "No Gnus", Emacs 23 or BBDB bug.

> I am running GNU Emacs.

Specifically you are running "No Gnus v0.7, Emacs/23.0.0.1 (2007-05-18),
Fedora 6.93 gnu/linux".

But I cannot reproduce this with Emacs 22.1.50.1 and Gnus v5.11.

>From what version have you been updating to the head of CVS?

Could you try if it also occurs with Emacs 22 and older Gnus? 

Robert

-
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/