Re: [Bf-committers] Swiss Cheese Text Editor Refactor/Merge
Would it work with multicolumn characters which were recently added by http://projects.blender.org/tracker/index.php?func=detailaid=34373group_id=9atid=127? On Wed, Apr 3, 2013 at 11:34 AM, Jason Wilkins jason.a.wilk...@gmail.comwrote: The drawing would be more efficient regardless of the underlying BLF rendering due to the batching. The text editor changes aren't really dependent on the other changes. My problem is that the text editor (text_draw.c) is starting to diverge in inconvenient ways. On Tue, Apr 2, 2013 at 9:11 PM, Mitchell Stokes moguri...@gmail.com wrote: Would this also include the more efficient BLF rendering? I'm guessing the text editor changes are dependent on that? I'd really love to see BLF getting away from glBegin/glEnd. On Tue, Apr 2, 2013 at 1:28 PM, Jason Wilkins jason.a.wilk...@gmail.com wrote: During the last GSoC I made some modifications to the text editor so that it would batch text before drawing it instead of drawing on character at a time. (Since I was removing immediate mode calls from swiss-cheese, sending one character at a time as WAY too much overhead.) The recent changes to the text editor have been a bit of a nightmare to merge. The code is complicated and fragile (both mine and the original). I wanted to touch base and see if it would be OK to see about going ahead and integrating swiss-cheese's more efficient text rendering into trunk. Perhaps I could also refactor some of the code to be a little bit more maintainable as well. The reason I'm asking is I'm not sure if somebody else might have plans for this area, so I don't want to just continue as I am (merging complex changes) if it just going to be blown away. ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] i18n maintenance is on hold
From my translator point of view, explosion of number of strings in POT files is inevitable. Right now different strings use the same translation just because we don't want to make code less readable, but make translation more precise (especially for russiancjk translations). For example here are RNA ids of word Smooth with empty context:http://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.DynamicPaintBrushSettings.html#bpy.types.DynamicPaintBrushSettings.proximity_falloff 1. bpy.types.DynamicPaintBrushSettings.proximity_falloffhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.DynamicPaintBrushSettings.html#bpy.types.DynamicPaintBrushSettings.proximity_falloff :'SMOOTH' 2. bpy.types.Brush.sculpt_toolhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.Brush.html#bpy.types.Brush.sculpt_tool :'SMOOTH' 3. bpy.types.Brush.mask_toolhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.Brush.html#bpy.types.Brush.mask_tool :'SMOOTH' 4. bpy.types.MaskLayer.falloffhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.MaskLayer.html#bpy.types.MaskLayer.falloff :'SMOOTH' 5. bpy.types.MaskSpline.offset_modehttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.MaskSpline.html#bpy.types.MaskSpline.offset_mode :'SMOOTH' 6. bpy.types.MeshPolygon.use_smoothhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.MeshPolygon.html#bpy.types.MeshPolygon.use_smooth 7. bpy.types.MeshTessFace.use_smoothhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.MeshTessFace.html#bpy.types.MeshTessFace.use_smooth 8. bpy.types.Modifier.typehttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.Modifier.html#bpy.types.Modifier.type :'SMOOTH' 9. bpy.types.RemeshModifier.modehttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.RemeshModifier.html#bpy.types.RemeshModifier.mode :'SMOOTH' 10. bpy.types.VertexWeightEditModifier.falloff_typehttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.VertexWeightEditModifier.html#bpy.types.VertexWeightEditModifier.falloff_type :'SMOOTH' 11. bpy.types.VertexWeightProximityModifier.falloff_typehttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.VertexWeightProximityModifier.html#bpy.types.VertexWeightProximityModifier.falloff_type :'SMOOTH' 12. bpy.types.WarpModifier.falloff_typehttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.WarpModifier.html#bpy.types.WarpModifier.falloff_type :'SMOOTH' 13. bpy.types.CompositorNodeDilateErode.falloffhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.CompositorNodeDilateErode.html#bpy.types.CompositorNodeDilateErode.falloff :'SMOOTH' 14. bpy.types.CompositorNodeKeying.feather_falloffhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.types.CompositorNodeKeying.html#bpy.types.CompositorNodeKeying.feather_falloff :'SMOOTH' 15. bpy.types.BRUSH_OT_curve_preset.shapehttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.ops.brush.html#bpy.ops.brush.curve_preset :'SMOOTH' 16. bpy.types.MESH_OT_rip.proportional_edit_falloffhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.ops.mesh.html#bpy.ops.mesh.rip :'SMOOTH' 17. bpy.types.OBJECT_OT_modifier_add.typehttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.ops.object.html#bpy.ops.object.modifier_add :'SMOOTH' 18. bpy.types.PAINT_OT_brush_select.sculpt_toolhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.ops.paint.html#bpy.ops.paint.brush_select :'SMOOTH' 19. bpy.types.SCULPT_OT_brush_stroke.modehttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.ops.sculpt.html#bpy.ops.sculpt.brush_stroke :'SMOOTH' 20. bpy.types.TRANSFORM_OT_mirror.proportional_edit_falloffhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.ops.transform.html#bpy.ops.transform.mirror :'SMOOTH' 21. bpy.types.TRANSFORM_OT_push_pull.proportional_edit_falloffhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.ops.transform.html#bpy.ops.transform.push_pull :'SMOOTH' 22. bpy.types.TRANSFORM_OT_resize.proportional_edit_falloffhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.ops.transform.html#bpy.ops.transform.resize :'SMOOTH' 23. bpy.types.TRANSFORM_OT_rotate.proportional_edit_falloffhttp://www.blender.org/documentation/blender_python_api_2_66_release/bpy.ops.transform.html#bpy.ops.transform.rotate :'SMOOTH' 24.
Re: [Bf-committers] Regarding sticky coordinates removal from blender
On Sat, Sep 22, 2012 at 9:03 AM, Campbell Barton ideasma...@gmail.com wrote: Committed a material option so UV interpolation is calculated using the same method that sticky used, r50806. - see UV Project material option. This fixes the nasty errors you pointed out. Now blender crashes on loading the same file ( http://www.pasteall.org/blend/16548 ). Not sure about specific revision, but this file works well with RC1 (r50696). Crashlog: http://www.pasteall.org/35469 ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
[Bf-committers] Regarding sticky coordinates removal from blender
Why sticky coordinates were removed from blender? The original comment says that this feature was unavailable from blender UI, but in reality the only part of blender without support of sticky coordinates was cycles. This feature was quite popular since Andrew Price created a tutorial about camera mapping at http://www.blenderguru.com/videos/camera-mapping/ . Not speaking of BCON4, but at this point people would loose all the data about sticky mapping in their blend files. I hope r50789, r50790 and 50791 will be reverted or fixed some other way as soon as possible. Cheers Sv. Lockal ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Regarding sticky coordinates removal from blender
Project from view ignores the scale and aspect of camera. Additional uv tweaking is needed to match the scale of original image. The other potential replacement could be adding and applying UvProject modifier on the special uv layer, however it distorts uvs in perspective mode. Also it doesn't take image aspect into account (default aspect is (1, 1)). And even after fixing distortion in uvproject modifier there are still problems: 1) No replacement in do_versions provided 2) No changes in documentation and release notes 3) Even then Spacebar menu - Add sticky is easier than going to modifiers panel, adding Uv project modifier, setting image, setting aspect, setting camera and clicking apply after each geometry change. On Fri, Sep 21, 2012 at 9:32 PM, Nate Wiebe natewieb...@gmail.com wrote: Unless I'm missing out on something, using project from view uvs is a better solution and works with cycles. ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] Regarding sticky coordinates removal from blender
On Sat, Sep 22, 2012 at 2:34 AM, Campbell Barton ideasma...@gmail.com wrote: Can you expand on this? - not sure what you mean. Ok, Project From View has an option to correct aspect, so it's not so bad. However, UV projection produces distorted maps, see http://www.pasteall.org/pic/show.php?id=38001 (blend file: http://www.pasteall.org/blend/16548) Such mesh was created only to demonstrate exaggerated distortions, but those exist for any non-flat mesh in perspective mode. Project from view and Uv project work almost perfect in orthographic mode (there are some distortion for overlapping faces which I don't take into account), but both of them produce distorted uv maps for non-flat meshes in perspective mode. On the other hand, sticky produces clean image like if it was composited over the 3d image. Adding an option to use the scenes aspect can be done easily, though it does create a tricky dependency (changing scene aspect would need to update modifiers). New options for object modifiers are always welcome :)! such a tool can be added as an operator accessible from C, or a macro / py script. New tools are also welcome! Err, actually this would be rather old tool. Also the same tool could be used in do_versions to convert old sticky coordinate setting to uv maps (if it is even possible, see the image above) -- Sv. Lockal ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] 2.63a bugfix relerase - rev:dev mapping
r46116 (basically unicode fix, so not very important) introduced a more obvious problem with word selection using ctrl+left or ctrl+right. This problem was fixed in r46416. So I think it would be better to apply both r46116 and r46416 (if it is possible) or do not apply any of them. 2012/5/7 Campbell Barton ideasma...@gmail.com: Heres a list of fixes to include in 2.63a - by developer, Id like to know if there are any missing of that should not be included. alexk: 46172 aligorith: 46072, 46077, 46152, 46158, 46280, 46308, 46316, 46342 46345, 46342, 46338, 46336 bjornmose: 46004 blendix: 46117, 46120, 46125, 46141, 46142, 46156, 46159, 46160, 46179, 46180, 46181, 46183, 46192, 46194, 46196, 46205, 46206, 46213, 46214, 46215, 46224, 46225, 46226, 46231, 46232, 46233, 46234, 46241, 46246, 46250, 46260, 46261, 46264, 46265, 46273, 46289, 46310, 46311, 46327 campbellbarton: 46003, 46005, 46014, 46015, 46016, 46095, 46127, 46131, 46136, 46184, 46277, 46278, 46282, 46290, 46294, 46346, 46347, 46361, 46362, 46363 dingto: 46043, 46093 gsrb3d: 46253 kanttori: 46197 lockal: 46116 lukastoenne: 46138, 46222 moguri: 46085 mont29: 46149, 46155, 46341 nazgul: 46027, 46028, 46039, 46140, 46143, 46148, 46157, 46178, 46227, 46229, 46230, 46235, 46236, 46269 nexyon: 46035, 46036, 46305 psy-fi: 46228 scourage: 46091 --- up until r46363 For original list see: http://wiki.blender.org/index.php/Dev:Ref/Release_Notes/2.63/Bug_Fixes#Fixes_since_2.63_.28for_bugfix_release.29 ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] PVS-Studio Static Analysis
I should mention that PVS-Studio contains clang for C++ parsing and preprocessing. As far I can see they have reimplemented some of the clang features (missing in vc++) and have added their own diagnosis patterns. The main feature is visual studio integration, which allows to enable/disable diagnosis options and mark false positives right inside visual studio using GUI. The drawback is impossibility of using it even with VC++ Express Edition (this version does not support extension packages) and of course with non-windows systems. The price of €3500/year also worries me. Be sure not to lock in to a proprietary vendor when the license expires. so basically Andrey Karpov is selling better version of Clang (at least better than native vc++ compiler analyser). But remember 3DMagix and IllusionMage? Of course PVS-Studio is NOT a such scam, but only because Clang is under BSD license and not GPL. The problem is PVS-Studio have never returned a single line of code back to the Clang SVN. As for me I do not support such kind of business. 25 апреля 2012 г. 9:44 пользователь Campbell Barton ideasma...@gmail.com написал: for obvious things they mostly find the same issues (even same false positives), but each have a handful that are unique. I've ran blender through cppcheck, splint, sparse and clang-static-checler. the problem is that once you wade through the error logs (mainly false positives), and fixed the actual bugs... Running a second time gives you only the false positives again. If some new bug is added to the source you still needed to read over the false positives (unless your memory is really good). long term we need to have a way to notify us when new errors are added. On Wed, Apr 25, 2012 at 9:30 AM, Nicholas Bishop nicholasbis...@gmail.com wrote: Not necessarily; different static analyzers can detect different types of potential problems. The PVS analysis contains some interesting things like the Misprint in a homogeneous code block section that I don't think clang's analyzer does. On Tue, Apr 24, 2012 at 7:20 PM, Tom M letter...@gmail.com wrote: We have a page with generated CLang static analysis, http://clang.blenderheads.org/trunk/ It probably shows the same bugs as PVS-Studio does. LetterRip On Tue, Apr 24, 2012 at 4:15 PM, Nicholas Bishop nicholasbis...@gmail.com wrote: I think some of these have been fixed already in recent commits from Campbell. On Tue, Apr 24, 2012 at 7:11 PM, Jason Wilkins jason.a.wilk...@gmail.com wrote: http://www.viva64.com/en/b/0145/#ID0EO3BK It appears that Andrey Karpov has done an analysis of Blender source code using his PVS-Studio tool. He did this just yesterday, so I assume the problems he found are still in the source. He offers free licenses to open source project members (3500 euro software otherwise, wow). I was thinking of investigating the problems he found and seeing if I could fix them. ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers -- - Campbell ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers ___ Bf-committers mailing list Bf-committers@blender.org http://lists.blender.org/mailman/listinfo/bf-committers
Re: [Bf-committers] [Bf-blender-cvs] SVN commit: /data/svn/bf-blender [43733] trunk/blender/source/blender/ blenlib/intern/math_matrix.c: Fix orthogonality check for mat3 and mat4
Sorry for double posting, I'm not sure if the previous mail got to the list.
Old behavior:
Matrix(((0, 0, 10), (0, 20, 0), (0, 0, 0))).is_orthogonal returned
true, but this matrix is not orthogonal
Matrix(((0, 0, 1, 42), (0, 1, 0, 0x42), (0, 0, 0, 100500), (-42, 42,
0xDEAD, 0))).is_orthogonal also returned true (but this matrix is not
orthogonal)
So as you can see m3 version completely ignored the main diagonal and
m4 version also ignored 4-th column and 4-th row. Now it works as it
described in Wikipedia and Wolfram MathWorld.
At this moment orthogonality check is being used only one time in
blender (in draw_manipulator_rotate), and this one case seems to be a
real orthogonality check.
Also it should not be a big problem with this 1, because floatval -
intval = floatval - (float)intval in C.
- Sv. Lockal
2012/1/26 Campbell Barton ideasma...@gmail.com:
Can you give an example as to what case this fixes?
On Fri, Jan 27, 2012 at 4:11 AM, Sv. Lockal lockals...@gmail.com wrote:
Revision: 43733
http://projects.blender.org/scm/viewvc.php?view=revroot=bf-blenderrevision=43733
Author: lockal
Date: 2012-01-26 17:11:43 + (Thu, 26 Jan 2012)
Log Message:
---
Fix orthogonality check for mat3 and mat4
Modified Paths:
--
trunk/blender/source/blender/blenlib/intern/math_matrix.c
Modified: trunk/blender/source/blender/blenlib/intern/math_matrix.c
===
--- trunk/blender/source/blender/blenlib/intern/math_matrix.c 2012-01-26
17:03:30 UTC (rev 43732)
+++ trunk/blender/source/blender/blenlib/intern/math_matrix.c 2012-01-26
17:11:43 UTC (rev 43733)
@@ -778,32 +778,38 @@
mul_v3_fl(mat[2], size[2]);
}
-int is_orthogonal_m3(float mat[][3])
+int is_orthogonal_m3(float m[][3])
{
- if (fabsf(dot_v3v3(mat[0], mat[1])) 1.5f * FLT_EPSILON)
- return 0;
+ int i, j;
- if (fabsf(dot_v3v3(mat[1], mat[2])) 1.5f * FLT_EPSILON)
- return 0;
+ for (i = 0; i 3; i++) {
+ for (j = 0; j i; j++) {
+ if (fabsf(dot_v3v3(m[i], m[j])) 1.5f * FLT_EPSILON)
+ return 0;
+ }
- if (fabsf(dot_v3v3(mat[0], mat[2])) 1.5f * FLT_EPSILON)
- return 0;
-
- return 1;
+ if (fabsf(dot_v3v3(m[i], m[i]) - 1) 1.5f * FLT_EPSILON)
+ return 0;
+ }
+
+ return 1;
}
-int is_orthogonal_m4(float mat[][4])
+int is_orthogonal_m4(float m[][4])
{
- if (fabsf(dot_v3v3(mat[0], mat[1])) 1.5f * FLT_EPSILON)
- return 0;
+ int i, j;
- if (fabsf(dot_v3v3(mat[1], mat[2])) 1.5f * FLT_EPSILON)
- return 0;
+ for (i = 0; i 4; i++) {
+ for (j = 0; j i; j++) {
+ if (fabsf(dot_vn_vn(m[i], m[j], 4)) 1.5f * FLT_EPSILON)
+ return 0;
+ }
- if (fabsf(dot_v3v3(mat[0], mat[2])) 1.5f * FLT_EPSILON)
- return 0;
-
- return 1;
+ if (fabsf(dot_vn_vn(m[i], m[i], 4) - 1) 1.5f * FLT_EPSILON)
+ return 0;
+ }
+
+ return 1;
}
void normalize_m3(float mat[][3])
___
Bf-blender-cvs mailing list
bf-blender-...@blender.org
http://lists.blender.org/mailman/listinfo/bf-blender-cvs
--
- Campbell
___
Bf-committers mailing list
Bf-committers@blender.org
http://lists.blender.org/mailman/listinfo/bf-committers
